3d9ee7d24b
ctor_cmp had an ineffective comparison of addresses in an attempt to ensure sort stability. Comparing the addresses passed to the comparison function can't work since those addresses may be from an array that is already perturbed by qsort. * ldctor.h (struct set_element): Make next field a union, adding idx field. * ldctor.c (ctor_cmp): Dereference pointer and lose unnecessary const. Replace final sort on pointer value with final sort on idx. (ldctor_add_set_entry): Adjust next field access. (ldctor_build_sets): Likewise. Set u.idx field for sort.
63 lines
2.0 KiB
C
63 lines
2.0 KiB
C
/* ldctor.h - linker constructor support
|
|
Copyright (C) 1991-2019 Free Software Foundation, Inc.
|
|
|
|
This file is part of the GNU Binutils.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
|
MA 02110-1301, USA. */
|
|
|
|
#ifndef LDCTOR_H
|
|
#define LDCTOR_H
|
|
|
|
/* List of statements needed to handle constructors */
|
|
extern lang_statement_list_type constructor_list;
|
|
|
|
/* Whether the constructors should be sorted. Note that this is
|
|
global for the entire link; we assume that there is only a single
|
|
CONSTRUCTORS command in the linker script. */
|
|
extern bfd_boolean constructors_sorted;
|
|
|
|
/* We keep a list of these structures for each set we build. */
|
|
|
|
struct set_info {
|
|
struct set_info *next; /* Next set. */
|
|
struct bfd_link_hash_entry *h; /* Hash table entry. */
|
|
bfd_reloc_code_real_type reloc; /* Reloc to use for an entry. */
|
|
size_t count; /* Number of elements. */
|
|
struct set_element *elements; /* Elements in set. */
|
|
};
|
|
|
|
struct set_element {
|
|
union {
|
|
struct set_element *next; /* Next element. */
|
|
long idx;
|
|
} u;
|
|
const char *name; /* Name in set (may be NULL). */
|
|
asection *section; /* Section of value in set. */
|
|
bfd_vma value; /* Value in set. */
|
|
};
|
|
|
|
/* The sets we have seen. */
|
|
|
|
extern struct set_info *sets;
|
|
|
|
extern void ldctor_add_set_entry
|
|
(struct bfd_link_hash_entry *, bfd_reloc_code_real_type, const char *,
|
|
asection *, bfd_vma);
|
|
extern void ldctor_build_sets
|
|
(void);
|
|
|
|
#endif
|