binutils-gdb/gdb/gdbserver
Simon Marchi 466eeceef4 lwp_info: Make the arch code free arch_lwp_info
I have the goal of "poisoning" the XNEW/xfree-family of functions, so
that we catch their usages with non-POD types.  A few things need to be
fixed in the mean time, this is one.

The common lwp code in linux-nat.c and gdbserver/linux-low.c xfrees the
private lwp data of type arch_lwp_info.  However, that type is opaque
from its point of view, as its defined differently in each arch-specific
implementation.  This trips on the std::is_pod<T> check, since the
compiler can't tell whether the type is POD or not if it doesn't know
about it.

My initial patch [1] made a class hierarchy with a virtual destructor.
However, as Pedro pointed out, we only have one native architecture at
the time built in gdb and gdbserver, so that's overkill.  Instead, we
can move the responsibility of free'ing arch_lwp_info to the arch code
(which is also the one that allocated it in the first place).  This is
what this patch does.

Also, I had the concern that if we wanted to use C++ features in these
structures, we would have a problem with the one-definition rule.
However, since a build will only have one version of arch_lwp_info,
that's not a problem.

There are changes in arch-specific files, I was only able to built-test
this patch with the following cross-compilers:

  aarch64-linux-gnu
  alpha-linux-gnu
  arm-linux-gnueabihf
  hppa-linux-gnu
  m68k-linux-gnu
  mips64el-linux-gnuabi64
  powerpc64-linux-gnu
  s390x-linux-gnu
  sh4-linux-gnu
  sparc64-linux-gnu
  x86_64-linux-gnu
  x86_64-w64-mingw32

A buildbot run didn't find any regression.

[1] https://sourceware.org/ml/gdb-patches/2017-08/msg00255.html

gdb/ChangeLog:

	* linux-nat.h (linux_nat_set_delete_thread): New declaration.
	* linux-nat.c (linux_nat_delete_thread): New variable.
	(lwp_free): Invoke linux_nat_delete_thread if set.
	(linux_nat_set_delete_thread): New function.
	* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Assign
	thread delete callback.
	* arm-linux-nat.c (arm_linux_delete_thread): New function.
	(_initialize_arm_linux_nat): Assign thread delete callback.
	* s390-linux-nat.c (s390_delete_thread): New function.
	(_initialize_s390_nat): Assign thread delete callback.
	* x86-linux-nat.c (x86_linux_add_target): Likewise.
	* nat/aarch64-linux.c (aarch64_linux_delete_thread): New
	function.
	* nat/aarch64-linux.h (aarch64_linux_delete_thread): New
	declaration.
	* nat/x86-linux.c (x86_linux_delete_thread): New function.
	* nat/x86-linux.h (x86_linux_delete_thread): New declaration.

gdb/gdbserver/ChangeLog:

	* linux-aarch64-low.c (the_low_target): Add thread delete
	callback.
	* linux-arm-low.c (arm_delete_thread): New function.
	(the_low_target): Add thread delete callback.
	* linux-bfin-low.c (the_low_target): Likewise.
	* linux-crisv32-low.c (the_low_target): Likewise.
	* linux-low.c (delete_lwp): Invoke delete_thread callback if
	set.
	* linux-low.h (struct linux_target_ops) <delete_thread>: New
	field.
	* linux-m32r-low.c (the_low_target): Add thread delete callback.
	* linux-mips-low.c (mips_linux_delete_thread): New function.
	(the_low_target): Add thread delete callback.
	* linux-ppc-low.c (the_low_target): Likewise.
	* linux-s390-low.c (the_low_target): Likewise.
	* linux-sh-low.c (the_low_target): Likewise.
	* linux-tic6x-low.c (the_low_target): Likewise.
	* linux-tile-low.c (the_low_target): Likewise.
	* linux-x86-low.c (the_low_target): Likewise.
	* linux-xtensa-low.c (the_low_target): Likewise.
2017-10-12 16:48:22 -04:00
..
.gitignore
ChangeLog lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
Makefile.in Introduce gdb_tilde_expand 2017-10-04 01:57:29 -04:00
README
acinclude.m4
aclocal.m4
ax.c Constify unpack_varlen_hex & fix fallout 2017-09-29 17:15:36 +01:00
ax.h Constify unpack_varlen_hex & fix fallout 2017-09-29 17:15:36 +01:00
config.in GDBserver self tests 2017-08-18 09:20:43 +01:00
configure GDBserver self tests 2017-08-18 09:20:43 +01:00
configure.ac GDBserver self tests 2017-08-18 09:20:43 +01:00
configure.srv S390: Add guarded-storage register support to gdbserver 2017-09-25 16:02:23 +02:00
debug.c
debug.h
dll.c
dll.h
event-loop.c
event-loop.h
fork-child.c
gdb_proc_service.h
gdbreplay.c
gdbthread.h Use "switch_to_thread" more thoroughly on gdbserver 2017-09-26 12:50:25 -04:00
hostio-errno.c
hostio.c
hostio.h
i387-fp.c
i387-fp.h
inferiors.c Extend "set cwd" to work on gdbserver 2017-10-04 02:01:45 -04:00
inferiors.h gdbserver: Remove thread_to_gdb_id 2017-09-15 18:02:51 +02:00
linux-aarch32-low.c
linux-aarch32-low.h
linux-aarch64-ipa.c
linux-aarch64-low.c lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
linux-amd64-ipa.c Convert amd64-linux target descriptions 2017-09-05 09:54:54 +01:00
linux-arm-low.c lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
linux-bfin-low.c lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
linux-cris-low.c
linux-crisv32-low.c lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
linux-i386-ipa.c [GDBserver] Use pre-generated tdesc as test 2017-09-05 09:54:53 +01:00
linux-ia64-low.c
linux-low.c lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
linux-low.h lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
linux-m32r-low.c lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
linux-m68k-low.c
linux-mips-low.c lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
linux-nios2-low.c
linux-ppc-ipa.c
linux-ppc-low.c lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
linux-ppc-tdesc.h
linux-s390-ipa.c
linux-s390-low.c lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
linux-s390-tdesc.h S390: Add guarded-storage register support to gdbserver 2017-09-25 16:02:23 +02:00
linux-sh-low.c lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
linux-sparc-low.c
linux-tic6x-low.c lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
linux-tile-low.c lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
linux-x86-low.c lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
linux-x86-tdesc-selftest.c Add selftests run filtering 2017-09-16 14:06:03 +02:00
linux-x86-tdesc.c Convert the rest x86 target descriptions 2017-09-05 09:54:54 +01:00
linux-x86-tdesc.h Convert amd64-linux target descriptions 2017-09-05 09:54:54 +01:00
linux-xtensa-low.c lwp_info: Make the arch code free arch_lwp_info 2017-10-12 16:48:22 -04:00
lynx-i386-low.c nto & lynx x86: call init_target_desc 2017-10-02 11:00:30 +02:00
lynx-low.c gdbserver: Remove thread_to_gdb_id 2017-09-15 18:02:51 +02:00
lynx-low.h
lynx-ppc-low.c
mem-break.c Constify unpack_varlen_hex & fix fallout 2017-09-29 17:15:36 +01:00
mem-break.h Constify unpack_varlen_hex & fix fallout 2017-09-29 17:15:36 +01:00
notif.c
notif.h
nto-low.c gdbserver: Remove thread_to_gdb_id 2017-09-15 18:02:51 +02:00
nto-low.h
nto-x86-low.c nto & lynx x86: call init_target_desc 2017-10-02 11:00:30 +02:00
proc-service.c gdbserver/libthread_db: Don't ignore memory reading failures 2017-09-29 13:10:39 +01:00
proc-service.list
regcache.c Use std::vector on tdesc->reg_defs (gdbserver/tdesc.h) 2017-09-15 23:51:33 -04:00
regcache.h
remote-utils.c Constify unpack_varlen_hex & fix fallout 2017-09-29 17:15:36 +01:00
remote-utils.h Constify unpack_varlen_hex & fix fallout 2017-09-29 17:15:36 +01:00
server.c Extend "set cwd" to work on gdbserver 2017-10-04 02:01:45 -04:00
server.h
spu-low.c
symbol.c
target.c Use "switch_to_thread" more thoroughly on gdbserver 2017-09-26 12:50:25 -04:00
target.h Add thread_handle_to_thread_info support for remote targets 2017-09-21 11:49:47 -07:00
tdesc.c Use std::vector on tdesc->reg_defs (gdbserver/tdesc.h) 2017-09-15 23:51:33 -04:00
tdesc.h Use std::vector on tdesc->reg_defs (gdbserver/tdesc.h) 2017-09-15 23:51:33 -04:00
thread-db.c Fix gdbserver regression exposed by gdb.threads/multi-create-ns-info-thr.exp 2017-09-29 13:06:34 +01:00
tracepoint.c Constify unpack_varlen_hex & fix fallout 2017-09-29 17:15:36 +01:00
tracepoint.h
utils.c
utils.h
win32-arm-low.c
win32-i386-low.c gdbserver x86 on win32: call init_target_desc 2017-09-22 16:51:55 +02:00
win32-low.c Fix GDB build under msys+mingw gcc 32bit 2017-10-06 11:44:54 +01:00
win32-low.h
wincecompat.c
wincecompat.h
x86-low.c
x86-low.h
xtensa-xtregs.c

README

		   README for GDBserver & GDBreplay
		    by Stu Grossman and Fred Fish

Introduction:

This is GDBserver, a remote server for Un*x-like systems.  It can be used to
control the execution of a program on a target system from a GDB on a different
host.  GDB and GDBserver communicate using the standard remote serial protocol
implemented in remote.c, and various *-stub.c files.  They communicate via
either a serial line or a TCP connection.

For more information about GDBserver, see the GDB manual.

Usage (server (target) side):

First, you need to have a copy of the program you want to debug put onto
the target system.  The program can be stripped to save space if needed, as
GDBserver doesn't care about symbols.  All symbol handling is taken care of by
the GDB running on the host system.

To use the server, you log on to the target system, and run the `gdbserver'
program.  You must tell it (a) how to communicate with GDB, (b) the name of
your program, and (c) its arguments.  The general syntax is:

	target> gdbserver COMM PROGRAM [ARGS ...]

For example, using a serial port, you might say:

	target> gdbserver /dev/com1 emacs foo.txt

This tells GDBserver to debug emacs with an argument of foo.txt, and to
communicate with GDB via /dev/com1.  GDBserver now waits patiently for the
host GDB to communicate with it.

To use a TCP connection, you could say:

	target> gdbserver host:2345 emacs foo.txt

This says pretty much the same thing as the last example, except that we are
going to communicate with the host GDB via TCP.  The `host:2345' argument means
that we are expecting to see a TCP connection from `host' to local TCP port
2345.  (Currently, the `host' part is ignored.)  You can choose any number you
want for the port number as long as it does not conflict with any existing TCP
ports on the target system.  This same port number must be used in the host
GDBs `target remote' command, which will be described shortly.  Note that if
you chose a port number that conflicts with another service, GDBserver will
print an error message and exit.

On some targets, GDBserver can also attach to running programs.  This is
accomplished via the --attach argument.  The syntax is:

	target> gdbserver --attach COMM PID

PID is the process ID of a currently running process.  It isn't necessary
to point GDBserver at a binary for the running process.

Usage (host side):

You need an unstripped copy of the target program on your host system, since
GDB needs to examine it's symbol tables and such.  Start up GDB as you normally
would, with the target program as the first argument.  (You may need to use the
--baud option if the serial line is running at anything except 9600 baud.)
Ie: `gdb TARGET-PROG', or `gdb --baud BAUD TARGET-PROG'.  After that, the only
new command you need to know about is `target remote'.  It's argument is either
a device name (usually a serial device, like `/dev/ttyb'), or a HOST:PORT
descriptor.  For example:

	(gdb) target remote /dev/ttyb

communicates with the server via serial line /dev/ttyb, and:

	(gdb) target remote the-target:2345

communicates via a TCP connection to port 2345 on host `the-target', where
you previously started up GDBserver with the same port number.  Note that for
TCP connections, you must start up GDBserver prior to using the `target remote'
command, otherwise you may get an error that looks something like
`Connection refused'.

Building GDBserver:

The supported targets as of November 2006 are:
	arm-*-linux*
	bfin-*-uclinux
	bfin-*-linux-uclibc
	crisv32-*-linux*
	cris-*-linux*
	i[34567]86-*-cygwin*
	i[34567]86-*-linux*
	i[34567]86-*-mingw*
	ia64-*-linux*
	m32r*-*-linux*
	m68*-*-linux*
	m68*-*-uclinux*
	mips*64*-*-linux*
	mips*-*-linux*
	powerpc[64]-*-linux*
	s390[x]-*-linux*
	sh-*-linux*
	spu*-*-*
	x86_64-*-linux*

Configuring GDBserver you should specify the same machine for host and
target (which are the machine that GDBserver is going to run on.  This
is not the same as the machine that GDB is going to run on; building
GDBserver automatically as part of building a whole tree of tools does
not currently work if cross-compilation is involved (we don't get the
right CC in the Makefile, to start with)).

Building GDBserver for your target is very straightforward.  If you build
GDB natively on a target which GDBserver supports, it will be built
automatically when you build GDB.  You can also build just GDBserver:

	% mkdir obj
	% cd obj
	% path-to-gdbserver-sources/configure
	% make

If you prefer to cross-compile to your target, then you can also build
GDBserver that way.  In a Bourne shell, for example:

	% export CC=your-cross-compiler
	% path-to-gdbserver-sources/configure your-target-name
	% make

Using GDBreplay:

A special hacked down version of GDBserver can be used to replay remote
debug log files created by GDB.  Before using the GDB "target" command to
initiate a remote debug session, use "set remotelogfile <filename>" to tell
GDB that you want to make a recording of the serial or tcp session.  Note
that when replaying the session, GDB communicates with GDBreplay via tcp,
regardless of whether the original session was via a serial link or tcp.

Once you are done with the remote debug session, start GDBreplay and
tell it the name of the log file and the host and port number that GDB
should connect to (typically the same as the host running GDB):

	$ gdbreplay logfile host:port

Then start GDB (preferably in a different screen or window) and use the
"target" command to connect to GDBreplay:

	(gdb) target remote host:port

Repeat the same sequence of user commands to GDB that you gave in the
original debug session.  GDB should not be able to tell that it is talking
to GDBreplay rather than a real target, all other things being equal.  Note
that GDBreplay echos the command lines to stderr, as well as the contents of
the packets it sends and receives.  The last command echoed by GDBreplay is
the next command that needs to be typed to GDB to continue the session in
sync with the original session.