OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR tree-optimization/92818 (Typo in vec_perm -> bit_insert pattern)

Browse Source 
2019-12-05  Richard Biener  <rguenther@suse.de>

	PR middle-end/92818
	* tree-ssa-forwprop.c (simplify_vector_constructor): Improve
	heuristics on what don't care element to choose.
	* match.pd (VEC_PERM_EXPR -> BIT_INSERT_EXPR): Fix typo.

	* gcc.target/i386/pr92818.c: New testcase.

From-SVN: r278998
This commit is contained in:
Richard Biener 2019-12-05 13:02:57 +00:00 committed by Richard Biener
parent f1355c8dda
commit b0a71a184c
5 changed files with 32 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gcc/ChangeLog
View File

@ -1,3 +1,10 @@
2019-12-05 Richard Biener <rguenther@suse.de>
PR middle-end/92818
* tree-ssa-forwprop.c (simplify_vector_constructor): Improve
heuristics on what don't care element to choose.
* match.pd (VEC_PERM_EXPR -> BIT_INSERT_EXPR): Fix typo.
2019-12-05 Martin Liska <mliska@suse.cz>
PR gcov-profile/92817

2
gcc/match.pd
View File

@ -6049,7 +6049,7 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
break;
if (at < encoded_nelts && sel.series_p (at + 1, 1, at + 1, 1))
{
if (known_lt (at, nelts))
if (known_lt (poly_uint64 (sel[at]), nelts))
ins = fold_read_from_vector (cop0, sel[at]);
else
ins = fold_read_from_vector (cop1, sel[at] - nelts);

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2019-12-05 Richard Biener <rguenther@suse.de>
PR middle-end/92818
* gcc.target/i386/pr92818.c: New testcase.
2019-12-05 Frederik Harwath <frederik@codesourcery.com>
* gcc.dg/asm-4.c: Skip on target amdgcn-*-*.

14
gcc/testsuite/gcc.target/i386/pr92818.c Normal file
View File

@ -0,0 +1,14 @@
/* { dg-do compile } */
/* { dg-options "-O -mavx2 -fdump-tree-forwprop1" } */
typedef double v4df __attribute__((vector_size (32)));
typedef double v2df __attribute__((vector_size (16)));
v2df
bar (v4df x, double *p)
{
return (v2df) { x[0], *p };
}
/* { dg-final { scan-tree-dump "BIT_INSERT_EXPR" "forwprop1" } } */
/* { dg-final { scan-assembler "movhpd" } } */

7
gcc/tree-ssa-forwprop.c
View File

@ -2265,9 +2265,12 @@ simplify_vector_constructor (gimple_stmt_iterator *gsi)
sel.quick_push (elts[i].second + elts[i].first * refnelts);
/* And fill the tail with "something". It's really don't care,
and ideally we'd allow VEC_PERM to have a smaller destination
vector. */
vector. As heuristic try to preserve a uniform orig[0] which
facilitates later pattern-matching VEC_PERM_EXPR to a
BIT_INSERT_EXPR. */
for (; i < refnelts; ++i)
sel.quick_push (i - elts.length ());
sel.quick_push ((elts[0].second == 0 && elts[0].first == 0
? 0 : refnelts) + i);
vec_perm_indices indices (sel, orig[1] ? 2 : 1, refnelts);
if (!can_vec_perm_const_p (TYPE_MODE (perm_type), indices))
return false;