gcc/gcc
David Malcolm 3064b94272 Make INSN_HAS_LOCATION require an rtx_insn
gcc/
2014-08-28  David Malcolm  <dmalcolm@redhat.com>

	* rtl.h (INSN_HAS_LOCATION): Strengthen param from const_rtx to
	const rtx_insn *.

	* print-rtl.c (print_rtx): Add checked cast to const rtx_insn *
	in invocation of INSN_HAS_LOCATION.

From-SVN: r214700
2014-08-29 00:02:25 +00:00
..
ada Add missing entry 2014-08-26 06:37:51 +00:00
c c-aux-info.c (gen_type): Resize 'buff' from 10 to 23 bytes... 2014-08-27 15:19:54 -06:00
c-family IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
common gcc/ 2014-08-11 11:39:14 +00:00
config altivec.h (vec_xl): New #define. 2014-08-28 21:50:51 +00:00
cp re PR c++/52892 (Function pointer loses constexpr qualification) 2014-08-27 17:03:34 +00:00
doc Use rtx_insn for various target.def hooks 2014-08-27 19:34:13 +00:00
fortran frontend_passes (expr_array): Replace by vec template. 2014-08-26 18:25:49 +00:00
ginclude DR 458 2014-08-14 18:56:10 +00:00
go compiler: Disallow call of *T method using **T variable. 2014-08-27 04:12:50 +00:00
java IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
lto IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
objc
objcp
po
testsuite altivec.h (vec_xl): New #define. 2014-08-28 21:50:51 +00:00
ABOUT-GCC-NLS
acinclude.m4
aclocal.m4
addresses.h
alias.c alias.c: Include rtl-iter.h. 2014-08-28 06:21:44 +00:00
alias.h
alloc-pool.c
alloc-pool.h
asan.c asan.c: strengthen some rtx locals 2014-08-21 20:12:30 +00:00
asan.h asan_emit_stack_protection returns an insn 2014-08-19 19:48:08 +00:00
attribs.c
attribs.h
auto-inc-dec.c auto-inc-dec.c: strengthen various rtx to rtx_insn * 2014-08-21 20:17:15 +00:00
BASE-VER BASE-VER: Change to 5.0.0 2014-08-14 13:58:50 +00:00
basic-block.h inside_basic_block_p requires a const rtx_insn * 2014-08-28 20:35:42 +00:00
bb-reorder.c Remove BB_HEAD, BB_END, BB_HEADER scaffolding 2014-08-26 18:56:58 +00:00
bb-reorder.h
bitmap.c
bitmap.h
bt-load.c bt-load.c: Include rtl-iter.h. 2014-08-28 06:21:50 +00:00
builtin-attrs.def
builtin-types.def
builtins.c Convert nonlocal_goto_handler_labels from an EXPR_LIST to an INSN_LIST 2014-08-28 19:03:22 +00:00
builtins.def
builtins.h builtins.c (c_getstr, [...]): Export. 2014-08-08 09:18:40 +00:00
caller-save.c caller-save.c: Include rtl-iter.h. 2014-08-28 06:21:54 +00:00
calls.c calls.c: Include rtl-iter.h. 2014-08-28 06:21:59 +00:00
calls.h
cfg-flags.def
cfg.c
cfganal.c
cfgbuild.c inside_basic_block_p requires a const rtx_insn * 2014-08-28 20:35:42 +00:00
cfgcleanup.c rtl.h (replace_label_data): Delete. 2014-08-28 06:24:27 +00:00
cfgexpand.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
cfgexpand.h
cfghooks.c
cfghooks.h
cfgloop.c cfgloop.c: Use rtx_insn 2014-08-21 21:08:33 +00:00
cfgloop.h loop-iv.c: Use rtx_insn (also touches cfgloop.h and loop-unroll.c) 2014-08-22 18:12:28 +00:00
cfgloopanal.c cfgloopanal.c: Use rtx_insn 2014-08-21 21:11:30 +00:00
cfgloopmanip.c
cfgrtl.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
cgraph.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
cgraph.h IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
cgraphbuild.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
cgraphclones.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
cgraphunit.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ChangeLog Make INSN_HAS_LOCATION require an rtx_insn 2014-08-29 00:02:25 +00:00
ChangeLog-1997
ChangeLog-1998
ChangeLog-1999
ChangeLog-2000
ChangeLog-2001
ChangeLog-2002
ChangeLog-2003
ChangeLog-2004
ChangeLog-2005
ChangeLog-2006
ChangeLog-2007
ChangeLog-2008
ChangeLog-2009
ChangeLog-2010
ChangeLog-2011
ChangeLog-2012
ChangeLog-2013
ChangeLog.dataflow
ChangeLog.graphite
ChangeLog.lib
ChangeLog.ptr
ChangeLog.tree-ssa
ChangeLog.tuples
cif-code.def
cilk-builtins.def
cilk-common.c
cilk.h
cilkplus.def
collect2-aix.c
collect2-aix.h
collect2.c
collect2.h
collect-utils.c
collect-utils.h
combine-stack-adj.c combine-stack-adj.c: Include rtl-iter.h. 2014-08-28 06:22:16 +00:00
combine.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
common.md
common.opt common.opt: Make the ISL AST generator to be the main code generator of Graphite. 2014-08-16 21:18:24 +00:00
compare-elim.c compare-elim.c: Use rtx_insn 2014-08-22 00:32:20 +00:00
conditions.h
config.build
config.gcc re PR other/62248 (Configure error with --with-fpu=fp-armv8) 2014-08-27 12:35:28 +00:00
config.host
config.in configure.ac: Eliminate ClooG installation dependency. 2014-08-18 15:42:11 +00:00
configure Set install_gold_as_default to no first 2014-08-19 09:23:36 -07:00
configure.ac Set install_gold_as_default to no first 2014-08-19 09:23:36 -07:00
context.c
context.h
convert.c [convert.c] PR 61876: Guard transformation to lrint by -fno-math-errno. 2014-08-05 09:52:21 +00:00
convert.h
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
coretypes.h Introduce rtx_expr_list subclass of rtx_def 2014-08-27 20:30:51 +00:00
coverage.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
coverage.h
cppbuiltin.c
cppbuiltin.h
cppdefault.c
cppdefault.h
cprop.c Convert edge_def.insns.r to rtx_insn * 2014-08-25 20:15:36 +00:00
cse.c cse.c (change_cc_mode_args): Delete. 2014-08-28 06:22:42 +00:00
cselib.c rtl.h (for_each_inc_dec_fn): Remove special case for -1. 2014-08-28 06:24:36 +00:00
cselib.h cselib (also touches sched-deps.c) 2014-08-26 20:45:09 +00:00
cstamp-h.in
data-streamer-in.c data-streamer.h (streamer_string_index, [...]): Remove. 2014-08-15 07:51:35 +00:00
data-streamer-out.c data-streamer.h (streamer_string_index, [...]): Remove. 2014-08-15 07:51:35 +00:00
data-streamer.c
data-streamer.h data-streamer.h (streamer_string_index, [...]): Remove. 2014-08-15 07:51:35 +00:00
DATESTAMP Daily bump. 2014-08-28 00:16:44 +00:00
dbgcnt.c
dbgcnt.def
dbgcnt.h
dbxout.c Debug hooks: use rtx_insn and rtx_code_label 2014-08-21 08:20:43 +00:00
dbxout.h
dce.c dce.c: Use rtx subclasses 2014-08-22 14:09:42 +00:00
dce.h
ddg.c ddg.c (walk_mems_2, [...]): Delete. 2014-08-28 06:22:51 +00:00
ddg.h ddg: Use rtx_insn 2014-08-22 14:13:22 +00:00
debug.c Debug hooks: use rtx_insn and rtx_code_label 2014-08-21 08:20:43 +00:00
debug.h Debug hooks: use rtx_insn and rtx_code_label 2014-08-21 08:20:43 +00:00
defaults.h
DEV-PHASE
df-core.c Remove DF_REF_INSN scaffolding 2014-08-26 20:39:42 +00:00
df-problems.c df-problems.c: Include rtl-iter.h. 2014-08-28 06:22:56 +00:00
df-scan.c Remove DF_REF_INSN scaffolding 2014-08-26 20:39:42 +00:00
df.h Remove DF_REF_INSN scaffolding 2014-08-26 20:39:42 +00:00
dfp.c
dfp.h
diagnostic-color.c
diagnostic-color.h
diagnostic-core.h
diagnostic.c re PR fortran/44054 (Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color) 2014-08-21 00:27:25 +00:00
diagnostic.def
diagnostic.h re PR fortran/44054 (Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color) 2014-08-21 00:27:25 +00:00
dojump.c
dominance.c remove pointer-set.[ch] 2014-08-07 20:52:50 +00:00
domwalk.c
domwalk.h
double-int.c
double-int.h
dse.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
dumpfile.c
dumpfile.h
dwarf2asm.c
dwarf2asm.h
dwarf2cfi.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
dwarf2out.c dwarf2out.c (resolve_one_addr): Remove unused data parameter. 2014-08-28 06:23:09 +00:00
dwarf2out.h dwarf2out.h (dwarf2out_decl): Remove prototype. 2014-08-26 22:57:45 +00:00
emit-rtl.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
emit-rtl.h Use rtx subclasses in more places in reorg.c 2014-08-28 18:48:00 +00:00
errors.c
errors.h
et-forest.c
et-forest.h
except.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
except.h struct eh_landing_pad_d: field "landing_pad" is an rtx_code_label 2014-08-25 20:07:26 +00:00
exec-tool.in
explow.c explow.c: Use rtx_insn and rtx_code_label 2014-08-22 15:36:14 +00:00
expmed.c expmed.c: Use rtx_insn and rtx_code_label 2014-08-22 15:39:02 +00:00
expmed.h
expr.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
expr.h emit_move et al return rtx_insn * 2014-08-19 20:51:09 +00:00
file-find.c
file-find.h
final.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
fixed-value.c
fixed-value.h
flag-types.h opts.c (common_handle_option): Handle -fsanitize=alignment. 2014-08-01 09:52:43 +02:00
flags.h
fold-const.c fold-const.c (tree_swap_operands_p): Put all constants last... 2014-08-15 11:42:01 +00:00
fold-const.h
fp-test.c
FSFChangeLog
FSFChangeLog.10
FSFChangeLog.11
function.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
function.h Convert forced_labels from an EXPR_LIST to an INSN_LIST 2014-08-28 19:05:44 +00:00
fwprop.c fwprop.c: Include rtl-iter.h. 2014-08-28 06:23:26 +00:00
gcc-ar.c
gcc-plugin.h
gcc-symtab.h
gcc.c * gcc.c (do_spec_1): Allocate enough space for saved_suffix. 2014-07-31 16:31:39 -06:00
gcc.h
gcov-counter.def
gcov-dump.c
gcov-io.c
gcov-io.h
gcov-iov.c
gcov-tool.c
gcov.c
gcse.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
gcse.h
gdbasan.in
gdbhooks.py gdbhooks.py: add "break-on-pass" command 2014-08-05 21:01:47 +00:00
gdbinit.in
gen-pass-instances.awk
genattr-common.c
genattr.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
genattrtab.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
genautomata.c define_bypass guard functions take a pair of rtx_insn 2014-08-21 14:01:37 +00:00
gencheck.c
genchecksum.c
gencodes.c
genconditions.c Use rtx_insn internally within generated functions 2014-08-21 07:49:28 +00:00
genconfig.c
genconstants.c
genemit.c Use rtx_insn internally within generated functions 2014-08-21 07:49:28 +00:00
genenums.c
genextract.c
genflags.c
gengenrtl.c Introduce rtx_expr_list subclass of rtx_def 2014-08-27 20:30:51 +00:00
gengtype-lex.l
gengtype-parse.c
gengtype-state.c
gengtype.c remove pointer-set.[ch] 2014-08-07 20:52:50 +00:00
gengtype.h
genhooks.c
genmddeps.c
genmddump.c
genmodes.c
genmultilib
genopinit.c
genoutput.c Use rtx_insn internally within generated functions 2014-08-21 07:49:28 +00:00
genpeep.c genpeep.c: peephole requires an rtx_insn 2014-08-22 16:50:40 +00:00
genpreds.c
genrecog.c Use rtx_insn internally within generated functions 2014-08-21 07:49:28 +00:00
gensupport.c
gensupport.h
ggc-common.c
ggc-internal.h
ggc-none.c
ggc-page.c
ggc.h
gimple-builder.c
gimple-builder.h
gimple-expr.c remove pointer-set.[ch] 2014-08-07 20:52:50 +00:00
gimple-expr.h
gimple-fold.c gimple-fold.c (get_maxval_strlen): Add overload wrapping get_maxval_strlen inside a more useful API. 2014-08-27 12:48:23 +00:00
gimple-fold.h gimple-fold.h (gimple_fold_builtin): Remove. 2014-08-04 13:08:34 +00:00
gimple-iterator.c re PR tree-optimization/62112 (Optimize out malloc when block is unused or write-only) 2014-08-21 09:32:21 +00:00
gimple-iterator.h re PR tree-optimization/62112 (Optimize out malloc when block is unused or write-only) 2014-08-21 09:32:21 +00:00
gimple-low.c
gimple-low.h
gimple-pretty-print.c
gimple-pretty-print.h
gimple-ssa-isolate-paths.c re PR c++/60517 (warning/error for taking address of member of a temporary object) 2014-07-31 09:33:58 +00:00
gimple-ssa-strength-reduction.c remove pointer-set.[ch] 2014-08-07 20:52:50 +00:00
gimple-ssa.h convert the rest of the users of pointer_map to hash_map 2014-08-07 10:44:14 +00:00
gimple-streamer-in.c
gimple-streamer-out.c
gimple-streamer.h
gimple-walk.c add a hash_set based on hash_table 2014-08-02 11:23:49 +00:00
gimple-walk.h add a hash_set based on hash_table 2014-08-02 11:23:49 +00:00
gimple.c Added fnspec to internal functions. 2014-08-11 06:06:29 +00:00
gimple.def
gimple.h re PR lto/60449 (Merging function DECLs discards leaf attribute which causes cfg verifier to fail) 2014-08-20 16:47:12 +00:00
gimplify-me.c
gimplify-me.h
gimplify.c re PR middle-end/62092 (libgomp.c++/target-2.C FAIL while compiling for OpenMP 4.0 offload target) 2014-08-15 09:40:03 +02:00
gimplify.h
glimits.h
godump.c add a hash_set based on hash_table 2014-08-02 11:23:49 +00:00
graph.c
graph.h
graphds.c
graphds.h
graphite-blocking.c configure.ac: Eliminate ClooG installation dependency. 2014-08-18 15:42:11 +00:00
graphite-clast-to-gimple.c Replacement of isl_int by isl_val 2014-08-11 15:05:48 +00:00
graphite-clast-to-gimple.h
graphite-dependences.c configure.ac: Eliminate ClooG installation dependency. 2014-08-18 15:42:11 +00:00
graphite-htab.h
graphite-interchange.c configure.ac: Eliminate ClooG installation dependency. 2014-08-18 15:42:11 +00:00
graphite-isl-ast-to-gimple.c configure.ac: Eliminate ClooG installation dependency. 2014-08-18 15:42:11 +00:00
graphite-isl-ast-to-gimple.h
graphite-optimize-isl.c configure.ac: Eliminate ClooG installation dependency. 2014-08-18 15:42:11 +00:00
graphite-poly.c configure.ac: Eliminate ClooG installation dependency. 2014-08-18 15:42:11 +00:00
graphite-poly.h graphite-isl-ast-to-gimple.c: Add a new struct ast_build_info. 2014-08-05 03:41:29 +00:00
graphite-scop-detection.c configure.ac: Eliminate ClooG installation dependency. 2014-08-18 15:42:11 +00:00
graphite-scop-detection.h
graphite-sese-to-poly.c configure.ac: Eliminate ClooG installation dependency. 2014-08-18 15:42:11 +00:00
graphite-sese-to-poly.h
graphite.c configure.ac: Eliminate ClooG installation dependency. 2014-08-18 15:42:11 +00:00
gsstruct.def
gstab.h
gsyms.h
gsyslimits.h
gtm-builtins.def
haifa-sched.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
hard-reg-set.h
hash-map.h convert the rest of the users of pointer_map to hash_map 2014-08-07 10:44:14 +00:00
hash-set.h add a hash_set based on hash_table 2014-08-02 11:23:49 +00:00
hash-table.c
hash-table.h
highlev-plugin-common.h
hooks.c Use rtx_insn for various target.def hooks 2014-08-27 19:34:13 +00:00
hooks.h Use rtx_insn for various target.def hooks 2014-08-27 19:34:13 +00:00
host-default.c
hosthooks-def.h
hosthooks.h
hw-doloop.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
hw-doloop.h NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
hwint.c
hwint.h
ifcvt.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
inchash.c
inchash.h Change inchash to name space. 2014-08-01 02:51:46 +00:00
incpath.c re PR preprocessor/51303 (-Wmissing-include-dirs warnings reported as [enabled by default]) 2014-08-19 22:52:02 +00:00
incpath.h
init-regs.c init-regs.c: Use rtx_insn 2014-08-22 17:42:44 +00:00
input.c input.c (diagnostic_file_cache_fini): Fix typo in comment. 2014-08-15 14:07:19 +00:00
input.h input.h (in_system_header_at): Add comment. 2014-08-15 16:27:38 +00:00
insn-addr.h
insn-notes.def
internal-fn.c internal-fn.c: Use rtx_insn and rtx_code_label 2014-08-22 17:45:22 +00:00
internal-fn.def Move inlining of Asan memory checks to sanopt pass. 2014-08-11 06:12:12 +00:00
internal-fn.h Added fnspec to internal functions. 2014-08-11 06:06:29 +00:00
intl.c
intl.h
ipa-comdats.c
ipa-cp.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ipa-devirt.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ipa-inline-analysis.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ipa-inline-transform.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ipa-inline.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ipa-inline.h
ipa-profile.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ipa-prop.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ipa-prop.h IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ipa-pure-const.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ipa-ref.c
ipa-ref.h
ipa-reference.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ipa-reference.h
ipa-split.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ipa-utils.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ipa-utils.h ipa-utils.h (ipa_polymorphic_call_context): Turn into class; add ctors. 2014-08-16 09:10:23 +00:00
ipa-visibility.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ipa.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
ira-build.c ira: Use rtx_insn in various places 2014-08-22 17:48:40 +00:00
ira-color.c re PR c/61271 (10 * possible coding error with logical not (!)) 2014-08-22 19:40:28 +00:00
ira-conflicts.c ira: Use rtx_insn in various places 2014-08-22 17:48:40 +00:00
ira-costs.c ira: Use rtx_insn in various places 2014-08-22 17:48:40 +00:00
ira-emit.c Remove DF_REF_INSN scaffolding 2014-08-26 20:39:42 +00:00
ira-int.h ira: Use rtx_insn in various places 2014-08-22 17:48:40 +00:00
ira-lives.c Tweak to ira-lives.c 2014-08-27 19:43:12 +00:00
ira.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
ira.h NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
is-a.h Introduce safe_as_a 2014-08-18 19:50:38 +00:00
jump.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
langhooks-def.h
langhooks.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
langhooks.h
LANGUAGES
lcm.c
libfuncs.h
limitx.h
limity.h
lists.c Use rtx_expr_list in various places 2014-08-27 20:40:05 +00:00
lock-and-run.sh
loop-doloop.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
loop-init.c
loop-invariant.c loop-invariant.c: Use rtx_insn in various places 2014-08-22 18:08:51 +00:00
loop-iv.c loop-iv.c (altered_reg_used): Turn from being a for_each_rtx callback to being a function that examines each... 2014-08-28 06:23:47 +00:00
loop-unroll.c loop-unroll.c: Use rtx_insn (also touches basic-block.h) 2014-08-22 18:15:54 +00:00
lower-subreg.c lower-subreg.c (find_decomposable_subregs): Turn from being a for_each_rtx callback to being a function that examines each... 2014-08-28 06:23:58 +00:00
lower-subreg.h
lra-assigns.c lra: use rtx_insn 2014-08-22 18:36:35 +00:00
lra-coalesce.c lra: use rtx_insn 2014-08-22 18:36:35 +00:00
lra-constraints.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
lra-eliminations.c lra: use rtx_insn 2014-08-22 18:36:35 +00:00
lra-int.h lra: use rtx_insn 2014-08-22 18:36:35 +00:00
lra-lives.c lra: use rtx_insn 2014-08-22 18:36:35 +00:00
lra-spills.c re PR c/61271 (10 * possible coding error with logical not (!)) 2014-08-22 19:40:28 +00:00
lra.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
lra.h
lto-cgraph.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
lto-compress.c
lto-compress.h
lto-opts.c lto-streamer.h (lto_write_data): New function. 2014-07-30 12:14:58 +00:00
lto-section-in.c lto-streamer.h (struct lto_input_block): Make it a class with a constructor. 2014-08-08 12:55:31 +00:00
lto-section-names.h
lto-section-out.c lto-streamer.h (struct lto_input_block): Make it a class with a constructor. 2014-08-08 12:55:31 +00:00
lto-streamer-in.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
lto-streamer-out.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
lto-streamer.c
lto-streamer.h lto-streamer.h (struct output_block::symbol): Change from struct symtab_node to plain symtab_node. 2014-08-11 02:10:00 +00:00
lto-wrapper.c
machmode.def
machmode.h
main.c
Makefile.in configure.ac: Eliminate ClooG installation dependency. 2014-08-18 15:42:11 +00:00
mcf.c
mkconfig.sh
mode-classes.def
mode-switching.c mode-switching.c: Use rtx_insn 2014-08-22 18:39:08 +00:00
modulo-sched.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
omega.c
omega.h
omp-builtins.def
omp-low.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
omp-low.h
ONEWS
opt-functions.awk
opt-gather.awk
opt-include.awk
opt-read.awk
optabs.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
optabs.def
optabs.h
optc-gen.awk re PR preprocessor/60975 (-Wvariadic-macros does not print warning) 2014-08-19 22:37:49 +00:00
optc-save-gen.awk
opth-gen.awk re PR preprocessor/60975 (-Wvariadic-macros does not print warning) 2014-08-19 22:37:49 +00:00
opts-common.c re PR c/59304 (#pragma diagnostic pop after warning fails for options unspecified in the command-line and disabled by default) 2014-08-20 12:48:16 +00:00
opts-diagnostic.h
opts-global.c
opts.c opts.c (common_handle_option): Handle -fsanitize=alignment. 2014-08-01 09:52:43 +02:00
opts.h
output.h NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
params.c
params.def Move inlining of Asan memory checks to sanopt pass. 2014-08-11 06:12:12 +00:00
params.h
pass_manager.h
passes.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
passes.def re PR tree-optimization/62081 (ICE: in fix_loop_structure, at loop-init.c:208 with -fno-tree-ch -fno-tree-cselim -fno-tree-dominator-opts -fno-tree-reassoc -fno-tree-sink) 2014-08-14 13:14:24 +00:00
plugin.c
plugin.def
plugin.h
postreload-gcse.c Convert edge_def.insns.r to rtx_insn * 2014-08-25 20:15:36 +00:00
postreload.c postreload.c: Use rtx_insn (also touches rtl.h and cprop.c) 2014-08-22 19:38:50 +00:00
predict.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
predict.def
predict.h predict.*: Use rtx_insn (also touches function.c and config/cris/cris.c) 2014-08-22 19:51:23 +00:00
prefix.c
prefix.h
pretty-print.c
pretty-print.h
print-rtl.c Make INSN_HAS_LOCATION require an rtx_insn 2014-08-29 00:02:25 +00:00
print-rtl.h
print-tree.c
print-tree.h
profile.c
profile.h
read-md.c
read-md.h
read-rtl.c
README.Portability
real.c
real.h
realmpfr.c
realmpfr.h
recog.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
recog.h Use rtx_insn internally within generated functions 2014-08-21 07:49:28 +00:00
ree.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
reg-notes.def
reg-stack.c reg-stack.c: Include rtl-iter.h. 2014-08-28 06:24:03 +00:00
regcprop.c regcprop.c (cprop_find_used_regs_1): Delete. 2014-08-28 06:24:12 +00:00
regcprop.h
reginfo.c reginfo.c: Use rtx_insn (also touches rtl.h) 2014-08-22 20:19:07 +00:00
regrename.c regrename.c: Use rtx_insn 2014-08-22 20:42:50 +00:00
regrename.h du_chain.insn is an rtx_insn 2014-08-25 21:24:13 +00:00
regs.h Remove CALLER_SAVE_PROFITABLE since it is not used at present. 2014-08-24 02:52:46 +00:00
regset.h
regstat.c regstat.c: Use rtx_insn 2014-08-22 20:44:34 +00:00
reload1.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
reload.c reload: Use rtx_insn (also touches caller-save.c and config/arc/arc) 2014-08-22 20:49:31 +00:00
reload.h Use rtx_expr_list in various places 2014-08-27 20:40:05 +00:00
reorg.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
resource.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
resource.h Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
rtl-error.c
rtl-error.h
rtl-iter.h rtl-iter.h: New file. 2014-08-28 06:20:12 +00:00
rtl.c RTL & dwarf2out changes 2014-08-01 02:51:57 +00:00
rtl.def
rtl.h Make INSN_HAS_LOCATION require an rtx_insn 2014-08-29 00:02:25 +00:00
rtlanal.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
rtlhash.c RTL & dwarf2out changes 2014-08-01 02:51:57 +00:00
rtlhash.h RTL & dwarf2out changes 2014-08-01 02:51:57 +00:00
rtlhooks-def.h
rtlhooks.c
sanitizer.def
sbitmap.c
sbitmap.h
sched-deps.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
sched-ebb.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
sched-int.h Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
sched-rgn.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
sched-vis.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
sdbout.c Debug hooks: use rtx_insn and rtx_code_label 2014-08-21 08:20:43 +00:00
sdbout.h
sel-sched-dump.c insn_t becomes an rtx_insn * 2014-08-26 17:42:13 +00:00
sel-sched-dump.h Strengthen haifa_sched_info callbacks and 3 scheduler hooks 2014-08-25 21:19:23 +00:00
sel-sched-ir.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
sel-sched-ir.h NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
sel-sched.c sel-sched.c: Include rtl-iter.h 2014-08-28 06:24:44 +00:00
sel-sched.h
sese.c
sese.h
shrink-wrap.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
shrink-wrap.h Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
signop.h
simplify-rtx.c calls.c (precompute_arguments): Use new SUBREG_PROMOTED_SET instead of SUBREG_PROMOTED_UNSIGNED_SET. 2014-08-08 05:24:12 +00:00
sparseset.c
sparseset.h
sreal.c
sreal.h
ssa-iterators.h
stab.def
stack-ptr-mod.c stack-ptr-mod.c: Use rtx_insn 2014-08-22 21:44:32 +00:00
statistics.c
statistics.h
stmt.c Convert forced_labels from an EXPR_LIST to an INSN_LIST 2014-08-28 19:05:44 +00:00
stmt.h
stor-layout.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
stor-layout.h opts.c (common_handle_option): Handle -fsanitize=alignment. 2014-08-01 09:52:43 +02:00
store-motion.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
streamer-hooks.c
streamer-hooks.h
stringpool.c
stringpool.h
symtab.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
sync-builtins.def
system.h Remove CALLER_SAVE_PROFITABLE since it is not used at present. 2014-08-24 02:52:46 +00:00
target-def.h
target-globals.c
target-globals.h
target-hooks-macros.h
target.def Use rtx_insn for various target.def hooks 2014-08-27 19:34:13 +00:00
target.h
targhooks.c Use rtx_insn for various target.def hooks 2014-08-27 19:34:13 +00:00
targhooks.h Use rtx_insn for various target.def hooks 2014-08-27 19:34:13 +00:00
timevar.c
timevar.def
timevar.h
tlink.c
toplev.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
toplev.h
tracer.c
trans-mem.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
trans-mem.h
tree-affine.c remove pointer-set.[ch] 2014-08-07 20:52:50 +00:00
tree-affine.h convert the rest of the users of pointer_map to hash_map 2014-08-07 10:44:14 +00:00
tree-browser.c
tree-browser.def
tree-call-cdce.c
tree-cfg.c Convert edge_def.insns.r to rtx_insn * 2014-08-25 20:15:36 +00:00
tree-cfg.h
tree-cfgcleanup.c re PR lto/60449 (Merging function DECLs discards leaf attribute which causes cfg verifier to fail) 2014-08-20 16:47:12 +00:00
tree-cfgcleanup.h
tree-chrec.c
tree-chrec.h
tree-complex.c
tree-core.h Added fnspec to internal functions. 2014-08-11 06:06:29 +00:00
tree-data-ref.c re PR tree-optimization/62031 (Different results between O2 and O2 -fpredictive-commoning) 2014-08-15 07:50:40 +00:00
tree-data-ref.h re PR tree-optimization/62031 (Different results between O2 and O2 -fpredictive-commoning) 2014-08-15 07:50:40 +00:00
tree-dfa.c
tree-dfa.h
tree-diagnostic.c
tree-diagnostic.h
tree-dump.c
tree-dump.h
tree-eh.c remove pointer-set.[ch] 2014-08-07 20:52:50 +00:00
tree-eh.h convert many uses of pointer_map to hash_map 2014-08-02 11:34:54 +00:00
tree-emutls.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
tree-hasher.h
tree-if-conv.c
tree-inline.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
tree-inline.h convert many uses of pointer_map to hash_map 2014-08-02 11:34:54 +00:00
tree-into-ssa.c
tree-into-ssa.h
tree-iterator.c
tree-iterator.h
tree-loop-distribution.c configure.ac: Also check for popen. 2014-07-30 18:29:41 +00:00
tree-nested.c Fix invalid gimple made by finalize_nesting_tree_1. 2014-08-25 16:15:49 +00:00
tree-nested.h
tree-nrv.c
tree-object-size.c
tree-object-size.h
tree-outof-ssa.c Convert edge_def.insns.r to rtx_insn * 2014-08-25 20:15:36 +00:00
tree-outof-ssa.h
tree-parloops.c
tree-parloops.h
tree-pass.h re PR tree-optimization/62081 (ICE: in fix_loop_structure, at loop-init.c:208 with -fno-tree-ch -fno-tree-cselim -fno-tree-dominator-opts -fno-tree-reassoc -fno-tree-sink) 2014-08-14 13:14:24 +00:00
tree-phinodes.c
tree-phinodes.h
tree-predcom.c convert the rest of the users of pointer_map to hash_map 2014-08-07 10:44:14 +00:00
tree-pretty-print.c add a hash_set based on hash_table 2014-08-02 11:23:49 +00:00
tree-pretty-print.h
tree-profile.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
tree-scalar-evolution.c remove pointer-set.[ch] 2014-08-07 20:52:50 +00:00
tree-scalar-evolution.h
tree-sra.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
tree-ssa-address.c
tree-ssa-address.h
tree-ssa-alias.c re PR tree-optimization/62112 (Optimize out malloc when block is unused or write-only) 2014-08-21 09:32:21 +00:00
tree-ssa-alias.h re PR tree-optimization/62112 (Optimize out malloc when block is unused or write-only) 2014-08-21 09:32:21 +00:00
tree-ssa-ccp.c gimple-fold.h (gimple_fold_builtin): Remove. 2014-08-04 13:08:34 +00:00
tree-ssa-coalesce.c
tree-ssa-coalesce.h
tree-ssa-copy.c
tree-ssa-copyrename.c
tree-ssa-dce.c
tree-ssa-dom.c Convert tree-ssa-dom to inchash 2014-08-01 02:52:30 +00:00
tree-ssa-dom.h
tree-ssa-dse.c re PR tree-optimization/62112 (Optimize out malloc when block is unused or write-only) 2014-08-21 09:32:21 +00:00
tree-ssa-forwprop.c
tree-ssa-ifcombine.c
tree-ssa-live.c
tree-ssa-live.h
tree-ssa-loop-ch.c
tree-ssa-loop-im.c remove pointer-set.[ch] 2014-08-07 20:52:50 +00:00
tree-ssa-loop-ivcanon.c
tree-ssa-loop-ivopts.c NEXT_INSN and PREV_INSN take a const rtx_insn 2014-08-28 21:29:38 +00:00
tree-ssa-loop-ivopts.h
tree-ssa-loop-manip.c re PR tree-optimization/62070 (ICE: verify_ssa failed) 2014-08-11 10:55:10 +00:00
tree-ssa-loop-manip.h
tree-ssa-loop-niter.c re PR c++/62175 (Internal compiler error in gimplify_modify_expr gimplify.c:4616) 2014-08-26 08:03:32 +00:00
tree-ssa-loop-niter.h
tree-ssa-loop-prefetch.c
tree-ssa-loop-unswitch.c
tree-ssa-loop.c re PR tree-optimization/62081 (ICE: in fix_loop_structure, at loop-init.c:208 with -fno-tree-ch -fno-tree-cselim -fno-tree-dominator-opts -fno-tree-reassoc -fno-tree-sink) 2014-08-14 13:14:24 +00:00
tree-ssa-loop.h
tree-ssa-math-opts.c
tree-ssa-operands.c re PR lto/60449 (Merging function DECLs discards leaf attribute which causes cfg verifier to fail) 2014-08-20 16:47:12 +00:00
tree-ssa-operands.h
tree-ssa-phiopt.c remove pointer-set.[ch] 2014-08-07 20:52:50 +00:00
tree-ssa-phiprop.c
tree-ssa-pre.c ipa-utils.h (ipa_polymorphic_call_context): Turn into class; add ctors. 2014-08-16 09:10:23 +00:00
tree-ssa-propagate.c
tree-ssa-propagate.h
tree-ssa-reassoc.c convert many uses of pointer_map to hash_map 2014-08-02 11:34:54 +00:00
tree-ssa-sccvn.c Convert tree-ssa-sccvn to inchash 2014-08-01 02:52:41 +00:00
tree-ssa-sccvn.h Convert tree-ssa-sccvn to inchash 2014-08-01 02:52:41 +00:00
tree-ssa-sink.c
tree-ssa-strlen.c
tree-ssa-structalias.c tree-ssa-structalias.c (readonly_id): Rename to string_id. 2014-08-15 12:54:28 +00:00
tree-ssa-tail-merge.c Convert tree-ssa-tail-merge to inchash 2014-08-01 02:52:52 +00:00
tree-ssa-ter.c
tree-ssa-ter.h
tree-ssa-threadedge.c add a hash_set based on hash_table 2014-08-02 11:23:49 +00:00
tree-ssa-threadedge.h
tree-ssa-threadupdate.c
tree-ssa-threadupdate.h
tree-ssa-uncprop.c
tree-ssa-uninit.c remove pointer-set.[ch] 2014-08-07 20:52:50 +00:00
tree-ssa.c remove pointer-set.[ch] 2014-08-07 20:52:50 +00:00
tree-ssa.h convert many uses of pointer_map to hash_map 2014-08-02 11:34:54 +00:00
tree-ssanames.c
tree-ssanames.h re PR lto/60449 (Merging function DECLs discards leaf attribute which causes cfg verifier to fail) 2014-08-20 16:47:12 +00:00
tree-stdarg.c
tree-stdarg.h
tree-streamer-in.c
tree-streamer-out.c lto-streamer-out.c (DFS::DFS_write_tree_body): Stream DECL_EXTERNALs in BLOCKs as non-references. 2014-08-19 07:57:44 +00:00
tree-streamer.c
tree-streamer.h
tree-switch-conversion.c
tree-tailcall.c
tree-vect-data-refs.c re PR fortran/62283 (basic-block vectorization fails) 2014-08-28 13:13:45 +00:00
tree-vect-generic.c
tree-vect-loop-manip.c
tree-vect-loop.c re PR c/62073 (Segmentation fault with tree vectorize) 2014-08-11 11:24:35 +00:00
tree-vect-patterns.c
tree-vect-slp.c re PR tree-optimization/62075 (Vectorizer ICE on dolphin) 2014-08-11 14:48:24 +00:00
tree-vect-stmts.c
tree-vectorizer.c
tree-vectorizer.h re PR c/61271 (10 * possible coding error with logical not (!)) 2014-08-26 09:21:18 +00:00
tree-vrp.c
tree.c re PR lto/62190 (LTO DWARF produces __unknown__ type for unsigned int function argument type) 2014-08-20 11:06:48 +00:00
tree.def
tree.h add a hash_set based on hash_table 2014-08-02 11:23:49 +00:00
treestruct.def
tsan.c
tsan.h
tsystem.h
typeclass.h
ubsan.c opts.c (common_handle_option): Handle -fsanitize=alignment. 2014-08-01 09:52:43 +02:00
ubsan.h opts.c (common_handle_option): Handle -fsanitize=alignment. 2014-08-01 09:52:43 +02:00
valtrack.c Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
valtrack.h Work towards NEXT_INSN/PREV_INSN requiring insns as their params 2014-08-28 20:45:40 +00:00
value-prof.c convert the rest of the users of pointer_map to hash_map 2014-08-07 10:44:14 +00:00
value-prof.h
var-tracking.c var-tracking.c (add_uses): Take an rtx rather than an rtx *. 2014-08-28 06:25:05 +00:00
varasm.c varasm.c (compute_reloc_for_rtx_1): Take a const_rtx. 2014-08-28 06:25:18 +00:00
varasm.h
varpool.c IPA C++ refactoring 4/N 2014-08-25 13:01:47 +00:00
vec.c
vec.h
version.c
version.h
vmsdbg.h
vmsdbgout.c Debug hooks: use rtx_insn and rtx_code_label 2014-08-21 08:20:43 +00:00
vtable-verify.c
vtable-verify.h
web.c web.c: Use rtx_insn 2014-08-23 00:59:08 +00:00
wide-int-print.cc
wide-int-print.h
wide-int.cc
wide-int.h * wide-int.h (generic_wide_int): Declare as class instead of struct. 2014-08-16 19:27:54 +00:00
xcoff.h
xcoffout.c
xcoffout.h

Copyright (C) 2000-2014 Free Software Foundation, Inc.

This file is intended to contain a few notes about writing C code
within GCC so that it compiles without error on the full range of
compilers GCC needs to be able to compile on.

The problem is that many ISO-standard constructs are not accepted by
either old or buggy compilers, and we keep getting bitten by them.
This knowledge until now has been sparsely spread around, so I
thought I'd collect it in one useful place.  Please add and correct
any problems as you come across them.

I'm going to start from a base of the ISO C90 standard, since that is
probably what most people code to naturally.  Obviously using
constructs introduced after that is not a good idea.

For the complete coding style conventions used in GCC, please read
http://gcc.gnu.org/codingconventions.html


String literals
---------------

Irix6 "cc -n32" and OSF4 "cc" have problems with constant string
initializers with parens around it, e.g.

const char string[] = ("A string");

This is unfortunate since this is what the GNU gettext macro N_
produces.  You need to find a different way to code it.

Some compilers like MSVC++ have fairly low limits on the maximum
length of a string literal; 509 is the lowest we've come across.  You
may need to break up a long printf statement into many smaller ones.


Empty macro arguments
---------------------

ISO C (6.8.3 in the 1990 standard) specifies the following:

If (before argument substitution) any argument consists of no
preprocessing tokens, the behavior is undefined.

This was relaxed by ISO C99, but some older compilers emit an error,
so code like

#define foo(x, y) x y
foo (bar, )

needs to be coded in some other way.


Avoid unnecessary test before free
----------------------------------

Since SunOS 4 stopped being a reasonable portability target,
(which happened around 2007) there has been no need to guard
against "free (NULL)".  Thus, any guard like the following
constitutes a redundant test:

  if (P)
    free (P);

It is better to avoid the test.[*]
Instead, simply free P, regardless of whether it is NULL.

[*] However, if your profiling exposes a test like this in a
performance-critical loop, say where P is nearly always NULL, and
the cost of calling free on a NULL pointer would be prohibitively
high, consider using __builtin_expect, e.g., like this:

  if (__builtin_expect (ptr != NULL, 0))
    free (ptr);



Trigraphs
---------

You weren't going to use them anyway, but some otherwise ISO C
compliant compilers do not accept trigraphs.


Suffixes on Integer Constants
-----------------------------

You should never use a 'l' suffix on integer constants ('L' is fine),
since it can easily be confused with the number '1'.


			Common Coding Pitfalls
			======================

errno
-----

errno might be declared as a macro.


Implicit int
------------

In C, the 'int' keyword can often be omitted from type declarations.
For instance, you can write

  unsigned variable;

as shorthand for

  unsigned int variable;

There are several places where this can cause trouble.  First, suppose
'variable' is a long; then you might think

  (unsigned) variable

would convert it to unsigned long.  It does not.  It converts to
unsigned int.  This mostly causes problems on 64-bit platforms, where
long and int are not the same size.

Second, if you write a function definition with no return type at
all:

  operate (int a, int b)
  {
    ...
  }

that function is expected to return int, *not* void.  GCC will warn
about this.

Implicit function declarations always have return type int.  So if you
correct the above definition to

  void
  operate (int a, int b)
  ...

but operate() is called above its definition, you will get an error
about a "type mismatch with previous implicit declaration".  The cure
is to prototype all functions at the top of the file, or in an
appropriate header.

Char vs unsigned char vs int
----------------------------

In C, unqualified 'char' may be either signed or unsigned; it is the
implementation's choice.  When you are processing 7-bit ASCII, it does
not matter.  But when your program must handle arbitrary binary data,
or fully 8-bit character sets, you have a problem.  The most obvious
issue is if you have a look-up table indexed by characters.

For instance, the character '\341' in ISO Latin 1 is SMALL LETTER A
WITH ACUTE ACCENT.  In the proper locale, isalpha('\341') will be
true.  But if you read '\341' from a file and store it in a plain
char, isalpha(c) may look up character 225, or it may look up
character -31.  And the ctype table has no entry at offset -31, so
your program will crash.  (If you're lucky.)

It is wise to use unsigned char everywhere you possibly can.  This
avoids all these problems.  Unfortunately, the routines in <string.h>
take plain char arguments, so you have to remember to cast them back
and forth - or avoid the use of strxxx() functions, which is probably
a good idea anyway.

Another common mistake is to use either char or unsigned char to
receive the result of getc() or related stdio functions.  They may
return EOF, which is outside the range of values representable by
char.  If you use char, some legal character value may be confused
with EOF, such as '\377' (SMALL LETTER Y WITH UMLAUT, in Latin-1).
The correct choice is int.

A more subtle version of the same mistake might look like this:

  unsigned char pushback[NPUSHBACK];
  int pbidx;
  #define unget(c) (assert(pbidx < NPUSHBACK), pushback[pbidx++] = (c))
  #define get(c) (pbidx ? pushback[--pbidx] : getchar())
  ...
  unget(EOF);

which will mysteriously turn a pushed-back EOF into a SMALL LETTER Y
WITH UMLAUT.


Other common pitfalls
---------------------

o Expecting 'plain' char to be either sign or unsigned extending.

o Shifting an item by a negative amount or by greater than or equal to
  the number of bits in a type (expecting shifts by 32 to be sensible
  has caused quite a number of bugs at least in the early days).

o Expecting ints shifted right to be sign extended.

o Modifying the same value twice within one sequence point.

o Host vs. target floating point representation, including emitting NaNs
  and Infinities in a form that the assembler handles.

o qsort being an unstable sort function (unstable in the sense that
  multiple items that sort the same may be sorted in different orders
  by different qsort functions).

o Passing incorrect types to fprintf and friends.

o Adding a function declaration for a module declared in another file to
  a .c file instead of to a .h file.