futex: Use futex_top_waiter() in lookup_pi_state()

upstream commit: bd1dbcc67c

No point in open coding the same function again.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Darren Hart <darren@dvhart.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Davidlohr Bueso <davidlohr@hp.com>
Cc: Kees Cook <kees@outflux.net>
Cc: wad@chromium.org
Link: http://lkml.kernel.org/r/20140611204237.092947239@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
This commit is contained in:
Thomas Gleixner 2014-06-11 20:45:39 +00:00 committed by Alibek Omarov
parent 5e3746259e
commit 9e62263a76
1 changed files with 62 additions and 64 deletions

View File

@ -786,21 +786,20 @@ static int
lookup_pi_state(u32 uval, struct futex_hash_bucket *hb,
union futex_key *key, struct futex_pi_state **ps)
{
struct futex_q *match = futex_top_waiter(hb, key);
struct futex_pi_state *pi_state = NULL;
struct futex_q *this, *next;
struct task_struct *p;
pid_t pid = uval & FUTEX_TID_MASK;
plist_for_each_entry_safe(this, next, &hb->chain, list) {
if (match_futex(&this->key, key)) {
if (match) {
/*
* Sanity check the waiter before increasing
* the refcount and attaching to it.
* Sanity check the waiter before increasing the
* refcount and attaching to it.
*/
pi_state = this->pi_state;
pi_state = match->pi_state;
/*
* Userspace might have messed up non-PI and
* PI futexes [3]
* Userspace might have messed up non-PI and PI
* futexes [3]
*/
if (unlikely(!pi_state))
return -EINVAL;
@ -867,7 +866,6 @@ lookup_pi_state(u32 uval, struct futex_hash_bucket *hb,
*ps = pi_state;
return 0;
}
}
/*
* We are the first waiter - try to look up the real owner and attach