Commit Graph

140433 Commits

Author SHA1 Message Date
Roel Kluin 39b41b23e2 Staging: agnx: i reaches -1, tested 0
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:26 -07:00
Julia Lawall 6bf676723a Staging: agnx: Move a dereference below a NULL test
If the NULL test is necessary, then the dereference should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: YanBo <dreamfly281@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:26 -07:00
Huang Weiyi 4ed4f41c1b Staging: remove duplicated #include's
Removed duplicated #include's in
  drivers/staging/altpciechdma/altpciechdma.c
  drivers/staging/comedi/comedidev.h
  drivers/staging/rt2860/rt_linux.h
  drivers/staging/rt2870/rt_linux.h

Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:26 -07:00
Andre Haupt 93be73f929 Staging: me4000: make file_operations const
This eliminates checkpatch.pl warnings, that struct file_operations is
usually const.  The structs me4000_ai_fops_array and
me4000_ao_fops_array are not modified and thus also made const.

Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:25 -07:00
Andre Haupt f02d3345ed Staging: me4000: use tabs for code indentation
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:25 -07:00
Andre Haupt 370eb29dc4 Staging: me4000: do not use C99 style comments.
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:24 -07:00
Andre Haupt b8341a8d32 Staging: me4000: fix various checkpatch.pl warnings about bracing
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:24 -07:00
Andre Haupt e8aa1bd098 Staging: me4000: kfree(NULL) is safe, so no extra checks needed.
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:24 -07:00
Andre Haupt 705d300e1b Staging: me4000: replace some C99 comments
checkpatch.pl triggered those as false positives for trailing
statements, but those lines also triggered some other warnings.

Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:24 -07:00
Andre Haupt 1836842b20 Staging: me4000: inline keyword should sit between storage class and type
fixes some checkpatch.pl errors complaining about wrong position of the
inline keyword

Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:24 -07:00
Andre Haupt 387ed8f8ed Staging: me4000: return is not a function, no parentheses required
fixes some checkpatch.pl errors about unneccessary parentheses.

Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:24 -07:00
Andre Haupt 07d2a28230 Staging: me4000: use linux/uaccess.h and linux/io.h
This fixes the following checkpatch.pl warnings:

WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
WARNING: Use #include <linux/io.h> instead of <asm/io.h>

Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:24 -07:00
Richard Kennedy cfde74517b Staging: wlan-ng: block ioctls until card fully initialised
Add a mutex to block ioctls before the card is fully initialised and
only allow one ioctl at a time.
This stops udev trying to load the firmware before to card is fully up.

patch ported from wlan-ng-devel

Karl Relton <karllinuxtest.relton@ntlworld.com> spotted that this was
missing from the staging version,
http://lists.linux-wlan.com/pipermail/linux-wlan-devel/2009-February/003890.html

Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: Karl Relton <karllinuxtest.relton@ntlworld.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:24 -07:00
Moritz Muehlenhoff 18c7f792be Staging: wlan-ng: Replace local byteorder macros
Replace hfa384x2host_16(), hfa384x2host_32(), host2hfa384x_16()
and host2hfa384x_32() with standard byteorder macros.

Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:24 -07:00
Moritz Muehlenhoff 465e7417b1 Staging: wlan-ng: Remove the now empty wlan_compat.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:23 -07:00
Moritz Muehlenhoff 3897cd0c40 Staging: wlan-ng: Remove dead code from p80211netdev.c
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:23 -07:00
Moritz Muehlenhoff 7c98f71878 Staging: wlan-ng: Remove unnecessary checks for NULL before calling kfree()
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:23 -07:00
Moritz Muehlenhoff e469ee7f56 Staging: wlan-ng: Remove more dead code from hfa384x_usb.c
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:23 -07:00
Moritz Muehlenhoff d01f4677a8 Staging: wlan-ng: Remove dead code from prism2mib.c
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:23 -07:00
Moritz Muehlenhoff 450238eab0 Staging: wlan-ng: prism2mgmt.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:23 -07:00
Moritz Muehlenhoff 21dc0f8987 Staging: wlan-ng: hfa384x_usb.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:23 -07:00
Moritz Muehlenhoff b4b3f0da84 Staging: wlan-ng: p80211netdev.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:22 -07:00
Moritz Muehlenhoff f342288244 Staging: wlan-ng: prism2sta.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:22 -07:00
Moritz Muehlenhoff f4ee0f42a7 Staging: wlan-ng: prism2usb.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:22 -07:00
Moritz Muehlenhoff ec7466f091 Staging: wlan-ng: prism2mib.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:22 -07:00
Moritz Muehlenhoff bb12793243 Staging: wlan-ng: p80211mgmt.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:22 -07:00
Moritz Muehlenhoff a32fb5f754 Staging: wlan-ng: p80211netdev.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:22 -07:00
Moritz Muehlenhoff c27f880c34 Staging: wlan-ng: p80211msg.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:22 -07:00
Moritz Muehlenhoff 356925c713 Staging: wlan-ng: p80211types.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:22 -07:00
Moritz Muehlenhoff 82eaca7d9a Staging: wlan-ng: p80211conv.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:22 -07:00
Moritz Muehlenhoff c979aec791 Staging: wlan-ng: p80211conv.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:22 -07:00
Moritz Muehlenhoff d6c82d9719 Staging: wlan-ng: p80211hdr.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:22 -07:00
Moritz Muehlenhoff ea75ad7b8b Staging: wlan-ng: p80211metastruct.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:22 -07:00
Moritz Muehlenhoff 77ebd0471a Staging: wlan-ng: p80211ioctl.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:21 -07:00
Moritz Muehlenhoff 90de180a29 Staging: wlan-ng: p80211meta.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:21 -07:00
Moritz Muehlenhoff c7d4bd7d29 Staging: wlan-ng: p80211wext.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:21 -07:00
Moritz Muehlenhoff e573aaa4fd Staging: wlan-ng: hfa384x.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:21 -07:00
Moritz Muehlenhoff 2407486b83 Staging: wlan-ng: prism2mgmt.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:21 -07:00
Moritz Muehlenhoff b1de9675ac Staging: wlan-ng: p80211req.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:21 -07:00
Moritz Muehlenhoff 4793a5e2fd Staging: wlan-ng: p80211req.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:21 -07:00
Moritz Muehlenhoff a7cf7bae32 Staging: wlan-ng: Replace WLAN_LOG_DEBUG() with printk(KERN_DEBUG
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:21 -07:00
Moritz Muehlenhoff 16910554f3 Staging: wlan-ng: Move wlan_mkprintstr() and wlan_hexchar() macros into prism2sta.c
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:21 -07:00
Moritz Muehlenhoff 96c5abd7f8 Staging: wlan-ng: Move netdevice_t typedef into p80211netdev.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:21 -07:00
Moritz Muehlenhoff ea045ba020 Staging: wlan-ng: Remove WLAN_INCLUDE_DEBUG and some related, mostly unused
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:21 -07:00
Moritz Muehlenhoff 40a67411de Staging: wlan-ng: Remove more dead/unused code from hfa384x.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:21 -07:00
Moritz Muehlenhoff acb7e24208 Staging: wlan-ng: Remove dead/unused code from hfa384x.h and p80211metamsg.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:20 -07:00
Moritz Muehlenhoff 849d908ec3 Staging: wlan-ng: Remove dead/unused code from p80211ioctl.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:20 -07:00
Moritz Muehlenhoff 4033fefab3 Staging: wlan-ng: Remove dead/unused code from p80211metadef.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:20 -07:00
Moritz Muehlenhoff fc71f4a544 Staging: wlan-ng: Remove unused header file p80211metamib.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:20 -07:00
Moritz Muehlenhoff 28aed9e369 Staging: wlan-ng: Remove dead code from hfa384x_usb.c
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03 14:53:20 -07:00