OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
linux/drivers/pinctrl
History
Coiby Xu 974aa59837 pinctrl: amd: remove debounce filter setting in IRQ type setting 
commit 47a0001436 upstream.

Debounce filter setting should be independent from IRQ type setting
because according to the ACPI specs, there are separate arguments for
specifying debounce timeout and IRQ type in GpioIo() and GpioInt().

Together with commit 06abe8291b
("pinctrl: amd: fix incorrect way to disable debounce filter") and
Andy's patch "gpiolib: acpi: Take into account debounce settings" [1],
this will fix broken touchpads for laptops whose BIOS set the
debounce timeout to a relatively large value. For example, the BIOS
of Lenovo AMD gaming laptops including Legion-5 15ARH05 (R7000),
Legion-5P (R7000P) and IdeaPad Gaming 3 15ARH05, set the debounce
timeout to 124.8ms. This led to the kernel receiving only ~7 HID
reports per second from the Synaptics touchpad
(MSFT0001:00 06CB:7F28).

Existing touchpads like [2][3] are not troubled by this bug because
the debounce timeout has been set to 0 by the BIOS before enabling
the debounce filter in setting IRQ type.

[1] https://lore.kernel.org/linux-gpio/20201111222008.39993-11-andriy.shevchenko@linux.intel.com/
    8dcb7a15a585 ("gpiolib: acpi: Take into account debounce settings")
[2] https://github.com/Syniurge/i2c-amd-mp2/issues/11#issuecomment-721331582
[3] https://forum.manjaro.org/t/random-short-touchpad-freezes/30832/28

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/linux-gpio/CAHp75VcwiGREBUJ0A06EEw-SyabqYsp%2Bdqs2DpSrhaY-2GVdAA%40mail.gmail.com/
BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1887190
Link: https://lore.kernel.org/r/20201125130320.311059-1-coiby.xu@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 		2020-12-16 10:56:58 +01:00
..
actions
…
aspeed pinctrl: aspeed: Fix GPI only function problem. 2020-11-18 19:20:26 +01:00
bcm pinctrl: bcm: fix kconfig dependency warning when !GPIOLIB 2020-10-29 09:57:34 +01:00
berlin
…
cirrus
…
freescale pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()' 2020-06-24 17:50:38 +02:00
intel pinctrl: baytrail: Fix pin being driven low for a while on gpiod_get(..., GPIOD_OUT_HIGH) 2020-12-11 13:23:27 +01:00
mediatek
…
meson
…
mvebu pinctrl: mvebu: Fix i2c sda definition for 98DX3236 2020-10-07 08:01:28 +02:00
nomadik
…
nuvoton
…
pxa
…
qcom pinctrl: qcom: spmi-gpio: fix warning about irq chip reusage 2020-06-30 15:37:04 -04:00
samsung pinctrl: samsung: Save/restore eint_mask over suspend for EINT_TYPE GPIOs 2020-06-22 09:31:20 +02:00
sh-pfc
…
sirf
…
spear
…
sprd
…
stm32
…
sunxi
…
tegra pinctrl: tegra: Use noirq suspend/resume callbacks 2020-06-30 15:37:04 -04:00
ti
…
uniphier
…
vt8500
…
zte
…
Kconfig
…
Makefile
…
core.c
…
core.h
…
devicetree.c
…
devicetree.h
…
pinconf-generic.c
…
pinconf.c
…
pinconf.h
…
pinctrl-amd.c pinctrl: amd: remove debounce filter setting in IRQ type setting 2020-12-16 10:56:58 +01:00
pinctrl-amd.h pinctrl: amd: fix npins for uart0 in kerncz_groups 2020-07-29 10:18:26 +02:00
pinctrl-artpec6.c
…
pinctrl-as3722.c
…
pinctrl-at91-pio4.c
…
pinctrl-at91.c
…
pinctrl-at91.h
…
pinctrl-axp209.c
…
pinctrl-bm1880.c
…
pinctrl-coh901.c
…
pinctrl-coh901.h
…
pinctrl-da850-pupd.c
…
pinctrl-digicolor.c
…
pinctrl-falcon.c
…
pinctrl-gemini.c
…
pinctrl-ingenic.c pinctrl: ingenic: Properly detect GPIO direction when configured for IRQ 2020-08-21 13:05:29 +02:00
pinctrl-lantiq.c
…
pinctrl-lantiq.h
…
pinctrl-lpc18xx.c
…
pinctrl-max77620.c
…
pinctrl-mcp23s08.c pinctrl: mcp23s08: Fix mcp23x17 precious range 2020-10-29 09:57:39 +01:00
pinctrl-ocelot.c pinctrl: ocelot: Fix GPIO interrupt decoding on Jaguar2 2020-06-24 17:50:14 +02:00
pinctrl-oxnas.c
…
pinctrl-palmas.c
…
pinctrl-pic32.c
…
pinctrl-pic32.h
…
pinctrl-pistachio.c
…
pinctrl-rk805.c
…
pinctrl-rockchip.c pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq 2020-11-24 13:29:00 +01:00
pinctrl-rza1.c pinctrl: rza1: Fix wrong array assignment of rza1l_swio_entries 2020-06-24 17:50:21 +02:00
pinctrl-rza2.c
…
pinctrl-rzn1.c
…
pinctrl-single.c pinctrl-single: fix pcs_parse_pinconf() return value 2020-08-19 08:16:21 +02:00
pinctrl-st.c
…
pinctrl-stmfx.c
…
pinctrl-sx150x.c
…
pinctrl-tb10x.c
…
pinctrl-u300.c
…
pinctrl-utils.c
…
pinctrl-utils.h
…
pinctrl-xway.c
…
pinctrl-zynq.c
…
pinmux.c
…
pinmux.h
…