OpenE2K
/
qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

softmmu/device_tree: Remove redundant pointer assignment 

The pointer assignment "const char *p = path;" in function
qemu_fdt_add_path is unnecessary. Let's remove it and just
use the "path" passed in. No functional change.

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-id: 20220111032758.27804-1-wangyanan55@huawei.com
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
This commit is contained in:
Yanan Wang 2022-01-11 11:27:58 +08:00 committed by Alistair Francis
parent cfeeeb482a
commit 22599b795c
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
softmmu/device_tree.c
View File

@ -558,7 +558,6 @@ int qemu_fdt_add_subnode(void *fdt, const char *name)
int qemu_fdt_add_path(void *fdt, const char *path) int qemu_fdt_add_path(void *fdt, const char *path)
{ {
const char *name; const char *name;
const char *p = path;
int namelen, retval; int namelen, retval;
int parent = 0; int parent = 0;
@ -567,9 +566,9 @@ int qemu_fdt_add_path(void *fdt, const char *path)
} }
do { do {
name = p + 1; name = path + 1;
p = strchr(name, '/'); path = strchr(name, '/');
namelen = p != NULL ? p - name : strlen(name); namelen = path != NULL ? path - name : strlen(name);
retval = fdt_subnode_offset_namelen(fdt, parent, name, namelen); retval = fdt_subnode_offset_namelen(fdt, parent, name, namelen);
if (retval < 0 && retval != -FDT_ERR_NOTFOUND) { if (retval < 0 && retval != -FDT_ERR_NOTFOUND) {
@ -586,7 +585,7 @@ int qemu_fdt_add_path(void *fdt, const char *path)
} }
parent = retval; parent = retval;
} while (p); } while (path);
return retval; return retval;
} }