OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

chardev: src buffer const for write functions

Browse Source 
Make source buffers const for char be write functions.
This allows using buffers returned by fifo as buf parameter and source buffer
should not be changed by write functions anyway.

Signed-off-by: Arwed Meyer <arwed.meyer@gmx.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20220911181840.8933-3-arwed.meyer@gmx.de>
This commit is contained in:
Arwed Meyer 2022-09-11 20:18:37 +02:00 committed by Marc-André Lureau
parent a39fe10557
commit 8f9abdf586
5 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
chardev/char.c
View File

@ -193,7 +193,7 @@ int qemu_chr_be_can_write(Chardev *s)
return be->chr_can_read(be->opaque); return be->chr_can_read(be->opaque);
} }
void qemu_chr_be_write_impl(Chardev *s, uint8_t *buf, int len) void qemu_chr_be_write_impl(Chardev *s, const uint8_t *buf, int len)
{ {
CharBackend *be = s->be; CharBackend *be = s->be;
@ -202,7 +202,7 @@ void qemu_chr_be_write_impl(Chardev *s, uint8_t *buf, int len)
} }
} }
void qemu_chr_be_write(Chardev *s, uint8_t *buf, int len) void qemu_chr_be_write(Chardev *s, const uint8_t *buf, int len)
{ {
if (qemu_chr_replay(s)) { if (qemu_chr_replay(s)) {
if (replay_mode == REPLAY_MODE_PLAY) { if (replay_mode == REPLAY_MODE_PLAY) {

4
include/chardev/char.h
View File

@ -186,7 +186,7 @@ int qemu_chr_be_can_write(Chardev *s);
* the caller should call @qemu_chr_be_can_write to determine how much data * the caller should call @qemu_chr_be_can_write to determine how much data
* the front end can currently accept. * the front end can currently accept.
*/ */
void qemu_chr_be_write(Chardev *s, uint8_t *buf, int len); void qemu_chr_be_write(Chardev *s, const uint8_t *buf, int len);
/** /**
* qemu_chr_be_write_impl: * qemu_chr_be_write_impl:
@ -195,7 +195,7 @@ void qemu_chr_be_write(Chardev *s, uint8_t *buf, int len);
* *
* Implementation of back end writing. Used by replay module. * Implementation of back end writing. Used by replay module.
*/ */
void qemu_chr_be_write_impl(Chardev *s, uint8_t *buf, int len); void qemu_chr_be_write_impl(Chardev *s, const uint8_t *buf, int len);
/** /**
* qemu_chr_be_update_read_handlers: * qemu_chr_be_update_read_handlers:

2
include/sysemu/replay.h
View File

@ -198,7 +198,7 @@ uint64_t blkreplay_next_id(void);
/*! Registers char driver to save it's events */ /*! Registers char driver to save it's events */
void replay_register_char_driver(struct Chardev *chr); void replay_register_char_driver(struct Chardev *chr);
/*! Saves write to char device event to the log */ /*! Saves write to char device event to the log */
void replay_chr_be_write(struct Chardev *s, uint8_t *buf, int len); void replay_chr_be_write(struct Chardev *s, const uint8_t *buf, int len);
/*! Writes char write return value to the replay log. */ /*! Writes char write return value to the replay log. */
void replay_char_write_event_save(int res, int offset); void replay_char_write_event_save(int res, int offset);
/*! Reads char write return value from the replay log. */ /*! Reads char write return value from the replay log. */

2
replay/replay-char.c
View File

@ -48,7 +48,7 @@ void replay_register_char_driver(Chardev *chr)
char_drivers[drivers_count++] = chr; char_drivers[drivers_count++] = chr;
} }
void replay_chr_be_write(Chardev *s, uint8_t *buf, int len) void replay_chr_be_write(Chardev *s, const uint8_t *buf, int len)
{ {
CharEvent *event = g_new0(CharEvent, 1); CharEvent *event = g_new0(CharEvent, 1);

2
stubs/replay-tools.c
View File

@ -53,7 +53,7 @@ void replay_register_char_driver(struct Chardev *chr)
{ {
} }
void replay_chr_be_write(struct Chardev *s, uint8_t *buf, int len) void replay_chr_be_write(struct Chardev *s, const uint8_t *buf, int len)
{ {
abort(); abort();
} }