nbd/client-connection: improve error message of cancelled attempt
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Reviewed-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
parent
169b9a94ed
commit
9e14491af4
|
@ -351,8 +351,15 @@ nbd_co_establish_connection(NBDClientConnection *conn, NBDExportInfo *info,
|
||||||
if (conn->err) {
|
if (conn->err) {
|
||||||
error_propagate(errp, error_copy(conn->err));
|
error_propagate(errp, error_copy(conn->err));
|
||||||
} else {
|
} else {
|
||||||
error_setg(errp,
|
/*
|
||||||
"Connection attempt cancelled by other operation");
|
* The only possible case here is cancelling by open_timer
|
||||||
|
* during nbd_open(). So, the error message is for that case.
|
||||||
|
* If we have more use cases, we can refactor
|
||||||
|
* nbd_co_establish_connection_cancel() to take an additional
|
||||||
|
* parameter cancel_reason, that would be passed than to the
|
||||||
|
* caller of cancelled nbd_co_establish_connection().
|
||||||
|
*/
|
||||||
|
error_setg(errp, "Connection attempt cancelled by timeout");
|
||||||
}
|
}
|
||||||
|
|
||||||
return NULL;
|
return NULL;
|
||||||
|
|
Loading…
Reference in New Issue