OpenE2K
/
qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

gdbstub: do not split gdb_monitor_write payload 

Since we can now send packets of arbitrary length:
simplify gdb_monitor_write() and send the whole payload
in one packet.

Suggested-by: Luc Michel <luc.michel@greensocs.com>
Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20191211160514.58373-3-damien.hedde@greensocs.com>
Message-Id: <20200316172155.971-28-alex.bennee@linaro.org>
This commit is contained in:
Damien Hedde 2020-03-16 17:21:54 +00:00 committed by Alex Bennée
parent d116e813a5
commit d86b4672f2
1 changed files with 3 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
gdbstub.c
View File

@ -3200,28 +3200,11 @@ static void gdb_chr_event(void *opaque, QEMUChrEvent event)
}
}
static void gdb_monitor_output(const char *msg, int len)
{
g_autoptr(GString) buf = g_string_new("O");
memtohex(buf, (uint8_t *)msg, len);
put_packet(buf->str);
}
static int gdb_monitor_write(Chardev *chr, const uint8_t *buf, int len)
{
const char *p = (const char *)buf;
int max_sz;
max_sz = (MAX_PACKET_LENGTH / 2) + 1;
for (;;) {
if (len <= max_sz) {
gdb_monitor_output(p, len);
break;
}
gdb_monitor_output(p, max_sz);
p += max_sz;
len -= max_sz;
}
g_autoptr(GString) hex_buf = g_string_new("O");
memtohex(hex_buf, buf, len);
put_packet(hex_buf->str);
return len;
}