gdbstub: do not split gdb_monitor_write payload
Since we can now send packets of arbitrary length: simplify gdb_monitor_write() and send the whole payload in one packet. Suggested-by: Luc Michel <luc.michel@greensocs.com> Signed-off-by: Damien Hedde <damien.hedde@greensocs.com> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-Id: <20191211160514.58373-3-damien.hedde@greensocs.com> Message-Id: <20200316172155.971-28-alex.bennee@linaro.org>
This commit is contained in:
parent
d116e813a5
commit
d86b4672f2
23
gdbstub.c
23
gdbstub.c
|
@ -3200,28 +3200,11 @@ static void gdb_chr_event(void *opaque, QEMUChrEvent event)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
static void gdb_monitor_output(const char *msg, int len)
|
|
||||||
{
|
|
||||||
g_autoptr(GString) buf = g_string_new("O");
|
|
||||||
memtohex(buf, (uint8_t *)msg, len);
|
|
||||||
put_packet(buf->str);
|
|
||||||
}
|
|
||||||
|
|
||||||
static int gdb_monitor_write(Chardev *chr, const uint8_t *buf, int len)
|
static int gdb_monitor_write(Chardev *chr, const uint8_t *buf, int len)
|
||||||
{
|
{
|
||||||
const char *p = (const char *)buf;
|
g_autoptr(GString) hex_buf = g_string_new("O");
|
||||||
int max_sz;
|
memtohex(hex_buf, buf, len);
|
||||||
|
put_packet(hex_buf->str);
|
||||||
max_sz = (MAX_PACKET_LENGTH / 2) + 1;
|
|
||||||
for (;;) {
|
|
||||||
if (len <= max_sz) {
|
|
||||||
gdb_monitor_output(p, len);
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
gdb_monitor_output(p, max_sz);
|
|
||||||
p += max_sz;
|
|
||||||
len -= max_sz;
|
|
||||||
}
|
|
||||||
return len;
|
return len;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue