QEMU With E2K User Support
Go to file
Li Feng 2b61bb716c char-socket: initialize reconnect timer only when the timer doesn't start
When the disconnect event is triggered in the connecting stage,
the tcp_chr_disconnect_locked may be called twice.

The first call:
    #0  qemu_chr_socket_restart_timer (chr=0x55555582ee90) at chardev/char-socket.c:120
    #1  0x000055555558e38c in tcp_chr_disconnect_locked (chr=<optimized out>) at chardev/char-socket.c:490
    #2  0x000055555558e3cd in tcp_chr_disconnect (chr=0x55555582ee90) at chardev/char-socket.c:497
    #3  0x000055555558ea32 in tcp_chr_new_client (chr=chr@entry=0x55555582ee90, sioc=sioc@entry=0x55555582f0b0) at chardev/char-socket.c:892
    #4  0x000055555558eeb8 in qemu_chr_socket_connected (task=0x55555582f300, opaque=<optimized out>) at chardev/char-socket.c:1090
    #5  0x0000555555574352 in qio_task_complete (task=task@entry=0x55555582f300) at io/task.c:196
    #6  0x00005555555745f4 in qio_task_thread_result (opaque=0x55555582f300) at io/task.c:111
    #7  qio_task_wait_thread (task=0x55555582f300) at io/task.c:190
    #8  0x000055555558f17e in tcp_chr_wait_connected (chr=0x55555582ee90, errp=0x555555802a08 <error_abort>) at chardev/char-socket.c:1013
    #9  0x0000555555567cbd in char_socket_client_reconnect_test (opaque=0x5555557fe020 <client8unix>) at tests/test-char.c:1152
The second call:
    #0  0x00007ffff5ac3277 in raise () from /lib64/libc.so.6
    #1  0x00007ffff5ac4968 in abort () from /lib64/libc.so.6
    #2  0x00007ffff5abc096 in __assert_fail_base () from /lib64/libc.so.6
    #3  0x00007ffff5abc142 in __assert_fail () from /lib64/libc.so.6
    #4  0x000055555558d10a in qemu_chr_socket_restart_timer (chr=0x55555582ee90) at chardev/char-socket.c:125
    #5  0x000055555558df0c in tcp_chr_disconnect_locked (chr=<optimized out>) at chardev/char-socket.c:490
    #6  0x000055555558df4d in tcp_chr_disconnect (chr=0x55555582ee90) at chardev/char-socket.c:497
    #7  0x000055555558e5b2 in tcp_chr_new_client (chr=chr@entry=0x55555582ee90, sioc=sioc@entry=0x55555582f0b0) at chardev/char-socket.c:892
    #8  0x000055555558e93a in tcp_chr_connect_client_sync (chr=chr@entry=0x55555582ee90, errp=errp@entry=0x7fffffffd178) at chardev/char-socket.c:944
    #9  0x000055555558ec78 in tcp_chr_wait_connected (chr=0x55555582ee90, errp=0x555555802a08 <error_abort>) at chardev/char-socket.c:1035
    #10 0x000055555556804b in char_socket_client_test (opaque=0x5555557fe020 <client8unix>) at tests/test-char.c:1023

Run test/test-char to reproduce this issue.

test-char: chardev/char-socket.c:125: qemu_chr_socket_restart_timer: Assertion `!s->reconnect_timer' failed.

Signed-off-by: Li Feng <fengli@smartx.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200522025554.41063-1-fengli@smartx.com>
2020-07-13 11:59:47 +04:00
.github .github: Enable repo-lockdown bot to refuse GitHub pull requests 2020-04-07 16:19:18 +01:00
.gitlab-ci.d gitlab-ci: Move edk2 and opensbi YAML files to .gitlab-ci.d folder 2020-05-28 11:00:39 +02:00
accel accel/tcg: Add stub for probe_access() 2020-07-10 18:02:21 -04:00
audio qapi: Make visitor functions taking Error ** return bool, not void 2020-07-10 15:18:08 +02:00
authz qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
backends error: Eliminate error_propagate() with Coccinelle, part 1 2020-07-10 15:18:08 +02:00
block iscsi: return -EIO when sense fields are meaningless 2020-07-10 18:02:23 -04:00
bsd-user linux-user/sparc64: Fix the handling of window spill trap 2020-06-29 13:00:23 +02:00
capstone@22ead3e0bf
chardev char-socket: initialize reconnect timer only when the timer doesn't start 2020-07-13 11:59:47 +04:00
contrib qemu-option: Use returned bool to check for failure 2020-07-10 15:17:35 +02:00
crypto qom: Put name parameter before value / visitor parameter 2020-07-10 15:18:08 +02:00
default-configs hw/avr: Add limited support for some Arduino boards 2020-07-11 11:02:05 +02:00
disas
docs target/avr: Add section into QEMU documentation 2020-07-11 11:02:05 +02:00
dtc@85e5d83984 Makefile: dtc: update, build the libfdt target 2020-06-16 14:49:05 +01:00
dump error: Eliminate error_propagate() manually 2020-07-10 15:18:08 +02:00
fpu softfloat: return low bits of quotient from floatx80_modrem 2020-06-26 09:39:38 -04:00
fsdev 9p: null terminate fs driver options list 2020-07-10 12:48:06 +02:00
gdb-xml target/avr: CPU class: Add GDB support 2020-07-10 17:58:32 +02:00
hw 8bit AVR port from Michael Rolnik. 2020-07-11 19:27:59 +01:00
include 8bit AVR port from Michael Rolnik. 2020-07-11 19:27:59 +01:00
io io/task: Move 'qom/object.h' header to source 2020-06-10 12:09:37 -04:00
libdecnumber
linux-headers linux-headers: update again to 5.8 2020-07-10 19:26:55 -04:00
linux-user qom: Put name parameter before value / visitor parameter 2020-07-10 15:18:08 +02:00
migration cpu-throttle: new module, extracted from cpus.c 2020-07-10 18:04:49 -04:00
monitor qapi: Smooth another visitor error checking pattern 2020-07-10 15:18:08 +02:00
nbd nbd: Use ERRP_GUARD() 2020-07-10 15:18:09 +02:00
net error: Eliminate error_propagate() with Coccinelle, part 2 2020-07-10 15:18:08 +02:00
pc-bios Update OpenBIOS images to 75fbb41d built from submodule. 2020-07-07 21:54:37 +01:00
plugins qemu/qemu-plugin: Make qemu_plugin_hwaddr_is_io() hwaddr argument const 2020-05-15 15:25:16 +01:00
po translations: Add Swedish language 2020-06-15 20:51:10 +02:00
python/qemu python/qemu/qtest: Check before accessing _qtest 2020-05-31 18:25:31 +02:00
qapi target/avr: Register AVR support with the rest of QEMU 2020-07-11 11:02:05 +02:00
qga error: Eliminate error_propagate() manually 2020-07-10 15:18:08 +02:00
qobject qobject: Eliminate qdict_iter(), use qdict_first(), qdict_next() 2020-04-30 06:51:15 +02:00
qom qom: Introduce object_property_try_add_child() 2020-07-10 18:02:16 -04:00
replay replay: synchronize on every virtual timer callback 2020-06-26 06:45:30 -04:00
roms Update OpenBIOS images to 75fbb41d built from submodule. 2020-07-07 21:54:37 +01:00
scripts scripts: improve message when TAP based tests fail 2020-07-10 19:26:55 -04:00
scsi error: Use error_reportf_err() where appropriate 2020-05-27 07:45:30 +02:00
slirp@2faae0f778 slirp: update to fix CVE-2020-1983 2020-04-21 18:39:20 +01:00
softmmu 8bit AVR port from Michael Rolnik. 2020-07-11 19:27:59 +01:00
storage-daemon
stubs trivial branch patches 20200707 2020-07-09 14:13:19 +01:00
target 8bit AVR port from Michael Rolnik. 2020-07-11 19:27:59 +01:00
tcg tcg: Fix do_nonatomic_op_* vs signed operations 2020-07-06 10:58:19 -07:00
tests char-socket: initialize reconnect timer only when the timer doesn't start 2020-07-13 11:59:47 +04:00
tools/virtiofsd virtiofsd: Allow addition or removal of capabilities 2020-07-03 16:23:05 +01:00
trace trace/simple: Fix unauthorized enable 2020-06-24 11:21:00 +01:00
ui cpu-throttle: new module, extracted from cpus.c 2020-07-10 18:04:49 -04:00
util util/qemu-error: prepend guest name to error message to identify affected VM owner 2020-07-10 18:02:15 -04:00
.cirrus.yml cirrus.yml: serialise make check 2020-06-16 14:49:05 +01:00
.dir-locals.el
.editorconfig
.exrc
.gdbinit
.gitignore .gitignore: Ignore storage-daemon files 2020-06-17 14:53:40 +02:00
.gitlab-ci.yml gitlab-ci: Determine the number of jobs dynamically 2020-05-28 11:01:38 +02:00
.gitmodules
.gitpublish
.mailmap MAINTAINERS: Update Radoslaw Biernacki email address 2020-07-07 12:38:50 +02:00
.patchew.yml
.readthedocs.yml
.shippable.yml Revert ".shippable: temporaily disable some cross builds" 2020-06-16 14:49:05 +01:00
.travis.yml configure: Let SLOF be initialized by ./scripts/git-submodule.sh 2020-06-15 18:26:47 +02:00
block.c error: Reduce unnecessary error propagation 2020-07-10 15:18:08 +02:00
blockdev-nbd.c
blockdev.c error: Eliminate error_propagate() manually 2020-07-10 15:18:08 +02:00
blockjob.c block: Add BdrvChildRole to BdrvChild 2020-05-18 19:05:25 +02:00
bootdevice.c error: Eliminate error_propagate() manually 2020-07-10 15:18:08 +02:00
Changelog
CODING_STYLE.rst
configure target/avr: Register AVR support with the rest of QEMU 2020-07-11 11:02:05 +02:00
COPYING
COPYING.LIB
cpus-common.c cpus: Move CPU code from exec.c to cpus-common.c 2020-07-10 18:02:24 -04:00
device_tree.c device_tree: Constify compat in qemu_fdt_node_path() 2020-04-30 15:35:41 +01:00
disas.c disas: Let disas::read_memory() handler return EIO on error 2020-06-10 12:10:23 -04:00
dma-helpers.c icount: make dma reads deterministic 2020-06-17 14:53:39 +02:00
exec-vary.c
exec.c cpus: Move CPU code from exec.c to cpus-common.c 2020-07-10 18:02:24 -04:00
gdbstub.c gdbstub/linux-user: support debugging over a unix socket 2020-05-06 09:29:26 +01:00
gitdm.config
hmp-commands-info.hx memory: Make 'info mtree' not display disabled regions by default 2020-06-10 12:10:49 -04:00
hmp-commands.hx hmp: Make json format optional for qom-set 2020-06-17 17:48:39 +01:00
iothread.c error: Eliminate error_propagate() with Coccinelle, part 1 2020-07-10 15:18:08 +02:00
job-qmp.c job: take each job's lock individually in job_txn_apply 2020-04-07 14:34:47 +02:00
job.c job: take each job's lock individually in job_txn_apply 2020-04-07 14:34:47 +02:00
Kconfig Makefile: simplify MINIKCONF rules 2020-07-10 18:02:21 -04:00
Kconfig.host accel/Kconfig: Extract accel selectors into their own config 2020-07-10 18:02:21 -04:00
LICENSE
MAINTAINERS 8bit AVR port from Michael Rolnik. 2020-07-11 19:27:59 +01:00
Makefile Makefile: simplify MINIKCONF rules 2020-07-10 18:02:21 -04:00
Makefile.objs chardev: enable modules, use for braille 2020-07-07 15:33:59 +02:00
Makefile.target softmmu: move softmmu only files from root 2020-07-10 18:02:24 -04:00
memory_ldst.inc.c
module-common.c
os-posix.c
os-win32.c
qdev-monitor.c hmp: Ignore Error objects where the return value suffices 2020-07-10 15:18:09 +02:00
qemu-bridge-helper.c
qemu-edid.c
qemu-img-cmds.hx block/amend: add 'force' option 2020-07-06 08:49:28 +02:00
qemu-img.c qemu-img: Ignore Error objects where the return value suffices 2020-07-10 15:18:09 +02:00
qemu-io-cmds.c block-backend: Add flags to blk_truncate() 2020-04-30 17:51:07 +02:00
qemu-io.c
qemu-keymap.c
qemu-nbd.c error: Use error_reportf_err() where appropriate 2020-05-27 07:45:30 +02:00
qemu-options-wrapper.h
qemu-options.h
qemu-options.hx util/qemu-error: prepend guest name to error message to identify affected VM owner 2020-07-10 18:02:15 -04:00
qemu-seccomp.c
qemu-storage-daemon.c qemu-storage-daemon: add missing cleanup calls 2020-07-03 09:37:03 +02:00
qemu.nsi
qemu.sasl
README.rst
replication.c
replication.h
rules.mak
thunk.c linux-user: Add strace support for printing arguments of ioctl() 2020-07-04 18:08:51 +02:00
tpm.c error: Eliminate error_propagate() with Coccinelle, part 1 2020-07-10 15:18:08 +02:00
trace-events
VERSION Open 5.1 development tree 2020-04-29 15:07:10 +01:00
version.rc

===========
QEMU README
===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:


.. code-block:: shell

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

* `<https://qemu.org/Hosts/Linux>`_
* `<https://qemu.org/Hosts/Mac>`_
* `<https://qemu.org/Hosts/W32>`_


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

.. code-block:: shell

   git clone https://git.qemu.org/git/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the CODING_STYLE.rst file.

Additional information on submitting patches can be found online via
the QEMU website

* `<https://qemu.org/Contribute/SubmitAPatch>`_
* `<https://qemu.org/Contribute/TrivialPatches>`_

The QEMU website is also maintained under source control.

.. code-block:: shell

  git clone https://git.qemu.org/git/qemu-web.git

* `<https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/>`_

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

*  `<https://github.com/stefanha/git-publish>`_

The workflow with 'git-publish' is:

.. code-block:: shell

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

.. code-block:: shell

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses Launchpad as its primary upstream bug tracker. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

* `<https://bugs.launchpad.net/qemu/>`_

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via launchpad.

For additional information on bug reporting consult:

* `<https://qemu.org/Contribute/ReportABug>`_


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

* `<mailto:qemu-devel@nongnu.org>`_
* `<https://lists.nongnu.org/mailman/listinfo/qemu-devel>`_
* #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

* `<https://qemu.org/Contribute/StartHere>`_