ed5abf46b3
As reported in: https://bugs.launchpad.net/qemu/+bug/1851939 we weren't correctly handling illegal instructions based on the value of MSTATUS_TSR and the current privledge level. This patch fixes the issue raised in the bug by raising an illegal instruction if TSR is set and we are in S-Mode. Signed-off-by: Alistair Francis <alistair.francis@wdc.com> Reviewed-by: Jonathan Behrens <jonathan@fintelia.io Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
205 lines
6.2 KiB
C
205 lines
6.2 KiB
C
/*
|
|
* RISC-V Emulation Helpers for QEMU.
|
|
*
|
|
* Copyright (c) 2016-2017 Sagar Karandikar, sagark@eecs.berkeley.edu
|
|
* Copyright (c) 2017-2018 SiFive, Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms and conditions of the GNU General Public License,
|
|
* version 2 or later, as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along with
|
|
* this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qemu/log.h"
|
|
#include "cpu.h"
|
|
#include "qemu/main-loop.h"
|
|
#include "exec/exec-all.h"
|
|
#include "exec/helper-proto.h"
|
|
|
|
/* Exceptions processing helpers */
|
|
void QEMU_NORETURN riscv_raise_exception(CPURISCVState *env,
|
|
uint32_t exception, uintptr_t pc)
|
|
{
|
|
CPUState *cs = env_cpu(env);
|
|
qemu_log_mask(CPU_LOG_INT, "%s: %d\n", __func__, exception);
|
|
cs->exception_index = exception;
|
|
cpu_loop_exit_restore(cs, pc);
|
|
}
|
|
|
|
void helper_raise_exception(CPURISCVState *env, uint32_t exception)
|
|
{
|
|
riscv_raise_exception(env, exception, 0);
|
|
}
|
|
|
|
target_ulong helper_csrrw(CPURISCVState *env, target_ulong src,
|
|
target_ulong csr)
|
|
{
|
|
target_ulong val = 0;
|
|
if (riscv_csrrw(env, csr, &val, src, -1) < 0) {
|
|
riscv_raise_exception(env, RISCV_EXCP_ILLEGAL_INST, GETPC());
|
|
}
|
|
return val;
|
|
}
|
|
|
|
target_ulong helper_csrrs(CPURISCVState *env, target_ulong src,
|
|
target_ulong csr, target_ulong rs1_pass)
|
|
{
|
|
target_ulong val = 0;
|
|
if (riscv_csrrw(env, csr, &val, -1, rs1_pass ? src : 0) < 0) {
|
|
riscv_raise_exception(env, RISCV_EXCP_ILLEGAL_INST, GETPC());
|
|
}
|
|
return val;
|
|
}
|
|
|
|
target_ulong helper_csrrc(CPURISCVState *env, target_ulong src,
|
|
target_ulong csr, target_ulong rs1_pass)
|
|
{
|
|
target_ulong val = 0;
|
|
if (riscv_csrrw(env, csr, &val, 0, rs1_pass ? src : 0) < 0) {
|
|
riscv_raise_exception(env, RISCV_EXCP_ILLEGAL_INST, GETPC());
|
|
}
|
|
return val;
|
|
}
|
|
|
|
#ifndef CONFIG_USER_ONLY
|
|
|
|
target_ulong helper_sret(CPURISCVState *env, target_ulong cpu_pc_deb)
|
|
{
|
|
target_ulong prev_priv, prev_virt, mstatus;
|
|
|
|
if (!(env->priv >= PRV_S)) {
|
|
riscv_raise_exception(env, RISCV_EXCP_ILLEGAL_INST, GETPC());
|
|
}
|
|
|
|
target_ulong retpc = env->sepc;
|
|
if (!riscv_has_ext(env, RVC) && (retpc & 0x3)) {
|
|
riscv_raise_exception(env, RISCV_EXCP_INST_ADDR_MIS, GETPC());
|
|
}
|
|
|
|
if (env->priv_ver >= PRIV_VERSION_1_10_0 &&
|
|
get_field(env->mstatus, MSTATUS_TSR) && !(env->priv >= PRV_M)) {
|
|
riscv_raise_exception(env, RISCV_EXCP_ILLEGAL_INST, GETPC());
|
|
}
|
|
|
|
mstatus = env->mstatus;
|
|
|
|
if (riscv_has_ext(env, RVH) && !riscv_cpu_virt_enabled(env)) {
|
|
/* We support Hypervisor extensions and virtulisation is disabled */
|
|
target_ulong hstatus = env->hstatus;
|
|
|
|
prev_priv = get_field(mstatus, MSTATUS_SPP);
|
|
prev_virt = get_field(hstatus, HSTATUS_SPV);
|
|
|
|
hstatus = set_field(hstatus, HSTATUS_SPV,
|
|
get_field(hstatus, HSTATUS_SP2V));
|
|
mstatus = set_field(mstatus, MSTATUS_SPP,
|
|
get_field(hstatus, HSTATUS_SP2P));
|
|
hstatus = set_field(hstatus, HSTATUS_SP2V, 0);
|
|
hstatus = set_field(hstatus, HSTATUS_SP2P, 0);
|
|
mstatus = set_field(mstatus, SSTATUS_SIE,
|
|
get_field(mstatus, SSTATUS_SPIE));
|
|
mstatus = set_field(mstatus, SSTATUS_SPIE, 1);
|
|
|
|
env->mstatus = mstatus;
|
|
env->hstatus = hstatus;
|
|
|
|
if (prev_virt) {
|
|
riscv_cpu_swap_hypervisor_regs(env);
|
|
}
|
|
|
|
riscv_cpu_set_virt_enabled(env, prev_virt);
|
|
} else {
|
|
prev_priv = get_field(mstatus, MSTATUS_SPP);
|
|
|
|
mstatus = set_field(mstatus,
|
|
env->priv_ver >= PRIV_VERSION_1_10_0 ?
|
|
MSTATUS_SIE : MSTATUS_UIE << prev_priv,
|
|
get_field(mstatus, MSTATUS_SPIE));
|
|
mstatus = set_field(mstatus, MSTATUS_SPIE, 1);
|
|
mstatus = set_field(mstatus, MSTATUS_SPP, PRV_U);
|
|
env->mstatus = mstatus;
|
|
}
|
|
|
|
riscv_cpu_set_mode(env, prev_priv);
|
|
|
|
return retpc;
|
|
}
|
|
|
|
target_ulong helper_mret(CPURISCVState *env, target_ulong cpu_pc_deb)
|
|
{
|
|
if (!(env->priv >= PRV_M)) {
|
|
riscv_raise_exception(env, RISCV_EXCP_ILLEGAL_INST, GETPC());
|
|
}
|
|
|
|
target_ulong retpc = env->mepc;
|
|
if (!riscv_has_ext(env, RVC) && (retpc & 0x3)) {
|
|
riscv_raise_exception(env, RISCV_EXCP_INST_ADDR_MIS, GETPC());
|
|
}
|
|
|
|
target_ulong mstatus = env->mstatus;
|
|
target_ulong prev_priv = get_field(mstatus, MSTATUS_MPP);
|
|
target_ulong prev_virt = MSTATUS_MPV_ISSET(env);
|
|
mstatus = set_field(mstatus,
|
|
env->priv_ver >= PRIV_VERSION_1_10_0 ?
|
|
MSTATUS_MIE : MSTATUS_UIE << prev_priv,
|
|
get_field(mstatus, MSTATUS_MPIE));
|
|
mstatus = set_field(mstatus, MSTATUS_MPIE, 1);
|
|
mstatus = set_field(mstatus, MSTATUS_MPP, PRV_U);
|
|
#ifdef TARGET_RISCV32
|
|
env->mstatush = set_field(env->mstatush, MSTATUS_MPV, 0);
|
|
#else
|
|
mstatus = set_field(mstatus, MSTATUS_MPV, 0);
|
|
#endif
|
|
env->mstatus = mstatus;
|
|
riscv_cpu_set_mode(env, prev_priv);
|
|
|
|
if (riscv_has_ext(env, RVH)) {
|
|
if (prev_virt) {
|
|
riscv_cpu_swap_hypervisor_regs(env);
|
|
}
|
|
|
|
riscv_cpu_set_virt_enabled(env, prev_virt);
|
|
}
|
|
|
|
return retpc;
|
|
}
|
|
|
|
void helper_wfi(CPURISCVState *env)
|
|
{
|
|
CPUState *cs = env_cpu(env);
|
|
|
|
if ((env->priv == PRV_S &&
|
|
env->priv_ver >= PRIV_VERSION_1_10_0 &&
|
|
get_field(env->mstatus, MSTATUS_TW)) ||
|
|
riscv_cpu_virt_enabled(env)) {
|
|
riscv_raise_exception(env, RISCV_EXCP_ILLEGAL_INST, GETPC());
|
|
} else {
|
|
cs->halted = 1;
|
|
cs->exception_index = EXCP_HLT;
|
|
cpu_loop_exit(cs);
|
|
}
|
|
}
|
|
|
|
void helper_tlb_flush(CPURISCVState *env)
|
|
{
|
|
CPUState *cs = env_cpu(env);
|
|
if (!(env->priv >= PRV_S) ||
|
|
(env->priv == PRV_S &&
|
|
env->priv_ver >= PRIV_VERSION_1_10_0 &&
|
|
get_field(env->mstatus, MSTATUS_TVM))) {
|
|
riscv_raise_exception(env, RISCV_EXCP_ILLEGAL_INST, GETPC());
|
|
} else {
|
|
tlb_flush(cs);
|
|
}
|
|
}
|
|
|
|
#endif /* !CONFIG_USER_ONLY */
|