OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity
QEMU With E2K User Support
26,025 Commits 9 Branches 0 Tags 459 MiB
C 83.1%
C++ 6.3%
Python 3.2%
Dylan 2.8%
Shell 1.6%
Other 2.8%
75c439bc65
Go to file
Hans de Goede 75c439bc65 spice-qemu-char: vmc_write: Don't write more bytes then we're asked too 
This one took me eons to debug, but I've finally found it now, oh well.

The usage of the MIN macro in this line:
    last_out = MIN(len, qemu_chr_be_can_write(scd->chr));

Causes qemu_chr_be_can_write to be called *twice*, since the MIN macro
evaluates its arguments twice (bad MIN macro, bad!). And the result of
the call can change between the 2 calls since the guest may have consumed
some data from the virtio ringbuffer between the calls!

When this happens it is possible for qemu_chr_be_can_write to return less
then len in the call made for the comparision, and then to return more then
len in the actual call for the return-value of MIN, after which we will end
up writing len data + some extra garbage, not good.

This patch fixes this by only calling qemu_chr_be_can_write once.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2013-04-16 11:52:09 +02:00
audio audio: Replace non-portable asprintf in debug code by g_strdup_printf 2013-01-16 12:03:26 -06:00
backends sysemu: avoid proliferation of include/ subdirectories 2013-04-15 18:19:25 +02:00
block rbd: add an asynchronous flush 2013-04-15 10:18:05 +02:00
bsd-user qemu-log: default to stderr for logging output 2013-02-26 13:31:47 -06:00
default-configs configure: fix TPM logic 2013-04-15 15:16:41 +02:00
disas target-i386: add AES-NI instructions 2013-04-13 13:51:57 +02:00
docs Typo, spelling and grammatical fixes 2013-04-12 14:33:20 +02:00
fpu fpu: Correct edgecase in float64_muladd 2013-04-15 16:06:15 +02:00
fsdev virtfs-proxy-helper: Fix unchecked strdup() by conv. to g_strdup() 2013-01-30 11:14:46 +01:00
gdb-xml
hw virtio-console: Remove any pending watches on close 2013-04-16 11:52:09 +02:00
include virtio-console: Also throttle when less was written then requested 2013-04-16 11:52:09 +02:00
ldscripts
libcacard libcacard: Fix unchecked strdup() by converting to g_strdup() 2013-01-30 11:14:46 +01:00
linux-headers linux-headers: Update to v3.9-rc2 2013-04-01 11:50:04 -06:00
linux-user linux-user: pass correct host flags to eventfd2 call 2013-04-12 14:33:20 +02:00
net sysemu: avoid proliferation of include/ subdirectories 2013-04-15 18:19:25 +02:00
pc-bios hw: move headers to include/ 2013-04-08 18:13:10 +02:00
pixman@97336fad32 qapi: move include files to include/qobject/ 2012-12-19 08:31:31 +01:00
po po: Update German translation 2013-04-04 00:28:37 +02:00
qapi qapi: Fix unchecked strdup() by converting to g_strdup() 2013-01-30 11:14:46 +01:00
qga qemu-ga: ga_get_fd_handle(): abort if fd_counter overflows 2013-04-02 09:06:11 -05:00
QMP virtio,pci,qom 2013-03-26 16:16:43 -05:00
qobject qjson: to_json() case QTYPE_QSTRING is buggy, rewrite 2013-04-13 19:40:25 +00:00
qom virtio,pci,qom 2013-03-26 16:16:43 -05:00
roms virtio,pci,qom 2013-03-26 16:16:43 -05:00
scripts trace: [stderr] Port to generic event information and new control interface 2013-03-28 14:19:57 +01:00
slirp sysemu: avoid proliferation of include/ subdirectories 2013-04-15 18:19:25 +02:00
stubs stubs: Add a vmstate_dummy struct for CONFIG_USER_ONLY 2013-03-12 10:35:54 +01:00
sysconfigs/target
target-alpha cpu: Replace do_interrupt() by CPUClass::do_interrupt method 2013-03-12 10:35:55 +01:00
target-arm arm: fix location of some include files 2013-04-15 15:16:01 +02:00
target-cris cpu: Replace do_interrupt() by CPUClass::do_interrupt method 2013-03-12 10:35:55 +01:00
target-i386 target-i386: add AES-NI instructions 2013-04-13 13:51:57 +02:00
target-lm32 hw: move headers to include/ 2013-04-08 18:13:10 +02:00
target-m68k cpu: Replace do_interrupt() by CPUClass::do_interrupt method 2013-03-12 10:35:55 +01:00
target-microblaze Typo, spelling and grammatical fixes 2013-04-12 14:33:20 +02:00
target-mips target-mips: fix mipsdsp_mul_q15_q15 and tests for MAQ_SA_W_PHL/PHR 2013-04-15 16:07:57 +02:00
target-moxie target-moxie: Fix VMState registration 2013-04-12 14:30:39 +02:00
target-openrisc cpu: Replace do_interrupt() by CPUClass::do_interrupt method 2013-03-12 10:35:55 +01:00
target-ppc memory: move core typedefs to qemu/typedefs.h 2013-04-15 18:19:26 +02:00
target-s390x Typo, spelling and grammatical fixes 2013-04-12 14:33:20 +02:00
target-sh4 hw: move headers to include/ 2013-04-08 18:13:10 +02:00
target-sparc cpu: Replace do_interrupt() by CPUClass::do_interrupt method 2013-03-12 10:35:55 +01:00
target-unicore32 cpu: Replace do_interrupt() by CPUClass::do_interrupt method 2013-03-12 10:35:55 +01:00
target-xtensa cpu: Replace do_interrupt() by CPUClass::do_interrupt method 2013-03-12 10:35:55 +01:00
tcg tcg-ppc64: Handle deposit of zero 2013-04-15 20:09:55 +02:00
tests target-mips: fix mipsdsp_mul_q15_q15 and tests for MAQ_SA_W_PHL/PHR 2013-04-15 16:07:57 +02:00
trace trace: rebuild generated-events.o when configuration changes 2013-03-28 14:19:57 +01:00
ui sysemu: avoid proliferation of include/ subdirectories 2013-04-15 18:19:25 +02:00
util sysemu: avoid proliferation of include/ subdirectories 2013-04-15 18:19:25 +02:00
.exrc
.gitignore .gitignore: rename trace/generated-tracers.dtrace 2013-03-28 14:19:57 +01:00
.gitmodules
.mailmap
aio-posix.c aio: support G_IO_HUP and G_IO_ERR 2013-02-21 16:17:31 -06:00
aio-win32.c aio: Fix return value of aio_poll() 2013-01-17 10:51:42 +01:00
arch_init.c include: avoid useless includes of exec/ headers 2013-04-15 18:19:26 +02:00
async.c aio: add a ThreadPool instance to AioContext 2013-03-15 16:07:50 +01:00
balloon.c softmmu: move include files to include/sysemu/ 2012-12-19 08:32:45 +01:00
block-migration.c migration: run setup callbacks out of big lock 2013-03-11 13:32:01 +01:00
block.c block: Introduce bdrv_pwritev() for qcow2_save_vmstate 2013-04-15 08:26:18 +02:00
blockdev-nbd.c hw: move headers to include/ 2013-04-08 18:13:10 +02:00
blockdev.c hw: move headers to include/ 2013-04-08 18:13:10 +02:00
blockjob.c misc: move include files to include/qemu/ 2012-12-19 08:32:39 +01:00
bt-host.c sysemu: avoid proliferation of include/ subdirectories 2013-04-15 18:19:25 +02:00
bt-vhci.c sysemu: avoid proliferation of include/ subdirectories 2013-04-15 18:19:25 +02:00
Changelog
cmd.c misc: move include files to include/qemu/ 2012-12-19 08:32:39 +01:00
cmd.h
CODING_STYLE
configure Merge remote-tracking branch 'bonzini/hw-dirs' into staging 2013-04-15 17:06:04 -05:00
COPYING
COPYING.LIB
coroutine-gthread.c block: move include files to include/block/ 2012-12-19 08:31:31 +01:00
coroutine-sigaltstack.c Merge remote-tracking branch 'kwolf/for-anthony' into staging 2013-02-26 07:44:39 -06:00
coroutine-ucontext.c Merge remote-tracking branch 'kwolf/for-anthony' into staging 2013-02-26 07:44:39 -06:00
coroutine-win32.c block: move include files to include/block/ 2012-12-19 08:31:31 +01:00
cpu-exec.c Merge branch 'mingw' of git://qemu.weilnetz.de/qemu 2013-04-13 14:31:54 +02:00
cpus.c Check effective suspension of TCG thread 2013-04-12 18:27:16 +02:00
cputlb.c cpu: Move current_tb field to CPUState 2013-02-16 14:51:00 +01:00
device_tree.c softmmu: move include files to include/sysemu/ 2012-12-19 08:32:45 +01:00
device-hotplug.c hw: move device-hotplug.o to toplevel, compile it once 2013-03-01 13:57:13 +01:00
disas.c disas: Disassemble all ppc insns for the host 2013-04-15 19:44:35 +02:00
dma-helpers.c softmmu: move include files to include/sysemu/ 2012-12-19 08:32:45 +01:00
dump-stub.c softmmu: move include files to include/sysemu/ 2012-12-19 08:32:45 +01:00
dump.c include: avoid useless includes of exec/ headers 2013-04-15 18:19:26 +02:00
exec.c hw: move headers to include/ 2013-04-08 18:13:10 +02:00
gdbstub.c sysemu: avoid proliferation of include/ subdirectories 2013-04-15 18:19:25 +02:00
HACKING
hmp-commands.hx Revert "New QMP command query-cpu-max and HMP command cpu_max" 2013-04-12 09:41:54 -04:00
hmp.c Merge remote-tracking branch 'bonzini/hw-dirs' into staging 2013-04-15 17:06:04 -05:00
hmp.h Revert "New QMP command query-cpu-max and HMP command cpu_max" 2013-04-12 09:41:54 -04:00
iohandler.c iohandler: switch to GPollFD 2013-02-21 16:17:31 -06:00
ioport.c exec: move include files to include/exec/ 2012-12-19 08:31:31 +01:00
kvm-all.c cpu: Pass CPUState to cpu_interrupt() 2013-03-12 10:35:55 +01:00
kvm-stub.c include: avoid useless includes of exec/ headers 2013-04-15 18:19:26 +02:00
LICENSE
main-loop.c main-loop: drop the BQL if the I/O appears to be spinning 2013-04-05 12:53:33 -05:00
MAINTAINERS MAINTAINERS: update for source code movement 2013-04-08 18:13:16 +02:00
Makefile Update Makefile to actually install the new efi-enabled nic roms that are used by default. 2013-04-15 10:22:04 -05:00
Makefile.objs tpm: reorganize headers and split hardware part 2013-04-15 18:19:25 +02:00
Makefile.target build: always link device_tree.o into emulators if libfdt available 2013-03-01 15:01:19 +01:00
memory_mapping-stub.c softmmu: move include files to include/sysemu/ 2012-12-19 08:32:45 +01:00
memory_mapping.c exec: change RAM list to a TAILQ 2012-12-20 23:08:47 +01:00
memory.c memory: fix a bug of detection of memory region collision 2013-03-22 13:21:28 +01:00
migration-exec.c migration: eliminate s->migration_file 2013-03-11 13:32:03 +01:00
migration-fd.c migration: eliminate s->migration_file 2013-03-11 13:32:03 +01:00
migration-tcp.c migration: eliminate s->migration_file 2013-03-11 13:32:03 +01:00
migration-unix.c migration: eliminate s->migration_file 2013-03-11 13:32:03 +01:00
migration.c oslib-posix: rename socket_set_nonblock() to qemu_set_nonblock() 2013-04-02 11:47:37 -04:00
monitor.c Merge remote-tracking branch 'bonzini/hw-dirs' into staging 2013-04-15 17:06:04 -05:00
nbd.c oslib-posix: rename socket_set_nonblock() to qemu_set_nonblock() 2013-04-02 11:47:37 -04:00
os-posix.c softmmu: move include files to include/sysemu/ 2012-12-19 08:32:45 +01:00
os-win32.c qemu-timer: move timeBeginPeriod/timeEndPeriod to os-win32 2013-04-12 18:27:16 +02:00
page_cache.c page_cache: dup memory on insert 2013-03-11 13:32:03 +01:00
qapi-schema-test.json
qapi-schema.json qapi: use valid JSON in schema 2013-04-12 09:41:54 -04:00
qdev-monitor.c hw: move qdev-monitor.o to toplevel directory 2013-03-01 13:54:10 +01:00
qdict-test-data.txt
qemu-bridge-helper.c qemu-bridge-helper: force usage of a very high MAC address for the bridge 2013-03-28 12:58:52 -05:00
qemu-char.c Merge remote-tracking branch 'bonzini/hw-dirs' into staging 2013-04-15 17:06:04 -05:00
qemu-coroutine-io.c misc: move include files to include/qemu/ 2012-12-19 08:32:39 +01:00
qemu-coroutine-lock.c coroutine: use AioContext for CoQueue BH 2013-03-15 16:07:51 +01:00
qemu-coroutine-sleep.c misc: move include files to include/qemu/ 2012-12-19 08:32:39 +01:00
qemu-coroutine.c coroutine: move pooling to common code 2013-02-22 21:21:10 +01:00
qemu-doc.texi block: ssh: Use libssh2_sftp_fsync (if supported by libssh2) to flush to disk. 2013-04-15 10:18:05 +02:00
qemu-img-cmds.hx qemu-img: Add compare subcommand 2013-02-22 21:21:10 +01:00
qemu-img.c block: Add options QDict to bdrv_open() prototype 2013-03-15 16:07:49 +01:00
qemu-img.texi qemu-img: Add compare subcommand 2013-02-22 21:21:10 +01:00
qemu-io.c block: Add options QDict to bdrv_file_open() prototypes 2013-03-22 17:51:31 +01:00
qemu-log.c qemu-log: default to stderr for logging output 2013-02-26 13:31:47 -06:00
qemu-nbd.c Add -f FMT / --format FMT arg to qemu-nbd 2013-04-15 14:29:20 -05:00
qemu-nbd.texi Add -f FMT / --format FMT arg to qemu-nbd 2013-04-15 14:29:20 -05:00
qemu-options-wrapper.h
qemu-options.h
qemu-options.hx block: Add support for Secure Shell (ssh) block device. 2013-04-15 10:18:05 +02:00
qemu-seccomp.c softmmu: move include files to include/sysemu/ 2012-12-19 08:32:45 +01:00
qemu-tech.texi
qemu-timer.c qemu-timer: move timeBeginPeriod/timeEndPeriod to os-win32 2013-04-12 18:27:16 +02:00
qemu.sasl
qmp-commands.hx Revert "New QMP command query-cpu-max and HMP command cpu_max" 2013-04-12 09:41:54 -04:00
qmp.c sysemu: avoid proliferation of include/ subdirectories 2013-04-15 18:19:25 +02:00
qtest.c sysemu: avoid proliferation of include/ subdirectories 2013-04-15 18:19:25 +02:00
readline.c readline: Fix unchecked strdup() by converting to g_strdup() 2013-01-30 11:14:46 +01:00
README
rules.mak rules/mak: make clean should blow away timestamp files 2013-01-30 01:31:08 +02:00
savevm.c Merge remote-tracking branch 'stefanha/block' into staging 2013-04-15 08:02:41 -05:00
spice-qemu-char.c spice-qemu-char: vmc_write: Don't write more bytes then we're asked too 2013-04-16 11:52:09 +02:00
tcg-runtime.c tcg: Implement multiword multiply helpers 2013-02-23 17:25:28 +00:00
tci.c tci: Make tcg temporaries local to tcg_qemu_tb_exec 2013-04-11 19:58:21 +02:00
thread-pool.c threadpool: drop global thread pool 2013-03-15 16:07:51 +01:00
thunk.c exec: move include files to include/exec/ 2012-12-19 08:31:31 +01:00
tpm.c sysemu: avoid proliferation of include/ subdirectories 2013-04-15 18:19:25 +02:00
trace-events xhci: remove unimplemented printfs 2013-04-03 09:55:49 +02:00
translate-all.c include: avoid useless includes of exec/ headers 2013-04-15 18:19:26 +02:00
translate-all.h cputlb: Pass CPUState to cpu_unlink_tb() 2013-02-16 14:51:00 +01:00
user-exec.c Replace all setjmp()/longjmp() with sigsetjmp()/siglongjmp() 2013-02-23 16:11:19 +00:00
VERSION Open up 1.5 development tree 2013-02-15 17:40:56 -06:00
version.rc
vl.c Merge remote-tracking branch 'bonzini/hw-dirs' into staging 2013-04-15 17:06:04 -05:00
xbzrle.c Move XBZRLE encoding code to a separate file to allow testing 2013-02-01 08:32:20 +01:00
xen-all.c sysemu: avoid proliferation of include/ subdirectories 2013-04-15 18:19:25 +02:00
xen-mapcache.c hw: move headers to include/ 2013-04-08 18:13:10 +02:00
xen-stub.c hw: move headers to include/ 2013-04-08 18:13:10 +02:00

README 

Read the documentation in qemu-doc.html or on http://wiki.qemu.org

- QEMU team