QEMU With E2K User Support
Go to file
Markus Armbruster 7fcb8c89f0 blockdev: Fix blockdev-snapshot-sync error reporting for no medium
When external_snapshot_abort() rejects a BlockDriverState without a
medium, it creates an error like this:

        error_setg(errp, "Device '%s' has no medium", device);

Trouble is @device can be null.  My system formats null as "(null)",
but other systems might crash.  Reproducer:

1. Create a block device without a medium

    -> {"execute": "blockdev-add", "arguments": {"driver": "host_cdrom", "node-name": "blk0", "filename": "/dev/sr0"}}
    <- {"return": {}}

3. Attempt to snapshot it

    -> {"execute":"blockdev-snapshot-sync", "arguments": { "node-name": "blk0", "snapshot-file":"/tmp/foo.qcow2","format":"qcow2"}}
    <- {"error": {"class": "GenericError", "desc": "Device '(null)' has no medium"}}

Broken when commit 0901f67ecd made @device optional.

Use bdrv_get_device_or_node_name() instead.  Now it fails as it
should:

    <- {"error": {"class": "GenericError", "desc": "Device 'blk0' has no medium"}}

Fixes: 0901f67ecd ("qmp: Allow to take external snapshots on bs graphs node.")
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240306142831.2514431-1-armbru@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2024-03-18 13:13:08 +01:00
.github/workflows
.gitlab/issue_templates
.gitlab-ci.d gitlab-ci: add manual job to run Coverity 2024-03-08 19:11:00 +01:00
accel bulk: Call in place single use cpu_env() 2024-03-12 11:46:16 +01:00
audio audio: Depend on dbus_display1_dep 2024-02-16 17:27:22 +04:00
authz
backends backends/iommufd: Fix missing ERRP_GUARD() for error_prepend() 2024-03-12 11:45:33 +01:00
block mirror: Don't call job_pause_point() under graph lock 2024-03-18 12:03:04 +01:00
bsd-user gdbstub: Save target's siginfo 2024-03-13 11:43:52 +00:00
chardev char: Slightly better error reporting when chardev is in use 2024-03-09 18:56:37 +03:00
common-user
configs mips: do not list individual devices from configs/ 2024-03-08 15:51:22 +01:00
contrib contrib/elf2dmp: Ensure phdrs fit in file 2024-03-11 17:06:27 +00:00
crypto crypto: Introduce 'detached-header' field in QCryptoBlockInfoLUKS 2024-02-09 12:50:37 +00:00
disas target/riscv: honour show_opcodes when disassembling 2024-03-06 12:35:51 +00:00
docs virtio,pc,pci: features, cleanups, fixes 2024-03-13 15:11:53 +00:00
dump dump: Fix HMP dump-guest-memory -z without -R 2024-01-30 21:20:20 +03:00
ebpf ebpf: Updated eBPF program and skeleton. 2024-03-12 19:31:47 +08:00
fpu
fsdev configure, meson: rename targetos to host_os 2023-12-31 09:11:29 +01:00
gdb-xml gdb-xml: fix duplicate register in arm-neon.xml 2023-11-08 15:15:23 +00:00
gdbstub gdbstub: Fix double close() of the follow-fork-mode socket 2024-03-13 11:43:52 +00:00
host/include host/include/generic/host/atomic128: Fix compilation problem with Clang 17 2023-11-13 11:35:47 +01:00
hw virtio,pc,pci: features, cleanups, fixes 2024-03-13 15:11:53 +00:00
include mirror: Don't call job_pause_point() under graph lock 2024-03-18 12:03:04 +01:00
io migration/multifd: Don't fsync when closing QIOChannelFile 2024-03-11 14:41:40 -04:00
libdecnumber
linux-headers linux-headers: Update to Linux v6.8-rc6 2024-03-08 20:48:03 +10:00
linux-user final updates for 9.0 (testing, gdbstub): 2024-03-13 15:12:14 +00:00
migration * Add missing ERRP_GUARD() statements in functions that need it 2024-03-12 16:55:42 +00:00
monitor monitor/target: Include missing 'exec/memory.h' header 2024-02-13 10:59:25 +03:00
nbd nbd/server: Fix race in draining the export 2024-03-18 12:38:02 +01:00
net virtio,pc,pci: features, cleanups, fixes 2024-03-13 15:11:53 +00:00
pc-bios pc-bios/README: Add information about hppa-firmware 2024-03-03 06:41:19 +01:00
plugins plugins: cleanup codepath for previous inline operation 2024-03-06 12:35:50 +00:00
po
python buildsys: Bump known good meson version to v1.2.3 2023-11-24 16:21:55 +01:00
qapi virtio,pc,pci: features, cleanups, fixes 2024-03-13 15:11:53 +00:00
qga qga-win: Add support of Windows Server 2025 in get-osinfo command 2024-03-11 18:24:39 +02:00
qobject
qom hw/acpi: move object_resolve_type_unambiguous to core QOM 2024-02-27 09:36:41 +01:00
replay replay: Improve error messages about configuration conflicts 2024-03-09 18:56:36 +03:00
roms roms/hppa: Add build rules for hppa-firmware 2024-03-03 06:41:19 +01:00
scripts tracetool: remove redundant --target-type / --target-name args 2024-03-12 14:52:07 -04:00
scsi configure, meson: rename targetos to host_os 2023-12-31 09:11:29 +01:00
semihosting {linux,bsd}-user: Introduce get_task_state() 2024-03-06 12:35:19 +00:00
stats
storage-daemon meson: remove config_targetos 2023-12-31 09:11:28 +01:00
stubs migration: privatize colo interfaces 2024-03-11 16:28:59 -04:00
subprojects libvhost-user: Mark mmap'ed region memory as MADV_DONTDUMP 2024-03-12 17:56:55 -04:00
system migration: migration_thread_is_self 2024-03-11 16:28:59 -04:00
target * PAPR nested hypervisor host implementation for spapr TCG 2024-03-13 12:37:27 +00:00
tcg tcg/aarch64: Fix tcg_out_brcond for test comparisons 2024-03-12 04:09:21 -10:00
tests iotests: Add test for reset/AioContext switches with NBD exports 2024-03-18 13:12:51 +01:00
tools ebpf: Updated eBPF program and skeleton. 2024-03-12 19:31:47 +08:00
trace tracing: install trace events file only if necessary 2023-12-27 05:01:55 -05:00
ui ui/dbus: filter out pending messages when scanout 2024-03-12 17:57:58 +04:00
util oslib-posix: fix memory leak in touch_all_pages 2024-03-08 15:51:22 +01:00
.dir-locals.el
.editorconfig
.exrc
.gdbinit
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitlab-ci.yml
.gitmodules
.gitpublish
.mailmap mailmap: Fix Stefan Weil email 2024-01-30 21:20:20 +03:00
.patchew.yml
.readthedocs.yml readthodocs: fully specify a build environment 2024-01-12 13:23:48 +00:00
.travis.yml
block.c error: Move ERRP_GUARD() to the beginning of the function 2024-03-12 11:45:45 +01:00
blockdev-nbd.c
blockdev.c blockdev: Fix blockdev-snapshot-sync error reporting for no medium 2024-03-18 13:13:08 +01:00
blockjob.c block: remove AioContext locking 2023-12-21 22:49:27 +01:00
configure configure: put all symlink creation together 2024-02-16 13:56:09 +01:00
COPYING
COPYING.LIB
cpu-common.c system/cpus: rename qemu_mutex_lock_iothread() to bql_lock() 2024-01-08 10:45:43 -05:00
cpu-target.c cpu: Remove page_size_init 2024-02-29 11:35:37 -10:00
event-loop-base.c
gitdm.config
hmp-commands-info.hx hmp: Add option to info qtree to omit details 2024-03-09 19:17:01 +01:00
hmp-commands.hx hmp: Remove deprecated 'singlestep' command 2024-01-19 11:38:32 +01:00
iothread.c iothread: Simplify expression in qemu_in_iothread() 2024-02-13 10:59:25 +03:00
job-qmp.c
job.c block: remove AioContext locking 2023-12-21 22:49:27 +01:00
Kconfig
Kconfig.host build-sys: add a "pixman" feature 2023-11-07 14:04:24 +04:00
LICENSE
MAINTAINERS virtio,pc,pci: features, cleanups, fixes 2024-03-13 15:11:53 +00:00
Makefile Makefile: clean qemu-iotests output 2023-12-31 09:11:28 +01:00
meson_options.txt meson: fix type of "relocatable" option 2023-12-31 09:11:27 +01:00
meson.build Pull request 2024-03-13 12:37:15 +00:00
module-common.c
os-posix.c qemu_init: increase NOFILE soft limit on POSIX 2024-02-09 12:47:58 +00:00
os-win32.c
page-vary-common.c
page-vary-target.c
pythondeps.toml buildsys: Bump known good meson version to v1.2.3 2023-11-24 16:21:55 +01:00
qemu-bridge-helper.c
qemu-edid.c
qemu-img-cmds.hx docs/devel/docs: Document .hx file syntax 2024-01-15 17:12:22 +00:00
qemu-img.c block: remove AioContext locking 2023-12-21 22:49:27 +01:00
qemu-io-cmds.c
qemu-io.c block: remove AioContext locking 2023-12-21 22:49:27 +01:00
qemu-keymap.c
qemu-nbd.c qemu-nbd: mention --tls-hostname option in qemu-nbd --help 2024-02-13 10:59:25 +03:00
qemu-options.hx qemu-options.hx: Document the virtio-iommu-pci aw-bits option 2024-03-12 17:59:10 -04:00
qemu.nsi
qemu.sasl
README.rst
replication.c
trace-events
VERSION Open 9.0 development tree 2023-12-19 09:46:22 -05:00
version.rc

===========
QEMU README
===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Documentation
=============

Documentation can be found hosted online at
`<https://www.qemu.org/documentation/>`_. The documentation for the
current development version that is available at
`<https://www.qemu.org/docs/master/>`_ is generated from the ``docs/``
folder in the source tree, and is built by `Sphinx
<https://www.sphinx-doc.org/en/master/>`_.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:


.. code-block:: shell

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

* `<https://wiki.qemu.org/Hosts/Linux>`_
* `<https://wiki.qemu.org/Hosts/Mac>`_
* `<https://wiki.qemu.org/Hosts/W32>`_


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

.. code-block:: shell

   git clone https://gitlab.com/qemu-project/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the `style section
<https://www.qemu.org/docs/master/devel/style.html>`_ of
the Developers Guide.

Additional information on submitting patches can be found online via
the QEMU website

* `<https://wiki.qemu.org/Contribute/SubmitAPatch>`_
* `<https://wiki.qemu.org/Contribute/TrivialPatches>`_

The QEMU website is also maintained under source control.

.. code-block:: shell

  git clone https://gitlab.com/qemu-project/qemu-web.git

* `<https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/>`_

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

*  `<https://github.com/stefanha/git-publish>`_

The workflow with 'git-publish' is:

.. code-block:: shell

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

.. code-block:: shell

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses GitLab issues to track bugs. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

* `<https://gitlab.com/qemu-project/qemu/-/issues>`_

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via GitLab.

For additional information on bug reporting consult:

* `<https://wiki.qemu.org/Contribute/ReportABug>`_


ChangeLog
=========

For version history and release notes, please visit
`<https://wiki.qemu.org/ChangeLog/>`_ or look at the git history for
more detailed information.


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

* `<mailto:qemu-devel@nongnu.org>`_
* `<https://lists.nongnu.org/mailman/listinfo/qemu-devel>`_
* #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

* `<https://wiki.qemu.org/Contribute/StartHere>`_