qemu-e2k/include
Kevin Wolf ae5a40e858 mirror: Don't call job_pause_point() under graph lock
Calling job_pause_point() while holding the graph reader lock
potentially results in a deadlock: bdrv_graph_wrlock() first drains
everything, including the mirror job, which pauses it. The job is only
unpaused at the end of the drain section, which is when the graph writer
lock has been successfully taken. However, if the job happens to be
paused at a pause point where it still holds the reader lock, the writer
lock can't be taken as long as the job is still paused.

Mark job_pause_point() as GRAPH_UNLOCKED and fix mirror accordingly.

Cc: qemu-stable@nongnu.org
Buglink: https://issues.redhat.com/browse/RHEL-28125
Fixes: 004915a96a ("block: Protect bs->backing with graph_lock")
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20240313153000.33121-1-kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2024-03-18 12:03:04 +01:00
..
authz
block
chardev
crypto
disas disas: introduce show_opcodes 2024-03-06 12:35:51 +00:00
exec target-arm queue: 2024-03-05 13:54:54 +00:00
fpu
gdbstub gdbstub: Save target's siginfo 2024-03-13 11:43:52 +00:00
hw virtio,pc,pci: features, cleanups, fixes 2024-03-13 15:11:53 +00:00
io io: Add generic pwritev/preadv interface 2024-03-01 15:42:04 +08:00
libdecnumber
migration migration: purge MigrationState from public interface 2024-03-11 16:28:59 -04:00
monitor
net
qapi error: Add error_vprepend() in comment of ERRP_GUARD() rules 2024-03-12 11:45:33 +01:00
qemu mirror: Don't call job_pause_point() under graph lock 2024-03-18 12:03:04 +01:00
qom include/qom/object.h: New OBJECT_DEFINE_SIMPLE_TYPE{, _WITH_INTERFACES} macros 2024-02-27 13:01:42 +00:00
scsi
semihosting
standard-headers hw/virtio: Add support for VDPA network simulation devices 2024-03-12 17:56:55 -04:00
sysemu hw/acpi: Implement the SRAT GI affinity structure 2024-03-12 17:56:55 -04:00
tcg
ui
user {linux,bsd}-user: Introduce get_task_state() 2024-03-06 12:35:19 +00:00
elf.h
glib-compat.h
qemu-io.h
qemu-main.h