QEMU With E2K User Support
Go to file
Max Reitz a134d90f50 qcow2: Fix fail path in realloc_refcount_block()
If qcow2_alloc_clusters() fails, new_offset and ret will both be
negative after the fail label, thus passing the first if condition and
subsequently resulting in a call of qcow2_free_clusters() with an
invalid (negative) offset parameter. Fix this by introducing a new label
"fail_free_cluster" which is only invoked if new_offset is indeed
pointing to a newly allocated cluster that should be cleaned up by
freeing it.

While we're at it, clean up the whole fail path. qcow2_cache_put()
should (and actually can) never fail, hence the return value can safely
be ignored (aside from asserting that it indeed did not fail).

Furthermore, there is no reason to give QCOW2_DISCARD_ALWAYS to
qcow2_free_clusters(), a mere QCOW2_DISCARD_OTHER will suffice.

Ultimately, rename the "fail" label to "done", as it is invoked both on
failure and success.

Suggested-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-03-19 09:39:41 +01:00
audio Add the ability to vary Spice playback and record rates, to facilitate Opus support. 2014-02-03 11:05:15 +01:00
backends ui/sdl2 : initial port to SDL 2.0 (v2.0) 2014-03-05 09:52:05 +01:00
block qcow2: Fix fail path in realloc_refcount_block() 2014-03-19 09:39:41 +01:00
bsd-user cpu: Move opaque field from CPU_COMMON to CPUState 2014-03-13 19:20:47 +01:00
default-configs Add Enhanced Three-Speed Ethernet Controller (eTSEC) 2014-03-05 03:06:45 +01:00
disas libvixl: Fix format strings for several int64_t values 2014-03-10 14:56:29 +00:00
docs Docs: Introduce multiport serial support in qemupciserial.inf. 2014-03-12 15:03:42 +00:00
dtc@bc895d6d09
fpu softfloat: export squash_input_denormal functions 2014-03-17 16:31:51 +00:00
fsdev hw/9pfs: Include virtio-9p-device.o in build 2014-03-04 09:20:49 +05:30
gdb-xml
hw vnc: fix vmware VGA incompatiblities 2014-03-18 16:39:29 +00:00
include block: Add error handling to bdrv_invalidate_cache() 2014-03-19 09:39:41 +01:00
libcacard Add a 'name' parameter to qemu_thread_create 2014-03-09 21:09:38 +02:00
linux-headers update linux headers to kvm/next 2014-02-27 09:50:45 +01:00
linux-user exec: Change cpu_abort() argument to CPUState 2014-03-13 19:52:28 +01:00
net Net patches 2014-03-12 16:45:25 +00:00
pc-bios prep: Update ppc_rom.bin 2014-03-13 20:15:37 +01:00
pixman@97336fad32
po
qapi qapi: Add missing null check to opts_start_struct() 2014-03-03 11:17:45 -05:00
qga qga: Remove unneeded include file 2014-03-03 09:46:27 +04:00
qobject qdict: Extract non-QDicts in qdict_array_split() 2014-02-21 22:11:23 +01:00
qom cpu: Move tb_jmp_cache field from CPU_COMMON to CPUState 2014-03-13 19:20:46 +01:00
roms prep: Update ppc_rom.bin 2014-03-13 20:15:37 +01:00
scripts scripts/qemu-binfmt-conf.sh: Add AArch64 registration 2014-03-17 16:31:53 +00:00
slirp
stubs blockdev: Refuse to open encrypted image unless paused 2014-03-14 16:24:42 +01:00
sysconfigs/target
target-alpha target-alpha: fix subl and s8subl indentation 2014-03-17 13:21:12 +01:00
target-arm target-arm: A64: Add [UF]RSQRTE (reciprocal root estimate) 2014-03-17 16:31:53 +00:00
target-cris cputlb: Change tlb_set_page() argument to CPUState 2014-03-13 19:52:47 +01:00
target-i386 cputlb: Change tlb_set_page() argument to CPUState 2014-03-13 19:52:47 +01:00
target-lm32 cputlb: Change tlb_set_page() argument to CPUState 2014-03-13 19:52:47 +01:00
target-m68k cputlb: Change tlb_set_page() argument to CPUState 2014-03-13 19:52:47 +01:00
target-microblaze cputlb: Change tlb_set_page() argument to CPUState 2014-03-13 19:52:47 +01:00
target-mips cputlb: Change tlb_set_page() argument to CPUState 2014-03-13 19:52:47 +01:00
target-moxie cputlb: Change tlb_set_page() argument to CPUState 2014-03-13 19:52:47 +01:00
target-openrisc cputlb: Change tlb_set_page() argument to CPUState 2014-03-13 19:52:47 +01:00
target-ppc misc: Fix typos in comments 2014-03-15 13:54:18 +04:00
target-s390x cputlb: Change tlb_set_page() argument to CPUState 2014-03-13 19:52:47 +01:00
target-sh4 cputlb: Change tlb_set_page() argument to CPUState 2014-03-13 19:52:47 +01:00
target-sparc cputlb: Change tlb_set_page() argument to CPUState 2014-03-13 19:52:47 +01:00
target-unicore32 cputlb: Change tlb_set_page() argument to CPUState 2014-03-13 19:52:47 +01:00
target-xtensa cputlb: Change tlb_set_page() argument to CPUState 2014-03-13 19:52:47 +01:00
tcg tcg-sparc: Convert to new ldst opcodes 2014-03-17 11:13:26 -07:00
tests trivial patches for 2014-03-15 2014-03-15 18:22:11 +00:00
trace trace: Fix build warnings for Win32 build 2014-03-12 14:19:58 +01:00
ui ui/vnc: fix vmware VGA incompatiblities 2014-03-18 08:21:24 +01:00
util Block pull request 2014-03-13 15:33:04 +00:00
.exrc
.gitignore Add qga/qapi-generated to .gitignore 2014-03-15 13:54:18 +04:00
.gitmodules Add OpenHack'Ware submodule 2014-03-12 17:26:32 +01:00
.mailmap
.travis.yml .travis.yml: add IRC notifications for build failures 2014-03-15 13:54:18 +04:00
aio-posix.c
aio-win32.c
arch_init.c XBZRLE: Fix qemu crash when resize the xbzrle cache 2014-03-08 22:22:34 +01:00
async.c aio: add aio_context_acquire() and aio_context_release() 2014-03-13 14:42:24 +01:00
balloon.c
block-migration.c
block.c block: Add error handling to bdrv_invalidate_cache() 2014-03-19 09:39:41 +01:00
blockdev-nbd.c
blockdev.c blockdev: Fix NULL pointer dereference in blockdev-add 2014-03-06 17:27:28 +01:00
blockjob.c Use error_is_set() only when necessary 2014-02-17 11:57:23 -05:00
bt-host.c
bt-vhci.c
Changelog
CODING_STYLE
configure configure: Don't use __int128_t for clang versions before 3.2 2014-03-15 13:54:18 +04:00
COPYING
COPYING.LIB
coroutine-gthread.c
coroutine-sigaltstack.c
coroutine-ucontext.c
coroutine-win32.c
cpu-exec.c cpu-exec: Change cpu_resume_from_signal() argument to CPUState 2014-03-13 19:20:48 +01:00
cpus.c cpu: Move icount_decr field from CPU_COMMON to CPUState 2014-03-13 19:20:46 +01:00
cputlb.c cputlb: Change tlb_set_page() argument to CPUState 2014-03-13 19:52:47 +01:00
device_tree.c
device-hotplug.c hw/boards: Convert current_machine to MachineState 2014-03-12 20:13:02 +01:00
disas.c disas: Implement disassembly output for A64 2014-02-08 14:50:48 +00:00
dma-helpers.c
dump.c dump: add 'query-dump-guest-memory-capability' command 2014-02-28 11:52:03 -05:00
exec.c cputlb: Change tlb_flush() argument to CPUState 2014-03-13 19:52:47 +01:00
gdbstub.c exec: Change cpu_breakpoint_{insert,remove{,_by_ref,_all}} argument 2014-03-13 19:20:48 +01:00
HACKING
hmp-commands.hx
hmp.c dump: make kdump-compressed format available for 'dump-guest-memory' 2014-02-28 11:52:03 -05:00
hmp.h
iohandler.c
ioport.c
iothread.c qmp: add query-iothreads command 2014-03-13 14:42:24 +01:00
kvm-all.c Merge remote-tracking branch 'remotes/kvm/uq/master' into staging 2014-03-11 19:39:17 +00:00
kvm-stub.c Revert "KVM: Split QEMUMachine typedef into separate header" 2014-03-13 03:49:48 +01:00
LICENSE
main-loop.c main-loop: Suppress "I/O thread spun" warnings for qtest 2014-03-13 21:36:50 +01:00
MAINTAINERS acpi,pc,pci,virtio,memory bug fixes 2014-03-10 19:14:11 +00:00
Makefile Makefile: Fix "make clean" 2014-03-17 11:50:19 +00:00
Makefile.objs iothread: add I/O thread object 2014-03-13 14:42:24 +01:00
Makefile.target build: softmmu targets do not have a "main.o" file 2014-02-20 13:14:18 +01:00
memory_mapping.c
memory.c memory_region_present: return false if address is not found in child MemoryRegion 2014-03-09 21:09:37 +02:00
migration-exec.c
migration-fd.c
migration-rdma.c rdma: rename 'x-rdma' => 'rdma' 2014-02-25 14:30:28 +01:00
migration-tcp.c
migration-unix.c
migration.c block: Add error handling to bdrv_invalidate_cache() 2014-03-19 09:39:41 +01:00
module-common.c module: implement module loading 2014-02-20 13:14:18 +01:00
monitor.c input: mouse: switch monitor to new core 2014-03-05 09:52:03 +01:00
nbd.c nbd: move socket wrappers to qemu-nbd 2014-02-21 21:02:23 +01:00
os-posix.c oslib-posix: Fix build on FreeBSD 2014-03-13 14:34:16 +00:00
os-win32.c util: Split out exec_dir from os_find_datadir 2014-02-20 13:12:54 +01:00
page_cache.c Fix two XBZRLE corruption issues 2014-02-25 14:30:28 +01:00
qapi-schema.json qmp: add query-iothreads command 2014-03-13 14:42:24 +01:00
qdev-monitor.c qdev-monitor: Set properties after parent is assigned in device_add 2014-03-12 20:13:02 +01:00
qdict-test-data.txt
qemu-bridge-helper.c
qemu-char.c char: restore read callback on a reattached (hotplug) chardev 2014-03-13 10:33:45 +01:00
qemu-coroutine-io.c
qemu-coroutine-lock.c
qemu-coroutine-sleep.c
qemu-coroutine.c
qemu-doc.texi Describe flaws in qcow/qcow2 encryption in the docs 2014-01-31 22:05:03 +01:00
qemu-file.c qemu_file: Fix mismerge of "use fwrite() correctly" 2014-03-08 22:22:34 +01:00
qemu-img-cmds.hx
qemu-img.c qemu-img convert: Fix progress output 2014-03-05 15:58:32 +01:00
qemu-img.texi Describe flaws in qcow/qcow2 encryption in the docs 2014-01-31 22:05:03 +01:00
qemu-io-cmds.c qemu-io-cmds: Fixed typo in example for writev. 2014-03-19 09:39:41 +01:00
qemu-io.c qemu-io: Extended "--cmd" description in usage text 2014-03-19 09:39:41 +01:00
qemu-log.c
qemu-nbd.c qemu-nbd: Fix coverity issues 2014-03-17 13:21:11 +01:00
qemu-nbd.texi
qemu-options-wrapper.h
qemu-options.h
qemu-options.hx gtk: Allow to activate grab-on-hover from the command line 2014-03-17 14:33:55 +01:00
qemu-seccomp.c
qemu-tech.texi
qemu-timer.c
qemu.nsi
qemu.sasl sasl: Avoid 'Could not find keytab file' in syslog 2014-03-15 13:54:18 +04:00
qmp-commands.hx qmp: add query-iothreads command 2014-03-13 14:42:24 +01:00
qmp.c hw/boards: Convert current_machine to MachineState 2014-03-12 20:13:02 +01:00
qtest.c kvm: Add a new machine option kvm-type 2014-03-05 03:06:24 +01:00
README
rules.mak rules.mak: Fix per object libs extraction 2014-03-17 13:21:11 +01:00
savevm.c migration: extend section_start/end traces 2014-03-08 22:22:34 +01:00
spice-qemu-char.c spice: hook qemu_chr_fe_set_open() event to ports 2014-02-03 11:05:15 +01:00
tcg-runtime.c
tci.c
thread-pool.c Add a 'name' parameter to qemu_thread_create 2014-03-09 21:09:38 +02:00
thunk.c
tpm.c Use error_is_set() only when necessary 2014-02-17 11:57:23 -05:00
trace-events migration: extend section_start/end traces 2014-03-08 22:22:34 +01:00
translate-all.c exec: Change cpu_abort() argument to CPUState 2014-03-13 19:52:28 +01:00
translate-all.h translate-all: Change tb_check_watchpoint() argument to CPUState 2014-03-13 19:20:48 +01:00
user-exec.c user-exec: Change exception_action() argument to CPUState 2014-03-13 19:52:48 +01:00
VERSION Update version for v2.0-rc0 2014-03-13 20:08:15 -07:00
version.rc
vl.c gtk: warp bugfixes. 2014-03-17 15:51:57 +00:00
vmstate.c Fix vmstate_info_int32_le comparison/assign 2014-02-25 14:30:28 +01:00
xbzrle.c
xen-all.c kvm: Add a new machine option kvm-type 2014-03-05 03:06:24 +01:00
xen-mapcache.c
xen-stub.c kvm: Add a new machine option kvm-type 2014-03-05 03:06:24 +01:00

Read the documentation in qemu-doc.html or on http://wiki.qemu-project.org

- QEMU team