QEMU With E2K User Support
Go to file
Markus Armbruster b69c3c21a5 qdev: Unrealize must not fail
Devices may have component devices and buses.

Device realization may fail.  Realization is recursive: a device's
realize() method realizes its components, and device_set_realized()
realizes its buses (which should in turn realize the devices on that
bus, except bus_set_realized() doesn't implement that, yet).

When realization of a component or bus fails, we need to roll back:
unrealize everything we realized so far.  If any of these unrealizes
failed, the device would be left in an inconsistent state.  Must not
happen.

device_set_realized() lets it happen: it ignores errors in the roll
back code starting at label child_realize_fail.

Since realization is recursive, unrealization must be recursive, too.
But how could a partly failed unrealize be rolled back?  We'd have to
re-realize, which can fail.  This design is fundamentally broken.

device_set_realized() does not roll back at all.  Instead, it keeps
unrealizing, ignoring further errors.

It can screw up even for a device with no buses: if the lone
dc->unrealize() fails, it still unregisters vmstate, and calls
listeners' unrealize() callback.

bus_set_realized() does not roll back either.  Instead, it stops
unrealizing.

Fortunately, no unrealize method can fail, as we'll see below.

To fix the design error, drop parameter @errp from all the unrealize
methods.

Any unrealize method that uses @errp now needs an update.  This leads
us to unrealize() methods that can fail.  Merely passing it to another
unrealize method cannot cause failure, though.  Here are the ones that
do other things with @errp:

* virtio_serial_device_unrealize()

  Fails when qbus_set_hotplug_handler() fails, but still does all the
  other work.  On failure, the device would stay realized with its
  resources completely gone.  Oops.  Can't happen, because
  qbus_set_hotplug_handler() can't actually fail here.  Pass
  &error_abort to qbus_set_hotplug_handler() instead.

* hw/ppc/spapr_drc.c's unrealize()

  Fails when object_property_del() fails, but all the other work is
  already done.  On failure, the device would stay realized with its
  vmstate registration gone.  Oops.  Can't happen, because
  object_property_del() can't actually fail here.  Pass &error_abort
  to object_property_del() instead.

* spapr_phb_unrealize()

  Fails and bails out when remove_drcs() fails, but other work is
  already done.  On failure, the device would stay realized with some
  of its resources gone.  Oops.  remove_drcs() fails only when
  chassis_from_bus()'s object_property_get_uint() fails, and it can't
  here.  Pass &error_abort to remove_drcs() instead.

Therefore, no unrealize method can fail before this patch.

device_set_realized()'s recursive unrealization via bus uses
object_property_set_bool().  Can't drop @errp there, so pass
&error_abort.

We similarly unrealize with object_property_set_bool() elsewhere,
always ignoring errors.  Pass &error_abort instead.

Several unrealize methods no longer handle errors from other unrealize
methods: virtio_9p_device_unrealize(),
virtio_input_device_unrealize(), scsi_qdev_unrealize(), ...
Much of the deleted error handling looks wrong anyway.

One unrealize methods no longer ignore such errors:
usb_ehci_pci_exit().

Several realize methods no longer ignore errors when rolling back:
v9fs_device_realize_common(), pci_qdev_unrealize(),
spapr_phb_realize(), usb_qdev_realize(), vfio_ccw_realize(),
virtio_device_realize().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-17-armbru@redhat.com>
2020-05-15 07:08:14 +02:00
.github .github: Enable repo-lockdown bot to refuse GitHub pull requests 2020-04-07 16:19:18 +01:00
.gitlab-ci.d gitlab-ci.yml: Add jobs to build OpenSBI firmware binaries 2020-03-16 17:03:50 -07:00
accel qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
audio dsoundaudio: dsound_get_buffer_in should honor *size 2020-04-06 13:29:53 +02:00
authz qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
backends qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
block qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
bsd-user gdbstub/linux-user: support debugging over a unix socket 2020-05-06 09:29:26 +01:00
capstone@22ead3e0bf
chardev qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
contrib vhost-user-gpu: Release memory returned by vu_queue_pop() with free() 2020-04-15 19:00:39 +01:00
crypto qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
default-configs ACPI: Build related register address fields via hardware error fw_cfg blob 2020-05-14 15:03:09 +01:00
disas target/mips: Add implementation of GINVT instruction 2020-01-29 19:28:52 +01:00
docs docs: APEI GHES generation and CPER record description 2020-05-14 15:03:09 +01:00
dtc@88f18909db
dump various: Remove suspicious '\' character outside of #define in C code 2020-04-29 08:01:51 +02:00
fpu softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal 2020-04-07 16:19:49 +01:00
fsdev virtfs-proxy-helper: Make the helper_opts[] array const 2020-03-09 15:59:31 +01:00
gdb-xml target/arm: Use correct GDB XML for M-profile cores 2020-05-14 15:03:08 +01:00
hw qdev: Unrealize must not fail 2020-05-15 07:08:14 +02:00
include qdev: Unrealize must not fail 2020-05-15 07:08:14 +02:00
io io: Fix qio_channel_socket_close() error handling 2020-04-29 08:01:52 +02:00
libdecnumber
linux-headers linux-headers: update against Linux 5.7-rc3 2020-04-28 12:29:01 +02:00
linux-user gdbstub/linux-user: support debugging over a unix socket 2020-05-06 09:29:26 +01:00
migration migration/multifd: Do error_free after migrate_set_error to avoid memleaks 2020-05-07 17:40:24 +01:00
monitor qom: Clean up inconsistent use of gchar * vs. char * 2020-05-15 06:26:02 +02:00
nbd nbd/server: use bdrv_dirty_bitmap_next_dirty_area 2020-03-18 14:03:46 -04:00
net qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
pc-bios roms: opensbi: Upgrade from v0.6 to v0.7 2020-04-29 13:16:38 -07:00
plugins lockable: add QemuRecMutex support 2020-03-17 15:18:45 +01:00
po
python/qemu python/qemu: Kill QEMU process if 'quit' doesn't work 2020-03-21 22:37:32 +00:00
qapi qcow2: add zstd cluster compression 2020-05-13 14:20:31 +02:00
qga qga: Fix qmp_guest_suspend_{disk, ram}() error handling 2020-04-29 08:01:52 +02:00
qobject qobject: Eliminate qdict_iter(), use qdict_first(), qdict_next() 2020-04-30 06:51:15 +02:00
qom qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
replay
roms roms: opensbi: Upgrade from v0.6 to v0.7 2020-04-29 13:16:38 -07:00
scripts checkpatch: ignore allowed diff list 2020-05-04 10:25:02 -04:00
scsi qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
slirp@2faae0f778 slirp: update to fix CVE-2020-1983 2020-04-21 18:39:20 +01:00
softmmu qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
storage-daemon qemu-storage-daemon: Add --monitor option 2020-03-06 17:21:28 +01:00
stubs hmp: Fail gracefully if chardev is already in use 2020-03-06 17:21:28 +01:00
target qdev: Unrealize must not fail 2020-05-15 07:08:14 +02:00
tcg tcg: Fix integral argument type to tcg_gen_rot[rl]i_i{32,64} 2020-05-06 09:25:10 -07:00
tests qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
tools/virtiofsd virtiofsd: drop all capabilities in the wait parent process 2020-05-01 20:05:37 +01:00
trace tracing: only allow -trace to override -D if set 2020-02-25 20:20:23 +00:00
ui qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
util nbd patches for 2020-05-04 2020-05-05 15:47:44 +01:00
.cirrus.yml .cirrus.yml: bootstrap pkg unconditionally 2020-05-06 09:29:03 +01:00
.dir-locals.el
.editorconfig
.exrc
.gdbinit
.gitignore docs: Stop building qemu-doc 2020-03-06 11:06:55 +00:00
.gitlab-ci-edk2.yml gitlab-ci.yml: Add jobs to build EDK2 firmware binaries 2020-01-21 14:15:48 +01:00
.gitlab-ci-opensbi.yml gitlab-ci.yml: Add jobs to build OpenSBI firmware binaries 2020-03-16 17:03:50 -07:00
.gitlab-ci.yml gitlab-ci.yml: Add jobs to build OpenSBI firmware binaries 2020-03-16 17:03:50 -07:00
.gitmodules hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS 2020-02-02 14:07:57 +11:00
.gitpublish
.mailmap MAINTAINERS: Adjust maintainer's email 2020-03-17 13:51:24 +01:00
.patchew.yml
.readthedocs.yml .readthedocs.yml: specify some minimum python requirements 2020-02-07 15:15:16 +01:00
.shippable.yml .shippable: --disable-docs for cross-compile tests 2020-02-04 17:13:29 +00:00
.travis.yml .travis.yml: reduce the load on [ppc64] GCC check-tcg 2020-05-06 09:29:26 +01:00
arch_init.c Add rx-softmmu 2020-03-19 17:58:05 +01:00
balloon.c
block.c block: Drop unused .bdrv_has_zero_init_truncate 2020-05-08 13:26:35 +02:00
blockdev-nbd.c blockdev-nbd: Boxed argument type for nbd-server-add 2020-03-06 17:21:28 +01:00
blockdev.c block: Add blk_new_with_bs() helper 2020-05-05 13:17:36 +02:00
blockjob.c block: Add blk_new_with_bs() helper 2020-05-05 13:17:36 +02:00
bootdevice.c Drop more @errp parameters after previous commit 2020-05-15 07:08:14 +02:00
Changelog
CODING_STYLE.rst
configure target/arm: Use correct GDB XML for M-profile cores 2020-05-14 15:03:08 +01:00
COPYING
COPYING.LIB
cpus-common.c lockable: replaced locks with lock guard macros where appropriate 2020-05-04 16:07:43 +01:00
cpus.c cpus: Proper range-checking for -icount shift=N 2020-04-29 08:01:52 +02:00
device_tree.c device_tree: Constify compat in qemu_fdt_node_path() 2020-04-30 15:35:41 +01:00
disas.c
dma-helpers.c Avoid address_space_rw() with a constant is_write argument 2020-02-20 14:47:08 +01:00
exec-vary.c
exec.c exec: Fix cpu_watchpoint_address_matches address length 2020-05-11 11:14:02 +01:00
gdbstub.c gdbstub/linux-user: support debugging over a unix socket 2020-05-06 09:29:26 +01:00
gitdm.config
hmp-commands-info.hx Update comments in .hx files that mention Texinfo 2020-03-12 11:14:05 +00:00
hmp-commands.hx Update comments in .hx files that mention Texinfo 2020-03-12 11:14:05 +00:00
ioport.c
iothread.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
job-qmp.c job: take each job's lock individually in job_txn_apply 2020-04-07 14:34:47 +02:00
job.c job: take each job's lock individually in job_txn_apply 2020-04-07 14:34:47 +02:00
Kconfig.host
LICENSE
MAINTAINERS target-arm queue: 2020-05-14 16:17:55 +01:00
Makefile Makefile: Drop unused, broken target recurse-fuzz 2020-04-29 08:01:52 +02:00
Makefile.objs aspeed/smc: Add some tracing 2020-03-12 16:01:37 +00:00
Makefile.target update syscall numbers to linux 5.5 (with scripts) 2020-03-20 16:00:21 +00:00
memory_ldst.inc.c
memory_mapping.c
memory.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
module-common.c
os-posix.c
os-win32.c
qdev-monitor.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
qemu-bridge-helper.c
qemu-edid.c
qemu-img-cmds.hx qemu-img: Add --target-is-zero to convert 2020-02-20 16:43:42 +01:00
qemu-img.c block-backend: Add flags to blk_truncate() 2020-04-30 17:51:07 +02:00
qemu-io-cmds.c block-backend: Add flags to blk_truncate() 2020-04-30 17:51:07 +02:00
qemu-io.c qemu-io: adds option to use aio engine 2020-01-30 20:59:42 +00:00
qemu-keymap.c
qemu-nbd.c qemu-nbd: Removed deprecated --partition option 2020-02-05 17:29:49 -06:00
qemu-options-wrapper.h
qemu-options.h
qemu-options.hx qemu-options.hx: 9p: clarify -virtfs vs. -fsdev 2020-05-14 08:06:43 +02:00
qemu-seccomp.c
qemu-storage-daemon.c qemu-storage-daemon: Fix non-string --object properties 2020-04-30 17:51:07 +02:00
qemu.nsi qemu.nsi: Install Sphinx documentation 2020-03-09 16:45:00 +00:00
qemu.sasl
qtest.c qtest: fix fuzzer-related 80-char limit violations 2020-03-06 10:33:26 +00:00
README.rst
replication.c
replication.h
rules.mak build-sys: Move the print-variable rule to rules.mak 2020-03-09 15:59:31 +01:00
thunk.c
tpm.c
trace-events
VERSION Open 5.1 development tree 2020-04-29 15:07:10 +01:00
version.rc

===========
QEMU README
===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:


.. code-block:: shell

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

* `<https://qemu.org/Hosts/Linux>`_
* `<https://qemu.org/Hosts/Mac>`_
* `<https://qemu.org/Hosts/W32>`_


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

.. code-block:: shell

   git clone https://git.qemu.org/git/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the CODING_STYLE.rst file.

Additional information on submitting patches can be found online via
the QEMU website

* `<https://qemu.org/Contribute/SubmitAPatch>`_
* `<https://qemu.org/Contribute/TrivialPatches>`_

The QEMU website is also maintained under source control.

.. code-block:: shell

  git clone https://git.qemu.org/git/qemu-web.git

* `<https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/>`_

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

*  `<https://github.com/stefanha/git-publish>`_

The workflow with 'git-publish' is:

.. code-block:: shell

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

.. code-block:: shell

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses Launchpad as its primary upstream bug tracker. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

* `<https://bugs.launchpad.net/qemu/>`_

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via launchpad.

For additional information on bug reporting consult:

* `<https://qemu.org/Contribute/ReportABug>`_


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

* `<mailto:qemu-devel@nongnu.org>`_
* `<https://lists.nongnu.org/mailman/listinfo/qemu-devel>`_
* #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

* `<https://qemu.org/Contribute/StartHere>`_