Markus Armbruster
bf83f04e13
qapi: Fix doc comment checking for commands and events
...
When a command's 'data' is an object, its doc comment describes the
arguments defined there. When 'data' names a type, the doc comment
does not describe arguments. Instead, the doc generator inserts a
pointer to the named type.
An event's doc comment works the same.
We don't actually check doc comments for commands and events.
Instead, QAPISchema._def_command() forwards the doc comment to the
implicit argument type, where it gets checked. Works because the
check only cares for the implicit argument type's members.
Not only is this needlessly hard to understand, it actually falls
apart in two cases:
* When 'data' is empty, there is nothing to forward to, and the doc
comment remains unchecked. Demonstrated by test doc-bad-event-arg.
* When 'data' names a type, we can't forward, as the type has its own
doc comment. The command or event's doc comment remains unchecked.
Demonstrated by test doc-bad-boxed-command-arg.
The forwarding goes back to commit 069fb5b250 "qapi: Prepare for
requiring more complete documentation", put to use in commit
816a57cd6e "qapi: Fix detection of bogus member documentation". That
fix was incomplete.
To fix this, make QAPISchemaCommand and QAPISchemaEvent check doc
comments, and drop the forwarding of doc comments to implicit argument
types.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20191024110237.30963-12-armbru@redhat.com>
2019-10-29 07:35:16 +01:00
..
2019-03-05 14:43:11 +01:00
2019-10-22 09:26:12 +02:00
2018-05-30 13:19:14 -03:00
2018-05-30 13:19:14 -03:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2016-02-19 11:08:56 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:23 +02:00
2019-09-24 14:07:23 +02:00
2019-10-22 09:26:12 +02:00
2017-05-31 16:04:05 +02:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2017-09-01 12:51:04 +02:00
2017-09-01 12:51:04 +02:00
2019-10-22 09:26:12 +02:00
2017-05-31 16:04:09 +02:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2017-05-31 16:04:09 +02:00
2017-05-31 16:04:09 +02:00
2019-10-22 09:26:12 +02:00
2017-05-31 16:04:09 +02:00
2017-05-31 16:04:09 +02:00
2019-10-22 09:26:12 +02:00
2017-09-01 12:51:04 +02:00
2017-09-01 12:51:04 +02:00
2019-10-22 09:26:12 +02:00
2017-05-31 16:04:09 +02:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:22 +02:00
2016-02-19 11:08:56 +01:00
2019-10-22 09:26:12 +02:00
2018-12-13 19:20:11 +01:00
2018-12-13 19:20:11 +01:00
2019-10-22 09:26:12 +02:00
2017-05-31 16:04:05 +02:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2017-05-31 16:04:05 +02:00
2015-09-04 15:47:15 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-09-21 09:56:49 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-09-04 15:47:15 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-09-04 15:47:15 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2016-07-19 13:21:08 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2016-07-19 13:21:08 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2016-07-19 13:21:08 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-09-04 15:47:15 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-09-04 15:47:16 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-09-04 15:47:15 +02:00
2019-10-22 09:26:12 +02:00
2019-09-28 17:17:18 +02:00
2015-12-17 08:21:29 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-09-04 15:47:15 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-12-17 08:21:27 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-09-04 15:47:15 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-09-04 15:47:15 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2018-07-03 18:21:24 +02:00
2018-07-03 18:21:24 +02:00
2019-10-22 09:26:12 +02:00
2018-07-03 18:21:24 +02:00
2018-07-03 18:21:24 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:23 +02:00
2018-07-03 18:21:24 +02:00
2019-10-22 09:26:12 +02:00
2018-07-03 18:21:24 +02:00
2018-07-03 18:21:24 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:23 +02:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-12-17 08:21:29 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-12-17 08:21:29 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2017-03-16 07:13:01 +01:00
2019-02-18 14:44:04 +01:00
2019-10-22 09:26:12 +02:00
2017-05-31 16:04:05 +02:00
2017-03-16 07:13:03 +01:00
2019-10-29 07:35:16 +01:00
2019-10-29 07:35:16 +01:00
2019-10-29 07:35:16 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:03 +01:00
2017-03-16 07:13:03 +01:00
2019-10-29 07:35:16 +01:00
2019-10-29 07:35:16 +01:00
2019-10-29 07:35:16 +01:00
2019-10-29 07:35:16 +01:00
2019-10-29 07:35:16 +01:00
2019-10-29 07:35:16 +01:00
2019-10-29 07:35:16 +01:00
2019-10-29 07:35:16 +01:00
2019-10-29 07:35:16 +01:00
2017-12-20 19:18:33 +01:00
2017-12-20 19:18:33 +01:00
2019-02-18 14:44:04 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:03 +01:00
2017-03-16 07:13:04 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:03 +01:00
2017-03-16 07:13:03 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:03 +01:00
2017-03-16 07:13:03 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2017-03-21 10:42:55 +01:00
2019-10-29 07:35:16 +01:00
2019-10-29 07:35:16 +01:00
2019-10-29 07:35:16 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-01-16 10:10:35 +01:00
2017-01-16 10:10:35 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2017-03-16 07:13:01 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:03 +01:00
2017-03-16 07:13:03 +01:00
2019-10-29 07:35:16 +01:00
2019-10-29 07:35:16 +01:00
2019-10-29 07:35:16 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:22 +02:00
2019-02-18 14:44:04 +01:00
2019-10-22 09:26:12 +02:00
2018-12-13 19:20:11 +01:00
2018-12-13 19:20:11 +01:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:22 +02:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-09-15 10:59:28 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2018-12-13 19:20:11 +01:00
2018-12-13 19:20:11 +01:00
2019-10-22 09:26:12 +02:00
2018-12-13 19:20:11 +01:00
2018-12-13 19:20:11 +01:00
2019-10-22 09:26:12 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:02 +01:00
2015-12-17 08:21:29 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2016-07-19 13:21:08 +02:00
2015-05-05 18:39:01 +02:00
2017-03-16 07:13:01 +01:00
2019-10-22 13:54:13 +02:00
2019-10-22 09:26:12 +02:00
2018-12-13 19:20:11 +01:00
2018-12-13 19:20:11 +01:00
2019-10-22 09:26:12 +02:00
2018-12-13 19:20:11 +01:00
2014-06-23 11:01:25 -04:00
2019-10-22 09:26:12 +02:00
2019-06-12 18:35:26 +02:00
2019-06-12 18:35:26 +02:00
2019-10-22 09:26:12 +02:00
2019-06-12 18:35:26 +02:00
2019-06-12 18:35:26 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:23 +02:00
2019-09-24 14:07:23 +02:00
2019-10-22 09:26:12 +02:00
2019-06-12 18:35:26 +02:00
2019-06-12 18:35:26 +02:00
2019-10-22 09:26:12 +02:00
2019-06-12 18:35:26 +02:00
2019-06-12 18:35:26 +02:00
2019-10-22 09:26:12 +02:00
2019-06-12 18:35:26 +02:00
2019-06-12 18:35:26 +02:00
2019-10-22 09:26:12 +02:00
2019-06-12 18:35:26 +02:00
2019-06-12 18:35:26 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-06-18 14:19:47 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-09-21 09:56:49 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-10-12 18:44:54 +02:00
2019-10-22 09:26:12 +02:00
2019-09-28 17:17:19 +02:00
2019-09-24 14:07:22 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:22 +02:00
2016-02-19 11:08:56 +01:00
2019-10-22 09:26:12 +02:00
2018-12-13 19:20:11 +01:00
2018-12-13 19:20:11 +01:00
2019-10-22 09:26:12 +02:00
2018-12-13 19:20:11 +01:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:23 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:23 +02:00
2018-12-13 19:20:11 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2019-10-22 09:26:12 +02:00
2019-09-28 17:17:19 +02:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:23 +02:00
2019-09-24 14:07:23 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:22 +02:00
2019-09-24 14:07:22 +02:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2017-03-16 07:13:01 +01:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2015-10-12 18:44:54 +02:00
2019-02-18 14:44:04 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2019-02-18 14:44:04 +01:00
2017-03-16 07:13:01 +01:00
2019-10-22 13:54:13 +02:00
2019-10-22 09:26:12 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2019-10-22 09:26:12 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2018-12-13 19:20:11 +01:00
2018-12-13 19:20:11 +01:00
2019-10-22 09:26:12 +02:00
2018-12-13 19:20:11 +01:00
2015-05-05 18:39:02 +02:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2018-03-27 10:17:45 -05:00
2018-03-27 10:17:45 -05:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2017-03-16 07:13:01 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2017-03-16 07:13:01 +01:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:23 +02:00
2017-03-16 07:13:02 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2017-03-16 07:13:01 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:02 +01:00
2017-03-16 07:13:02 +01:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:22 +02:00
2019-09-24 14:07:22 +02:00
2019-10-22 13:54:13 +02:00
2019-10-22 13:54:13 +02:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-11-02 08:30:26 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-12-17 08:21:27 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-11-02 08:30:26 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-11-02 08:30:26 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-11-02 08:30:28 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-12-17 08:21:27 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-11-02 08:30:25 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-11-02 08:30:26 +01:00
2019-10-22 09:26:12 +02:00
2017-05-31 16:04:05 +02:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-09-04 15:47:15 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:02 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:22 +02:00
2019-09-24 14:07:22 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:22 +02:00
2019-09-24 14:07:22 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:02 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:02 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-09-04 15:47:16 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:23 +02:00
2019-09-24 14:07:23 +02:00
2019-10-22 09:26:12 +02:00
2018-12-13 19:20:11 +01:00
2018-12-13 19:20:11 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-09-04 15:47:16 +02:00
2019-03-05 14:43:11 +01:00
2019-10-29 07:35:16 +01:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:02 +01:00
2017-03-16 07:13:02 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:00 +02:00
2019-10-22 09:26:12 +02:00
2019-09-28 17:17:18 +02:00
2015-12-17 08:21:29 +01:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:23 +02:00
2019-09-24 14:07:23 +02:00
2019-10-22 09:26:12 +02:00
2018-12-13 19:20:11 +01:00
2018-12-13 19:20:11 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-10-12 18:44:54 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:22 +02:00
2016-02-19 11:08:56 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2019-10-22 09:26:12 +02:00
2017-03-16 07:13:01 +01:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2019-09-28 17:17:19 +02:00
2015-05-05 18:39:01 +02:00
2019-10-22 09:26:12 +02:00
2019-09-24 14:07:22 +02:00
2015-05-05 18:39:02 +02:00
2019-10-22 09:26:12 +02:00
2018-12-13 19:20:11 +01:00
2015-05-05 18:39:01 +02:00