QEMU With E2K User Support
Go to file
Vladimir Sementsov-Ogievskiy d12ade5732 mirror: fix dead-lock
Let start from the beginning:

Commit b9e413dd37 (in 2.9)
"block: explicitly acquire aiocontext in aio callbacks that need it"
added pairs of aio_context_acquire/release to mirror_write_complete and
mirror_read_complete, when they were aio callbacks for blk_aio_* calls.

Then, commit 2e1990b26e (in 3.0) "block/mirror: Convert to coroutines"
dropped these blk_aio_* calls, than mirror_write_complete and
mirror_read_complete are not callbacks more, and don't need additional
aiocontext acquiring. Furthermore, mirror_read_complete calls
blk_co_pwritev inside these pair of aio_context_acquire/release, which
leads to the following dead-lock with mirror:

 (gdb) info thr
   Id   Target Id         Frame
   3    Thread (LWP 145412) "qemu-system-x86" syscall ()
   2    Thread (LWP 145416) "qemu-system-x86" __lll_lock_wait ()
 * 1    Thread (LWP 145411) "qemu-system-x86" __lll_lock_wait ()

 (gdb) bt
 #0  __lll_lock_wait ()
 #1  _L_lock_812 ()
 #2  __GI___pthread_mutex_lock
 #3  qemu_mutex_lock_impl (mutex=0x561032dce420 <qemu_global_mutex>,
     file=0x5610327d8654 "util/main-loop.c", line=236) at
     util/qemu-thread-posix.c:66
 #4  qemu_mutex_lock_iothread_impl
 #5  os_host_main_loop_wait (timeout=480116000) at util/main-loop.c:236
 #6  main_loop_wait (nonblocking=0) at util/main-loop.c:497
 #7  main_loop () at vl.c:1892
 #8  main

Printing contents of qemu_global_mutex, I see that "__owner = 145416",
so, thr1 is main loop, and now it wants BQL, which is owned by thr2.

 (gdb) thr 2
 (gdb) bt
 #0  __lll_lock_wait ()
 #1  _L_lock_870 ()
 #2  __GI___pthread_mutex_lock
 #3  qemu_mutex_lock_impl (mutex=0x561034d25dc0, ...
 #4  aio_context_acquire (ctx=0x561034d25d60)
 #5  dma_blk_cb
 #6  dma_blk_io
 #7  dma_blk_read
 #8  ide_dma_cb
 #9  bmdma_cmd_writeb
 #10 bmdma_write
 #11 memory_region_write_accessor
 #12 access_with_adjusted_size
 #15 flatview_write
 #16 address_space_write
 #17 address_space_rw
 #18 kvm_handle_io
 #19 kvm_cpu_exec
 #20 qemu_kvm_cpu_thread_fn
 #21 qemu_thread_start
 #22 start_thread
 #23 clone ()

Printing mutex in fr 2, I see "__owner = 145411", so thr2 wants aio
context mutex, which is owned by thr1. Classic dead-lock.

Then, let's check that aio context is hold by mirror coroutine: just
print coroutine stack of first tracked request in mirror job target:

 (gdb) [...]
 (gdb) qemu coroutine 0x561035dd0860
 #0  qemu_coroutine_switch
 #1  qemu_coroutine_yield
 #2  qemu_co_mutex_lock_slowpath
 #3  qemu_co_mutex_lock
 #4  qcow2_co_pwritev
 #5  bdrv_driver_pwritev
 #6  bdrv_aligned_pwritev
 #7  bdrv_co_pwritev
 #8  blk_co_pwritev
 #9  mirror_read_complete () at block/mirror.c:232
 #10 mirror_co_read () at block/mirror.c:370
 #11 coroutine_trampoline
 #12 __start_context

Yes it is mirror_read_complete calling blk_co_pwritev after acquiring
aio context.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2018-12-03 16:50:58 +01:00
accel cputlb: Remove tlb_c.pending_flushes 2018-10-31 12:16:39 +00:00
audio pulseaudio: process audio data in smaller chunks 2018-11-12 14:15:13 +01:00
backends hostmem: no need to check for host_memory_backend_mr_inited() in alloc() 2018-11-28 11:51:24 +01:00
block mirror: fix dead-lock 2018-12-03 16:50:58 +01:00
bsd-user
capstone@22ead3e0bf
chardev chardev: Indent list of chardevs 2018-11-05 15:18:00 +01:00
contrib contrib: add elf2dmp tool 2018-10-02 19:09:12 +02:00
crypto io: return 0 for EOF in TLS session read after shutdown 2018-11-19 11:16:46 -06:00
default-configs hw/ppc/spapr_rng: Introduce CONFIG_SPAPR_RNG switch for spapr_rng.c 2018-11-08 12:04:40 +11:00
disas target/mips: Add disassembler support for nanoMIPS 2018-10-25 22:13:33 +02:00
docs qcow2: Document some maximum size constraints 2018-11-19 12:51:40 +01:00
dtc@88f18909db Update dtc/libfdt submodule to v1.4.7 2018-10-02 13:53:26 +10:00
fpu qemu/compiler: Wrap __attribute__((flatten)) in a macro 2018-10-17 08:36:28 +02:00
fsdev fsdev: Clean up error reporting in qemu_fsdev_add() 2018-10-19 14:51:34 +02:00
gdb-xml
hw i2c: Add a length check to the SMBus write handling 2018-12-03 13:00:38 +00:00
include vmstate: constify VMStateField 2018-11-27 15:35:15 +01:00
io io: return 0 for EOF in TLS session read after shutdown 2018-11-19 11:16:46 -06:00
libdecnumber
linux-headers linux-headers: update to 4.20-rc1 2018-10-19 13:44:11 +02:00
linux-user linux-user: Update MIPS specific prctl() implementation 2018-11-17 19:29:34 +01:00
migration vmstate: constify VMStateField 2018-11-27 15:35:15 +01:00
nbd nbd/server: Ignore write errors when replying to NBD_OPT_ABORT 2018-11-19 11:16:46 -06:00
net net/filter-rewriter.c: Fix coverity static analysis issue 2018-11-16 11:08:26 +08:00
pc-bios update seabios to 1.12 2018-11-20 06:57:53 +01:00
po po/Makefile: Modern shell scripting (use $() instead of ``) 2018-10-24 07:39:10 +01:00
qapi qapi: add query-display-options command 2018-11-27 07:47:57 +01:00
qga qga: Add multiple include guard to guest-agent-core.h 2018-11-09 07:55:13 -06:00
qobject qobject: Catch another straggler for use of qdict_put_str() 2018-10-26 17:17:32 +02:00
qom Error reporting patches for 2018-10-22 2018-10-23 17:20:23 +01:00
replay replay: Exit on errors reading from replay log 2018-11-08 13:24:35 +00:00
roms update seabios to 1.12 2018-11-20 06:57:53 +01:00
scripts checkpatch: g_test_message does not need a trailing newline 2018-11-27 15:35:19 +01:00
scsi scsi: Address spurious clang warning 2018-11-27 23:56:12 +00:00
slirp slirp: fork_exec(): create and connect child socket before fork() 2018-11-10 15:07:53 +01:00
stubs Error reporting patches for 2018-10-22 2018-10-23 17:20:23 +01:00
target i386: hvf: Fix overrun of _decode_tbl1 2018-12-03 15:09:55 +00:00
tcg tcg/tcg-op.h: Add multiple include guard 2018-11-08 15:15:32 +00:00
tests * lsi HBA reselection fix (George) 2018-11-28 11:32:33 +00:00
trace tracing: Use double-dash spelling for trace option 2018-07-19 13:09:04 +01:00
ui ui: Allow specifying 'rendernode' display option for egl-headless 2018-11-16 11:44:22 +01:00
util vfio-helpers: Fix qemu_vfio_open_pci() crash 2018-11-27 18:39:32 +00:00
.dir-locals.el
.editorconfig editorconfig: set emacs mode 2018-11-01 12:13:12 +04:00
.exrc
.gdbinit
.gitignore edid: Ignore built binary 2018-10-05 11:20:55 +02:00
.gitmodules gitmodules: use 'https://' instead of 'git://' 2018-11-12 11:26:02 +00:00
.gitpublish
.mailmap mailmap: Add an item for Yongbok Kim 2018-10-18 20:37:20 +02:00
.shippable.yml
.travis.yml .travis.yml: split MacOSX builds and reduce target list 2018-11-14 10:20:23 +00:00
arch_init.c
balloon.c balloon: Allow multiple inhibit users 2018-08-17 09:27:15 -06:00
block.c block: Don't inactivate children before parents 2018-11-27 12:59:00 +01:00
blockdev-nbd.c nbd/server: drop old-style negotiation 2018-10-03 15:52:32 -05:00
blockdev.c blockdev: Consistently use snapshot_node_name in external_snapshot_prepare() 2018-11-12 17:46:57 +01:00
blockjob.c block: Use a single global AioWait 2018-09-25 15:50:15 +02:00
bootdevice.c fw_cfg: ignore suffixes in the bootdevice list dependent on machine class 2018-08-16 22:27:43 -03:00
bt-host.c
bt-vhci.c
Changelog
CODING_STYLE
configure qemu-iotests: convert pwd and $(pwd) to $PWD 2018-11-19 10:08:19 -06:00
COPYING
COPYING.LIB
cpus-common.c qom: convert the CPU list to RCU 2018-08-23 18:46:25 +02:00
cpus.c cpus: run work items for all vCPUs if single-threaded 2018-11-27 15:06:14 +01:00
device_tree.c
device-hotplug.c blockdev: Convert drive_new() to Error 2018-10-19 14:51:34 +02:00
disas.c
dma-helpers.c
dump.c qapi: Drop qapi_event_send_FOO()'s Error ** argument 2018-08-28 18:21:38 +02:00
exec.c exec: introduce tlb_init 2018-10-18 18:58:10 -07:00
gdbstub.c gdbstub: Remove unused include 2018-10-16 18:10:55 +02:00
HACKING
hmp-commands-info.hx hmp-commands-info: add sync-profile 2018-08-23 18:46:25 +02:00
hmp-commands.hx hmp-commands: add sync-profile 2018-08-23 18:46:25 +02:00
hmp.c qmp, hmp: make subsystem/system-vendor identities optional 2018-10-11 19:58:26 +01:00
hmp.h hmp-commands: add sync-profile 2018-08-23 18:46:25 +02:00
ioport.c
iothread.c iothread: fix crash with invalid properties 2018-10-12 09:46:14 +08:00
job-qmp.c jobs: canonize Error object 2018-08-31 16:28:33 +02:00
job.c job: Fix off-by-one assert checks for JobSTT and JobVerbTable 2018-11-12 17:49:21 +01:00
LICENSE
MAINTAINERS MAINTAINERS: Add an entry for the Firmware Configuration (fw_cfg) device 2018-11-27 15:35:19 +01:00
Makefile Makefile: Install new vgabios binaries 2018-10-15 09:57:33 +02:00
Makefile.objs contrib: add elf2dmp tool 2018-10-02 19:09:12 +02:00
Makefile.target
memory_ldst.inc.c
memory_mapping.c memory-mapping: skip non-volatile memory regions in GuestPhysBlockList 2018-11-06 21:35:05 +01:00
memory.c memory: learn about non-volatile memory region 2018-11-06 21:35:05 +01:00
module-common.c
monitor.c monitor: delay monitor iothread creation 2018-11-06 17:02:49 +01:00
numa.c numa: Clean up error reporting in parse_numa() 2018-10-19 14:51:34 +02:00
os-posix.c util: add qemu_write_pidfile() 2018-10-02 18:47:55 +02:00
os-win32.c util: add qemu_write_pidfile() 2018-10-02 18:47:55 +02:00
qdev-monitor.c qdev-monitor: Make device options help nicer 2018-11-05 15:18:04 +01:00
qdict-test-data.txt
qemu-bridge-helper.c
qemu-deprecated.texi bt: Mark the bluetooth subsystem as deprecated 2018-11-12 14:08:17 +01:00
qemu-doc.texi doc: replace x-root with rootdir for usb-mtp 2018-10-01 10:49:54 +02:00
qemu-edid.c display/edid: add edid generator to qemu. 2018-09-27 08:07:51 +02:00
qemu-ga.texi
qemu-img-cmds.hx qemu-img: Add -C option for convert with copy offloading 2018-07-30 15:35:37 +02:00
qemu-img.c qemu-img: Fix leak 2018-11-21 15:17:46 +01:00
qemu-img.texi qemu-img: Add -C option for convert with copy offloading 2018-07-30 15:35:37 +02:00
qemu-io-cmds.c qemu-io-cmds: Fix two format strings 2018-11-05 15:09:54 +01:00
qemu-io.c qom: Clean up error reporting in user_creatable_add_opts_foreach() 2018-10-19 14:51:34 +02:00
qemu-keymap.c ui: use enum to string helpers 2018-08-24 08:40:10 +02:00
qemu-nbd.c qom: Clean up error reporting in user_creatable_add_opts_foreach() 2018-10-19 14:51:34 +02:00
qemu-nbd.texi
qemu-option-trace.texi
qemu-options-wrapper.h
qemu-options.h
qemu-options.hx hostmem-memfd: honour share=on/off property 2018-11-27 19:36:22 +01:00
qemu-seccomp.c seccomp: Clean up error reporting in parse_sandbox() 2018-10-19 14:51:34 +02:00
qemu-tech.texi cli qmp: Mark --preconfig, exit-preconfig experimental 2018-07-16 15:38:19 +02:00
qemu.nsi
qemu.sasl
qmp.c cli qmp: Mark --preconfig, exit-preconfig experimental 2018-07-16 15:38:19 +02:00
qtest.c qtest: Use cpu address space instead of system memory 2018-07-06 18:39:19 +02:00
README README: use 'https://' instead of 'git://' 2018-11-12 11:26:02 +00:00
replication.c
replication.h
rules.mak
thunk.c
tpm.c tpm: Clean up error reporting in tpm_init_tpmdev() 2018-10-19 14:51:34 +02:00
trace-events jobs: remove ret argument to job_completed; privatize it 2018-08-31 16:28:33 +02:00
VERSION Update version for v3.1.0-rc3 release 2018-11-28 17:37:34 +00:00
version.rc
vl.c vl.c: remove outdated comment 2018-11-27 15:35:19 +01:00
win_dump.c dump: fix Windows dump memory run mapping 2018-10-02 18:47:55 +02:00
win_dump.h dump: move Windows dump structures definitions 2018-10-02 19:09:12 +02:00

         QEMU README
         ===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

  https://qemu.org/Hosts/Linux
  https://qemu.org/Hosts/Mac
  https://qemu.org/Hosts/W32


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

   git clone https://git.qemu.org/git/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the HACKING and CODING_STYLE files.

Additional information on submitting patches can be found online via
the QEMU website

  https://qemu.org/Contribute/SubmitAPatch
  https://qemu.org/Contribute/TrivialPatches

The QEMU website is also maintained under source control.

  git clone https://git.qemu.org/git/qemu-web.git
  https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

  https://github.com/stefanha/git-publish

The workflow with 'git-publish' is:

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses Launchpad as its primary upstream bug tracker. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

  https://bugs.launchpad.net/qemu/

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via launchpad.

For additional information on bug reporting consult:

  https://qemu.org/Contribute/ReportABug


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

 - qemu-devel@nongnu.org
   https://lists.nongnu.org/mailman/listinfo/qemu-devel
 - #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

  https://qemu.org/Contribute/StartHere

-- End