QEMU With E2K User Support
Go to file
Philippe Mathieu-Daudé d39fdfff34 hw/block/nand: Fix out-of-bound access in NAND block buffer
nand_command() and nand_getio() don't check @offset points
into the block, nor the available data length (s->iolen) is
not negative.

In order to fix:

- check the offset is in range in nand_blk_load_NAND_PAGE_SIZE(),
- do not set @iolen if blk_load() failed.

Reproducer:

  $ cat << EOF | qemu-system-arm -machine tosa \
                                 -monitor none -serial none \
                                 -display none -qtest stdio
  write 0x10000111 0x1 0xca
  write 0x10000104 0x1 0x47
  write 0x1000ca04 0x1 0xd7
  write 0x1000ca01 0x1 0xe0
  write 0x1000ca04 0x1 0x71
  write 0x1000ca00 0x1 0x50
  write 0x1000ca04 0x1 0xd7
  read 0x1000ca02 0x1
  write 0x1000ca01 0x1 0x10
  EOF

=================================================================
==15750==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61f000000de0
 at pc 0x560e61557210 bp 0x7ffcfc4a59f0 sp 0x7ffcfc4a59e8
READ of size 1 at 0x61f000000de0 thread T0
    #0 0x560e6155720f in mem_and hw/block/nand.c:101:20
    #1 0x560e6155ac9c in nand_blk_write_512 hw/block/nand.c:663:9
    #2 0x560e61544200 in nand_command hw/block/nand.c:293:13
    #3 0x560e6153cc83 in nand_setio hw/block/nand.c:520:13
    #4 0x560e61a0a69e in tc6393xb_nand_writeb hw/display/tc6393xb.c:380:13
    #5 0x560e619f9bf7 in tc6393xb_writeb hw/display/tc6393xb.c:524:9
    #6 0x560e647c7d03 in memory_region_write_accessor softmmu/memory.c:492:5
    #7 0x560e647c7641 in access_with_adjusted_size softmmu/memory.c:554:18
    #8 0x560e647c5f66 in memory_region_dispatch_write softmmu/memory.c:1514:16
    #9 0x560e6485409e in flatview_write_continue softmmu/physmem.c:2825:23
    #10 0x560e648421eb in flatview_write softmmu/physmem.c:2867:12
    #11 0x560e64841ca8 in address_space_write softmmu/physmem.c:2963:18
    #12 0x560e61170162 in qemu_writeb tests/qtest/videzzo/videzzo_qemu.c:1080:5
    #13 0x560e6116eef7 in dispatch_mmio_write tests/qtest/videzzo/videzzo_qemu.c:1227:28

0x61f000000de0 is located 0 bytes to the right of 3424-byte region [0x61f000000080,0x61f000000de0)
allocated by thread T0 here:
    #0 0x560e611276cf in malloc /root/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:145:3
    #1 0x7f7959a87e98 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x57e98)
    #2 0x560e64b98871 in object_new qom/object.c:749:12
    #3 0x560e64b5d1a1 in qdev_new hw/core/qdev.c:153:19
    #4 0x560e61547ea5 in nand_init hw/block/nand.c:639:11
    #5 0x560e619f8772 in tc6393xb_init hw/display/tc6393xb.c:558:16
    #6 0x560e6390bad2 in tosa_init hw/arm/tosa.c:250:12

SUMMARY: AddressSanitizer: heap-buffer-overflow hw/block/nand.c:101:20 in mem_and
==15750==ABORTING

Broken since introduction in commit 3e3d5815cb ("NAND Flash memory
emulation and ECC calculation helpers for use by NAND controllers").

Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1445
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1446
Reported-by: Qiang Liu <cyruscyliu@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20240409135944.24997-4-philmd@linaro.org>
2024-04-10 09:09:34 +02:00
.github/workflows
.gitlab/issue_templates
.gitlab-ci.d gitlab-ci/cirrus: switch from 'master' to 'latest' 2024-04-01 13:12:26 +01:00
accel kvm: error out of kvm_irqchip_add_msi_route() in case of full route table 2024-04-08 21:22:00 +02:00
audio audio: Depend on dbus_display1_dep 2024-02-16 17:27:22 +04:00
authz
backends backends/iommufd: Fix missing ERRP_GUARD() for error_prepend() 2024-03-12 11:45:33 +01:00
block block: Remove unnecessary NULL check in bdrv_pad_request() 2024-04-02 14:55:32 +02:00
bsd-user gdbstub: Save target's siginfo 2024-03-13 11:43:52 +00:00
chardev Revert "chardev: use a child source for qio input source" 2024-03-19 20:17:12 +00:00
common-user
configs mips: do not list individual devices from configs/ 2024-03-08 15:51:22 +01:00
contrib contrib/plugins/execlog: Fix compiler warning 2024-03-26 14:32:51 +01:00
crypto crypto: query gcrypt for cipher availability 2024-03-19 20:17:12 +00:00
disas nanomips: fix warnings with GCC 14 2024-04-08 21:21:48 +02:00
docs Revert "hw/virtio: Add support for VDPA network simulation devices" 2024-04-09 02:30:18 -04:00
dump dump: Fix HMP dump-guest-memory -z without -R 2024-01-30 21:20:20 +03:00
ebpf ebpf: Fix indirections table setting 2024-03-29 14:59:00 +08:00
fpu fpu/softfloat: Remove mention of TILE-Gx target 2024-04-01 19:47:40 +03:00
fsdev configure, meson: rename targetos to host_os 2023-12-31 09:11:29 +01:00
gdb-xml gdb-xml: fix duplicate register in arm-neon.xml 2023-11-08 15:15:23 +00:00
gdbstub gdbstub/system: Rename 'user_ctx' argument as 'ctx' 2024-04-02 14:55:07 +02:00
host/include host/include/generic/host/atomic128: Fix compilation problem with Clang 17 2023-11-13 11:35:47 +01:00
hw hw/block/nand: Fix out-of-bound access in NAND block buffer 2024-04-10 09:09:34 +02:00
include hw/virtio: Introduce virtio_bh_new_guarded() helper 2024-04-10 09:09:33 +02:00
io io: Introduce qio_channel_file_new_dupfd 2024-03-12 15:22:23 -04:00
libdecnumber
linux-headers linux-headers: Update to Linux v6.8-rc6 2024-03-08 20:48:03 +10:00
linux-user linux-user: Fix shmat(NULL) for h != g 2024-03-26 18:20:36 -10:00
migration migration/postcopy: ensure preempt channel is ready before loading states 2024-04-07 14:40:25 -04:00
monitor monitor/hmp-cmds-target: Append a space in error message in gpa2hva() 2024-03-26 14:24:06 +01:00
nbd nbd/server: Fix race in draining the export 2024-03-18 12:38:02 +01:00
net Revert "tap: setting error appropriately when calling net_init_tap_one()" 2024-03-29 14:59:07 +08:00
pc-bios edk2: rebuild binaries with correct version information 2024-04-09 18:21:23 +02:00
plugins plugins: fix -Werror=maybe-uninitialized false-positive 2024-04-02 16:15:07 +02:00
po
python buildsys: Bump known good meson version to v1.2.3 2023-11-24 16:21:55 +01:00
qapi Fix some typos in documentation (found by codespell) 2024-04-02 13:38:40 +03:00
qga qga/qapi-schema: Refill doc comments to conform to current conventions 2024-03-26 06:36:08 +01:00
qobject
qom hw/acpi: move object_resolve_type_unambiguous to core QOM 2024-02-27 09:36:41 +01:00
replay replay: Improve error messages about configuration conflicts 2024-03-09 18:56:36 +03:00
roms edk2/seabios: use common extra version 2024-04-09 18:12:20 +02:00
scripts tracetool: remove redundant --target-type / --target-name args 2024-03-12 14:52:07 -04:00
scsi configure, meson: rename targetos to host_os 2023-12-31 09:11:29 +01:00
semihosting {linux,bsd}-user: Introduce get_task_state() 2024-03-06 12:35:19 +00:00
stats
storage-daemon meson: remove config_targetos 2023-12-31 09:11:28 +01:00
stubs migration: privatize colo interfaces 2024-03-11 16:28:59 -04:00
subprojects libvhost-user: Mark mmap'ed region memory as MADV_DONTDUMP 2024-03-12 17:56:55 -04:00
system qdev-monitor: fix error message in find_device_state() 2024-04-09 02:31:33 -04:00
target target/arm: Use correct SecuritySpace for AArch64 AT ops at EL3 2024-04-08 15:38:53 +01:00
tcg tcg/optimize: Fix sign_mask for logical right-shift 2024-03-29 12:15:55 -10:00
tests qtest/libqos: Reduce size_to_prdtl() declaration scope 2024-04-02 14:55:32 +02:00
tools ebpf: Updated eBPF program and skeleton. 2024-03-12 19:31:47 +08:00
trace tracing: install trace events file only if necessary 2023-12-27 05:01:55 -05:00
ui ui/cocoa: Use NSTrackingInVisibleRect 2024-03-26 14:32:54 +01:00
util coroutine: reserve 5,000 mappings 2024-03-21 13:14:30 -04:00
.dir-locals.el
.editorconfig
.exrc
.gdbinit
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitlab-ci.yml
.gitmodules
.gitpublish
.mailmap mailmap: Fix Stefan Weil email 2024-01-30 21:20:20 +03:00
.patchew.yml
.readthedocs.yml readthodocs: fully specify a build environment 2024-01-12 13:23:48 +00:00
.travis.yml .travis.yml: Remove the unused xfslib-dev package 2024-03-25 09:57:32 +01:00
block.c error: Move ERRP_GUARD() to the beginning of the function 2024-03-12 11:45:45 +01:00
blockdev-nbd.c
blockdev.c blockdev: Fix blockdev-snapshot-sync error reporting for no medium 2024-03-18 13:13:08 +01:00
blockjob.c block: remove AioContext locking 2023-12-21 22:49:27 +01:00
configure configure: put all symlink creation together 2024-02-16 13:56:09 +01:00
COPYING
COPYING.LIB
cpu-common.c system/cpus: rename qemu_mutex_lock_iothread() to bql_lock() 2024-01-08 10:45:43 -05:00
cpu-target.c cpu: Remove page_size_init 2024-02-29 11:35:37 -10:00
event-loop-base.c
gitdm.config
hmp-commands-info.hx hmp: Add option to info qtree to omit details 2024-03-09 19:17:01 +01:00
hmp-commands.hx hmp: Add help information for watchdog action: inject-nmi 2024-04-02 13:38:51 +03:00
iothread.c iothread: Simplify expression in qemu_in_iothread() 2024-02-13 10:59:25 +03:00
job-qmp.c
job.c block: remove AioContext locking 2023-12-21 22:49:27 +01:00
Kconfig
Kconfig.host build-sys: add a "pixman" feature 2023-11-07 14:04:24 +04:00
LICENSE
MAINTAINERS virtio,pc,pci: bugfixes 2024-04-09 09:51:07 +01:00
Makefile Makefile: preserve --jobserver-auth argument when calling ninja 2024-04-08 10:04:44 +02:00
meson_options.txt meson: fix type of "relocatable" option 2023-12-31 09:11:27 +01:00
meson.build meson: remove dead dictionary access 2024-03-20 11:30:49 +01:00
module-common.c
os-posix.c qemu_init: increase NOFILE soft limit on POSIX 2024-02-09 12:47:58 +00:00
os-win32.c
page-vary-common.c
page-vary-target.c exec: Rename target specific page-vary.c -> page-vary-target.c 2023-10-04 11:03:54 -07:00
pythondeps.toml buildsys: Bump known good meson version to v1.2.3 2023-11-24 16:21:55 +01:00
qemu-bridge-helper.c
qemu-edid.c
qemu-img-cmds.hx docs/devel/docs: Document .hx file syntax 2024-01-15 17:12:22 +00:00
qemu-img.c block: remove AioContext locking 2023-12-21 22:49:27 +01:00
qemu-io-cmds.c block: Mark bdrv_get_specific_info() and callers GRAPH_RDLOCK 2023-10-12 16:31:33 +02:00
qemu-io.c block: remove AioContext locking 2023-12-21 22:49:27 +01:00
qemu-keymap.c
qemu-nbd.c qemu-nbd: mention --tls-hostname option in qemu-nbd --help 2024-02-13 10:59:25 +03:00
qemu-options.hx qemu-options: Fix CXL Fixed Memory Window interleave-granularity typo 2024-04-10 09:09:33 +02:00
qemu.nsi
qemu.sasl
README.rst
replication.c
trace-events
VERSION Update version for v9.0.0-rc2 release 2024-04-02 20:59:43 +01:00
version.rc

===========
QEMU README
===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Documentation
=============

Documentation can be found hosted online at
`<https://www.qemu.org/documentation/>`_. The documentation for the
current development version that is available at
`<https://www.qemu.org/docs/master/>`_ is generated from the ``docs/``
folder in the source tree, and is built by `Sphinx
<https://www.sphinx-doc.org/en/master/>`_.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:


.. code-block:: shell

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

* `<https://wiki.qemu.org/Hosts/Linux>`_
* `<https://wiki.qemu.org/Hosts/Mac>`_
* `<https://wiki.qemu.org/Hosts/W32>`_


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

.. code-block:: shell

   git clone https://gitlab.com/qemu-project/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the `style section
<https://www.qemu.org/docs/master/devel/style.html>`_ of
the Developers Guide.

Additional information on submitting patches can be found online via
the QEMU website

* `<https://wiki.qemu.org/Contribute/SubmitAPatch>`_
* `<https://wiki.qemu.org/Contribute/TrivialPatches>`_

The QEMU website is also maintained under source control.

.. code-block:: shell

  git clone https://gitlab.com/qemu-project/qemu-web.git

* `<https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/>`_

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

*  `<https://github.com/stefanha/git-publish>`_

The workflow with 'git-publish' is:

.. code-block:: shell

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

.. code-block:: shell

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses GitLab issues to track bugs. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

* `<https://gitlab.com/qemu-project/qemu/-/issues>`_

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via GitLab.

For additional information on bug reporting consult:

* `<https://wiki.qemu.org/Contribute/ReportABug>`_


ChangeLog
=========

For version history and release notes, please visit
`<https://wiki.qemu.org/ChangeLog/>`_ or look at the git history for
more detailed information.


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

* `<mailto:qemu-devel@nongnu.org>`_
* `<https://lists.nongnu.org/mailman/listinfo/qemu-devel>`_
* #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

* `<https://wiki.qemu.org/Contribute/StartHere>`_