qemu-e2k/target/s390x
Markus Armbruster e47970f51d s390x/cpumodel: Fix query-cpu-model-FOO error API violations
cpu_model_from_info() is a helper for qmp_query_cpu_model_expansion(),
qmp_query_cpu_model_comparison(), qmp_query_cpu_model_baseline().  It
dereferences @errp when the visitor or the QOM setter fails.  That's
wrong; see the big comment in error.h.  Introduced in commit
137974cea3 's390x/cpumodel: implement QMP interface
"query-cpu-model-expansion"'.

Its three callers have the same issue.  Introduced in commit
4e82ef0502 's390x/cpumodel: implement QMP interface
"query-cpu-model-comparison"' and commit f1a47d08ef 's390x/cpumodel:
implement QMP interface "query-cpu-model-baseline"'.

No caller actually passes null.

Fix anyway: splice in a local Error *err, and error_propagate().

Cc: David Hildenbrand <david@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20191204093625.14836-15-armbru@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-12-14 10:25:50 +01:00
..
arch_dump.c
cc_helper.c target/s390x: Use tcg_s390_program_interrupt in TCG helpers 2019-10-09 12:49:01 +02:00
cpu_features_def.h
cpu_features_def.inc.h
cpu_features.c
cpu_features.h
cpu_models.c s390x/cpumodel: Fix query-cpu-model-FOO error API violations 2019-12-14 10:25:50 +01:00
cpu_models.h
cpu-param.h
cpu-qom.h s390x: Move clear reset 2019-12-14 10:25:50 +01:00
cpu.c s390x: Fix cpu normal reset ri clearing 2019-12-14 10:25:50 +01:00
cpu.h s390x: Fix cpu normal reset ri clearing 2019-12-14 10:25:50 +01:00
crypto_helper.c target/s390x: Use tcg_s390_program_interrupt in TCG helpers 2019-10-09 12:49:01 +02:00
diag.c s390x: Beautify diag308 handling 2019-12-14 10:25:50 +01:00
excp_helper.c target/s390x: Remove ilen argument from trigger_pgm_exception 2019-10-09 12:49:02 +02:00
fpu_helper.c target/s390x: Use tcg_s390_program_interrupt in TCG helpers 2019-10-09 12:49:01 +02:00
gdbstub.c
gen-features.c
helper.c target/s390x: Return exception from mmu_translate 2019-10-09 12:49:01 +02:00
helper.h
insn-data.def
insn-format.def
int_helper.c target/s390x: Use tcg_s390_program_interrupt in TCG helpers 2019-10-09 12:49:01 +02:00
internal.h target/s390x: Remove ilen argument from trigger_pgm_exception 2019-10-09 12:49:02 +02:00
interrupt.c target/s390x: Remove ilen argument from trigger_pgm_exception 2019-10-09 12:49:02 +02:00
ioinst.c
kvm_s390x.h
kvm-stub.c
kvm.c s390x: kvm: Make kvm_sclp_service_call void 2019-12-14 10:25:50 +01:00
machine.c
Makefile.objs
mem_helper.c s390x/tcg: MVCL: Exit to main loop if requested 2019-10-10 12:27:15 +02:00
misc_helper.c target/s390x: Use tcg_s390_program_interrupt in TCG helpers 2019-10-09 12:49:01 +02:00
mmu_helper.c s390x/mmu: Remove duplicate check for MMU_DATA_STORE 2019-10-21 17:30:06 +02:00
s390-tod.h
sigp.c s390x: Move initial reset 2019-12-14 10:25:50 +01:00
tcg_s390x.h
tcg-stub.c
trace-events
translate_vx.inc.c s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATION 2019-10-21 17:34:43 +02:00
translate.c
vec_fpu_helper.c
vec_helper.c
vec_int_helper.c s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION 2019-10-21 17:33:29 +02:00
vec_string_helper.c
vec.h