2017-02-20 04:50:31 +01:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:11:23
|
|
|
|
|
|
|
|
|
11 | fn foo<T: Default>(v: Vec<T>, w: Vec<T>, mut x: Vec<T>, y: Vec<T>) -> Vec<T> {
|
|
|
|
| ^^^^^^ help: consider changing the type to: `&[T]`
|
|
|
|
|
|
|
|
|
= note: `-D clippy::needless-pass-by-value` implied by `-D warnings`
|
2017-02-20 04:50:31 +01:00
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:25:11
|
2017-02-20 04:50:31 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
25 | fn bar(x: String, y: Wrapper) {
|
2017-07-21 10:40:23 +02:00
|
|
|
| ^^^^^^ help: consider changing the type to: `&str`
|
2017-02-20 04:50:31 +01:00
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:25:22
|
2017-02-20 04:50:31 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
25 | fn bar(x: String, y: Wrapper) {
|
2017-07-21 10:40:23 +02:00
|
|
|
| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
|
2017-02-20 04:50:31 +01:00
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:31:71
|
2017-02-20 04:50:31 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
31 | fn test_borrow_trait<T: Borrow<str>, U: AsRef<str>, V>(t: T, u: U, v: V) {
|
2017-10-08 03:23:41 +02:00
|
|
|
| ^ help: consider taking a reference instead: `&V`
|
2017-02-20 04:50:31 +01:00
|
|
|
|
2017-02-20 08:45:37 +01:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:43:18
|
2017-02-20 08:45:37 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
43 | fn test_match(x: Option<Option<String>>, y: Option<Option<String>>) {
|
2017-02-20 08:45:37 +01:00
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
help: consider taking a reference instead
|
2017-07-10 15:29:29 +02:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
43 | fn test_match(x: &Option<Option<String>>, y: Option<Option<String>>) {
|
|
|
|
44 | match *x {
|
2017-07-10 15:29:29 +02:00
|
|
|
|
|
2017-02-20 08:45:37 +01:00
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:56:24
|
2017-02-20 08:45:37 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
56 | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
|
2017-07-21 10:40:23 +02:00
|
|
|
| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
|
2017-02-20 08:45:37 +01:00
|
|
|
|
2017-02-20 10:18:31 +01:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:56:36
|
2017-02-20 10:18:31 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
56 | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
|
2017-02-20 10:18:31 +01:00
|
|
|
| ^^^^^^^
|
|
|
|
help: consider taking a reference instead
|
2017-07-10 15:29:29 +02:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
56 | fn test_destructure(x: Wrapper, y: &Wrapper, z: Wrapper) {
|
|
|
|
57 | let Wrapper(s) = z; // moved
|
|
|
|
58 | let Wrapper(ref t) = *y; // not moved
|
|
|
|
59 | let Wrapper(_) = *y; // still not moved
|
2017-10-08 03:23:41 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:72:49
|
2017-07-10 15:29:29 +02:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
72 | fn test_blanket_ref<T: Foo, S: Serialize>(_foo: T, _serializable: S) {}
|
2017-10-08 03:23:41 +02:00
|
|
|
| ^ help: consider taking a reference instead: `&T`
|
2017-02-20 10:18:31 +01:00
|
|
|
|
2017-10-08 10:51:44 +02:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:74:18
|
2017-10-08 10:51:44 +02:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
74 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
2017-10-08 10:51:44 +02:00
|
|
|
| ^^^^^^ help: consider taking a reference instead: `&String`
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:74:29
|
2017-10-08 10:51:44 +02:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
74 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
2017-10-08 10:51:44 +02:00
|
|
|
| ^^^^^^
|
|
|
|
help: consider changing the type to
|
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
74 | fn issue_2114(s: String, t: &str, u: Vec<i32>, v: Vec<i32>) {
|
2017-10-08 10:51:44 +02:00
|
|
|
| ^^^^
|
|
|
|
help: change `t.clone()` to
|
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
76 | let _ = t.to_string();
|
2017-10-08 10:51:44 +02:00
|
|
|
| ^^^^^^^^^^^^^
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:74:40
|
2017-10-08 10:51:44 +02:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
74 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
2017-10-08 10:51:44 +02:00
|
|
|
| ^^^^^^^^ help: consider taking a reference instead: `&Vec<i32>`
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:74:53
|
2017-10-08 10:51:44 +02:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
74 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
2017-10-08 10:51:44 +02:00
|
|
|
| ^^^^^^^^
|
|
|
|
help: consider changing the type to
|
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
74 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: &[i32]) {
|
2017-10-08 10:51:44 +02:00
|
|
|
| ^^^^^^
|
|
|
|
help: change `v.clone()` to
|
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
78 | let _ = v.to_owned();
|
2017-10-08 10:51:44 +02:00
|
|
|
| ^^^^^^^^^^^^
|
|
|
|
|
2017-11-03 09:24:10 +01:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:86:12
|
2017-11-03 09:24:10 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
86 | s: String,
|
2017-11-03 09:24:10 +01:00
|
|
|
| ^^^^^^ help: consider changing the type to: `&str`
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:87:12
|
2017-11-03 09:24:10 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
87 | t: String,
|
2017-11-03 09:24:10 +01:00
|
|
|
| ^^^^^^ help: consider taking a reference instead: `&String`
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:99:13
|
2018-05-29 10:56:58 +02:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
99 | _u: U,
|
2018-05-29 10:56:58 +02:00
|
|
|
| ^ help: consider taking a reference instead: `&U`
|
2017-11-03 09:24:10 +01:00
|
|
|
|
2017-11-03 09:56:26 +01:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:100:13
|
|
|
|
|
|
|
|
|
100 | _s: Self,
|
|
|
|
| ^^^^ help: consider taking a reference instead: `&Self`
|
2018-01-18 14:27:47 +01:00
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:122:24
|
2018-01-18 14:27:47 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
122 | fn bar_copy(x: u32, y: CopyWrapper) {
|
2018-01-18 14:27:47 +01:00
|
|
|
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
|
|
|
|
|
|
|
|
|
help: consider marking this type as Copy
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:120:1
|
2018-01-18 14:27:47 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
120 | struct CopyWrapper(u32);
|
2018-01-18 14:27:47 +01:00
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:128:29
|
2018-01-18 14:27:47 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
128 | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
|
2018-01-18 14:27:47 +01:00
|
|
|
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
|
|
|
|
|
|
|
|
|
help: consider marking this type as Copy
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:120:1
|
2018-01-18 14:27:47 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
120 | struct CopyWrapper(u32);
|
2018-01-18 14:27:47 +01:00
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:128:45
|
2018-01-18 14:27:47 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
128 | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
|
2018-01-18 14:27:47 +01:00
|
|
|
| ^^^^^^^^^^^
|
|
|
|
|
|
|
|
|
help: consider marking this type as Copy
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:120:1
|
2018-01-18 14:27:47 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
120 | struct CopyWrapper(u32);
|
2018-01-18 14:27:47 +01:00
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
help: consider taking a reference instead
|
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
128 | fn test_destructure_copy(x: CopyWrapper, y: &CopyWrapper, z: CopyWrapper) {
|
|
|
|
129 | let CopyWrapper(s) = z; // moved
|
|
|
|
130 | let CopyWrapper(ref t) = *y; // not moved
|
|
|
|
131 | let CopyWrapper(_) = *y; // still not moved
|
2018-01-18 14:27:47 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:128:61
|
2018-01-18 14:27:47 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
128 | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
|
2018-01-18 14:27:47 +01:00
|
|
|
| ^^^^^^^^^^^
|
|
|
|
|
|
|
|
|
help: consider marking this type as Copy
|
2018-08-01 16:30:44 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:120:1
|
2018-01-18 14:27:47 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
120 | struct CopyWrapper(u32);
|
2018-01-18 14:27:47 +01:00
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
help: consider taking a reference instead
|
2018-01-18 09:45:41 +01:00
|
|
|
|
|
2018-08-01 16:30:44 +02:00
|
|
|
128 | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: &CopyWrapper) {
|
|
|
|
129 | let CopyWrapper(s) = *z; // moved
|
2018-01-18 09:45:41 +01:00
|
|
|
|
|
2017-11-03 09:56:26 +01:00
|
|
|
|
2018-01-18 14:27:47 +01:00
|
|
|
error: aborting due to 20 previous errors
|
2018-01-16 17:06:27 +01:00
|
|
|
|