fb6895836f
Address PR comments
2017-05-11 15:36:27 +02:00
2cd3366817
Fixes #443
2017-05-10 13:42:19 +02:00
3b3e47f451
Merge pull request #1738 from Manishearth/serde
...
Update serde to 1.0
2017-05-10 08:55:36 +02:00
dee53fa1e2
Merge pull request #1728 from Manishearth/inspector
...
Print type adjustments in the inspector
2017-05-09 15:26:01 +02:00
31b2bf4ab9
Update our config reading to serde 1.0
2017-05-09 15:23:38 +02:00
8225c23a33
Update to serde 1.0
2017-05-09 15:23:10 +02:00
f1434d2023
clean tests/ui/assign_ops.rs
...
When all //~ were removed from tests, these were replaced with empty
lines to leave the numbers in the expected stderr untouched.
Cleaning the empty lines for clarity.
2017-05-08 14:05:02 +01:00
866239b1a8
Add a test showing a false positive on needless_borrow
2017-05-05 14:26:14 +02:00
a6c8464dde
Update to `rustc 1.19.0-nightly ( 6a5fc9eec 2017-05-02)`
2017-05-03 12:51:47 +02:00
96b25cdaf2
Add regression tests for op_ref
2017-04-28 17:07:39 +02:00
7aa42073f2
Fix op_ref false positives
2017-04-28 17:03:47 +02:00
5381c4fcf6
Update ui tests to new rustc range printing
2017-04-25 10:57:44 +02:00
68369e5d37
Merge remote-tracking branch 'origin/master' into yati_master
2017-04-25 10:31:40 +02:00
b20a6a773c
Update tests to new format of multiline errors
2017-04-23 15:39:41 +02:00
cac15d24f9
needless_continue: Remove indentation of suggestion code.
...
As per a suggestion by Oliver on the PR thread, maintaining indentation
in the suggested code is futile because of the changes in the compiler
and the messiness of real-world code. rustfmt will do the indentation if
required, so we don't need to do it.
2017-04-13 21:48:52 +02:00
3534149035
Update ui tests
2017-04-11 16:19:27 +02:00
679e98530a
Merge remote-tracking branch 'origin/master' into yati
2017-04-11 16:16:10 +02:00
21d8fbd082
Don't lint for lifetime bounds required by traits
2017-04-11 15:44:13 +02:00
fae1e646ee
Remove useless warning
2017-04-11 14:34:39 +02:00
2eae102cd1
Don't lint lifetimes after trait objects
2017-04-11 14:29:58 +02:00
9a4c0a1c72
Don't lint about unused lifetimes if the lifetimes are used in the body of the function
2017-04-11 14:09:58 +02:00
7b6111677a
Latest nightly produces more ellipses in output
2017-04-10 15:36:07 +02:00
b76ce176bb
Fix op_ref in case of nonexisting operations
2017-04-10 15:10:19 +02:00
62548f447c
needless_continue: Add ui test
...
The test program contains both conditions tested by the lint, i.e.,
a redundant continue in the `if` and `else` blocks within a loop. Maybe
splitting them out and also having a program that should *not* trigger
the lint warning is better.
2017-04-09 14:20:14 +02:00
f1e905f620
Reintroduce #768 so we can publish
2017-04-07 11:21:39 +02:00
3052000c73
Merge pull request #1649 from ensch/master
...
Fix for rustc 1.18.0-nightly (5c94997b6
2017-04-07 11:13:44 +02:00
f32fab1c8f
panic!("{}") lint is broken
2017-04-06 16:49:03 +02:00
71a788cbd7
correct error message for `option_map_unwrap_or_else` lint
...
Remove erroneous "with " in suggested alternative call.
2017-04-01 15:54:27 +02:00
5547fbb770
Fix accidental newline in diagnostic and missing entries in lint_array!
2017-03-24 10:21:12 +01:00
8ae82eb4ab
Merge remote-tracking branch 'origin/master' into 1537-drop_copy
2017-03-24 10:11:46 +01:00
a712271df6
Filter out proc_macro_derive functions ( fixes #1615 )
2017-03-21 17:09:21 +09:00
2d145b2ef5
don't lint macro_rules! in items_after_statements
2017-03-13 11:09:56 +01:00
51295960bf
Fix invalid_upcast_comparisons lint for same size sign casts
2017-03-02 10:41:20 +01:00
75e28610a7
Merged drop_forget_ref.rs with drop_forget_copy.rs.
...
Moved constant message strings out of declare_lint! macros.
2017-02-26 21:57:47 -05:00
aa037d1ef0
Merge branch 'master' into 1537-drop_copy
2017-02-25 23:11:21 -05:00
b8defc6cc4
Warn on calls to `std::mem::drop` or `std::mem::forget` with a `Copy` type
2017-02-25 23:05:37 -05:00
5906639af5
Enable `len_zero` for slices
2017-02-25 12:26:33 +09:00
19929790aa
Merge pull request #1561 from Manishearth/zero_ptr
...
New zero_ptr lint.
2017-02-22 13:34:28 +01:00
1e26c44010
Suggest `assert_ne` for `assert!(x != y)`
2017-02-22 16:47:18 +09:00
a7c049df28
Merge pull request #1564 from Manishearth/cleanup
...
Cleanup test suite
2017-02-21 15:30:39 +01:00
d032b8967c
Merge pull request #1491 from Manishearth/into_iter_on_ref
...
fix explicit_into_iter_loop on references
2017-02-21 14:55:52 +01:00
27aa309b3d
Merge pull request #1556 from sinkuu/take_by_value
...
Lint needless take-by-value
2017-02-21 13:07:25 +01:00
25e230419c
Merge system independent ui-tests back into tests/ui
2017-02-21 12:19:55 +01:00
f2ff5e2133
Update ui test output
2017-02-21 12:13:44 +01:00
21a0b16aee
adjust messages in tests
2017-02-21 12:04:29 +01:00
0bea3e76d4
fix explicit_into_iter_loop on references
...
fixes #1398
2017-02-21 12:01:41 +01:00
89d98a8732
Simplify calling `update-all-references.sh`
2017-02-21 11:18:05 +01:00
cb86c57c5f
Integrate suggestion spans
2017-02-21 19:03:50 +09:00
3516d45d7c
Use `multispan_sugg`
2017-02-21 18:44:31 +09:00
55ea08102a
Merge pull request #1543 from Manishearth/fix-windows-tests
...
fix windows tests
2017-02-21 10:34:49 +01:00
f07f793fa8
Merge pull request #1544 from bood/master
...
Add lint for unnecessary casts (cast to same type)
2017-02-21 09:16:07 +01:00
2f7babba82
New zero_ptr lint.
...
This fixes #1047 . I did not bother to add a full suggestion,
because replacing with `std::ptr::null()` may still lead to
inference failures.
2017-02-21 04:36:59 +01:00
627d24c80f
Fix suggestion for `let <pat>`
2017-02-21 00:27:12 +09:00
f1b0b774e7
Support non-moving usages at `match`
...
This `match` is not moving the `String`:
```rust
fn foo(x: Option<String>) -> i32 {
match x {
Some(_) => 1,
None => 2,
}
}
```
With this change, it will be linted and suggested to add `*` to deref it.
```rust
fn foo(x: &Option<String>) -> i32 {
match *x {
Some(_) => 1,
None => 2,
}
}
```
2017-02-20 16:45:37 +09:00
0a6bc6031a
Rename lint to needless_take_by_value
...
And fixes false-positives for generics and `match`
2017-02-20 16:02:48 +09:00
d6a4d2cb18
Fix typo
2017-02-19 15:39:40 +00:00
0396756098
Add test that adding allow attribute on impl block containing len silences len_without_is_empty. Add extra impl block to PubOne to check that this doesn't get flagged@
2017-02-19 15:36:17 +00:00
2dd45b7317
Use span of impl/trait in len_without_is_empty error message, rather than the span of the len method
2017-02-19 15:14:30 +00:00
d81d961ba7
Lint needless take-by-value
2017-02-19 07:59:44 +09:00
97d46232b4
Merge branch 'master' of github.com:Manishearth/rust-clippy
2017-02-18 11:12:13 +08:00
8cb2ec804d
Support generic type
2017-02-18 10:14:25 +09:00
6bb426b0e3
Add `should_assert_eq` lint ( fixes #641 )
2017-02-18 10:13:56 +09:00
505eb53d29
New never loop lint
...
This lint detects loops that unconditionally break or return.
Closes #257
2017-02-17 04:53:14 +01:00
84509ca48a
typos: coma -> comma
2017-02-16 11:23:28 -05:00
2f00ea3a07
Suppress lint for unsuffixed number casts
2017-02-16 22:55:41 +08:00
afce85e96d
Add lint for unnecessary casts (cast to same type)
2017-02-15 22:20:20 +08:00
d904a01140
fix windows tests
...
Windows has a different error message than POSIX, so the ui tests fail for the clippy-config-fail tests.
This commit splits those tests up in target-os specific subdirectories and extends compile-test.rs to
run either of them based on the target os. Here's hope we'll get a green appveyor build.
2017-02-14 17:30:55 +01:00
8b3ad61dd3
update ui tests
2017-02-13 11:57:14 +01:00
2265babe6a
Merge remote-tracking branch 'origin/master' into clonedCollect
2017-02-13 11:40:02 +01:00
637a4590f6
Merge remote-tracking branch 'origin/master'
2017-02-13 11:15:12 +01:00
9a7597d5af
Merge pull request #1528 from Manishearth/mut-from-ref
...
New `mut_from_ref` lint
2017-02-12 16:01:15 +01:00
21d226e7d2
fixed multi-span test
2017-02-12 15:10:25 +01:00
36b8554cf1
add notes for immutable inputs
2017-02-12 13:53:30 +01:00
b3570db094
update via comments
2017-02-12 20:40:38 +08:00
98aa0db0ac
Add a lint for `slice.iter().cloned().collect()`
...
If one uses `slice.iter().cloned().collect()` to create a new `Vec`,
it should be `slice.to_owned()`.
Fix #1292
2017-02-12 17:03:09 +08:00
64d2f8af8e
Lint on `panic!` only
2017-02-11 21:42:42 +08:00
a2d752807a
Lint on `Err(_)` arm of a match
2017-02-11 14:57:50 +08:00
2a8ce7c458
Update large_enum_variant test
2017-02-10 21:04:19 -07:00
1938904fcd
Change large_enum_variant to lint against size differences rather than size
2017-02-10 18:12:32 -07:00
673ee4800d
fix test
2017-02-11 01:41:49 +01:00
bff4c30ac7
added test, fixed message & description, rustfmt
2017-02-11 00:32:12 +01:00
5650a599a8
New mut_from_ref lint
...
This fixes #1507 .
2017-02-10 19:39:03 +01:00
1f2c97a291
remove all //~ from tests
2017-02-08 14:58:07 +01:00
fd1351f6e3
rustup and compile-fail -> ui test move
2017-02-07 21:05:30 +01:00
Oliver Schneider
Oliver Schneider
Luis de Bethencourt
mcarton
Yati Sagade
Oliver Schneider
Peter Gerber
sinkuu
Tristian Celestin
Andre Bogus
Phil Ellison
Bood Qian
Ben Boeckel
Martin Carton
f001
Owen Sanchez