Commit Graph

4967 Commits

Author SHA1 Message Date
Philipp Hansch 68bb900eba
Merge pull request #3473 from lucasloisp/additional-bool-comparisons
Adds inequality cases to bool comparison (#3438)
2018-12-04 07:26:29 +01:00
Philipp Hansch 8b2eb06df3
Merge pull request #3488 from phansch/fix_cargo_lint_bug
Fix wildcard_dependencies false positive
2018-12-04 07:24:11 +01:00
Philipp Hansch 46ee676139
cargo fmt 2018-12-04 06:47:41 +01:00
Lucas Lois 3930148059 Adds inequality cases to bool comparison lint
The lint now checks cases like `y != true`
2018-12-03 16:32:11 -03:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer c00210d7ba
Merge pull request #3478 from dtolnay/setlen
Remove unsafe_vector_initialization lint
2018-12-03 12:42:31 +01:00
David Tolnay e632a1946e
Remove unsafe_vector_initialization lint 2018-12-03 02:48:37 -08:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer 13438b6866
Merge pull request #3479 from dtolnay/literal
Downgrade large_digit_groups to pedantic
2018-12-03 11:06:56 +01:00
Philipp Hansch ef64c762d2
Fix wildcard_dependencies false positive
This now only checks for wildcard_dependencies if the source is a
non-git source.

I tried adding a compiletest suite for the cargo lints, but I was unable
to override the `Cargo.toml` of the original executable.

I tested this manually by modifying the main `Cargo.toml`.

Fixes #3458
2018-12-03 08:12:35 +01:00
Philipp Hansch a6f4cf7740
Merge pull request #3487 from phansch/fix_fmt
Fix rustfmt format
2018-12-03 07:44:43 +01:00
Philipp Hansch ebd508e0ac
Fix rustfmt format 2018-12-03 07:13:00 +01:00
Philipp Hansch fd54f448bd
Merge pull request #3486 from phansch/make_windows_travis_run_more_stuff
Travis: Add rustc sysroot bin to PATH for windows build
2018-12-02 16:29:38 +01:00
Philipp Hansch 39f179da45
Disable incremental build for windows
Testing if this speeds up compilation time for the Windows CI build.
2018-12-02 15:09:45 +01:00
Philipp Hansch d8166bf141
Travis: Add rustc sysroot bin to PATH for windows build 2018-12-02 14:33:19 +01:00
Philipp Hansch b06594e650
Merge pull request #3483 from phansch/mention_triage_procedure_in_contributing
Mention triage procedure in contributing.md
2018-12-02 12:35:14 +01:00
Philipp Hansch e048fab81e
Merge pull request #3485 from phansch/fix_some_nursery_links
Fix some nursery links
2018-12-02 12:33:09 +01:00
Philipp Hansch 451085ca8d
Fix some nursery links 2018-12-02 11:45:05 +01:00
Philipp Hansch 6253d457e1
Merge pull request #3484 from phansch/fix_windows_lineendings
git: Enforce LF lineendings for everything
2018-12-02 11:37:05 +01:00
Philipp Hansch 3a7da8b4fa
Enforce LF lineendings for everything
Someone on discord reported issues with UI tests.

This should make sure that git never automatically converts lineendings
for text files to `CRLF`. They should always be `LF` now.

Probably this means that we can stop using dos2unix for #3306, too.

Taken from [Rust's .gitattributes file](https://github.com/rust-lang/rust/blob/master/.gitattributes).
2018-12-02 11:05:39 +01:00
Philipp Hansch 40d58f9195
Mention triage procedure in contributing.md 2018-12-02 09:35:47 +01:00
David Tolnay 1a14cb3643
Keep testing large_digit_groups as ui test 2018-12-01 17:23:53 -08:00
David Tolnay 67f9d24c1b
Keep testing unsafe_vector_initialization as ui test 2018-12-01 17:19:39 -08:00
David Tolnay c00dcd03d7
Downgrade large_digit_groups to pedantic
I believe if the user already decided to put underscores in their
literal, Clippy should be willing to believe that they put a number of
underscores that they felt was readable.
2018-12-01 17:08:42 -08:00
David Tolnay 8b1f69a485
Downgrade unsafe_vector_initialization to restriction
This lint looks for:

    let mut vec = Vec::with_capacity(len);
    vec.set_len(len);

The suggested replacement is `vec![0; len]`.

This is far too opinionated to be a deny-by-default lint because the performance
characteristics of the suggested replacement are totally different.

I am not convinced that this lint has value beyond what deny(unsafe_code) gives
you. Unsafe code is unsafe but please don't deny-by-default lint it if that's
the only reason.
2018-12-01 16:21:02 -08:00
Philipp Hansch c669727df4
Merge pull request #3471 from matthiaskrgr/mamor_warn
remove macro_at_most_once_rep feature attribute since it's stable
2018-11-30 10:20:24 +01:00
Matthias Krüger c38bac89e9 remove macro_at_most_once_rep feature attribute since it's stable
Warning was:
warning: the feature `macro_at_most_once_rep` has been stable since 1.32.0 and no longer requires an attribute to enable
  --> clippy_lints/src/lib.rs:19:12
   |
19 | #![feature(macro_at_most_once_rep)]
   |            ^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: #[warn(stable_features)] on by default
2018-11-30 09:14:18 +01:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer f5831523d3
Merge pull request #3465 from flip1995/rustfmt
rustfmt everything once and for all
2018-11-28 16:19:55 +01:00
Philipp Krones a03ce65134
Merge pull request #3466 from phansch/clippy_rfc_readme
Update docs in regards to the merged RFC
2018-11-28 15:40:44 +01:00
Philipp Krones 33c1e3c08c
Add missing word
Co-Authored-By: phansch <dev@phansch.net>
2018-11-28 14:39:25 +01:00
Philipp Hansch 93e8c9efc9
Update docs in regards to the merged RFC 2018-11-28 08:11:28 +01:00
Philipp Hansch ab5b75ae86
Merge pull request #3464 from flip1995/no_fork_integration
Don't run integration tests in forks
2018-11-28 07:19:49 +01:00
flip1995 14d1e8d174
Document how to run rustfmt in CONTRIBUTING.md 2018-11-27 22:38:15 +01:00
flip1995 27a69bd66c
Don't run integration tests in forks 2018-11-27 22:19:52 +01:00
flip1995 63fa5d24e1
Fix some formatting issues 2018-11-27 21:49:09 +01:00
flip1995 1751d2496d
Run rustfmt on clippy_lints 2018-11-27 21:14:15 +01:00
flip1995 5c5e8cc942
Run rustfmt on build.rs 2018-11-27 21:13:26 +01:00
flip1995 f9c0e2a4cb
Run rustfmt on clippy_dev 2018-11-27 21:13:08 +01:00
flip1995 3befd86967
Run rustfmt on rustc_tools_util 2018-11-27 21:12:38 +01:00
flip1995 d71c871568
Run rustfmt on src 2018-11-27 21:12:13 +01:00
flip1995 2953ae0702
Run rustfmt on the tests 2018-11-27 21:11:50 +01:00
flip1995 4e0938d349
Let travis run cargo fmt --all -- --check 2018-11-27 21:11:05 +01:00
flip1995 ccff495b62
Error on line overflow 2018-11-27 20:46:11 +01:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer b2601beb35
Merge pull request #3459 from flip1995/sugg_appl
Add Applicability to suggestion lints: Take 2
2018-11-27 18:29:33 +01:00
flip1995 87e72a5861
Fix NAIVE_BYTECOUNT applicability 2018-11-27 17:31:17 +01:00
flip1995 6eb8e6d7c5
Fix dogfood error 2018-11-27 16:59:52 +01:00
flip1995 adc638ef33
Change Applicability of MISTYPED_LITERAL_SUFFIX 2018-11-27 16:59:39 +01:00
flip1995 4e74eef6e9
Add applicability level to (nearly) every span_lint_and_sugg function 2018-11-27 15:29:23 +01:00
flip1995 0c6483bf21
Update stderr file 2018-11-27 15:29:23 +01:00
flip1995 3740da203b
Fix bugs and improve documentation
Some bugs and some documentation is unrelated to the Applicability change, but
these bugs were serious and the documentation was kind of required to
understand what's going on.
2018-11-27 15:29:23 +01:00
flip1995 9096269610
Add Applicability::Unspecified to span_lint_and_sugg functions 2018-11-27 15:29:23 +01:00
flip1995 fad267c3b3
Introduce snippet_with_applicability and hir_with_applicability functions 2018-11-27 15:29:14 +01:00