OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
4,990 Commits 1 Branch 0 Tags 636 MiB
c4ef06a9b6
Commit Graph

4990 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Philipp Hansch
c4ef06a9b6
Merge pull request #3497 from daxpedda/master 
Fix bug in `implicit_return`.
 2018-12-06 14:13:20 +01:00
daxpedda
a4ec7be06f
Forgot to remove some debugging code ... 2018-12-06 13:23:42 +01:00
daxpedda
d048e15835
Improved code noted by clippy. 2018-12-06 13:21:04 +01:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
0fb30218d5
Merge pull request #3496 from fkohlgrueber/macro-in-closure-in-if-cond 
fix #3482 and add ui test for it
 2018-12-06 12:26:43 +01:00
daxpedda
973d676cd1
Fix bug in implicit_return. 
Bug was already covered by test, but test was not checked for.
 2018-12-06 12:22:54 +01:00
Felix Kohlgrüber
a8a0b236b5 fix #3482 and add ui test for it 2018-12-06 11:07:10 +01:00
Philipp Hansch
f93591294d
Merge pull request #3494 from daxpedda/master 
Added `IMPLICIT_RETURN` lint.
 2018-12-06 07:12:01 +01:00
Philipp Hansch
7cb1b1f7e1
Merge pull request #3444 from waynr/fix-dogfood-tests 
Fix dogfood tests
 2018-12-06 07:10:04 +01:00
Wayne Warren
0442bb9ce0 Don't change current working directory of cargo tests 2018-12-05 18:18:17 -06:00
Wayne Warren
87d517df5d Use cargo's "PROFILE" envvar and set CLIPPY_DOGFOOD 2018-12-05 18:18:17 -06:00
Wayne Warren
66251c3ece Use dogfood_runner for deterministic test ordering 2018-12-05 18:18:17 -06:00
Wayne Warren
1db535a887 Remove unnecessary documentation 2018-12-05 18:18:17 -06:00
Wayne Warren
72247d8e2e Fix dogfood tests. 2018-12-05 18:18:17 -06:00
daxpedda
b0f3ed2b80 Added additional reasoning to Why is this bad?. 
Added comment to explain usage of MIR.
 2018-12-05 15:01:19 +01:00
daxpedda
aed2b986e6 Renamed to implicit_return. 
Covered all other kinds besides `ExprKind::Lit`.
Added check for replacing `break` with `return`.
 2018-12-05 14:39:09 +01:00
Philipp Krones
29bf75cd31
Merge pull request #3495 from flip1995/tykind_fix 
Fix usage of ty::TyKind
 2018-12-05 13:34:20 +01:00
flip1995
36ee92780d
Fix ty::TyKind usage 2018-12-05 12:47:19 +01:00
flip1995
20a07f6d80
Fix TyKind::<kind> usage in codebase 2018-12-05 12:47:10 +01:00
daxpedda
19db2f1a32 Appeasing the Test Gods. 
Seems I'm not smart enough to run the tests locally before committing.
 2018-12-05 11:26:40 +01:00
daxpedda
978f8c65ee Renamed forced_return to missing_returns. 
Better clarification in the docs.
Ran `update_lints`.
 2018-12-05 10:54:21 +01:00
daxpedda
d5d6692288 Added FORCED_RETURN lint. 2018-12-05 01:59:09 +01:00
Philipp Krones
3f24cdf10f
Merge pull request #3490 from phansch/extract_single_match_else_ui_test 
Extract single_match_else UI test
 2018-12-04 14:57:19 +01:00
Philipp Hansch
68bb900eba
Merge pull request #3473 from lucasloisp/additional-bool-comparisons 
Adds inequality cases to bool comparison (#3438)
 2018-12-04 07:26:29 +01:00
Philipp Hansch
8b2eb06df3
Merge pull request #3488 from phansch/fix_cargo_lint_bug 
Fix wildcard_dependencies false positive
 2018-12-04 07:24:11 +01:00
Philipp Hansch
3f72d4d630
Extract single_match_else UI test 
There's only one test currently.
I also updated the lint doc with a 'good' example and changed the lint
help text a bit.

cc #2038
 2018-12-04 07:20:13 +01:00
Philipp Hansch
46ee676139
cargo fmt 2018-12-04 06:47:41 +01:00
Lucas Lois
3930148059 Adds inequality cases to bool comparison lint 
The lint now checks cases like `y != true`
 2018-12-03 16:32:11 -03:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
c00210d7ba
Merge pull request #3478 from dtolnay/setlen 
Remove unsafe_vector_initialization lint
 2018-12-03 12:42:31 +01:00
David Tolnay
e632a1946e
Remove unsafe_vector_initialization lint 2018-12-03 02:48:37 -08:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
13438b6866
Merge pull request #3479 from dtolnay/literal 
Downgrade large_digit_groups to pedantic
 2018-12-03 11:06:56 +01:00
Philipp Hansch
ef64c762d2
Fix wildcard_dependencies false positive 
This now only checks for wildcard_dependencies if the source is a
non-git source.

I tried adding a compiletest suite for the cargo lints, but I was unable
to override the `Cargo.toml` of the original executable.

I tested this manually by modifying the main `Cargo.toml`.

Fixes #3458
 2018-12-03 08:12:35 +01:00
Philipp Hansch
a6f4cf7740
Merge pull request #3487 from phansch/fix_fmt 
Fix rustfmt format
 2018-12-03 07:44:43 +01:00
Philipp Hansch
ebd508e0ac
Fix rustfmt format 2018-12-03 07:13:00 +01:00
Philipp Hansch
fd54f448bd
Merge pull request #3486 from phansch/make_windows_travis_run_more_stuff 
Travis: Add rustc sysroot bin to PATH for windows build
 2018-12-02 16:29:38 +01:00
Philipp Hansch
39f179da45
Disable incremental build for windows 
Testing if this speeds up compilation time for the Windows CI build.
 2018-12-02 15:09:45 +01:00
Philipp Hansch
d8166bf141
Travis: Add rustc sysroot bin to PATH for windows build 2018-12-02 14:33:19 +01:00
Philipp Hansch
b06594e650
Merge pull request #3483 from phansch/mention_triage_procedure_in_contributing 
Mention triage procedure in contributing.md
 2018-12-02 12:35:14 +01:00
Philipp Hansch
e048fab81e
Merge pull request #3485 from phansch/fix_some_nursery_links 
Fix some nursery links
 2018-12-02 12:33:09 +01:00
Philipp Hansch
451085ca8d
Fix some nursery links 2018-12-02 11:45:05 +01:00
Philipp Hansch
6253d457e1
Merge pull request #3484 from phansch/fix_windows_lineendings 
git: Enforce LF lineendings for everything
 2018-12-02 11:37:05 +01:00
Philipp Hansch
3a7da8b4fa
Enforce LF lineendings for everything 
Someone on discord reported issues with UI tests.

This should make sure that git never automatically converts lineendings
for text files to `CRLF`. They should always be `LF` now.

Probably this means that we can stop using dos2unix for #3306, too.

Taken from [Rust's .gitattributes file](https://github.com/rust-lang/rust/blob/master/.gitattributes).
 2018-12-02 11:05:39 +01:00
Philipp Hansch
40d58f9195
Mention triage procedure in contributing.md 2018-12-02 09:35:47 +01:00
David Tolnay
1a14cb3643
Keep testing large_digit_groups as ui test 2018-12-01 17:23:53 -08:00
David Tolnay
67f9d24c1b
Keep testing unsafe_vector_initialization as ui test 2018-12-01 17:19:39 -08:00
David Tolnay
c00dcd03d7
Downgrade large_digit_groups to pedantic 
I believe if the user already decided to put underscores in their
literal, Clippy should be willing to believe that they put a number of
underscores that they felt was readable.
 2018-12-01 17:08:42 -08:00
David Tolnay
8b1f69a485
Downgrade unsafe_vector_initialization to restriction 
This lint looks for:

    let mut vec = Vec::with_capacity(len);
    vec.set_len(len);

The suggested replacement is `vec![0; len]`.

This is far too opinionated to be a deny-by-default lint because the performance
characteristics of the suggested replacement are totally different.

I am not convinced that this lint has value beyond what deny(unsafe_code) gives
you. Unsafe code is unsafe but please don't deny-by-default lint it if that's
the only reason.
 2018-12-01 16:21:02 -08:00
Philipp Hansch
c669727df4
Merge pull request #3471 from matthiaskrgr/mamor_warn 
remove macro_at_most_once_rep feature attribute since it's stable
 2018-11-30 10:20:24 +01:00
Matthias Krüger
c38bac89e9 remove macro_at_most_once_rep feature attribute since it's stable 
Warning was:
warning: the feature `macro_at_most_once_rep` has been stable since 1.32.0 and no longer requires an attribute to enable
  --> clippy_lints/src/lib.rs:19:12
   |
19 | #![feature(macro_at_most_once_rep)]
   |            ^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: #[warn(stable_features)] on by default
 2018-11-30 09:14:18 +01:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
f5831523d3
Merge pull request #3465 from flip1995/rustfmt 
rustfmt everything once and for all
 2018-11-28 16:19:55 +01:00
Philipp Krones
a03ce65134
Merge pull request #3466 from phansch/clippy_rfc_readme 
Update docs in regards to the merged RFC
 2018-11-28 15:40:44 +01:00