OpenE2K
/
rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
5,036 Commits 1 Branch 0 Tags 636 MiB
Commit Graph

1783 Commits

Author SHA1 Message Date
bors ada0b2b095 Auto merge of #3518 - sinkuu:redundant_clone_tw, r=phansch 
Lint redundant clone of fields

Makes `redundant_clone` warn on unnecessary `foo.field.clone()` sometimes (it can detect an unnecessary clone only if the base of projection, `foo` in this case, is not used at all after that). This is enough for cases like `returns_tuple().0.clone()`.
 2018-12-10 18:55:49 +00:00
Shotaro Yamada 109d4b1ab3 Lint redundant clone of projection 2018-12-10 08:48:14 +09:00
Matthias Krüger 9b839cd4b5 update line numbers of tests 2018-12-09 17:24:08 +01:00
Matthias Krüger 4583d78156 add rustfmt::skip attributes to some tests 2018-12-09 17:21:49 +01:00
Shotaro Yamada a4fe567602 Fix test 
`if true` is recognized by MIR optimization.
 2018-12-09 23:51:31 +09:00
Philipp Hansch 43542f8d89
Remove a run-rustfix annotation (for now) 
Starting to work on #2376, this annotation got in the way. Going to
remove it for now.
 2018-12-09 15:16:36 +01:00
Philipp Hansch 26602ddff4
Merge pull request #3336 from HMPerson1/clone_on_copy_deref 
Fix `clone_on_copy` not detecting derefs sometimes
 2018-12-08 09:59:02 +01:00
Philipp Hansch 041c49c1ed
Merge pull request #3257 from o01eg/remove-sysroot 
Don't try to determine sysroot. rustc_driver will use default value.
 2018-12-06 22:11:29 +01:00
Philipp Hansch c4ef06a9b6
Merge pull request #3497 from daxpedda/master 
Fix bug in `implicit_return`.
 2018-12-06 14:13:20 +01:00
daxpedda 973d676cd1
Fix bug in `implicit_return`. 
Bug was already covered by test, but test was not checked for.
 2018-12-06 12:22:54 +01:00
O01eg 278b94e6db
Fix format. 2018-12-06 13:46:23 +03:00
O01eg 5113de90d1
Add sysroot gettinh code to dogfood tests. 2018-12-06 13:21:45 +03:00
Felix Kohlgrüber a8a0b236b5 fix #3482 and add ui test for it 2018-12-06 11:07:10 +01:00
O01eg 571d4cc7bf
Add sysroot getting code to tests. 2018-12-06 12:23:47 +03:00
Philipp Hansch f93591294d
Merge pull request #3494 from daxpedda/master 
Added `IMPLICIT_RETURN` lint.
 2018-12-06 07:12:01 +01:00
Wayne Warren 0442bb9ce0 Don't change current working directory of cargo tests 2018-12-05 18:18:17 -06:00
Wayne Warren 87d517df5d Use cargo's "PROFILE" envvar and set CLIPPY_DOGFOOD 2018-12-05 18:18:17 -06:00
Wayne Warren 66251c3ece Use dogfood_runner for deterministic test ordering 2018-12-05 18:18:17 -06:00
Wayne Warren 72247d8e2e Fix dogfood tests. 2018-12-05 18:18:17 -06:00
daxpedda aed2b986e6 Renamed to `implicit_return`. 
Covered all other kinds besides `ExprKind::Lit`.
Added check for replacing `break` with `return`.
 2018-12-05 14:39:09 +01:00
daxpedda 978f8c65ee Renamed `forced_return` to `missing_returns`. 
Better clarification in the docs.
Ran `update_lints`.
 2018-12-05 10:54:21 +01:00
daxpedda d5d6692288 Added `FORCED_RETURN` lint. 2018-12-05 01:59:09 +01:00
Philipp Krones 3f24cdf10f
Merge pull request #3490 from phansch/extract_single_match_else_ui_test 
Extract single_match_else UI test
 2018-12-04 14:57:19 +01:00
Philipp Hansch 68bb900eba
Merge pull request #3473 from lucasloisp/additional-bool-comparisons 
Adds inequality cases to bool comparison (#3438)
 2018-12-04 07:26:29 +01:00
Philipp Hansch 3f72d4d630
Extract single_match_else UI test 
There's only one test currently.
I also updated the lint doc with a 'good' example and changed the lint
help text a bit.

cc #2038
 2018-12-04 07:20:13 +01:00
Lucas Lois 3930148059 Adds inequality cases to bool comparison lint 
The lint now checks cases like `y != true`
 2018-12-03 16:32:11 -03:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer c00210d7ba
Merge pull request #3478 from dtolnay/setlen 
Remove unsafe_vector_initialization lint
 2018-12-03 12:42:31 +01:00
David Tolnay e632a1946e
Remove unsafe_vector_initialization lint 2018-12-03 02:48:37 -08:00
David Tolnay 1a14cb3643
Keep testing large_digit_groups as ui test 2018-12-01 17:23:53 -08:00
David Tolnay 67f9d24c1b
Keep testing unsafe_vector_initialization as ui test 2018-12-01 17:19:39 -08:00
flip1995 2953ae0702
Run rustfmt on the tests 2018-11-27 21:11:50 +01:00
flip1995 0c6483bf21
Update stderr file 2018-11-27 15:29:23 +01:00
Guillem Nieto 5fa04bc3cd Lint only the first statment/expression after alloc 
Instead of searching for all the successive expressions after a vector
allocation, check only the first expression.

This is done to minimize the amount of false positives of the lint.
 2018-11-25 14:34:23 -08:00
Guillem Nieto 5b77ee95dc Rename some symbols 
Renamed some symbols in order to make them a little bit more accurate.
 2018-11-25 14:34:23 -08:00
Guillem Nieto 2753f1cbd4 Split lint into slow and unsafe vector initalization 2018-11-25 14:34:23 -08:00
Guillem Nieto 9b4bc3b6ef Add unsafe set_len initialization 2018-11-25 14:34:23 -08:00
Guillem Nieto e0ccc9d9af Add slow zero-filled vector initialization lint 
Add lint to detect slow zero-filled vector initialization. It detects
when a vector is zero-filled with extended with `repeat(0).take(len)`
or `resize(len, 0)`.
This zero-fillings are usually slower than simply using `vec![0; len]`.
 2018-11-25 14:34:23 -08:00
Matthias Krüger f5929e0797 rust-lang-nursery/rust-clippy => rust-lang/rust-clippy 2018-11-22 04:40:09 +01:00
Wayne Warren ca4803101f Update trivially_copy_pass_by_ref with Trait stderr output 2018-11-21 07:52:02 -06:00
Wayne Warren 67c32eb2c4 Update trivially_copy_pass_by_ref with Trait examples 2018-11-21 07:52:02 -06:00
flip1995 655a2b4709
Add regression test 2018-11-15 17:06:36 +01:00
Michael Wright e2e892b59b Fix wrong suggestion for `redundant_closure_call` 
Fixes #1684
 2018-11-14 08:01:39 +02:00
Michael Wright 5ade9ff44e Fix `use_self` false positive on `use` statements 2018-11-13 06:15:33 +02:00
Michael Wright 460c2b317b Fix `use_self` false positive 
This fixes the first error reported in issue #3410.
 2018-11-10 10:57:11 +02:00
Michael Wright 2353f24095 Merge branch 'master' into fix-missing-comma-fp 2018-11-06 07:00:54 +02:00
bors[bot] 7e417d4cbd Merge #3353 
3353: float support added for mistyped_literal_suffixes lint r=mikerite a=Maxgy

I implemented the mistyped_literal_suffixes lint for float literals.

```
#![allow(unused_variables)]

fn main() {
    let x = 1E2_32;
    let x = 75.22_64;
}
```
Given the above, the additional check suggests the variables to be written as `let x = 1E2_f32` and `let x = 75.22_f64`.

Fixes #3167 

Co-authored-by: Maxwell Anderson <maxwell.brayden.anderson@gmail.com>
 2018-11-05 03:58:15 +00:00
Michael Wright 0c1ffc1d1f Fix `possible_missing_comma` false positives 
`possible_missing_comma` should only trigger when the binary operator has
unary equivalent. Otherwise, it's not possible to insert a comma without
breaking compilation. The operators identified were `+`, `&`, `*` and `-`.

This fixes the specific examples given in issues #3244 and #3396
but doesn't address the conflict this lint has with the style of starting
a line with a binary operator.
 2018-11-04 10:02:49 +02:00
bors[bot] 486300b89d Merge #3400 
3400: Fix a false-positive of needless_borrow r=phansch a=sinkuu



Co-authored-by: Shotaro Yamada <sinkuu@sinkuu.xyz>
 2018-11-03 08:34:13 +00:00
flip1995 318f84ffcf
Update stderr 2018-11-02 19:50:24 +01:00
flip1995 5c1385249e
Rename test files 2018-11-02 19:50:24 +01:00