7df7a0a86e
Add tests from rustfmt::skip test file
2018-11-02 19:50:24 +01:00
352da1d33d
Add test for non-crate-level inner attributes
2018-11-02 19:49:58 +01:00
7bd8c303d3
Add tests
2018-11-02 19:49:58 +01:00
2d1c9313b0
Added lints `into_iter_on_ref` and `into_iter_on_array`. Fix #1565 .
2018-11-02 22:53:56 +08:00
faa1db3391
Update stderr
2018-11-02 13:49:10 +01:00
4e1102f56c
Add copyright statement©
2018-11-02 13:49:10 +01:00
ea4a80f215
Fix typo and indentation
2018-11-02 13:49:10 +01:00
8d516b36fe
Add tests for unknwon_clippy_lints lint
2018-11-02 13:49:09 +01:00
df7cff31dc
clippy: fix pedantic warnings and run clippy::pedantic lints on the codebase.
...
Turn on pedantic lints in dogfood and base tests.
needless_bool: fix clippy::items-after-statements
redundant_pattern_matching: fix clippy::similar-names
mods.rs: fix clippy::explicit-iter-loop
returns.rs: allow clippy::cast-possible-wrap
Fixes #3172
2018-11-02 12:16:43 +01:00
ae137d526c
Merge #3397 #3398
...
3397: UI test cleanup: Extract expect_fun_call tests r=matthiaskrgr a=phansch
Note that the new stderr file does not include a `shadow-unrelated`
error, because the new UI test file does not use `#![warn(clippy::all)]`
cc #2038
3398: UI test cleanup: Extract match_overlapping_arm tests r=matthiaskrgr a=phansch
cc #2038
Co-authored-by: Philipp Hansch <dev@phansch.net>
2018-11-02 07:34:38 +00:00
d4370f8b07
Fix a false-positive of needless_borrow
2018-11-02 15:58:54 +09:00
e5af43d426
UI test cleanup: Extract match_overlapping_arm tests
2018-11-02 07:19:30 +01:00
26569f3dde
UI test cleanup: Extract expect_fun_call tests
...
Note that the new stderr file does not include a `shadow-unrelated`
error, because the new UI test file does not use `#![warn(clippy::all)]`
2018-11-02 07:18:56 +01:00
3c22b2314c
Merge remote-tracking branch 'upstream/master'
2018-10-31 16:48:47 -06:00
6a165e5a92
Merge #3392
...
3392: UI test cleanup: Extract for_loop_over_x tests r=matthiaskrgr a=phansch
cc #2038
Co-authored-by: Philipp Hansch <dev@phansch.net>
2018-10-31 21:08:34 +00:00
c8308c92b6
Merge #3378
...
3378: Fix lint_without_lint_pass r=phansch a=mikerite
Co-authored-by: Michael Wright <mikerite@lavabit.com>
Co-authored-by: flip1995 <hello@philkrones.com>
2018-10-31 07:18:42 +00:00
b144c7f35d
Merge #3370
...
3370: bool_comparison triggers 3 times on same code r=phansch a=mrbuzz
Fix #3335
Co-authored-by: Giorgio Gambino <gambnio.giorgio@gmail.com>
2018-10-31 06:48:49 +00:00
b421f5ad48
UI test cleanup: Extract for_loop_over_x tests
2018-10-30 21:25:34 +01:00
3d84ffb5ec
Update .stderr file
2018-10-29 20:55:52 +01:00
a7fc6799df
Rewrite registered lint collection
2018-10-29 20:44:45 +01:00
267d5d3433
Fix lint_without_lint_pass
2018-10-29 20:28:06 +01:00
be7656d992
compiletest: clean rmeta data (from "cargo check") before running compiletest.
...
Fixes #2896
Fixes #2139
2018-10-29 12:29:40 +01:00
00ed70526a
Merge #3373
...
3373: UI test cleanup: Extract unnecessary_operation tests r=matthiaskrgr a=phansch
cc #2038
Co-authored-by: Philipp Hansch <dev@phansch.net>
2018-10-28 22:52:21 +00:00
18b122005f
UI test cleanup: Extract explicit_counter_loop tests
2018-10-28 18:56:49 +01:00
7adc8dc956
UI test cleanup: Extract unnecessary_operation tests
2018-10-28 18:40:29 +01:00
14d2700b6f
Merge #3217 #3366
...
3217: Fix string_lit_as_bytes lint for macros r=phansch a=yaahallo
Prior to this change, string_lit_as_bytes would trigger for constructs
like `include_str!("filename").as_bytes()` and would recommend fixing it
by rewriting as `binclude_str!("filename")`.
This change updates the lint to act as an EarlyLintPass lint. It then
differentiates between string literals and macros that have bytes
yielding alternatives.
Closes #3205
3366: Don't expand macros in some suggestions r=oli-obk a=phansch
Fixes #1148
Fixes #1628
Fixes #2455
Fixes #3023
Fixes #3333
Fixes #3360
Co-authored-by: Jane Lusby <jlusby42@gmail.com>
Co-authored-by: Philipp Hansch <dev@phansch.net>
2018-10-28 17:13:34 +00:00
62f16803e8
Fix #3335 rev1: bool_comparison triggers 3 times on same code
2018-10-28 16:28:17 +01:00
7cfde9cfa9
Fix #3335 : bool_comparison triggers 3 times on same code
2018-10-28 15:37:39 +01:00
183e19a1c3
Merge remote-tracking branch 'upstream/master'
2018-10-27 12:50:12 -06:00
840e50e97f
Don't expand macro in or_fun_call suggestion
2018-10-27 15:47:56 +02:00
af1548f58f
Don't expand macro in single_match suggestion
2018-10-27 15:47:56 +02:00
aa7bcb9074
Don't expand macro in identity_conversion suggestion
2018-10-27 15:47:56 +02:00
19ac2e94c6
fix: correctly reconstruct raw strings
2018-10-26 09:12:01 -07:00
f9020bb2dd
fix: extra semicolon, only create callsite once
2018-10-26 09:12:01 -07:00
c209fc9349
Fix string_lit_as_bytes lint for macros
...
Prior to this change, string_lit_as_bytes would trigger for constructs
like `include_str!("filename").as_bytes()` and would recommend fixing it
by rewriting as `binclude_str!("filename")`.
This change updates the lint to act as an EarlyLintPass lint. It then
differentiates between string literals and macros that have bytes
yielding alternatives.
Closes #3205
2018-10-26 09:12:01 -07:00
457e7f12e9
Merge #3355
...
3355: Lint to remove redundant `clone()`s r=oli-obk a=sinkuu
This PR adds lint `redundant_clone`. It suggests to remove redundant `clone()` that clones a owned value that will be dropped without any usage after that.
Real-world example: https://github.com/rust-lang/rust/compare/7b0735a..sinkuu:redundant_clone2
Co-authored-by: Shotaro Yamada <sinkuu@sinkuu.xyz>
2018-10-26 10:36:43 +00:00
ead29847ff
Merge #3357
...
3357: Check existential types in `use_self` r=oli-obk a=HMPerson1
Fixes #3231
Co-authored-by: HMPerson1 <hmperson1@gmail.com>
2018-10-26 08:48:12 +00:00
9a150b4aa1
Use lint_root
2018-10-26 01:16:14 +09:00
105ae712f4
update_references indexing_slicing
2018-10-26 01:16:14 +09:00
3ca0895920
Add redundant_clone lint
2018-10-26 01:15:55 +09:00
a87e1b02ab
Merge #3331
...
3331: Disable arithmetic lints in constant items r=oli-obk a=pengowen123
Currently this will not catch cases in associated constants. I'm not sure whether checking spans is the best way to solve this issue, but I don't think it will cause any problems.
Fixes #1858
Co-authored-by: Owen Sanchez <pengowen816@gmail.com>
2018-10-25 09:38:00 +00:00
d53e6f87e9
Add tests for more than one level of reference
2018-10-24 23:39:55 -04:00
1a6bfecf38
Add test case for `mem::discriminant` inside a macro
2018-10-24 23:39:55 -04:00
aabf8083bd
Add lint for calling `mem::discriminant` on a non-enum type
2018-10-24 23:39:54 -04:00
3db14f182c
Check existential types in `use_self`
2018-10-24 23:32:33 -04:00
0b9e9c9e3d
Disable arithmetic lints in constant items
2018-10-24 20:27:26 -07:00
4c6201dceb
Merge #3312
...
3312: OUT_OF_BOUNDS_INDEXING false negative r=phansch a=JoshMcguigan
fixes #3102
Co-authored-by: Josh Mcguigan <joshmcg88@gmail.com>
2018-10-24 21:17:43 +00:00
bce190558f
Merge #3338
...
3338: new_ret_no_self false positives r=flip1995 a=JoshMcguigan
~~WORK IN PROGRESS~~
I plan to fix all of the false positives in #3313 in this PR, but I wanted to open it now to start gathering feedback.
In this first commit, I've updated the lint to allow tuple return types as long as `Self` shows up at least once, in any position of the tuple. I believe this is the broadest possible interpretation of what should be allowed for tuple return types, but I would certainly be okay making the lint more strict.
fixes #3313
Co-authored-by: Josh Mcguigan <joshmcg88@gmail.com>
2018-10-24 14:42:40 +00:00
30ffc17ef7
new_ret_no_self added test cases
2018-10-24 06:43:21 -07:00
03f8899fa5
Merge #3350
...
3350: Don't emit `new_without_default_derive` if an impl of Default exists regardless of generics r=oli-obk a=pengowen123
Fixes #2226
Co-authored-by: Owen Sanchez <pengowen816@gmail.com>
2018-10-24 07:59:06 +00:00
50b9e7aebc
Don't emit `new_without_default_derive` if an impl of Default exists
2018-10-23 20:44:31 -07:00
6a695ffb3d
added float support for mistyped literal lints
2018-10-23 15:54:27 -06:00
a624583557
new_ret_no_self added test cases
2018-10-20 06:29:17 -07:00
553d01d9c7
Update `ui/for_loop` test output
2018-10-19 17:17:13 -04:00
2e9172aea2
Check for known array length in `needless_range_loop`
2018-10-19 16:34:16 -04:00
2a9dec681f
Fix suggestion for multiple derefs
2018-10-19 14:51:25 -04:00
097df8f223
new_ret_no_self correct false positive on raw pointer return types
2018-10-19 05:20:33 -07:00
6e75050be0
new_ret_no_self correct linting of tuple return types
2018-10-19 04:55:06 -07:00
a2be050965
Fix `clone_on_copy` not detecting derefs sometimes
2018-10-19 00:03:56 -04:00
9f637288cf
Merge remote-tracking branch 'upstream/master'
2018-10-18 15:45:05 -06:00
5614dcb4ea
Support multiline comments and hopefully fix panic
2018-10-18 18:57:16 +02:00
8753e568bf
Check for comments in collapsible ifs
2018-10-18 18:00:21 +02:00
1264bb6b7d
Merge pull request #3323 from pengowen123/fix_manual_memcpy
...
Simplify manual_memcpy suggestion in some cases
2018-10-18 09:44:24 +02:00
284c63e84d
Merge pull request #3281 from CYBAI/redundant-match
...
Add lint for redundant pattern matching for explicit return boolean
2018-10-17 07:31:09 +02:00
66ae3b1249
Rename if_let_redundant_pattern_matching to redundant_pattern_matching
...
Also, making the old one deprecated
2018-10-17 11:20:42 +08:00
3b7c88888b
Add lint for redundant pattern matching for explicit return boolean
2018-10-17 11:14:37 +08:00
aa88e68902
Fix issue #3322 : reword help message for len_zero
2018-10-16 23:23:31 +02:00
8c902d1cf2
Simplify manual_memcpy suggestion in some cases
2018-10-16 12:38:23 -07:00
2d8b4f3d5c
Avoid linting `boxed_local` on trait implementations.
2018-10-15 20:34:45 +02:00
66d3672b26
out_of_bounds_indexing improved reporting of out of bounds value
2018-10-15 04:44:39 -07:00
456843f1cd
Swap order of methods in `needless_range_loop` suggestion in some cases
2018-10-14 20:14:16 -07:00
0f3345e8b2
OUT_OF_BOUNDS_INDEXING fix #3102 false negative
2018-10-13 13:51:53 -07:00
601cc9d2c5
Merge pull request #3310 from JoshMcguigan/explicit_counter_loop-3308
...
explicit_counter_loop fix #3308 false positive
2018-10-13 20:11:50 +02:00
c6f79c7ba0
explicit_counter_loop fix #3308 false positive
2018-10-13 06:57:52 -07:00
3f386d33f9
new_ret_no_self test remove tool lints cfg flag
2018-10-13 06:33:46 -07:00
348d18ebd8
Removed new_ret_no_self tests from method.rs
2018-10-13 06:25:10 -07:00
a5e4805ecf
new_ret_no_self correctly lint impl return
2018-10-13 06:20:39 -07:00
1c4fa419f3
new_ret_no_self fix false positive for impl trait return with associated type self
2018-10-13 06:20:39 -07:00
13ce96c4bf
new_ret_no_self corrected panic and added test stderr
2018-10-13 06:20:39 -07:00
eb854b233c
new_ret_no_self added positive test cases
2018-10-13 06:20:39 -07:00
8b12eee112
Merge pull request #3233 from rust-lang-nursery/unused-unit
...
new lint: unused_unit
2018-10-13 09:30:19 +02:00
e8687a6677
unused unit lint
2018-10-13 00:42:55 +02:00
d445dbfe16
Merge pull request #3291 from JoshMcguigan/cmp_owned-3289
...
cmp_owned wording and false positive
2018-10-12 15:07:12 +02:00
c9718fa589
cmp_owned correct error message if rhs is deref
2018-10-12 04:34:41 -07:00
63fbeaab68
Merge remote-tracking branch 'upstream/master'
2018-10-11 22:16:05 -06:00
9fad38dca9
tmp progress
2018-10-11 22:15:01 -06:00
0b65462ca5
cmp_owned current suggestion for multiple deref
2018-10-11 05:03:02 -07:00
9d3373137b
Remove now-useless `allow(unknown_lints)`
2018-10-11 12:18:27 +02:00
b8654eaa6c
Stabilize tool lints
2018-10-11 12:16:22 +02:00
31eb3b73d3
Merge pull request #3127 from mikerite/fix-2937
...
Fix 2937
2018-10-11 06:22:02 +02:00
f9e4f5695d
Limit commutative assign op lint to primitive types
2018-10-10 19:10:44 +02:00
d41615548e
cmp_owned add test for multiple dereference
2018-10-10 04:51:06 -07:00
7499cb543d
Fix #2937
2018-10-10 07:52:58 +02:00
b0d7aea946
Fixes 3289, cmp_owned wording and false positive
2018-10-09 19:25:03 -07:00
f6882ede4d
Merge pull request #3287 from JoshMcguigan/cmp_owned-2925
...
cmp_owned false positive
2018-10-09 10:01:31 +02:00
ad5c29a445
Fixes #2925 cmp_owned false positive
2018-10-08 19:04:29 -07:00
a578cb2d62
if_let_redundant_pattern_matching: use Span.to() instead of Span.with_hi() to fix crash.
...
Fixes #3064
2018-10-08 17:34:43 +02:00
1ef32e4096
Improve diagnostics in case of lifetime elision ( closes #3284 )
2018-10-08 13:07:21 +03:00
02705d4cf5
Merge pull request #3282 from JoshMcguigan/excessive_precision-2840
...
Fix excessive_precision false positive
2018-10-08 08:24:13 +02:00
9bd4e5469e
Don't suggest cloned() for map Box deref
...
Boxes are a bit magic in that they need to use `*` to get an owned value
out of the box. They implement `Deref` but that only returns a
reference. This means an easy way to convert an `Option<Box<T>>` to an
`<Option<T>` is:
```
box_option.map(|b| *b)
```
However, since b36bb0a6Fixes #3274
2018-10-08 06:20:32 +11:00
flip1995
flip1995
kennytm
Matthias Krüger
bors[bot]
Shotaro Yamada
Philipp Hansch
Maxwell Anderson
Michael Wright
Giorgio Gambino
Jane Lusby
HMPerson1
Owen Sanchez
Josh Mcguigan
Lukas Stevens
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
CYBAI
Bruno Kirschner
Andre Bogus
mikerite
Karim SENHAJI
Rotem Yaari
Ryan Cumming