* * Make it impossible to create playlists with spaces wrapped name & show duplicate playlist message sooner
* * Update default new playlist name to include channel name when copying a remote playlist
* * Show duplicate playlist message sooner for blank playlist name
* Update per code review
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* * Only show blank playlist name message when spaces input
* ! Fix create button not disabled when input name blank (not empty)
* !* Fix message shown in edit mode, update edit mode to show error message for empty/blank/duplicate input playlist name
* $ Fix indentation warning from lint
* ! Fix able to create playlist with invalid playlist names
---------
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* $ Remove duplicate line in a method setting a property to the same value
* * Update playlist page to add remove duplicate videos button for user playlists
* * Make remove watched videos button visible when any video watched
* * Use different icon
* * Show no. of items to be deleted on prompts
* Implement playlist sorting
* Hide sort menu for remote playlists
* Remove 'Custom (descending)' sort order
I don't see the need for this particular sort order.
* Adjust sort order & align dropdown with 'More Options' button
* Make 'Latest added first' default option instead of custom
* Remove unlikely-to-be-implemented 'Date published' sorting options
Context from absidue: 'I don't think we should even attempt to support it, due to all of the situations where it wouldn't be possible.'
* Update to use sortOrder as main variable throughout
* Hide sort menu for playlists of length <2
* Send sorted user playlist to watch-video-playlist
* Implement minor reversing optimization / cleanup
* Update src/renderer/helpers/playlists.js
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Change Playlist.js logic to cache user playlists, and pass the sorted user playlist
---------
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Add confirmation popup before unsubscribing
* Added translation to confirmation popup
* Add accidental popup setting
* Remove extra parameter from handleSubscription function
* Resolve unsubscription problem in case of mutiple profiles
* Remove un-utilized allowPlayingVideoRemoval disabled option
* Have currently deleted video entry become the prior entry in the playlist
* Fix issue where first video is skipped when current video after removal is zeroth & loop is enabled
* Handle first video in playlist being removed
* Fix shuffle prevVideo issue
* Fix wrong variable for reversal bug
* Implement suggested optimization
* * Make adding duplicate disabled by default
* * Make additional text work for multi video adding
* * Put controls toward the end
* * Add new label text to translation file
* * Use set instead of array for performance
* * Add aria-disabled to disabled playlist selector
* * Move toggles to the left
* #917 - Display Subtitles/CC and 4k tag
* Display Subtitles/CC and 4k tag - Implement themes
* Review comment changes - 4k and subtitle implementation
* Changes for review comments
* Implementation of "Live" label
* Back out duplication of "Live" label
* Changes based on code review
* Set a max length of 100 for most inputs
Excluded are playlist descriptions, which presumably deserve to have some leeway, and the password input, to prevent the edge case of a user being locked out if they had a longer one set (and also why not for this one).
* Remove maxlength where it constrains valid inputs
* Update proxy port and playlist description maxlength
* Implement suggested changes
* Update with suggested changes to make null maxlength the default
* Implement suggested changes
* Allow filtering searches by features
* use include instead of some
* use created instead of mounted for ft-radio-button and ft-checkbox-list
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
* update css and classes used in ft-checkbox-list
* small bug fixes
* Remove unused prop
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
---------
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Implement user playlist grid view
* Update to use listType setting for user playlist display type
* Implement styling fixes & adjustments
* Update ft-refresh-widget to use fixed-top-bar mixin
* Fix mixin
* Disable quick bookmark button on Quick Bookmark playlist
* Fix isLoading artifact
* Implement missing Edit Mode properties for grid view
* Make playlist title fixed height
* Standardize gap between top bar and bottom section using CSS variables & calc()
* Make effectiveListType computed property
* Force list view on playlists for mobile devices
* Update to adjust height properly when playlist only has one item, not just zero
* Move is-side-nav-open and fixed-top-bar mixins to new partial file
* Add height threshold for forcing list view on playlist route
* Make user playlist grid top section sticky, not fixed
* Update disabled ft-icon-button styling to show title on hover and use aria-disabled
* Update Quick Bookmark button logic
* Import regular fontawesome icons for showing the bookmark
The original plan: use the Quick Bookmark icons here for enabled/disabled sates. Problem: colors would be off if we used the same background color for the ft-list-item. Button would barely appear visible. Thereore, we should probably use the existing 'secondary' theme. Problem: the 'checked' icon then looks unrecognizable and instead generic. Solution: use 'unfilled'/regular icon version for disabled state and 'filled'/solid icon version for enabled state, specifically on the ft-playlist-info page.
* Implement Quick Bookmark establishment on startup, playlist addition, and playlist deletion
* Update translation text
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Prevent quick bookmark playlist target from being deleted
* Co-authored code with @PikachuEXE allowing quick bookmark to be set on ft-list-playlist item
* Update logic to use empty or latest played playlist as fallback target
Also removes now unneeded on-removal logic.
* Update to add toast messages on disabled icon buttons
* Update disabled bookmark icon styling
* Update to use @disabled-click event instead of showToast-specific behavior
The prior implementation was also leading into module loading errors.
* Update label to be more clear, and add periods to convey more seriousness
* Update casing for label
* Remove outdated piece of code
---------
Co-authored-by: PikachuEXE <git@pikachuexe.net>
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Sorted and grouped themes and colors
* Sort themes properly in dropdown
* Add code comment about grouping
* Fix lint
* fix lint again
* lint should be fixed now
* trim whitespace again...
* Add comment for consistency
* Add 'readable width' theme for making release notes more easily readable
* Update spacing to be even
* Update width to 50em
* Update mobile changelog styling
absidue
PikachuEXE
ChunkyProgrammer
Markus Gaugg
Jason
Mehul Sweeti Agrawal
dependabot[bot]
Phil's Git repository
efb4f5ff-1298-471a-8973-3d47447115dc
Emma