* Implement proposed formatting changes
* Increase font-size of video metrics to 14px
* More closely colocate title and channel to compensate for larger video metrics font size
* Update breakpoint for single column template to 1000px to minimize icon wrapping
* Fix like icon being on a different line from the text on smaller screen widths
* Update all Watch breakpoints to 1050px from 900px
* Implement pagination for user playlists on the Playlist page
* Fix the load more loading icon being displayed off-screen
* Caching user playlists is unnecessary as they are already in the store
* ft-list-video: Only render description element if there is a description
* Minor speed ups in the playlists store
* ft-list-video: Remove superfluous template around view count
* ft-list-video: Replace watched property with historyEntryExists computed property
* playlist-info: Fix copying partially loaded user playlists
* Fix the playlist number not getting lazy loaded
* Reduce nesting levels
Co-authored-by: PikachuEXE <git@pikachuexe.net>
---------
Co-authored-by: PikachuEXE <git@pikachuexe.net>
* Add support for viewing movie trailers with local api
* add support for age restricted trailers
* remove unused changes
* always show trailer, regardless of video playability status
* Improve movie parsing logic
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* check for null instead of truthy
* Exclude unneeded properties
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
---------
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Implement hiding of videos with user-inputted text
* Implement ft-input minInputLength
* Enable for playlists
* Enable feature on channel pages
The premise for this change is that users would not want to see that forbidden content anywhere, as opposed to hidden channels, where you're clearly on a channel page to see things from that channel.
* Fix 'Play Next Video' playing forbiddenTitle videos and hidden channel videos
* Fix issue of hidden recommended videos taking up vertical space
* Rename variables to better match non-video-specific function, and remove blocks from History and videos in playlists
* Fix to respect hideForbiddenTitles value
* Modify label
* Clarify restriction affecting original titles
* Add toast for entered input of length below min input length
* Add toast for element already exists
* Update to not clear if duplicate tag is entered for Hide Forbidden feature
* + Add feature to set a playlist as quick bookmark target
* Add back button to watch page
* focus behavior style update
* * Different button text when video saved
* ! Fix mutation function `removeVideos` (still unused)
* * Make default generated favorites playlist as default quick bookmark target
* ! Add fix for `deleteVideoIdsByPlaylistId`
* * Update button text
* * Update quick bookmark playlist first allow revert later
* * Update single playlist view to hide fav button when viewing the target playlist
* - Remove unused code
* ! Fix add/removing videos from favourite list
* ! Fix playlist type not passed into video list item component
* ! Fix playlist data loading issue on new windows
* ! Fix user playlist data parsing
* * Ensure playlist view rerender on video additonal removal for displayed playlist
* ! Fix icons & moving videos up/down in user playlist
* * Don't show move up/down buttons when cannot be done
* * Make user playlist view filtering function now works for filtering playlists
* ! Fix style of prompt from any button within playlist-info component
* $ Refactor a function to use early return style
* * Disallow empty playlist name when saving in playlist edit mode
* * Update add video to playlist prompt to have simple filtering like user playlist view
* * Update playlist view to only show video reorder/remove buttons in edit mode
With notice message
* ! Fix playlist view for remote playlist unnecessary reload on save
* ! Fix add to playlist prompt behaviour when some playlists are hidden due to filtering
* $ Remove unused watch function arguments
* * Update user playlist view create new playlist button position
* * Update playlist view to add transitions to video reorder/removal
* * Allow playlist with different case to be created
* * Update visibility of user playlist related action components according to hide playlist settings
Only those visible on video, remote playlist are updated
* * Update video items to only show add to playlist buttons on hover
* - Remove add to favorites button from video list item component
* * Update watch-video-info component to add "add to playlist" button
* * Update watch-video-info component to remove "add to favourite" button
* * Ensure video thumbnail image displayed in 16/9 aspect ratio
Mainly due to YT missing video thumbnail image got different aspect ratio 4/3
* * Update new buttons theme
* * Put edit playlist button before copy button
* * Move "remove video from playlist" button to most right
* * Make video reorder & remove button visible on hover in user playlist view, regardless of "edit mode"
* ! Fix video count parsing for user playlist
* * Update user playlist to allow duplicate video entries (per video ID)
* * Remove extra attributes assignment to video object except `timeAdded`
Unintended change
* * Update copy playlist button to like adding multiple videos to playlists
* * Update copy playlist prompt to prefill title if create new playlist prompt shown
* * Ensure all playlists have `playlistName`
* $- Remove unused playlist property `removeOnWatched`
* * Update read all playlist code to ensure existing "default" playlist properties (_id, protected) have same values as those in default
Also fix issue discovered during testing
* *- Remove unnecessary code line
* * Update playlists from default playlists to be deletable
* ! Fix duplicate `timeAdded` value for videos copied from user playlist
* ! Fix playlist import (tested with db file exported from this branch)
* * Update grid view to only display playlist title up to 255 chars
Still can see full title in single playlist view
* * Update add video to playlist prompt to only display playlist title up to 255 chars
* * Update text of new playlist button to be same as new profile button
* * Ignore many extra keys from playlist objectrs
Also make data import check for object keys against required keys not key counts
* * Disallow playlist import from changing internal playlist ID of existing playlists
Existing playlists are matched by playlist name, not by internal playlist ID
* * Ensure playlist name & description trimmed when saved
* * Add missing change for importing playlist to ignore `protected`
* $ Refactor code for "video object has all require keys"
* ! Fix style of prompt from any button within playlist-info component again
z-index war
* * Update some empty message & button text
* * Ensure playlist item action buttons are hidden during animations
* ! Fix other prompt z-index
* * Update `showAddToPlaylistPromptForManyVideos` to throw error when required keys missing from passed in video data
* *- Remove unused video property `paid` from playlist related code
* *- Remove unused video property `type` from playlist related code
* ! Fix duplicate playlist displayed on playlist conversion
* *- Remove unused video property `published` from playlist related code
* * Don't require & generate property `timeAdded` when display a prompt
* *- Remove unused video property `isLive` from playlist related code
* ! Fix text
* ! Revert code change for debugging only
* ! Fix CSS for "Ensure playlist item action buttons are hidden during animations"
* * Update add playlist button to be shown for live videos
* + Add clear all playlists button
* * Update add video to playlist prompt to swap "save" & "create playlist" button
* ! Fix playlist view won't load after default playlist added due to lack of playlist
* * Show toast message when no playlist selected after pressing save button
* * Update add video to playlist prompt to show latest updated playlist first
Easier for copying playlist with new playlist(s)
* ! Fix watch page when visited via history after viewing the video from a deleted user playlist
* ! Fix share buttons emitting user playlist IDs
* * Add toast message after removing all playlists
* ! Fix remote playlist video list rendering with duplicate videos
* ! Fix missing key for some direct child elements under `transition-group`
* ! Fix animation introduced to unnecessary elements
* ! Prevent video link click during animation
* ! Fix playlist creation/removal not reflected in other windows
* * Ensure playlist visual selected state in sync with data in parent
* * Update add video to playlist prompt to auto select playlists created after prompt shown once
* * Update copy playlist button to show warning about not loaded videos when some not loaded yet
For remote playlist
Won't work for Invidious though (coz no way to load more)
* * Update add video prompt to make it easier to access buttons via keyboard
* * Make video reorder & remove button always visible in user playlist view
* * Make plus button can be focused with tab
Side effect is thumbnail link can be focused too (otherwise can't make plus button visible)
* * Update add video to playlist prompt to focus on search input on shown
* * Accept playlist optional property `createdAt` when importing
* * Update playlist view to always show add to playlist button
* $ Refactor `inUserPlaylist`
Only playlist view would supply `playlistType`
* * Improve accessibility for new prompts
* * Make edit playlist inputs focused on entering edit mode
* * Make most prompts focus back to last focused element on close
* $ Use tabindex 0 for prompts
Possible tabindex values unnecessary with elements programatically focused
* * Update add video to playlist prompt to focus back to search input after new playlist created
* * Update ft-list-video to focus back on thumbnail link element after add to playlist prompt closed
* ! Fix unable to import duplicate video entries into an existing playlist
* ! Fix create playlist prompt looks unclosed after playlist created when opened via add video to playlist prompt
* ! Fix duplicate video entry ID when playlist with duplicate videoId entries copied to another playlist
* ! Fix issues caused by last merge in e291cc8b41b2273a0d77c9f35ea760f0e0f7ac10
* $ Remove unused imports
* ! Fix default playlists added when no playlist stored had no required attributes added on 1st run
* ! Fix invalid prop type warning
* * Use v-if instead of v-show
* $ Just assign bool value instead of if-else
* + Update playlists view to add sorting option
* $- Remove unnecessary property assignments
* ! Fix issues caused by "Remove unnecessary property assignments"
* ! Fix issues caused by "Remove unnecessary property assignments"
* * Ensure sort by time also fallbacks to playlist name sorting
* ! Fix add/remove video does not update playlist last created time
* ! Fix multi window playlist sync
* * Show filtering input & sorting element when no. of playlist > 1
* * Update upcoming video to allow saving in playlist
* ! Fix unable to visit previous video when playing first video in a playlist
* * Update sorting options labels
* ! Fix add to play prompt max width
* ! Fix user playlist view incorrectly sorted playlists by latest updated first when filtered
* * Update add to playlist prompt to add sort options
* $ Remove unused classname
* ! Ensure new playlist button focused after add to playlist prompt closed while thumbnail link unselectable
* * Add playlists sort order for last played at, update it on play
* ! Fix bug introduced by last merge
* ! Fix thumbnail not respecting backend preference
* ! Fix empty playlist thumbnail in single playlist view
* * Make adding large no. of videos faster
* $ Remove unused mapActions entries
* $ Remove unused and unusable playlist code for inserting video IDs into a playlist
* * Update single playlist view to only show `Remove watched videos` btn when there is any video
* ! Fix prompt style issue caused by old branch changes
* ! Fix removing video from local playlist remove all entries with same video ID
* ! Fix adding video does not have uniqueID & timeAdded set
Caused by previous add many video performance fix
* ! Fix navigation in user playlist between entries of same video
* * Reflect playlist updates on watch page playlist panel
* $- Remove outdated incorrect prompt style fix
* ! Fix add video to playlist prompt too high when there are too many playlists
* ! Fix watch page play next/prev video in local playlist
* ! Fix error in online playlist playing
* * Keep partial playlist backward compatibility by restoring `type` in persisted playlist videos
* ! Fix grid item for playlist to hide external player button for local playlist
* * Make history rememeber uniqueId (local playlist video entry) when playing video with local playlist
* ! Fix grid item for video in user playlist to hide external player button
* ! Fix grid item for video in history with user playlist to hide external player button
* ! Fix grid item for video in watch page playlist component with user playlist to hide external player button
* * Update watch page to clear `uniqueID` from query when not playing local playlist
* ! Fix watch page about user playlist detection on new window
* * Reflect playlist updates on watch page playlist panel, even for currently playing video
* ! Allow video with local playlist to be played in external player, but without playlist
Also add missing fix for WatchVideoInfo
* ! Fix external player handling for video in local playlist
* ! Fix ft-video having different URLs in links
* yarn run lint-style-fix
* $ Rename uniqueId to playlistItemId
* * Ensure local playlist ID won't conflict with remote playlist ID
* - Remove import video while creating playlist related code
* * Make text translatable
* * Make sort option text translatable
* ! Fix reverse condition
* $ Just use ?.
* Code review changes
* Spaces
* beforeDestroy
* Remove unused methods
* Remove infoData
* filter > find
* avoid importing `crypto` from NodeJS
* Compress CSS ruleset
* $ Remove useless prefix from key
* Use template for element with v-if only
* Make playlist selector look more selectable (cursor: pointer)
* Translate toast messages and fix remove watched videos from playlist
* ! Fix translation
* - Remove unused methods
* $ Remove workaround for issue which cannot be reproduced anymore
* $ Remove remaining useless code following last commit removing workaround
* you have no playlist > you have no playlists
* CSS use var --horizontal-directionality-coefficient
* * Update danger buttons color to primary (like clear search cache button)
* ! Fix playlist icon container size
* ! Fix sorting in add video to playlist prompt when filtered
* $- Update ft-inputs to removed prop input-tabindex
* ! Fix vue warning
* + Add toggle to export playlist for older FT
* * Update tooltip text
* ! Fix vue warning
* * Update text align
* * Remove the extra surrounding spaces
* Backtick > quote
* - Remove useless prop
* Fix tootip in lower width view
* Update default filename
* * Make tooltip auto-wrap
* Revert "* Make tooltip auto-wrap"
This reverts commit 7d932b936c.
* Adjust tooltip styling
* * Wait for local playlist loading only when playing with a user playlist
* * Wait for local playlist loading only when playing with a user playlist requested
Request user playlist can still be absent (but not requested for no playlist or remote playlist)
* ! Fix single playlist view cover image having link when no video
* ! Workaround create playlist prompt won't close when enter pressed in input box
* ! Fix clear text button style
* ! Fix copying playlist twice to the same user playlist produces same playlistItemId
* ! Fix add video to playlist prompt input box style
* ! Fix workaround for "create playlist prompt won't close when enter pressed in input box"
* ! Ensure add video to playlist prompt updated when a playlist deleted (in another window)
* ! Avoid saving and displaying unwanted video attributes into playlists
* ! Fix playlist view for deleted user playlists
* ! Fix copying playlist twice to the same user playlist produces same playlistItemId
Real fix
Cause of issue: updating property of input objects (which is shared across multiple run)
* ! Fix search suggestions being blocked by playlist info component in single playlist view
* ! Fix warning when reversing playlist in watch view
* ! Fix prompt in playlist view (playlistinfo component) not above sidebar
* Remove CSS top comments absent in other CSS files
* Remove not useful comment for CSS
* Float with variable
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
* Revert "! Fix clear text button style"
This reverts commit 44ed286848.
* Missing change for Revert "! Fix clear text button style"
* $ Remove unused style for ft-playlist-selector
* Apply changes from review
* * Use $tc for translation entries with different value according to count values
* ! Fix playlist link in watch view
---------
Co-authored-by: Jason Henriquez <jasonhenriquez@protonmail.com>
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
* Fix style for the Select component
Fixes#1804
Fixes the width of dropdowns and changes their style a little bit
* Fix lint
* Fix comments partially obscuring the sort dropdown
* Move select tooltip
* Add back 'Turn on Subtitles by Default'
* Update variable name
* Fix double-selection issue when auto-generated & native tracks exist, & fix similar pre-existing bug
Also fixes pre-existing bug with pressing 'c' having the effect of multiple tracks (inaccurately) showing as selected.
* Search input keyboard focus enhancements
Select text in search input when using Ctrl-L/Meta-L or Alt-D to focus
search input
Add new Slash key shortcut to focus input without selecting text
* Fix search input focus interfering with KDE clipboard sync
* Remove Slash shortcut for focusing search input
* Remove unused function
* Add subscribe button to channel search result
* Fix description logic not accounting for forceListType
* Fix video list item width issues on smaller viewport widths (esp. when in List mode)
* Expand link area for hashtag and channel list items
* Equalize thumbnail width of different element types (channel, playlist, hashtag, video) in list view
* Fix ft-list-playlist not actually respecting imposed appearance prop
* Add pointer-events: none to # of videos in playlist bar
* Adjust channel click area to be full width in grid view
* Adjust list item sizing for mobile devices
* Implement least-changes fix to subscribe button wrap, & fix channel icon resizing on smaller device sizes
* Update Edit Profile styling, labels, and order
* Introduce additional styling updates
* Remove check for channel name of All Channels, as that can be faulty for users who renamed it & had another profile take the name
* Force use of All Channels profile translation (& forbid alteration of All Channels profile name
* Combine ProfileSettings and ProfileEdit routes under one route
* Implement active settings profile styling & profileList watcher
* Fix pre-existing bug of selected channels & count in Other Channels not updating when changing the profile filter
* Fix pre-existing behavior of filter profile selection resetting after each use
* Fix pre-existing bug with Edit Profile Subscription List of count bugging after adding new channel mid-count
And vice versa with removing channel mid-count on Other Channels.
* Fix two toasts to use localized profile name, & remove unnecessary mounted
* Remove old modification of base ft-input styling
* Implement styling for new subscribe button
* Implement dropdown element and styling
* Implements remaining styling and logic
* Correct use of aria-selected in FT
Note: was able to add aria-controls to ft-profile-selector because it keeps the hidden dropdown in the DOM. The same is not true of the ft-icon-button or ft-subscribe-button. Main point: aria-expanded should go on the button opening the dropdown, not the dropdown itself.
* Resolve subscribe button staying upon bug
* Remove unneeded vendor-specific transition prefixes
See discussion here: https://www.web-plus-plus.com/Articles/css-transition-moz-and-webkit-vs-css3
* Display currently watching viewer count on live streams
* Improve watching count styling
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
---------
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
* Add hide channel option directly to More Options menu
* Added ability to unhide channels as well from the same menu
* Fix issue where unhide would not work with channelId
* Replace filter with some
* Remove extra hide channel
* Hide by channelId rather than name
* Shuffle lang terms to put channel name at the front
* Do not check channel name anymore
* One more spot
* Fixed lang terms
* Implement customizable landing pages
* Implement curated list for default landing page dropdown options
* Update top nav link to redirect back to selected landing page
* Update top nav title to be 'Go to {page}' for improved clarity
* Remove landing page from selection and/or restore selection to default if is no longer valid
* add description option to hiding channels
* does channel id search
* add tag tooltip
* legacy support for hidden channels
* update removeTag
* add parenthesis to id name
* add icon and id checking before requesting
* update id regex
* decouple channel hidden from tags
* update handling for legacy hidden channels
* remove tag description
* formatting
* newline
* shorten retrieving hidden channels
* separate channel api requests
* refractor ft-input-tags.js
* replace secondaryName with preferredName for tags
* unify hidden channel name/icon retrieval function
* remove tooltip from ft-input-tags
* auto update hidden channel if ID was used
* remove hiding channel by name
* i18n channels hidden disabled message
* run auto hidden channel id update once
* Update src/renderer/components/ft-input-tags/ft-input-tags.vue
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
* add text selection for ft tags
* add ft-input-tags icon url
* fix icon link
---------
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
* Localize proxy test info when possible
* Use a second find in-case a locale with the same language is added in the future
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
* Fix syntax error
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
---------
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* Chore: move stylelint-use-logical-spec to devDependencies
* Update blur to be a thumbnail preference instead of its own ft-toggle-switch
* Update en-US.yaml
* Add a 15 second timeout for fetching the Invidious instances at startup
* Use a better name for the timeout parameter
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* Fix docs
---------
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* * Update FT history import to accept key `lastViewedPlaylistId`
Also update the strange required key check logic
Which was last changed by 58882b3e16
* * Remove unused video property `paid`
* Implement fix to elements escaping container on Channel page at small widths
* Show all Channel tabs on smaller viewport widths & reduce bulky gap
* Update Channel page to not break at even lower sizes
* Re-introduce channel button clipping fix
* Implement updated share button styling
* Fix issue with prompt box shrinking on small enough viewport sizes / overflow
* Update share button to work at all sizes'
* Fix pre-existing issue of Channel tabs overflowing on desktop view in some locales
* Support multiple audio tracks and AV1 for Invidious by using the local API DASH manifest generator
* Upgrade YouTube.js to 6.2.0 to fix default track selection
* Fix audio formats
* Use Intl.DisplayNames to get the language names
* Simplify returns
Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>
---------
Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>
* Add subscription community tab
* fix up community tab
* simplify if statement
* use global.community for all references to community
* dont show community when useRss is set
* check visibleTabs for showing the community tab
* fix caching, decrease datalimit for community, add missing translations
* L: Hide shared posts, IV: Don't show errors for empty community tab
* add links to related issues
* Fix buttons intersecting on Subscribed Channels tab in many languages
Note that this can still occur if one of the words in 'Unsubscribe' is pretty big on smaller screen sizes, e.g., Svenska at 515px. This is because we allow the Unsubscribe button to be wider than the element itself, which is hard to change here without completely reworking the structure using (due to limitations with minmax being unable to have fit-content in a grid definition).
* Update src/renderer/components/ft-subscribe-button/ft-subscribe-button.css
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
---------
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* Fix comment author focus outline being broken
* Wrap overflowing text
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
---------
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
* Add Stylelint plugin and rule for evaluating use of logical properties
* Implement stylelint-advised use of logical properties in SCSS files
* Implement stylelint-advised use of logical properties in CSS files
* Implement stylelint linting before each commit to any branch of the repo
* Remove other Stylelint plugins so that we can add them in later one-by-one
After discussing this with the FreeTube team, it seems that we are still undecided on which rules we want to be active, including ones currently enabled. As a stopgap fix, we disabled Stylelint checking in our pre-commit Git hook and our recommended
> freetube@0.19.0 lint-fix
> run-p eslint-fix lint-style-fix command. With this change, we will be using Stylelint in our
> freetube@0.19.0 lint-fix
> run-p eslint-fix lint-style-fix command, while giving us the flexibility to add in additional desired plugins and rules as separate efforts.
* Add video player to .stylelintignore
* Replace non-logical property usage in templates
This is not enforced by the plugin at this time.
* Remove use of logical properties from ft-video-player, & allow empty input when .stylelintignore files are changed
* Update ft-video-player.css to disable use of logical property linter
We want to avoid introducing directionality-specific properties that could muck up the video player.
* Remove redundant/unnecessary scripts in package.json
* Add hashtags to search results
* add global count , implement changes from code review
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
* use h3 for title of hashtag element
* implement suggestions from code review
* use hashtag.text, move url update logic
* encodeURI for hashtag url
---------
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Replace margin-left with margin-inline-start
* Replace margin-right with margin-inline-end
* Replace padding-left with padding-inline-start
* Replace padding-right with padding-inline-end
* Replace padding-top & padding-bottom with padding-block; continue replacing padding-left and padding-right with padding-inline-start and padding-inline-end
* Add updated rtl-compatible margins to ft-slider and fix indentation
* Replace margin-top & margin-bottom with margin-block; continue replacing margin-left and margin-right with margin-inline-start and margin-inline-end
* Continue replacing with margin-block and margin-inline
* Replace left and right with inset-inline-start and inset-inline-end
This commit also changes border-left to border-inline-start, and border-right to border-inline-end.
* Replace margin-bottom, top, and bottom with margin-block-end, inset-block-start, and inset-block-end
This commit also replaces border-top and border-bottom with border-block-start and border-block-end.
* Replace text-align left and right with text-align start and end
* Fix syntax error with inset-block-end
* Implement dynamic float: left/right based on direction ltr/rtl
* Implement dynamic navigation arrow placement based on direction ltr/rtl
To the fullest of my understanding, it is expected for the left navigation in rtl-supporting browsers to be for forward navigation, and the right one to be for backward navigation.
* Add direction to body based on preferred language
* Implement horizontal directionality coefficient to fix translate working in wrong x-direction for rtl languages
* Add explicit text-align: start in places to ensure rtl version is correctly aligned
* Add text-align: start to places where it is not inferred to enable proper rtl text orientation
* Fix search bar magnifying glass being too far right issue
* Move body.dir-setting logic to setLocale to fix dir not setting correctly on page reload
* Change .switchColumn to have align-items: start instead of justify-items: start
I have validated this for all settings tabs; the justify-content: start did nothing in any language, left-to-right or right-to-left. Replacing it with align-items: start aligned all menu switch items by their switches, not by their labels. This makes for a much more uniform settings section for trl languages.
* Fix emergent bug in which history icons are temporarily disabled on changing language to one with different directionality
Given that which icon is displayed for which history arrow is now dynamic based on the user's directionality, changing of the icon resets the font-awesome-icon state and thus re-adds the base disabled class to both arrows. This means that changing your language to one that has a different directionality was falsely setting the arrows to their disabled state (until the route is changed, after which the history icons will be fully back to normal). This commmit refactors the history icon setting logic to use class binding to two booleans in the top-nav component's data rather than adding and removing the disabled classes directly to the arrow elements' classLists, thus cleaning up the implementation and fixing the bug.
* Add Kurdish to rtl languages list & add li items to be right-aligned on rtl languages
* Force FreeTube logo to be ordered left-to-right for 'brand consistency'
* Add styling flipping font-awesome icons for rtl languages except for exclusion list
* Update isRightAligned with additional languages, and use it instead of locale value from store
Kudos to absidue for pointing out this existing function for representing this, and that it grabs directly from the i18n object. This means that FreeTube will display the proper rtl interface if one is the user's system language, where it did not before.
* Update isRightAligned property name to more clearly reflect rtl purpose
* Simplify left/right arrow display logic
Leverage the icons being flipped rather than manually setting the classes to their opposites when the directionality is RTL.
* Replace justify-self: left & justify-self: right with justify-self; start and justify-self: end
* Remove misguided attempt to emulate directionality-agnosticism with rightAligned class
* Explicitly center FreeTube version on About page
* Replace pre-existing identation issue
* Replace margin-left with margin-inline-start
* Replace margin-right with margin-inline-end
* Replace padding-left with padding-inline-start
* Replace padding-right with padding-inline-end
* Replace padding-top & padding-bottom with padding-block; continue replacing padding-left and padding-right with padding-inline-start and padding-inline-end
* Add updated rtl-compatible margins to ft-slider and fix indentation
* Replace margin-top & margin-bottom with margin-block; continue replacing margin-left and margin-right with margin-inline-start and margin-inline-end
* Continue replacing with margin-block and margin-inline
* Replace left and right with inset-inline-start and inset-inline-end
This commit also changes border-left to border-inline-start, and border-right to border-inline-end.
* Replace margin-bottom, top, and bottom with margin-block-end, inset-block-start, and inset-block-end
This commit also replaces border-top and border-bottom with border-block-start and border-block-end.
* Replace text-align left and right with text-align start and end
* Fix syntax error with inset-block-end
* Implement dynamic float: left/right based on direction ltr/rtl
* Implement dynamic navigation arrow placement based on direction ltr/rtl
To the fullest of my understanding, it is expected for the left navigation in rtl-supporting browsers to be for forward navigation, and the right one to be for backward navigation.
* Add direction to body based on preferred language
* Implement horizontal directionality coefficient to fix translate working in wrong x-direction for rtl languages
* Add explicit text-align: start in places to ensure rtl version is correctly aligned
* Add text-align: start to places where it is not inferred to enable proper rtl text orientation
* Fix search bar magnifying glass being too far right issue
* Move body.dir-setting logic to setLocale to fix dir not setting correctly on page reload
* Change .switchColumn to have align-items: start instead of justify-items: start
I have validated this for all settings tabs; the justify-content: start did nothing in any language, left-to-right or right-to-left. Replacing it with align-items: start aligned all menu switch items by their switches, not by their labels. This makes for a much more uniform settings section for trl languages.
* Fix emergent bug in which history icons are temporarily disabled on changing language to one with different directionality
Given that which icon is displayed for which history arrow is now dynamic based on the user's directionality, changing of the icon resets the font-awesome-icon state and thus re-adds the base disabled class to both arrows. This means that changing your language to one that has a different directionality was falsely setting the arrows to their disabled state (until the route is changed, after which the history icons will be fully back to normal). This commmit refactors the history icon setting logic to use class binding to two booleans in the top-nav component's data rather than adding and removing the disabled classes directly to the arrow elements' classLists, thus cleaning up the implementation and fixing the bug.
* Add Kurdish to rtl languages list & add li items to be right-aligned on rtl languages
* Force FreeTube logo to be ordered left-to-right for 'brand consistency'
* Add styling flipping font-awesome icons for rtl languages except for exclusion list
* Update isRightAligned with additional languages, and use it instead of locale value from store
Kudos to absidue for pointing out this existing function for representing this, and that it grabs directly from the i18n object. This means that FreeTube will display the proper rtl interface if one is the user's system language, where it did not before.
* Update isRightAligned property name to more clearly reflect rtl purpose
* Simplify left/right arrow display logic
Leverage the icons being flipped rather than manually setting the classes to their opposites when the directionality is RTL.
* Replace justify-self: left & justify-self: right with justify-self; start and justify-self: end
* Remove misguided attempt to emulate directionality-agnosticism with rightAligned class
* Explicitly center FreeTube version on About page
* Fix question mark reversing logic for Arabic, Hebrew, Persian, and Urdu
* Fix minor indentation issue
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Remove unused function
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Update src/renderer/components/ft-slider/ft-slider.css
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
---------
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* Revert "! Fix watch page layout when theatre mode enabled and sidebar "hidden" (#3931)"
This reverts commit 621cc27938.
* Fix the watch page layout when the sidebar is hidden and theatre mode mode is enabled by default
* Do not use theatre mode while loading
* Add pastel and hot pink base configuration & labels
* Update Author Background Color to be based on --secondary-card-bg-color instead of --scrollbar-color
This unneeded dependency on the scrollbar color here resulted in the Author Background text blending into its background on the new Hot Pink theme. This change does not tangibly affect any other theme, whose scrollbar colors are incidentally similar to the secondary-card-bg-color, as this color is already being used for tags on the Channel About tab.
* Implement Pastel Pink and Hot Pink styling
Note that Hot Pink styling overwrites the primary and secondary color themes to maintain accessible color contrasts throughout FreeTube. It also updates the underline styling to match its aesthetic. The scrollbar-text-color-hover and side-nav-active-text-color colors are added for allow for the text and icon to both change on hover. This allows for more accessible hover and active styling.
* Add textWhiteSmall and iconWhiteSmall to repo; add FT pink icon themes
The textWhiteSmall was actually already sized exactly the same as the other small text files, so I just changed the name to reflect that fact.
* Add side-nav-hover-text-color and side-nav-active-text-color throughout FT
* Update Hot Pink theme accent-color-active
* Add side-nav hover-text and active-text styling to ft-icon-button
* Fix incorrect variable name
* Disable primary & secondary color theme controls when hot pink theme is enabled
* Added hide comment photos option into settings
* Hide comment photos if setting is enabled
* include hidden photos for comment replies
* Always show video uploader photo in comments
* reverted en_GB changes
* Updated settings to "Hide Profile Pictures in Comments"
* This is due to my previous change which included the use of a poorly researched 'user-select: all' to unset a 'user-select'. The problem is that all does something else altogether: 'The content of the element shall be selected atomically: If a selection would contain part of the element, then the selection must contain the entire element including all its descendants. If a double-click or context-click occurred in sub-elements, the highest ancestor with this value will be selected.' Source: https://developer.mozilla.org/en-US/docs/Web/CSS/user-select
* Add user-select:none to one more area
* Remove extraneous additional dash
Co-authored-by: LQ2' <lq2.apostrophe@gmail.com>
---------
Co-authored-by: LQ2' <lq2.apostrophe@gmail.com>
* Implement external player icon and favorites icon only appearing after hover/focus
As a way of cleaning up the look of videos, only shows the video icons on hover or focus. This is for all purposes a very 'free' change that I would opine makes FreeTube appear much cleaner.
* Implement video list settings button only appearing on hover/focus
Same idea as for the favorites & external player icons; much cleaner look without any sizable 'cost' to boot.
* Ensure video list buttons always show on devices without hover (e.g., mobile)
* Remove user-select lines (already in another PR) & one extraneous line
* Make settings heading text unselectable
I often encounter the issue of accidentally selecting/highlighting the settings heading text, which ends up highlighting all of the text inside of that settings tab. This is an unpleasant appearance that I have to click to remove. This change removes this issue altogether.
* Switch all instances of user-select to be only user-select and -webkit-user-select
* Make side-nav labels unselectable
* Make side-nav and channels un-draggable
* Remove selection from ft-flex-box, ft-input placeholders, and profile icons
* CSS updates
* Include resolution to 'auto' in quality display
* Include auto info in video statistics
* Value integrity check in CreateDashQualitySelector
* Refactoring to community polls & fixes for quizzes
* Replaced the interactive quiz with a reveal button and small fixes
* Replaced the interactive quiz with a reveal button and small fixes
* Implemented vote formatting
* vote translation fix
* Accessibility additions
* Fixed local API is_correct typo
* Fixed inconsistent indents
* Add semantic roles to make the site more accessible
Co-Authored-By: Jason <84899178+jasonhenriquez@users.noreply.github.com>
* Apply suggestions from code review
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
---------
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* ! Fix outdated subscription cache clearing code when "Remove All Subscriptions / Profiles" performed
* * Use one action to clear cache instead of three
* $ Use early return
* Add basic support for mpc-hc/be, sort list
* Add startOffset handling for mpc-hc family
* Add basic PotPlayer support
* Fix indentations
* Undo entry sorting
* Add Tabs to subscriptions page for live streams and shorts
* Fix naming issue with fetching live streams via Invidious RSS
* Remove console log
* Better error handling and better live stream sorting
* Fix linter issues
* Change videos RSS feed. Make live stream call more efficient.
* Store last used tab in memory. Return to last used tab on mount
* Fix live sorting. Reorganize tabs and check for currentTab via created instead of mounted
* Fix linting issue
* Start Global locales object, add distraction free checks for subscriptions tab
* Start Global locales object for all locales
* Cleanup and reduce duplicate code
* Undo original distraction free settings change
* Fix missing change in previous commit
* Add distraction free settings to hide tabs
* Improve accessibility
* Make app-wide hide live streams setting override hide subscriptions live
* Fix incorrect all tabs disabled message
* Fix arrow key navigation
* Create shared UI component for the subscription tabs
---------
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Update external-player-map.json: Add basic support for external SMPlayer
Adds basic functionality to open videos in SMPlayer.
Adding more parameters (e.g., startOffset or speed) is not possible at this time as SMPlayer expects different formatting compared to what FreeTube currently passes through.
* Update utils.js: Add special startOffset handling for SMPlayer
* Update external-player-map.json: Add startOffset for SMPlayer
* Update utils.js: Truncate startOffset for SMPlayer
If watchProgress contains a non-integer value, SMPlayer will simply parse it as 0. Thus, truncate it before passing it along.
* Update utils.js: startOffset comments
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
---------
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* Wrap long one word channel names in `infoLine`
* Set height of playlist section to auto on small devices to prevent overflow
* Center videoThumbnail in playlist sidebar to visually be the same as playlist view
* Move CSS changes closer together
* * Update channel view to opt out of "Hide Videos From Channels"
* * Update history, local playlist & subscription view to opt out of "Hide Videos From Channels"
* * Update recommended video section to use hide videos from channel preference
* * Update setting tooltip text
* Update `or` to `and`
* * Update most popular view to use hide videos from channel preference
* fix for invidious (+6 squashed commits)
Squashed commits:
[65932b4b4] update playlist and channel filtering
[952a7213a] update subscriptions js to use premiereDate over durationText
[530dea939] Add back isRSS and viewcount check to fix when in subscriptions page
[93ebb7654] Fix hide premiere
[de7a8b4ec] ft-list-lazy-wrapper put whitespace back to what it was
[8dadb59b1] move showResult from a method to a computed to work with v-if
* Fix Hide Premier for Invidous API
* Refactor code to be more redable with better doc
---------
Co-authored-by: petaded <code@zikl.co.uk>
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
Providing these type of links is currently unnecessary
and can turn into a hassle when the players are extended by scripts
that are not expecting them and don't function as intended.
* Only use android formats when the video id in the response is correct
* Fix typo in playability status check
Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>
---------
Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>
* Changes from PR #3673
* * Update subscription view to be able to load videos from video cache again
* * Update subscription view to be able to load videos from video cache per channel
* * Remove meaningless argument `allowUseOfChannelCache`
* $ Remove unused imports
---------
Co-authored-by: petaded <code@zikl.co.uk>
* Use playlist thumbnail provided by YT from Local API
* Use correct thumbnails for playlist page
* Fix playlistThumbnail not giving correct value
* Update youtubei.js
* Update package.json
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* Update yarn.lock to align with package.json
---------
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* Fix Hide Channel Subscribers setting still displaying subscribers if changed from a secondary window (#3504)
* Revert naming change subscriptionCountText to channelSubCountText
* Use `!=` instead of `!==` for `subscriberCount` in ft-list-channel
* Set subscriberCount to null if `data.subscribers` is null in ft-list-channel.js
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
---------
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Fix `proxyVideos` setting for legacy formats & hls urls
- Replace the hostname of stream urls with the current invidious instance when `proxyVideos` is true
- Add `local` flag to iv hls URLs when proxy videos is true
* Add missing `proxyVideos` getter in `ft-video-player`
* Move change of URI to before `getProxyVideos`
JonahFoster
Jason
absidue
PikachuEXE
ChunkyProgrammer
dependabot[bot]
trostboot
pkrasicki
efb4f5ff-1298-471a-8973-3d47447115dc
Simon Epstein
Shroomy
Mitchel Paulin
CelularBat
Benjababe
Ajay Ramachandran
Anima
Wesley Appler
Benjababe
Emma
MaxMaxMaxCh
David Frederick Batt
Vinit Jha
PrestonN
Svallinn
petaded
Jaden
RikThePixel