* Support multiple audio tracks and AV1 for Invidious by using the local API DASH manifest generator
* Upgrade YouTube.js to 6.2.0 to fix default track selection
* Fix audio formats
* Use Intl.DisplayNames to get the language names
* Simplify returns
Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>
---------
Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>
* Add subscription community tab
* fix up community tab
* simplify if statement
* use global.community for all references to community
* dont show community when useRss is set
* check visibleTabs for showing the community tab
* fix caching, decrease datalimit for community, add missing translations
* L: Hide shared posts, IV: Don't show errors for empty community tab
* add links to related issues
* Fix buttons intersecting on Subscribed Channels tab in many languages
Note that this can still occur if one of the words in 'Unsubscribe' is pretty big on smaller screen sizes, e.g., Svenska at 515px. This is because we allow the Unsubscribe button to be wider than the element itself, which is hard to change here without completely reworking the structure using (due to limitations with minmax being unable to have fit-content in a grid definition).
* Update src/renderer/components/ft-subscribe-button/ft-subscribe-button.css
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
---------
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* Fix comment author focus outline being broken
* Wrap overflowing text
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
---------
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
* Add Stylelint plugin and rule for evaluating use of logical properties
* Implement stylelint-advised use of logical properties in SCSS files
* Implement stylelint-advised use of logical properties in CSS files
* Implement stylelint linting before each commit to any branch of the repo
* Remove other Stylelint plugins so that we can add them in later one-by-one
After discussing this with the FreeTube team, it seems that we are still undecided on which rules we want to be active, including ones currently enabled. As a stopgap fix, we disabled Stylelint checking in our pre-commit Git hook and our recommended
> freetube@0.19.0 lint-fix
> run-p eslint-fix lint-style-fix command. With this change, we will be using Stylelint in our
> freetube@0.19.0 lint-fix
> run-p eslint-fix lint-style-fix command, while giving us the flexibility to add in additional desired plugins and rules as separate efforts.
* Add video player to .stylelintignore
* Replace non-logical property usage in templates
This is not enforced by the plugin at this time.
* Remove use of logical properties from ft-video-player, & allow empty input when .stylelintignore files are changed
* Update ft-video-player.css to disable use of logical property linter
We want to avoid introducing directionality-specific properties that could muck up the video player.
* Remove redundant/unnecessary scripts in package.json
* Add hashtags to search results
* add global count , implement changes from code review
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
* use h3 for title of hashtag element
* implement suggestions from code review
* use hashtag.text, move url update logic
* encodeURI for hashtag url
---------
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Replace margin-left with margin-inline-start
* Replace margin-right with margin-inline-end
* Replace padding-left with padding-inline-start
* Replace padding-right with padding-inline-end
* Replace padding-top & padding-bottom with padding-block; continue replacing padding-left and padding-right with padding-inline-start and padding-inline-end
* Add updated rtl-compatible margins to ft-slider and fix indentation
* Replace margin-top & margin-bottom with margin-block; continue replacing margin-left and margin-right with margin-inline-start and margin-inline-end
* Continue replacing with margin-block and margin-inline
* Replace left and right with inset-inline-start and inset-inline-end
This commit also changes border-left to border-inline-start, and border-right to border-inline-end.
* Replace margin-bottom, top, and bottom with margin-block-end, inset-block-start, and inset-block-end
This commit also replaces border-top and border-bottom with border-block-start and border-block-end.
* Replace text-align left and right with text-align start and end
* Fix syntax error with inset-block-end
* Implement dynamic float: left/right based on direction ltr/rtl
* Implement dynamic navigation arrow placement based on direction ltr/rtl
To the fullest of my understanding, it is expected for the left navigation in rtl-supporting browsers to be for forward navigation, and the right one to be for backward navigation.
* Add direction to body based on preferred language
* Implement horizontal directionality coefficient to fix translate working in wrong x-direction for rtl languages
* Add explicit text-align: start in places to ensure rtl version is correctly aligned
* Add text-align: start to places where it is not inferred to enable proper rtl text orientation
* Fix search bar magnifying glass being too far right issue
* Move body.dir-setting logic to setLocale to fix dir not setting correctly on page reload
* Change .switchColumn to have align-items: start instead of justify-items: start
I have validated this for all settings tabs; the justify-content: start did nothing in any language, left-to-right or right-to-left. Replacing it with align-items: start aligned all menu switch items by their switches, not by their labels. This makes for a much more uniform settings section for trl languages.
* Fix emergent bug in which history icons are temporarily disabled on changing language to one with different directionality
Given that which icon is displayed for which history arrow is now dynamic based on the user's directionality, changing of the icon resets the font-awesome-icon state and thus re-adds the base disabled class to both arrows. This means that changing your language to one that has a different directionality was falsely setting the arrows to their disabled state (until the route is changed, after which the history icons will be fully back to normal). This commmit refactors the history icon setting logic to use class binding to two booleans in the top-nav component's data rather than adding and removing the disabled classes directly to the arrow elements' classLists, thus cleaning up the implementation and fixing the bug.
* Add Kurdish to rtl languages list & add li items to be right-aligned on rtl languages
* Force FreeTube logo to be ordered left-to-right for 'brand consistency'
* Add styling flipping font-awesome icons for rtl languages except for exclusion list
* Update isRightAligned with additional languages, and use it instead of locale value from store
Kudos to absidue for pointing out this existing function for representing this, and that it grabs directly from the i18n object. This means that FreeTube will display the proper rtl interface if one is the user's system language, where it did not before.
* Update isRightAligned property name to more clearly reflect rtl purpose
* Simplify left/right arrow display logic
Leverage the icons being flipped rather than manually setting the classes to their opposites when the directionality is RTL.
* Replace justify-self: left & justify-self: right with justify-self; start and justify-self: end
* Remove misguided attempt to emulate directionality-agnosticism with rightAligned class
* Explicitly center FreeTube version on About page
* Replace pre-existing identation issue
* Replace margin-left with margin-inline-start
* Replace margin-right with margin-inline-end
* Replace padding-left with padding-inline-start
* Replace padding-right with padding-inline-end
* Replace padding-top & padding-bottom with padding-block; continue replacing padding-left and padding-right with padding-inline-start and padding-inline-end
* Add updated rtl-compatible margins to ft-slider and fix indentation
* Replace margin-top & margin-bottom with margin-block; continue replacing margin-left and margin-right with margin-inline-start and margin-inline-end
* Continue replacing with margin-block and margin-inline
* Replace left and right with inset-inline-start and inset-inline-end
This commit also changes border-left to border-inline-start, and border-right to border-inline-end.
* Replace margin-bottom, top, and bottom with margin-block-end, inset-block-start, and inset-block-end
This commit also replaces border-top and border-bottom with border-block-start and border-block-end.
* Replace text-align left and right with text-align start and end
* Fix syntax error with inset-block-end
* Implement dynamic float: left/right based on direction ltr/rtl
* Implement dynamic navigation arrow placement based on direction ltr/rtl
To the fullest of my understanding, it is expected for the left navigation in rtl-supporting browsers to be for forward navigation, and the right one to be for backward navigation.
* Add direction to body based on preferred language
* Implement horizontal directionality coefficient to fix translate working in wrong x-direction for rtl languages
* Add explicit text-align: start in places to ensure rtl version is correctly aligned
* Add text-align: start to places where it is not inferred to enable proper rtl text orientation
* Fix search bar magnifying glass being too far right issue
* Move body.dir-setting logic to setLocale to fix dir not setting correctly on page reload
* Change .switchColumn to have align-items: start instead of justify-items: start
I have validated this for all settings tabs; the justify-content: start did nothing in any language, left-to-right or right-to-left. Replacing it with align-items: start aligned all menu switch items by their switches, not by their labels. This makes for a much more uniform settings section for trl languages.
* Fix emergent bug in which history icons are temporarily disabled on changing language to one with different directionality
Given that which icon is displayed for which history arrow is now dynamic based on the user's directionality, changing of the icon resets the font-awesome-icon state and thus re-adds the base disabled class to both arrows. This means that changing your language to one that has a different directionality was falsely setting the arrows to their disabled state (until the route is changed, after which the history icons will be fully back to normal). This commmit refactors the history icon setting logic to use class binding to two booleans in the top-nav component's data rather than adding and removing the disabled classes directly to the arrow elements' classLists, thus cleaning up the implementation and fixing the bug.
* Add Kurdish to rtl languages list & add li items to be right-aligned on rtl languages
* Force FreeTube logo to be ordered left-to-right for 'brand consistency'
* Add styling flipping font-awesome icons for rtl languages except for exclusion list
* Update isRightAligned with additional languages, and use it instead of locale value from store
Kudos to absidue for pointing out this existing function for representing this, and that it grabs directly from the i18n object. This means that FreeTube will display the proper rtl interface if one is the user's system language, where it did not before.
* Update isRightAligned property name to more clearly reflect rtl purpose
* Simplify left/right arrow display logic
Leverage the icons being flipped rather than manually setting the classes to their opposites when the directionality is RTL.
* Replace justify-self: left & justify-self: right with justify-self; start and justify-self: end
* Remove misguided attempt to emulate directionality-agnosticism with rightAligned class
* Explicitly center FreeTube version on About page
* Fix question mark reversing logic for Arabic, Hebrew, Persian, and Urdu
* Fix minor indentation issue
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Remove unused function
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Update src/renderer/components/ft-slider/ft-slider.css
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
---------
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* Revert "! Fix watch page layout when theatre mode enabled and sidebar "hidden" (#3931)"
This reverts commit 621cc27938.
* Fix the watch page layout when the sidebar is hidden and theatre mode mode is enabled by default
* Do not use theatre mode while loading
* Add pastel and hot pink base configuration & labels
* Update Author Background Color to be based on --secondary-card-bg-color instead of --scrollbar-color
This unneeded dependency on the scrollbar color here resulted in the Author Background text blending into its background on the new Hot Pink theme. This change does not tangibly affect any other theme, whose scrollbar colors are incidentally similar to the secondary-card-bg-color, as this color is already being used for tags on the Channel About tab.
* Implement Pastel Pink and Hot Pink styling
Note that Hot Pink styling overwrites the primary and secondary color themes to maintain accessible color contrasts throughout FreeTube. It also updates the underline styling to match its aesthetic. The scrollbar-text-color-hover and side-nav-active-text-color colors are added for allow for the text and icon to both change on hover. This allows for more accessible hover and active styling.
* Add textWhiteSmall and iconWhiteSmall to repo; add FT pink icon themes
The textWhiteSmall was actually already sized exactly the same as the other small text files, so I just changed the name to reflect that fact.
* Add side-nav-hover-text-color and side-nav-active-text-color throughout FT
* Update Hot Pink theme accent-color-active
* Add side-nav hover-text and active-text styling to ft-icon-button
* Fix incorrect variable name
* Disable primary & secondary color theme controls when hot pink theme is enabled
* Added hide comment photos option into settings
* Hide comment photos if setting is enabled
* include hidden photos for comment replies
* Always show video uploader photo in comments
* reverted en_GB changes
* Updated settings to "Hide Profile Pictures in Comments"
* This is due to my previous change which included the use of a poorly researched 'user-select: all' to unset a 'user-select'. The problem is that all does something else altogether: 'The content of the element shall be selected atomically: If a selection would contain part of the element, then the selection must contain the entire element including all its descendants. If a double-click or context-click occurred in sub-elements, the highest ancestor with this value will be selected.' Source: https://developer.mozilla.org/en-US/docs/Web/CSS/user-select
* Add user-select:none to one more area
* Remove extraneous additional dash
Co-authored-by: LQ2' <lq2.apostrophe@gmail.com>
---------
Co-authored-by: LQ2' <lq2.apostrophe@gmail.com>
* Implement external player icon and favorites icon only appearing after hover/focus
As a way of cleaning up the look of videos, only shows the video icons on hover or focus. This is for all purposes a very 'free' change that I would opine makes FreeTube appear much cleaner.
* Implement video list settings button only appearing on hover/focus
Same idea as for the favorites & external player icons; much cleaner look without any sizable 'cost' to boot.
* Ensure video list buttons always show on devices without hover (e.g., mobile)
* Remove user-select lines (already in another PR) & one extraneous line
* Make settings heading text unselectable
I often encounter the issue of accidentally selecting/highlighting the settings heading text, which ends up highlighting all of the text inside of that settings tab. This is an unpleasant appearance that I have to click to remove. This change removes this issue altogether.
* Switch all instances of user-select to be only user-select and -webkit-user-select
* Make side-nav labels unselectable
* Make side-nav and channels un-draggable
* Remove selection from ft-flex-box, ft-input placeholders, and profile icons
* CSS updates
* Include resolution to 'auto' in quality display
* Include auto info in video statistics
* Value integrity check in CreateDashQualitySelector
* Refactoring to community polls & fixes for quizzes
* Replaced the interactive quiz with a reveal button and small fixes
* Replaced the interactive quiz with a reveal button and small fixes
* Implemented vote formatting
* vote translation fix
* Accessibility additions
* Fixed local API is_correct typo
* Fixed inconsistent indents
* Add semantic roles to make the site more accessible
Co-Authored-By: Jason <84899178+jasonhenriquez@users.noreply.github.com>
* Apply suggestions from code review
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
---------
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* ! Fix outdated subscription cache clearing code when "Remove All Subscriptions / Profiles" performed
* * Use one action to clear cache instead of three
* $ Use early return
* Add basic support for mpc-hc/be, sort list
* Add startOffset handling for mpc-hc family
* Add basic PotPlayer support
* Fix indentations
* Undo entry sorting
* Add Tabs to subscriptions page for live streams and shorts
* Fix naming issue with fetching live streams via Invidious RSS
* Remove console log
* Better error handling and better live stream sorting
* Fix linter issues
* Change videos RSS feed. Make live stream call more efficient.
* Store last used tab in memory. Return to last used tab on mount
* Fix live sorting. Reorganize tabs and check for currentTab via created instead of mounted
* Fix linting issue
* Start Global locales object, add distraction free checks for subscriptions tab
* Start Global locales object for all locales
* Cleanup and reduce duplicate code
* Undo original distraction free settings change
* Fix missing change in previous commit
* Add distraction free settings to hide tabs
* Improve accessibility
* Make app-wide hide live streams setting override hide subscriptions live
* Fix incorrect all tabs disabled message
* Fix arrow key navigation
* Create shared UI component for the subscription tabs
---------
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Update external-player-map.json: Add basic support for external SMPlayer
Adds basic functionality to open videos in SMPlayer.
Adding more parameters (e.g., startOffset or speed) is not possible at this time as SMPlayer expects different formatting compared to what FreeTube currently passes through.
* Update utils.js: Add special startOffset handling for SMPlayer
* Update external-player-map.json: Add startOffset for SMPlayer
* Update utils.js: Truncate startOffset for SMPlayer
If watchProgress contains a non-integer value, SMPlayer will simply parse it as 0. Thus, truncate it before passing it along.
* Update utils.js: startOffset comments
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
---------
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* Wrap long one word channel names in `infoLine`
* Set height of playlist section to auto on small devices to prevent overflow
* Center videoThumbnail in playlist sidebar to visually be the same as playlist view
* Move CSS changes closer together
* * Update channel view to opt out of "Hide Videos From Channels"
* * Update history, local playlist & subscription view to opt out of "Hide Videos From Channels"
* * Update recommended video section to use hide videos from channel preference
* * Update setting tooltip text
* Update `or` to `and`
* * Update most popular view to use hide videos from channel preference
* fix for invidious (+6 squashed commits)
Squashed commits:
[65932b4b4] update playlist and channel filtering
[952a7213a] update subscriptions js to use premiereDate over durationText
[530dea939] Add back isRSS and viewcount check to fix when in subscriptions page
[93ebb7654] Fix hide premiere
[de7a8b4ec] ft-list-lazy-wrapper put whitespace back to what it was
[8dadb59b1] move showResult from a method to a computed to work with v-if
* Fix Hide Premier for Invidous API
* Refactor code to be more redable with better doc
---------
Co-authored-by: petaded <code@zikl.co.uk>
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
Providing these type of links is currently unnecessary
and can turn into a hassle when the players are extended by scripts
that are not expecting them and don't function as intended.
* Only use android formats when the video id in the response is correct
* Fix typo in playability status check
Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>
---------
Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>
* Let YouTube generate the Innertube session for the watch page
* Fix the user agent
* Set referer and origin for Innertube and googlevideo requests
* Fix sec-fetch-site header for Innertube requests
* Remove content-type header for googlevideo requests
* Changes from PR #3673
* * Update subscription view to be able to load videos from video cache again
* * Update subscription view to be able to load videos from video cache per channel
* * Remove meaningless argument `allowUseOfChannelCache`
* $ Remove unused imports
---------
Co-authored-by: petaded <code@zikl.co.uk>
* Use playlist thumbnail provided by YT from Local API
* Use correct thumbnails for playlist page
* Fix playlistThumbnail not giving correct value
* Update youtubei.js
* Update package.json
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* Update yarn.lock to align with package.json
---------
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* Fix Hide Channel Subscribers setting still displaying subscribers if changed from a secondary window (#3504)
* Revert naming change subscriptionCountText to channelSubCountText
* Use `!=` instead of `!==` for `subscriberCount` in ft-list-channel
* Set subscriberCount to null if `data.subscribers` is null in ft-list-channel.js
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
---------
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* Fix `proxyVideos` setting for legacy formats & hls urls
- Replace the hostname of stream urls with the current invidious instance when `proxyVideos` is true
- Add `local` flag to iv hls URLs when proxy videos is true
* Add missing `proxyVideos` getter in `ft-video-player`
* Move change of URI to before `getProxyVideos`
* ! Fix YT comment loading for video with comment disabled
* * Update video view w/ Local API to render video comment disabled as no comment
* ! Fix style with less side effects
* * Update watch view playlist component to auto scroll to current video
* ! Fix window being scrolled when playlist is out of initial view
* * Use `nextTick` instead of `setTimeout`
* Revert "* Use `nextTick` instead of `setTimeout`"
This reverts commit 9215b0fe54.
* * Remove setTimeout, fix issue when Invidious API used
* Allow fetching more community posts with IV
* Update src/renderer/views/Channel/Channel.js
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
---------
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
* * Update History & UserPlaylists view to filter with delay
* * Use lodash.debounce to implement
* * Update delay to 500ms
* * Update to have delay with empty query string
* + Add setting to auto load comment section
* * Cleanup hooks when possible
* * Update new setting to be a toggle
Possible values reduced to disabled & 0%
* * Use vue-observe-visibility to implement comment autoload
* - Remove unused translation entries
* - Remove no longer valid code comment
* * Rename & retype new setting
* * Implement auto more comment loading
* - Remove outdated comment
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
* * Disable new setting switch when hide comments enabled
* * Remove the unnecessary delay on video comment loading
* * Update according to review
* * Disable autoload when hide comment enabled
---------
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>