5c9705d94e
Change check for updates button to trigger a version check
2021-10-26 20:47:12 +02:00
85fb5827aa
Add Check for updates button
2021-10-26 20:47:11 +02:00
7067deb328
Merge pull request #7261 from TacoTheDank/bumpRecyclerView
...
Update RecyclerView & Groupie libraries
2021-10-24 21:22:04 +02:00
af936bc646
Always create a backup list when shuffling
...
The backup-list has to be created at all cost (even when current list size <= 2). Otherwise it's not possible to enter shuffle-mode (as ``isShuffled()`` always returns false)!
2021-10-23 17:35:42 +02:00
d66f933c69
Fixing the shuffle button on the UI is enough.
...
No need for doing the heavier method ``onShuffleModeEnabledChanged(false);``
2021-10-23 16:46:56 +02:00
cf81c37683
Removed changes to the intent handler
2021-10-23 16:43:29 +02:00
d2306b0fd7
Fixed shuffle button opacity bug
...
Parameterised shuffle state into initPlayback for potentially passing the shuffle state into the player in the future
2021-10-23 16:43:28 +02:00
44cad27d0a
Merge pull request #7268 from TeamNewPipe/release/0.21.13
...
Release 0.21.13
- Fix playback resume
- Ensure that the service for new version checks is not started in background
2021-10-21 20:51:01 +02:00
768bb0bbcd
Start service for update checks in onPastCreate()
2021-10-20 23:55:18 +02:00
ac071b383f
Revert part of #6872 and fix playback resuming
2021-10-20 23:20:26 +02:00
b6b19b474e
Update RecyclerView & Groupie
2021-10-19 17:31:59 -04:00
28c72e7f63
Fix new version check still occassionally started in background
2021-10-17 12:55:06 +02:00
5fcc3b4dab
[Player] Fix resuming playback
...
This was caused by #6872
2021-10-17 12:13:38 +02:00
51837ce36f
Get rid of setUserVisibleHint
2021-10-16 15:33:45 -04:00
ddaafb68c8
Adress new requested changes
2021-10-16 15:32:56 +02:00
a744775fe7
Adress requested changes and remove an unused return value in NewPipeTextViewHelper
2021-10-16 13:41:05 +02:00
50b85a7734
Simplify code
2021-10-16 13:41:05 +02:00
aab09c0c65
Merge the Share process of the two classes into one
...
A new class has been added in the util package: NewPipeTextViewHelper.
It shares the selected text of a TextView with ShareUtils#shareText (with the created shareSelectedTextWithShareUtils static method).
Only this static method can be used by other classes, other methods are private.
2021-10-16 13:41:04 +02:00
3ded6feddb
Improve code of created views
...
Use the same logic as Android TextViews
2021-10-16 13:41:04 +02:00
c8802fe5d0
Add JavaDocs on created views
2021-10-16 13:41:04 +02:00
411b3129f9
Use a custom EditText everywhere to be able to share with ShareUtils the selected text
...
This EditText class extends the AppCompatEditText class from androidx.
These changes (only in XML ressources) allow us to share the selected text by using ShareUtils.shareText, which opens the Android system chooser instead of the Huawei system chooser on EMUI devices.
2021-10-16 13:41:03 +02:00
a55acd38df
Use a custom TextView everywhere to be able to share with ShareUtils the selected text
...
This TextView class extends the AppCompatTextView class from androidx.
These changes (only in XML ressources) allow us to share the selected text by using ShareUtils.shareText, which opens the Android system chooser instead of the Huawei system chooser on EMUI devices.
2021-10-16 13:40:54 +02:00
7edef8d5a2
Merge pull request #7222 from ktprograms/queue-menu-channel-details
...
Added the 'Show Channel Details' menu item to the Queue long press menu
2021-10-15 20:28:18 +02:00
03d2ca9f9f
Fixed format of code
2021-10-15 20:18:52 +02:00
2271ea4281
Improved documentation
2021-10-15 20:16:34 +02:00
afc8db8f81
Add reasoning for separate openChannelFragmentUsingIntent method
2021-10-14 09:51:25 +08:00
4af49ee5a6
Merge pull request #7194 from KalleStruik/add-to-playlist-in-share
...
Add a "add to playlist" option in the share menu
2021-10-13 20:34:07 +02:00
d7b29aae5c
Merge branch 'master' into dev
2021-10-12 20:03:42 +02:00
9f7a8407ca
Merge pull request #7224 from vhouriet/vhouriet_fix_check-background-player-type
...
Check if background player already active before displaying player toast
2021-10-12 19:47:50 +02:00
54d3bff26d
Move checking for new version to MainAcitvity
...
When the service is started from the Application class, the app might be still in the background. This is definetly not the case when MainActivity.onCreate() is called.
Fixes #7227
2021-10-12 16:45:01 +02:00
a2050a5211
Merge pull request #7215 from litetex/code-cleanup-drawer-main-activity
...
Deduplicated drawer code in MainActivity
2021-10-11 21:29:42 +02:00
e9bd2934c3
Merge pull request #7202 from vhouriet/vhouriet_bug_issue-6662
...
Fix clicking timestamp shows Toast "Playing in popup mode"
2021-10-11 21:20:26 +02:00
50634eb2b3
Check player type before displaying background player toast
2021-10-11 19:41:22 +02:00
a2ff770afc
Added the 'Show Channel Details' menu item to the Queue long press menu
...
Created a method in NavigationHelper that opens the channel fragment using an Intent to MainActivity instead of replacing fragments.
2021-10-11 14:47:37 +08:00
658d988254
Simplify code and add annotations
2021-10-10 20:33:05 +02:00
9d7e9289bb
Fix cursor color in PlaylistCreationDialog
2021-10-10 12:32:57 +02:00
d7d87691cb
Add to playlist - Showing toast that this may take a moment
2021-10-09 18:47:36 +02:00
731640997e
Cleaned up PlaylistDialog-related code
2021-10-09 18:46:20 +02:00
64d7432852
Deduplicated drawer code in MainActivity
2021-10-09 16:37:34 +02:00
e6fffc0d5b
Fix crash on missing title when sharing livestream
2021-10-08 21:42:01 +02:00
1c9f68bcae
Fix clicking timestamp shows Toast "Playing in popup mode"
...
Fixes #6662
2021-10-05 18:15:36 +02:00
b633108a4c
Use the correct TAG in NavigationHelper
2021-10-03 22:04:34 +02:00
ceb55d0ede
Set the theme for PlaylistCreationDialog explicitly.
2021-10-03 14:25:50 +02:00
87c958b2e7
Rename the "append_playlist" string to "add_to_playlist"
2021-10-03 13:27:24 +02:00
d844e0aba6
Add a add to playlist option in the share menu.
2021-10-02 19:21:25 +02:00
4fc9f2e5fd
Merge pull request #7176 from litetex/fix-progress-bar-end-not-synced
...
Fixed seekbar not completed after video end
2021-10-02 09:24:59 +02:00
ce592f4baf
Merge pull request #6980 from bravenewpipe/check-for-update-after-toggle-and-restart
...
resets the expire date for checking for updates
2021-10-02 09:07:05 +02:00
2b3edcf2d1
Add a comment
2021-10-02 08:53:03 +02:00
672eb34049
Merge pull request #7150 from TacoTheDank/groupieBump
...
Update Groupie library to 2.9.0
2021-09-30 21:26:58 +02:00
b753705a84
Merge pull request #7178 from Redirion/dsblmdtnnelrealtekatv
...
Disable media tunneling on RealtekATV
2021-09-28 07:53:11 +02:00
f48ff610a3
Merge pull request #7166 from litetex/various-fixes-for-mediasession-player
...
Various fixes related to MediasessionManager
2021-09-27 23:45:38 +02:00
3cf94382e6
Disable media tunneling on RealtekATV
2021-09-27 13:21:04 +02:00
f52cb3bbe0
Make requested changes
2021-09-27 01:45:33 +05:30
d45182cb5c
Referenced issue in code
2021-09-26 20:58:49 +02:00
22847c6c92
Fixed progress bar not completing after video end
2021-09-26 20:50:24 +02:00
bc3139e5f9
Fix Settings import
2021-09-25 15:37:07 +05:30
72dbb9441e
Improved streamType check and documentation
2021-09-25 10:31:42 +02:00
bbc13756f3
Removed useless check for livestreams
2021-09-25 00:04:53 +02:00
ba0876b43b
Reformatted MediaSessionManager code
2021-09-24 23:55:06 +02:00
c0d41661e8
Fixed performance problems with mediaSessionManager
...
* Built on top of Redirons changes
* MediaSessionManager-Metadata get's only update when metadata changes - not every second as it only changes when the metadata changes
* Reworked mediasessionmanager
2021-09-24 23:40:12 +02:00
b2e2551e33
Two fixes for setMetadata
2021-09-24 23:28:55 +02:00
108af48b76
Enable Mark as Watched in all the other playlist fragments.
2021-09-23 21:39:47 -06:00
920695f90a
Regenerate some drawables to their latest design
2021-09-22 23:38:01 -04:00
b61d44aaa6
Update Groupie to 2.9.0
2021-09-22 19:08:03 -04:00
7e26748dc4
Merge branch 'master' into dev
2021-09-19 22:37:00 +02:00
7667b2ce59
Fix restoring orientation in onBack
2021-09-19 19:09:11 +02:00
62d36126ea
Load full stream info when enqueuing a stream
...
This commit calls getStreamInfo causing a full network fetch of stream
info (I believe only if required) when adding a stream item to the
queue. This should prevent UI issues of missing metadata when queueing
videos that have been fast-loaded and are missing metadata.
Fixes #7035
2021-09-19 00:15:56 +01:00
70354eb73e
Add play next to long press menu & refactor enqueue methods ( #6872 )
...
* added mvp play next button in long press menu; new intent handling, new long press dialog entry, new dialog functions, new strings
* changed line length for checkstyle pass
* cleaned comments, moved strings
* Update app/src/main/res/values/strings.xml
to make long press entry more descriptive
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
* Update app/src/main/res/values/strings.xml
Co-authored-by: Stypox <stypox@pm.me>
* replace redundant nextOnVideoPlayer methods
Co-authored-by: Stypox <stypox@pm.me>
* add enqueueNextOnPlayer and enqueueOnPlayer without selectOnAppend and RESUME_PLAYBACK/ deprecate enqueueNextOn*Player and enqueueOn*Player methods
add getPlayerIntent, getPlayerEnqueueIntent and getPlayerEnqueueNextIntent without selectOnAppend and RESUME_PLAYBACK/ deprecate those with
add section comments
* removed deprecated methods
removed redundant methods
* removed deprecated methods
removed redundant methods
* replaced APPEND_ONLY, removed SELECT_ON_APPEND / replaced remaining enqueueOn*Player methods
* now works with playlists
* renamed dialog entry
* checking for >1 items in the queue using the PlayerHolder
* making enqueue*OnPlayer safe to call when no video is playing (defaulting to audio)
* corrected strings
* improve getQueueSize in PlayerHolder
* long press to enqueue only if queue isnt empty
* add Whitespace
Co-authored-by: Stypox <stypox@pm.me>
* clarify comments / add spaces
* PlayerType as parameter of the enqueueOnPlayer method
add Helper method
* using the helper function everywhere (except for the background and popup long-press actions (also on playlists, history, ...)), so basically nowhere
/ passing checkstyle
* assimilated the enqueue*OnPlayer methods
* removed redundant comment, variable
* simplify code line
Co-authored-by: Stypox <stypox@pm.me>
* move if
* replace workaround for isPlayerOpen()
Co-authored-by: Stypox <stypox@pm.me>
* replaced workarounds (getType), corrected static access with getInstance
* remove unused imports
* changed method call to original, new method doesnt exist yet.
* Use getter method instead of property access syntax.
* improve conditional for play next entry
Co-authored-by: Stypox <stypox@pm.me>
* show play next btn in feed fragment
Co-authored-by: Stypox <stypox@pm.me>
* add play next to local playlist and statistics fragment
Co-authored-by: Stypox <stypox@pm.me>
* formating
Co-authored-by: Stypox <stypox@pm.me>
* correcting logic
Co-authored-by: Stypox <stypox@pm.me>
* remove 2 year old unused string, formating
Co-authored-by: Stypox <stypox@pm.me>
* correct enqueue (next) conditionals, default to background if no player is open. Dont generally default to background play.
* remove player open checks from button long press enqueue actions
* improve log msg
* Rename next to enqueue_next
* Refactor kotlin
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-authored-by: Stypox <stypox@pm.me>
2021-09-18 11:22:49 +02:00
a2887034a6
Merge pull request #7068 from litetex/fix-restart
...
Fixed restarting not working properly
2021-09-11 12:51:38 +02:00
7eb5aa1bc5
Merge pull request #7056 from TeamNewPipe/fix/playOnPopup
...
Fix handling exception in `playOnPopup` and toggle description tab
2021-09-10 18:21:41 +02:00
892b4a15f6
Change player progress bar update from 500 ms to 1 s
...
Just like in the issue 7062, https://github.com/TeamNewPipe/NewPipe/issues/7062 , this doesn't affect UI as it updates every one second anyway, but reduces very heavy android widget progress bar high cpu usage. With every 500s there is 6% cpu usage and with 1s only 4%. However further changes will have to be made to disable updating of player progress bar when screen is off to further reduce power consumption. With this, total power savings would be 20% in mAh consumption.
2021-09-07 00:04:05 +02:00
fda0a550fd
Fixed the app restarting not working properly
...
* Using [``process-phoenix``](https://github.com/JakeWharton/ProcessPhoenix )
2021-09-06 20:47:44 +02:00
4d51ebc37a
Fix a few SonarLint warnings
2021-09-05 19:54:28 +02:00
433c6dc33b
Fix OnErrorNotImplementedException in SearchFragment.initSuggestionObserver()
...
Hopefully also fix the cause of the original error.
2021-09-05 19:54:28 +02:00
ed4fdadd4d
Fix OnErrorNotImplementedException in playOnPopup
2021-09-05 19:54:28 +02:00
298e96b821
Fix updating the wrong tabs when changing settings while running the minimized player in VideoDetailFragment
...
The comments tab was updated although the settings for the description tab were changed.
2021-09-04 22:36:47 +02:00
8dd617fc6b
Merge pull request #7043 from Stypox/optimize-resources
...
Remove unused resources
2021-09-04 20:57:07 +02:00
3a09039b93
Remove unused resources
2021-09-02 21:13:54 +02:00
669a35bc78
check immediately for updates if user enables 'check for updates setting'
...
- Convert CheckForNewAppVersion to IntentService
- reset expire date to 0 after user enables check for updates setting
2021-09-02 07:20:35 +02:00
ed408b2094
Move fullscreen-related comments to javadocs
2021-09-01 20:13:27 +02:00
3bc661f583
Fix null pointer exception in player initialization
2021-09-01 20:13:27 +02:00
cf9b482be2
Completely close player when changing stream w/o autoplay
2021-09-01 20:13:27 +02:00
1d935b46f9
Open fullscreen when switching from popup to main player
2021-09-01 20:13:24 +02:00
520ac2e935
Fix bottom sheet state after automatic fullscreen
2021-09-01 20:12:14 +02:00
c6316abbce
Fix opening directly fullscreen on tablets
2021-09-01 20:12:09 +02:00
2dfe837c35
Extract isLandscape and isInMultiWindow to DeviceUtils
2021-09-01 20:09:08 +02:00
3c2ea7697c
Add option to directly open fullscreen when the main player starts
2021-09-01 20:08:37 +02:00
faa7a91764
Merge pull request #7004 from litetex/fix-showTextError-and-rework-ErrorPanel
...
Reworked the ErrorPanel
2021-08-31 18:26:51 +02:00
f629a4d206
Merge pull request #6993 from Redirion/closeaudioeffectsession
...
Close audio effect control session properly
2021-08-31 12:37:20 +02:00
4b7c37e919
Merge pull request #6955 from ktprograms/queue-long-press-menu
...
Show popup menu when long pressing in play queue (Full screen player)
2021-08-31 12:22:59 +02:00
f8f2dfce4b
Merge pull request #6882 from talanc/dev
...
Add support for CSV+ZIP subscriptions (Google Takeout)
2021-08-31 12:10:12 +02:00
5284072b8d
Improve mime type deduction on subscription import
2021-08-31 12:07:34 +02:00
e603dddc54
Added support for CSV+ZIP subscriptions
...
Updated import instructions string
2021-08-31 12:07:34 +02:00
a555aab3e7
Merge pull request #7024 from Stypox/string-fixes
...
Never use ``android.R.string``s; remove unused ``add`` string
2021-08-31 12:00:07 +02:00
88f1c3a808
Merge pull request #6985 from litetex/set-seekbarjump-when-using-dpad-to-seek-duration-from-preferences
...
Set ``KeyProgressIncrement`` manually / Fix long seekbar jumps when using a DPad
2021-08-30 23:36:29 +02:00
0e6668636d
Merge pull request #6986 from litetex/fix-build-problems-update-kotlin
...
Fix build problems and updated kotlin
2021-08-30 21:20:45 +02:00
cfdcb92fa3
Always use our strings, not android ones
2021-08-30 16:37:01 +02:00
039bd5d413
Rename string finish to ok, as its content was "OK"
2021-08-30 16:36:57 +02:00
57ca281c80
Merge pull request #6634 from Isira-Seneviratne/Use_PackageInfoCompat
...
Use PackageInfoCompat.getSignatures().
2021-08-29 23:13:12 +02:00
703f1550d8
Fixed double tapping the replay button
2021-08-29 17:53:09 +02:00
8bfd380b89
Merge pull request #6515 from Redirion/buffersharmonization
...
Use ExoPlayer default values for buffers
2021-08-29 17:44:43 +02:00
43e91ae4ae
Added plural forms for download related strings ( #6930 )
...
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
2021-08-29 13:28:01 +02:00
d931d058d9
Reworked the ErrorPanel
...
* All element on the error panel are now hidden by default (expect for the ``errorTextView``) as they are only optional shown
* Added a method to ensure the above
* This deduplicates a lot of code
* Fixed format of some LoC
* Added new method: ``showAndSetErrorButtonAction``
* Fixed ``showTextError``
* Named buttons more logically: ``errorButtonAction`` -> ``errorActionButton``
2021-08-28 17:05:12 +02:00
d9086300f3
Re-add sharing of the content name with the "Share" command ( #6957 )
...
The title of the content is re-added as the EXTRA_SUBJECT of the share intent.
2021-08-27 19:26:32 +02:00
f18a7c91ca
Suppressed warning
...
There seems to be a bug in the kotlin plugin as it tells you when building that this can't be null:
"Condition 'throwable != null' is always 'true'"
However it can indeed be null as seen in https://github.com/TeamNewPipe/NewPipe/pull/6986#issuecomment-906822218
2021-08-27 16:32:59 +02:00
43d0543b9f
close audio effect control session properly
2021-08-27 10:53:44 +02:00
0787d62254
Merge pull request #6820 from Stypox/picker-mime-type
...
Provide mime type to file picker to gray out unselectable files
2021-08-26 21:39:35 +02:00
b061423847
Changed package as the old one is deprecated
2021-08-26 18:09:27 +02:00
c6ead351c0
Set ``KeyProgressIncrement`` manually
...
* Set ``KeyProgressIncrement`` manually to the value of the seek duration in the settings so that it works when using the DPad
* consolidated code inside a new method to avoid duplication
2021-08-26 17:16:51 +02:00
a4503eb609
Remove TAG parameter, refactor method calls
2021-08-25 17:04:15 +08:00
a1cb3e59d6
Move opening popup menu to utility class
2021-08-25 09:30:40 +08:00
1b05c404d5
Remove Details option in Main Player Queue menu
2021-08-25 08:56:26 +08:00
5de455bb86
Change type of themeWrapper to ContextThemeWrapper
2021-08-25 08:56:26 +08:00
acdfee5c25
Show popup menu when long pressing in play queue (Full screen player)
2021-08-25 08:56:26 +08:00
87e7d95966
Do not show suggestions error snackbar for interrupted I/O
...
Fix formatting
2021-08-24 18:16:17 +02:00
d37ee1e0dc
First run migrations, then setDefaultValues, since the latter requires the correct types
2021-08-24 18:16:17 +02:00
1d33e7ab49
Allow choosing which types of search suggestions to show
...
local, remote, both, none
Replacing the old on-off setting
2021-08-24 18:16:16 +02:00
2027b743b4
Merge pull request #6919 from ktprograms/channel-details-all-places
...
Add Show Channel Details where it's missing
2021-08-24 16:43:21 +02:00
2928df0cc9
Fix checkstyle ParenPad error
2021-08-24 21:17:08 +08:00
44128f9145
Remove placeholder image while loading thumbnails
2021-08-24 10:56:25 +02:00
6eaff5ca6a
Apply review: move thumbnail loading out of Player
2021-08-24 10:56:25 +02:00
c0664c1cb6
Add Picasso to licences and remove Universal Image Loader
2021-08-24 10:56:25 +02:00
e229e5355d
Always create new bitmap when resizing thumbnail
...
This prevents strange crashes on some devices, fixes #4638
2021-08-24 10:56:25 +02:00
52189fc5df
Add debug setting to enable Picasso indicators
2021-08-24 10:56:25 +02:00
314964c5f9
Recycle Bitmap in transformation
2021-08-24 10:56:25 +02:00
fcef783bbb
Replace UniversalImageLoader with Picasso
2021-08-24 10:56:25 +02:00
bdbb9bead2
Merge pull request #6848 from Stypox/somali-cancel
...
Use custom cancel string everywhere
2021-08-22 22:36:14 +02:00
6fbb601802
Merge branch 'master' into dev
2021-08-22 22:22:37 +02:00
8715e7dd98
Only show "mark as watched" context menu entry when watch history is enabled
2021-08-22 22:15:05 +02:00
a209e87c69
Add Loading Channel Details Toast
2021-08-21 09:30:40 +08:00
967bdf8f08
Remove migration test, add manual testing reminder to Migrations.java
2021-08-17 08:57:03 +08:00
712985ced1
Save uploader url when adding from PlayQueueItem
2021-08-16 08:08:50 +08:00
0683dafa55
Merge pull request #6851 from litetex/make-parsing-of-timestamp-links-more-robust
...
Catch errors while processing timestamp-links
2021-08-14 21:10:20 +02:00
6f1958d398
Remove setting uploaderUrl to empty string if null
2021-08-14 20:59:38 +08:00
21bcadeecb
Make uploader_url column nullable
2021-08-14 17:48:35 +08:00
bd0427c79f
Refactor duplicated code into method
2021-08-14 17:32:38 +08:00
241054fd26
Remove hardcoded string
2021-08-14 15:38:57 +08:00
d8888e3495
Catch error from ExtractorHelper.getStreamInfo, remove blockingGet
2021-08-14 09:07:27 +08:00
76803bfcb1
Save channelUrl to Database if it doesn't exist
2021-08-13 18:02:53 +08:00
c248741c00
Add Show Channel Details to Subscription Feed & History
2021-08-13 17:04:10 +08:00
759a078ce0
Add uploader_url column to StreamEntity
2021-08-13 16:44:50 +08:00
a536311d56
name the regions according to the comments ( #6854 )
...
if a region is named android studio will show its name in the structure view.
2021-08-10 22:38:23 +00:00
5f3b8bea52
Fixed format
2021-08-06 22:12:49 +02:00
f9ab23bb4a
Removed useless fiedl
2021-08-06 22:08:42 +02:00
9f8b2264a2
Use better pattern for matching timestamp in text and some reworks
...
Also extracted overhead code into ``TimestampExtractor``
2021-08-06 22:08:29 +02:00
1d61bb58f5
Set loglevel to error
...
Co-authored-by: Stypox <stypox@pm.me>
2021-08-05 20:26:17 +02:00
a3440cc8ef
Merge pull request #6814 from Stypox/channel-grid-span-count
...
Fix channel item span count for SubscriptionFragment
2021-08-05 14:25:39 +02:00
51c60e5261
Catch errors while processing timestamp-links
...
Otherwise the complete app crashes, which is bad
2021-08-04 22:35:41 +02:00
f8caed139a
Use custom cancel string everywhere
...
to fix missing somali translation for android.R.string.cancel
2021-08-04 18:58:35 +02:00
a2297fb5b8
Fix play queue theme
2021-08-04 18:41:23 +02:00
32dffb577c
Provide mime type to file picker to gray out unselectable files
2021-08-01 13:52:32 +02:00
a9623f8e6a
Merge pull request #6550 from Douile/fix/clickthrough-feed-refresh
...
Disable feed click events while refresh overlay is shown
2021-08-01 13:11:24 +02:00
d32450255c
Use NotificationChannelCompat.
2021-08-01 14:59:30 +05:30
896aec5295
Merge pull request #6719 from TacoTheDank/core-lifecycle-bump
...
Update some AndroidX libraries
2021-08-01 11:24:33 +02:00
d42a534fc3
Merge pull request #6741 from KalleStruik/comment-hearts
...
Show hearts in comments
2021-08-01 11:12:58 +02:00
551e8df8b8
Merge pull request #6773 from nschulzke/mark-as-played
...
Add ability to mark an item as played
2021-08-01 10:30:36 +02:00
dc0a28b93d
Upsert the complete info if we fetch it for marking as watched
2021-07-31 09:50:41 -06:00
644396149b
Fix channel item span count for SubscriptionFragment
2021-07-31 11:02:57 +02:00
0e12cdea7c
Save the fetched duration to the database so that it can render the view correctly.
2021-07-29 20:59:23 -06:00
cd713db029
Merge pull request #6778 from Stypox/invalid-storage-npe
...
Fix NullPointerException when checking if storage exists
2021-07-28 16:54:57 +02:00
bdd16e06e0
Add comments describing the purpose of the markAsWatched method
2021-07-28 08:25:39 -06:00
4c632810ec
Fetch the stream info via a network request if no duration is found when attempting to mark as watched.
2021-07-27 15:21:56 -06:00
f451bdbfa4
Do not add Mark as Watched to a live stream.
2021-07-27 15:21:56 -06:00
bfac73b992
Make heart visible in android studio and move logic to the right file.
2021-07-27 22:34:59 +02:00
2b41f710a8
Change played to watched
2021-07-27 13:26:51 -06:00
5ceec31adf
Merge pull request #6720 from TacoTheDank/alertdialog-edittext
...
Consolidate edittext alert dialogs into one common layout
2021-07-27 19:42:51 +02:00
50f3b08c59
Consolidate edittext alert dialogs into one layout
2021-07-27 13:31:58 -04:00
2aebf6ceaf
Add log when existsAsFile() is called on an invalid StoredFileHelper
2021-07-27 17:56:41 +02:00
0cb801179c
Merge pull request #6733 from Douile/fix/recaptcha-webview-background-activity
...
Prevent recaptcha webview from keeping youtube loaded in background
2021-07-27 11:41:17 +02:00
1822d21676
Fix NullPointerException when checking if storage exists
2021-07-27 11:36:14 +02:00
7fd2ebc252
Add ability to mark an item as played
2021-07-26 20:51:41 -06:00
74173317de
Change heart color to be red, add else clause for non hearted comments, and apply some code style suggestions.
2021-07-23 19:43:25 +02:00
3874e16187
Added support for showing when a comment has received a heart from the creator of a video.
2021-07-23 17:30:47 +02:00
52c136439e
Use loadUrl instead of loadData
...
Co-authored-by: Stypox <stypox@pm.me>
2021-07-22 10:47:47 +00:00
cd86ed3877
Prevent recaptcha webview from keeping youtube loaded in background
...
After the cookies are extracted from the recaptcha webview make it load an empty
page to prevent youtube being loaded unecessarily in the background.
2021-07-22 02:41:01 +01:00
1d85661ab9
Update some AndroidX libraries
2021-07-21 19:31:41 -04:00
fa8630ddae
Use url comparison between queue items when disabling preloading
...
From #4562 : Disable player stream preloading only if the current stream is going to be replaced for sure (see this). equals() was implemented for PlayQueueItems, so that (only) the url is compared when checking them.
2021-07-21 18:09:18 +02:00
4a2bd7bd7b
Remove equals() method from PlayQueueItem
2021-07-21 18:09:18 +02:00
63fdc100d6
Merge pull request #6705 from Stypox/big-text-info-items
...
Fix grid span count calculation
2021-07-19 22:45:48 +02:00
9e2ece78dd
Merge pull request #6701 from Stypox/dismiss-download-dialog
...
Dismiss download dialog correctly
2021-07-19 21:47:12 +02:00
4a242e43a7
Merge pull request #6689 from Isira-Seneviratne/Use_WindowInsetsCompat_getInsets
...
Use WindowInsetsCompat's getInsets() method.
2021-07-19 21:19:06 +02:00
5ba3ef0a25
Fix grid span count calculation; remove duplicate methods
2021-07-19 20:47:50 +02:00
9458b9f37d
Use PackageInfoCompat.getSignatures().
2021-07-19 19:48:24 +05:30
ca282f2be8
Merge pull request #6675 from Isira-Seneviratne/Use_Kotlin_methods
...
Use Kotlin methods in LicenseFragment.
2021-07-19 13:19:02 +02:00
46e7da4e21
Merge pull request #6688 from litetex/fix-some-build-warnings
...
Fix some build warnings
2021-07-19 11:52:24 +02:00
1721817fdb
Use WindowInsetsCompat's getInsets() method.
2021-07-19 15:17:44 +05:30
d57bfde604
Merge pull request #6434 from litetex/playerSeekbarPreview
...
Player seekbar thumbnail preview
2021-07-19 11:42:10 +02:00
8f559965f6
Call DownloadDialog dismiss() in the correct way
2021-07-19 10:59:45 +02:00
35e005caaa
Improve method order in DownloadDialog and add separator comments
2021-07-18 14:23:38 +02:00
baa12c7069
Merge pull request #6536 from TacoTheDank/moar-onactivityresult
...
More onActivityResult deprecation fixes
2021-07-18 10:24:00 +02:00
e2b044d2ee
Use Kotlin methods in LicenseFragment.
2021-07-18 07:47:12 +05:30
621af8d812
Removed unused import (rebasing/merge problem)
2021-07-17 16:52:24 +02:00
a9b5ef3bd3
Set minWidth to 10dp so that the popup player works (mostly) correctly
2021-07-17 16:43:03 +02:00
384d964827
Added seekbarThumbnailPreview
2021-07-17 16:43:00 +02:00
36c198fc33
One textview is enough for disabled comments
...
Ref: https://github.com/TeamNewPipe/NewPipe/pull/6483#discussion_r654793920
2021-07-17 13:14:50 +02:00
81107df53f
Added comments disabled functionallity
2021-07-17 13:10:44 +02:00
a932bc2503
Merge pull request #6637 from Isira-Seneviratne/Use_GestureDetectorCompat
...
Use GestureDetectorCompat.
2021-07-17 12:58:43 +02:00
f4e2eca256
Simplified code and adjusted the style so that it's similar to FeedFragment
2021-07-16 21:21:10 +02:00
08d5dfa49c
Removed updateRelativeTimeViews when the activity is paused
...
We don't need to call ``updateRelativeTimeViews`` when the activity is paused, because the user likely won't notice it.
Despite that onResume already calls ``updateRelativeTimeViews`` so there is no need to do that twice.
2021-07-16 21:04:32 +02:00
dfa941a9e7
Merge pull request #6503 from evermind-zz/fixes-for-upstream
...
Prevent error msg: 'Unrecoverable player error occurred' while playin…
2021-07-14 09:53:30 +02:00
1584028995
Merge pull request #6531 from XiangRongLin/immediat_pref_commit
...
Remove option to immediately commit pref changes on import
2021-07-14 09:48:58 +02:00
14dab85ff0
Merge pull request #6566 from evermind-zz/various-fixes-for-upstream
...
Convert PlayerHolder to Singleton; cleanup in VideoDetailFragment; Player/MainPlayer do not call onDestroy() directly
2021-07-14 09:46:04 +02:00
96f5cd9f17
Merge pull request #6463 from Stypox/metadata-tags
...
Improved metadata layout, better tags accessibility
2021-07-12 16:18:11 +02:00
2e053ea25a
Fix crash when refreshing feed
2021-07-11 03:00:32 +01:00
9ca2691a2c
Add close() method to NewPipeDatabase
2021-07-10 14:46:51 +02:00
7c3f5a62c5
Fix crash when refreshing feed after importing database or subscriptions
...
The database was not closed correctly
2021-07-10 13:09:01 +02:00
6711dae4e0
Use GestureDetectorCompat.
2021-07-10 15:35:11 +05:30
f78d2a5ed8
Prevent error msg: 'Unrecoverable player error occurred' while playing video during rotation ( #6502 )
...
Playing a video in VideoDetailFragment and rotating the screen to landscape (back and forth more often)
can trigger this error message. Especially if rotation for whatever reason takes long or
playing a high resolution (1080p) video.
The underlying logcat error messages:
05-12 16:38:38.251 24920 26037 E Surface : getSlotFromBufferLocked: unknown buffer: 0x923fc810
05-12 16:38:38.251 24920 26037 W ACodec : [OMX.qcom.video.decoder.avc] can not return buffer 35 to native window
The problem is that that Exoplayer is trying to write to our -- during rotation -- no longer existant
(VideoDetailFragment) SurfaceView.
Solution:
Implementing SurfaceHolder.Callback and using DummySurface we can now handle the lifecycle of the Surface.
How?: In case we are no longer able to write to the Surface eg. through rotation/putting in
background we can set a DummySurface. Although it only works on API >= 23.
Result: we get a little video interruption (audio is still fine) but we won't get the
'Unrecoverable player error occurred' error message.
This implementation is based on and more background information:
'ExoPlayer stuck in buffering after re-adding the surface view a few time 2703'
-> exoplayer fix suggestion link
https://github.com/google/ExoPlayer/issues/2703#issuecomment-300599981
2021-07-06 12:49:56 +02:00
48c2c156cb
convert PlayerHolder to Singleton, handle context within, bugfix ServiceConnection leak
...
- bugfix: have ServiceConnection created only once!
- select the context within the PlayerHolder to start, stop, bind or unbind the service
-> we have to make sure the Service is started AND stopped within the same context
-> so let PlayerHolder be the one to select the context
- remove removeListener() and replace the call with setListener(null)
- Compatibility: use ContextCompat.startForegroundService instead of startService()
2021-07-06 12:31:26 +02:00
435813355f
use viewBinding correctly
2021-07-06 07:56:05 +02:00
e30a552b6c
remove duplicated code for toggle Fullscreen
2021-07-06 07:56:00 +02:00
22a4a4b2df
move null checks for player and playerService to helper methods
...
- code is easier to read
- duplication of code reduced
2021-07-06 07:55:52 +02:00
201e5ee09d
Fix NPE when connecting via BT
2021-06-25 09:14:15 +02:00
aaa3e20c5a
service.onDestroy() should only be called from the system and not manually
...
instead use service.stopService() which inturn calls stopSelf() and
triggers hopefully onDestroy() to be called. Eventually we have to make
sure that all ServiceConnections are closed to successfully stop the service
now!
Cleanup within stopService() and not only onDestroy()
So we make sure that all listeners can react to onServiceStopped()
and close their ServiceConnections. Afterwards the android framework
is ready to stop the Service.
2021-06-24 10:15:07 +02:00
0da8e28651
Merge pull request #6558 from Douile/fix/searchfragment-null-service
...
Fix null pointer exception when displaying SearchFragment
2021-06-24 09:16:00 +02:00
25cf8dc20a
Refactoring by Android Studio
2021-06-23 14:30:01 +02:00
cb1a138140
#6081 : Disable feed click handlers during refresh
...
This patch changes click handlers for feed (Whats new) so that they do
nothing while the feed is refreshing and the items being clicked are not
visible.
2021-06-22 19:42:20 +01:00
384ca66205
#6522 : Fix null pointer exception when displaying SearchFragment
...
It seems due to #6394 updating the FragmentX library there was a
change to the order of lifecycle calls, as such onResume() was no longer
before onCreateOptionsMenu() creating a null pointer exception when
using service in onCreateOptionsMenu() as it is only set in onResume().
By moving the initialization of service to onStart() which still happens
before onCreateOptionsMenu() this crash can be avoided. This commit also
adds a check for a null service to prevent future crashes for similar
issues.
2021-06-22 16:52:02 +01:00
62b4f333bb
Don't enable SAF on Fire TV ( #6516 )
2021-06-20 19:01:06 +00:00
ae39b31c68
Fix onActivityResult deprecation in DownloadDialog
2021-06-20 14:14:44 -04:00
e5a1438673
Fix onActivityResult deprecation in DownloadSettingsFragment
2021-06-20 14:11:00 -04:00
785c0376f8
Remove variable ContentSettingsFragment.lastImportExportDataUri
...
Instead pass the value through the methods as parameter
2021-06-20 09:30:59 +02:00
0bdf8de38e
Resolve sonar issues in ContentSettingsFragment
...
https://sonarcloud.io/organizations/teamnewpipe/rules?open=java%3AS2885&rule_key=java%3AS2885
https://sonarcloud.io/organizations/teamnewpipe/rules?open=java%3AS112&rule_key=java%3AS112
2021-06-20 09:30:59 +02:00
9767e98e50
Remove option to immediately commit pref changes on import
...
System is now not restarted with `System.exit(0)`.
Instead it is done properly by finishing the activity and restarting the activity. This allows preference changes which are queued up asynchronously through `apply` to be applied.
2021-06-20 09:17:55 +02:00
79deff3261
Annotate some overridden methods and parameters as NonNull
2021-06-19 18:37:02 -04:00
f5d015e8f9
Use ExoPlayer default values for buffers
2021-06-18 20:18:24 +02:00
74ad488f4a
Merge pull request #6394 from TacoTheDank/androidx-fragment-134
...
Update AndroidX Fragment to 1.3.4
2021-06-18 13:14:30 +02:00
be676ad93c
Merge pull request #3371 from mauriciocolli/feed-hide-played-items
...
Add ability to hide played items in a feed
2021-06-18 09:18:48 +02:00
0803d9f2b5
Merge pull request #6504 from evermind-zz/fixes-choice-dialog
...
dismiss choice dialog in onStop() to avoid a leaked window Exception:
2021-06-17 21:17:35 +02:00
841fb4cfc5
Merge pull request #6495 from danielmbutler/Replace-System.exit-calls
...
Replace the System.exit calls with getActivity.finishAffinity()
2021-06-17 21:07:48 +02:00
90de75968d
Replaced System.Exit calls with FinishAffinity and Start Activity calls
...
Implemented "RestartApp" method defined in NavigationHelper.java.
This method is used in ExitActivity.java and ContentSettingsFragment.java
2021-06-17 17:18:15 +01:00
a9ab2f54ea
dismiss choice dialog in onStop() to avoid a leaked window Exception:
...
E/WindowManager: android.view.WindowLeaked: Activity org.schabi.newpipe.RouterActivity has leaked window DecorView@d99fe3b[] that was originally added here
at android.view.ViewRootImpl.<init>(ViewRootImpl.java:418)
2021-06-17 06:53:47 +02:00
a1432e939f
Fix onActivityResult deprecation in SubscriptionFragment
2021-06-15 22:09:19 -04:00
cae160b5be
Fix onActivityResult deprecation in SubscriptionsImportFragment
2021-06-15 22:09:07 -04:00
aa4e5da146
Fix onActivityResult deprecation in ContentSettingsFragment
2021-06-15 22:08:55 -04:00
1061fca6a3
Add super.onRequestPermissionsResult where missing
2021-06-15 22:08:41 -04:00
e4885e3c52
Fix some older deprecations from previous Fragment versions
2021-06-15 22:08:25 -04:00
d6e0bd8c26
Merge pull request #6059 from Dakkaron/manual-tablet-mode-setting
...
Adds manual tablet mode setting
2021-06-15 21:46:19 +02:00
e01ef42d31
Adds manual tablet mode setting
...
Co-authored-by: TiA4f8R <74829229+TiA4f8R@users.noreply.github.com>
2021-06-15 21:43:06 +02:00
32df4d39a4
Reshow feed if grid/list view mode changed
2021-06-15 18:40:25 +02:00
7145b117cc
Fix long press menu in feed
2021-06-14 19:02:57 +02:00
4698d07323
Do not hide feed buttons (show/hide & help) behind three-dots menu
2021-06-14 19:02:57 +02:00
2142f05a88
Fix hiding finished streams in groups; new stream state validity condition
...
Consider stream state valid also if >1/4 of video was watched
2021-06-14 19:01:01 +02:00
40a2df847b
Move tags layout at the bottom, use multiple lines
2021-06-13 21:56:06 +02:00
4eef498d24
Only call addClickListenersOnTimestamps if relatedInfo is instance of StreamInfo
2021-06-11 14:08:08 +02:00
32b0bdb98c
Fix the compile error
2021-06-11 12:19:29 +02:00
edfe0f9c30
Fix disposables handling for text linkifier
...
also use differently Markwon methods to convert plain text to markdown
2021-06-11 12:12:12 +02:00
eef418a757
Improve text linkifier function parameters
2021-06-11 12:12:11 +02:00
218f25c171
Annotate params and methods with NonNull
2021-06-11 12:12:10 +02:00
f02df6d80c
Fix an error and add a new method in the ShareUtils class
...
Fix the error due to the rebase on the dev branch of this branch
Add a shareText method in the ShareUtils class which has 3 parameters and calls
the original shareText method with an empty string for the
imagePreviewUrl param.
2021-06-11 12:12:09 +02:00
vhouriet
litetex
0x416c6578
Tobi
Stypox
TacoTheDank
TiA4f8R
ktprograms
Kalle Struik
Robin
Robin
Laksh
Nathan Schulzke
Douile
z3r0r4
thefalsedev
evermind
talanc
Agnieszka C
acti0
Isira Seneviratne
bopol
Mohammed Anas
XiangRongLin
danielmbutler
Dakkaron