[YouTube] Fix descriptive audio role property value in generated DASH manifests
The note 2 of the section 5.8.5.5 of ISO/IEC 23009-1 specifies that when using the alternate role value, a description of what the alternate track is should be added. As alternate is a generic role and a description role exists, it should be used instead of the alternate one. The property value has been of course updated in the corresponding test.
This commit is contained in:
parent
5a9b6ed2e3
commit
7d27f8f25d
|
@ -278,7 +278,7 @@ public final class YoutubeDashManifestCreatorsUtils {
|
||||||
*
|
*
|
||||||
* <p>
|
* <p>
|
||||||
* {@code <Role schemeIdUri="urn:mpeg:DASH:role:2011" value="VALUE"/>}, where {@code VALUE} is
|
* {@code <Role schemeIdUri="urn:mpeg:DASH:role:2011" value="VALUE"/>}, where {@code VALUE} is
|
||||||
* {@code main} for videos and audios and {@code alternate} for descriptive audio
|
* {@code main} for videos and audios and {@code description} for descriptive audio
|
||||||
* </p>
|
* </p>
|
||||||
*
|
*
|
||||||
* <p>
|
* <p>
|
||||||
|
@ -299,7 +299,7 @@ public final class YoutubeDashManifestCreatorsUtils {
|
||||||
|
|
||||||
setAttribute(roleElement, doc, "schemeIdUri", "urn:mpeg:DASH:role:2011");
|
setAttribute(roleElement, doc, "schemeIdUri", "urn:mpeg:DASH:role:2011");
|
||||||
setAttribute(roleElement, doc, "value", itagItem.isDescriptiveAudio()
|
setAttribute(roleElement, doc, "value", itagItem.isDescriptiveAudio()
|
||||||
? "alternate" : "main");
|
? "description" : "main");
|
||||||
|
|
||||||
adaptationSetElement.appendChild(roleElement);
|
adaptationSetElement.appendChild(roleElement);
|
||||||
} catch (final DOMException e) {
|
} catch (final DOMException e) {
|
||||||
|
|
|
@ -233,7 +233,7 @@ class YoutubeDashManifestCreatorsTest {
|
||||||
private void assertRoleElement(@Nonnull final Document document,
|
private void assertRoleElement(@Nonnull final Document document,
|
||||||
@Nonnull final ItagItem itagItem) {
|
@Nonnull final ItagItem itagItem) {
|
||||||
final Element element = assertGetElement(document, ROLE, ADAPTATION_SET);
|
final Element element = assertGetElement(document, ROLE, ADAPTATION_SET);
|
||||||
assertAttrEquals(itagItem.isDescriptiveAudio() ? "alternate" : "main", element, "value");
|
assertAttrEquals(itagItem.isDescriptiveAudio() ? "description" : "main", element, "value");
|
||||||
}
|
}
|
||||||
|
|
||||||
private void assertRepresentationElement(@Nonnull final Document document,
|
private void assertRepresentationElement(@Nonnull final Document document,
|
||||||
|
|
Loading…
Reference in New Issue