Stypox
8c1041def6
Add @ null annotations where Android Studio suggested it
...
That is, basically where the overriding function was missing an annotation from the base method.
Also apply renaming of emptyDescription to EMPTY_DESCRIPTION
2022-03-26 22:07:14 +01:00
Stypox
adbbdc7a5b
[YouTube] Fix regex warning: use ' {2}' instead of ' '
2022-03-26 22:07:14 +01:00
Stypox
24e83997b4
[Bandcamp] Add Java 8 streams
2022-03-26 22:07:12 +01:00
Stypox
349990fd48
Fix redundant escape \\ in regex in Utils
2022-03-26 22:01:30 +01:00
litetex
3bf7aa3762
Cleanup `TimeAgoParser`
2022-03-26 21:09:31 +01:00
litetex
5a18730845
Merge pull request #813 from litetex/fix-test-2022-03
...
Fixed tests (+ Youtube shorts in channels)
2022-03-26 21:09:10 +01:00
litetex
af82edf9dc
Fix checkstyle problems
2022-03-26 20:54:20 +01:00
litetex
29408f9356
`YoutubeMusicSearchExtractorTest$Suggestion` has no mock data
2022-03-26 20:52:28 +01:00
litetex
fcee247f9f
Switched to mockonly tests
...
* Made the reason why the tests are mockonly mandatory
2022-03-26 20:52:28 +01:00
litetex
0fceb4686b
Added missing mock data
2022-03-26 20:52:27 +01:00
litetex
70b20f0d6b
Updated mock data after conflicts
2022-03-26 20:52:27 +01:00
litetex
6a6c9359af
Fixed kurzgesagt test - They changed their description...
2022-03-26 20:52:27 +01:00
litetex
26596215fa
Refactored `MediaCCCRecentListExtractorTest`
2022-03-26 20:52:26 +01:00
litetex
53962bfd7d
Disabled suggestion test for now
...
Has to be done once YT's backed works again...
2022-03-26 20:52:26 +01:00
litetex
66dc5e8bb8
API hardening against changes
2022-03-26 20:52:26 +01:00
litetex
5d58156cde
Update mock data
2022-03-26 20:52:25 +01:00
litetex
7598b40957
Workaround for incorrect duration for "YT shorts" videos in channels
...
As a workaround 0 is returned as duration for such videos.
See also https://github.com/TeamNewPipe/NewPipe/issues/8034
2022-03-26 20:52:24 +01:00
litetex
164e21b5af
Fixed `MediaCCCRecentKiosk`
...
Ignore faulty data/items (with duration <= 0)
2022-03-26 20:52:23 +01:00
litetex
49dfdae5d2
Removed useless throw declaration
2022-03-26 20:51:38 +01:00
litetex
69a58fd3d1
Don't use sysout
2022-03-26 20:51:37 +01:00
litetex
639be7adda
Minimized some code
2022-03-26 20:51:37 +01:00
litetex
2bd4299563
Fixed test: Peertube - Use new comments and videos
...
Old comments/videos got deleted
2022-03-26 20:49:39 +01:00
litetex
606a386a98
Fix tests: What's peertube has less comments now
2022-03-26 20:49:39 +01:00
litetex
4d1a1c8fb8
Better test for `MediaCCCRecentListExtractorTest`
...
* Use assertAll
* Show which item is affected
2022-03-26 20:49:38 +01:00
litetex
ba43dbaa28
Fix Tests: The channel lost abos
2022-03-26 20:49:38 +01:00
litetex
ff436e5740
Fixed test: YT mix playlist
2022-03-26 20:49:38 +01:00
litetex
bb49f7d857
Merge pull request #817 from Stypox/checkstyle
...
Add checkstyle
2022-03-26 20:46:49 +01:00
litetex
9c07e8a664
Fix useage of wrong object
2022-03-26 20:17:50 +01:00
litetex
93d6e5c4d5
CI: Upload test reports when failure occurs
2022-03-26 19:57:17 +01:00
litetex
804e57004f
Fixed new checkstyle problems from dev
2022-03-26 19:46:10 +01:00
litetex
33347ac18b
Removed unused methods
...
``contentFilters`` and ``sortfilter`` are get inside the ``ListLinkHandler`` and not the ``ListLinkHandlerFactory``
``ListLinkHandlerFactory`` only passes these values through when ``fromQuery`` is called
2022-03-26 19:43:11 +01:00
litetex
ec5b54c38b
Removed unused class
2022-03-26 19:43:10 +01:00
litetex
8771af7ba5
Restored original naming
2022-03-26 19:43:09 +01:00
litetex
01cfde0285
Fixed typo
2022-03-26 19:43:09 +01:00
Stypox
bdadcfa1f7
Legitimately suppress remaining checkstyle warnings
2022-03-26 19:43:08 +01:00
Stypox
740a37a2de
[YouTube] Fix checkstyle issues
2022-03-26 19:42:40 +01:00
Stypox
9dc17cd1ca
[Soundcloud] Fix checkstyle issues
2022-03-26 19:40:20 +01:00
Stypox
9ab32cb2e7
[Peertube] Fix checkstyle issues
2022-03-26 19:40:19 +01:00
Stypox
9f7e06c817
[MediaCCC] Fix checkstyle issues
2022-03-26 19:40:18 +01:00
Stypox
3a94839359
[Bandcamp] Fix checkstyle issues
2022-03-26 19:40:17 +01:00
Stypox
08dff33002
Use Java 8 streams in NewPipe class
2022-03-26 19:40:15 +01:00
Stypox
c2446ecff0
Use Java 8 streams and deduplicate code in MediaFormat class
2022-03-26 19:40:15 +01:00
Stypox
d79e20340c
Fix checkstyle issues in root package extractor/
...
Note: not all issues were fixed because MediaFormat and ServiceList use a specific formatting that makes sense for them
2022-03-26 19:40:14 +01:00
Stypox
ca7c63f273
Fix remaining checkstyle issues in utils/ subpackage
2022-03-26 19:40:13 +01:00
Stypox
1d5f22e41f
Fix checkstyle issues & more in JsonUtils
...
Also use Java 8 streams and extract duplicate code to getInstanceOf function
2022-03-26 19:40:13 +01:00
Stypox
87d2834986
Fix checkstyle issues & more in DonationLinkHelper
...
Also add comment about the class being unused and replace the fixLink function with Utils.stringToUrl()
2022-03-26 19:40:12 +01:00
Stypox
bd7b362040
Fix checkstyle issues & more in DashMpdParser
...
Also remove useless null check on ItagItem.getItag() as that function already throws an exception if there is no itag
2022-03-26 19:40:11 +01:00
Stypox
8aba2b47b0
Fix checkstyle issues in subpackages with abstract classes
2022-03-26 19:40:10 +01:00
Stypox
e4951a0623
Refactor code handling http headers in downloader.Request
2022-03-26 19:37:47 +01:00
Stypox
37690058d2
Add checkstyle to extractor gradle project
...
With respect to NewPipe's checkstyle.xml, checkstyle is disabled for javadoc comments. There is no need for strict rules over comments here in the extractor, as sometimes javadocs are just needed to clarify a small thing and having empty/meaningless @param or @throws is useless.
2022-03-26 19:37:46 +01:00
