Improve test descriptions

This commit is contained in:
Mark Felder 2023-12-27 22:37:06 -05:00
parent ad0a5deb67
commit a6fd251e44
1 changed files with 5 additions and 5 deletions

View File

@ -15,7 +15,7 @@ defmodule Pleroma.Workers.RemoteFetcherWorkerTest do
@unreachable_object "https://unreachable.example.com/" @unreachable_object "https://unreachable.example.com/"
@depth_object "https://depth.example.com/" @depth_object "https://depth.example.com/"
describe "it does not" do describe "RemoteFetcherWorker" do
setup do setup do
Tesla.Mock.mock(fn Tesla.Mock.mock(fn
%{method: :get, url: @deleted_object_one} -> %{method: :get, url: @deleted_object_one} ->
@ -40,7 +40,7 @@ defmodule Pleroma.Workers.RemoteFetcherWorkerTest do
end) end)
end end
test "requeue a deleted object" do test "does not requeue a deleted object" do
assert {:cancel, _} = assert {:cancel, _} =
RemoteFetcherWorker.perform(%Oban.Job{ RemoteFetcherWorker.perform(%Oban.Job{
args: %{"op" => "fetch_remote", "id" => @deleted_object_one} args: %{"op" => "fetch_remote", "id" => @deleted_object_one}
@ -52,14 +52,14 @@ defmodule Pleroma.Workers.RemoteFetcherWorkerTest do
}) })
end end
test "requeue an unauthorized object" do test "does not requeue an unauthorized object" do
assert {:cancel, _} = assert {:cancel, _} =
RemoteFetcherWorker.perform(%Oban.Job{ RemoteFetcherWorker.perform(%Oban.Job{
args: %{"op" => "fetch_remote", "id" => @unauthorized_object} args: %{"op" => "fetch_remote", "id" => @unauthorized_object}
}) })
end end
test "fetch an unreachable instance" do test "does not fetch an unreachable instance" do
Instances.set_consistently_unreachable(@unreachable_object) Instances.set_consistently_unreachable(@unreachable_object)
refute Instances.reachable?(@unreachable_object) refute Instances.reachable?(@unreachable_object)
@ -70,7 +70,7 @@ defmodule Pleroma.Workers.RemoteFetcherWorkerTest do
}) })
end end
test "requeue an object that exceeded depth" do test "does not requeue an object that exceeded depth" do
clear_config([:instance, :federation_incoming_replies_max_depth], 0) clear_config([:instance, :federation_incoming_replies_max_depth], 0)
assert {:cancel, _} = assert {:cancel, _} =