Multi-target support
This commit adds multi-target support to GDB. What this means is that
with this commit, GDB can now be connected to different targets at the
same time. E.g., you can debug a live native process and a core dump
at the same time, connect to multiple gdbservers, etc.
Actually, the word "target" is overloaded in gdb. We already have a
target stack, with pushes several target_ops instances on top of one
another. We also have "info target" already, which means something
completely different to what this patch does.
So from here on, I'll be using the "target connections" term, to mean
an open process_stratum target, pushed on a target stack. This patch
makes gdb have multiple target stacks, and multiple process_stratum
targets open simultaneously. The user-visible changes / commands will
also use this terminology, but of course it's all open to debate.
User-interface-wise, not that much changes. The main difference is
that each inferior may have its own target connection.
A target connection (e.g., a target extended-remote connection) may
support debugging multiple processes, just as before.
Say you're debugging against gdbserver in extended-remote mode, and
you do "add-inferior" to prepare to spawn a new process, like:
(gdb) target extended-remote :9999
...
(gdb) start
...
(gdb) add-inferior
Added inferior 2
(gdb) inferior 2
[Switching to inferior 2 [<null>] (<noexec>)]
(gdb) file a.out
...
(gdb) start
...
At this point, you have two inferiors connected to the same gdbserver.
With this commit, GDB will maintain a target stack per inferior,
instead of a global target stack.
To preserve the behavior above, by default, "add-inferior" makes the
new inferior inherit a copy of the target stack of the current
inferior. Same across a fork - the child inherits a copy of the
target stack of the parent. While the target stacks are copied, the
targets themselves are not. Instead, target_ops is made a
refcounted_object, which means that target_ops instances are
refcounted, which each inferior counting for a reference.
What if you want to create an inferior and connect it to some _other_
target? For that, this commit introduces a new "add-inferior
-no-connection" option that makes the new inferior not share the
current inferior's target. So you could do:
(gdb) target extended-remote :9999
Remote debugging using :9999
...
(gdb) add-inferior -no-connection
[New inferior 2]
Added inferior 2
(gdb) inferior 2
[Switching to inferior 2 [<null>] (<noexec>)]
(gdb) info inferiors
Num Description Executable
1 process 18401 target:/home/pedro/tmp/main
* 2 <null>
(gdb) tar extended-remote :10000
Remote debugging using :10000
...
(gdb) info inferiors
Num Description Executable
1 process 18401 target:/home/pedro/tmp/main
* 2 process 18450 target:/home/pedro/tmp/main
(gdb)
A following patch will extended "info inferiors" to include a column
indicating which connection an inferior is bound to, along with a
couple other UI tweaks.
Other than that, debugging is the same as before. Users interact with
inferiors and threads as before. The only difference is that
inferiors may be bound to processes running in different machines.
That's pretty much all there is to it in terms of noticeable UI
changes.
On to implementation.
Since we can be connected to different systems at the same time, a
ptid_t is no longer a unique identifier. Instead a thread can be
identified by a pair of ptid_t and 'process_stratum_target *', the
later being the instance of the process_stratum target that owns the
process/thread. Note that process_stratum_target inherits from
target_ops, and all process_stratum targets inherit from
process_stratum_target. In earlier patches, many places in gdb were
converted to refer to threads by thread_info pointer instead of
ptid_t, but there are still places in gdb where we start with a
pid/tid and need to find the corresponding inferior or thread_info
objects. So you'll see in the patch many places adding a
process_stratum_target parameter to functions that used to take only a
ptid_t.
Since each inferior has its own target stack now, we can always find
the process_stratum target for an inferior. That is done via a
inf->process_target() convenience method.
Since each inferior has its own target stack, we need to handle the
"beneath" calls when servicing target calls. The solution I settled
with is just to make sure to switch the current inferior to the
inferior you want before making a target call. Not relying on global
context is just not feasible in current GDB. Fortunately, there
aren't that many places that need to do that, because generally most
code that calls target methods already has the current context
pointing to the right inferior/thread. Note, to emphasize -- there's
no method to "switch to this target stack". Instead, you switch the
current inferior, and that implicitly switches the target stack.
In some spots, we need to iterate over all inferiors so that we reach
all target stacks.
Native targets are still singletons. There's always only a single
instance of such targets.
Remote targets however, we'll have one instance per remote connection.
The exec target is still a singleton. There's only one instance. I
did not see the point of instanciating more than one exec_target
object.
After vfork, we need to make sure to push the exec target on the new
inferior. See exec_on_vfork.
For type safety, functions that need a {target, ptid} pair to identify
a thread, take a process_stratum_target pointer for target parameter
instead of target_ops *. Some shared code in gdb/nat/ also need to
gain a target pointer parameter. This poses an issue, since gdbserver
doesn't have process_stratum_target, only target_ops. To fix this,
this commit renames gdbserver's target_ops to process_stratum_target.
I think this makes sense. There's no concept of target stack in
gdbserver, and gdbserver's target_ops really implements a
process_stratum-like target.
The thread and inferior iterator functions also gain
process_stratum_target parameters. These are used to be able to
iterate over threads and inferiors of a given target. Following usual
conventions, if the target pointer is null, then we iterate over
threads and inferiors of all targets.
I tried converting "add-inferior" to the gdb::option framework, as a
preparatory patch, but that stumbled on the fact that gdb::option does
not support file options yet, for "add-inferior -exec". I have a WIP
patchset that adds that, but it's not a trivial patch, mainly due to
need to integrate readline's filename completion, so I deferred that
to some other time.
In infrun.c/infcmd.c, the main change is that we need to poll events
out of all targets. See do_target_wait. Right after collecting an
event, we switch the current inferior to an inferior bound to the
target that reported the event, so that target methods can be used
while handling the event. This makes most of the code transparent to
multi-targets. See fetch_inferior_event.
infrun.c:stop_all_threads is interesting -- in this function we need
to stop all threads of all targets. What the function does is send an
asynchronous stop request to all threads, and then synchronously waits
for events, with target_wait, rinse repeat, until all it finds are
stopped threads. Now that we have multiple targets, it's not
efficient to synchronously block in target_wait waiting for events out
of one target. Instead, we implement a mini event loop, with
interruptible_select, select'ing on one file descriptor per target.
For this to work, we need to be able to ask the target for a waitable
file descriptor. Such file descriptors already exist, they are the
descriptors registered in the main event loop with add_file_handler,
inside the target_async implementations. This commit adds a new
target_async_wait_fd target method that just returns the file
descriptor in question. See wait_one / stop_all_threads in infrun.c.
The 'threads_executing' global is made a per-target variable. Since
it is only relevant to process_stratum_target targets, this is where
it is put, instead of in target_ops.
You'll notice that remote.c includes some FIXME notes. These refer to
the fact that the global arrays that hold data for the remote packets
supported are still globals. For example, if we connect to two
different servers/stubs, then each might support different remote
protocol features. They might even be different architectures, like
e.g., one ARM baremetal stub, and a x86 gdbserver, to debug a
host/controller scenario as a single program. That isn't going to
work correctly today, because of said globals. I'm leaving fixing
that for another pass, since it does not appear to be trivial, and I'd
rather land the base work first. It's already useful to be able to
debug multiple instances of the same server (e.g., a distributed
cluster, where you have full control over the servers installed), so I
think as is it's already reasonable incremental progress.
Current limitations:
- You can only resume more that one target at the same time if all
targets support asynchronous debugging, and support non-stop mode.
It should be possible to support mixed all-stop + non-stop
backends, but that is left for another time. This means that
currently in order to do multi-target with gdbserver you need to
issue "maint set target-non-stop on". I would like to make that
mode be the default, but we're not there yet. Note that I'm
talking about how the target backend works, only. User-visible
all-stop mode works just fine.
- As explained above, connecting to different remote servers at the
same time is likely to produce bad results if they don't support the
exact set of RSP features.
FreeBSD updates courtesy of John Baldwin.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
John Baldwin <jhb@FreeBSD.org>
* aarch64-linux-nat.c
(aarch64_linux_nat_target::thread_architecture): Adjust.
* ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
(task_command_1): Likewise.
* aix-thread.c (sync_threadlists, aix_thread_target::resume)
(aix_thread_target::wait, aix_thread_target::fetch_registers)
(aix_thread_target::store_registers)
(aix_thread_target::thread_alive): Adjust.
* amd64-fbsd-tdep.c: Include "inferior.h".
(amd64fbsd_get_thread_local_address): Pass down target.
* amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
thread's gdbarch instead of target_gdbarch.
* break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
get_last_target_status.
* break-catch-syscall.c (print_it_catch_syscall): Likewise.
* breakpoint.c (breakpoints_should_be_inserted_now): Consider all
inferiors.
(update_inserted_breakpoint_locations): Skip if inferiors with no
execution.
(update_global_location_list): When handling moribund locations,
find representative inferior for location's pspace, and use thread
count of its process_stratum target.
* bsd-kvm.c (bsd_kvm_target_open): Pass target down.
* bsd-uthread.c (bsd_uthread_target::wait): Use
as_process_stratum_target and adjust thread_change_ptid and
add_thread calls.
(bsd_uthread_target::update_thread_list): Use
as_process_stratum_target and adjust find_thread_ptid,
thread_change_ptid and add_thread calls.
* btrace.c (maint_btrace_packet_history_cmd): Adjust
find_thread_ptid call.
* corelow.c (add_to_thread_list): Adjust add_thread call.
(core_target_open): Adjust add_thread_silent and thread_count
calls.
(core_target::pid_to_str): Adjust find_inferior_ptid call.
* ctf.c (ctf_target_open): Adjust add_thread_silent call.
* event-top.c (async_disconnect): Pop targets from all inferiors.
* exec.c (add_target_sections): Push exec target on all inferiors
sharing the program space.
(remove_target_sections): Remove the exec target from all
inferiors sharing the program space.
(exec_on_vfork): New.
* exec.h (exec_on_vfork): Declare.
* fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
Pass it down.
(fbsd_nat_target::update_thread_list): Adjust.
(fbsd_nat_target::resume): Adjust.
(fbsd_handle_debug_trap): Add fbsd_nat_target parameter. Pass it
down.
(fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
* fbsd-tdep.c (fbsd_corefile_thread): Adjust
get_thread_arch_regcache call.
* fork-child.c (gdb_startup_inferior): Pass target down to
startup_inferior and set_executing.
* gdbthread.h (struct process_stratum_target): Forward declare.
(add_thread, add_thread_silent, add_thread_with_info)
(in_thread_list): Add process_stratum_target parameter.
(find_thread_ptid(inferior*, ptid_t)): New overload.
(find_thread_ptid, thread_change_ptid): Add process_stratum_target
parameter.
(all_threads()): Delete overload.
(all_threads, all_non_exited_threads): Add process_stratum_target
parameter.
(all_threads_safe): Use brace initialization.
(thread_count): Add process_stratum_target parameter.
(set_resumed, set_running, set_stop_requested, set_executing)
(threads_are_executing, finish_thread_state): Add
process_stratum_target parameter.
(switch_to_thread): Use is_current_thread.
* i386-fbsd-tdep.c: Include "inferior.h".
(i386fbsd_get_thread_local_address): Pass down target.
* i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
* inf-child.c (inf_child_target::maybe_unpush_target): Remove
have_inferiors check.
* inf-ptrace.c (inf_ptrace_target::create_inferior)
(inf_ptrace_target::attach): Adjust.
* infcall.c (run_inferior_call): Adjust.
* infcmd.c (run_command_1): Pass target to
scoped_finish_thread_state.
(proceed_thread_callback): Skip inferiors with no execution.
(continue_command): Rename 'all_threads' local to avoid hiding
'all_threads' function. Adjust get_last_target_status call.
(prepare_one_step): Adjust set_running call.
(signal_command): Use user_visible_resume_target. Compare thread
pointers instead of inferior_ptid.
(info_program_command): Adjust to pass down target.
(attach_command): Mark target's 'thread_executing' flag.
(stop_current_target_threads_ns): New, factored out from ...
(interrupt_target_1): ... this. Switch inferior before making
target calls.
* inferior-iter.h
(struct all_inferiors_iterator, struct all_inferiors_range)
(struct all_inferiors_safe_range)
(struct all_non_exited_inferiors_range): Filter on
process_stratum_target too. Remove explicit.
* inferior.c (inferior::inferior): Push dummy target on target
stack.
(find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
Add process_stratum_target parameter, and pass it down.
(have_live_inferiors): Adjust.
(switch_to_inferior_and_push_target): New.
(add_inferior_command, clone_inferior_command): Handle
"-no-connection" parameter. Use
switch_to_inferior_and_push_target.
(_initialize_inferior): Mention "-no-connection" option in
the help of "add-inferior" and "clone-inferior" commands.
* inferior.h: Include "process-stratum-target.h".
(interrupt_target_1): Use bool.
(struct inferior) <push_target, unpush_target, target_is_pushed,
find_target_beneath, top_target, process_target, target_at,
m_stack>: New.
(discard_all_inferiors): Delete.
(find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
(all_inferiors, all_non_exited_inferiors): Add
process_stratum_target parameter.
* infrun.c: Include "gdb_select.h" and <unordered_map>.
(target_last_proc_target): New global.
(follow_fork_inferior): Push target on new inferior. Pass target
to add_thread_silent. Call exec_on_vfork. Handle target's
reference count.
(follow_fork): Adjust get_last_target_status call. Also consider
target.
(follow_exec): Push target on new inferior.
(struct execution_control_state) <target>: New field.
(user_visible_resume_target): New.
(do_target_resume): Call target_async.
(resume_1): Set target's threads_executing flag. Consider resume
target.
(commit_resume_all_targets): New.
(proceed): Also consider resume target. Skip threads of inferiors
with no execution. Commit resumtion in all targets.
(start_remote): Pass current inferior to wait_for_inferior.
(infrun_thread_stop_requested): Consider target as well. Pass
thread_info pointer to clear_inline_frame_state instead of ptid.
(infrun_thread_thread_exit): Consider target as well.
(random_pending_event_thread): New inferior parameter. Use it.
(do_target_wait): Rename to ...
(do_target_wait_1): ... this. Add inferior parameter, and pass it
down.
(threads_are_resumed_pending_p, do_target_wait): New.
(prepare_for_detach): Adjust calls.
(wait_for_inferior): New inferior parameter. Handle it. Use
do_target_wait_1 instead of do_target_wait.
(fetch_inferior_event): Adjust. Switch to representative
inferior. Pass target down.
(set_last_target_status): Add process_stratum_target parameter.
Save target in global.
(get_last_target_status): Add process_stratum_target parameter and
handle it.
(nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
(context_switch): Check inferior_ptid == null_ptid before calling
inferior_thread().
(get_inferior_stop_soon): Pass down target.
(wait_one): Rename to ...
(poll_one_curr_target): ... this.
(struct wait_one_event): New.
(wait_one): New.
(stop_all_threads): Adjust.
(handle_no_resumed, handle_inferior_event): Adjust to consider the
event's target.
(switch_back_to_stepped_thread): Also consider target.
(print_stop_event): Update.
(normal_stop): Update. Also consider the resume target.
* infrun.h (wait_for_inferior): Remove declaration.
(user_visible_resume_target): New declaration.
(get_last_target_status, set_last_target_status): New
process_stratum_target parameter.
* inline-frame.c (clear_inline_frame_state(ptid_t)): Add
process_stratum_target parameter, and use it.
(clear_inline_frame_state (thread_info*)): New.
* inline-frame.c (clear_inline_frame_state(ptid_t)): Add
process_stratum_target parameter.
(clear_inline_frame_state (thread_info*)): Declare.
* linux-fork.c (delete_checkpoint_command): Pass target down to
find_thread_ptid.
(checkpoint_command): Adjust.
* linux-nat.c (linux_nat_target::follow_fork): Switch to thread
instead of just tweaking inferior_ptid.
(linux_nat_switch_fork): Pass target down to thread_change_ptid.
(exit_lwp): Pass target down to find_thread_ptid.
(attach_proc_task_lwp_callback): Pass target down to
add_thread/set_running/set_executing.
(linux_nat_target::attach): Pass target down to
thread_change_ptid.
(get_detach_signal): Pass target down to find_thread_ptid.
Consider last target status's target.
(linux_resume_one_lwp_throw, resume_lwp)
(linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
(stop_wait_callback, save_stop_reason, linux_nat_filter_event)
(linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
(linux_nat_target::async_wait_fd): New.
(linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
target down.
* linux-nat.h (linux_nat_target::async_wait_fd): Declare.
* linux-tdep.c (get_thread_arch_regcache): Pass target down.
* linux-thread-db.c (struct thread_db_info::process_target): New
field.
(add_thread_db_info): Save target.
(get_thread_db_info): New process_stratum_target parameter. Also
match target.
(delete_thread_db_info): New process_stratum_target parameter.
Also match target.
(thread_from_lwp): Adjust to pass down target.
(thread_db_notice_clone): Pass down target.
(check_thread_db_callback): Pass down target.
(try_thread_db_load_1): Always push the thread_db target.
(try_thread_db_load, record_thread): Pass target down.
(thread_db_target::detach): Pass target down. Always unpush the
thread_db target.
(thread_db_target::wait, thread_db_target::mourn_inferior): Pass
target down. Always unpush the thread_db target.
(find_new_threads_callback, thread_db_find_new_threads_2)
(thread_db_target::update_thread_list): Pass target down.
(thread_db_target::pid_to_str): Pass current inferior down.
(thread_db_target::get_thread_local_address): Pass target down.
(thread_db_target::resume, maintenance_check_libthread_db): Pass
target down.
* nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
* procfs.c (procfs_target::procfs_init_inferior): Declare.
(proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
(procfs_init_inferior): Rename to ...
(procfs_target::procfs_init_inferior): ... this and adjust.
(procfs_target::create_inferior, procfs_notice_thread)
(procfs_do_thread_registers): Adjust.
* ppc-fbsd-tdep.c: Include "inferior.h".
(ppcfbsd_get_thread_local_address): Pass down target.
* proc-service.c (ps_xfer_memory): Switch current inferior and
program space as well.
(get_ps_regcache): Pass target down.
* process-stratum-target.c
(process_stratum_target::thread_address_space)
(process_stratum_target::thread_architecture): Pass target down.
* process-stratum-target.h
(process_stratum_target::threads_executing): New field.
(as_process_stratum_target): New.
* ravenscar-thread.c
(ravenscar_thread_target::update_inferior_ptid): Pass target down.
(ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
down.
* record-btrace.c (record_btrace_target::info_record): Adjust.
(record_btrace_target::record_method)
(record_btrace_target::record_is_replaying)
(record_btrace_target::fetch_registers)
(get_thread_current_frame_id, record_btrace_target::resume)
(record_btrace_target::wait, record_btrace_target::stop): Pass
target down.
* record-full.c (record_full_wait_1): Switch to event thread.
Pass target down.
* regcache.c (regcache::regcache)
(get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
process_stratum_target parameter and handle it.
(current_thread_target): New global.
(get_thread_regcache): Add process_stratum_target parameter and
handle it. Switch inferior before calling target method.
(get_thread_regcache): Pass target down.
(get_thread_regcache_for_ptid): Pass target down.
(registers_changed_ptid): Add process_stratum_target parameter and
handle it.
(registers_changed_thread, registers_changed): Pass target down.
(test_get_thread_arch_aspace_regcache): New.
(current_regcache_test): Define a couple local test_target_ops
instances and use them for testing.
(readwrite_regcache): Pass process_stratum_target parameter.
(cooked_read_test, cooked_write_test): Pass mock_target down.
* regcache.h (get_thread_regcache, get_thread_arch_regcache)
(get_thread_arch_aspace_regcache): Add process_stratum_target
parameter.
(regcache::target): New method.
(regcache::regcache, regcache::get_thread_arch_aspace_regcache)
(regcache::registers_changed_ptid): Add process_stratum_target
parameter.
(regcache::m_target): New field.
(registers_changed_ptid): Add process_stratum_target parameter.
* remote.c (remote_state::supports_vCont_probed): New field.
(remote_target::async_wait_fd): New method.
(remote_unpush_and_throw): Add remote_target parameter.
(get_current_remote_target): Adjust.
(remote_target::remote_add_inferior): Push target.
(remote_target::remote_add_thread)
(remote_target::remote_notice_new_inferior)
(get_remote_thread_info): Pass target down.
(remote_target::update_thread_list): Skip threads of inferiors
bound to other targets. (remote_target::close): Don't discard
inferiors. (remote_target::add_current_inferior_and_thread)
(remote_target::process_initial_stop_replies)
(remote_target::start_remote)
(remote_target::remote_serial_quit_handler): Pass down target.
(remote_target::remote_unpush_target): New remote_target
parameter. Unpush the target from all inferiors.
(remote_target::remote_unpush_and_throw): New remote_target
parameter. Pass it down.
(remote_target::open_1): Check whether the current inferior has
execution instead of checking whether any inferior is live. Pass
target down.
(remote_target::remote_detach_1): Pass down target. Use
remote_unpush_target.
(extended_remote_target::attach): Pass down target.
(remote_target::remote_vcont_probe): Set supports_vCont_probed.
(remote_target::append_resumption): Pass down target.
(remote_target::append_pending_thread_resumptions)
(remote_target::remote_resume_with_hc, remote_target::resume)
(remote_target::commit_resume): Pass down target.
(remote_target::remote_stop_ns): Check supports_vCont_probed.
(remote_target::interrupt_query)
(remote_target::remove_new_fork_children)
(remote_target::check_pending_events_prevent_wildcard_vcont)
(remote_target::remote_parse_stop_reply)
(remote_target::process_stop_reply): Pass down target.
(first_remote_resumed_thread): New remote_target parameter. Pass
it down.
(remote_target::wait_as): Pass down target.
(unpush_and_perror): New remote_target parameter. Pass it down.
(remote_target::readchar, remote_target::remote_serial_write)
(remote_target::getpkt_or_notif_sane_1)
(remote_target::kill_new_fork_children, remote_target::kill): Pass
down target.
(remote_target::mourn_inferior): Pass down target. Use
remote_unpush_target.
(remote_target::core_of_thread)
(remote_target::remote_btrace_maybe_reopen): Pass down target.
(remote_target::pid_to_exec_file)
(remote_target::thread_handle_to_thread_info): Pass down target.
(remote_target::async_wait_fd): New.
* riscv-fbsd-tdep.c: Include "inferior.h".
(riscv_fbsd_get_thread_local_address): Pass down target.
* sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
* sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
(ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
Adjust.
* solib-spu.c (spu_skip_standalone_loader): Pass down target.
* solib-svr4.c (enable_break): Pass down target.
* spu-multiarch.c (parse_spufs_run): Pass down target.
* spu-tdep.c (spu2ppu_sniffer): Pass down target.
* target-delegates.c: Regenerate.
* target.c (g_target_stack): Delete.
(current_top_target): Return the current inferior's top target.
(target_has_execution_1): Refer to the passed-in inferior's top
target.
(target_supports_terminal_ours): Check whether the initial
inferior was already created.
(decref_target): New.
(target_stack::push): Incref/decref the target.
(push_target, push_target, unpush_target): Adjust.
(target_stack::unpush): Defref target.
(target_is_pushed): Return bool. Adjust to refer to the current
inferior's target stack.
(dispose_inferior): Delete, and inline parts ...
(target_preopen): ... here. Only dispose of the current inferior.
(target_detach): Hold strong target reference while detaching.
Pass target down.
(target_thread_name): Add assertion.
(target_resume): Pass down target.
(target_ops::beneath, find_target_at): Adjust to refer to the
current inferior's target stack.
(get_dummy_target): New.
(target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
has a thread running.
(initialize_targets): Rename to ...
(_initialize_target): ... this.
* target.h: Include "gdbsupport/refcounted-object.h".
(struct target_ops): Inherit refcounted_object.
(target_ops::shortname, target_ops::longname): Make const.
(target_ops::async_wait_fd): New method.
(decref_target): Declare.
(struct target_ops_ref_policy): New.
(target_ops_ref): New typedef.
(get_dummy_target): Declare function.
(target_is_pushed): Return bool.
* thread-iter.c (all_matching_threads_iterator::m_inf_matches)
(all_matching_threads_iterator::all_matching_threads_iterator):
Handle filter target.
* thread-iter.h (struct all_matching_threads_iterator, struct
all_matching_threads_range, class all_non_exited_threads_range):
Filter by target too. Remove explicit.
* thread.c (threads_executing): Delete.
(inferior_thread): Pass down current inferior.
(clear_thread_inferior_resources): Pass down thread pointer
instead of ptid_t.
(add_thread_silent, add_thread_with_info, add_thread): Add
process_stratum_target parameter. Use it for thread and inferior
searches.
(is_current_thread): New.
(thread_info::deletable): Use it.
(find_thread_ptid, thread_count, in_thread_list)
(thread_change_ptid, set_resumed, set_running): New
process_stratum_target parameter. Pass it down.
(set_executing): New process_stratum_target parameter. Pass it
down. Adjust reference to 'threads_executing'.
(threads_are_executing): New process_stratum_target parameter.
Adjust reference to 'threads_executing'.
(set_stop_requested, finish_thread_state): New
process_stratum_target parameter. Pass it down.
(switch_to_thread): Also match inferior.
(switch_to_thread): New process_stratum_target parameter. Pass it
down.
(update_threads_executing): Reimplement.
* top.c (quit_force): Pop targets from all inferior.
(gdb_init): Don't call initialize_targets.
* windows-nat.c (windows_nat_target) <get_windows_debug_event>:
Declare.
(windows_add_thread, windows_delete_thread): Adjust.
(get_windows_debug_event): Rename to ...
(windows_nat_target::get_windows_debug_event): ... this. Adjust.
* tracefile-tfile.c (tfile_target_open): Pass down target.
* gdbsupport/common-gdbthread.h (struct process_stratum_target):
Forward declare.
(switch_to_thread): Add process_stratum_target parameter.
* mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
parameter. Use it.
(mi_on_resume): Pass target down.
* nat/fork-inferior.c (startup_inferior): Add
process_stratum_target parameter. Pass it down.
* nat/fork-inferior.h (startup_inferior): Add
process_stratum_target parameter.
* python/py-threadevent.c (py_get_event_thread): Pass target down.
gdb/gdbserver/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* fork-child.c (post_fork_inferior): Pass target down to
startup_inferior.
* inferiors.c (switch_to_thread): Add process_stratum_target
parameter.
* lynx-low.c (lynx_target_ops): Now a process_stratum_target.
* nto-low.c (nto_target_ops): Now a process_stratum_target.
* linux-low.c (linux_target_ops): Now a process_stratum_target.
* remote-utils.c (prepare_resume_reply): Pass the target to
switch_to_thread.
* target.c (the_target): Now a process_stratum_target.
(done_accessing_memory): Pass the target to switch_to_thread.
(set_target_ops): Ajust to use process_stratum_target.
* target.h (struct target_ops): Rename to ...
(struct process_stratum_target): ... this.
(the_target, set_target_ops): Adjust.
(prepare_to_access_memory): Adjust comment.
* win32-low.c (child_xfer_memory): Adjust to use
process_stratum_target.
(win32_target_ops): Now a process_stratum_target.
2020-01-10 21:06:08 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
John Baldwin <jhb@FreeBSD.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-linux-nat.c
|
|
|
|
|
|
(aarch64_linux_nat_target::thread_architecture): Adjust.
|
|
|
|
|
|
* ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
|
|
|
|
|
|
(task_command_1): Likewise.
|
|
|
|
|
|
* aix-thread.c (sync_threadlists, aix_thread_target::resume)
|
|
|
|
|
|
(aix_thread_target::wait, aix_thread_target::fetch_registers)
|
|
|
|
|
|
(aix_thread_target::store_registers)
|
|
|
|
|
|
(aix_thread_target::thread_alive): Adjust.
|
|
|
|
|
|
* amd64-fbsd-tdep.c: Include "inferior.h".
|
|
|
|
|
|
(amd64fbsd_get_thread_local_address): Pass down target.
|
|
|
|
|
|
* amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
|
|
|
|
|
|
thread's gdbarch instead of target_gdbarch.
|
|
|
|
|
|
* break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
|
|
|
|
|
|
get_last_target_status.
|
|
|
|
|
|
* break-catch-syscall.c (print_it_catch_syscall): Likewise.
|
|
|
|
|
|
* breakpoint.c (breakpoints_should_be_inserted_now): Consider all
|
|
|
|
|
|
inferiors.
|
|
|
|
|
|
(update_inserted_breakpoint_locations): Skip if inferiors with no
|
|
|
|
|
|
execution.
|
|
|
|
|
|
(update_global_location_list): When handling moribund locations,
|
|
|
|
|
|
find representative inferior for location's pspace, and use thread
|
|
|
|
|
|
count of its process_stratum target.
|
|
|
|
|
|
* bsd-kvm.c (bsd_kvm_target_open): Pass target down.
|
|
|
|
|
|
* bsd-uthread.c (bsd_uthread_target::wait): Use
|
|
|
|
|
|
as_process_stratum_target and adjust thread_change_ptid and
|
|
|
|
|
|
add_thread calls.
|
|
|
|
|
|
(bsd_uthread_target::update_thread_list): Use
|
|
|
|
|
|
as_process_stratum_target and adjust find_thread_ptid,
|
|
|
|
|
|
thread_change_ptid and add_thread calls.
|
|
|
|
|
|
* btrace.c (maint_btrace_packet_history_cmd): Adjust
|
|
|
|
|
|
find_thread_ptid call.
|
|
|
|
|
|
* corelow.c (add_to_thread_list): Adjust add_thread call.
|
|
|
|
|
|
(core_target_open): Adjust add_thread_silent and thread_count
|
|
|
|
|
|
calls.
|
|
|
|
|
|
(core_target::pid_to_str): Adjust find_inferior_ptid call.
|
|
|
|
|
|
* ctf.c (ctf_target_open): Adjust add_thread_silent call.
|
|
|
|
|
|
* event-top.c (async_disconnect): Pop targets from all inferiors.
|
|
|
|
|
|
* exec.c (add_target_sections): Push exec target on all inferiors
|
|
|
|
|
|
sharing the program space.
|
|
|
|
|
|
(remove_target_sections): Remove the exec target from all
|
|
|
|
|
|
inferiors sharing the program space.
|
|
|
|
|
|
(exec_on_vfork): New.
|
|
|
|
|
|
* exec.h (exec_on_vfork): Declare.
|
|
|
|
|
|
* fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
|
|
|
|
|
|
Pass it down.
|
|
|
|
|
|
(fbsd_nat_target::update_thread_list): Adjust.
|
|
|
|
|
|
(fbsd_nat_target::resume): Adjust.
|
|
|
|
|
|
(fbsd_handle_debug_trap): Add fbsd_nat_target parameter. Pass it
|
|
|
|
|
|
down.
|
|
|
|
|
|
(fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
|
|
|
|
|
|
* fbsd-tdep.c (fbsd_corefile_thread): Adjust
|
|
|
|
|
|
get_thread_arch_regcache call.
|
|
|
|
|
|
* fork-child.c (gdb_startup_inferior): Pass target down to
|
|
|
|
|
|
startup_inferior and set_executing.
|
|
|
|
|
|
* gdbthread.h (struct process_stratum_target): Forward declare.
|
|
|
|
|
|
(add_thread, add_thread_silent, add_thread_with_info)
|
|
|
|
|
|
(in_thread_list): Add process_stratum_target parameter.
|
|
|
|
|
|
(find_thread_ptid(inferior*, ptid_t)): New overload.
|
|
|
|
|
|
(find_thread_ptid, thread_change_ptid): Add process_stratum_target
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(all_threads()): Delete overload.
|
|
|
|
|
|
(all_threads, all_non_exited_threads): Add process_stratum_target
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(all_threads_safe): Use brace initialization.
|
|
|
|
|
|
(thread_count): Add process_stratum_target parameter.
|
|
|
|
|
|
(set_resumed, set_running, set_stop_requested, set_executing)
|
|
|
|
|
|
(threads_are_executing, finish_thread_state): Add
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
(switch_to_thread): Use is_current_thread.
|
|
|
|
|
|
* i386-fbsd-tdep.c: Include "inferior.h".
|
|
|
|
|
|
(i386fbsd_get_thread_local_address): Pass down target.
|
|
|
|
|
|
* i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
|
|
|
|
|
|
* inf-child.c (inf_child_target::maybe_unpush_target): Remove
|
|
|
|
|
|
have_inferiors check.
|
|
|
|
|
|
* inf-ptrace.c (inf_ptrace_target::create_inferior)
|
|
|
|
|
|
(inf_ptrace_target::attach): Adjust.
|
|
|
|
|
|
* infcall.c (run_inferior_call): Adjust.
|
|
|
|
|
|
* infcmd.c (run_command_1): Pass target to
|
|
|
|
|
|
scoped_finish_thread_state.
|
|
|
|
|
|
(proceed_thread_callback): Skip inferiors with no execution.
|
|
|
|
|
|
(continue_command): Rename 'all_threads' local to avoid hiding
|
|
|
|
|
|
'all_threads' function. Adjust get_last_target_status call.
|
|
|
|
|
|
(prepare_one_step): Adjust set_running call.
|
|
|
|
|
|
(signal_command): Use user_visible_resume_target. Compare thread
|
|
|
|
|
|
pointers instead of inferior_ptid.
|
|
|
|
|
|
(info_program_command): Adjust to pass down target.
|
|
|
|
|
|
(attach_command): Mark target's 'thread_executing' flag.
|
|
|
|
|
|
(stop_current_target_threads_ns): New, factored out from ...
|
|
|
|
|
|
(interrupt_target_1): ... this. Switch inferior before making
|
|
|
|
|
|
target calls.
|
|
|
|
|
|
* inferior-iter.h
|
|
|
|
|
|
(struct all_inferiors_iterator, struct all_inferiors_range)
|
|
|
|
|
|
(struct all_inferiors_safe_range)
|
|
|
|
|
|
(struct all_non_exited_inferiors_range): Filter on
|
|
|
|
|
|
process_stratum_target too. Remove explicit.
|
|
|
|
|
|
* inferior.c (inferior::inferior): Push dummy target on target
|
|
|
|
|
|
stack.
|
|
|
|
|
|
(find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
|
|
|
|
|
|
Add process_stratum_target parameter, and pass it down.
|
|
|
|
|
|
(have_live_inferiors): Adjust.
|
|
|
|
|
|
(switch_to_inferior_and_push_target): New.
|
|
|
|
|
|
(add_inferior_command, clone_inferior_command): Handle
|
|
|
|
|
|
"-no-connection" parameter. Use
|
|
|
|
|
|
switch_to_inferior_and_push_target.
|
|
|
|
|
|
(_initialize_inferior): Mention "-no-connection" option in
|
|
|
|
|
|
the help of "add-inferior" and "clone-inferior" commands.
|
|
|
|
|
|
* inferior.h: Include "process-stratum-target.h".
|
|
|
|
|
|
(interrupt_target_1): Use bool.
|
|
|
|
|
|
(struct inferior) <push_target, unpush_target, target_is_pushed,
|
|
|
|
|
|
find_target_beneath, top_target, process_target, target_at,
|
|
|
|
|
|
m_stack>: New.
|
|
|
|
|
|
(discard_all_inferiors): Delete.
|
|
|
|
|
|
(find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
|
|
|
|
|
|
(all_inferiors, all_non_exited_inferiors): Add
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
* infrun.c: Include "gdb_select.h" and <unordered_map>.
|
|
|
|
|
|
(target_last_proc_target): New global.
|
|
|
|
|
|
(follow_fork_inferior): Push target on new inferior. Pass target
|
|
|
|
|
|
to add_thread_silent. Call exec_on_vfork. Handle target's
|
|
|
|
|
|
reference count.
|
|
|
|
|
|
(follow_fork): Adjust get_last_target_status call. Also consider
|
|
|
|
|
|
target.
|
|
|
|
|
|
(follow_exec): Push target on new inferior.
|
|
|
|
|
|
(struct execution_control_state) <target>: New field.
|
|
|
|
|
|
(user_visible_resume_target): New.
|
|
|
|
|
|
(do_target_resume): Call target_async.
|
|
|
|
|
|
(resume_1): Set target's threads_executing flag. Consider resume
|
|
|
|
|
|
target.
|
|
|
|
|
|
(commit_resume_all_targets): New.
|
|
|
|
|
|
(proceed): Also consider resume target. Skip threads of inferiors
|
|
|
|
|
|
with no execution. Commit resumtion in all targets.
|
|
|
|
|
|
(start_remote): Pass current inferior to wait_for_inferior.
|
|
|
|
|
|
(infrun_thread_stop_requested): Consider target as well. Pass
|
|
|
|
|
|
thread_info pointer to clear_inline_frame_state instead of ptid.
|
|
|
|
|
|
(infrun_thread_thread_exit): Consider target as well.
|
|
|
|
|
|
(random_pending_event_thread): New inferior parameter. Use it.
|
|
|
|
|
|
(do_target_wait): Rename to ...
|
|
|
|
|
|
(do_target_wait_1): ... this. Add inferior parameter, and pass it
|
|
|
|
|
|
down.
|
|
|
|
|
|
(threads_are_resumed_pending_p, do_target_wait): New.
|
|
|
|
|
|
(prepare_for_detach): Adjust calls.
|
|
|
|
|
|
(wait_for_inferior): New inferior parameter. Handle it. Use
|
|
|
|
|
|
do_target_wait_1 instead of do_target_wait.
|
|
|
|
|
|
(fetch_inferior_event): Adjust. Switch to representative
|
|
|
|
|
|
inferior. Pass target down.
|
|
|
|
|
|
(set_last_target_status): Add process_stratum_target parameter.
|
|
|
|
|
|
Save target in global.
|
|
|
|
|
|
(get_last_target_status): Add process_stratum_target parameter and
|
|
|
|
|
|
handle it.
|
|
|
|
|
|
(nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
|
|
|
|
|
|
(context_switch): Check inferior_ptid == null_ptid before calling
|
|
|
|
|
|
inferior_thread().
|
|
|
|
|
|
(get_inferior_stop_soon): Pass down target.
|
|
|
|
|
|
(wait_one): Rename to ...
|
|
|
|
|
|
(poll_one_curr_target): ... this.
|
|
|
|
|
|
(struct wait_one_event): New.
|
|
|
|
|
|
(wait_one): New.
|
|
|
|
|
|
(stop_all_threads): Adjust.
|
|
|
|
|
|
(handle_no_resumed, handle_inferior_event): Adjust to consider the
|
|
|
|
|
|
event's target.
|
|
|
|
|
|
(switch_back_to_stepped_thread): Also consider target.
|
|
|
|
|
|
(print_stop_event): Update.
|
|
|
|
|
|
(normal_stop): Update. Also consider the resume target.
|
|
|
|
|
|
* infrun.h (wait_for_inferior): Remove declaration.
|
|
|
|
|
|
(user_visible_resume_target): New declaration.
|
|
|
|
|
|
(get_last_target_status, set_last_target_status): New
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
* inline-frame.c (clear_inline_frame_state(ptid_t)): Add
|
|
|
|
|
|
process_stratum_target parameter, and use it.
|
|
|
|
|
|
(clear_inline_frame_state (thread_info*)): New.
|
|
|
|
|
|
* inline-frame.c (clear_inline_frame_state(ptid_t)): Add
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
(clear_inline_frame_state (thread_info*)): Declare.
|
|
|
|
|
|
* linux-fork.c (delete_checkpoint_command): Pass target down to
|
|
|
|
|
|
find_thread_ptid.
|
|
|
|
|
|
(checkpoint_command): Adjust.
|
|
|
|
|
|
* linux-nat.c (linux_nat_target::follow_fork): Switch to thread
|
|
|
|
|
|
instead of just tweaking inferior_ptid.
|
|
|
|
|
|
(linux_nat_switch_fork): Pass target down to thread_change_ptid.
|
|
|
|
|
|
(exit_lwp): Pass target down to find_thread_ptid.
|
|
|
|
|
|
(attach_proc_task_lwp_callback): Pass target down to
|
|
|
|
|
|
add_thread/set_running/set_executing.
|
|
|
|
|
|
(linux_nat_target::attach): Pass target down to
|
|
|
|
|
|
thread_change_ptid.
|
|
|
|
|
|
(get_detach_signal): Pass target down to find_thread_ptid.
|
|
|
|
|
|
Consider last target status's target.
|
|
|
|
|
|
(linux_resume_one_lwp_throw, resume_lwp)
|
|
|
|
|
|
(linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
|
|
|
|
|
|
(stop_wait_callback, save_stop_reason, linux_nat_filter_event)
|
|
|
|
|
|
(linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
|
|
|
|
|
|
(linux_nat_target::async_wait_fd): New.
|
|
|
|
|
|
(linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
|
|
|
|
|
|
target down.
|
|
|
|
|
|
* linux-nat.h (linux_nat_target::async_wait_fd): Declare.
|
|
|
|
|
|
* linux-tdep.c (get_thread_arch_regcache): Pass target down.
|
|
|
|
|
|
* linux-thread-db.c (struct thread_db_info::process_target): New
|
|
|
|
|
|
field.
|
|
|
|
|
|
(add_thread_db_info): Save target.
|
|
|
|
|
|
(get_thread_db_info): New process_stratum_target parameter. Also
|
|
|
|
|
|
match target.
|
|
|
|
|
|
(delete_thread_db_info): New process_stratum_target parameter.
|
|
|
|
|
|
Also match target.
|
|
|
|
|
|
(thread_from_lwp): Adjust to pass down target.
|
|
|
|
|
|
(thread_db_notice_clone): Pass down target.
|
|
|
|
|
|
(check_thread_db_callback): Pass down target.
|
|
|
|
|
|
(try_thread_db_load_1): Always push the thread_db target.
|
|
|
|
|
|
(try_thread_db_load, record_thread): Pass target down.
|
|
|
|
|
|
(thread_db_target::detach): Pass target down. Always unpush the
|
|
|
|
|
|
thread_db target.
|
|
|
|
|
|
(thread_db_target::wait, thread_db_target::mourn_inferior): Pass
|
|
|
|
|
|
target down. Always unpush the thread_db target.
|
|
|
|
|
|
(find_new_threads_callback, thread_db_find_new_threads_2)
|
|
|
|
|
|
(thread_db_target::update_thread_list): Pass target down.
|
|
|
|
|
|
(thread_db_target::pid_to_str): Pass current inferior down.
|
|
|
|
|
|
(thread_db_target::get_thread_local_address): Pass target down.
|
|
|
|
|
|
(thread_db_target::resume, maintenance_check_libthread_db): Pass
|
|
|
|
|
|
target down.
|
|
|
|
|
|
* nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
|
|
|
|
|
|
* procfs.c (procfs_target::procfs_init_inferior): Declare.
|
|
|
|
|
|
(proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
|
|
|
|
|
|
(procfs_init_inferior): Rename to ...
|
|
|
|
|
|
(procfs_target::procfs_init_inferior): ... this and adjust.
|
|
|
|
|
|
(procfs_target::create_inferior, procfs_notice_thread)
|
|
|
|
|
|
(procfs_do_thread_registers): Adjust.
|
|
|
|
|
|
* ppc-fbsd-tdep.c: Include "inferior.h".
|
|
|
|
|
|
(ppcfbsd_get_thread_local_address): Pass down target.
|
|
|
|
|
|
* proc-service.c (ps_xfer_memory): Switch current inferior and
|
|
|
|
|
|
program space as well.
|
|
|
|
|
|
(get_ps_regcache): Pass target down.
|
|
|
|
|
|
* process-stratum-target.c
|
|
|
|
|
|
(process_stratum_target::thread_address_space)
|
|
|
|
|
|
(process_stratum_target::thread_architecture): Pass target down.
|
|
|
|
|
|
* process-stratum-target.h
|
|
|
|
|
|
(process_stratum_target::threads_executing): New field.
|
|
|
|
|
|
(as_process_stratum_target): New.
|
|
|
|
|
|
* ravenscar-thread.c
|
|
|
|
|
|
(ravenscar_thread_target::update_inferior_ptid): Pass target down.
|
|
|
|
|
|
(ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
|
|
|
|
|
|
down.
|
|
|
|
|
|
* record-btrace.c (record_btrace_target::info_record): Adjust.
|
|
|
|
|
|
(record_btrace_target::record_method)
|
|
|
|
|
|
(record_btrace_target::record_is_replaying)
|
|
|
|
|
|
(record_btrace_target::fetch_registers)
|
|
|
|
|
|
(get_thread_current_frame_id, record_btrace_target::resume)
|
|
|
|
|
|
(record_btrace_target::wait, record_btrace_target::stop): Pass
|
|
|
|
|
|
target down.
|
|
|
|
|
|
* record-full.c (record_full_wait_1): Switch to event thread.
|
|
|
|
|
|
Pass target down.
|
|
|
|
|
|
* regcache.c (regcache::regcache)
|
|
|
|
|
|
(get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
|
|
|
|
|
|
process_stratum_target parameter and handle it.
|
|
|
|
|
|
(current_thread_target): New global.
|
|
|
|
|
|
(get_thread_regcache): Add process_stratum_target parameter and
|
|
|
|
|
|
handle it. Switch inferior before calling target method.
|
|
|
|
|
|
(get_thread_regcache): Pass target down.
|
|
|
|
|
|
(get_thread_regcache_for_ptid): Pass target down.
|
|
|
|
|
|
(registers_changed_ptid): Add process_stratum_target parameter and
|
|
|
|
|
|
handle it.
|
|
|
|
|
|
(registers_changed_thread, registers_changed): Pass target down.
|
|
|
|
|
|
(test_get_thread_arch_aspace_regcache): New.
|
|
|
|
|
|
(current_regcache_test): Define a couple local test_target_ops
|
|
|
|
|
|
instances and use them for testing.
|
|
|
|
|
|
(readwrite_regcache): Pass process_stratum_target parameter.
|
|
|
|
|
|
(cooked_read_test, cooked_write_test): Pass mock_target down.
|
|
|
|
|
|
* regcache.h (get_thread_regcache, get_thread_arch_regcache)
|
|
|
|
|
|
(get_thread_arch_aspace_regcache): Add process_stratum_target
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(regcache::target): New method.
|
|
|
|
|
|
(regcache::regcache, regcache::get_thread_arch_aspace_regcache)
|
|
|
|
|
|
(regcache::registers_changed_ptid): Add process_stratum_target
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(regcache::m_target): New field.
|
|
|
|
|
|
(registers_changed_ptid): Add process_stratum_target parameter.
|
|
|
|
|
|
* remote.c (remote_state::supports_vCont_probed): New field.
|
|
|
|
|
|
(remote_target::async_wait_fd): New method.
|
|
|
|
|
|
(remote_unpush_and_throw): Add remote_target parameter.
|
|
|
|
|
|
(get_current_remote_target): Adjust.
|
|
|
|
|
|
(remote_target::remote_add_inferior): Push target.
|
|
|
|
|
|
(remote_target::remote_add_thread)
|
|
|
|
|
|
(remote_target::remote_notice_new_inferior)
|
|
|
|
|
|
(get_remote_thread_info): Pass target down.
|
|
|
|
|
|
(remote_target::update_thread_list): Skip threads of inferiors
|
|
|
|
|
|
bound to other targets. (remote_target::close): Don't discard
|
|
|
|
|
|
inferiors. (remote_target::add_current_inferior_and_thread)
|
|
|
|
|
|
(remote_target::process_initial_stop_replies)
|
|
|
|
|
|
(remote_target::start_remote)
|
|
|
|
|
|
(remote_target::remote_serial_quit_handler): Pass down target.
|
|
|
|
|
|
(remote_target::remote_unpush_target): New remote_target
|
|
|
|
|
|
parameter. Unpush the target from all inferiors.
|
|
|
|
|
|
(remote_target::remote_unpush_and_throw): New remote_target
|
|
|
|
|
|
parameter. Pass it down.
|
|
|
|
|
|
(remote_target::open_1): Check whether the current inferior has
|
|
|
|
|
|
execution instead of checking whether any inferior is live. Pass
|
|
|
|
|
|
target down.
|
|
|
|
|
|
(remote_target::remote_detach_1): Pass down target. Use
|
|
|
|
|
|
remote_unpush_target.
|
|
|
|
|
|
(extended_remote_target::attach): Pass down target.
|
|
|
|
|
|
(remote_target::remote_vcont_probe): Set supports_vCont_probed.
|
|
|
|
|
|
(remote_target::append_resumption): Pass down target.
|
|
|
|
|
|
(remote_target::append_pending_thread_resumptions)
|
|
|
|
|
|
(remote_target::remote_resume_with_hc, remote_target::resume)
|
|
|
|
|
|
(remote_target::commit_resume): Pass down target.
|
|
|
|
|
|
(remote_target::remote_stop_ns): Check supports_vCont_probed.
|
|
|
|
|
|
(remote_target::interrupt_query)
|
|
|
|
|
|
(remote_target::remove_new_fork_children)
|
|
|
|
|
|
(remote_target::check_pending_events_prevent_wildcard_vcont)
|
|
|
|
|
|
(remote_target::remote_parse_stop_reply)
|
|
|
|
|
|
(remote_target::process_stop_reply): Pass down target.
|
|
|
|
|
|
(first_remote_resumed_thread): New remote_target parameter. Pass
|
|
|
|
|
|
it down.
|
|
|
|
|
|
(remote_target::wait_as): Pass down target.
|
|
|
|
|
|
(unpush_and_perror): New remote_target parameter. Pass it down.
|
|
|
|
|
|
(remote_target::readchar, remote_target::remote_serial_write)
|
|
|
|
|
|
(remote_target::getpkt_or_notif_sane_1)
|
|
|
|
|
|
(remote_target::kill_new_fork_children, remote_target::kill): Pass
|
|
|
|
|
|
down target.
|
|
|
|
|
|
(remote_target::mourn_inferior): Pass down target. Use
|
|
|
|
|
|
remote_unpush_target.
|
|
|
|
|
|
(remote_target::core_of_thread)
|
|
|
|
|
|
(remote_target::remote_btrace_maybe_reopen): Pass down target.
|
|
|
|
|
|
(remote_target::pid_to_exec_file)
|
|
|
|
|
|
(remote_target::thread_handle_to_thread_info): Pass down target.
|
|
|
|
|
|
(remote_target::async_wait_fd): New.
|
|
|
|
|
|
* riscv-fbsd-tdep.c: Include "inferior.h".
|
|
|
|
|
|
(riscv_fbsd_get_thread_local_address): Pass down target.
|
|
|
|
|
|
* sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
|
|
|
|
|
|
* sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
|
|
|
|
|
|
(ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
|
|
|
|
|
|
Adjust.
|
|
|
|
|
|
* solib-spu.c (spu_skip_standalone_loader): Pass down target.
|
|
|
|
|
|
* solib-svr4.c (enable_break): Pass down target.
|
|
|
|
|
|
* spu-multiarch.c (parse_spufs_run): Pass down target.
|
|
|
|
|
|
* spu-tdep.c (spu2ppu_sniffer): Pass down target.
|
|
|
|
|
|
* target-delegates.c: Regenerate.
|
|
|
|
|
|
* target.c (g_target_stack): Delete.
|
|
|
|
|
|
(current_top_target): Return the current inferior's top target.
|
|
|
|
|
|
(target_has_execution_1): Refer to the passed-in inferior's top
|
|
|
|
|
|
target.
|
|
|
|
|
|
(target_supports_terminal_ours): Check whether the initial
|
|
|
|
|
|
inferior was already created.
|
|
|
|
|
|
(decref_target): New.
|
|
|
|
|
|
(target_stack::push): Incref/decref the target.
|
|
|
|
|
|
(push_target, push_target, unpush_target): Adjust.
|
|
|
|
|
|
(target_stack::unpush): Defref target.
|
|
|
|
|
|
(target_is_pushed): Return bool. Adjust to refer to the current
|
|
|
|
|
|
inferior's target stack.
|
|
|
|
|
|
(dispose_inferior): Delete, and inline parts ...
|
|
|
|
|
|
(target_preopen): ... here. Only dispose of the current inferior.
|
|
|
|
|
|
(target_detach): Hold strong target reference while detaching.
|
|
|
|
|
|
Pass target down.
|
|
|
|
|
|
(target_thread_name): Add assertion.
|
|
|
|
|
|
(target_resume): Pass down target.
|
|
|
|
|
|
(target_ops::beneath, find_target_at): Adjust to refer to the
|
|
|
|
|
|
current inferior's target stack.
|
|
|
|
|
|
(get_dummy_target): New.
|
|
|
|
|
|
(target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
|
|
|
|
|
|
has a thread running.
|
|
|
|
|
|
(initialize_targets): Rename to ...
|
|
|
|
|
|
(_initialize_target): ... this.
|
|
|
|
|
|
* target.h: Include "gdbsupport/refcounted-object.h".
|
|
|
|
|
|
(struct target_ops): Inherit refcounted_object.
|
|
|
|
|
|
(target_ops::shortname, target_ops::longname): Make const.
|
|
|
|
|
|
(target_ops::async_wait_fd): New method.
|
|
|
|
|
|
(decref_target): Declare.
|
|
|
|
|
|
(struct target_ops_ref_policy): New.
|
|
|
|
|
|
(target_ops_ref): New typedef.
|
|
|
|
|
|
(get_dummy_target): Declare function.
|
|
|
|
|
|
(target_is_pushed): Return bool.
|
|
|
|
|
|
* thread-iter.c (all_matching_threads_iterator::m_inf_matches)
|
|
|
|
|
|
(all_matching_threads_iterator::all_matching_threads_iterator):
|
|
|
|
|
|
Handle filter target.
|
|
|
|
|
|
* thread-iter.h (struct all_matching_threads_iterator, struct
|
|
|
|
|
|
all_matching_threads_range, class all_non_exited_threads_range):
|
|
|
|
|
|
Filter by target too. Remove explicit.
|
|
|
|
|
|
* thread.c (threads_executing): Delete.
|
|
|
|
|
|
(inferior_thread): Pass down current inferior.
|
|
|
|
|
|
(clear_thread_inferior_resources): Pass down thread pointer
|
|
|
|
|
|
instead of ptid_t.
|
|
|
|
|
|
(add_thread_silent, add_thread_with_info, add_thread): Add
|
|
|
|
|
|
process_stratum_target parameter. Use it for thread and inferior
|
|
|
|
|
|
searches.
|
|
|
|
|
|
(is_current_thread): New.
|
|
|
|
|
|
(thread_info::deletable): Use it.
|
|
|
|
|
|
(find_thread_ptid, thread_count, in_thread_list)
|
|
|
|
|
|
(thread_change_ptid, set_resumed, set_running): New
|
|
|
|
|
|
process_stratum_target parameter. Pass it down.
|
|
|
|
|
|
(set_executing): New process_stratum_target parameter. Pass it
|
|
|
|
|
|
down. Adjust reference to 'threads_executing'.
|
|
|
|
|
|
(threads_are_executing): New process_stratum_target parameter.
|
|
|
|
|
|
Adjust reference to 'threads_executing'.
|
|
|
|
|
|
(set_stop_requested, finish_thread_state): New
|
|
|
|
|
|
process_stratum_target parameter. Pass it down.
|
|
|
|
|
|
(switch_to_thread): Also match inferior.
|
|
|
|
|
|
(switch_to_thread): New process_stratum_target parameter. Pass it
|
|
|
|
|
|
down.
|
|
|
|
|
|
(update_threads_executing): Reimplement.
|
|
|
|
|
|
* top.c (quit_force): Pop targets from all inferior.
|
|
|
|
|
|
(gdb_init): Don't call initialize_targets.
|
|
|
|
|
|
* windows-nat.c (windows_nat_target) <get_windows_debug_event>:
|
|
|
|
|
|
Declare.
|
|
|
|
|
|
(windows_add_thread, windows_delete_thread): Adjust.
|
|
|
|
|
|
(get_windows_debug_event): Rename to ...
|
|
|
|
|
|
(windows_nat_target::get_windows_debug_event): ... this. Adjust.
|
|
|
|
|
|
* tracefile-tfile.c (tfile_target_open): Pass down target.
|
|
|
|
|
|
* gdbsupport/common-gdbthread.h (struct process_stratum_target):
|
|
|
|
|
|
Forward declare.
|
|
|
|
|
|
(switch_to_thread): Add process_stratum_target parameter.
|
|
|
|
|
|
* mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
|
|
|
|
|
|
parameter. Use it.
|
|
|
|
|
|
(mi_on_resume): Pass target down.
|
|
|
|
|
|
* nat/fork-inferior.c (startup_inferior): Add
|
|
|
|
|
|
process_stratum_target parameter. Pass it down.
|
|
|
|
|
|
* nat/fork-inferior.h (startup_inferior): Add
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
* python/py-threadevent.c (py_get_event_thread): Pass target down.
|
|
|
|
|
|
|
2020-01-10 21:05:54 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::start_remote): Don't set inferior_ptid
|
|
|
|
|
|
directly. Instead find the first thread in the thread list and
|
|
|
|
|
|
use switch_to_thread.
|
|
|
|
|
|
|
Fix reconnecting to a gdbserver already debugging multiple processes, I
The multi-target patch will change the remote target's behavior when:
- the current inferior is connected to an extended-remote target.
- the current inferior is attached to any process.
- some other inferior than than the current one is live.
In current master, we get:
(gdb) tar extended-remote :9999
A program is being debugged already. Kill it? (y or n)
While after multi-target, since each inferior may have its own target
connection, we'll get:
(gdb) tar extended-remote :9999
Already connected to a remote target. Disconnect? (y or n)
That change made gdb.server/extended-remote-restart.exp expose a gdb
bug, because it made "target remote", via gdb_reconnect, just
disconnect from the previous connection, while in current master that
command would kill the inferior before disconnecting. In turn, that
would make a multi-target gdb find processes already running under
control of gdbserver as soon as it reconnects, while in current master
there is never any process around when gdb reconnects, since they'd
all been killed prior to disconnection.
The bug this exposed is that remote_target::remote_add_inferior was
always reusing current_inferior() for the new process, even if the
current inferior was already bound to a process. In the testcase's
case, when we reconnect, the remote is debugging two processes. So
we'd bind the first remote process to the empty current inferior the
first time, and then bind the second remote process to the same
inferior again, essencially losing track of the first process. That
resulted in failed assertions when we look up the inferior for the
first process by PID. The fix is to still prefer binding to the
current inferior (so that plain "target remote" keeps doing what you'd
expect), but not reuse the current inferior if it is already bound to
a process.
This patch tweaks the test to explicitly disconnect before
reconnecting, to avoid GDB killing processes, thus making current GDB
behave the same as it will behave when the multi-target work lands.
That change alone without the GDB fix exposes the bug like so:
(gdb) PASS: gdb.server/extended-remote-restart.exp: kill: 0, follow-child 0: disconnect
target extended-remote localhost:2350
Remote debugging using localhost:2350
src/gdb/thread.c:93: internal-error: thread_info* inferior_thread(): Assertion `tp' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n)
The original bug that the testcase was written for was related to
killing, (git 9d4a934ce604 ("gdb: Fix assert for extended-remote
target (PR gdb/18050)")), but since the testcase tries reconnecting
with both explicitly killing and not explicitly killing, I think we're
covering the original bug with this testcase change.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* remote.c (remote_target::remote_add_inferior): Don't bind a
process to the current inferior if the current inferior is already
bound to a process.
gdb/testsuite/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* gdb.server/extended-remote-restart.exp (test_reload): Explicitly
disconnect before reconnecting.
2020-01-10 21:05:53 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::remote_add_inferior): Don't bind a
|
|
|
|
|
|
process to the current inferior if the current inferior is already
|
|
|
|
|
|
bound to a process.
|
|
|
|
|
|
|
2020-01-10 21:05:52 +01:00
|
|
|
|
2020-01-10 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
|
|
|
|
|
|
Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
|
|
|
|
|
|
If no process is specified, return null_ptid instead of
|
|
|
|
|
|
inferior_ptid.
|
|
|
|
|
|
(remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
|
|
|
|
|
|
TARGET_WAITKIND_SIGNALLED with no pid.
|
|
|
|
|
|
|
Tweak handling of remote errors in response to resumption packet
With current master, on a Fedora 27 machine with a kernel with buggy
watchpoint support, I see:
(gdb) PASS: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: hardware breakpoints work
continue
Continuing.
warning: Remote failure reply: E01
Remote communication error. Target disconnected.: Connection reset by peer.
(gdb) FAIL: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: watchpoints work
continue
The program is not being run.
(gdb) FAIL: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: breakpoint after the first fork (the program is no longer running)
The FAILs themselves aren't what's interesting here. What is
interesting is that with the main multi-target patch applied, I was getting this:
(gdb) PASS: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: hardware breakpoints work
continue
Continuing.
warning: Remote failure reply: E01
/home/pedro/brno/pedro/gdb/binutils-gdb-2/build/../src/gdb/inferior.c:285: internal-error: inferior* find_inferior_pid(process_stratum_target*, int): Assertion `pid != 0' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) FAIL: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: watchpoints work (GDB internal error)
The problem is that in remote_target::wait_as, we're hitting this:
switch (buf[0])
{
case 'E': /* Error of some sort. */
/* We're out of sync with the target now. Did it continue or
not? Not is more likely, so report a stop. */
rs->waiting_for_stop_reply = 0;
warning (_("Remote failure reply: %s"), buf);
status->kind = TARGET_WAITKIND_STOPPED;
status->value.sig = GDB_SIGNAL_0;
break;
which leaves event_ptid as null_ptid. At the end of the function, we then reach:
else if (status->kind != TARGET_WAITKIND_EXITED
&& status->kind != TARGET_WAITKIND_SIGNALLED)
{
if (event_ptid != null_ptid)
record_currthread (rs, event_ptid);
else
event_ptid = inferior_ptid; <<<<< here
}
and the trouble is that with the multi-target patch, we'll get here
with inferior_ptid as null_ptid too. That is done exactly to find
these implicit assumptions that inferior_ptid is a good choice for
default thread, which isn't generaly true.
I first thought of fixing this in the "case 'E'" path, but, given that
this "event_ptid = inferior_ptid" path is also taken when the remote
target does not support threads at all, no thread-related packets or
extensions, it's better to fix it in latter path, to handle all
scenarios that miss reporting a thread.
That's what this patch does.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* remote.c (first_remote_resumed_thread): New.
(remote_target::wait_as): Use it as default event_ptid instead of
inferior_ptid.
2020-01-10 21:05:52 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (first_remote_resumed_thread): New.
|
|
|
|
|
|
(remote_target::wait_as): Use it as default event_ptid instead of
|
|
|
|
|
|
inferior_ptid.
|
|
|
|
|
|
|
2020-01-10 21:05:51 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
|
|
|
|
|
|
|
2020-01-10 21:05:50 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
|
|
|
|
|
|
not -1.
|
|
|
|
|
|
|
2020-01-10 21:05:49 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
|
|
|
|
|
|
ptid to get_last_target_status.
|
|
|
|
|
|
* break-catch-syscall.c (print_it_catch_syscall): Don't pass a
|
|
|
|
|
|
ptid to get_last_target_status.
|
|
|
|
|
|
* infcmd.c (continue_command): Don't pass a target_waitstatus to
|
|
|
|
|
|
get_last_target_status.
|
|
|
|
|
|
(info_program_command): Don't pass a target_waitstatus to
|
|
|
|
|
|
get_last_target_status.
|
|
|
|
|
|
* infrun.c (init_wait_for_inferior): Use
|
|
|
|
|
|
nullify_last_target_wait_ptid.
|
|
|
|
|
|
(get_last_target_status): Handle nullptr arguments.
|
|
|
|
|
|
(nullify_last_target_wait_ptid): Clear target_last_waitstatus.
|
|
|
|
|
|
(print_stop_event): Don't pass a ptid to get_last_target_status.
|
|
|
|
|
|
(normal_stop): Don't pass a ptid to get_last_target_status.
|
|
|
|
|
|
* infrun.h (get_last_target_status, set_last_target_status): Move
|
|
|
|
|
|
comments here and update.
|
|
|
|
|
|
(nullify_last_target_wait_ptid): Declare.
|
|
|
|
|
|
* linux-fork.c (fork_load_infrun_state): Remove local extern
|
|
|
|
|
|
declaration of nullify_last_target_wait_ptid.
|
|
|
|
|
|
* linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
|
|
|
|
|
|
to get_last_target_status.
|
|
|
|
|
|
|
2020-01-10 21:05:48 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbthread.h (scoped_restore_current_thread)
|
|
|
|
|
|
<dont_restore, restore, m_dont_restore>: Declare.
|
|
|
|
|
|
* thread.c (thread_alive): Add assertion. Return bool.
|
|
|
|
|
|
(switch_to_thread_if_alive): New.
|
|
|
|
|
|
(prune_threads): Switch inferior/thread.
|
|
|
|
|
|
(print_thread_info_1): Switch thread before calling target methods.
|
|
|
|
|
|
(scoped_restore_current_thread::restore): New, factored out from
|
|
|
|
|
|
...
|
|
|
|
|
|
(scoped_restore_current_thread::~scoped_restore_current_thread):
|
|
|
|
|
|
... this.
|
|
|
|
|
|
(scoped_restore_current_thread::scoped_restore_current_thread):
|
|
|
|
|
|
Add assertion.
|
|
|
|
|
|
(thread_apply_all_command, thread_select): Use
|
|
|
|
|
|
switch_to_thread_if_alive.
|
|
|
|
|
|
* infrun.c (proceed, restart_threads, handle_signal_stop)
|
|
|
|
|
|
(switch_back_to_stepped_thread): Switch current thread before
|
|
|
|
|
|
calling target methods.
|
|
|
|
|
|
|
2020-01-10 21:05:47 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* inferior.c (switch_to_inferior_no_thread): New function,
|
|
|
|
|
|
factored out from ...
|
|
|
|
|
|
(inferior_command): ... here.
|
|
|
|
|
|
* inferior.h (switch_to_inferior_no_thread): Declare.
|
|
|
|
|
|
* mi/mi-main.c (run_one_inferior): Use
|
|
|
|
|
|
switch_to_inferior_no_thread.
|
|
|
|
|
|
|
Delete unnecessary code from kill_command
I believe this comment:
/* Killing off the inferior can leave us with a core file. If
so, print the state we are left in. */
Referred to the fact that a decade ago, by design, GDB would let you
type "run" when debugging a core dump, keeping the core open. That
"run" would push a process_stratum target on the target stack for the
live process, and, the core would remain open -- we used to have a
core_stratum. When the live process was killed/detached or exited,
GDB would go back to debugging the core, since the core_stratum target
was now at the top of the stack. That design had a number of
problems, see here for example:
https://sourceware.org/ml/gdb-patches/2008-08/msg00290.html
In 2010, core_stratum was finaly eliminated and cores now have
process_stratum too, with commit c0edd9edadfe ("Make core files the
process_stratum."). Pushing a live process on the stack while you're
debugging a core discards the core completely.
I also thought that this might be in use with checkpoints, but it does
not -- "kill" when you have multiple checkpoints kills all the
checkpoints.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* infcmd.c (kill_command): Remove dead code.
2020-01-10 21:05:46 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infcmd.c (kill_command): Remove dead code.
|
|
|
|
|
|
|
Don't check target is running in remote_target::mourn_inferior
I believe the tail end of remote_target::mourn_inferior is broken, and
it's been broken for too long to even bother trying to fix. Most
probably nobody needs it. If the code is reached and we find the
target is running, we'd need to resync the thread list, at least,
since generic_mourn_inferior got rid of all the threads in the
inferior, otherwise, we'd hit an assertion on the next call to
inferior_thread(), for example. A "correct" fix would probably
involve restarting the whole remote_target::start_remote requence,
exactly as if we had completely disconnected and reconnected from
scratch.
Note that regular stub debugging usually uses plain target remote, but
this code is only reachable in target extended-mode:
- The !remote_multi_process_p check means that it's only reacheable if
the stub does not support multi-process. I.e., there can only ever
be one live process.
- remote_target::mourn_inferior has this at the top:
/* In 'target remote' mode with one inferior, we close the connection. */
if (!rs->extended && number_of_live_inferiors () <= 1)
{
unpush_target (this);
/* remote_close takes care of doing most of the clean up. */
generic_mourn_inferior ();
return;
}
Which means that if we only had one live inferior (which for our
case, must be true), we'll have closed the connection already,
unless we're in extended-remote mode.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* remote.c (remote_target::mourn_inferior): No longer check
whether the target is running.
2020-01-10 21:05:45 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::mourn_inferior): No longer check
|
|
|
|
|
|
whether the target is running.
|
|
|
|
|
|
|
Make target_ops::has_execution take an 'inferior *' instead of a ptid_t
With the multi-target work, each inferior will have its own target
stack, so to call a target method, we'll need to make sure that the
inferior in question is the current one, otherwise target->beneath()
calls will find the target beneath in the wrong inferior.
In some places, it's much more convenient to be able to check whether
an inferior has execution without having to switch to it in order to
call target_has_execution on the right inferior/target stack, to avoid
side effects with switching inferior/thread/program space.
The current target_ops::has_execution method takes a ptid_t as
parameter, which, in a multi-target world, isn't sufficient to
identify the target. This patch prepares to address that, by changing
the parameter to an inferior pointer instead. From the inferior,
we'll be able to query its target stack to tell which target is
beneath.
Also adds a new inferior::has_execution() method to make callers a bit
more natural to read.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* corelow.c (core_target::has_execution): Change parameter type to
inferior pointer.
* inferior.c (number_of_live_inferiors): Use
inferior::has_execution instead of target_has_execution_1.
* inferior.h (inferior::has_execution): New.
* linux-thread-db.c (thread_db_target::update_thread_list): Use
inferior::has_execution instead of target_has_execution_1.
* process-stratum-target.c
(process_stratum_target::has_execution): Change parameter type to
inferior pointer. Check the inferior's PID instead of
inferior_ptid.
* process-stratum-target.h
(process_stratum_target::has_execution): Change parameter type to
inferior pointer.
* record-full.c (record_full_core_target::has_execution): Change
parameter type to inferior pointer.
* target.c (target_has_execution_1): Change parameter type to
inferior pointer.
(target_has_execution_current): Adjust.
* target.h (target_ops::has_execution): Change parameter type to
inferior pointer.
(target_has_execution_1): Change parameter type to inferior
pointer. Change return type to bool.
* tracefile.h (tracefile_target::has_execution): Change parameter
type to inferior pointer.
2020-01-10 21:05:44 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* corelow.c (core_target::has_execution): Change parameter type to
|
|
|
|
|
|
inferior pointer.
|
|
|
|
|
|
* inferior.c (number_of_live_inferiors): Use
|
|
|
|
|
|
inferior::has_execution instead of target_has_execution_1.
|
|
|
|
|
|
* inferior.h (inferior::has_execution): New.
|
|
|
|
|
|
* linux-thread-db.c (thread_db_target::update_thread_list): Use
|
|
|
|
|
|
inferior::has_execution instead of target_has_execution_1.
|
|
|
|
|
|
* process-stratum-target.c
|
|
|
|
|
|
(process_stratum_target::has_execution): Change parameter type to
|
|
|
|
|
|
inferior pointer. Check the inferior's PID instead of
|
|
|
|
|
|
inferior_ptid.
|
|
|
|
|
|
* process-stratum-target.h
|
|
|
|
|
|
(process_stratum_target::has_execution): Change parameter type to
|
|
|
|
|
|
inferior pointer.
|
|
|
|
|
|
* record-full.c (record_full_core_target::has_execution): Change
|
|
|
|
|
|
parameter type to inferior pointer.
|
|
|
|
|
|
* target.c (target_has_execution_1): Change parameter type to
|
|
|
|
|
|
inferior pointer.
|
|
|
|
|
|
(target_has_execution_current): Adjust.
|
|
|
|
|
|
* target.h (target_ops::has_execution): Change parameter type to
|
|
|
|
|
|
inferior pointer.
|
|
|
|
|
|
(target_has_execution_1): Change parameter type to inferior
|
|
|
|
|
|
pointer. Change return type to bool.
|
|
|
|
|
|
* tracefile.h (tracefile_target::has_execution): Change parameter
|
|
|
|
|
|
type to inferior pointer.
|
|
|
|
|
|
|
2020-01-10 21:05:43 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* exceptions.c (print_flush): Remove current_top_target() check.
|
|
|
|
|
|
|
2020-01-10 21:05:42 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (show_remote_exec_file): Show the current inferior's
|
|
|
|
|
|
exec-file instead of the command variable's value.
|
|
|
|
|
|
|
2020-01-10 21:05:41 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* record-full.c (record_full_resume_ptid): New global.
|
|
|
|
|
|
(record_full_target::resume): Set it.
|
|
|
|
|
|
(record_full_wait_1): Use record_full_resume_ptid instead of
|
|
|
|
|
|
inferior_ptid.
|
|
|
|
|
|
|
Preserve selected thread in all-stop w/ background execution
In non-stop mode, if you resume the program in the background (with
"continue&", for example), then gdb makes sure to not switch the
current thread behind your back. That means that you can be sure that
the commands you type apply to the thread you selected, even if some
other thread that was running in the background hits some event just
while you're typing.
In all-stop mode, however, if you resume the program in the
background, gdb let's the current thread switch behind your back.
This is bogus, of course. All-stop and non-stop background
resumptions should behave the same.
This patch fixes that, and adds a testcase that exposes the bad
behavior in current master.
The fork-running-state.exp changes are necessary because that
preexisting testcase was expecting the old behavior:
Before:
continue &
Continuing.
(gdb)
[Attaching after process 8199 fork to child process 8203]
[New inferior 2 (process 8203)]
info threads
Id Target Id Frame
1.1 process 8199 "fork-running-st" (running)
* 2.1 process 8203 "fork-running-st" (running)
(gdb)
After:
continue &
Continuing.
(gdb)
[Attaching after process 24660 fork to child process 24664]
[New inferior 2 (process 24664)]
info threads
Id Target Id Frame
* 1.1 process 24660 "fork-running-st" (running)
2.1 process 24664 "fork-running-st" (running)
(gdb)
Here we see that before this patch GDB switches current inferior to
the new inferior behind the user's back, as a side effect of handling
the fork.
The delete_exited_threads call in inferior_appeared is there to fix an
issue that Baris found in a previous version of this patch. The
fetch_inferior_event change increases the refcount of the current
thread, and in case the fetched inferior event denotes a thread exit,
the thread will not be deleted right away. A non-deleted but exited
thread stays in the inferior's thread list. This, in turn, causes the
"init_thread_list" call in inferior.c to be skipped. A consequence is
that the global thread ID counter is not restarted if the current
thread exits, and then the inferior is restarted:
(gdb) start
Temporary breakpoint 1 at 0x4004d6: file main.c, line 21.
Starting program: /tmp/main
Temporary breakpoint 1, main () at main.c:21
21 foo ();
(gdb) info threads -gid
Id GId Target Id Frame
* 1 1 process 16106 "main" main () at main.c:21
(gdb) c
Continuing.
[Inferior 1 (process 16106) exited normally]
(gdb) start
Temporary breakpoint 2 at 0x4004d6: file main.c, line 21.
Starting program: /tmp/main
Temporary breakpoint 2, main () at main.c:21
21 foo ();
(gdb) info threads -gid
Id GId Target Id Frame
* 1 2 process 16138 "main" main () at main.c:21
^^^
Notice that GId == 2 above. It should have been "1" instead.
The new tids-git-reset.exp testcase exercises the problem above.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* gdbthread.h (scoped_restore_current_thread)
<dont_restore, restore, m_dont_restore>: Declare.
* thread.c (thread_alive): Add assertion. Return bool.
(switch_to_thread_if_alive): New.
(prune_threads): Switch inferior/thread.
(print_thread_info_1): Switch thread before calling target methods.
(scoped_restore_current_thread::restore): New, factored out from
...
(scoped_restore_current_thread::~scoped_restore_current_thread):
... this.
(scoped_restore_current_thread::scoped_restore_current_thread):
Add assertion.
(thread_apply_all_command, thread_select): Use
switch_to_thread_if_alive.
gdb/testsuite/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* gdb.base/fork-running-state.exp (do_test): Adjust expected
output.
* gdb.threads/async.c: New.
* gdb.threads/async.exp: New.
* gdb.multi/tids-gid-reset.c: New.
* gdb.multi/tids-gid-reset.exp: New.
2020-01-10 21:05:41 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbthread.h (scoped_restore_current_thread)
|
|
|
|
|
|
<dont_restore, restore, m_dont_restore>: Declare.
|
|
|
|
|
|
* thread.c (thread_alive): Add assertion. Return bool.
|
|
|
|
|
|
(switch_to_thread_if_alive): New.
|
|
|
|
|
|
(prune_threads): Switch inferior/thread.
|
|
|
|
|
|
(print_thread_info_1): Switch thread before calling target methods.
|
|
|
|
|
|
(scoped_restore_current_thread::restore): New, factored out from
|
|
|
|
|
|
...
|
|
|
|
|
|
(scoped_restore_current_thread::~scoped_restore_current_thread):
|
|
|
|
|
|
... this.
|
|
|
|
|
|
(scoped_restore_current_thread::scoped_restore_current_thread):
|
|
|
|
|
|
Add assertion.
|
|
|
|
|
|
(thread_apply_all_command, thread_select): Use
|
|
|
|
|
|
switch_to_thread_if_alive.
|
|
|
|
|
|
|
2020-01-10 20:30:28 +01:00
|
|
|
|
2020-01-10 George Barrett <bob@bob131.so>
|
|
|
|
|
|
|
|
|
|
|
|
* stap-probe.c (stap_modify_semaphore): Don't check for null
|
|
|
|
|
|
semaphores.
|
|
|
|
|
|
(stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
|
|
|
|
|
|
for null semaphores.
|
|
|
|
|
|
|
2020-01-07 12:39:17 +01:00
|
|
|
|
2020-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
|
|
|
|
|
|
all source windows, and maintain horizontal scroll status while
|
|
|
|
|
|
doing so.
|
|
|
|
|
|
|
2019-12-23 00:52:56 +01:00
|
|
|
|
2020-01-09 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR tui/18932:
|
|
|
|
|
|
* tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
|
|
|
|
|
|
update_source_window, not print_source_lines.
|
|
|
|
|
|
|
2020-01-07 01:41:08 +01:00
|
|
|
|
2020-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui.c (tui_enable): Register tui hooks after calling
|
|
|
|
|
|
tui_display_main.
|
|
|
|
|
|
|
2019-12-18 19:06:43 +01:00
|
|
|
|
2020-01-09 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
|
|
|
|
|
|
|
2020-01-08 22:55:03 +01:00
|
|
|
|
2020-01-08 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* thread.c (print_thread_info_1): Fix indentation.
|
|
|
|
|
|
|
2020-01-08 02:10:40 +01:00
|
|
|
|
2020-01-09 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* symtab.c (general_symbol_info::compute_and_set_names): Move the
|
|
|
|
|
|
unique_xmalloc_ptr outside the if to always free the demangled name.
|
|
|
|
|
|
|
Change section_offsets to a std::vector
This changes section_offsets to be specialization of a std::vector and
updates all the users. It also removes the ANOFFSET and
SIZEOF_N_SECTION_OFFSETS macros.
Most of this is just a generic sort of cleanup, that reduces the
number of lines of code. However, a couple spots were doing weird
things.
objfile_relocate did:
- std::vector<struct section_offsets>
- new_debug_offsets (SIZEOF_N_SECTION_OFFSETS (debug_objfile->num_sections));
... which seems to greatly over-estimate the number of elements
needed.
This appeared in set_objfile_default_section_offset:
- std::vector<struct section_offsets> offsets (objf->num_sections,
- { { offset } });
... which makes sense due to type safety, but is also actively
confusing given that section_offsets was previously also a kind of
vector type.
Tested on x86-64 Fedora 30.
gdb/ChangeLog
2020-01-08 Tom Tromey <tromey@adacore.com>
* xcoffread.c (enter_line_range, read_xcoff_symtab)
(process_xcoff_symbol, xcoff_symfile_offsets): Update.
* symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
(struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
Remove.
(section_offsets): New typedef.
* symtab.c (fixup_section, get_msymbol_address): Update.
* symmisc.c (dump_msymbols): Update.
* symfile.h (relative_addr_info_to_section_offsets)
(symfile_map_offsets_to_segments): Update.
* symfile.c (build_section_addr_info_from_objfile)
(init_objfile_sect_indices): Update.
(struct place_section_arg): Change type of "offsets".
(place_section): Update.
(relative_addr_info_to_section_offsets): Change type of
"section_offsets". Remove "num_sections" parameter.
(default_symfile_offsets, syms_from_objfile_1)
(set_objfile_default_section_offset): Update.
(reread_symbols): No need to preserve section offsets by hand.
(symfile_map_offsets_to_segments): Change type of "offsets".
* stap-probe.c (relocate_address): Update.
* stabsread.h (process_one_symbol): Update.
* solib-target.c (struct lm_info_target) <offsets>: Change type.
(solib_target_relocate_section_addresses): Update.
* solib-svr4.c (enable_break, svr4_relocate_main_executable):
Update.
* solib-frv.c (frv_relocate_main_executable): Update.
* solib-dsbt.c (dsbt_relocate_main_executable): Update.
* solib-aix.c (solib_aix_get_section_offsets): Change return
type.
(solib_aix_solib_create_inferior_hook): Update.
* remote.c (remote_target::get_offsets): Update.
* psymtab.c (find_pc_sect_psymtab): Update.
* psympriv.h (struct partial_symbol) <address, text_low,
text_high>: Update.
* objfiles.h (obj_section_offset): Update.
(struct objfile) <section_offsets>: Change type.
<num_sections>: Remove.
(objfile_relocate): Update.
* objfiles.c (entry_point_address_query): Update
(relocate_one_symbol): Change type of "section_offsets".
(objfile_relocate1, objfile_relocate1): Change type of
"new_offsets".
(objfile_rebase1): Update.
* mipsread.c (mipscoff_symfile_read): Update.
(read_alphacoff_dynamic_symtab): Remove "section_offsets"
parameter.
* mdebugread.c (parse_symbol): Change type of "section_offsets".
(parse_external, psymtab_to_symtab_1): Update.
* machoread.c (macho_symfile_offsets): Update.
* ia64-tdep.c (ia64_find_unwind_table): Update.
* hppa-tdep.c (read_unwind_info): Update.
* hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
* dwarf2read.c (create_addrmap_from_index)
(create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
(process_psymtab_comp_unit_reader, add_partial_symbol)
(add_partial_subprogram, process_full_comp_unit)
(read_file_scope, read_func_scope, read_lexical_block_scope)
(read_call_site_scope, dwarf2_rnglists_process)
(dwarf2_ranges_process, dwarf2_ranges_read)
(dwarf_decode_lines_1, var_decode_location, new_symbol)
(dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
Update.
* dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
Update.
* dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
* dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
(process_one_symbol): Change type of "section_offsets".
* ctfread.c (get_objfile_text_range): Update.
* coffread.c (coff_symtab_read, enter_linenos)
(process_coff_symbol): Update.
* coff-pe-read.c (add_pe_forwarded_sym): Update.
* amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
Change-Id: I147eb967e9b44d82f4048039de7bb44b80cd72fb
2020-01-06 22:34:52 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (enter_line_range, read_xcoff_symtab)
|
|
|
|
|
|
(process_xcoff_symbol, xcoff_symfile_offsets): Update.
|
|
|
|
|
|
* symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
|
|
|
|
|
|
(struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
|
|
|
|
|
|
Remove.
|
|
|
|
|
|
(section_offsets): New typedef.
|
|
|
|
|
|
* symtab.c (fixup_section, get_msymbol_address): Update.
|
|
|
|
|
|
* symmisc.c (dump_msymbols): Update.
|
|
|
|
|
|
* symfile.h (relative_addr_info_to_section_offsets)
|
|
|
|
|
|
(symfile_map_offsets_to_segments): Update.
|
|
|
|
|
|
* symfile.c (build_section_addr_info_from_objfile)
|
|
|
|
|
|
(init_objfile_sect_indices): Update.
|
|
|
|
|
|
(struct place_section_arg): Change type of "offsets".
|
|
|
|
|
|
(place_section): Update.
|
|
|
|
|
|
(relative_addr_info_to_section_offsets): Change type of
|
|
|
|
|
|
"section_offsets". Remove "num_sections" parameter.
|
|
|
|
|
|
(default_symfile_offsets, syms_from_objfile_1)
|
|
|
|
|
|
(set_objfile_default_section_offset): Update.
|
|
|
|
|
|
(reread_symbols): No need to preserve section offsets by hand.
|
|
|
|
|
|
(symfile_map_offsets_to_segments): Change type of "offsets".
|
|
|
|
|
|
* stap-probe.c (relocate_address): Update.
|
|
|
|
|
|
* stabsread.h (process_one_symbol): Update.
|
|
|
|
|
|
* solib-target.c (struct lm_info_target) <offsets>: Change type.
|
|
|
|
|
|
(solib_target_relocate_section_addresses): Update.
|
|
|
|
|
|
* solib-svr4.c (enable_break, svr4_relocate_main_executable):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* solib-frv.c (frv_relocate_main_executable): Update.
|
|
|
|
|
|
* solib-dsbt.c (dsbt_relocate_main_executable): Update.
|
|
|
|
|
|
* solib-aix.c (solib_aix_get_section_offsets): Change return
|
|
|
|
|
|
type.
|
|
|
|
|
|
(solib_aix_solib_create_inferior_hook): Update.
|
|
|
|
|
|
* remote.c (remote_target::get_offsets): Update.
|
|
|
|
|
|
* psymtab.c (find_pc_sect_psymtab): Update.
|
|
|
|
|
|
* psympriv.h (struct partial_symbol) <address, text_low,
|
|
|
|
|
|
text_high>: Update.
|
|
|
|
|
|
* objfiles.h (obj_section_offset): Update.
|
|
|
|
|
|
(struct objfile) <section_offsets>: Change type.
|
|
|
|
|
|
<num_sections>: Remove.
|
|
|
|
|
|
(objfile_relocate): Update.
|
|
|
|
|
|
* objfiles.c (entry_point_address_query): Update
|
|
|
|
|
|
(relocate_one_symbol): Change type of "section_offsets".
|
|
|
|
|
|
(objfile_relocate1, objfile_relocate1): Change type of
|
|
|
|
|
|
"new_offsets".
|
|
|
|
|
|
(objfile_rebase1): Update.
|
|
|
|
|
|
* mipsread.c (mipscoff_symfile_read): Update.
|
|
|
|
|
|
(read_alphacoff_dynamic_symtab): Remove "section_offsets"
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
* mdebugread.c (parse_symbol): Change type of "section_offsets".
|
|
|
|
|
|
(parse_external, psymtab_to_symtab_1): Update.
|
|
|
|
|
|
* machoread.c (macho_symfile_offsets): Update.
|
|
|
|
|
|
* ia64-tdep.c (ia64_find_unwind_table): Update.
|
|
|
|
|
|
* hppa-tdep.c (read_unwind_info): Update.
|
|
|
|
|
|
* hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
|
|
|
|
|
|
* dwarf2read.c (create_addrmap_from_index)
|
|
|
|
|
|
(create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
|
|
|
|
|
|
(process_psymtab_comp_unit_reader, add_partial_symbol)
|
|
|
|
|
|
(add_partial_subprogram, process_full_comp_unit)
|
|
|
|
|
|
(read_file_scope, read_func_scope, read_lexical_block_scope)
|
|
|
|
|
|
(read_call_site_scope, dwarf2_rnglists_process)
|
|
|
|
|
|
(dwarf2_ranges_process, dwarf2_ranges_read)
|
|
|
|
|
|
(dwarf_decode_lines_1, var_decode_location, new_symbol)
|
|
|
|
|
|
(dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
|
|
|
|
|
|
* dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
|
|
|
|
|
|
(process_one_symbol): Change type of "section_offsets".
|
|
|
|
|
|
* ctfread.c (get_objfile_text_range): Update.
|
|
|
|
|
|
* coffread.c (coff_symtab_read, enter_linenos)
|
|
|
|
|
|
(process_coff_symbol): Update.
|
|
|
|
|
|
* coff-pe-read.c (add_pe_forwarded_sym): Update.
|
|
|
|
|
|
* amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
|
|
|
|
|
|
|
2019-10-31 17:46:18 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (parse_macro_definition): Use std::string.
|
|
|
|
|
|
(parse_macro_definition): Likewise.
|
|
|
|
|
|
|
2019-10-31 17:37:35 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (abbrev_table_read_table): Use std::vector.
|
|
|
|
|
|
(ATTR_ALLOC_CHUNK): Remove.
|
|
|
|
|
|
|
2019-10-31 17:34:40 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
|
|
|
|
|
|
|
2019-10-31 17:31:28 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
|
|
|
|
|
|
(dwarf2_compute_name, open_dwo_file): Likewise.
|
|
|
|
|
|
(process_enumeration_scope): Use std::vector.
|
|
|
|
|
|
(guess_partial_die_structure_name): Use unique_xmalloc_ptr.
|
|
|
|
|
|
(partial_die_info::fixup, dwarf2_start_subfile)
|
|
|
|
|
|
(guess_full_die_structure_name, dwarf2_name): Likewise.
|
|
|
|
|
|
(determine_prefix): Update.
|
|
|
|
|
|
(guess_full_die_structure_name): Make return type const.
|
|
|
|
|
|
(partial_die_full_name): Return unique_xmalloc_ptr.
|
|
|
|
|
|
(DW_FIELD_ALLOC_CHUNK): Remove.
|
|
|
|
|
|
|
2019-12-19 19:35:22 +01:00
|
|
|
|
2020-01-07 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR build/24937:
|
|
|
|
|
|
* stap-probe.c (class stap_static_probe_ops): Add constructor.
|
|
|
|
|
|
|
2019-12-29 23:26:41 +01:00
|
|
|
|
2020-01-02 Jon Turney <jon.turney@dronecode.org.uk>
|
|
|
|
|
|
|
|
|
|
|
|
* cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
|
|
|
|
|
|
|
2019-12-26 21:56:01 +01:00
|
|
|
|
2020-01-06 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* stack.c (print_frame_info): Move disassemble_next_line code
|
|
|
|
|
|
inside source_print block.
|
|
|
|
|
|
|
2020-01-06 20:54:21 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbsupport/gdb_wait.c: Include <signal.h> instead of
|
|
|
|
|
|
gdb/signals.h, as we are now using native signal symbols.
|
|
|
|
|
|
|
2020-01-06 15:27:32 +01:00
|
|
|
|
2020-01-06 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
|
|
|
|
|
|
overflow by an early check of content vs threshold.
|
|
|
|
|
|
* tui/tui-source.c (tui_source_window::line_is_displayed):
|
|
|
|
|
|
Likewise.
|
|
|
|
|
|
|
2020-01-06 20:25:23 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
|
|
|
|
|
|
|
2020-01-02 01:25:56 +01:00
|
|
|
|
2020-01-02 Jon Turney <jon.turney@dronecode.org.uk>
|
|
|
|
|
|
|
|
|
|
|
|
* coff-pe-read.c (read_pe_exported_syms): Don't try to read the
|
|
|
|
|
|
export table if no section contains it's RVA.
|
|
|
|
|
|
|
2020-01-06 19:22:15 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
|
|
|
|
|
|
|
2019-12-22 14:58:22 +01:00
|
|
|
|
2020-01-06 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* source.c (print_source_lines_base): Set last_line_listed.
|
|
|
|
|
|
|
2020-01-06 13:54:18 +01:00
|
|
|
|
2020-01-06 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-disasm.c: Remove trailing spaces.
|
|
|
|
|
|
|
2020-01-06 12:51:54 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
|
|
|
|
|
|
* windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
|
|
|
|
|
|
(windows_gdb_signal_to_target): New function, uses the above
|
|
|
|
|
|
enumeration to convert GDB internal signal codes to equivalent
|
|
|
|
|
|
Windows codes.
|
|
|
|
|
|
(windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
|
|
|
|
|
|
* windows-nat.c: Include "gdb_wait.h".
|
|
|
|
|
|
(get_windows_debug_event): Extract the fatal exception from the
|
|
|
|
|
|
exit status and convert to the equivalent Posix signal number.
|
|
|
|
|
|
* cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
|
|
|
|
|
|
possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
|
|
|
|
|
|
* gdbsupport/gdb_wait.c: New file, implements
|
|
|
|
|
|
windows_status_to_termsig.
|
|
|
|
|
|
* gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
|
|
|
|
|
|
(WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
|
|
|
|
|
|
|
2019-12-23 00:45:31 +01:00
|
|
|
|
2020-01-05 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
|
|
|
|
|
|
show_layout.
|
|
|
|
|
|
|
2020-01-03 20:08:16 +01:00
|
|
|
|
2020-01-05 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-linux-nat.c
|
|
|
|
|
|
(aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
|
|
|
|
|
|
and bfd_mach_aarch64.
|
|
|
|
|
|
|
2019-12-15 17:58:16 +01:00
|
|
|
|
2020-01-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
|
|
|
|
|
|
|
|
|
|
|
|
* ui-file.c (stdio_file::can_emit_style_escape)
|
|
|
|
|
|
(tee_file::can_emit_style_escape): Ensure style is used also on
|
|
|
|
|
|
gdb_stderr when gdb_stderr is a tty supporting styling, similarly
|
|
|
|
|
|
to gdb_stdout.
|
|
|
|
|
|
* main.c (set_gdb_data_directory): Use file style to output the
|
|
|
|
|
|
warning that the given pathname is not a directory.
|
|
|
|
|
|
* top.c (show_history_filename, gdb_safe_append_history)
|
|
|
|
|
|
(show_gdb_datadir): Use file style.
|
|
|
|
|
|
|
2019-12-27 13:41:58 +01:00
|
|
|
|
2020-01-03 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* solib-target.c (struct lm_info_target):
|
|
|
|
|
|
Change offsets to be a unique_xmalloc_ptr.
|
|
|
|
|
|
(solib_target_relocate_section_addresses): Update.
|
|
|
|
|
|
|
2019-12-24 13:14:01 +01:00
|
|
|
|
2020-01-03 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-nat.c (windows_clear_solib): Free so_list linked list.
|
|
|
|
|
|
|
2020-01-03 09:16:38 +01:00
|
|
|
|
2020-01-03 Bernd Edlinger <bernd.edlinger@hotmail.de>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS (Write After Approval): Add myself.
|
|
|
|
|
|
|
2019-12-30 19:47:10 +01:00
|
|
|
|
2020-01-02 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* proc-service.c (get_ps_regcache): Remove reference to obsolete
|
|
|
|
|
|
Cell BE architecture.
|
|
|
|
|
|
* target.h (struct target_ops) <thread_architecture>: Likewise.
|
|
|
|
|
|
|
2019-12-30 17:01:02 +01:00
|
|
|
|
2020-01-01 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in: Use INSTALL_PROGRAM_ENV.
|
|
|
|
|
|
|
2020-01-01 13:00:28 +01:00
|
|
|
|
2020-01-01 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS (Write After Approval): Add myself.
|
|
|
|
|
|
|
2020-01-01 07:37:10 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbarch.sh: Update copyright year range of generated files.
|
|
|
|
|
|
|
2020-01-01 07:20:01 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
Update copyright year range in all GDB files.
|
|
|
|
|
|
|
2020-01-01 07:12:57 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copyright.py: Convert to Python 3.
|
|
|
|
|
|
|
2020-01-01 06:19:14 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copyright.py: Adapt after move of gnulib directory from gdb
|
|
|
|
|
|
directory to toplevel directory.
|
|
|
|
|
|
|
2020-01-01 06:08:08 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copyright.py (main): Exit if run from the wrong directory.
|
|
|
|
|
|
|
2020-01-01 05:43:08 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* top.c (print_gdb_version): Change copyright year to 2020.
|
|
|
|
|
|
|
2020-01-01 05:40:23 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
2019-12-30 17:11:32 +01:00
|
|
|
|
|
2020-01-01 05:40:23 +01:00
|
|
|
|
* config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
|
2019-12-30 17:11:32 +01:00
|
|
|
|
|
2020-01-01 05:40:23 +01:00
|
|
|
|
For older changes see ChangeLog-2019.
|
1999-04-16 03:35:26 +02:00
|
|
|
|
|
|
|
|
|
|
Local Variables:
|
|
|
|
|
|
mode: change-log
|
|
|
|
|
|
left-margin: 8
|
|
|
|
|
|
fill-column: 74
|
|
|
|
|
|
version-control: never
|
2007-08-10 00:44:38 +02:00
|
|
|
|
coding: utf-8
|
1999-04-16 03:35:26 +02:00
|
|
|
|
End:
|
