Luiz Capitulino d2e4d08b3e virtio-serial: Fix segfault on guest boot ... If I start qemu with: # qemu -hda disks/test.img -enable-kvm -m 1G -snapshot \ -device virtio-serial \ -chardev socket,host=localhost,port=1234,server,nowait,id=foo \ -device virtserialport,chardev=foo,name=org.qemu.guest_agent I get a segfault when booting a Fedora 14 guest. The backtrace says: Program terminated with signal 11, Segmentation fault. #0 0x0000000000420850 in handle_control_message (vser=0x3732bd0, buf=0x2c173e0, len=8) at /home/lcapitulino/src/qmp-unstable/hw/virtio-serial-bus.c:335 335 info = DO_UPCAST(VirtIOSerialPortInfo, qdev, port->dev.info); What's happening is VIRTIO_CONSOLE_DEVICE_READY is a message for the whole device, not for an individual port. So port is NULL. This bug was introduced by commit a15bb0d6a9. This commit fixes that by making the port returned by find_port_by_id() be used only by the VIRTIO_CONSOLE_PORT_READY and VIRTIO_CONSOLE_PORT_OPEN messages. Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Amit Shah <amit.shah@redhat.com>		2011-06-27 15:04:54 +05:30
..
9pfs
ide
9p.h
a9mpcore.c
ac97.c
acpi_piix4.c
acpi.c
acpi.h
adb.c
adlib.c
ads7846.c
an5206.c
apb_pci.c
apb_pci.h
apic.c
apic.h
apm.c
apm.h
applesmc.c
arm11mpcore.c
arm_boot.c
arm_gic.c
arm_pic.c
arm_sysctl.c
arm_timer.c
arm-misc.h
armv7m_nvic.c
armv7m.c
audiodev.h
axis_dev88.c
baum.c
baum.h
bitbang_i2c.c
bitbang_i2c.h
blizzard_template.h
blizzard.c
boards.h
bonito.c
bt-hci-csr.c
bt-hci.c
bt-hid.c
bt-l2cap.c
bt-sdp.c
bt.c
bt.h
cbus.c
ccid-card-emulated.c
ccid-card-passthru.c
ccid.h
cdrom.c
cirrus_vga_rop2.h
cirrus_vga_rop.h
cirrus_vga.c
collie.c
cris_pic_cpu.c
cris-boot.c
cris-boot.h
cs4231.c
cs4231a.c
cuda.c
debugcon.c
dec_pci.c
dec_pci.h
device-hotplug.c
devices.h
dma.c
dp8393x.c
ds1225y.c
ds1338.c
dummy_m68k.c
e1000_hw.h
e1000.c
ecc.c
eccmemctl.c
eepro100.c
eeprom93xx.c
eeprom93xx.h
elf_ops.h
empty_slot.c
empty_slot.h
es1370.c
escc.c
escc.h
esp.c
esp.h
etraxfs_dma.c
etraxfs_dma.h
etraxfs_eth.c
etraxfs_pic.c
etraxfs_ser.c
etraxfs_timer.c
etraxfs.c
etraxfs.h
event_notifier.c
event_notifier.h
fdc.c
fdc.h
firmware_abi.h
flash.h
fmopl.c
fmopl.h
framebuffer.c
framebuffer.h
fw_cfg.c
fw_cfg.h
g364fb.c
grackle_pci.c
grlib_apbuart.c
grlib_gptimer.c
grlib_irqmp.c
grlib.h
gt64xxx.c
gumstix.c
gus.c
gusemu_hal.c
gusemu_mixer.c
gusemu.h
gustate.h
hda-audio.c
heathrow_pic.c
hpet_emul.h
hpet.c
hw.h
i2c.c
i2c.h
i8254.c
i8259.c
ide.h
integratorcp.c
intel-hda-defs.h
intel-hda.c
intel-hda.h
ioapic.c
ioapic.h
ioh3420.c
ioh3420.h
irq.c
irq.h
isa_mmio.c
isa-bus.c
isa.h
ivshmem.c
jazz_led.c
kvmclock.c
kvmclock.h
lan9118.c
lance.c
leon3.c
lm32_boards.c
lm32_hwsetup.h
lm32_juart.c
lm32_juart.h
lm32_pic.c
lm32_pic.h
lm32_sys.c
lm32_timer.c
lm32_uart.c
lm32.h
lm832x.c
loader.c
loader.h
lsi53c895a.c
m48t59.c
mac_dbdma.c
mac_dbdma.h
mac_nvram.c
macio.c
mainstone.c
marvell_88w8618_audio.c
max111x.c
max7310.c
mc146818rtc.c
mc146818rtc.h
mcf5206.c
mcf5208.c
mcf_fec.c
mcf_intc.c
mcf_uart.c
mcf.h
microblaze_pic_cpu.c
milkymist-ac97.c
milkymist-hpdmc.c
milkymist-hw.h
milkymist-memcard.c
milkymist-minimac2.c
milkymist-pfpu.c
milkymist-softusb.c
milkymist-sysctl.c
milkymist-tmu2.c
milkymist-uart.c
milkymist-vgafb_template.h
milkymist-vgafb.c
milkymist.c
mips_addr.c
mips_cpudevs.h
mips_fulong2e.c
mips_int.c
mips_jazz.c
mips_malta.c
mips_mipssim.c
mips_r4k.c
mips_timer.c
mips-bios.h
mips.h
mipsnet.c
mpcore.c
msi.c
msi.h
msix.c
msix.h
msmouse.c
msmouse.h
mst_fpga.c
multiboot.c
multiboot.h
musicpal.c
nand.c
ne2000-isa.c
ne2000.c
ne2000.h
nseries.c
nvram.h
omap1.c
omap2.c
omap_clk.c
omap_dma.c
omap_dss.c
omap_gpio.c
omap_gpmc.c
omap_gptimer.c
omap_i2c.c
omap_intc.c
omap_l4.c
omap_lcd_template.h
omap_lcdc.c
omap_mmc.c
omap_sdrc.c
omap_spi.c
omap_sx1.c
omap_synctimer.c
omap_tap.c
omap_uart.c
omap.h
onenand.c
openpic.c
openpic.h
palm.c
parallel.c
pc_piix.c
pc.c
pc.h
pci_bridge.c
pci_bridge.h
pci_host.c
pci_host.h
pci_ids.h
pci_internals.h
pci_regs.h
pci-hotplug.c
pci-stub.c
pci.c
pci.h
pcie_aer.c
pcie_aer.h
pcie_host.c
pcie_host.h
pcie_port.c
pcie_port.h
pcie_regs.h
pcie.c
pcie.h
pckbd.c
pcmcia.h
pcnet-pci.c
pcnet.c
pcnet.h
pcspk.c
petalogix_ml605_mmu.c
petalogix_s3adsp1800_mmu.c
pflash_cfi01.c
pflash_cfi02.c
piix4.c
piix_pci.c
pixel_ops.h
pl011.c
pl022.c
pl031.c
pl050.c
pl061.c
pl080.c
pl110_template.h
pl110.c
pl181.c
pl190.c
pm_smbus.c
pm_smbus.h
ppc4xx_devs.c
ppc4xx_pci.c
ppc4xx.h
ppc405_boards.c
ppc405_uc.c
ppc405.h
ppc440_bamboo.c
ppc440.c
ppc440.h
ppc_mac.h
ppc_newworld.c
ppc_oldworld.c
ppc_prep.c
ppc-viosrp.h
ppc.c
ppc.h
ppce500_mpc8544ds.c
ppce500_pci.c
prep_pci.c
prep_pci.h
primecell.h
ps2.c
ps2.h
ptimer.c
pxa2xx_dma.c
pxa2xx_gpio.c
pxa2xx_keypad.c
pxa2xx_lcd.c
pxa2xx_mmci.c
pxa2xx_pcmcia.c
pxa2xx_pic.c
pxa2xx_template.h
pxa2xx_timer.c
pxa2xx.c
pxa.h
qdev-addr.c
qdev-addr.h
qdev-properties.c
qdev.c
qdev.h
qxl-logger.c
qxl-render.c
qxl.c
qxl.h
r2d.c
rc4030.c
realview_gic.c
realview.c
rtl8139.c
s390-virtio-bus.c
s390-virtio-bus.h
s390-virtio.c
sb16.c
sbi.c
scsi-bus.c
scsi-defs.h
scsi-disk.c
scsi-generic.c
scsi.h
sd.c
sd.h
serial.c
sga.c
sh7750_regnames.c
sh7750_regnames.h
sh7750_regs.h
sh7750.c	Remove exec-all.h include directives	2011-06-26 18:25:35 +00:00
sh_intc.c
sh_intc.h
sh_pci.c
sh_serial.c
sh_timer.c
sh.h
sharpsl.h
shix.c
slavio_intctl.c
slavio_misc.c
slavio_timer.c
sm501_template.h
sm501.c
smbios.c
smbios.h
smbus_eeprom.c
smbus.c
smbus.h
smc91c111.c
soc_dma.c
soc_dma.h
spapr_hcall.c	Remove exec-all.h include directives	2011-06-26 18:25:35 +00:00
spapr_llan.c
spapr_rtas.c
spapr_vio.c
spapr_vio.h
spapr_vscsi.c
spapr_vty.c
spapr.c
spapr.h
sparc32_dma.c
sparc32_dma.h
spitz.c
srp.h
ssd0303.c
ssd0323.c
ssi-sd.c
ssi.c
ssi.h
stellaris_enet.c
stellaris_input.c
stellaris.c
strongarm.c
strongarm.h
sun4c_intctl.c
sun4m_iommu.c
sun4m.c
sun4m.h
sun4u.c
syborg_fb.c
syborg_interrupt.c
syborg_keyboard.c
syborg_pointer.c
syborg_rtc.c
syborg_serial.c
syborg_timer.c
syborg_virtio.c
syborg.c
syborg.h
sysbus.c
sysbus.h
tc6393xb_template.h
tc6393xb.c
tc58128.c
tcx.c
tmp105.c
tosa.c
tsc210x.c
tsc2005.c
tusb6010.c
twl92230.c
unin_pci.c
usb-bt.c
usb-bus.c
usb-ccid.c
usb-desc.c
usb-desc.h
usb-ehci.c
usb-hid.c
usb-hub.c
usb-msd.c
usb-musb.c
usb-net.c
usb-ohci.c
usb-ohci.h
usb-serial.c
usb-uhci.c
usb-uhci.h
usb-wacom.c
usb.c
usb.h
versatile_pci.c
versatilepb.c
vexpress.c
vga_int.h
vga_template.h
vga-isa-mm.c
vga-isa.c
vga-pci.c
vga.c
vhost_net.c
vhost_net.h
vhost.c
vhost.h
virtex_ml507.c
virtio-balloon.c
virtio-balloon.h
virtio-blk.c
virtio-blk.h
virtio-console.c
virtio-net.c
virtio-net.h
virtio-pci.c
virtio-pci.h
virtio-serial-bus.c	virtio-serial: Fix segfault on guest boot	2011-06-27 15:04:54 +05:30
virtio-serial.h
virtio.c
virtio.h
vmmouse.c
vmport.c
vmware_vga.c
vmware_vga.h
vt82c686.c
vt82c686.h
watchdog.c
watchdog.h
wdt_i6300esb.c
wdt_ib700.c
wm8750.c
xen_backend.c
xen_backend.h
xen_blkif.h
xen_common.h
xen_console.c
xen_devconfig.c
xen_disk.c
xen_domainbuild.c
xen_domainbuild.h
xen_machine_pv.c
xen_nic.c
xen_platform.c
xen.h
xenfb.c
xics.c
xics.h
xilinx_axidma.c
xilinx_axidma.h
xilinx_axienet.c
xilinx_ethlite.c
xilinx_intc.c
xilinx_timer.c
xilinx_uartlite.c
xilinx.h
xio3130_downstream.c
xio3130_downstream.h
xio3130_upstream.c
xio3130_upstream.h
zaurus.c