2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (abbrev_table_up, struct abbrev_info)
|
|
|
|
|
|
(struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
|
|
|
|
|
|
Move.
|
|
|
|
|
|
(read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
|
|
|
|
|
|
(abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
|
|
|
|
|
|
(abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
|
|
|
|
|
|
abbrev.c.
|
|
|
|
|
|
* dwarf2/abbrev.h: New file.
|
|
|
|
|
|
* dwarf2/abbrev.c: New file, from dwarf2read.c.
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
|
|
|
|
|
|
|
Change section functions to be methods of dwarf2_section_info
This changes various section-related functions to be methods on
dwarf2_section_info. I think this clarifies the role of these
functions. This also changes one such function to return bool.
gdb/ChangeLog
2020-02-08 Tom Tromey <tom@tromey.com>
* dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
(dwarf2_section_size, dwarf2_get_section_info)
(create_signatured_type_table_from_debug_names)
(create_addrmap_from_aranges, read_debug_names_from_section)
(get_gdb_index_contents_from_section, read_comp_unit_head)
(error_check_comp_unit_head, read_abbrev_offset)
(create_debug_type_hash_table, init_cu_die_reader)
(read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
(read_comp_units_from_section, create_cus_hash_table)
(create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
(create_dwp_v2_section, dwarf2_rnglists_process)
(dwarf2_ranges_process, read_die_and_siblings, read_full_die)
(abbrev_table_read_table, read_indirect_string_at_offset_from)
(read_indirect_string_from_dwz, read_addr_index_1)
(read_str_index, dwarf_decode_line_header, skip_form_bytes)
(dwarf_decode_macro_bytes, dwarf_decode_macros)
(fill_in_loclist_baton): Update.
* dwarf2/section.h (struct dwarf2_section_info) <get_name,
get_containing_section, get_bfd_owner, get_bfd_section,
get_file_name, get_id, get_flags, empty, read>: Declare methods.
(dwarf2_read_section, get_section_name, get_section_file_name)
(get_containing_section, get_section_bfd_owner)
(get_section_bfd_section, get_section_name, get_section_file_name)
(get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
declare.
* dwarf2/section.c (dwarf2_section_info::get_containing_section)
(dwarf2_section_info::get_bfd_owner)
(dwarf2_section_info::get_bfd_section)
(dwarf2_section_info::get_name)
(dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
(dwarf2_section_info::get_flags, dwarf2_section_info::empty)
(dwarf2_section_info::read): Now methods.
* dwarf-index-write.c (class debug_names): Update.
Change-Id: Ic849f182f57a18bad6b1c7c3b9368005d307758a
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
|
|
|
|
|
|
(dwarf2_section_size, dwarf2_get_section_info)
|
|
|
|
|
|
(create_signatured_type_table_from_debug_names)
|
|
|
|
|
|
(create_addrmap_from_aranges, read_debug_names_from_section)
|
|
|
|
|
|
(get_gdb_index_contents_from_section, read_comp_unit_head)
|
|
|
|
|
|
(error_check_comp_unit_head, read_abbrev_offset)
|
|
|
|
|
|
(create_debug_type_hash_table, init_cu_die_reader)
|
|
|
|
|
|
(read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
|
|
|
|
|
|
(read_comp_units_from_section, create_cus_hash_table)
|
|
|
|
|
|
(create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
|
|
|
|
|
|
(create_dwp_v2_section, dwarf2_rnglists_process)
|
|
|
|
|
|
(dwarf2_ranges_process, read_die_and_siblings, read_full_die)
|
|
|
|
|
|
(abbrev_table_read_table, read_indirect_string_at_offset_from)
|
|
|
|
|
|
(read_indirect_string_from_dwz, read_addr_index_1)
|
|
|
|
|
|
(read_str_index, dwarf_decode_line_header, skip_form_bytes)
|
|
|
|
|
|
(dwarf_decode_macro_bytes, dwarf_decode_macros)
|
|
|
|
|
|
(fill_in_loclist_baton): Update.
|
|
|
|
|
|
* dwarf2/section.h (struct dwarf2_section_info) <get_name,
|
|
|
|
|
|
get_containing_section, get_bfd_owner, get_bfd_section,
|
|
|
|
|
|
get_file_name, get_id, get_flags, empty, read>: Declare methods.
|
|
|
|
|
|
(dwarf2_read_section, get_section_name, get_section_file_name)
|
|
|
|
|
|
(get_containing_section, get_section_bfd_owner)
|
|
|
|
|
|
(get_section_bfd_section, get_section_name, get_section_file_name)
|
|
|
|
|
|
(get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
|
|
|
|
|
|
declare.
|
|
|
|
|
|
* dwarf2/section.c (dwarf2_section_info::get_containing_section)
|
|
|
|
|
|
(dwarf2_section_info::get_bfd_owner)
|
|
|
|
|
|
(dwarf2_section_info::get_bfd_section)
|
|
|
|
|
|
(dwarf2_section_info::get_name)
|
|
|
|
|
|
(dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
|
|
|
|
|
|
(dwarf2_section_info::get_flags, dwarf2_section_info::empty)
|
|
|
|
|
|
(dwarf2_section_info::read): Now methods.
|
|
|
|
|
|
* dwarf-index-write.c (class debug_names): Update.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
|
|
|
|
|
|
Move to dwarf2/section.h.
|
|
|
|
|
|
* dwarf2read.c (get_containing_section, get_section_bfd_owner)
|
|
|
|
|
|
(get_section_bfd_section, get_section_name)
|
|
|
|
|
|
(get_section_file_name, get_section_id, get_section_flags)
|
|
|
|
|
|
(dwarf2_section_empty_p, dwarf2_read_section): Moe to
|
|
|
|
|
|
dwarf2/section.c.
|
|
|
|
|
|
* dwarf2/section.h: New file.
|
|
|
|
|
|
* dwarf2/section.c: New file, from dwarf2read.c.
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
|
|
|
|
|
|
|
Create dwarf2/leb.[ch]
This moves some scalar-unpacking code into a couple of new files,
dwarf2/leb.h and dwarf2/leb.c.
gdb/ChangeLog
2020-02-08 Tom Tromey <tom@tromey.com>
* dwarf2read.h (read_unsigned_leb128): Don't declare.
* dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
(read_2_signed_bytes, read_3_bytes, read_4_bytes)
(read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
(read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
* dwarf2/leb.h: New file, from dwarf2read.c.
* dwarf2/leb.c: New file, from dwarf2read.c.
* dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
Remove.
* Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
(COMMON_SFILES): Add dwarf2/leb.c.
Change-Id: Idd19647686c8f959d226a95fdfca4db47c6e96d0
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.h (read_unsigned_leb128): Don't declare.
|
|
|
|
|
|
* dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
|
|
|
|
|
|
(read_2_signed_bytes, read_3_bytes, read_4_bytes)
|
|
|
|
|
|
(read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
|
|
|
|
|
|
(read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
|
|
|
|
|
|
* dwarf2/leb.h: New file, from dwarf2read.c.
|
|
|
|
|
|
* dwarf2/leb.c: New file, from dwarf2read.c.
|
|
|
|
|
|
* dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
|
|
|
|
|
|
Remove.
|
|
|
|
|
|
* Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
|
|
|
|
|
|
(COMMON_SFILES): Add dwarf2/leb.c.
|
|
|
|
|
|
|
2020-02-08 14:02:16 +01:00
|
|
|
|
2020-02-08 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
GDB 9.1 released.
|
|
|
|
|
|
|
2020-02-05 12:45:13 +01:00
|
|
|
|
2020-02-05 Iain Buclaw <ibuclaw@gdcproject.org>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/25190:
|
|
|
|
|
|
* gdb/remote-sim.c (gdb_os_write_stderr): Update.
|
|
|
|
|
|
* gdb/remote.c (remote_console_output): Update.
|
|
|
|
|
|
* gdb/ui-file.c (fputs_unfiltered): Rename to...
|
|
|
|
|
|
(ui_file_puts): ...this.
|
|
|
|
|
|
* gdb/ui-file.h (ui_file_puts): Add declaration.
|
|
|
|
|
|
* gdb/utils.c (emit_style_escape): Update.
|
|
|
|
|
|
(flush_wrap_buffer): Update.
|
|
|
|
|
|
(fputs_maybe_filtered): Update.
|
|
|
|
|
|
(fputs_unfiltered): Add function.
|
|
|
|
|
|
|
2020-02-05 12:25:09 +01:00
|
|
|
|
2020-02-05 Iain Buclaw <ibuclaw@gdcproject.org>
|
|
|
|
|
|
|
|
|
|
|
|
* gdb/event-loop.c (gdb_wait_for_event): Update.
|
|
|
|
|
|
* gdb/printcmd.c (printf_command): Update.
|
|
|
|
|
|
* gdb/remote-fileio.c (remote_fileio_func_write): Update.
|
|
|
|
|
|
* gdb/remote-sim.c (gdb_os_flush_stdout): Update.
|
|
|
|
|
|
(gdb_os_flush_stderr): Update.
|
|
|
|
|
|
* gdb/remote.c (remote_console_output): Update.
|
|
|
|
|
|
* gdb/ui-file.c (gdb_flush): Rename to...
|
|
|
|
|
|
(ui_file_flush): ...this.
|
|
|
|
|
|
(stderr_file::write): Update.
|
|
|
|
|
|
(stderr_file::puts): Update.
|
|
|
|
|
|
* gdb/ui-file.h (gdb_flush): Rename to...
|
|
|
|
|
|
(ui_file_flush): ...this.
|
|
|
|
|
|
* gdb/utils.c (gdb_flush): Add function.
|
|
|
|
|
|
* gdb/utils.h (gdb_flush): Add declaration.
|
|
|
|
|
|
|
2020-02-05 10:53:44 +01:00
|
|
|
|
2020-02-07 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR breakpoints/24915:
|
|
|
|
|
|
* source.c (find_and_open_source): Do not check basenames_may_differ.
|
|
|
|
|
|
|
Move gdbserver to top level
This patch moves gdbserver to the top level.
This patch is as close to a pure move as possible -- gdbserver still
builds its own variant of gnulib and gdbsupport. Changing this will
be done in a separate patch.
[v2] Note that, per Simon's review comment, this patch changes the
tree so that gdbserver is not built for or1k or score. This makes
sense, because there is apparently not actually a gdbserver port here.
[v3] This version of the patch also splits out some configury into a
new file, gdbserver/configure.host, so that the top-level configure
script can simply rely on it in order to decide whether gdbserver
should be built.
[v4] This version adds documentation and removes some unnecessary
top-level dependencies.
[v5] Update docs to mention "make all-gdbserver" and change how
top-level configure decides whether to build gdbserver, switching to a
single, shared script.
Tested by the buildbot.
ChangeLog
2020-02-07 Tom Tromey <tom@tromey.com>
Pedro Alves <palves@redhat.com>
* src-release.sh (GDB_SUPPORT_DIRS): Add gdbserver.
* gdbserver: New directory, moved from gdb/gdbserver.
* configure.ac (host_tools): Add gdbserver.
Only build gdbserver on certain systems.
* Makefile.in, configure: Rebuild.
* Makefile.def (host_modules, dependencies): Add gdbserver.
* MAINTAINERS: Add gdbserver.
gdb/ChangeLog
2020-02-07 Tom Tromey <tom@tromey.com>
* README: Update gdbserver documentation.
* gdbserver: Move to top level.
* configure.tgt (build_gdbserver): Remove.
* configure.ac: Remove --enable-gdbserver.
* configure: Rebuild.
* Makefile.in (distclean): Don't mention gdbserver.
Change-Id: I826b7565b54604711dc7a11edea0499cd51ff39e
2019-12-15 15:37:06 +01:00
|
|
|
|
2020-02-07 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* README: Update gdbserver documentation.
|
|
|
|
|
|
* gdbserver: Move to top level.
|
|
|
|
|
|
* configure.tgt (build_gdbserver): Remove.
|
|
|
|
|
|
* configure.ac: Remove --enable-gdbserver.
|
|
|
|
|
|
* configure: Rebuild.
|
|
|
|
|
|
* Makefile.in (distclean): Don't mention gdbserver.
|
|
|
|
|
|
|
gdb: Catch exceptions if the source file is not found
The source_cache::ensure method may throw an exception through
the invocation of source_cache::get_plain_source_lines. This
happens when the source file is not found. The expected behaviour
of "ensure" is only returning "true" or "false" according to the
documentation in the header file.
So far, if gdb is in source layout and a file is missing, you see
some outputs like below:
,---------------------------------------------.
| test.c file is loaded in the source window. |
| |
| int main() |
| ... |
|---------------------------------------------|
| Remote debugging using :1234 |
| __start () at /path/to/crt0.S:141 |
| /path/to/crt0.S: No such file or directory. |
| (gdb) p/x $pc |
| $1 = 0x124 |
| (gdb) n |
| /path/to/crt0.S: No such file or directory. |
| (gdb) p/x $pc |
| $2 = 0x128 |
| (gdb) [pressing arrow-down key] |
| (gdb) terminate called after throwing an |
| instance of 'gdb_exception_error' |
`---------------------------------------------'
Other issues have been encountered as well [1].
The patch from Pedro [2] which is about preventing exceptions
from crossing the "readline" mitigates the situation by not
causing gdb crash, but still there are lots of errors printed:
,---------------------------------------------.
| test.c file is loaded in the source window. |
| |
| int main() |
| ... |
|---------------------------------------------|
| Remote debugging using :1234 |
| __start () at /path/to/crt0.S:141 |
| /path/to/crt0.S: No such file or directory. |
| (gdb) [pressing arrow-down key] |
| /path/to/crt0.S: No such file or directory. |
| (gdb) [pressing arrow-down key] |
| /path/to/crt0.S: No such file or directory. |
| (gdb) [pressing arrow-up key] |
| /path/to/crt0.S: No such file or directory. |
`---------------------------------------------'
With the changes of this patch, the behavior is like:
,---------------------------------------------.
| initially, source window is empty because |
| crt0.S is not found and according to the |
| program counter that is the piece of code |
| being executed. |
| |
| later, when we break at main (see commands |
| below), this window will be filled with the |
| the contents of test.c file. |
|---------------------------------------------|
| Remote debugging using :1234 |
| __start () at /path/to/crt0.S:141 |
| (gdb) p/x $pc |
| $1 = 0x124 |
| (gdb) n |
| (gdb) p/x $pc |
| $2 = 0x128 |
| (gdb) b main |
| Breakpoint 1 at 0x334: file test.c, line 8. |
| (gdb) cont |
| Continuing. |
| Breakpoint 1, main () at hello.c:8 |
| (gdb) n |
| (gdb) |
`---------------------------------------------'
There is no crash and the error message is completely
gone. Maybe it is good practice that the error is
shown inside the source window.
I tested this change against gdb.base/list-missing-source.exp
and there was no regression.
[1]
It has also been observed in the past that the register
values are not transferred from qemu's gdb stub, see:
https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/issues/226
[2]
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=2f267673f0fdee9287e6d404ecd4f2d29da0d2f2
gdb/ChangeLog:
* source-cache.c (source_cache::ensure): Surround
get_plain_source_lines with a try/catch.
(source_cache::get_line_charpos): Get rid of try/catch
and only check for the return value of "ensure".
* tui/tui-source.c (tui_source_window::set_contents):
Simplify "nlines" calculation.
gdb/testsuite/ChangeLog:
* gdb.tui/tui-missing-src.exp: Add the "missing source
file" test for the TUI.
2020-02-06 16:20:37 +01:00
|
|
|
|
2020-02-06 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* source-cache.c (source_cache::ensure): Surround
|
|
|
|
|
|
get_plain_source_lines with a try/catch.
|
|
|
|
|
|
(source_cache::get_line_charpos): Get rid of try/catch
|
|
|
|
|
|
and only check for the return value of "ensure".
|
|
|
|
|
|
* tui/tui-source.c (tui_source_window::set_contents):
|
|
|
|
|
|
Simplify "nlines" calculation.
|
|
|
|
|
|
|
2020-02-06 16:56:40 +01:00
|
|
|
|
2020-02-06 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS (Write After Approval): Add myself.
|
|
|
|
|
|
|
2020-02-05 18:43:22 +01:00
|
|
|
|
2020-02-05 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
|
|
|
|
|
|
function call.
|
|
|
|
|
|
|
2020-02-05 18:33:42 +01:00
|
|
|
|
2020-02-05 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ppc-nbsd-tdep.h: Fix macro name in #endif comment.
|
|
|
|
|
|
|
2020-02-05 18:21:12 +01:00
|
|
|
|
2020-02-05 Maciej W. Rozycki <macro@wdc.com>
|
|
|
|
|
|
|
|
|
|
|
|
* nat/riscv-linux-tdesc.h: New file.
|
|
|
|
|
|
* nat/riscv-linux-tdesc.c: New file, taking code from...
|
|
|
|
|
|
* riscv-linux-nat.c (riscv_linux_nat_target::read_description):
|
|
|
|
|
|
... here.
|
|
|
|
|
|
* configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
|
|
|
|
|
|
NATDEPFILES.
|
|
|
|
|
|
|
2020-02-04 10:07:16 +01:00
|
|
|
|
2020-02-04 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
|
|
|
|
|
|
we don't set the fake simulator ptid to the null_ptid.
|
|
|
|
|
|
|
2020-02-04 05:02:28 +01:00
|
|
|
|
2020-02-03 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* fork-child.c (gdb_startup_inferior): Use bool instead of int.
|
|
|
|
|
|
* gdbthread.h (class thread_info) <resumed>: Likewise.
|
|
|
|
|
|
* infrun.c (resume_1): Likewise.
|
|
|
|
|
|
(proceed): Likewise.
|
|
|
|
|
|
(infrun_thread_stop_requested): Likewise.
|
|
|
|
|
|
(stop_all_threads): Likewise.
|
|
|
|
|
|
(handle_inferior_event): Likewise.
|
|
|
|
|
|
(restart_threads): Likewise.
|
|
|
|
|
|
(finish_step_over): Likewise.
|
|
|
|
|
|
(keep_going_stepped_thread): Likewise.
|
|
|
|
|
|
* linux-nat.c (attach_proc_task_lwp_callback): Likewise.
|
|
|
|
|
|
(linux_handle_extended_wait): Likewise.
|
|
|
|
|
|
* record-btrace.c (get_thread_current_frame_id): Likewise.
|
|
|
|
|
|
* record-full.c (record_full_wait_1): Likewise.
|
|
|
|
|
|
* remote.c (remote_target::process_initial_stop_replies): Likewise.
|
|
|
|
|
|
* target.c (target_resume): Likewise.
|
|
|
|
|
|
* thread.c (set_running_thread): Likewise.
|
|
|
|
|
|
|
2020-02-04 02:24:34 +01:00
|
|
|
|
2020-02-03 Alok Kumar Sharma <AlokKumar.Sharma@amd.com>
|
|
|
|
|
|
|
|
|
|
|
|
* f-valprint.c (f77_print_array_1): Changed datatype of index
|
|
|
|
|
|
variable to LONGEST from int to enable it to contain bound
|
|
|
|
|
|
values correctly.
|
|
|
|
|
|
|
2020-02-03 13:07:02 +01:00
|
|
|
|
2020-02-03 Maciej W. Rozycki <macro@wdc.com>
|
|
|
|
|
|
|
|
|
|
|
|
* riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
|
|
|
|
|
|
(supply_fpregset_regnum, fill_fpregset): Handle regset buffer
|
|
|
|
|
|
offsets according to FLEN determined.
|
|
|
|
|
|
(riscv_linux_nat_target::read_description): Determine FLEN
|
|
|
|
|
|
dynamically.
|
|
|
|
|
|
(riscv_linux_nat_target::fetch_registers): Size regset buffer
|
|
|
|
|
|
according to FLEN determined.
|
|
|
|
|
|
(riscv_linux_nat_target::store_registers): Likewise.
|
|
|
|
|
|
|
gdb: Do not print empty-group regs when printing general ones
When the command "info registers" (same as "info registers general"),
is issued, _all_ the registers from a tdesc XML are printed. This
includes the registers with empty register groups (set as "") which
are supposed to be only printed by "info registers all" (or "info
all-registers").
This bug got introduced after all the overhauls that the
tdesc_register_in_reggroup_p() went through. You can see that the
logic of tdesc_register_in_reggroup_p() did NOT remain the same after
all those changes:
git difftool c9c895b9666..HEAD -- gdb/target-descriptions.c
With the current implementation, when the reg->group is an empty
string, this function returns -1, while in the working revision
(c9c895b9666), it returned 0. This patch makes sure that the 0 is
returned again.
The old implementation of tdesc_register_in_reggroup_p() returned
-1 when "reggroup" was set to "all_reggroups" at line 4 below:
1 tdesc_register_reggroup_p (...)
2 {
3 ...
4 ret = tdesc_register_in_reggroup_p (gdbarch, regno, reggroup);
5 if (ret != -1)
6 return ret;
7
8 return default_register_reggroup_p (gdbarch, regno, reggroup);
9 }
As a result, the execution continued at line 8 and the
default_register_reggroup_p(..., reggroup=all_reggroups) would
return 1. However, with the current implementation of
tdesc_register_in_reggroup_p() that allows checking against any
arbitrary group name, it returns 0 when comparing the "reg->group"
against the string "all" which is the group name for "all_reggroups".
I have added a special check to cover this case and
"info all-registers" works as expected.
gdb/ChangeLog:
* target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
when reg->group is empty and reggroup is not.
Change-Id: I9eaf9d7fb36410ed5684ae652fe4756b1b2e61a3
2020-01-31 23:10:11 +01:00
|
|
|
|
2020-02-01 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
|
|
|
|
|
|
when reg->group is empty and reggroup is not.
|
|
|
|
|
|
|
2020-01-22 20:30:40 +01:00
|
|
|
|
2020-01-31 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
|
|
|
|
|
|
Call beneath target's mourn_inferior after unpushing.
|
|
|
|
|
|
|
gdb/tui: Disassembler scrolling of very small programs
In TUI mode, if the disassembly output for the program is less than
one screen long, then currently if the user scrolls down until on the
last assembly instruction is displayed and then tries to scroll up
using Page-Up, the display doesn't update - they are stuck viewing the
last line.
If the user tries to scroll up using the Up-Arrow, then the display
scrolls normally.
What is happening is on the Page-Up we ask GDB to scroll backward the
same number of lines as the height of the TUI ASM window. The back
scanner, which looks for a good place to start disassembling, fails to
find a starting address which will provide the requested number of new
lines before we get back to the original starting address (which is
not surprising, our whole program contains less than a screen height
of instructions), as a result the back scanner gives up and returns
the original starting address.
When we scroll with Up-Arrow we only ask the back scanner to find 1
new instruction, which it manages to do, so this scroll works.
The solution here is, when we fail to find enough instructions, to
return the lowest address we did manage to find. This will ensure we
jump to the lowest possible address in the disassembly output.
gdb/ChangeLog:
PR tui/9765
* tui/tui-disasm.c (tui_find_disassembly_address): If we don't
have enough lines to fill the screen, still return the lowest
address we found.
gdb/testsuite/ChangeLog:
PR tui/9765
* gdb.tui/tui-layout-asm-short-prog.S: New file.
* gdb.tui/tui-layout-asm-short-prog.exp: New file.
Change-Id: I6a6a7972c68a0559e9717fd8d82870b669a40af3
2020-01-24 13:46:56 +01:00
|
|
|
|
2020-01-31 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR tui/9765
|
|
|
|
|
|
* tui/tui-disasm.c (tui_find_disassembly_address): If we don't
|
|
|
|
|
|
have enough lines to fill the screen, still return the lowest
|
|
|
|
|
|
address we found.
|
|
|
|
|
|
|
2020-01-24 15:18:56 +01:00
|
|
|
|
2020-01-31 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-win.c (_initialize_tui_win): Update help text for '+',
|
|
|
|
|
|
'-', '<', and '>' commands.
|
|
|
|
|
|
|
2020-01-29 18:53:55 +01:00
|
|
|
|
2020-01-29 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
Sergio Durigan Junior <sergiodj@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infcmd.c (construct_inferior_arguments): Assert that
|
|
|
|
|
|
'argc' is greater than 0.
|
|
|
|
|
|
|
Recognize more program breakpoint patterns
New in v3:
- Code cleanups based on reviews.
New in v2:
- Fixed misc problems based on reviews.
- Switched to using gdbarch_program_breakpoint_here_p as opposed to
gdbarch_insn_is_breakpoint.
- Fixed matching of brk instructions. Previously the mask was incorrect, which
was showing up as a few failures in the testsuite. Now it is clean.
- New testcase (separate patch).
- Moved program_breakpoint_here () to arch-utils.c and made it the default
implementation of gdbarch_program_breakpoint_here_p.
--
It was reported to me that program breakpoints (permanent ones inserted into
the code itself) other than the one GDB uses for AArch64 (0xd4200000) do not
generate visible stops when continuing, and GDB will continue spinning
infinitely.
This happens because GDB, upon hitting one of those program breakpoints, thinks
the SIGTRAP came from a delayed breakpoint hit...
(gdb) x/i $pc
=> 0x4005c0 <problem_function>: brk #0x90f
(gdb) c
Continuing.
infrun: clear_proceed_status_thread (process 14198)
infrun: proceed (addr=0xffffffffffffffff, signal=GDB_SIGNAL_DEFAULT)
infrun: proceed: resuming process 14198
infrun: resume (step=0, signal=GDB_SIGNAL_0), trap_expected=0, current thread [process 14198] at 0x4005c0
infrun: infrun_async(1)
infrun: prepare_to_wait
infrun: target_wait (-1.0.0, status) =
infrun: 14198.14198.0 [process 14198],
infrun: status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: handle_inferior_event status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: stop_pc = 0x4005c0
infrun: delayed software breakpoint trap, ignoring
infrun: no stepping, continue
infrun: resume (step=0, signal=GDB_SIGNAL_0), trap_expected=0, current thread [process 14198] at 0x4005c0
infrun: prepare_to_wait
infrun: target_wait (-1.0.0, status) =
infrun: 14198.14198.0 [process 14198],
infrun: status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: handle_inferior_event status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: stop_pc = 0x4005c0
infrun: delayed software breakpoint trap, ignoring
infrun: no stepping, continue
infrun: resume (step=0, signal=GDB_SIGNAL_0), trap_expected=0, current thread [process 14198] at 0x4005c0
infrun: prepare_to_wait
infrun: target_wait (-1.0.0, status) =
infrun: 14198.14198.0 [process 14198],
infrun: status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: handle_inferior_event status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: stop_pc = 0x4005c0
infrun: delayed software breakpoint trap, ignoring
infrun: no stepping, continue
infrun: resume (step=0, signal=GDB_SIGNAL_0), trap_expected=0, current thread [process 14198] at 0x4005c0
infrun: prepare_to_wait
infrun: target_wait (-1.0.0, status) =
infrun: 14198.14198.0 [process 14198],
infrun: status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: handle_inferior_event status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: stop_pc = 0x4005c0
infrun: delayed software breakpoint trap, ignoring
infrun: no stepping, continue
infrun: resume (step=0, signal=GDB_SIGNAL_0), trap_expected=0, current thread [process 14198] at 0x4005c0
infrun: prepare_to_wait
infrun: target_wait (-1.0.0, status) =
infrun: 14198.14198.0 [process 14198],
infrun: status->kind = stopped, signal = GDB_SIGNAL_TRAP
...
... which is not the case.
If the program breakpoint is one GDB recognizes, then it will stop when it
hits it.
(gdb) x/i $pc
=> 0x4005c0 <problem_function>: brk #0x0
(gdb) c
Continuing.
infrun: clear_proceed_status_thread (process 14193)
infrun: proceed (addr=0xffffffffffffffff, signal=GDB_SIGNAL_DEFAULT)
infrun: proceed: resuming process 14193
infrun: resume (step=0, signal=GDB_SIGNAL_0), trap_expected=0, current thread [process 14193] at 0x4005c0
infrun: infrun_async(1)
infrun: prepare_to_wait
infrun: target_wait (-1.0.0, status) =
infrun: 14193.14193.0 [process 14193],
infrun: status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: handle_inferior_event status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: stop_pc = 0x4005c0
infrun: random signal (GDB_SIGNAL_TRAP)
infrun: stop_waiting
infrun: stop_all_threads
infrun: stop_all_threads, pass=0, iterations=0
infrun: process 14193 not executing
infrun: stop_all_threads, pass=1, iterations=1
infrun: process 14193 not executing
infrun: stop_all_threads done
Program received signal SIGTRAP, Trace/breakpoint trap.
problem_function () at brk_0.c:7
7 asm("brk %0\n\t" ::"n"(0x0));
infrun: infrun_async(0)
Otherwise GDB will keep trying to resume the inferior and will keep
seeing the SIGTRAP's, without stopping.
To the user it appears GDB has gone into an infinite loop, interruptible only
by Ctrl-C.
Also, windbg seems to use a different variation of AArch64 breakpoint compared
to GDB. This causes problems when debugging Windows on ARM binaries, when
program breakpoints are being used.
The proposed patch creates a new gdbarch method (gdbarch_program_breakpoint_here_p)
that tells GDB whether the underlying instruction is a breakpoint instruction
or not.
This is more general than only checking for the instruction GDB uses as
breakpoint.
The existing logic is still preserved for targets that do not implement this
new gdbarch method.
The end result is like so:
(gdb) x/i $pc
=> 0x4005c0 <problem_function>: brk #0x90f
(gdb) c
Continuing.
infrun: clear_proceed_status_thread (process 16417)
infrun: proceed (addr=0xffffffffffffffff, signal=GDB_SIGNAL_DEFAULT)
infrun: proceed: resuming process 16417
infrun: resume (step=0, signal=GDB_SIGNAL_0), trap_expected=0, current thread [process 16417] at 0x4005c0
infrun: infrun_async(1)
infrun: prepare_to_wait
infrun: target_wait (-1.0.0, status) =
infrun: 16417.16417.0 [process 16417],
infrun: status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: handle_inferior_event status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: stop_pc = 0x4005c0
infrun: random signal (GDB_SIGNAL_TRAP)
infrun: stop_waiting
infrun: stop_all_threads
infrun: stop_all_threads, pass=0, iterations=0
infrun: process 16417 not executing
infrun: stop_all_threads, pass=1, iterations=1
infrun: process 16417 not executing
infrun: stop_all_threads done
Program received signal SIGTRAP, Trace/breakpoint trap.
problem_function () at brk.c:7
7 asm("brk %0\n\t" ::"n"(0x900 + 0xf));
infrun: infrun_async(0)
gdb/ChangeLog:
2020-01-29 Luis Machado <luis.machado@linaro.org>
* aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
(BRK_INSN_MASK): Define to 0xd4200000.
(aarch64_program_breakpoint_here_p): New function.
(aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
* arch-utils.c (default_program_breakpoint_here_p): Moved from
breakpoint.c.
* arch-utils.h (default_program_breakpoint_here_p): Moved from
breakpoint.h
* breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
call gdbarch_program_breakpoint_here_p.
(program_breakpoint_here): Moved to arch-utils.c, renamed to
default_program_breakpoint_here_p, changed return type to bool and
simplified.
* breakpoint.h (program_breakpoint_here): Moved prototype to
arch-utils.h, renamed to default_program_breakpoint_here_p and changed
return type to bool.
* gdbarch.c: Regenerate.
* gdbarch.h: Regenerate.
* gdbarch.sh (program_breakpoint_here_p): New method.
* infrun.c (handle_signal_stop): Call
gdbarch_program_breakpoint_here_p.
2019-12-23 16:04:26 +01:00
|
|
|
|
2020-01-29 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
|
|
|
|
|
|
(BRK_INSN_MASK): Define to 0xd4200000.
|
|
|
|
|
|
(aarch64_program_breakpoint_here_p): New function.
|
|
|
|
|
|
(aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
|
|
|
|
|
|
* arch-utils.c (default_program_breakpoint_here_p): Moved from
|
|
|
|
|
|
breakpoint.c.
|
|
|
|
|
|
* arch-utils.h (default_program_breakpoint_here_p): Moved from
|
|
|
|
|
|
breakpoint.h
|
|
|
|
|
|
* breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
|
|
|
|
|
|
call gdbarch_program_breakpoint_here_p.
|
|
|
|
|
|
(program_breakpoint_here): Moved to arch-utils.c, renamed to
|
|
|
|
|
|
default_program_breakpoint_here_p, changed return type to bool and
|
|
|
|
|
|
simplified.
|
|
|
|
|
|
* breakpoint.h (program_breakpoint_here): Moved prototype to
|
|
|
|
|
|
arch-utils.h, renamed to default_program_breakpoint_here_p and changed
|
|
|
|
|
|
return type to bool.
|
|
|
|
|
|
* gdbarch.c: Regenerate.
|
|
|
|
|
|
* gdbarch.h: Regenerate.
|
|
|
|
|
|
* gdbarch.sh (program_breakpoint_here_p): New method.
|
|
|
|
|
|
* infrun.c (handle_signal_stop): Call
|
|
|
|
|
|
gdbarch_program_breakpoint_here_p.
|
|
|
|
|
|
|
2020-01-27 02:43:17 +01:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ctfread.c (struct ctf_fp_info): Reindent.
|
|
|
|
|
|
(_initialize_ctfread): Remove.
|
|
|
|
|
|
|
Virtualize "readin" and "compunit_symtab"
This patch removes the "readin" and "compunit_symtab" members from
partial_symtab, replacing them with methods. Then it introduces a new
"standard_psymtab" class, which restores these members; and changes
the symbol readers to use this intermediate class as the base class of
their partial symtab subclasses.
The reason for this is to make it possible for a symbol reader to
implement an alternate mapping between partial and full symbol tables.
This is important in order to be able to share psymtabs across
objfiles -- whether a psymtab has been "readin" is objfile-dependent,
as are the pointers to the full symbol tables.
gdb/ChangeLog
2020-01-26 Tom Tromey <tom@tromey.com>
* psymtab.c (partial_map_expand_apply)
(psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
(psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
(psym_print_stats, psym_expand_symtabs_for_function)
(psym_map_symbol_filenames, psym_map_matching_symbols)
(psym_expand_symtabs_matching)
(partial_symtab::read_dependencies, maintenance_info_psymtabs)
(maintenance_check_psymtabs): Use new methods.
* psympriv.h (struct partial_symtab) <readin_p,
get_compunit_symtab>: New methods.
<readin, compunit_symtab>: Remove members.
(struct standard_psymtab): New.
(struct legacy_psymtab): Derive from standard_psymtab.
* dwarf2read.h (struct dwarf2_psymtab): Derive from
standard_psymtab.
* ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
Change-Id: Idb923f196d7e03bf7cb9cfc8134ed06dd3f211ce
2019-10-23 17:50:58 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* psymtab.c (partial_map_expand_apply)
|
|
|
|
|
|
(psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
|
|
|
|
|
|
(psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
|
|
|
|
|
|
(psym_print_stats, psym_expand_symtabs_for_function)
|
|
|
|
|
|
(psym_map_symbol_filenames, psym_map_matching_symbols)
|
|
|
|
|
|
(psym_expand_symtabs_matching)
|
|
|
|
|
|
(partial_symtab::read_dependencies, maintenance_info_psymtabs)
|
|
|
|
|
|
(maintenance_check_psymtabs): Use new methods.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab) <readin_p,
|
|
|
|
|
|
get_compunit_symtab>: New methods.
|
|
|
|
|
|
<readin, compunit_symtab>: Remove members.
|
|
|
|
|
|
(struct standard_psymtab): New.
|
|
|
|
|
|
(struct legacy_psymtab): Derive from standard_psymtab.
|
|
|
|
|
|
* dwarf2read.h (struct dwarf2_psymtab): Derive from
|
|
|
|
|
|
standard_psymtab.
|
|
|
|
|
|
* ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
|
|
|
|
|
|
|
2019-10-23 17:46:25 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (xcoff_psymtab_to_symtab_1): Call
|
|
|
|
|
|
read_dependencies. Add assert.
|
|
|
|
|
|
* psymtab.c (partial_symtab::read_dependencies): New method.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab) <read_dependencies>: New
|
|
|
|
|
|
method.
|
|
|
|
|
|
* mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
|
|
|
|
|
|
* dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
|
|
|
|
|
|
read_dependencies.
|
|
|
|
|
|
* dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
|
|
|
|
|
|
Add assert.
|
|
|
|
|
|
|
2019-10-23 17:40:54 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
|
|
|
|
|
|
Call expand_psymtab.
|
|
|
|
|
|
(xcoff_read_symtab): Call expand_psymtab.
|
|
|
|
|
|
(xcoff_start_psymtab, xcoff_end_psymtab): Set
|
|
|
|
|
|
legacy_expand_psymtab.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab) <expand_psymtab>: New
|
|
|
|
|
|
method.
|
|
|
|
|
|
(struct legacy_psymtab) <expand_psymtab>: Implement.
|
|
|
|
|
|
<legacy_expand_psymtab>: New member.
|
|
|
|
|
|
* mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
|
|
|
|
|
|
(parse_partial_symbols): Set legacy_expand_psymtab.
|
|
|
|
|
|
(psymtab_to_symtab_1): Change argument order. Call
|
|
|
|
|
|
expand_psymtab.
|
|
|
|
|
|
(new_psymtab): Set legacy_expand_psymtab.
|
|
|
|
|
|
* dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
|
|
|
|
|
|
* dwarf2read.c (dwarf2_psymtab::read_symtab): Call
|
|
|
|
|
|
expand_psymtab.
|
|
|
|
|
|
(dwarf2_psymtab::expand_psymtab): Rename from
|
|
|
|
|
|
psymtab_to_symtab_1. Call expand_psymtab.
|
|
|
|
|
|
* dbxread.c (start_psymtab): Set legacy_expand_psymtab.
|
|
|
|
|
|
(dbx_end_psymtab): Likewise.
|
|
|
|
|
|
(dbx_psymtab_to_symtab_1): Change argument order. Call
|
|
|
|
|
|
expand_psymtab.
|
|
|
|
|
|
(dbx_read_symtab): Call expand_psymtab.
|
|
|
|
|
|
* ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
|
|
|
|
|
|
(ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
|
|
|
|
|
|
(ctf_psymtab::read_symtab): Call expand_psymtab.
|
|
|
|
|
|
|
2019-10-23 05:13:10 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (xcoff_read_symtab): Remove prints. Add assert.
|
|
|
|
|
|
* psymtab.c (psymtab_to_symtab): Print verbose "Reading"
|
|
|
|
|
|
messages.
|
|
|
|
|
|
* mdebugread.c (mdebug_read_symtab): Remove prints.
|
|
|
|
|
|
* dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints. Add
|
|
|
|
|
|
assert.
|
|
|
|
|
|
* dbxread.c (dbx_read_symtab): Remove prints. Add assert.
|
|
|
|
|
|
|
Introduce partial_symtab::read_symtab method
This introduces a new partial_symtab::read_symtab method, and updates
the symbol readers to subclass partial_symtab and implement this
method. The old read_symtab and read_symtab_private members are
removed.
In practice, only DWARF and CTF are truly updated to take advantage of
the new setup. The other symbol readers are less actively maintained,
and so this patch also introduces a "legacy_psymtab", which
essentially works the same way as the old partial_symtab.
(Note that, without more knowledge of the interaction between these
symbol readers, fixing this to remove the new (small) overhead is not
trivial, because these readers copy the read_symtab pointer between
partial symtabs.)
gdb/ChangeLog
2020-01-26 Tom Tromey <tom@tromey.com>
* xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
(xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
(xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
legacy_symtab.
* stabsread.h (dbx_end_psymtab): Use legacy_symtab.
* psymtab.c (psymtab_to_symtab): Call method.
(dump_psymtab): Update.
* psympriv.h (struct partial_symtab): Add virtual destructor.
<read_symtab>: New method.
(struct legacy_symtab): New.
* mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
(struct pst_map) <pst>: Now a legacy_psymtab.
(parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
(new_psymtab): Use legacy_psymtab.
* dwarf2read.h (struct dwarf2_psymtab): New.
(struct dwarf2_per_cu_data) <psymtab>: Use it.
* dwarf2read.c (dwarf2_create_include_psymtab)
(dwarf2_build_include_psymtabs, create_type_unit_group)
(create_partial_symtab, process_psymtab_comp_unit_reader)
(build_type_psymtabs_reader, build_type_psymtab_dependencies)
(set_partial_user): Use dwarf2_psymtab.
(dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
(psymtab_to_symtab_1, process_full_comp_unit)
(process_full_type_unit, dwarf2_ranges_read)
(dwarf2_get_pc_bounds, psymtab_include_file_name)
(dwarf_decode_lines): Use dwarf2_psymtab.
* dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
(add_address_entry_worker, write_one_signatured_type)
(recursively_count_psymbols, recursively_write_psymbols)
(write_one_signatured_type, psyms_seen_size, write_gdbindex)
(write_debug_names): Likewise.
* dbxread.c (struct header_file_location): Take a legacy_psymtab.
<pst>: Now a legacy_psymtab.
(find_corresponding_bincl_psymtab): Return a legacy_psymtab.
(read_dbx_symtab, start_psymtab, dbx_end_psymtab)
(dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
* ctfread.c (struct ctf_psymtab): New.
(ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
ctf_psymtab.
(ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
(create_partial_symtab): Return a ctf_psymtab.
(scan_partial_symbols): Update.
Change-Id: Ia57a828786867d6ad03200af8f996f48ed15285e
2019-10-23 01:28:37 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
|
|
|
|
|
|
(xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
|
|
|
|
|
|
(xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
|
|
|
|
|
|
legacy_symtab.
|
|
|
|
|
|
* stabsread.h (dbx_end_psymtab): Use legacy_symtab.
|
|
|
|
|
|
* psymtab.c (psymtab_to_symtab): Call method.
|
|
|
|
|
|
(dump_psymtab): Update.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab): Add virtual destructor.
|
|
|
|
|
|
<read_symtab>: New method.
|
|
|
|
|
|
(struct legacy_symtab): New.
|
|
|
|
|
|
* mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
|
|
|
|
|
|
(struct pst_map) <pst>: Now a legacy_psymtab.
|
|
|
|
|
|
(parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
|
|
|
|
|
|
(new_psymtab): Use legacy_psymtab.
|
|
|
|
|
|
* dwarf2read.h (struct dwarf2_psymtab): New.
|
|
|
|
|
|
(struct dwarf2_per_cu_data) <psymtab>: Use it.
|
|
|
|
|
|
* dwarf2read.c (dwarf2_create_include_psymtab)
|
|
|
|
|
|
(dwarf2_build_include_psymtabs, create_type_unit_group)
|
|
|
|
|
|
(create_partial_symtab, process_psymtab_comp_unit_reader)
|
|
|
|
|
|
(build_type_psymtabs_reader, build_type_psymtab_dependencies)
|
|
|
|
|
|
(set_partial_user): Use dwarf2_psymtab.
|
|
|
|
|
|
(dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
|
|
|
|
|
|
(psymtab_to_symtab_1, process_full_comp_unit)
|
|
|
|
|
|
(process_full_type_unit, dwarf2_ranges_read)
|
|
|
|
|
|
(dwarf2_get_pc_bounds, psymtab_include_file_name)
|
|
|
|
|
|
(dwarf_decode_lines): Use dwarf2_psymtab.
|
|
|
|
|
|
* dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
|
|
|
|
|
|
(add_address_entry_worker, write_one_signatured_type)
|
|
|
|
|
|
(recursively_count_psymbols, recursively_write_psymbols)
|
|
|
|
|
|
(write_one_signatured_type, psyms_seen_size, write_gdbindex)
|
|
|
|
|
|
(write_debug_names): Likewise.
|
|
|
|
|
|
* dbxread.c (struct header_file_location): Take a legacy_psymtab.
|
|
|
|
|
|
<pst>: Now a legacy_psymtab.
|
|
|
|
|
|
(find_corresponding_bincl_psymtab): Return a legacy_psymtab.
|
|
|
|
|
|
(read_dbx_symtab, start_psymtab, dbx_end_psymtab)
|
|
|
|
|
|
(dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
|
|
|
|
|
|
* ctfread.c (struct ctf_psymtab): New.
|
|
|
|
|
|
(ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
|
|
|
|
|
|
ctf_psymtab.
|
|
|
|
|
|
(ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
|
|
|
|
|
|
(create_partial_symtab): Return a ctf_psymtab.
|
|
|
|
|
|
(scan_partial_symbols): Update.
|
|
|
|
|
|
|
2019-10-23 01:08:16 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (xcoff_start_psymtab): Use new.
|
|
|
|
|
|
* psymtab.c (partial_symtab::partial_symtab): New constructor,
|
|
|
|
|
|
renamed from start_psymtab_common.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab): Add new constructor.
|
|
|
|
|
|
(start_psymtab_common): Don't declare.
|
|
|
|
|
|
* mdebugread.c (parse_partial_symbols): Use new.
|
|
|
|
|
|
* dwarf2read.c (create_partial_symtab): Use new.
|
|
|
|
|
|
* dbxread.c (start_psymtab): Use new.
|
|
|
|
|
|
* ctfread.c (create_partial_symtab): Use new.
|
|
|
|
|
|
|
2019-10-23 00:57:35 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (xcoff_end_psymtab): Use new.
|
|
|
|
|
|
* psymtab.c (start_psymtab_common): Use new.
|
|
|
|
|
|
(partial_symtab::partial_symtab): Rename from allocate_psymtab.
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab): Add parameters to
|
|
|
|
|
|
constructor. Don't inline.
|
|
|
|
|
|
(allocate_psymtab): Don't declare.
|
|
|
|
|
|
* mdebugread.c (new_psymtab): Use new.
|
|
|
|
|
|
* dwarf2read.c (dwarf2_create_include_psymtab): Use new.
|
|
|
|
|
|
* dbxread.c (dbx_end_psymtab): Use new.
|
|
|
|
|
|
|
2019-10-23 00:51:55 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
|
|
|
|
|
|
allocate_psymtab. Update documentation.
|
|
|
|
|
|
* psymtab.c (psymtab_storage::install_psymtab): Rename from
|
|
|
|
|
|
allocate_psymtab. Do not use new.
|
|
|
|
|
|
(allocate_psymtab): Use new. Update.
|
|
|
|
|
|
|
2019-10-23 00:47:27 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
|
|
|
|
|
|
* psymtab.c (psym_print_stats): Update.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab) <readin,
|
|
|
|
|
|
psymtabs_addrmap_supported, anonymous>: Now bool.
|
|
|
|
|
|
* mdebugread.c (psymtab_to_symtab_1): Update.
|
|
|
|
|
|
* dwarf2read.c (create_type_unit_group, create_partial_symtab)
|
|
|
|
|
|
(build_type_psymtabs_reader, psymtab_to_symtab_1)
|
|
|
|
|
|
(process_full_comp_unit, process_full_type_unit): Update.
|
|
|
|
|
|
* dbxread.c (dbx_psymtab_to_symtab_1): Update.
|
|
|
|
|
|
* ctfread.c (psymtab_to_symtab): Update.
|
|
|
|
|
|
|
2019-10-16 22:06:43 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* mdebugread.c (parse_partial_symbols): Use discard_psymtab.
|
|
|
|
|
|
* psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
|
|
|
|
|
|
* psymtab.c (psymtab_storage): Delete psymtabs.
|
|
|
|
|
|
(psymtab_storage::allocate_psymtab): Use new.
|
|
|
|
|
|
(psymtab_storage::discard_psymtab): Use delete.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab): Add constructor and
|
|
|
|
|
|
initializers.
|
|
|
|
|
|
|
2019-10-23 01:41:58 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* machoread.c: Do not include psympriv.h.
|
|
|
|
|
|
|
2019-12-21 14:47:17 +01:00
|
|
|
|
2020-01-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Mention the new option and the set/show commands.
|
|
|
|
|
|
|
Implement 'set/show exec-file-mismatch'.
This option allows to tell GDB to detect and possibly handle mismatched exec-files.
A recurrent problem with GDB is that GDB uses the wrong exec-file
when using the attach/detach commands successively.
Also, in case the user specifies a file on the command line but attaches
to the wrong PID, this error is not made visible and gives a not user
understandable behaviour.
For example:
$ gdb
...
(gdb) atta 2682 ############################################ PID running 'sleepers' executable
Attaching to process 2682
[New LWP 2683]
[New LWP 2684]
[New LWP 2685]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
0x00007f5ff829f603 in select () at ../sysdeps/unix/syscall-template.S:84
84 ../sysdeps/unix/syscall-template.S: No such file or directory.
(gdb) det
Detaching from program: /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers, process 2682
[Inferior 1 (process 2682) detached]
(gdb) atta 31069 ############################################ PID running 'gdb' executable
Attaching to program: /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers, process 31069
Reading symbols from /lib64/ld-linux-x86-64.so.2...
Reading symbols from /usr/lib/debug/.build-id/60/6df9c355103e82140d513bc7a25a635591c153.debug...
0x00007f43c23478a0 in ?? ()
(gdb) bt
#0 0x00007f43c23478a0 in ?? ()
#1 0x0000558909e3ad91 in ?? ()
#2 0x0000202962646700 in ?? ()
#3 0x00007ffc69c74e70 in ?? ()
#4 0x000055890c1d2350 in ?? ()
#5 0x0000000000000000 in ?? ()
(gdb)
The second attach has kept the executable of the first attach.
(in this case, 31069 is the PID of a GDB, that has nothing to do
with the first determined 'sleepers' executable).
Similarly, if specifying an executable, but attaching to a wrong pid,
we get:
gdb /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers
...
Reading symbols from /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers...
(gdb) atta 31069 ############################################ PID running 'gdb' executable
Attaching to program: /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers, process 31069
Reading symbols from /lib64/ld-linux-x86-64.so.2...
Reading symbols from /usr/lib/debug/.build-id/60/6df9c355103e82140d513bc7a25a635591c153.debug...
0x00007f43c23478a0 in ?? ()
(gdb) bt
#0 0x00007f43c23478a0 in ?? ()
#1 0x0000558909e3ad91 in ?? ()
#2 0x0000202962646700 in ?? ()
#3 0x00007ffc69c74e70 in ?? ()
#4 0x000055890c1d2350 in ?? ()
#5 0x0000000000000000 in ?? ()
(gdb)
And it is unclear to the user what has happened/what is going wrong.
This patch series implements a new option:
(gdb) apropos exec-file-mismatch
set exec-file-mismatch -- Set exec-file-mismatch handling (ask|warn|off).
show exec-file-mismatch -- Show exec-file-mismatch handling (ask|warn|off).
(gdb) help set exec-file-mismatch
Set exec-file-mismatch handling (ask|warn|off).
Specifies how to handle a mismatch between the current exec-file name
loaded by GDB and the exec-file name automatically determined when attaching
to a process:
ask - warn the user and ask whether to load the determined exec-file.
warn - warn the user, but do not change the exec-file.
off - do not check for mismatch.
"ask" means: in case of mismatch between the current exec-file name
and the automatically determined exec-file name of the PID we are attaching to,
give a warning to the user and ask whether to load the automatically determined
exec-file.
"warn" means: in case of mismatch, just give a warning to the user.
"off" means: do not check for mismatch.
This fixes PR gdb/17626.
There was a previous trial to fix this PR.
See https://sourceware.org/ml/gdb-patches/2015-07/msg00118.html
This trial was however only fixing the problem for the automatically
determined executable files when doing attach.
It was differentiating the 'user specified executable files' ("sticky")
from the executable files automatically found by GDB.
But such user specified sticky executables are in most cases due
to a wrong manipulation by the user, giving unexpected results
such as backtrace showing no function like in the above example.
This patch ensures that whenever a process executable can be
determined, that the user is warned if there is a mismatch.
The same tests as above then give:
(gdb) atta 2682
Attaching to process 2682
[New LWP 2683]
[New LWP 2684]
[New LWP 2685]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
0x00007f5ff829f603 in select () at ../sysdeps/unix/syscall-template.S:84
84 ../sysdeps/unix/syscall-template.S: No such file or directory.
(gdb) det
Detaching from program: /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers, process 2682
[Inferior 1 (process 2682) detached]
(gdb) atta 31069
Attaching to program: /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers, process 31069
warning: Mismatch between current exec-file /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers
and automatically determined exec-file /bd/home/philippe/gdb/git/build_fixes/gdb/gdb
exec-file-mismatch handling is currently "ask"
Load new symbol table from "/bd/home/philippe/gdb/git/build_fixes/gdb/gdb"? (y or n) y
Reading symbols from /bd/home/philippe/gdb/git/build_fixes/gdb/gdb...
Setting up the environment for debugging gdb.
...
Reading symbols from /usr/lib/debug/.build-id/60/6df9c355103e82140d513bc7a25a635591c153.debug...
0x00007f43c23478a0 in __poll_nocancel () at ../sysdeps/unix/syscall-template.S:84
84 ../sysdeps/unix/syscall-template.S: No such file or directory.
(top-gdb) bt
During symbol reading: incomplete CFI data; unspecified registers (e.g., rax) at 0x7f43c23478ad
During symbol reading: unsupported tag: 'DW_TAG_unspecified_type'
During symbol reading: cannot get low and high bounds for subprogram DIE at 0x12282a7
During symbol reading: Child DIE 0x12288ba and its abstract origin 0x1228b26 have different parents
During symbol reading: DW_AT_call_target target DIE has invalid low pc, for referencing DIE 0x1229540 [in module /bd/home/philippe/gdb/git/build_fixes/gdb/gdb]
#0 0x00007f43c23478a0 in __poll_nocancel () at ../sysdeps/unix/syscall-template.S:84
#1 0x0000558909e3ad91 in poll (__timeout=-1, __nfds=<optimized out>, __fds=<optimized out>) at /usr/include/x86_64-linux-gnu/bits/poll2.h:46
#2 gdb_wait_for_event (block=block@entry=1) at ../../fixes/gdb/event-loop.c:772
#3 0x0000558909e3aef4 in gdb_do_one_event () at ../../fixes/gdb/event-loop.c:347
#4 0x0000558909e3b085 in gdb_do_one_event () at ../../fixes/gdb/common/common-exceptions.h:219
#5 start_event_loop () at ../../fixes/gdb/event-loop.c:371
During symbol reading: Member function "~_Sp_counted_base" (offset 0x1c69bf7) is virtual but the vtable offset is not specified
During symbol reading: Multiple children of DIE 0x1c8f5a0 refer to DIE 0x1c8f0ee as their abstract origin
#6 0x0000558909ed3b78 in captured_command_loop () at ../../fixes/gdb/main.c:331
#7 0x0000558909ed4b6d in captured_main (data=<optimized out>) at ../../fixes/gdb/main.c:1174
#8 gdb_main (args=<optimized out>) at ../../fixes/gdb/main.c:1190
#9 0x0000558909c1e9a8 in main (argc=<optimized out>, argv=<optimized out>) at ../../fixes/gdb/gdb.c:32
(top-gdb)
gdb /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers
...
Reading symbols from /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers...
(gdb) atta 31069
Attaching to program: /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers, process 31069
warning: Mismatch between current exec-file /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers
and automatically determined exec-file /bd/home/philippe/gdb/git/build_fixes/gdb/gdb
exec-file-mismatch handling is currently "ask"
Load new symbol table from "/bd/home/philippe/gdb/git/build_fixes/gdb/gdb"? (y or n) y
Reading symbols from /bd/home/philippe/gdb/git/build_fixes/gdb/gdb...
Setting up the environment for debugging gdb.
....
In other words, it now works as intuitively expected by the user.
If ever the user gave the correct executable on the command line,
then attached to the wrong pid, then confirmed loading the wrong executable,
the user can simply fix this by detaching, and attaching to the correct pid,
GDB will then tell again to the user that the exec-file might better
be loaded.
The default value of "ask" is chosen instead of e.g. "warn" as in most
cases, switching of executable will be the correct action,
and in any case, the user can decide to not load the executable,
as GDB asks a confirmation to the user to load the new executable.
For settings "ask" and "warn", the new function validate_exec_file ()
tries to get the inferior pid exec file and compares it with the current
exec file. In case of mismatch, it warns the user and optionally load
the executable.
This function is called in the attach_command implementation to cover
most cases of attaching to a running process.
It must also be called in remote.c, as the attach command is not supported
for all types of remote gdbserver.
gdb/ChangeLog
2020-01-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
* exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
(show_exec_file_mismatch_command, set_exec_file_mismatch_command)
(validate_exec_file): New variables, enums, functions.
(exec_file_locate_attach, print_section_info): Style the filenames.
(_initialize_exec): Install show_exec_file_mismatch_command and
set_exec_file_mismatch_command.
* gdbcore.h (validate_exec_file): Declare.
* infcmd.c (attach_command): Call validate_exec_file.
* remote.c ( remote_target::remote_add_inferior): Likewise.
2019-12-21 10:55:11 +01:00
|
|
|
|
2020-01-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
|
|
|
|
|
|
|
|
|
|
|
|
* exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
|
|
|
|
|
|
(show_exec_file_mismatch_command, set_exec_file_mismatch_command)
|
|
|
|
|
|
(validate_exec_file): New variables, enums, functions.
|
|
|
|
|
|
(exec_file_locate_attach, print_section_info): Style the filenames.
|
|
|
|
|
|
(_initialize_exec): Install show_exec_file_mismatch_command and
|
|
|
|
|
|
set_exec_file_mismatch_command.
|
|
|
|
|
|
* gdbcore.h (validate_exec_file): Declare.
|
|
|
|
|
|
* infcmd.c (attach_command): Call validate_exec_file.
|
|
|
|
|
|
* remote.c ( remote_target::remote_add_inferior): Likewise.
|
|
|
|
|
|
|
gdb: Better frame tracking for inline frames
This commit improves GDB's handling of inline functions when there are
more than one inline function in a stack, so for example if we have a
stack like:
main -> aaa -> bbb -> ccc -> ddd
And aaa, bbb, and ccc are all inline within main GDB should (when
given sufficient debug information) be able to step from main through
aaa, bbb, and ccc. Unfortunately, this currently doesn't work, here's
an example session:
(gdb) start
Temporary breakpoint 1 at 0x4003b0: file test.c, line 38.
Starting program: /project/gdb/tests/inline/test
Temporary breakpoint 1, main () at test.c:38
38 global_var = 0;
(gdb) step
39 return aaa () + 1;
(gdb) step
aaa () at test.c:39
39 return aaa () + 1;
(gdb) step
bbb () at test.c:39
39 return aaa () + 1;
(gdb) step
ccc () at test.c:39
39 return aaa () + 1;
(gdb) step
ddd () at test.c:32
32 return global_var;
(gdb) bt
#0 ddd () at test.c:32
#1 0x00000000004003c1 in ccc () at test.c:39
#2 bbb () at test.c:26
#3 aaa () at test.c:14
#4 main () at test.c:39
Notice that once we get to line 39 in main, GDB keeps reporting line
39 in main as the location despite understanding that the inferior is
stepping through the nested inline functions with each use of step.
The problem is that as soon as the inferior stops we call
skip_inline_frames (from inline-frame.c) which calculates the
inferiors current state in relation to inline functions - it figures
out if we're in an inline function, and if we are counts how many
inline frames there are at the current location.
So, in our example above, when we step from line 38 in main to line 39
we stop at a location that is simultaneously in all of main, aaa, bbb,
and ccc. The block structure reflects the order in which the
functions would be called, with ccc being the most inner block and
main being the most outer block. When we stop GDB naturally finds the
block for ccc, however within skip_inline_frames we spot that bbb,
aaa, and main are super-blocks of the current location and that each
layer represents an inline function. The skip_inline_frames then
records the depth of inline functions (3 in this case for aaa, bbb,
and ccc) and also the symbol of the outermost inline function (in this
case 'aaa' as main isn't an inline function, it just has things inline
within it).
Now GDB understands the stack to be main -> aaa -> bbb -> ccc,
however, the state initialised in skip_inline_frames starts off
indicating that we should hide 3 frames from the user, so we report
that we're in main at line 39. The location of main, line 39 is
derived by asking the inline function state for the last symbol in the
stack (aaa in this case), and then asking for it's location - the
location of an inlined function symbol is its call site, so main, line
39 in this case.
If the user then asks GDB to step we don't actually move the inferior
at all, instead we spot that we are in an inline function stack,
lookup the inline state data, and reduce the skip depth by 1. We then
report to the user that GDB has stopped. GDB now understands that we
are in 'aaa'. In order to get the precise location we again ask GDB
for the last symbol from the inline data structure, and we are again
told 'aaa', we then get the location from 'aaa', and report that we
are in main, line 39.
Hopefully it's clear what the mistake here is, once we've reduced the
inline skip depth we should not be using 'aaa' to compute the precise
location, instead we should be using 'bbb'. That is what this patch
does.
Now, when we call skip_inline_frames instead of just recording the
last skipped symbol we now record all symbols in the inline frame
stack. When we ask GDB for the last skipped symbol we return a symbol
based on how many frames we are skipping, not just the last know
symbol.
With this fix in place, the same session as above now looks much
better:
(gdb) start
Temporary breakpoint 1 at 0x4003b0: file test.c, line 38.
Starting program: /project/gdb/tests/inline/test
Temporary breakpoint 1, main () at test.c:38
38 global_var = 0;
(gdb) s
39 return aaa () + 1;
(gdb) s
aaa () at test.c:14
14 return bbb () + 1;
(gdb) s
bbb () at test.c:26
26 return ccc () + 1;
(gdb) s
ccc () at test.c:20
20 return ddd () + 1;
(gdb) s
ddd () at test.c:32
32 return global_var;
(gdb) bt
#0 ddd () at test.c:32
#1 0x00000000004003c1 in ccc () at test.c:20
#2 bbb () at test.c:26
#3 aaa () at test.c:14
#4 main () at test.c:39
gdb/ChangeLog:
* frame.c (find_frame_sal): Move call to get_next_frame into more
inner scope.
* inline-frame.c (inilne_state) <inline_state>: Update argument
types.
(inilne_state) <skipped_symbol>: Rename to...
(inilne_state) <skipped_symbols>: ...this, and change to a vector.
(skip_inline_frames): Build vector of skipped symbols and use this
to reate the inline_state.
(inline_skipped_symbol): Add a comment and some assertions, fetch
skipped symbol from the list.
gdb/testsuite/ChangeLog:
* gdb.dwarf2/dw2-inline-many-frames.c: New file.
* gdb.dwarf2/dw2-inline-many-frames.exp: New file.
Change-Id: I99def5ffb44eb9e58cda4b449bf3d91ab0386c62
2019-11-11 23:41:13 +01:00
|
|
|
|
2020-01-24 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* frame.c (find_frame_sal): Move call to get_next_frame into more
|
|
|
|
|
|
inner scope.
|
|
|
|
|
|
* inline-frame.c (inilne_state) <inline_state>: Update argument
|
|
|
|
|
|
types.
|
|
|
|
|
|
(inilne_state) <skipped_symbol>: Rename to...
|
|
|
|
|
|
(inilne_state) <skipped_symbols>: ...this, and change to a vector.
|
|
|
|
|
|
(skip_inline_frames): Build vector of skipped symbols and use this
|
|
|
|
|
|
to reate the inline_state.
|
|
|
|
|
|
(inline_skipped_symbol): Add a comment and some assertions, fetch
|
|
|
|
|
|
skipped symbol from the list.
|
|
|
|
|
|
|
gdb: Don't reorder line table entries too much when sorting.
Don't reorder line table entries for the same address when sorting the
line table, maintain the compiler given line order. Usually this will
reflect the order in which lines are conceptually encountered at a
given address.
Consider this example:
/* 1 */ volatile int global_var;
/* 2 */ int __attribute__ ((noinline))
/* 3 */ bar ()
/* 4 */ {
/* 5 */ return global_var;
/* 6 */ }
/* 7 */ static inline int __attribute__ ((always_inline))
/* 8 */ foo ()
/* 9 */ {
/* 10 */ return bar ();
/* 11 */ }
/* 12 */ int
/* 13 */ main ()
/* 14 */ {
/* 15 */ global_var = 0;
/* 16 */ return foo ();
/* 17 */ }
GCC 10 currently generates a line table like this (as shown by
objdump):
CU: ./test.c:
File name Line number Starting address
test.c 4 0x4004b0
test.c 5 0x4004b0
test.c 6 0x4004b6
test.c 6 0x4004b7
test.c 14 0x4003b0
test.c 15 0x4003b0
test.c 16 0x4003ba
test.c 10 0x4003ba
test.c 10 0x4003c1
The interesting entries are those for lines 16 and 10 at address
0x4003ba, these represent the call to foo and the inlined body of
foo.
With the current line table sorting GDB builds the line table like
this (as shown by 'maintenance info line-table'):
INDEX LINE ADDRESS
0 14 0x00000000004003b0
1 15 0x00000000004003b0
2 10 0x00000000004003ba
3 16 0x00000000004003ba
4 END 0x00000000004003c1
5 4 0x00000000004004b0
6 5 0x00000000004004b0
7 END 0x00000000004004b7
Notice that entries 2 and 3 for lines 10 and 16 are now in a different
order to the line table as given by the compiler. With this patch
applied the order is now:
INDEX LINE ADDRESS
0 14 0x00000000004003b0
1 15 0x00000000004003b0
2 16 0x00000000004003ba
3 10 0x00000000004003ba
4 END 0x00000000004003c1
5 4 0x00000000004004b0
6 5 0x00000000004004b0
7 END 0x00000000004004b7
Notice that entries 2 and 3 are now in their original order again.
The consequence of the incorrect ordering is that when stepping
through inlined functions GDB will display the wrong line for the
inner most frame. Here's a GDB session before this patch is applied:
Starting program: /home/andrew/tmp/inline/test
Temporary breakpoint 1, main () at test.c:15
15 /* 15 */ global_var = 0;
(gdb) step
16 /* 16 */ return foo ();
(gdb) step
foo () at test.c:16
16 /* 16 */ return foo ();
(gdb) step
bar () at test.c:5
5 /* 5 */ return global_var;
The step from line 15 to 16 was fine, but the next step should have
taken us to line 10, instead we are left at line 16. The final step
to line 5 is as expected.
With this patch applied the session goes better:
Starting program: /home/andrew/tmp/inline/test
Temporary breakpoint 1, main () at test.c:15
15 /* 15 */ global_var = 0;
(gdb) step
16 /* 16 */ return foo ();
(gdb) step
foo () at test.c:10
10 /* 10 */ return bar ();
(gdb) step
bar () at test.c:5
5 /* 5 */ return global_var;
We now visit the lines as 15, 16, 10, 5 as we would like.
The reason for this issue is that the inline frame unwinder is
detecting that foo is inlined in main. When we stop at the shared
address 0x4003ba the inline frame unwinder first shows us the outer
frame, this information is extracted from the DWARF's
DW_TAG_inlined_subroutine entries and passed via GDB's block data.
When we step again the inlined frame unwinder moves us up the call
stack to the inner most frame at which point the frame is displayed as
normal, with the location for the address being looked up in the line
table.
As GDB uses the last line table entry for an address as "the" line to
report for that address it is critical that GDB maintain the order of
the line table entries. In the first case, by reordering the line
table we report the wrong location.
I had to make a small adjustment in find_pc_sect_line in order to
correctly find the previous line in the line table. In some line
tables I was seeing an actual line entry and an end of sequence marker
at the same address, before this commit these would reorder to move
the end of sequence marker before the line entry (end of sequence has
line number 0). Now the end of sequence marker remains in its correct
location, and in order to find a previous line we should step backward
over any end of sequence markers.
As an example, the binary:
gdb/testsuite/outputs/gdb.dwarf2/dw2-ranges-func/dw2-ranges-func-lo-cold
Has this line table before the patch:
INDEX LINE ADDRESS
0 48 0x0000000000400487
1 END 0x000000000040048e
2 52 0x000000000040048e
3 54 0x0000000000400492
4 56 0x0000000000400497
5 END 0x000000000040049a
6 62 0x000000000040049a
7 END 0x00000000004004a1
8 66 0x00000000004004a1
9 68 0x00000000004004a5
10 70 0x00000000004004aa
11 72 0x00000000004004b9
12 END 0x00000000004004bc
13 76 0x00000000004004bc
14 78 0x00000000004004c0
15 80 0x00000000004004c5
16 END 0x00000000004004cc
And after this patch:
INDEX LINE ADDRESS
0 48 0x0000000000400487
1 52 0x000000000040048e
2 END 0x000000000040048e
3 54 0x0000000000400492
4 56 0x0000000000400497
5 END 0x000000000040049a
6 62 0x000000000040049a
7 66 0x00000000004004a1
8 END 0x00000000004004a1
9 68 0x00000000004004a5
10 70 0x00000000004004aa
11 72 0x00000000004004b9
12 END 0x00000000004004bc
13 76 0x00000000004004bc
14 78 0x00000000004004c0
15 80 0x00000000004004c5
16 END 0x00000000004004cc
When calling find_pc_sect_line with the address 0x000000000040048e, in
both cases we find entry #3, we then try to find the previous entry,
which originally found this entry '2 52 0x000000000040048e',
after the patch it finds '2 END 0x000000000040048e', which
cases the lookup to fail.
By skipping the END marker after this patch we get back to the correct
entry, which is now #1: '1 52 0x000000000040048e', and
everything works again.
gdb/ChangeLog:
* buildsym.c (lte_is_less_than): Delete.
(buildsym_compunit::end_symtab_with_blockvector): Create local
lambda function to sort line table entries, and use
std::stable_sort instead of std::sort.
* symtab.c (find_pc_sect_line): Skip backward over end of sequence
markers when looking for a previous line.
gdb/testsuite/ChangeLog:
* gdb.dwarf2/dw2-inline-stepping.c: New file.
* gdb.dwarf2/dw2-inline-stepping.exp: New file.
Change-Id: Ia0309494be4cfd9dcc554f30209477f5f040b21b
2019-11-06 11:17:05 +01:00
|
|
|
|
2020-01-24 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* buildsym.c (lte_is_less_than): Delete.
|
|
|
|
|
|
(buildsym_compunit::end_symtab_with_blockvector): Create local
|
|
|
|
|
|
lambda function to sort line table entries, and use
|
|
|
|
|
|
std::stable_sort instead of std::sort.
|
|
|
|
|
|
* symtab.c (find_pc_sect_line): Skip backward over end of sequence
|
|
|
|
|
|
markers when looking for a previous line.
|
|
|
|
|
|
|
2019-11-05 17:00:26 +01:00
|
|
|
|
2020-01-24 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (lnp_state_machine::record_line): Include
|
|
|
|
|
|
end_sequence parameter in debug print out. Record the line if we
|
|
|
|
|
|
are at an end_sequence marker even if it's not the start of a
|
|
|
|
|
|
statement.
|
|
|
|
|
|
* symmisc.c (maintenance_print_one_line_table): Print end of
|
|
|
|
|
|
sequence markers with 'END' not '0'.
|
|
|
|
|
|
|
Fix re-runs of a second inferior (PR gdb/25410)
This fixes a latent bug exposed by the multi-target patch (5b6d1e4fa
"Multi-target support), and then fixes two other latent bugs exposed
by fixing that first latent bug.
The symptom described in the bug report is that starting a first
inferior, then trying to run a second (multi-threaded) inferior twice,
causes libthread_db to fail to load, along with other erratic
behavior:
(gdb) run
Starting program: /tmp/foo
warning: td_ta_new failed: generic error
Going a bit deeply, I found that if the two inferiors have different
symbols, we can see that just after inferior 2 exits, we are left with
inferior 2 selected, which is correct, but the symbols in scope belong
to inferior 1, which is obviously incorrect...
This problem is that there's a path in
scoped_restore_current_thread::restore() that switches to no thread
selected, and switches the current inferior, but leaves the current
program space as is, resulting in leaving the program space pointing
to the wrong program space (the one of the other inferior). This was
happening after handling TARGET_WAITKIND_NO_RESUMED, which is an event
that triggers after TARGET_WAITKIND_EXITED for the previous inferior
exit. Subsequent symbol lookups find the symbols of the wrong
inferior.
The fix is to use switch_to_inferior_no_thread in that problem spot.
This function was recently added along with the multi-target work
exactly for these situations.
As for testing, this patch adds a new testcase that tests symbol
printing just after inferior exit, which exercises the root cause of
the problem more directly. And then, to cover the use case described
in the bug too, it also exercises the lithread_db.so mis-loading, by
using TLS printing as a proxy for being sure that threaded debugging
was activated sucessfully. The testcase fails without the fix like
this, for the "print symbol just after exit" bits:
...
[Inferior 1 (process 8719) exited normally]
(gdb) PASS: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: continue until exit
print re_run_var_1
No symbol "re_run_var_1" in current context.
(gdb) FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: print re_run_var_1
...
And like this for the "libthread_db.so loading" bits:
(gdb) run
Starting program: /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.multi/multi-re-run/multi-re-run
warning: td_ta_new failed: generic error
[New LWP 27001]
Thread 1.1 "multi-re-run" hit Breakpoint 3, all_started () at /home/pedro/gdb/binutils-gdb/build/../src/gdb/testsuite/gdb.multi/multi-re-run.c:44
44 }
(gdb) PASS: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: running to all_started in runto
print tls_var
Cannot find thread-local storage for LWP 27000, executable file /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.multi/multi-re-run/multi-re-run:
Cannot find thread-local variables on this target
(gdb) FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: print tls_var
As mentioned, that fix above goes on to expose a couple other latent
bugs. This commit fixes those as well.
The first latent bug exposed is in
infrun.c:handle_vfork_child_exec_or_exit. The current code is leaving
inf->pspace == NULL while calling clone_program_space. The idea was
to make it so that the breakpoints module doesn't use this inferior's
pspace to set breakpoints. With that, any
scoped_restore_current_thread use from within clone_program_space
tries to restore a NULL program space, which hits an assertion:
Attaching after Thread 0x7ffff74b8700 (LWP 27276) vfork to child process 27277]
[New inferior 2 (process 27277)]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
/home/pedro/gdb/binutils-gdb/build/../src/gdb/progspace.c:243: internal-error: void set_current_program_space(program_space*): Assertion `pspace != NULL' faile
d.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) FAIL: gdb.threads/vfork-follow-child-exit.exp: detach-on-fork=off: continue (GDB internal error)
That NULL pspace idea was legitimate, but it's no longer necessary,
since commit b2e586e850db ("Defer breakpoint reset when cloning
progspace for fork child"). So the fix is to just set the inferior's
program space earlier.
The other latent bug exposed is in exec.c. When exec_close is called
from the program_space destructor, it is purposedly called with a
current program space that is not the current inferior's program
space. The problem is that the multi-target work added some code to
remove_target_sections that loops over all inferiors, and uses
scoped_restore_current_thread to save/restore the previous
thread/inferior/frame state. This makes it so that exec_close returns
with the current program space set to the current inferior's program
space, which is exactly what we did not want. Then the program_space
destructor continues into free_all_objfiles, but it is now running
that method on the wrong program space, resulting in:
Reading symbols from /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.threads/fork-plus-threads/fork-plus-threads...
Reading symbols from /usr/lib/debug/usr/lib64/libpthread-2.26.so.debug...
Reading symbols from /usr/lib/debug/usr/lib64/libm-2.26.so.debug...
Reading symbols from /usr/lib/debug/usr/lib64/libc-2.26.so.debug...
Reading symbols from /usr/lib/debug/usr/lib64/ld-2.26.so.debug...
[Inferior 3 (process 9583) exited normally]
/home/pedro/gdb/binutils-gdb/build/../src/gdb/progspace.c:170: internal-error: void program_space::free_all_objfiles(): Assertion `so->objfile == NULL' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: inferior 1 exited (GDB internal error)
The fix is to use scoped_restore_current_pspace_and_thread instead of
scoped_restore_current_thread.
gdb/ChangeLog:
2020-01-24 Pedro Alves <palves@redhat.com>
PR gdb/25410
* thread.c (scoped_restore_current_thread::restore): Use
switch_to_inferior_no_thread.
* exec.c: Include "progspace-and-thread.h".
(add_target_sections, remove_target_sections):
scoped_restore_current_pspace_and_thread instead of
scoped_restore_current_thread.
* infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
and aspace to the inferior before calling clone_program_space.
Remove stale comment.
gdb/testsuite/ChangeLog:
2020-01-24 Pedro Alves <palves@redhat.com>
PR gdb/25410
* gdb.multi/multi-re-run-1.c: New.
* gdb.multi/multi-re-run-2.c: New.
* gdb.multi/multi-re-run.exp: New.
2020-01-24 19:46:20 +01:00
|
|
|
|
2020-01-24 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/25410
|
|
|
|
|
|
* thread.c (scoped_restore_current_thread::restore): Use
|
|
|
|
|
|
switch_to_inferior_no_thread.
|
|
|
|
|
|
* exec.c: Include "progspace-and-thread.h".
|
|
|
|
|
|
(add_target_sections, remove_target_sections):
|
|
|
|
|
|
scoped_restore_current_pspace_and_thread instead of
|
|
|
|
|
|
scoped_restore_current_thread.
|
|
|
|
|
|
* infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
|
|
|
|
|
|
and aspace to the inferior before calling clone_program_space.
|
|
|
|
|
|
Remove stale comment.
|
|
|
|
|
|
|
2020-01-24 15:12:48 +01:00
|
|
|
|
2020-01-24 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
|
|
|
|
|
|
(arm_netbsd_nat_target::fetch_registers): ...this.
|
|
|
|
|
|
(arm_nbsd_nat_target::store_registers): Rename to...
|
|
|
|
|
|
(arm_netbsd_nat_target::store_registers): ...this.
|
|
|
|
|
|
|
2020-01-24 15:05:05 +01:00
|
|
|
|
2020-01-24 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
|
|
|
|
|
|
register_t.
|
|
|
|
|
|
|
2020-01-23 15:52:05 +01:00
|
|
|
|
2020-01-24 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
|
|
|
|
|
|
Update comment.
|
|
|
|
|
|
* aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
|
|
|
|
|
|
Likewise.
|
|
|
|
|
|
* arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
|
|
|
|
|
|
* gdbcore.h (deprecated_add_core_fns): Update comment to point to
|
|
|
|
|
|
the correct replacement (iterate_over_regset_sections).
|
|
|
|
|
|
* riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
|
|
|
|
|
|
Update comment.
|
|
|
|
|
|
|
gdb: Enable stdin on exception in execute_gdb_command
This is an update of this patch:
https://sourceware.org/ml/gdb-patches/2018-09/msg00884.html
This patch attempts to address PR gdb/23718 by re-enabling stdin
whenever an exception is caught during gdb.execute().
When Python gdb.execute() is called, an exception could occur (e.g. the
target disappearing), which is then converted into a Python exception. If
stdin was disabled before the exception is caught, it is not re-enabled,
because the exception doesn't propagate to the top level of the event loop,
whose catch block would otherwise enable it.
The result is that when execution of a Python script completes, GDB does
not prompt or accept input, and is effectively hung.
This change rectifies the issue by re-enabling stdin in the catch block of
execute_gdb_command, prior to converting the exception to a Python
exception.
Since this patch was originally posted I've added a test, and also I
converted the code to re-enable stdin from this:
SWITCH_THRU_ALL_UIS ()
{
async_enable_stdin ();
}
to simply this:
async_enable_stdin ();
My reasoning is that we only need the SWITCH_THRU_ALL_UIS if, at the time
the exception is caught, the current_ui might be different than at the time
we called async_disable_stdin. Within python's execute_gdb_command I think
it should be impossible to switch current_ui, so the SWITCH_THRU_ALL_UIS
isn't needed.
gdb/ChangeLog:
PR gdb/23718
* gdb/python/python.c (execute_gdb_command): Call
async_enable_stdin in catch block.
gdb/testsuite/ChangeLog:
PR gdb/23718
* gdb.server/server-kill-python.exp: New file.
Change-Id: I1cfc36ee9f8484cc1ed82be9be338353db6bc080
2019-11-19 12:17:20 +01:00
|
|
|
|
2020-01-24 Graham Markall <graham.markall@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/23718
|
|
|
|
|
|
* gdb/python/python.c (execute_gdb_command): Call
|
|
|
|
|
|
async_enable_stdin in catch block.
|
|
|
|
|
|
|
2019-11-19 19:09:43 +01:00
|
|
|
|
2020-01-24 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* event-loop.c (start_event_loop): Wrap async_enable_stdin with
|
|
|
|
|
|
SWITCH_THRU_ALL_UIS.
|
|
|
|
|
|
|
gdb/tui: asm window handles invalid memory and scrolls better
This started as a patch to enable the asm window to handle attempts to
disassemble invalid memory, but it ended up expanding into a
significant rewrite of how the asm window handles scrolling. These
two things ended up being tied together as it was impossible to
correctly test scrolling into invalid memory when the asm window would
randomly behave weirdly while scrolling.
Things that should work nicely now; scrolling to the bottom or top of
the listing with PageUp, PageDown, Up Arrow, Down Arrow and we should
be able to scroll past small areas of memory that don't have symbols
associated with them. It should also be possible to scroll to the
start of a section even if there's no symbol at the start of the
section.
Adding tests for this scrolling was a little bit of a problem. First
I would have liked to add tests for PageUp / PageDown, but the tuiterm
library we use doesn't support these commands right now due to only
emulating a basic ascii terminal. Changing this to emulate a more
complex terminal would require adding support for more escape sequence
control codes, so I've not tried to tackle that in this patch.
Next, I would have liked to test scrolling to the start or end of the
assembler listing and then trying to scroll even more, however, this
is a problem because in a well behaving GDB a scroll at the start/end
has no effect. What we need to do is:
- Move to start of assembler listing,
- Send scroll up command,
- Wait for all curses output,
- Ensure the assembler listing is unchanged, we're still at the
start of the listing.
The problem is that there is no curses output, so how long do we wait
at step 3? The same problem exists for scrolling to the bottom of the
assembler listing. However, when scrolling down you can at least see
the end coming, so I added a test for this case, however, this feels
like an area of code that is massively under tested.
gdb/ChangeLog:
PR tui/9765
* minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
comment, add extra parameter, and update to store previous symbol
when appropriate.
* minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
add extra parameter.
* tui/tui-disasm.c (tui_disassemble): Update header comment,
remove unneeded parameter, add try/catch around gdb_print_insn,
rewrite to add items to asm_lines vector.
(tui_find_backward_disassembly_start_address): New function.
(tui_find_disassembly_address): Updated throughout.
(tui_disasm_window::set_contents): Update for changes to
tui_disassemble.
(tui_disasm_window::do_scroll_vertical): No need to adjust the
number of lines to scroll.
gdb/testsuite/ChangeLog:
PR tui/9765
* gdb.tui/tui-layout-asm.exp: Add scrolling test for asm window.
Change-Id: I323987c8fd316962c937e73c17d952ccd3cfa66c
2020-01-11 02:38:28 +01:00
|
|
|
|
2020-01-24 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR tui/9765
|
|
|
|
|
|
* minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
|
|
|
|
|
|
comment, add extra parameter, and update to store previous symbol
|
|
|
|
|
|
when appropriate.
|
|
|
|
|
|
* minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
|
|
|
|
|
|
add extra parameter.
|
|
|
|
|
|
* tui/tui-disasm.c (tui_disassemble): Update header comment,
|
|
|
|
|
|
remove unneeded parameter, add try/catch around gdb_print_insn,
|
|
|
|
|
|
rewrite to add items to asm_lines vector.
|
|
|
|
|
|
(tui_find_backward_disassembly_start_address): New function.
|
|
|
|
|
|
(tui_find_disassembly_address): Updated throughout.
|
|
|
|
|
|
(tui_disasm_window::set_contents): Update for changes to
|
|
|
|
|
|
tui_disassemble.
|
|
|
|
|
|
(tui_disasm_window::do_scroll_vertical): No need to adjust the
|
|
|
|
|
|
number of lines to scroll.
|
|
|
|
|
|
|
2020-01-23 23:55:35 +01:00
|
|
|
|
2020-01-23 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
|
|
|
|
|
|
(SECT_OFF_DATA): Likewise.
|
|
|
|
|
|
(SECT_OFF_RODATA): Likewise.
|
|
|
|
|
|
(SECT_OFF_TEXT): Likewise.
|
|
|
|
|
|
(SECT_OFF_BSS): Likewise.
|
|
|
|
|
|
(struct objfile) <text_section_offset, data_section_offset>: New
|
|
|
|
|
|
methods.
|
|
|
|
|
|
* amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
|
|
|
|
|
|
objfile::text_section_offset.
|
|
|
|
|
|
* coff-pe-read.c (add_pe_forwarded_sym): Likewise.
|
|
|
|
|
|
* coffread.c (coff_symtab_read): Likewise.
|
|
|
|
|
|
(enter_linenos): Likewise.
|
|
|
|
|
|
(process_coff_symbol): Likewise.
|
|
|
|
|
|
* ctfread.c (get_objfile_text_range): Likewise.
|
|
|
|
|
|
* dtrace-probe.c (dtrace_probe::get_relocated_address):
|
|
|
|
|
|
Use objfile::data_section_offset.
|
|
|
|
|
|
* dwarf2-frame.c (execute_cfa_program): Use
|
|
|
|
|
|
objfile::text_section_offset.
|
|
|
|
|
|
(dwarf2_frame_find_fde): Likewise.
|
|
|
|
|
|
* dwarf2read.c (create_addrmap_from_index): Likewise.
|
|
|
|
|
|
(create_addrmap_from_aranges): Likewise.
|
|
|
|
|
|
(dw2_find_pc_sect_compunit_symtab): Likewise.
|
|
|
|
|
|
(process_psymtab_comp_unit_reader): Likewise.
|
|
|
|
|
|
(add_partial_symbol): Likewise.
|
|
|
|
|
|
(add_partial_subprogram): Likewise.
|
|
|
|
|
|
(process_full_comp_unit): Likewise.
|
|
|
|
|
|
(read_file_scope): Likewise.
|
|
|
|
|
|
(read_func_scope): Likewise.
|
|
|
|
|
|
(read_lexical_block_scope): Likewise.
|
|
|
|
|
|
(read_call_site_scope): Likewise.
|
|
|
|
|
|
(dwarf2_rnglists_process): Likewise.
|
|
|
|
|
|
(dwarf2_ranges_process): Likewise.
|
|
|
|
|
|
(dwarf2_ranges_read): Likewise.
|
|
|
|
|
|
(dwarf_decode_lines_1): Likewise.
|
|
|
|
|
|
(new_symbol): Likewise.
|
|
|
|
|
|
(dwarf2_fetch_die_loc_sect_off): Likewise.
|
|
|
|
|
|
(dwarf2_per_cu_text_offset): Likewise.
|
|
|
|
|
|
* hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
|
|
|
|
|
|
* hppa-tdep.c (read_unwind_info): Likewise.
|
|
|
|
|
|
* ia64-tdep.c (ia64_find_unwind_table): Likewise.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab): Likewise.
|
|
|
|
|
|
* psymtab.c (find_pc_sect_psymtab): Likewise.
|
|
|
|
|
|
* solib-svr4.c (enable_break): Likewise.
|
|
|
|
|
|
* stap-probe.c (relocate_address): Use
|
|
|
|
|
|
objfile::data_section_offset.
|
|
|
|
|
|
* xcoffread.c (enter_line_range): Use
|
|
|
|
|
|
objfile::text_section_offset.
|
|
|
|
|
|
(read_xcoff_symtab): Likewise.
|
|
|
|
|
|
|
2020-01-23 23:44:22 +01:00
|
|
|
|
2020-01-23 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
|
|
|
|
|
|
declaration to narrower scopes.
|
|
|
|
|
|
|
gdb: fix darwin-nat.c build / adapt to multi-target
The darwin-nat.c file doesn't build since the multi-target changes
(5b6d1e4f, "Multi-target support"). This patch makes it build. I have
access to a macOS vm, so I am able to build it, but I wasn't able to
successfully codesign it and try to actually debug something, so I don't
know if it works. I don't have much more time to put on this to figure
it out, so I thought I'd sent the patch anyway, as it's at least a step
in the right direction.
The bulk of the patch is to change a bunch of functions to be methods of
the darwin_nat_target object, so that this can pass `this` to
find_inferior_ptid and other functions that now require a
process_stratum_target pointer.
The darwin_ptrace_him function (renamed to darwin_nat_target::ptrace_him
in this patch) is passed to fork_inferior as the `init_trace_fun`
parameter. Since the method can't be passed as a plain function pointer
(we need the `this` pointer), I changed the `init_trace_fun` parameter
of fork_inferior to be a gdb::function_view, so we can pass a lambda and
capture `this`.
The changes in darwin-nat.h are only to move definition higher in the
file, so that forward declarations are not needed.
gdb/ChangeLog:
* darwin-nat.h (struct darwin_exception_msg, enum
darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
Move up.
(class darwin_nat_target) <wait_1, check_new_threads,
decode_exception_message, decode_message, stop_inferior,
init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
* darwin-nat.c (darwin_check_new_threads): Rename to...
(darwin_nat_target::check_new_threads): ... this.
(darwin_suspend_inferior_it): Remove.
(darwin_decode_exception_message): Rename to...
(darwin_nat_target::decode_exception_message): ... this.
(darwin_nat_target::resume): Pass target to find_inferior_ptid.
(darwin_decode_message): Rename to...
(darwin_nat_target::decode_message): ... this.
(cancel_breakpoint): Rename to...
(darwin_nat_target::cancel_breakpoint): ... this.
(darwin_wait): Rename to...
(darwin_nat_target::wait_1): ... this. Use range-based for loop
instead of iterate_over_inferiors.
(darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
(darwin_stop_inferior): Rename to...
(darwin_nat_target::stop_inferior): ... this.
(darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
(darwin_init_thread_list): Rename to...
(darwin_nat_target::init_thread_list): ... this.
(darwin_ptrace_him): Rename to...
(darwin_nat_target::ptrace_him): ... this.
(darwin_nat_target::create_inferior): Pass lambda function to
fork_inferior.
(darwin_nat_target::detach): Call stop_inferior instead of
darwin_stop_inferior.
* fork-inferior.h (fork_inferior): Change init_trace_fun
parameter to gdb::function_view.
* fork-inferior.c (fork_inferior): Likewise.
2020-01-23 20:55:50 +01:00
|
|
|
|
2020-01-23 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* darwin-nat.h (struct darwin_exception_msg, enum
|
|
|
|
|
|
darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
|
|
|
|
|
|
Move up.
|
|
|
|
|
|
(class darwin_nat_target) <wait_1, check_new_threads,
|
|
|
|
|
|
decode_exception_message, decode_message, stop_inferior,
|
|
|
|
|
|
init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
|
|
|
|
|
|
* darwin-nat.c (darwin_check_new_threads): Rename to...
|
|
|
|
|
|
(darwin_nat_target::check_new_threads): ... this.
|
|
|
|
|
|
(darwin_suspend_inferior_it): Remove.
|
|
|
|
|
|
(darwin_decode_exception_message): Rename to...
|
|
|
|
|
|
(darwin_nat_target::decode_exception_message): ... this.
|
|
|
|
|
|
(darwin_nat_target::resume): Pass target to find_inferior_ptid.
|
|
|
|
|
|
(darwin_decode_message): Rename to...
|
|
|
|
|
|
(darwin_nat_target::decode_message): ... this.
|
|
|
|
|
|
(cancel_breakpoint): Rename to...
|
|
|
|
|
|
(darwin_nat_target::cancel_breakpoint): ... this.
|
|
|
|
|
|
(darwin_wait): Rename to...
|
|
|
|
|
|
(darwin_nat_target::wait_1): ... this. Use range-based for loop
|
|
|
|
|
|
instead of iterate_over_inferiors.
|
|
|
|
|
|
(darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
|
|
|
|
|
|
(darwin_stop_inferior): Rename to...
|
|
|
|
|
|
(darwin_nat_target::stop_inferior): ... this.
|
|
|
|
|
|
(darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
|
|
|
|
|
|
(darwin_init_thread_list): Rename to...
|
|
|
|
|
|
(darwin_nat_target::init_thread_list): ... this.
|
|
|
|
|
|
(darwin_ptrace_him): Rename to...
|
|
|
|
|
|
(darwin_nat_target::ptrace_him): ... this.
|
|
|
|
|
|
(darwin_nat_target::create_inferior): Pass lambda function to
|
|
|
|
|
|
fork_inferior.
|
|
|
|
|
|
(darwin_nat_target::detach): Call stop_inferior instead of
|
|
|
|
|
|
darwin_stop_inferior.
|
|
|
|
|
|
* fork-inferior.h (fork_inferior): Change init_trace_fun
|
|
|
|
|
|
parameter to gdb::function_view.
|
|
|
|
|
|
* fork-inferior.c (fork_inferior): Likewise.
|
|
|
|
|
|
|
2019-12-21 17:08:14 +01:00
|
|
|
|
2020-01-23 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* i386-cygwin-tdep.c (core_process_module_section): Update.
|
|
|
|
|
|
* windows-nat.c (struct lm_info_windows): Add text_offset.
|
|
|
|
|
|
(windows_xfer_shared_libraries): Update.
|
|
|
|
|
|
* windows-tdep.c (windows_xfer_shared_library):
|
|
|
|
|
|
Add text_offset_cached argument.
|
|
|
|
|
|
* windows-tdep.h (windows_xfer_shared_library): Update.
|
|
|
|
|
|
|
2020-01-22 00:30:07 +01:00
|
|
|
|
2020-01-21 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbarch.sh: Add declaration for _initialize_gdbarch.
|
|
|
|
|
|
|
2020-01-21 22:28:25 +01:00
|
|
|
|
2020-01-21 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
|
|
|
|
|
|
(get_sim_inferior_data): Remove use of iterate_over_inferiors,
|
|
|
|
|
|
replace with range-based for.
|
|
|
|
|
|
(gdbsim_interrupt_inferior): Remove.
|
|
|
|
|
|
(gdbsim_target::interrupt): Replace iterate_over_inferiors use
|
|
|
|
|
|
with a range-based for. Inline code from
|
|
|
|
|
|
gdbsim_interrupt_inferior.
|
|
|
|
|
|
|
2020-01-21 22:04:51 +01:00
|
|
|
|
2020-01-21 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infrun.c (proceed): Fix indentation.
|
|
|
|
|
|
|
Allow use of Pygments to colorize source code
While GNU Source Highlight is good, it's also difficult to build and
distribute. For one thing, it needs Boost. For another, it has an
unusual configuration and installation setup.
Pygments, a Python library, doesn't suffer from these issues, and so I
thought it would be a reasonable fallback.
This patch implements this idea. GNU Source Highlight is preferred,
but if it is unavailable (or fails), the extension languages are
tried. This patch also implements support for Pygments.
Something similar could be done for Guile, using:
https://dthompson.us/projects/guile-syntax-highlight.html
However, I don't know enough about Guile internals to make this
happen, so I have not done it here.
gdb/ChangeLog
2020-01-21 Tom Tromey <tromey@adacore.com>
* source-cache.c (source_cache::ensure): Call ext_lang_colorize.
* python/python.c (python_extension_ops): Update.
(gdbpy_colorize): New function.
* python/lib/gdb/__init__.py (colorize): New function.
* extension.h (ext_lang_colorize): Declare.
* extension.c (ext_lang_colorize): New function.
* extension-priv.h (struct extension_language_ops) <colorize>: New
member.
* cli/cli-style.c (_initialize_cli_style): Update help text.
Change-Id: I5e21623ee05f1f66baaa6deaeca78b578c031bf4
2020-01-03 21:59:27 +01:00
|
|
|
|
2020-01-21 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* source-cache.c (source_cache::ensure): Call ext_lang_colorize.
|
|
|
|
|
|
* python/python.c (python_extension_ops): Update.
|
|
|
|
|
|
(gdbpy_colorize): New function.
|
|
|
|
|
|
* python/lib/gdb/__init__.py (colorize): New function.
|
|
|
|
|
|
* extension.h (ext_lang_colorize): Declare.
|
|
|
|
|
|
* extension.c (ext_lang_colorize): New function.
|
|
|
|
|
|
* extension-priv.h (struct extension_language_ops) <colorize>: New
|
|
|
|
|
|
member.
|
|
|
|
|
|
* cli/cli-style.c (_initialize_cli_style): Update help text.
|
|
|
|
|
|
|
2020-01-09 20:24:15 +01:00
|
|
|
|
2020-01-21 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-tdep.c (struct aarch64_displaced_step_closure)
|
|
|
|
|
|
<cond>: Change type to bool.
|
|
|
|
|
|
(aarch64_displaced_step_b_cond): Update cond to use bool type.
|
|
|
|
|
|
(aarch64_displaced_step_cb): Likewise.
|
|
|
|
|
|
(aarch64_displaced_step_tb): Likewise.
|
|
|
|
|
|
|
2020-01-09 20:19:31 +01:00
|
|
|
|
2020-01-21 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
|
|
|
|
|
|
output.
|
|
|
|
|
|
|
2020-01-09 20:04:36 +01:00
|
|
|
|
2020-01-21 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-tdep.c (struct aarch64_displaced_step_closure )
|
|
|
|
|
|
<pc_adjust>: Adjust the documentation.
|
|
|
|
|
|
(aarch64_displaced_step_fixup): Check if PC really moved before
|
|
|
|
|
|
adjusting it.
|
|
|
|
|
|
|
2020-01-11 19:40:45 +01:00
|
|
|
|
2020-01-19 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* disasm.c (~gdb_disassembler): New destructor.
|
|
|
|
|
|
(gdb_buffered_insn_length): Call disassemble_free_target.
|
|
|
|
|
|
* disasm.h (class gdb_disassembler): Declare destructor. Use
|
|
|
|
|
|
DISABLE_COPY_AND_ASSIGN.
|
|
|
|
|
|
|
2020-01-11 23:56:10 +01:00
|
|
|
|
2020-01-19 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (abbrev_table_up): Move typedef earlier.
|
|
|
|
|
|
(die_reader_func_ftype): Remove.
|
|
|
|
|
|
(cutu_reader): New class.
|
|
|
|
|
|
(dw2_get_file_names_reader): Remove "data" parameter.
|
|
|
|
|
|
(dw2_get_file_names): Use cutu_reader.
|
|
|
|
|
|
(create_debug_type_hash_table): Update.
|
|
|
|
|
|
(read_cutu_die_from_dwo): Update comment.
|
|
|
|
|
|
(lookup_dwo_unit): Add dwo_name parameter.
|
|
|
|
|
|
(cutu_reader::init_tu_and_read_dwo_dies): Now a method. Remove
|
|
|
|
|
|
die_reader_func_ftype and data parameters.
|
|
|
|
|
|
(cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
|
|
|
|
|
|
Remove die_reader_func_ftype and data parameters.
|
|
|
|
|
|
(~cutu_reader): New; from init_cutu_and_read_dies.
|
|
|
|
|
|
(cutu_reader::cutu_reader): Rename from
|
|
|
|
|
|
init_cutu_and_read_dies_no_follow. Remove die_reader_func_ftype
|
|
|
|
|
|
and data parameters.
|
|
|
|
|
|
(init_cutu_and_read_dies_simple): Remove.
|
|
|
|
|
|
(struct process_psymtab_comp_unit_data): Remove.
|
|
|
|
|
|
(process_psymtab_comp_unit_reader): Remove data parameter; add
|
|
|
|
|
|
want_partial_unit and pretend_language parameters.
|
|
|
|
|
|
(process_psymtab_comp_unit): Use cutu_reader.
|
|
|
|
|
|
(build_type_psymtabs_reader): Remove data parameter.
|
|
|
|
|
|
(build_type_psymtabs_1): Use cutu_reader.
|
|
|
|
|
|
(process_skeletonless_type_unit): Likewise.
|
|
|
|
|
|
(load_partial_comp_unit_reader): Remove.
|
|
|
|
|
|
(load_partial_comp_unit): Use cutu_reader.
|
|
|
|
|
|
(load_full_comp_unit_reader): Remove.
|
|
|
|
|
|
(load_full_comp_unit): Use cutu_reader.
|
|
|
|
|
|
(struct create_dwo_cu_data): Remove.
|
|
|
|
|
|
(create_dwo_cu_reader): Remove datap parameter; add dwo_file and
|
|
|
|
|
|
dwo_unit parameters.
|
|
|
|
|
|
(create_cus_hash_table): Use cutu_reader.
|
|
|
|
|
|
(struct dwarf2_read_addr_index_data): Remove.
|
|
|
|
|
|
(dwarf2_read_addr_index_reader): Remove.
|
|
|
|
|
|
(dwarf2_read_addr_index): Use cutu_reader.
|
|
|
|
|
|
(read_signatured_type_reader): Remove.
|
|
|
|
|
|
(read_signatured_type): Use cutu_reader.
|
|
|
|
|
|
|
2019-12-27 16:47:41 +01:00
|
|
|
|
2020-01-19 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui.c (tui_show_assembly): Use tui_suppress_output.
|
|
|
|
|
|
* tui/tui-wingeneral.h (class tui_suppress_output): New.
|
|
|
|
|
|
(tui_wrefresh): Declare.
|
|
|
|
|
|
* tui/tui-wingeneral.c (suppress_output): New global.
|
|
|
|
|
|
(tui_suppress_output, ~tui_suppress_output): New constructor and
|
|
|
|
|
|
destructor.
|
|
|
|
|
|
(tui_wrefresh): New function.
|
|
|
|
|
|
(tui_gen_win_info::refresh_window): Use tui_wrefresh.
|
|
|
|
|
|
(tui_gen_win_info::make_window): Call wnoutrefresh when needed.
|
|
|
|
|
|
* tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
|
|
|
|
|
|
method.
|
|
|
|
|
|
* tui/tui-regs.c (tui_data_window::erase_data_content): Call
|
|
|
|
|
|
tui_wrefresh.
|
|
|
|
|
|
(tui_data_window::no_refresh): New method.
|
|
|
|
|
|
(tui_data_item_window::refresh_window): Call tui_wrefresh.
|
|
|
|
|
|
(tui_reg_command): Use tui_suppress_output
|
|
|
|
|
|
* tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
|
|
|
|
|
|
* tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
|
|
|
|
|
|
method.
|
|
|
|
|
|
* tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
|
|
|
|
|
|
|
2019-12-21 19:14:56 +01:00
|
|
|
|
2020-01-19 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-winsource.c (tui_update_source_windows_with_line):
|
|
|
|
|
|
Handle case where symtab is null.
|
|
|
|
|
|
|
2020-01-19 17:54:02 +01:00
|
|
|
|
2020-01-19 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* linux-fork.c (one_fork_p): Simplify.
|
|
|
|
|
|
|
2020-01-17 15:58:57 +01:00
|
|
|
|
2020-01-17 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* top.c (struct qt_args): Remove.
|
|
|
|
|
|
(kill_or_detach): Change return type to void, replace `void *`
|
|
|
|
|
|
parameter with a proper one.
|
|
|
|
|
|
(print_inferior_quit_action): Likewise.
|
|
|
|
|
|
(quit_confirm): Use range-based for loop to iterate over inferiors.
|
|
|
|
|
|
(quit_force): Likewise.
|
|
|
|
|
|
|
2020-01-17 15:57:58 +01:00
|
|
|
|
2020-01-17 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* mi/mi-main.c (run_one_inferior): Change return type to void, replace
|
|
|
|
|
|
`void *` parameter with proper parameters.
|
|
|
|
|
|
(mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
|
|
|
|
|
|
(print_one_inferior): Change return type to void, replace `void *`
|
|
|
|
|
|
parameter with proper parameters.
|
|
|
|
|
|
(mi_cmd_list_thread_groups): Use range-based loop to iterate over
|
|
|
|
|
|
inferiors.
|
|
|
|
|
|
(get_other_inferior): Remove.
|
|
|
|
|
|
(mi_cmd_remove_inferior): Use range-based loop to iterate over
|
|
|
|
|
|
inferiors.
|
|
|
|
|
|
|
2020-01-17 15:57:07 +01:00
|
|
|
|
2020-01-17 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* mi/mi-interp.c (report_initial_inferior): Remove.
|
|
|
|
|
|
(mi_interp::init): Use range-based for to iterate over inferiors.
|
|
|
|
|
|
|
2020-01-17 15:51:10 +01:00
|
|
|
|
2020-01-17 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* python/py-inferior.c (build_inferior_list): Remove.
|
|
|
|
|
|
(gdbpy_ref): Use range-based for loop to iterate over inferiors.
|
|
|
|
|
|
|
2020-01-16 23:41:53 +01:00
|
|
|
|
2020-01-16 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
|
|
|
|
|
|
(btrace_stitch_trace): Likewise.
|
|
|
|
|
|
* charset.c (intermediate_encoding): Likewise (vaild).
|
|
|
|
|
|
* nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
|
|
|
|
|
|
* python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
|
|
|
|
|
|
* record-btrace.c (record_btrace_print_conf): Likewise (unkown).
|
|
|
|
|
|
|
2019-12-23 16:38:13 +01:00
|
|
|
|
2020-01-16 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-tdep.c (windows_get_tlb_type):
|
|
|
|
|
|
Add rtl_user_process_parameters type.
|
|
|
|
|
|
|
Ensure proc-service symbols have default visibility (PR build/24805)
Compiling GDB with '-fvisibility=hidden' removes the symbols that
should be exported.
This patch explicitly marks them as visible.
gdb/ChangeLog:
2020-01-16 Pedro Alves <palves@redhat.com>
Norbert Lange <nolange79@gmail.com>
PR build/24805
* gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
(ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
(ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
(ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
(ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
(ps_plog): Redeclare exported functions with default visibility.
2020-01-16 19:35:30 +01:00
|
|
|
|
2020-01-16 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
Norbert Lange <nolange79@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR build/24805
|
|
|
|
|
|
* gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
|
|
|
|
|
|
(ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
|
|
|
|
|
|
(ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
|
|
|
|
|
|
(ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
|
|
|
|
|
|
(ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
|
|
|
|
|
|
(ps_plog): Redeclare exported functions with default visibility.
|
|
|
|
|
|
|
2020-01-16 17:51:06 +01:00
|
|
|
|
2020-01-16 Nitika Achra <Nitika.Achra@amd.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2loc.c (decode_debug_loclists_addresses): Handle
|
|
|
|
|
|
DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
|
|
|
|
|
|
|
2020-01-15 18:47:44 +01:00
|
|
|
|
2020-01-15 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infcmd.c (post_create_inferior): Use get_thread_regcache
|
|
|
|
|
|
instead of get_current_regcache.
|
|
|
|
|
|
|
2019-12-21 17:51:05 +01:00
|
|
|
|
2020-01-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR symtab/12535:
|
|
|
|
|
|
* python/python.c (gdbpy_decode_line): Treat empty string the same
|
|
|
|
|
|
as no argument.
|
|
|
|
|
|
|
2020-01-09 01:43:29 +01:00
|
|
|
|
2020-01-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
|
|
|
|
|
|
|
2019-12-20 01:49:25 +01:00
|
|
|
|
2020-01-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* nat/linux-btrace.c: Don't include <config.h>.
|
|
|
|
|
|
* nat/linux-ptrace.c: Don't include <config.h>.
|
|
|
|
|
|
* nat/x86-linux-dregs.c: Don't include <config.h>.
|
|
|
|
|
|
|
Move many configure checks to common.m4
This moves many needed configure checks from gdb and gdbserver into
common.m4. This helps gdbsupport, nat, and target be self-contained.
The result is a bit spaghetti-ish, because gdbsupport uses another m4
file from gdb/. The resulting code is somewhat non-obvious. However,
these problems already exist, so it's not really that much worse than
what is already done.
gdb/ChangeLog
2020-01-14 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
* configure.ac: Move many checks to ../gdbsupport/common.m4.
gdb/gdbserver/ChangeLog
2020-01-14 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
* configure.ac: Remove any checks that were added to common.m4.
* acinclude.m4: Include lib-ld.m4, lib-prefix.m4, and
lib-link.m4.
gdbsupport/ChangeLog
2020-01-14 Tom Tromey <tom@tromey.com>
* configure, Makefile.in, aclocal.m4, common.m4, config.in:
Rebuild.
* common.m4 (GDB_AC_COMMON): Move many checks from
gdb/configure.ac.
* acinclude.m4: Include bfd.m4, ptrace.m4.
Change-Id: I931eaa94065df268b30a2f1354390710df89c7f8
2019-12-20 00:40:15 +01:00
|
|
|
|
2020-01-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* configure: Rebuild.
|
|
|
|
|
|
* configure.ac: Move many checks to ../gdbsupport/common.m4.
|
|
|
|
|
|
|
Move gdbsupport to the top level
This patch moves the gdbsupport directory to the top level. This is
the next step in the ongoing project to move gdbserver to the top
level.
The bulk of this patch was created by "git mv gdb/gdbsupport gdbsupport".
This patch then adds a build system to gdbsupport and wires it into
the top level. Then it changes gdb to use the top-level build.
gdbserver, on the other hand, is not yet changed. It still does its
own build of gdbsupport.
ChangeLog
2020-01-14 Tom Tromey <tom@tromey.com>
* src-release.sh (GDB_SUPPORT_DIRS): Add gdbsupport.
* MAINTAINERS: Add gdbsupport.
* configure: Rebuild.
* configure.ac (configdirs): Add gdbsupport.
* gdbsupport: New directory, move from gdb/gdbsupport.
* Makefile.def (host_modules, dependencies): Add gnulib.
* Makefile.in: Rebuild.
gdb/ChangeLog
2020-01-14 Tom Tromey <tom@tromey.com>
* nat/x86-linux-dregs.c: Include configh.h.
* nat/linux-ptrace.c: Include configh.h.
* nat/linux-btrace.c: Include configh.h.
* defs.h: Include config.h, bfd.h.
* configure.ac: Don't source common.host.
(CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
* configure: Rebuild.
* acinclude.m4: Update path.
* Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
(CONFIG_SRC_SUBDIR): Remove gdbsupport.
(INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
(CLIBS): Add LIBSUPPORT.
(CDEPS): Likewise.
(COMMON_SFILES): Remove gdbsupport files.
(HFILES_NO_SRCDIR): Likewise.
(stamp-version): Update path to create-version.sh.
(ALLDEPFILES): Remove gdbsupport files.
gdb/gdbserver/ChangeLog
2020-01-14 Tom Tromey <tom@tromey.com>
* server.h: Include config.h.
* gdbreplay.c: Include config.h.
* configure: Rebuild.
* configure.ac: Don't source common.host.
* acinclude.m4: Update path.
* Makefile.in (INCSUPPORT): New variable.
(INCLUDE_CFLAGS): Add INCSUPPORT.
(SFILES): Update paths.
(version-generated.c): Update path to create-version.sh.
(gdbsupport/%-ipa.o, gdbsupport/%.o): Update paths.
gdbsupport/ChangeLog
2020-01-14 Tom Tromey <tom@tromey.com>
* common-defs.h: Add GDBSERVER case. Update includes.
* acinclude.m4, aclocal.m4, config.in, configure, configure.ac,
Makefile.am, Makefile.in, README: New files.
* Moved from ../gdb/gdbsupport/
Change-Id: I07632e7798635c1bab389bf885971e584fb4bb78
2019-07-09 16:06:39 +02:00
|
|
|
|
2020-01-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* nat/x86-linux-dregs.c: Include configh.h.
|
|
|
|
|
|
* nat/linux-ptrace.c: Include configh.h.
|
|
|
|
|
|
* nat/linux-btrace.c: Include configh.h.
|
|
|
|
|
|
* defs.h: Include config.h, bfd.h.
|
|
|
|
|
|
* configure.ac: Don't source common.host.
|
|
|
|
|
|
(CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
|
|
|
|
|
|
* configure: Rebuild.
|
|
|
|
|
|
* acinclude.m4: Update path.
|
|
|
|
|
|
* Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
|
|
|
|
|
|
(CONFIG_SRC_SUBDIR): Remove gdbsupport.
|
|
|
|
|
|
(INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
|
|
|
|
|
|
(CLIBS): Add LIBSUPPORT.
|
|
|
|
|
|
(CDEPS): Likewise.
|
|
|
|
|
|
(COMMON_SFILES): Remove gdbsupport files.
|
|
|
|
|
|
(HFILES_NO_SRCDIR): Likewise.
|
|
|
|
|
|
(stamp-version): Update path to create-version.sh.
|
|
|
|
|
|
(ALLDEPFILES): Remove gdbsupport files.
|
|
|
|
|
|
|
2019-10-23 00:22:58 +02:00
|
|
|
|
2020-01-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
|
|
|
|
|
|
USE_WIN32API when needed.
|
|
|
|
|
|
* configure.ac (USE_WIN32API): Don't define.
|
|
|
|
|
|
(WIN32LIBS): Use WIN32APILIBS.
|
|
|
|
|
|
* configure: Rebuild.
|
|
|
|
|
|
|
2020-01-15 00:16:39 +01:00
|
|
|
|
2020-01-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* configure: Rebuild.
|
|
|
|
|
|
* gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
|
|
|
|
|
|
|
2019-12-25 16:35:32 +01:00
|
|
|
|
2020-01-14 Bernd Edlinger <bernd.edlinger@hotmail.de>
|
|
|
|
|
|
|
|
|
|
|
|
* skip.c (skip_function_command): Make skip w/o arguments use the
|
|
|
|
|
|
name of the inlined function if pc is inside any inlined function.
|
|
|
|
|
|
|
2019-12-06 22:12:37 +01:00
|
|
|
|
2020-01-14 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* inf-ptrace.c (inf_ptrace_target::resume): Update comments.
|
|
|
|
|
|
* infrun.c (resume_1): Likewise.
|
|
|
|
|
|
(handle_inferior_event): Remove stale comment.
|
|
|
|
|
|
* linux-nat.c (linux_nat_target::resume): Update comments.
|
|
|
|
|
|
(save_stop_reason): Likewise.
|
|
|
|
|
|
(linux_nat_filter_event): Likewise.
|
|
|
|
|
|
* linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
|
|
|
|
|
|
|
gdb: Handle malformed ELF, symbols in non-allocatable sections
I ended up debugging a malformed ELF where a section containing
executable code was not correctly marked as allocatable. Before
realising the ELF was corrupted I tried to place a breakpoint on a
symbol in the non-allocatable, executable section, and GDB crashed.
Though trying to debug such an ELF clearly isn't going to go well I
would prefer, as far as possible, that any input, no matter how
corrupted, not crash GDB.
The crash occurs when trying to set a breakpoint on the name of a
function from the corrupted section. GDB converts the symbol to a
symtab_and_line, and looks up a suitable section for this.
The problem is that the section is actually an obj_section, which is
stored in the table within the objfile, and we only initialise this
table for allocatable sections (see add_to_objfile_sections_full in
objfiles.c). So, if the symbol is in a non-allocatable section then
we end up referencing an uninitialised obj_section.
Later we call get_sal_arch on the symtab_and_line, which calls
get_objfile_arch, which uses the objfile from the uninitialised
obj_section, which will be nullptr, at which point GDB crashes.
The fix I propose here is that when we setup the section references on
msymbols, we should check if the bfd_section being referenced is
allocatable or not. If it is not then we should set the section
reference back to the default 0 section (see how MSYMBOL_OBJ_SECTION
and SYMBOL_OBJ_SECTION treat the 0 section index).
With this fix in place GDB no longer crashes. Instead GDB creates the
breakpoint at the non-allocated address, and then fails, with an
error, when it tries to insert the breakpoint.
gdb/ChangeLog:
* elfread.c (record_minimal_symbol): Set section index to 0 for
non-allocatable sections.
gdb/testsuite/ChangeLog:
* gdb.dwarf2/dw2-bad-elf-other.S: New file.
* gdb.dwarf2/dw2-bad-elf.c: New file.
* gdb.dwarf2/dw2-bad-elf.exp: New file.
Change-Id: Ie05436ab4c6a71440304d20ee639dfb021223f8b
2019-12-07 00:12:29 +01:00
|
|
|
|
2020-01-13 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* elfread.c (record_minimal_symbol): Set section index to 0 for
|
|
|
|
|
|
non-allocatable sections.
|
|
|
|
|
|
|
Dwarf 5: Handle debug_str_offsets and indexed attributes that have base offsets.
* Process debug_str_offsets section. Handle DW_AT_str_offsets_base attribute and
keep the value in dwarf2_cu.
* Make addr_base field in dwarf2_cu optional to disambiguate 0 value
(absent or present and 0).
* During parsing, there is no guarantee that DW_AT_str_offsets_base and
DW_AT_rnglists_base fields will be processed before the attributes that need
those values for correct computation. So make two passes, on the first one mark
the attributes that depend on *_base attributes and process only the others.
On the second pass, only process the attributes that are marked on the first
pass.
* For string attributes, differentiate between addresses that directly point to
a string and those that point to an offset in debug_str_offsets section.
* There are now two attributes, DW_AT_addr_base and DW_AT_GNU_addr_base to read
address offset base. Likewise, there are two attributes, DW_AT_rnglists_base
and DW_AT_GNU_ranges_base to read ranges base. Since there is no guarantee which
ones the compiler will generate, create helper functions to handle all cases.
Tested with CC=/usr/bin/gcc (version 8.3.0) against master branch (also with
-gsplit-dwarf and -gdwarf-4 flags) and there was no increase in the set of
tests that fails. (gdb still cannot debug a 'hello world' program with DWARF 5,
so for the time being, this is all we care about).
This is part of an effort to support DWARF-5 in gdb.
2019-12-24 04:31:24 +01:00
|
|
|
|
|
|
|
|
|
|
2020-01-13 Ali Tamur <tamur@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
|
|
|
|
|
|
(dwarf2_cu): Add str_offsets_base field. Change the type of addr_base
|
|
|
|
|
|
to gdb::optional. Update comments.
|
|
|
|
|
|
(dwo_file): Update comments.
|
|
|
|
|
|
(read_attribute): Update API to take an additional out parameter,
|
|
|
|
|
|
need_reprocess. This is used to mark attributes that need other
|
|
|
|
|
|
attributes (e.g. str_offsets_base) for correct computation which may not
|
|
|
|
|
|
have been read yet.
|
|
|
|
|
|
(read_attribute_reprocess): New function declaration.
|
|
|
|
|
|
(read_addr_index): Likewise.
|
|
|
|
|
|
(read_dwo_str_index): Likewise.
|
|
|
|
|
|
(read_stub_str_index): Likewise.
|
|
|
|
|
|
(dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
|
|
|
|
|
|
(lookup_addr_base): New function definition.
|
|
|
|
|
|
(lookup_ranges_base): Likewise.
|
|
|
|
|
|
(read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
|
|
|
|
|
|
lookup_ranges_base.
|
|
|
|
|
|
(init_cutu_and_read_dies): Update comments.
|
|
|
|
|
|
(init_cutu_and_read_dies_no_follow): Change API to take parent compile
|
|
|
|
|
|
unit. This is used to inherit parent's str_offsets_base and addr_base.
|
|
|
|
|
|
Update comments.
|
|
|
|
|
|
(init_cutu_and_read_dies_simple): Reflect API changes.
|
|
|
|
|
|
(skip_one_die): Reflect API changes. Handle DW_FORM_rnglistx.
|
|
|
|
|
|
(create_cus_hash_table): Change API to take parent compile unit.
|
|
|
|
|
|
Reflect API changes.
|
|
|
|
|
|
(open_and_init_dwo_file): Reflect API changes.
|
|
|
|
|
|
(dwarf2_get_pc_bounds): Update comments.
|
|
|
|
|
|
(dwarf2_record_block_ranges): Likewise.
|
|
|
|
|
|
(read_full_die_1): Change implementation to reprocess attributes that
|
|
|
|
|
|
need str_offsets_base and addr_base.
|
|
|
|
|
|
(partial_die_info::read): Likewise.
|
|
|
|
|
|
(read_attribute_reprocess): New function definition.
|
|
|
|
|
|
(read_attribute_value): Change API to take an additional out parameter,
|
|
|
|
|
|
need_reprocess. Handle DW_FORM_rnglistx. No longer trigger an error
|
|
|
|
|
|
when a non-dwo compile unit has index based attributes.
|
|
|
|
|
|
(read_attribute): Reflect API changes.
|
|
|
|
|
|
(read_addr_index_1): Reflect API changes. Update comments.
|
|
|
|
|
|
(dwarf2_read_addr_index_data): Reflect API changes.
|
|
|
|
|
|
(dwarf2_read_addr_index): Likewise.
|
|
|
|
|
|
(read_str_index): Change API and implementation. This becomes a helper
|
|
|
|
|
|
to be used by the new string index related methods. Update error
|
|
|
|
|
|
message and comments.
|
|
|
|
|
|
(read_dwo_str_index): New function definition.
|
|
|
|
|
|
(read_stub_str_index): Likewise.
|
|
|
|
|
|
* dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
|
|
|
|
|
|
* symfile.h (dwarf2_debug_sections): Likewise.
|
|
|
|
|
|
* xcoffread.c (dwarf2_debug_sections): Likewise.
|
|
|
|
|
|
|
2020-01-14 00:12:08 +01:00
|
|
|
|
2020-01-13 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbcore.h (struct core_fns) <core_read_registers>: Change
|
|
|
|
|
|
core_reg_sect type to gdb_byte *.
|
|
|
|
|
|
* arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
|
|
|
|
|
|
* cris-tdep.c (fetch_core_registers): Likewise.
|
|
|
|
|
|
* corelow.c (core_target::get_core_register_section): Change
|
|
|
|
|
|
type of `contents` to gdb::byte_vector.
|
|
|
|
|
|
|
2020-01-10 01:04:25 +01:00
|
|
|
|
2020-01-13 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-wingeneral.c (box_win): Position the title in the center
|
|
|
|
|
|
of the border.
|
|
|
|
|
|
|
gdb: use std::vector instead of alloca in core_target::get_core_register_section
As I was trying to compile gdb for an m68k host, I got this error:
CXX corelow.o
In file included from /binutils-gdb/gdb/gdbsupport/common-defs.h:120,
from /binutils-gdb/gdb/defs.h:28,
from /binutils-gdb/gdb/corelow.c:20:
/binutils-gdb/gdb/corelow.c: In member function 'void core_target::get_core_register_section(regcache*, const regset*, const char*, int, int, const char*, bool)':
/binutils-gdb/gdb/../include/libiberty.h:727:36: error: 'alloca' bound is unknown [-Werror=alloca-larger-than=]
727 | # define alloca(x) __builtin_alloca(x)
| ~~~~~~~~~~~~~~~~^~~
/binutils-gdb/gdb/corelow.c:625:23: note: in expansion of macro 'alloca'
625 | contents = (char *) alloca (size);
| ^~~~~~
We are using alloca to hold the contents of a the core register
sections. These sections are typically fairly small, but there is no
realy guarantee, so I think it would be more reasonable to just use
dynamic allocation here.
gdb/ChangeLog:
* corelow.c (core_target::get_core_register_section): Use
std::vector instead of alloca.
2020-01-13 20:32:52 +01:00
|
|
|
|
2020-01-13 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* corelow.c (core_target::get_core_register_section): Use
|
|
|
|
|
|
std::vector instead of alloca.
|
|
|
|
|
|
|
2020-01-13 20:05:44 +01:00
|
|
|
|
2020-01-13 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* warning.m4: Add -Wmissing-declarations to build_warnings.
|
|
|
|
|
|
* configure: Re-generate.
|
|
|
|
|
|
|
2020-01-13 20:03:04 +01:00
|
|
|
|
2020-01-13 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* python/python.c (init__gdb_module): Add declaration.
|
|
|
|
|
|
|
2020-01-13 20:01:38 +01:00
|
|
|
|
2020-01-13 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
|
|
|
|
|
|
* aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
|
|
|
|
|
|
* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
|
|
|
|
|
|
* aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
|
|
|
|
|
|
* aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
|
|
|
|
|
|
* aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
|
|
|
|
|
|
* ada-exp.y (_initialize_ada_exp): Add declaration.
|
|
|
|
|
|
* ada-lang.c (_initialize_ada_language): Add declaration.
|
|
|
|
|
|
* ada-tasks.c (_initialize_tasks): Add declaration.
|
|
|
|
|
|
* agent.c (_initialize_agent): Add declaration.
|
|
|
|
|
|
* aix-thread.c (_initialize_aix_thread): Add declaration.
|
|
|
|
|
|
* alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
|
|
|
|
|
|
* alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
|
|
|
|
|
|
* alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
|
|
|
|
|
|
* alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
|
|
|
|
|
|
* alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
|
|
|
|
|
|
* alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
|
|
|
|
|
|
* amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
|
|
|
|
|
|
* amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
|
|
|
|
|
|
* amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
|
|
|
|
|
|
* amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
|
|
|
|
|
|
* amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
|
|
|
|
|
|
* amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
|
|
|
|
|
|
* amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
|
|
|
|
|
|
* amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
|
|
|
|
|
|
* amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
|
|
|
|
|
|
* amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
|
|
|
|
|
|
* amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
|
|
|
|
|
|
* amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
|
|
|
|
|
|
* amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
|
|
|
|
|
|
* amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
|
|
|
|
|
|
* annotate.c (_initialize_annotate): Add declaration.
|
|
|
|
|
|
* arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
|
|
|
|
|
|
* arc-tdep.c (_initialize_arc_tdep): Add declaration.
|
|
|
|
|
|
* arch-utils.c (_initialize_gdbarch_utils): Add declaration.
|
|
|
|
|
|
* arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
|
|
|
|
|
|
* arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
|
|
|
|
|
|
* arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
|
|
|
|
|
|
* arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
|
|
|
|
|
|
* arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
|
|
|
|
|
|
* arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
|
|
|
|
|
|
* arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
|
|
|
|
|
|
* arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
|
|
|
|
|
|
* arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
|
|
|
|
|
|
* arm-tdep.c (_initialize_arm_tdep): Add declaration.
|
|
|
|
|
|
* arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
|
|
|
|
|
|
* auto-load.c (_initialize_auto_load): Add declaration.
|
|
|
|
|
|
* auxv.c (_initialize_auxv): Add declaration.
|
|
|
|
|
|
* avr-tdep.c (_initialize_avr_tdep): Add declaration.
|
|
|
|
|
|
* ax-gdb.c (_initialize_ax_gdb): Add declaration.
|
|
|
|
|
|
* bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
|
|
|
|
|
|
* bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
|
|
|
|
|
|
* break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
|
|
|
|
|
|
* break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
|
|
|
|
|
|
* break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
|
|
|
|
|
|
* breakpoint.c (_initialize_breakpoint): Add declaration.
|
|
|
|
|
|
* bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
|
|
|
|
|
|
* btrace.c (_initialize_btrace): Add declaration.
|
|
|
|
|
|
* charset.c (_initialize_charset): Add declaration.
|
|
|
|
|
|
* cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
|
|
|
|
|
|
* cli/cli-dump.c (_initialize_cli_dump): Add declaration.
|
|
|
|
|
|
* cli/cli-interp.c (_initialize_cli_interp): Add declaration.
|
|
|
|
|
|
* cli/cli-logging.c (_initialize_cli_logging): Add declaration.
|
|
|
|
|
|
* cli/cli-script.c (_initialize_cli_script): Add declaration.
|
|
|
|
|
|
* cli/cli-style.c (_initialize_cli_style): Add declaration.
|
|
|
|
|
|
* coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
|
|
|
|
|
|
* coffread.c (_initialize_coffread): Add declaration.
|
|
|
|
|
|
* compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
|
|
|
|
|
|
* compile/compile.c (_initialize_compile): Add declaration.
|
|
|
|
|
|
* complaints.c (_initialize_complaints): Add declaration.
|
|
|
|
|
|
* completer.c (_initialize_completer): Add declaration.
|
|
|
|
|
|
* copying.c (_initialize_copying): Add declaration.
|
|
|
|
|
|
* corefile.c (_initialize_core): Add declaration.
|
|
|
|
|
|
* corelow.c (_initialize_corelow): Add declaration.
|
|
|
|
|
|
* cp-abi.c (_initialize_cp_abi): Add declaration.
|
|
|
|
|
|
* cp-namespace.c (_initialize_cp_namespace): Add declaration.
|
|
|
|
|
|
* cp-support.c (_initialize_cp_support): Add declaration.
|
|
|
|
|
|
* cp-valprint.c (_initialize_cp_valprint): Add declaration.
|
|
|
|
|
|
* cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
|
|
|
|
|
|
* cris-tdep.c (_initialize_cris_tdep): Add declaration.
|
|
|
|
|
|
* csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
|
|
|
|
|
|
* csky-tdep.c (_initialize_csky_tdep): Add declaration.
|
|
|
|
|
|
* ctfread.c (_initialize_ctfread): Add declaration.
|
|
|
|
|
|
* d-lang.c (_initialize_d_language): Add declaration.
|
|
|
|
|
|
* darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
|
|
|
|
|
|
* darwin-nat.c (_initialize_darwin_nat): Add declaration.
|
|
|
|
|
|
* dbxread.c (_initialize_dbxread): Add declaration.
|
|
|
|
|
|
* dcache.c (_initialize_dcache): Add declaration.
|
|
|
|
|
|
* disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
|
|
|
|
|
|
* disasm.c (_initialize_disasm): Add declaration.
|
|
|
|
|
|
* dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
|
|
|
|
|
|
* dummy-frame.c (_initialize_dummy_frame): Add declaration.
|
|
|
|
|
|
* dwarf-index-cache.c (_initialize_index_cache): Add declaration.
|
|
|
|
|
|
* dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
|
|
|
|
|
|
* dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
|
|
|
|
|
|
* dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
|
|
|
|
|
|
* dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
|
|
|
|
|
|
* dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
|
|
|
|
|
|
* dwarf2read.c (_initialize_dwarf2_read): Add declaration.
|
|
|
|
|
|
* elfread.c (_initialize_elfread): Add declaration.
|
|
|
|
|
|
* exec.c (_initialize_exec): Add declaration.
|
|
|
|
|
|
* extension.c (_initialize_extension): Add declaration.
|
|
|
|
|
|
* f-lang.c (_initialize_f_language): Add declaration.
|
|
|
|
|
|
* f-valprint.c (_initialize_f_valprint): Add declaration.
|
|
|
|
|
|
* fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
|
|
|
|
|
|
* fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
|
|
|
|
|
|
* filesystem.c (_initialize_filesystem): Add declaration.
|
|
|
|
|
|
* findcmd.c (_initialize_mem_search): Add declaration.
|
|
|
|
|
|
* findvar.c (_initialize_findvar): Add declaration.
|
|
|
|
|
|
* fork-child.c (_initialize_fork_child): Add declaration.
|
|
|
|
|
|
* frame-base.c (_initialize_frame_base): Add declaration.
|
|
|
|
|
|
* frame-unwind.c (_initialize_frame_unwind): Add declaration.
|
|
|
|
|
|
* frame.c (_initialize_frame): Add declaration.
|
|
|
|
|
|
* frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
|
|
|
|
|
|
* frv-tdep.c (_initialize_frv_tdep): Add declaration.
|
|
|
|
|
|
* ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
|
|
|
|
|
|
* gcore.c (_initialize_gcore): Add declaration.
|
|
|
|
|
|
* gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
|
|
|
|
|
|
* gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
|
|
|
|
|
|
* gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
|
|
|
|
|
|
* gdbarch.c (_initialize_gdbarch): Add declaration.
|
|
|
|
|
|
* gdbtypes.c (_initialize_gdbtypes): Add declaration.
|
|
|
|
|
|
* gnu-nat.c (_initialize_gnu_nat): Add declaration.
|
|
|
|
|
|
* gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
|
|
|
|
|
|
* gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
|
|
|
|
|
|
* go-lang.c (_initialize_go_language): Add declaration.
|
|
|
|
|
|
* go32-nat.c (_initialize_go32_nat): Add declaration.
|
|
|
|
|
|
* guile/guile.c (_initialize_guile): Add declaration.
|
|
|
|
|
|
* h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
|
|
|
|
|
|
* hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
|
|
|
|
|
|
* hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
|
|
|
|
|
|
* hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
|
|
|
|
|
|
* hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
|
|
|
|
|
|
* hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
|
|
|
|
|
|
* hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
|
|
|
|
|
|
* hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
|
|
|
|
|
|
* i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
|
|
|
|
|
|
* i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
|
|
|
|
|
|
* i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
|
|
|
|
|
|
* i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
|
|
|
|
|
|
* i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
|
|
|
|
|
|
* i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
|
|
|
|
|
|
* i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
|
|
|
|
|
|
* i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
|
|
|
|
|
|
* i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
|
|
|
|
|
|
* i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
|
|
|
|
|
|
* i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
|
|
|
|
|
|
* i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
|
|
|
|
|
|
* i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
|
|
|
|
|
|
* i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
|
|
|
|
|
|
* i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
|
|
|
|
|
|
* i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
|
|
|
|
|
|
* i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
|
|
|
|
|
|
* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
|
|
|
|
|
|
* i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
|
|
|
|
|
|
* i386-tdep.c (_initialize_i386_tdep): Add declaration.
|
|
|
|
|
|
* i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
|
|
|
|
|
|
* ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
|
|
|
|
|
|
* ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
|
|
|
|
|
|
* ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
|
|
|
|
|
|
* ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
|
|
|
|
|
|
* ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
|
|
|
|
|
|
* infcall.c (_initialize_infcall): Add declaration.
|
|
|
|
|
|
* infcmd.c (_initialize_infcmd): Add declaration.
|
|
|
|
|
|
* inflow.c (_initialize_inflow): Add declaration.
|
|
|
|
|
|
* infrun.c (_initialize_infrun): Add declaration.
|
|
|
|
|
|
* interps.c (_initialize_interpreter): Add declaration.
|
|
|
|
|
|
* iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
|
|
|
|
|
|
* jit.c (_initialize_jit): Add declaration.
|
|
|
|
|
|
* language.c (_initialize_language): Add declaration.
|
|
|
|
|
|
* linux-fork.c (_initialize_linux_fork): Add declaration.
|
|
|
|
|
|
* linux-nat.c (_initialize_linux_nat): Add declaration.
|
|
|
|
|
|
* linux-tdep.c (_initialize_linux_tdep): Add declaration.
|
|
|
|
|
|
* linux-thread-db.c (_initialize_thread_db): Add declaration.
|
|
|
|
|
|
* lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
|
|
|
|
|
|
* m2-lang.c (_initialize_m2_language): Add declaration.
|
|
|
|
|
|
* m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
|
|
|
|
|
|
* m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
|
|
|
|
|
|
* m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
|
|
|
|
|
|
* m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
|
|
|
|
|
|
* m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
|
|
|
|
|
|
* m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
|
|
|
|
|
|
* m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
|
|
|
|
|
|
* m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
|
|
|
|
|
|
* m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
|
|
|
|
|
|
* m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
|
|
|
|
|
|
* machoread.c (_initialize_machoread): Add declaration.
|
|
|
|
|
|
* macrocmd.c (_initialize_macrocmd): Add declaration.
|
|
|
|
|
|
* macroscope.c (_initialize_macroscope): Add declaration.
|
|
|
|
|
|
* maint-test-options.c (_initialize_maint_test_options): Add declaration.
|
|
|
|
|
|
* maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
|
|
|
|
|
|
* maint.c (_initialize_maint_cmds): Add declaration.
|
|
|
|
|
|
* mdebugread.c (_initialize_mdebugread): Add declaration.
|
|
|
|
|
|
* memattr.c (_initialize_mem): Add declaration.
|
|
|
|
|
|
* mep-tdep.c (_initialize_mep_tdep): Add declaration.
|
|
|
|
|
|
* mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
|
|
|
|
|
|
* mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
|
|
|
|
|
|
* mi/mi-interp.c (_initialize_mi_interp): Add declaration.
|
|
|
|
|
|
* mi/mi-main.c (_initialize_mi_main): Add declaration.
|
|
|
|
|
|
* microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
|
|
|
|
|
|
* microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
|
|
|
|
|
|
* mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
|
|
|
|
|
|
* mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
|
|
|
|
|
|
* mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
|
|
|
|
|
|
* mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
|
|
|
|
|
|
* mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
|
|
|
|
|
|
* mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
|
|
|
|
|
|
* mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
|
|
|
|
|
|
* mips-tdep.c (_initialize_mips_tdep): Add declaration.
|
|
|
|
|
|
* mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
|
|
|
|
|
|
* mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
|
|
|
|
|
|
* mipsread.c (_initialize_mipsread): Add declaration.
|
|
|
|
|
|
* mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
|
|
|
|
|
|
* mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
|
|
|
|
|
|
* moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
|
|
|
|
|
|
* msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
|
|
|
|
|
|
* nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
|
|
|
|
|
|
* nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
|
|
|
|
|
|
* nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
|
|
|
|
|
|
* nto-procfs.c (_initialize_procfs): Add declaration.
|
|
|
|
|
|
* objc-lang.c (_initialize_objc_language): Add declaration.
|
|
|
|
|
|
* observable.c (_initialize_observer): Add declaration.
|
|
|
|
|
|
* opencl-lang.c (_initialize_opencl_language): Add declaration.
|
|
|
|
|
|
* or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
|
|
|
|
|
|
* or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
|
|
|
|
|
|
* osabi.c (_initialize_gdb_osabi): Add declaration.
|
|
|
|
|
|
* osdata.c (_initialize_osdata): Add declaration.
|
|
|
|
|
|
* p-valprint.c (_initialize_pascal_valprint): Add declaration.
|
|
|
|
|
|
* parse.c (_initialize_parse): Add declaration.
|
|
|
|
|
|
* ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
|
|
|
|
|
|
* ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
|
|
|
|
|
|
* ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
|
|
|
|
|
|
* ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
|
|
|
|
|
|
* ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
|
|
|
|
|
|
* ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
|
|
|
|
|
|
* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
|
|
|
|
|
|
* ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
|
|
|
|
|
|
* printcmd.c (_initialize_printcmd): Add declaration.
|
|
|
|
|
|
* probe.c (_initialize_probe): Add declaration.
|
|
|
|
|
|
* proc-api.c (_initialize_proc_api): Add declaration.
|
|
|
|
|
|
* proc-events.c (_initialize_proc_events): Add declaration.
|
|
|
|
|
|
* proc-service.c (_initialize_proc_service): Add declaration.
|
|
|
|
|
|
* procfs.c (_initialize_procfs): Add declaration.
|
|
|
|
|
|
* producer.c (_initialize_producer): Add declaration.
|
|
|
|
|
|
* psymtab.c (_initialize_psymtab): Add declaration.
|
|
|
|
|
|
* python/python.c (_initialize_python): Add declaration.
|
|
|
|
|
|
* ravenscar-thread.c (_initialize_ravenscar): Add declaration.
|
|
|
|
|
|
* record-btrace.c (_initialize_record_btrace): Add declaration.
|
|
|
|
|
|
* record-full.c (_initialize_record_full): Add declaration.
|
|
|
|
|
|
* record.c (_initialize_record): Add declaration.
|
|
|
|
|
|
* regcache-dump.c (_initialize_regcache_dump): Add declaration.
|
|
|
|
|
|
* regcache.c (_initialize_regcache): Add declaration.
|
|
|
|
|
|
* reggroups.c (_initialize_reggroup): Add declaration.
|
|
|
|
|
|
* remote-notif.c (_initialize_notif): Add declaration.
|
|
|
|
|
|
* remote-sim.c (_initialize_remote_sim): Add declaration.
|
|
|
|
|
|
* remote.c (_initialize_remote): Add declaration.
|
|
|
|
|
|
* reverse.c (_initialize_reverse): Add declaration.
|
|
|
|
|
|
* riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
|
|
|
|
|
|
* riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
|
|
|
|
|
|
* riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
|
|
|
|
|
|
* riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
|
|
|
|
|
|
* riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
|
|
|
|
|
|
* rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
|
|
|
|
|
|
* rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
|
|
|
|
|
|
* rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
|
|
|
|
|
|
Add declaration.
|
|
|
|
|
|
* rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
|
|
|
|
|
|
* rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
|
|
|
|
|
|
* run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
|
|
|
|
|
|
* rust-exp.y (_initialize_rust_exp): Add declaration.
|
|
|
|
|
|
* rx-tdep.c (_initialize_rx_tdep): Add declaration.
|
|
|
|
|
|
* s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
|
|
|
|
|
|
* s390-linux-nat.c (_initialize_s390_nat): Add declaration.
|
|
|
|
|
|
* s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
|
|
|
|
|
|
* s390-tdep.c (_initialize_s390_tdep): Add declaration.
|
|
|
|
|
|
* score-tdep.c (_initialize_score_tdep): Add declaration.
|
|
|
|
|
|
* ser-go32.c (_initialize_ser_dos): Add declaration.
|
|
|
|
|
|
* ser-mingw.c (_initialize_ser_windows): Add declaration.
|
|
|
|
|
|
* ser-pipe.c (_initialize_ser_pipe): Add declaration.
|
|
|
|
|
|
* ser-tcp.c (_initialize_ser_tcp): Add declaration.
|
|
|
|
|
|
* ser-uds.c (_initialize_ser_socket): Add declaration.
|
|
|
|
|
|
* ser-unix.c (_initialize_ser_hardwire): Add declaration.
|
|
|
|
|
|
* serial.c (_initialize_serial): Add declaration.
|
|
|
|
|
|
* sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
|
|
|
|
|
|
* sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
|
|
|
|
|
|
* sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
|
|
|
|
|
|
* sh-tdep.c (_initialize_sh_tdep): Add declaration.
|
|
|
|
|
|
* skip.c (_initialize_step_skip): Add declaration.
|
|
|
|
|
|
* sol-thread.c (_initialize_sol_thread): Add declaration.
|
|
|
|
|
|
* solib-aix.c (_initialize_solib_aix): Add declaration.
|
|
|
|
|
|
* solib-darwin.c (_initialize_darwin_solib): Add declaration.
|
|
|
|
|
|
* solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
|
|
|
|
|
|
* solib-frv.c (_initialize_frv_solib): Add declaration.
|
|
|
|
|
|
* solib-svr4.c (_initialize_svr4_solib): Add declaration.
|
|
|
|
|
|
* solib-target.c (_initialize_solib_target): Add declaration.
|
|
|
|
|
|
* solib.c (_initialize_solib): Add declaration.
|
|
|
|
|
|
* source-cache.c (_initialize_source_cache): Add declaration.
|
|
|
|
|
|
* source.c (_initialize_source): Add declaration.
|
|
|
|
|
|
* sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
|
|
|
|
|
|
* sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
|
|
|
|
|
|
* sparc-nat.c (_initialize_sparc_nat): Add declaration.
|
|
|
|
|
|
* sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
|
|
|
|
|
|
* sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
|
|
|
|
|
|
* sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
|
|
|
|
|
|
* sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
|
|
|
|
|
|
* sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
|
|
|
|
|
|
* sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
|
|
|
|
|
|
* sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
|
|
|
|
|
|
* sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
|
|
|
|
|
|
* sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
|
|
|
|
|
|
* sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
|
|
|
|
|
|
* sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
|
|
|
|
|
|
* sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
|
|
|
|
|
|
* sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
|
|
|
|
|
|
* sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
|
|
|
|
|
|
* sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
|
|
|
|
|
|
* sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
|
|
|
|
|
|
* stabsread.c (_initialize_stabsread): Add declaration.
|
|
|
|
|
|
* stack.c (_initialize_stack): Add declaration.
|
|
|
|
|
|
* stap-probe.c (_initialize_stap_probe): Add declaration.
|
|
|
|
|
|
* std-regs.c (_initialize_frame_reg): Add declaration.
|
|
|
|
|
|
* symfile-debug.c (_initialize_symfile_debug): Add declaration.
|
|
|
|
|
|
* symfile-mem.c (_initialize_symfile_mem): Add declaration.
|
|
|
|
|
|
* symfile.c (_initialize_symfile): Add declaration.
|
|
|
|
|
|
* symmisc.c (_initialize_symmisc): Add declaration.
|
|
|
|
|
|
* symtab.c (_initialize_symtab): Add declaration.
|
|
|
|
|
|
* target.c (_initialize_target): Add declaration.
|
|
|
|
|
|
* target-connection.c (_initialize_target_connection): Add
|
|
|
|
|
|
declaration.
|
|
|
|
|
|
* target-dcache.c (_initialize_target_dcache): Add declaration.
|
|
|
|
|
|
* target-descriptions.c (_initialize_target_descriptions): Add declaration.
|
|
|
|
|
|
* thread.c (_initialize_thread): Add declaration.
|
|
|
|
|
|
* tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
|
|
|
|
|
|
* tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
|
|
|
|
|
|
* tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
|
|
|
|
|
|
* tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
|
|
|
|
|
|
* tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
|
|
|
|
|
|
* tracectf.c (_initialize_ctf): Add declaration.
|
|
|
|
|
|
* tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
|
|
|
|
|
|
* tracefile.c (_initialize_tracefile): Add declaration.
|
|
|
|
|
|
* tracepoint.c (_initialize_tracepoint): Add declaration.
|
|
|
|
|
|
* tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
|
|
|
|
|
|
* tui/tui-interp.c (_initialize_tui_interp): Add declaration.
|
|
|
|
|
|
* tui/tui-layout.c (_initialize_tui_layout): Add declaration.
|
|
|
|
|
|
* tui/tui-regs.c (_initialize_tui_regs): Add declaration.
|
|
|
|
|
|
* tui/tui-stack.c (_initialize_tui_stack): Add declaration.
|
|
|
|
|
|
* tui/tui-win.c (_initialize_tui_win): Add declaration.
|
|
|
|
|
|
* tui/tui.c (_initialize_tui): Add declaration.
|
|
|
|
|
|
* typeprint.c (_initialize_typeprint): Add declaration.
|
|
|
|
|
|
* ui-style.c (_initialize_ui_style): Add declaration.
|
|
|
|
|
|
* unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
|
|
|
|
|
|
* unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
|
|
|
|
|
|
* unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
|
|
|
|
|
|
* unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
|
|
|
|
|
|
* unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
|
|
|
|
|
|
* unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
|
|
|
|
|
|
* unittests/filtered_iterator-selftests.c
|
|
|
|
|
|
(_initialize_filtered_iterator_selftests): Add declaration.
|
|
|
|
|
|
* unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
|
|
|
|
|
|
* unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
|
|
|
|
|
|
* unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
|
|
|
|
|
|
* unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
|
|
|
|
|
|
* unittests/main-thread-selftests.c
|
|
|
|
|
|
(_initialize_main_thread_selftests): Add declaration.
|
|
|
|
|
|
* unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
|
|
|
|
|
|
* unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
|
|
|
|
|
|
* unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
|
|
|
|
|
|
* unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
|
|
|
|
|
|
* unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
|
|
|
|
|
|
* unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
|
|
|
|
|
|
* unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
|
|
|
|
|
|
* unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
|
|
|
|
|
|
* unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
|
|
|
|
|
|
* unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
|
|
|
|
|
|
* unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
|
|
|
|
|
|
* unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
|
|
|
|
|
|
* unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
|
|
|
|
|
|
* unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
|
|
|
|
|
|
* unittests/tui-selftests.c (_initialize_tui_selftest): Add
|
|
|
|
|
|
declaration.
|
|
|
|
|
|
* unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
|
|
|
|
|
|
* unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
|
|
|
|
|
|
* unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
|
|
|
|
|
|
* unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
|
|
|
|
|
|
* user-regs.c (_initialize_user_regs): Add declaration.
|
|
|
|
|
|
* utils.c (_initialize_utils): Add declaration.
|
|
|
|
|
|
* v850-tdep.c (_initialize_v850_tdep): Add declaration.
|
|
|
|
|
|
* valops.c (_initialize_valops): Add declaration.
|
|
|
|
|
|
* valprint.c (_initialize_valprint): Add declaration.
|
|
|
|
|
|
* value.c (_initialize_values): Add declaration.
|
|
|
|
|
|
* varobj.c (_initialize_varobj): Add declaration.
|
|
|
|
|
|
* vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
|
|
|
|
|
|
* vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
|
|
|
|
|
|
* vax-tdep.c (_initialize_vax_tdep): Add declaration.
|
|
|
|
|
|
* windows-nat.c (_initialize_windows_nat): Add declaration.
|
|
|
|
|
|
(_initialize_check_for_gdb_ini): Add declaration.
|
|
|
|
|
|
(_initialize_loadable): Add declaration.
|
|
|
|
|
|
* windows-tdep.c (_initialize_windows_tdep): Add declaration.
|
|
|
|
|
|
* x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
|
|
|
|
|
|
* x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
|
|
|
|
|
|
* xcoffread.c (_initialize_xcoffread): Add declaration.
|
|
|
|
|
|
* xml-support.c (_initialize_xml_support): Add declaration.
|
|
|
|
|
|
* xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
|
|
|
|
|
|
* xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
|
|
|
|
|
|
* xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
|
|
|
|
|
|
* xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
|
|
|
|
|
|
|
gdb: make regformats output a declaration for the init function
When compiling gdbserver for an architecture that uses the regdat.sh
script (such as m68k) and the -Wmissing-declarations compiler flag, I
get:
REGDAT reg-m68k-generated.c
CXX reg-m68k.o
reg-m68k-generated.c:30:1: error: no previous declaration for 'void init_registers_m68k()' [-Werror=missing-declarations]
30 | init_registers_m68k (void)
| ^~~~~~~~~~~~~~~~~~~
The same happens with other architectures, such as s390, but I'll be
using 68k as an example.
The init_registers_m68k function is defined in reg-m68k-generated.c,
which is produced by the regformats/regdat.sh script. This script reads
the regformats/reg-m68k.dat file, containing a register description, and
produces C code that creates a corresponding target description at
runtime.
The init_registers_m68k function is invoked at initialization time in
linux-m68k-low.c. The function must therefore be non-static, but does
not have a declaration at the moment.
The real clean way of fixing this would be to make regdat.sh generate a
.h file (in addition to the .c file) with declarations for whatever is
in the .c file. The generated .c file would include the .h file, and
therefore the definition would have a corresponding declaration. The
linux-m68k-low.c file would also include this .h file, instead of having
its own declaration of init_registers_m68k, like it does now.
However, this would be a quite big change for not much gain. As far as
I understand, some common architectures (i386, x86-64, ARM, AArch64)
have been moved to dynamically building target descriptions based on
features (the linux-*-tdesc.c files in gdbserver) and don't use
regdat.sh anymore. Logically (and given infinite development
resources), the other architectures would be migrated to this system too
and the regdat.sh script would be dropped. A new architecture would
probably not use regdat.sh either. So I therefore propose this simpler
patch instead, which just adds a local declaration in the generated
file.
gdb/ChangeLog:
* regformats/regdat.sh: Generate declaration for init function.
2020-01-13 19:59:18 +01:00
|
|
|
|
2020-01-13 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* regformats/regdat.sh: Generate declaration for init function.
|
|
|
|
|
|
|
gdb: adjust remote-sim.c to multi-target
The remote-sim.c file doesn't build since the main multi-target patch
(5b6d1e4f, "Multi-target support"), this patch is an attempt to fix it.
I have only build-tested it, so I'm not sure it runs fine, but it should
get us close at least.
I made these functions methods of the gdbsim_target, because they need
to pass the target down to some GDB core functions, like
find_inferior_ptid:
- get_sim_inferior_data_by_ptid (renamed to get_inferior_data_by_ptid)
- gdbsim_resume_inferior (renamed to resume_one_inferior)
- gdbsim_close_inferior (renamed to close_one_inferior)
In the last two, I changed iterate_over_inferiors to a range-based for,
since that gives simpler code (no need to pass data through the void
pointer).
The next_pid variable, INITIAL_PID macro and sim_inferior_data structure
are simply moved up in the file, above gdbsim_target.
gdb/ChangeLog:
* remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
up.
(gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
close_one_inferior>: New methods.
(get_sim_inferior_data_by_ptid): Move to gdbsim_target,
pass down target to find_inferior_pid.
(gdbsim_target::fetch_registers, gdbsim_target::store_registers):
Pass down target to find_inferior_ptid.
(gdbsim_target::create_inferior): Pass down target to
add_thread_silent.
(gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
target down to find_inferior_ptid and switch_to_thread.
(gdbsim_target::close): Update to call close_one_inferior.
(struct resume_data): Remove.
(gdbsim_resume_inferior): Move to gdbsim_target. Take arguments
directly, rather than through a void pointer.
(gdbsim_target::resume): Update to call resume_one_inferior.
2020-01-13 16:58:52 +01:00
|
|
|
|
2020-01-13 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
|
|
|
|
|
|
up.
|
|
|
|
|
|
(gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
|
|
|
|
|
|
close_one_inferior>: New methods.
|
|
|
|
|
|
(get_sim_inferior_data_by_ptid): Move to gdbsim_target,
|
|
|
|
|
|
pass down target to find_inferior_pid.
|
|
|
|
|
|
(gdbsim_target::fetch_registers, gdbsim_target::store_registers):
|
|
|
|
|
|
Pass down target to find_inferior_ptid.
|
|
|
|
|
|
(gdbsim_target::create_inferior): Pass down target to
|
|
|
|
|
|
add_thread_silent.
|
|
|
|
|
|
(gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
|
|
|
|
|
|
target down to find_inferior_ptid and switch_to_thread.
|
|
|
|
|
|
(gdbsim_target::close): Update to call close_one_inferior.
|
|
|
|
|
|
(struct resume_data): Remove.
|
|
|
|
|
|
(gdbsim_resume_inferior): Move to gdbsim_target. Take arguments
|
|
|
|
|
|
directly, rather than through a void pointer.
|
|
|
|
|
|
(gdbsim_target::resume): Update to call resume_one_inferior.
|
|
|
|
|
|
|
2020-01-12 21:11:07 +01:00
|
|
|
|
2020-01-12 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbsupport/gdb_wait.c: Include gdb_wait.h.
|
|
|
|
|
|
|
2020-01-12 01:40:02 +01:00
|
|
|
|
2020-01-12 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
|
|
|
|
|
|
directly for the current inferior instead of
|
|
|
|
|
|
discard_all_inferiors.
|
|
|
|
|
|
(discard_all_inferiors): Delete.
|
|
|
|
|
|
|
2020-01-04 22:35:02 +01:00
|
|
|
|
2020-01-11 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-wingeneral.c (box_win): Check cli_styling.
|
|
|
|
|
|
* tui/tui-winsource.c (tui_source_window_base::refill): Use
|
|
|
|
|
|
deprecated_safe_get_selected_frame.
|
|
|
|
|
|
|
Switch the inferior before outputting its id in "info inferiors"
GDB uses the 'current_top_target' when displaying the description of
an inferior. This leads to same target being used for each inferior
and, in turn, yields incorrect output when the inferior has a target
that is supposed to give a specialized output. For instance, the
remote target outputs "Remote target" instead of "process XYZ" as the
description if the multi-process feature is not supported or turned
off.
E.g.: Suppose we have a native and a remote target, and the native is
the current inferior. The remote target does not support multi-process.
For "info inferiors", we would expect to see:
~~~
(gdb) i inferiors
Num Description Connection Executable
* 1 process 29060 1 (native) /a/path
2 Remote target 2 (remote ...)
~~~
but instead we get
~~~
(gdb) i inferiors
Num Description Connection Executable
* 1 process 29060 1 (native) /a/path
2 process 42000 2 (remote ...)
~~~
Similarly, if the current inferior is the remote one, we would expect
to see
~~~
(gdb) i inferiors
Num Description Connection Executable
1 process 29060 1 (native) /a/path
* 2 Remote target 2 (remote ...)
~~~
but we get
~~~
(gdb) i inferiors
Num Description Connection Executable
* 1 Remote target 1 (native) /a/path
2 Remote target 2 (remote ...)
~~~
With this patch, we switch to the inferior when outputting its
description, so that the current_top_target will be aligned to the
inferior we are displaying.
For testing, this patch expands the "info inferiors" test for the
multi-target feature. The test was checking for the output of the
info commands after setup, only when the current inferior is the last
added inferior.
This patch does the following to the testcase:
1. The "info inferiors" and "info connections" test is extracted out
from the "setup" procedure to a separate procedure.
2. The test is enriched to check the output after switching to each
inferior, not just the last one.
3. The test is performed twice; one for when the multi-process feature
is turned on, one for off.
gdb/ChangeLog:
2020-01-10 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* inferior.c (print_inferior): Switch inferior before printing it.
gdb/testsuite/ChangeLog:
2020-01-10 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* gdb.multi/multi-target.exp (setup): Factor out "info
connections" and "info inferiors" tests to ...
(test_info_inferiors): ... this new procedure.
(top level): Run new "info-inferiors" tests.
2020-01-10 21:06:17 +01:00
|
|
|
|
2020-01-10 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
* inferior.c (print_inferior): Switch inferior before printing it.
|
|
|
|
|
|
|
Switch the inferior too in switch_to_program_space_and_thread
With multi-target, each inferior now has its own target connection.
The problem in switch_to_program_space_and_thread is that in the
current state GDB switches to "no thread" and also sets the program
space but because the inferior is not switched, potentially an
incorrect target remains selected.
Here is a sample scenario that exploits this flow:
On terminal 1, start a gdbserver on a program named foo:
$ gdbserver :1234 ./foo
On terminal 2, start gdb on a program named bar. Suppose foo and bar
are compiled from foo.c and bar.c. They are completely separate. So,
bar.c:2 has no meaning for foo.
$ gdb -q ./bar
Reading symbols from ./bar...
(gdb) add-inferior
[New inferior 2]
Added inferior 2
(gdb) inferior 2
[Switching to inferior 2 [<null>] (<noexec>)]
(gdb) target remote :1234
...
(gdb) set debug remote 2
(gdb) break bar.c:2
Sending packet: $Hgp0.0#ad...Packet received: OK
Sending packet: $m5fa,12#f8...Packet received: E01
Sending packet: $m5fa,1#c6...Packet received: E01
Sending packet: $m5fb,3#c9...Packet received: E01
Sending packet: $m5fe,1#ca...Packet received: E01
Breakpoint 1 at 0x5fe: file bar.c, line 2.
(gdb)
Here we have an unnecessary sending of the packets to the gdbserver.
With this fix in progspace-and-thread.c, we'll get this:
(gdb) break bar.c:2
Breakpoint 1 at 0x5fe: file bar.c, line 2.
(gdb)
Now there is no sending of the packets to gdbserver.
The changes around clear_symtab_users calls are necessary because
otherwise we regress gdb.base/step-over-exit.exp, hitting the new
assertion in switch_to_program_space_and_thread. The problem is, a
forked child terminates, and when GDB decides to auto-purge that
inferior, GDB tries to switch to the pspace of that no-longer-existing
inferior.
The root of the problem is within the program_space destructor:
program_space::~program_space ()
{
...
set_current_program_space (this); # (1)
...
breakpoint_program_space_exit (this); # (2)
...
free_all_objfiles (); # (3)
...
}
We get here from delete_inferior -> delete_program_space.
So we're deleting an inferior, and the inferior to be
deleted is no longer in the inferior list.
At (2), we've deleted all the breakpoints and locations for the
program space being deleted.
The crash happens while doing a breakpoint re-set, called by
clear_symtab_users at the tail end of (3). That is, while recreating
breakpoints for the current program space, which is the program space
we're tearing down. During breakpoint re-set, we try to switch to the
new location's pspace (the current pspace set in (1), so the pspace
we're tearing down) with switch_to_program_space_and_thread, and that
hits the failed assertion. It's the fact that we recreate breakpoints
in the program_space destructor that is the latent bug here. Just
don't do that, and we don't end up in the crash situation.
My first approach to fix this added a symfile_add_flags parameter to
program_space::free_all_objfiles, and then passed that down to
clear_symtab_users. The program_space dtor would then pass down
SYMFILE_DEFER_BP_RESET to free_all_objfiles. I couldn't help feeling
that adding that parameter to free_all_objfiles looked a little
awkward, so I settled on something a little different -- hoist the
clear_symtab_users call to the callers. There are only two callers.
I felt that that didn't look as odd, particularly since
remove_symbol_file_command also does:
objf->unlink ();
clear_symtab_users (0);
I.e., objfile deletion is already separate from calling
clear_symtab_users in some places.
gdb/ChangeLog:
2020-01-10 Aleksandar Paunovic <aleksandar.paunovic@intel.com>
Pedro Alves <palves@redhat.com>
* progspace-and-thread.c (switch_to_program_space_and_thread):
Assert there's an inferior for PSPACE. Use
switch_to_inferior_no_thread to switch the inferior too.
* progspace.c (program_space::~program_space): Call
clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
(program_space::free_all_objfiles): Don't call clear_symtab_users
here.
* symfile.c (symbol_file_clear): Call clear_symtab_users here.
gdb/testsuite/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* gdb.server/bkpt-other-inferior.exp: New file.
2020-01-10 21:06:16 +01:00
|
|
|
|
2020-01-10 Aleksandar Paunovic <aleksandar.paunovic@intel.com>
|
|
|
|
|
|
Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* progspace-and-thread.c (switch_to_program_space_and_thread):
|
|
|
|
|
|
Assert there's an inferior for PSPACE. Use
|
|
|
|
|
|
switch_to_inferior_no_thread to switch the inferior too.
|
|
|
|
|
|
* progspace.c (program_space::~program_space): Call
|
|
|
|
|
|
clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
|
|
|
|
|
|
(program_space::free_all_objfiles): Don't call clear_symtab_users
|
|
|
|
|
|
here.
|
|
|
|
|
|
* symfile.c (symbol_file_clear): Call clear_symtab_users here.
|
|
|
|
|
|
|
2020-01-10 21:06:15 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Mention multi-target debugging, "info connections", and
|
|
|
|
|
|
"add-inferior -no-connection".
|
|
|
|
|
|
|
2020-01-10 21:06:14 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infrun.c: Include "target-connection.h".
|
|
|
|
|
|
(check_multi_target_resumption): New.
|
|
|
|
|
|
(proceed): Call it.
|
|
|
|
|
|
* target-connection.c (make_target_connection_string): Make
|
|
|
|
|
|
extern.
|
|
|
|
|
|
* target-connection.h (make_target_connection_string): Declare.
|
|
|
|
|
|
|
2020-01-10 21:06:14 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add target-connection.c.
|
|
|
|
|
|
* inferior.c (uiout_field_connection): New function.
|
|
|
|
|
|
(print_inferior): Add new "connection-id" column.
|
|
|
|
|
|
(add_inferior_command): Show connection number/string of added
|
|
|
|
|
|
inferior.
|
|
|
|
|
|
* process-stratum-target.h
|
|
|
|
|
|
(process_stratum_target::connection_string): New virtual method.
|
|
|
|
|
|
(process_stratum_target::connection_number): New field.
|
|
|
|
|
|
* remote.c (remote_target::connection_string): New override.
|
|
|
|
|
|
* target-connection.c: New file.
|
|
|
|
|
|
* target-connection.h: New file.
|
|
|
|
|
|
* target.c (decref_target): Remove process_stratum targets from
|
|
|
|
|
|
the connection list.
|
|
|
|
|
|
(target_stack::push): Add process_stratum targets to the
|
|
|
|
|
|
connection list.
|
|
|
|
|
|
|
2020-01-10 21:06:11 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
Revert:
|
|
|
|
|
|
2016-04-12 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
* serial.c (serial_open, serial_fdopen_ops, do_serial_close):
|
|
|
|
|
|
Remove references to name.
|
|
|
|
|
|
* serial.h (struct serial) <name>: Delete.
|
|
|
|
|
|
|
2020-01-10 21:06:10 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbarch-selftests.c (register_to_value_test): Remove "target
|
|
|
|
|
|
already pushed" check.
|
|
|
|
|
|
|
Multi-target support
This commit adds multi-target support to GDB. What this means is that
with this commit, GDB can now be connected to different targets at the
same time. E.g., you can debug a live native process and a core dump
at the same time, connect to multiple gdbservers, etc.
Actually, the word "target" is overloaded in gdb. We already have a
target stack, with pushes several target_ops instances on top of one
another. We also have "info target" already, which means something
completely different to what this patch does.
So from here on, I'll be using the "target connections" term, to mean
an open process_stratum target, pushed on a target stack. This patch
makes gdb have multiple target stacks, and multiple process_stratum
targets open simultaneously. The user-visible changes / commands will
also use this terminology, but of course it's all open to debate.
User-interface-wise, not that much changes. The main difference is
that each inferior may have its own target connection.
A target connection (e.g., a target extended-remote connection) may
support debugging multiple processes, just as before.
Say you're debugging against gdbserver in extended-remote mode, and
you do "add-inferior" to prepare to spawn a new process, like:
(gdb) target extended-remote :9999
...
(gdb) start
...
(gdb) add-inferior
Added inferior 2
(gdb) inferior 2
[Switching to inferior 2 [<null>] (<noexec>)]
(gdb) file a.out
...
(gdb) start
...
At this point, you have two inferiors connected to the same gdbserver.
With this commit, GDB will maintain a target stack per inferior,
instead of a global target stack.
To preserve the behavior above, by default, "add-inferior" makes the
new inferior inherit a copy of the target stack of the current
inferior. Same across a fork - the child inherits a copy of the
target stack of the parent. While the target stacks are copied, the
targets themselves are not. Instead, target_ops is made a
refcounted_object, which means that target_ops instances are
refcounted, which each inferior counting for a reference.
What if you want to create an inferior and connect it to some _other_
target? For that, this commit introduces a new "add-inferior
-no-connection" option that makes the new inferior not share the
current inferior's target. So you could do:
(gdb) target extended-remote :9999
Remote debugging using :9999
...
(gdb) add-inferior -no-connection
[New inferior 2]
Added inferior 2
(gdb) inferior 2
[Switching to inferior 2 [<null>] (<noexec>)]
(gdb) info inferiors
Num Description Executable
1 process 18401 target:/home/pedro/tmp/main
* 2 <null>
(gdb) tar extended-remote :10000
Remote debugging using :10000
...
(gdb) info inferiors
Num Description Executable
1 process 18401 target:/home/pedro/tmp/main
* 2 process 18450 target:/home/pedro/tmp/main
(gdb)
A following patch will extended "info inferiors" to include a column
indicating which connection an inferior is bound to, along with a
couple other UI tweaks.
Other than that, debugging is the same as before. Users interact with
inferiors and threads as before. The only difference is that
inferiors may be bound to processes running in different machines.
That's pretty much all there is to it in terms of noticeable UI
changes.
On to implementation.
Since we can be connected to different systems at the same time, a
ptid_t is no longer a unique identifier. Instead a thread can be
identified by a pair of ptid_t and 'process_stratum_target *', the
later being the instance of the process_stratum target that owns the
process/thread. Note that process_stratum_target inherits from
target_ops, and all process_stratum targets inherit from
process_stratum_target. In earlier patches, many places in gdb were
converted to refer to threads by thread_info pointer instead of
ptid_t, but there are still places in gdb where we start with a
pid/tid and need to find the corresponding inferior or thread_info
objects. So you'll see in the patch many places adding a
process_stratum_target parameter to functions that used to take only a
ptid_t.
Since each inferior has its own target stack now, we can always find
the process_stratum target for an inferior. That is done via a
inf->process_target() convenience method.
Since each inferior has its own target stack, we need to handle the
"beneath" calls when servicing target calls. The solution I settled
with is just to make sure to switch the current inferior to the
inferior you want before making a target call. Not relying on global
context is just not feasible in current GDB. Fortunately, there
aren't that many places that need to do that, because generally most
code that calls target methods already has the current context
pointing to the right inferior/thread. Note, to emphasize -- there's
no method to "switch to this target stack". Instead, you switch the
current inferior, and that implicitly switches the target stack.
In some spots, we need to iterate over all inferiors so that we reach
all target stacks.
Native targets are still singletons. There's always only a single
instance of such targets.
Remote targets however, we'll have one instance per remote connection.
The exec target is still a singleton. There's only one instance. I
did not see the point of instanciating more than one exec_target
object.
After vfork, we need to make sure to push the exec target on the new
inferior. See exec_on_vfork.
For type safety, functions that need a {target, ptid} pair to identify
a thread, take a process_stratum_target pointer for target parameter
instead of target_ops *. Some shared code in gdb/nat/ also need to
gain a target pointer parameter. This poses an issue, since gdbserver
doesn't have process_stratum_target, only target_ops. To fix this,
this commit renames gdbserver's target_ops to process_stratum_target.
I think this makes sense. There's no concept of target stack in
gdbserver, and gdbserver's target_ops really implements a
process_stratum-like target.
The thread and inferior iterator functions also gain
process_stratum_target parameters. These are used to be able to
iterate over threads and inferiors of a given target. Following usual
conventions, if the target pointer is null, then we iterate over
threads and inferiors of all targets.
I tried converting "add-inferior" to the gdb::option framework, as a
preparatory patch, but that stumbled on the fact that gdb::option does
not support file options yet, for "add-inferior -exec". I have a WIP
patchset that adds that, but it's not a trivial patch, mainly due to
need to integrate readline's filename completion, so I deferred that
to some other time.
In infrun.c/infcmd.c, the main change is that we need to poll events
out of all targets. See do_target_wait. Right after collecting an
event, we switch the current inferior to an inferior bound to the
target that reported the event, so that target methods can be used
while handling the event. This makes most of the code transparent to
multi-targets. See fetch_inferior_event.
infrun.c:stop_all_threads is interesting -- in this function we need
to stop all threads of all targets. What the function does is send an
asynchronous stop request to all threads, and then synchronously waits
for events, with target_wait, rinse repeat, until all it finds are
stopped threads. Now that we have multiple targets, it's not
efficient to synchronously block in target_wait waiting for events out
of one target. Instead, we implement a mini event loop, with
interruptible_select, select'ing on one file descriptor per target.
For this to work, we need to be able to ask the target for a waitable
file descriptor. Such file descriptors already exist, they are the
descriptors registered in the main event loop with add_file_handler,
inside the target_async implementations. This commit adds a new
target_async_wait_fd target method that just returns the file
descriptor in question. See wait_one / stop_all_threads in infrun.c.
The 'threads_executing' global is made a per-target variable. Since
it is only relevant to process_stratum_target targets, this is where
it is put, instead of in target_ops.
You'll notice that remote.c includes some FIXME notes. These refer to
the fact that the global arrays that hold data for the remote packets
supported are still globals. For example, if we connect to two
different servers/stubs, then each might support different remote
protocol features. They might even be different architectures, like
e.g., one ARM baremetal stub, and a x86 gdbserver, to debug a
host/controller scenario as a single program. That isn't going to
work correctly today, because of said globals. I'm leaving fixing
that for another pass, since it does not appear to be trivial, and I'd
rather land the base work first. It's already useful to be able to
debug multiple instances of the same server (e.g., a distributed
cluster, where you have full control over the servers installed), so I
think as is it's already reasonable incremental progress.
Current limitations:
- You can only resume more that one target at the same time if all
targets support asynchronous debugging, and support non-stop mode.
It should be possible to support mixed all-stop + non-stop
backends, but that is left for another time. This means that
currently in order to do multi-target with gdbserver you need to
issue "maint set target-non-stop on". I would like to make that
mode be the default, but we're not there yet. Note that I'm
talking about how the target backend works, only. User-visible
all-stop mode works just fine.
- As explained above, connecting to different remote servers at the
same time is likely to produce bad results if they don't support the
exact set of RSP features.
FreeBSD updates courtesy of John Baldwin.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
John Baldwin <jhb@FreeBSD.org>
* aarch64-linux-nat.c
(aarch64_linux_nat_target::thread_architecture): Adjust.
* ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
(task_command_1): Likewise.
* aix-thread.c (sync_threadlists, aix_thread_target::resume)
(aix_thread_target::wait, aix_thread_target::fetch_registers)
(aix_thread_target::store_registers)
(aix_thread_target::thread_alive): Adjust.
* amd64-fbsd-tdep.c: Include "inferior.h".
(amd64fbsd_get_thread_local_address): Pass down target.
* amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
thread's gdbarch instead of target_gdbarch.
* break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
get_last_target_status.
* break-catch-syscall.c (print_it_catch_syscall): Likewise.
* breakpoint.c (breakpoints_should_be_inserted_now): Consider all
inferiors.
(update_inserted_breakpoint_locations): Skip if inferiors with no
execution.
(update_global_location_list): When handling moribund locations,
find representative inferior for location's pspace, and use thread
count of its process_stratum target.
* bsd-kvm.c (bsd_kvm_target_open): Pass target down.
* bsd-uthread.c (bsd_uthread_target::wait): Use
as_process_stratum_target and adjust thread_change_ptid and
add_thread calls.
(bsd_uthread_target::update_thread_list): Use
as_process_stratum_target and adjust find_thread_ptid,
thread_change_ptid and add_thread calls.
* btrace.c (maint_btrace_packet_history_cmd): Adjust
find_thread_ptid call.
* corelow.c (add_to_thread_list): Adjust add_thread call.
(core_target_open): Adjust add_thread_silent and thread_count
calls.
(core_target::pid_to_str): Adjust find_inferior_ptid call.
* ctf.c (ctf_target_open): Adjust add_thread_silent call.
* event-top.c (async_disconnect): Pop targets from all inferiors.
* exec.c (add_target_sections): Push exec target on all inferiors
sharing the program space.
(remove_target_sections): Remove the exec target from all
inferiors sharing the program space.
(exec_on_vfork): New.
* exec.h (exec_on_vfork): Declare.
* fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
Pass it down.
(fbsd_nat_target::update_thread_list): Adjust.
(fbsd_nat_target::resume): Adjust.
(fbsd_handle_debug_trap): Add fbsd_nat_target parameter. Pass it
down.
(fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
* fbsd-tdep.c (fbsd_corefile_thread): Adjust
get_thread_arch_regcache call.
* fork-child.c (gdb_startup_inferior): Pass target down to
startup_inferior and set_executing.
* gdbthread.h (struct process_stratum_target): Forward declare.
(add_thread, add_thread_silent, add_thread_with_info)
(in_thread_list): Add process_stratum_target parameter.
(find_thread_ptid(inferior*, ptid_t)): New overload.
(find_thread_ptid, thread_change_ptid): Add process_stratum_target
parameter.
(all_threads()): Delete overload.
(all_threads, all_non_exited_threads): Add process_stratum_target
parameter.
(all_threads_safe): Use brace initialization.
(thread_count): Add process_stratum_target parameter.
(set_resumed, set_running, set_stop_requested, set_executing)
(threads_are_executing, finish_thread_state): Add
process_stratum_target parameter.
(switch_to_thread): Use is_current_thread.
* i386-fbsd-tdep.c: Include "inferior.h".
(i386fbsd_get_thread_local_address): Pass down target.
* i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
* inf-child.c (inf_child_target::maybe_unpush_target): Remove
have_inferiors check.
* inf-ptrace.c (inf_ptrace_target::create_inferior)
(inf_ptrace_target::attach): Adjust.
* infcall.c (run_inferior_call): Adjust.
* infcmd.c (run_command_1): Pass target to
scoped_finish_thread_state.
(proceed_thread_callback): Skip inferiors with no execution.
(continue_command): Rename 'all_threads' local to avoid hiding
'all_threads' function. Adjust get_last_target_status call.
(prepare_one_step): Adjust set_running call.
(signal_command): Use user_visible_resume_target. Compare thread
pointers instead of inferior_ptid.
(info_program_command): Adjust to pass down target.
(attach_command): Mark target's 'thread_executing' flag.
(stop_current_target_threads_ns): New, factored out from ...
(interrupt_target_1): ... this. Switch inferior before making
target calls.
* inferior-iter.h
(struct all_inferiors_iterator, struct all_inferiors_range)
(struct all_inferiors_safe_range)
(struct all_non_exited_inferiors_range): Filter on
process_stratum_target too. Remove explicit.
* inferior.c (inferior::inferior): Push dummy target on target
stack.
(find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
Add process_stratum_target parameter, and pass it down.
(have_live_inferiors): Adjust.
(switch_to_inferior_and_push_target): New.
(add_inferior_command, clone_inferior_command): Handle
"-no-connection" parameter. Use
switch_to_inferior_and_push_target.
(_initialize_inferior): Mention "-no-connection" option in
the help of "add-inferior" and "clone-inferior" commands.
* inferior.h: Include "process-stratum-target.h".
(interrupt_target_1): Use bool.
(struct inferior) <push_target, unpush_target, target_is_pushed,
find_target_beneath, top_target, process_target, target_at,
m_stack>: New.
(discard_all_inferiors): Delete.
(find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
(all_inferiors, all_non_exited_inferiors): Add
process_stratum_target parameter.
* infrun.c: Include "gdb_select.h" and <unordered_map>.
(target_last_proc_target): New global.
(follow_fork_inferior): Push target on new inferior. Pass target
to add_thread_silent. Call exec_on_vfork. Handle target's
reference count.
(follow_fork): Adjust get_last_target_status call. Also consider
target.
(follow_exec): Push target on new inferior.
(struct execution_control_state) <target>: New field.
(user_visible_resume_target): New.
(do_target_resume): Call target_async.
(resume_1): Set target's threads_executing flag. Consider resume
target.
(commit_resume_all_targets): New.
(proceed): Also consider resume target. Skip threads of inferiors
with no execution. Commit resumtion in all targets.
(start_remote): Pass current inferior to wait_for_inferior.
(infrun_thread_stop_requested): Consider target as well. Pass
thread_info pointer to clear_inline_frame_state instead of ptid.
(infrun_thread_thread_exit): Consider target as well.
(random_pending_event_thread): New inferior parameter. Use it.
(do_target_wait): Rename to ...
(do_target_wait_1): ... this. Add inferior parameter, and pass it
down.
(threads_are_resumed_pending_p, do_target_wait): New.
(prepare_for_detach): Adjust calls.
(wait_for_inferior): New inferior parameter. Handle it. Use
do_target_wait_1 instead of do_target_wait.
(fetch_inferior_event): Adjust. Switch to representative
inferior. Pass target down.
(set_last_target_status): Add process_stratum_target parameter.
Save target in global.
(get_last_target_status): Add process_stratum_target parameter and
handle it.
(nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
(context_switch): Check inferior_ptid == null_ptid before calling
inferior_thread().
(get_inferior_stop_soon): Pass down target.
(wait_one): Rename to ...
(poll_one_curr_target): ... this.
(struct wait_one_event): New.
(wait_one): New.
(stop_all_threads): Adjust.
(handle_no_resumed, handle_inferior_event): Adjust to consider the
event's target.
(switch_back_to_stepped_thread): Also consider target.
(print_stop_event): Update.
(normal_stop): Update. Also consider the resume target.
* infrun.h (wait_for_inferior): Remove declaration.
(user_visible_resume_target): New declaration.
(get_last_target_status, set_last_target_status): New
process_stratum_target parameter.
* inline-frame.c (clear_inline_frame_state(ptid_t)): Add
process_stratum_target parameter, and use it.
(clear_inline_frame_state (thread_info*)): New.
* inline-frame.c (clear_inline_frame_state(ptid_t)): Add
process_stratum_target parameter.
(clear_inline_frame_state (thread_info*)): Declare.
* linux-fork.c (delete_checkpoint_command): Pass target down to
find_thread_ptid.
(checkpoint_command): Adjust.
* linux-nat.c (linux_nat_target::follow_fork): Switch to thread
instead of just tweaking inferior_ptid.
(linux_nat_switch_fork): Pass target down to thread_change_ptid.
(exit_lwp): Pass target down to find_thread_ptid.
(attach_proc_task_lwp_callback): Pass target down to
add_thread/set_running/set_executing.
(linux_nat_target::attach): Pass target down to
thread_change_ptid.
(get_detach_signal): Pass target down to find_thread_ptid.
Consider last target status's target.
(linux_resume_one_lwp_throw, resume_lwp)
(linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
(stop_wait_callback, save_stop_reason, linux_nat_filter_event)
(linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
(linux_nat_target::async_wait_fd): New.
(linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
target down.
* linux-nat.h (linux_nat_target::async_wait_fd): Declare.
* linux-tdep.c (get_thread_arch_regcache): Pass target down.
* linux-thread-db.c (struct thread_db_info::process_target): New
field.
(add_thread_db_info): Save target.
(get_thread_db_info): New process_stratum_target parameter. Also
match target.
(delete_thread_db_info): New process_stratum_target parameter.
Also match target.
(thread_from_lwp): Adjust to pass down target.
(thread_db_notice_clone): Pass down target.
(check_thread_db_callback): Pass down target.
(try_thread_db_load_1): Always push the thread_db target.
(try_thread_db_load, record_thread): Pass target down.
(thread_db_target::detach): Pass target down. Always unpush the
thread_db target.
(thread_db_target::wait, thread_db_target::mourn_inferior): Pass
target down. Always unpush the thread_db target.
(find_new_threads_callback, thread_db_find_new_threads_2)
(thread_db_target::update_thread_list): Pass target down.
(thread_db_target::pid_to_str): Pass current inferior down.
(thread_db_target::get_thread_local_address): Pass target down.
(thread_db_target::resume, maintenance_check_libthread_db): Pass
target down.
* nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
* procfs.c (procfs_target::procfs_init_inferior): Declare.
(proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
(procfs_init_inferior): Rename to ...
(procfs_target::procfs_init_inferior): ... this and adjust.
(procfs_target::create_inferior, procfs_notice_thread)
(procfs_do_thread_registers): Adjust.
* ppc-fbsd-tdep.c: Include "inferior.h".
(ppcfbsd_get_thread_local_address): Pass down target.
* proc-service.c (ps_xfer_memory): Switch current inferior and
program space as well.
(get_ps_regcache): Pass target down.
* process-stratum-target.c
(process_stratum_target::thread_address_space)
(process_stratum_target::thread_architecture): Pass target down.
* process-stratum-target.h
(process_stratum_target::threads_executing): New field.
(as_process_stratum_target): New.
* ravenscar-thread.c
(ravenscar_thread_target::update_inferior_ptid): Pass target down.
(ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
down.
* record-btrace.c (record_btrace_target::info_record): Adjust.
(record_btrace_target::record_method)
(record_btrace_target::record_is_replaying)
(record_btrace_target::fetch_registers)
(get_thread_current_frame_id, record_btrace_target::resume)
(record_btrace_target::wait, record_btrace_target::stop): Pass
target down.
* record-full.c (record_full_wait_1): Switch to event thread.
Pass target down.
* regcache.c (regcache::regcache)
(get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
process_stratum_target parameter and handle it.
(current_thread_target): New global.
(get_thread_regcache): Add process_stratum_target parameter and
handle it. Switch inferior before calling target method.
(get_thread_regcache): Pass target down.
(get_thread_regcache_for_ptid): Pass target down.
(registers_changed_ptid): Add process_stratum_target parameter and
handle it.
(registers_changed_thread, registers_changed): Pass target down.
(test_get_thread_arch_aspace_regcache): New.
(current_regcache_test): Define a couple local test_target_ops
instances and use them for testing.
(readwrite_regcache): Pass process_stratum_target parameter.
(cooked_read_test, cooked_write_test): Pass mock_target down.
* regcache.h (get_thread_regcache, get_thread_arch_regcache)
(get_thread_arch_aspace_regcache): Add process_stratum_target
parameter.
(regcache::target): New method.
(regcache::regcache, regcache::get_thread_arch_aspace_regcache)
(regcache::registers_changed_ptid): Add process_stratum_target
parameter.
(regcache::m_target): New field.
(registers_changed_ptid): Add process_stratum_target parameter.
* remote.c (remote_state::supports_vCont_probed): New field.
(remote_target::async_wait_fd): New method.
(remote_unpush_and_throw): Add remote_target parameter.
(get_current_remote_target): Adjust.
(remote_target::remote_add_inferior): Push target.
(remote_target::remote_add_thread)
(remote_target::remote_notice_new_inferior)
(get_remote_thread_info): Pass target down.
(remote_target::update_thread_list): Skip threads of inferiors
bound to other targets. (remote_target::close): Don't discard
inferiors. (remote_target::add_current_inferior_and_thread)
(remote_target::process_initial_stop_replies)
(remote_target::start_remote)
(remote_target::remote_serial_quit_handler): Pass down target.
(remote_target::remote_unpush_target): New remote_target
parameter. Unpush the target from all inferiors.
(remote_target::remote_unpush_and_throw): New remote_target
parameter. Pass it down.
(remote_target::open_1): Check whether the current inferior has
execution instead of checking whether any inferior is live. Pass
target down.
(remote_target::remote_detach_1): Pass down target. Use
remote_unpush_target.
(extended_remote_target::attach): Pass down target.
(remote_target::remote_vcont_probe): Set supports_vCont_probed.
(remote_target::append_resumption): Pass down target.
(remote_target::append_pending_thread_resumptions)
(remote_target::remote_resume_with_hc, remote_target::resume)
(remote_target::commit_resume): Pass down target.
(remote_target::remote_stop_ns): Check supports_vCont_probed.
(remote_target::interrupt_query)
(remote_target::remove_new_fork_children)
(remote_target::check_pending_events_prevent_wildcard_vcont)
(remote_target::remote_parse_stop_reply)
(remote_target::process_stop_reply): Pass down target.
(first_remote_resumed_thread): New remote_target parameter. Pass
it down.
(remote_target::wait_as): Pass down target.
(unpush_and_perror): New remote_target parameter. Pass it down.
(remote_target::readchar, remote_target::remote_serial_write)
(remote_target::getpkt_or_notif_sane_1)
(remote_target::kill_new_fork_children, remote_target::kill): Pass
down target.
(remote_target::mourn_inferior): Pass down target. Use
remote_unpush_target.
(remote_target::core_of_thread)
(remote_target::remote_btrace_maybe_reopen): Pass down target.
(remote_target::pid_to_exec_file)
(remote_target::thread_handle_to_thread_info): Pass down target.
(remote_target::async_wait_fd): New.
* riscv-fbsd-tdep.c: Include "inferior.h".
(riscv_fbsd_get_thread_local_address): Pass down target.
* sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
* sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
(ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
Adjust.
* solib-spu.c (spu_skip_standalone_loader): Pass down target.
* solib-svr4.c (enable_break): Pass down target.
* spu-multiarch.c (parse_spufs_run): Pass down target.
* spu-tdep.c (spu2ppu_sniffer): Pass down target.
* target-delegates.c: Regenerate.
* target.c (g_target_stack): Delete.
(current_top_target): Return the current inferior's top target.
(target_has_execution_1): Refer to the passed-in inferior's top
target.
(target_supports_terminal_ours): Check whether the initial
inferior was already created.
(decref_target): New.
(target_stack::push): Incref/decref the target.
(push_target, push_target, unpush_target): Adjust.
(target_stack::unpush): Defref target.
(target_is_pushed): Return bool. Adjust to refer to the current
inferior's target stack.
(dispose_inferior): Delete, and inline parts ...
(target_preopen): ... here. Only dispose of the current inferior.
(target_detach): Hold strong target reference while detaching.
Pass target down.
(target_thread_name): Add assertion.
(target_resume): Pass down target.
(target_ops::beneath, find_target_at): Adjust to refer to the
current inferior's target stack.
(get_dummy_target): New.
(target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
has a thread running.
(initialize_targets): Rename to ...
(_initialize_target): ... this.
* target.h: Include "gdbsupport/refcounted-object.h".
(struct target_ops): Inherit refcounted_object.
(target_ops::shortname, target_ops::longname): Make const.
(target_ops::async_wait_fd): New method.
(decref_target): Declare.
(struct target_ops_ref_policy): New.
(target_ops_ref): New typedef.
(get_dummy_target): Declare function.
(target_is_pushed): Return bool.
* thread-iter.c (all_matching_threads_iterator::m_inf_matches)
(all_matching_threads_iterator::all_matching_threads_iterator):
Handle filter target.
* thread-iter.h (struct all_matching_threads_iterator, struct
all_matching_threads_range, class all_non_exited_threads_range):
Filter by target too. Remove explicit.
* thread.c (threads_executing): Delete.
(inferior_thread): Pass down current inferior.
(clear_thread_inferior_resources): Pass down thread pointer
instead of ptid_t.
(add_thread_silent, add_thread_with_info, add_thread): Add
process_stratum_target parameter. Use it for thread and inferior
searches.
(is_current_thread): New.
(thread_info::deletable): Use it.
(find_thread_ptid, thread_count, in_thread_list)
(thread_change_ptid, set_resumed, set_running): New
process_stratum_target parameter. Pass it down.
(set_executing): New process_stratum_target parameter. Pass it
down. Adjust reference to 'threads_executing'.
(threads_are_executing): New process_stratum_target parameter.
Adjust reference to 'threads_executing'.
(set_stop_requested, finish_thread_state): New
process_stratum_target parameter. Pass it down.
(switch_to_thread): Also match inferior.
(switch_to_thread): New process_stratum_target parameter. Pass it
down.
(update_threads_executing): Reimplement.
* top.c (quit_force): Pop targets from all inferior.
(gdb_init): Don't call initialize_targets.
* windows-nat.c (windows_nat_target) <get_windows_debug_event>:
Declare.
(windows_add_thread, windows_delete_thread): Adjust.
(get_windows_debug_event): Rename to ...
(windows_nat_target::get_windows_debug_event): ... this. Adjust.
* tracefile-tfile.c (tfile_target_open): Pass down target.
* gdbsupport/common-gdbthread.h (struct process_stratum_target):
Forward declare.
(switch_to_thread): Add process_stratum_target parameter.
* mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
parameter. Use it.
(mi_on_resume): Pass target down.
* nat/fork-inferior.c (startup_inferior): Add
process_stratum_target parameter. Pass it down.
* nat/fork-inferior.h (startup_inferior): Add
process_stratum_target parameter.
* python/py-threadevent.c (py_get_event_thread): Pass target down.
gdb/gdbserver/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* fork-child.c (post_fork_inferior): Pass target down to
startup_inferior.
* inferiors.c (switch_to_thread): Add process_stratum_target
parameter.
* lynx-low.c (lynx_target_ops): Now a process_stratum_target.
* nto-low.c (nto_target_ops): Now a process_stratum_target.
* linux-low.c (linux_target_ops): Now a process_stratum_target.
* remote-utils.c (prepare_resume_reply): Pass the target to
switch_to_thread.
* target.c (the_target): Now a process_stratum_target.
(done_accessing_memory): Pass the target to switch_to_thread.
(set_target_ops): Ajust to use process_stratum_target.
* target.h (struct target_ops): Rename to ...
(struct process_stratum_target): ... this.
(the_target, set_target_ops): Adjust.
(prepare_to_access_memory): Adjust comment.
* win32-low.c (child_xfer_memory): Adjust to use
process_stratum_target.
(win32_target_ops): Now a process_stratum_target.
2020-01-10 21:06:08 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
John Baldwin <jhb@FreeBSD.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-linux-nat.c
|
|
|
|
|
|
(aarch64_linux_nat_target::thread_architecture): Adjust.
|
|
|
|
|
|
* ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
|
|
|
|
|
|
(task_command_1): Likewise.
|
|
|
|
|
|
* aix-thread.c (sync_threadlists, aix_thread_target::resume)
|
|
|
|
|
|
(aix_thread_target::wait, aix_thread_target::fetch_registers)
|
|
|
|
|
|
(aix_thread_target::store_registers)
|
|
|
|
|
|
(aix_thread_target::thread_alive): Adjust.
|
|
|
|
|
|
* amd64-fbsd-tdep.c: Include "inferior.h".
|
|
|
|
|
|
(amd64fbsd_get_thread_local_address): Pass down target.
|
|
|
|
|
|
* amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
|
|
|
|
|
|
thread's gdbarch instead of target_gdbarch.
|
|
|
|
|
|
* break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
|
|
|
|
|
|
get_last_target_status.
|
|
|
|
|
|
* break-catch-syscall.c (print_it_catch_syscall): Likewise.
|
|
|
|
|
|
* breakpoint.c (breakpoints_should_be_inserted_now): Consider all
|
|
|
|
|
|
inferiors.
|
|
|
|
|
|
(update_inserted_breakpoint_locations): Skip if inferiors with no
|
|
|
|
|
|
execution.
|
|
|
|
|
|
(update_global_location_list): When handling moribund locations,
|
|
|
|
|
|
find representative inferior for location's pspace, and use thread
|
|
|
|
|
|
count of its process_stratum target.
|
|
|
|
|
|
* bsd-kvm.c (bsd_kvm_target_open): Pass target down.
|
|
|
|
|
|
* bsd-uthread.c (bsd_uthread_target::wait): Use
|
|
|
|
|
|
as_process_stratum_target and adjust thread_change_ptid and
|
|
|
|
|
|
add_thread calls.
|
|
|
|
|
|
(bsd_uthread_target::update_thread_list): Use
|
|
|
|
|
|
as_process_stratum_target and adjust find_thread_ptid,
|
|
|
|
|
|
thread_change_ptid and add_thread calls.
|
|
|
|
|
|
* btrace.c (maint_btrace_packet_history_cmd): Adjust
|
|
|
|
|
|
find_thread_ptid call.
|
|
|
|
|
|
* corelow.c (add_to_thread_list): Adjust add_thread call.
|
|
|
|
|
|
(core_target_open): Adjust add_thread_silent and thread_count
|
|
|
|
|
|
calls.
|
|
|
|
|
|
(core_target::pid_to_str): Adjust find_inferior_ptid call.
|
|
|
|
|
|
* ctf.c (ctf_target_open): Adjust add_thread_silent call.
|
|
|
|
|
|
* event-top.c (async_disconnect): Pop targets from all inferiors.
|
|
|
|
|
|
* exec.c (add_target_sections): Push exec target on all inferiors
|
|
|
|
|
|
sharing the program space.
|
|
|
|
|
|
(remove_target_sections): Remove the exec target from all
|
|
|
|
|
|
inferiors sharing the program space.
|
|
|
|
|
|
(exec_on_vfork): New.
|
|
|
|
|
|
* exec.h (exec_on_vfork): Declare.
|
|
|
|
|
|
* fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
|
|
|
|
|
|
Pass it down.
|
|
|
|
|
|
(fbsd_nat_target::update_thread_list): Adjust.
|
|
|
|
|
|
(fbsd_nat_target::resume): Adjust.
|
|
|
|
|
|
(fbsd_handle_debug_trap): Add fbsd_nat_target parameter. Pass it
|
|
|
|
|
|
down.
|
|
|
|
|
|
(fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
|
|
|
|
|
|
* fbsd-tdep.c (fbsd_corefile_thread): Adjust
|
|
|
|
|
|
get_thread_arch_regcache call.
|
|
|
|
|
|
* fork-child.c (gdb_startup_inferior): Pass target down to
|
|
|
|
|
|
startup_inferior and set_executing.
|
|
|
|
|
|
* gdbthread.h (struct process_stratum_target): Forward declare.
|
|
|
|
|
|
(add_thread, add_thread_silent, add_thread_with_info)
|
|
|
|
|
|
(in_thread_list): Add process_stratum_target parameter.
|
|
|
|
|
|
(find_thread_ptid(inferior*, ptid_t)): New overload.
|
|
|
|
|
|
(find_thread_ptid, thread_change_ptid): Add process_stratum_target
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(all_threads()): Delete overload.
|
|
|
|
|
|
(all_threads, all_non_exited_threads): Add process_stratum_target
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(all_threads_safe): Use brace initialization.
|
|
|
|
|
|
(thread_count): Add process_stratum_target parameter.
|
|
|
|
|
|
(set_resumed, set_running, set_stop_requested, set_executing)
|
|
|
|
|
|
(threads_are_executing, finish_thread_state): Add
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
(switch_to_thread): Use is_current_thread.
|
|
|
|
|
|
* i386-fbsd-tdep.c: Include "inferior.h".
|
|
|
|
|
|
(i386fbsd_get_thread_local_address): Pass down target.
|
|
|
|
|
|
* i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
|
|
|
|
|
|
* inf-child.c (inf_child_target::maybe_unpush_target): Remove
|
|
|
|
|
|
have_inferiors check.
|
|
|
|
|
|
* inf-ptrace.c (inf_ptrace_target::create_inferior)
|
|
|
|
|
|
(inf_ptrace_target::attach): Adjust.
|
|
|
|
|
|
* infcall.c (run_inferior_call): Adjust.
|
|
|
|
|
|
* infcmd.c (run_command_1): Pass target to
|
|
|
|
|
|
scoped_finish_thread_state.
|
|
|
|
|
|
(proceed_thread_callback): Skip inferiors with no execution.
|
|
|
|
|
|
(continue_command): Rename 'all_threads' local to avoid hiding
|
|
|
|
|
|
'all_threads' function. Adjust get_last_target_status call.
|
|
|
|
|
|
(prepare_one_step): Adjust set_running call.
|
|
|
|
|
|
(signal_command): Use user_visible_resume_target. Compare thread
|
|
|
|
|
|
pointers instead of inferior_ptid.
|
|
|
|
|
|
(info_program_command): Adjust to pass down target.
|
|
|
|
|
|
(attach_command): Mark target's 'thread_executing' flag.
|
|
|
|
|
|
(stop_current_target_threads_ns): New, factored out from ...
|
|
|
|
|
|
(interrupt_target_1): ... this. Switch inferior before making
|
|
|
|
|
|
target calls.
|
|
|
|
|
|
* inferior-iter.h
|
|
|
|
|
|
(struct all_inferiors_iterator, struct all_inferiors_range)
|
|
|
|
|
|
(struct all_inferiors_safe_range)
|
|
|
|
|
|
(struct all_non_exited_inferiors_range): Filter on
|
|
|
|
|
|
process_stratum_target too. Remove explicit.
|
|
|
|
|
|
* inferior.c (inferior::inferior): Push dummy target on target
|
|
|
|
|
|
stack.
|
|
|
|
|
|
(find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
|
|
|
|
|
|
Add process_stratum_target parameter, and pass it down.
|
|
|
|
|
|
(have_live_inferiors): Adjust.
|
|
|
|
|
|
(switch_to_inferior_and_push_target): New.
|
|
|
|
|
|
(add_inferior_command, clone_inferior_command): Handle
|
|
|
|
|
|
"-no-connection" parameter. Use
|
|
|
|
|
|
switch_to_inferior_and_push_target.
|
|
|
|
|
|
(_initialize_inferior): Mention "-no-connection" option in
|
|
|
|
|
|
the help of "add-inferior" and "clone-inferior" commands.
|
|
|
|
|
|
* inferior.h: Include "process-stratum-target.h".
|
|
|
|
|
|
(interrupt_target_1): Use bool.
|
|
|
|
|
|
(struct inferior) <push_target, unpush_target, target_is_pushed,
|
|
|
|
|
|
find_target_beneath, top_target, process_target, target_at,
|
|
|
|
|
|
m_stack>: New.
|
|
|
|
|
|
(discard_all_inferiors): Delete.
|
|
|
|
|
|
(find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
|
|
|
|
|
|
(all_inferiors, all_non_exited_inferiors): Add
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
* infrun.c: Include "gdb_select.h" and <unordered_map>.
|
|
|
|
|
|
(target_last_proc_target): New global.
|
|
|
|
|
|
(follow_fork_inferior): Push target on new inferior. Pass target
|
|
|
|
|
|
to add_thread_silent. Call exec_on_vfork. Handle target's
|
|
|
|
|
|
reference count.
|
|
|
|
|
|
(follow_fork): Adjust get_last_target_status call. Also consider
|
|
|
|
|
|
target.
|
|
|
|
|
|
(follow_exec): Push target on new inferior.
|
|
|
|
|
|
(struct execution_control_state) <target>: New field.
|
|
|
|
|
|
(user_visible_resume_target): New.
|
|
|
|
|
|
(do_target_resume): Call target_async.
|
|
|
|
|
|
(resume_1): Set target's threads_executing flag. Consider resume
|
|
|
|
|
|
target.
|
|
|
|
|
|
(commit_resume_all_targets): New.
|
|
|
|
|
|
(proceed): Also consider resume target. Skip threads of inferiors
|
|
|
|
|
|
with no execution. Commit resumtion in all targets.
|
|
|
|
|
|
(start_remote): Pass current inferior to wait_for_inferior.
|
|
|
|
|
|
(infrun_thread_stop_requested): Consider target as well. Pass
|
|
|
|
|
|
thread_info pointer to clear_inline_frame_state instead of ptid.
|
|
|
|
|
|
(infrun_thread_thread_exit): Consider target as well.
|
|
|
|
|
|
(random_pending_event_thread): New inferior parameter. Use it.
|
|
|
|
|
|
(do_target_wait): Rename to ...
|
|
|
|
|
|
(do_target_wait_1): ... this. Add inferior parameter, and pass it
|
|
|
|
|
|
down.
|
|
|
|
|
|
(threads_are_resumed_pending_p, do_target_wait): New.
|
|
|
|
|
|
(prepare_for_detach): Adjust calls.
|
|
|
|
|
|
(wait_for_inferior): New inferior parameter. Handle it. Use
|
|
|
|
|
|
do_target_wait_1 instead of do_target_wait.
|
|
|
|
|
|
(fetch_inferior_event): Adjust. Switch to representative
|
|
|
|
|
|
inferior. Pass target down.
|
|
|
|
|
|
(set_last_target_status): Add process_stratum_target parameter.
|
|
|
|
|
|
Save target in global.
|
|
|
|
|
|
(get_last_target_status): Add process_stratum_target parameter and
|
|
|
|
|
|
handle it.
|
|
|
|
|
|
(nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
|
|
|
|
|
|
(context_switch): Check inferior_ptid == null_ptid before calling
|
|
|
|
|
|
inferior_thread().
|
|
|
|
|
|
(get_inferior_stop_soon): Pass down target.
|
|
|
|
|
|
(wait_one): Rename to ...
|
|
|
|
|
|
(poll_one_curr_target): ... this.
|
|
|
|
|
|
(struct wait_one_event): New.
|
|
|
|
|
|
(wait_one): New.
|
|
|
|
|
|
(stop_all_threads): Adjust.
|
|
|
|
|
|
(handle_no_resumed, handle_inferior_event): Adjust to consider the
|
|
|
|
|
|
event's target.
|
|
|
|
|
|
(switch_back_to_stepped_thread): Also consider target.
|
|
|
|
|
|
(print_stop_event): Update.
|
|
|
|
|
|
(normal_stop): Update. Also consider the resume target.
|
|
|
|
|
|
* infrun.h (wait_for_inferior): Remove declaration.
|
|
|
|
|
|
(user_visible_resume_target): New declaration.
|
|
|
|
|
|
(get_last_target_status, set_last_target_status): New
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
* inline-frame.c (clear_inline_frame_state(ptid_t)): Add
|
|
|
|
|
|
process_stratum_target parameter, and use it.
|
|
|
|
|
|
(clear_inline_frame_state (thread_info*)): New.
|
|
|
|
|
|
* inline-frame.c (clear_inline_frame_state(ptid_t)): Add
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
(clear_inline_frame_state (thread_info*)): Declare.
|
|
|
|
|
|
* linux-fork.c (delete_checkpoint_command): Pass target down to
|
|
|
|
|
|
find_thread_ptid.
|
|
|
|
|
|
(checkpoint_command): Adjust.
|
|
|
|
|
|
* linux-nat.c (linux_nat_target::follow_fork): Switch to thread
|
|
|
|
|
|
instead of just tweaking inferior_ptid.
|
|
|
|
|
|
(linux_nat_switch_fork): Pass target down to thread_change_ptid.
|
|
|
|
|
|
(exit_lwp): Pass target down to find_thread_ptid.
|
|
|
|
|
|
(attach_proc_task_lwp_callback): Pass target down to
|
|
|
|
|
|
add_thread/set_running/set_executing.
|
|
|
|
|
|
(linux_nat_target::attach): Pass target down to
|
|
|
|
|
|
thread_change_ptid.
|
|
|
|
|
|
(get_detach_signal): Pass target down to find_thread_ptid.
|
|
|
|
|
|
Consider last target status's target.
|
|
|
|
|
|
(linux_resume_one_lwp_throw, resume_lwp)
|
|
|
|
|
|
(linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
|
|
|
|
|
|
(stop_wait_callback, save_stop_reason, linux_nat_filter_event)
|
|
|
|
|
|
(linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
|
|
|
|
|
|
(linux_nat_target::async_wait_fd): New.
|
|
|
|
|
|
(linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
|
|
|
|
|
|
target down.
|
|
|
|
|
|
* linux-nat.h (linux_nat_target::async_wait_fd): Declare.
|
|
|
|
|
|
* linux-tdep.c (get_thread_arch_regcache): Pass target down.
|
|
|
|
|
|
* linux-thread-db.c (struct thread_db_info::process_target): New
|
|
|
|
|
|
field.
|
|
|
|
|
|
(add_thread_db_info): Save target.
|
|
|
|
|
|
(get_thread_db_info): New process_stratum_target parameter. Also
|
|
|
|
|
|
match target.
|
|
|
|
|
|
(delete_thread_db_info): New process_stratum_target parameter.
|
|
|
|
|
|
Also match target.
|
|
|
|
|
|
(thread_from_lwp): Adjust to pass down target.
|
|
|
|
|
|
(thread_db_notice_clone): Pass down target.
|
|
|
|
|
|
(check_thread_db_callback): Pass down target.
|
|
|
|
|
|
(try_thread_db_load_1): Always push the thread_db target.
|
|
|
|
|
|
(try_thread_db_load, record_thread): Pass target down.
|
|
|
|
|
|
(thread_db_target::detach): Pass target down. Always unpush the
|
|
|
|
|
|
thread_db target.
|
|
|
|
|
|
(thread_db_target::wait, thread_db_target::mourn_inferior): Pass
|
|
|
|
|
|
target down. Always unpush the thread_db target.
|
|
|
|
|
|
(find_new_threads_callback, thread_db_find_new_threads_2)
|
|
|
|
|
|
(thread_db_target::update_thread_list): Pass target down.
|
|
|
|
|
|
(thread_db_target::pid_to_str): Pass current inferior down.
|
|
|
|
|
|
(thread_db_target::get_thread_local_address): Pass target down.
|
|
|
|
|
|
(thread_db_target::resume, maintenance_check_libthread_db): Pass
|
|
|
|
|
|
target down.
|
|
|
|
|
|
* nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
|
|
|
|
|
|
* procfs.c (procfs_target::procfs_init_inferior): Declare.
|
|
|
|
|
|
(proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
|
|
|
|
|
|
(procfs_init_inferior): Rename to ...
|
|
|
|
|
|
(procfs_target::procfs_init_inferior): ... this and adjust.
|
|
|
|
|
|
(procfs_target::create_inferior, procfs_notice_thread)
|
|
|
|
|
|
(procfs_do_thread_registers): Adjust.
|
|
|
|
|
|
* ppc-fbsd-tdep.c: Include "inferior.h".
|
|
|
|
|
|
(ppcfbsd_get_thread_local_address): Pass down target.
|
|
|
|
|
|
* proc-service.c (ps_xfer_memory): Switch current inferior and
|
|
|
|
|
|
program space as well.
|
|
|
|
|
|
(get_ps_regcache): Pass target down.
|
|
|
|
|
|
* process-stratum-target.c
|
|
|
|
|
|
(process_stratum_target::thread_address_space)
|
|
|
|
|
|
(process_stratum_target::thread_architecture): Pass target down.
|
|
|
|
|
|
* process-stratum-target.h
|
|
|
|
|
|
(process_stratum_target::threads_executing): New field.
|
|
|
|
|
|
(as_process_stratum_target): New.
|
|
|
|
|
|
* ravenscar-thread.c
|
|
|
|
|
|
(ravenscar_thread_target::update_inferior_ptid): Pass target down.
|
|
|
|
|
|
(ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
|
|
|
|
|
|
down.
|
|
|
|
|
|
* record-btrace.c (record_btrace_target::info_record): Adjust.
|
|
|
|
|
|
(record_btrace_target::record_method)
|
|
|
|
|
|
(record_btrace_target::record_is_replaying)
|
|
|
|
|
|
(record_btrace_target::fetch_registers)
|
|
|
|
|
|
(get_thread_current_frame_id, record_btrace_target::resume)
|
|
|
|
|
|
(record_btrace_target::wait, record_btrace_target::stop): Pass
|
|
|
|
|
|
target down.
|
|
|
|
|
|
* record-full.c (record_full_wait_1): Switch to event thread.
|
|
|
|
|
|
Pass target down.
|
|
|
|
|
|
* regcache.c (regcache::regcache)
|
|
|
|
|
|
(get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
|
|
|
|
|
|
process_stratum_target parameter and handle it.
|
|
|
|
|
|
(current_thread_target): New global.
|
|
|
|
|
|
(get_thread_regcache): Add process_stratum_target parameter and
|
|
|
|
|
|
handle it. Switch inferior before calling target method.
|
|
|
|
|
|
(get_thread_regcache): Pass target down.
|
|
|
|
|
|
(get_thread_regcache_for_ptid): Pass target down.
|
|
|
|
|
|
(registers_changed_ptid): Add process_stratum_target parameter and
|
|
|
|
|
|
handle it.
|
|
|
|
|
|
(registers_changed_thread, registers_changed): Pass target down.
|
|
|
|
|
|
(test_get_thread_arch_aspace_regcache): New.
|
|
|
|
|
|
(current_regcache_test): Define a couple local test_target_ops
|
|
|
|
|
|
instances and use them for testing.
|
|
|
|
|
|
(readwrite_regcache): Pass process_stratum_target parameter.
|
|
|
|
|
|
(cooked_read_test, cooked_write_test): Pass mock_target down.
|
|
|
|
|
|
* regcache.h (get_thread_regcache, get_thread_arch_regcache)
|
|
|
|
|
|
(get_thread_arch_aspace_regcache): Add process_stratum_target
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(regcache::target): New method.
|
|
|
|
|
|
(regcache::regcache, regcache::get_thread_arch_aspace_regcache)
|
|
|
|
|
|
(regcache::registers_changed_ptid): Add process_stratum_target
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(regcache::m_target): New field.
|
|
|
|
|
|
(registers_changed_ptid): Add process_stratum_target parameter.
|
|
|
|
|
|
* remote.c (remote_state::supports_vCont_probed): New field.
|
|
|
|
|
|
(remote_target::async_wait_fd): New method.
|
|
|
|
|
|
(remote_unpush_and_throw): Add remote_target parameter.
|
|
|
|
|
|
(get_current_remote_target): Adjust.
|
|
|
|
|
|
(remote_target::remote_add_inferior): Push target.
|
|
|
|
|
|
(remote_target::remote_add_thread)
|
|
|
|
|
|
(remote_target::remote_notice_new_inferior)
|
|
|
|
|
|
(get_remote_thread_info): Pass target down.
|
|
|
|
|
|
(remote_target::update_thread_list): Skip threads of inferiors
|
|
|
|
|
|
bound to other targets. (remote_target::close): Don't discard
|
|
|
|
|
|
inferiors. (remote_target::add_current_inferior_and_thread)
|
|
|
|
|
|
(remote_target::process_initial_stop_replies)
|
|
|
|
|
|
(remote_target::start_remote)
|
|
|
|
|
|
(remote_target::remote_serial_quit_handler): Pass down target.
|
|
|
|
|
|
(remote_target::remote_unpush_target): New remote_target
|
|
|
|
|
|
parameter. Unpush the target from all inferiors.
|
|
|
|
|
|
(remote_target::remote_unpush_and_throw): New remote_target
|
|
|
|
|
|
parameter. Pass it down.
|
|
|
|
|
|
(remote_target::open_1): Check whether the current inferior has
|
|
|
|
|
|
execution instead of checking whether any inferior is live. Pass
|
|
|
|
|
|
target down.
|
|
|
|
|
|
(remote_target::remote_detach_1): Pass down target. Use
|
|
|
|
|
|
remote_unpush_target.
|
|
|
|
|
|
(extended_remote_target::attach): Pass down target.
|
|
|
|
|
|
(remote_target::remote_vcont_probe): Set supports_vCont_probed.
|
|
|
|
|
|
(remote_target::append_resumption): Pass down target.
|
|
|
|
|
|
(remote_target::append_pending_thread_resumptions)
|
|
|
|
|
|
(remote_target::remote_resume_with_hc, remote_target::resume)
|
|
|
|
|
|
(remote_target::commit_resume): Pass down target.
|
|
|
|
|
|
(remote_target::remote_stop_ns): Check supports_vCont_probed.
|
|
|
|
|
|
(remote_target::interrupt_query)
|
|
|
|
|
|
(remote_target::remove_new_fork_children)
|
|
|
|
|
|
(remote_target::check_pending_events_prevent_wildcard_vcont)
|
|
|
|
|
|
(remote_target::remote_parse_stop_reply)
|
|
|
|
|
|
(remote_target::process_stop_reply): Pass down target.
|
|
|
|
|
|
(first_remote_resumed_thread): New remote_target parameter. Pass
|
|
|
|
|
|
it down.
|
|
|
|
|
|
(remote_target::wait_as): Pass down target.
|
|
|
|
|
|
(unpush_and_perror): New remote_target parameter. Pass it down.
|
|
|
|
|
|
(remote_target::readchar, remote_target::remote_serial_write)
|
|
|
|
|
|
(remote_target::getpkt_or_notif_sane_1)
|
|
|
|
|
|
(remote_target::kill_new_fork_children, remote_target::kill): Pass
|
|
|
|
|
|
down target.
|
|
|
|
|
|
(remote_target::mourn_inferior): Pass down target. Use
|
|
|
|
|
|
remote_unpush_target.
|
|
|
|
|
|
(remote_target::core_of_thread)
|
|
|
|
|
|
(remote_target::remote_btrace_maybe_reopen): Pass down target.
|
|
|
|
|
|
(remote_target::pid_to_exec_file)
|
|
|
|
|
|
(remote_target::thread_handle_to_thread_info): Pass down target.
|
|
|
|
|
|
(remote_target::async_wait_fd): New.
|
|
|
|
|
|
* riscv-fbsd-tdep.c: Include "inferior.h".
|
|
|
|
|
|
(riscv_fbsd_get_thread_local_address): Pass down target.
|
|
|
|
|
|
* sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
|
|
|
|
|
|
* sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
|
|
|
|
|
|
(ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
|
|
|
|
|
|
Adjust.
|
|
|
|
|
|
* solib-spu.c (spu_skip_standalone_loader): Pass down target.
|
|
|
|
|
|
* solib-svr4.c (enable_break): Pass down target.
|
|
|
|
|
|
* spu-multiarch.c (parse_spufs_run): Pass down target.
|
|
|
|
|
|
* spu-tdep.c (spu2ppu_sniffer): Pass down target.
|
|
|
|
|
|
* target-delegates.c: Regenerate.
|
|
|
|
|
|
* target.c (g_target_stack): Delete.
|
|
|
|
|
|
(current_top_target): Return the current inferior's top target.
|
|
|
|
|
|
(target_has_execution_1): Refer to the passed-in inferior's top
|
|
|
|
|
|
target.
|
|
|
|
|
|
(target_supports_terminal_ours): Check whether the initial
|
|
|
|
|
|
inferior was already created.
|
|
|
|
|
|
(decref_target): New.
|
|
|
|
|
|
(target_stack::push): Incref/decref the target.
|
|
|
|
|
|
(push_target, push_target, unpush_target): Adjust.
|
|
|
|
|
|
(target_stack::unpush): Defref target.
|
|
|
|
|
|
(target_is_pushed): Return bool. Adjust to refer to the current
|
|
|
|
|
|
inferior's target stack.
|
|
|
|
|
|
(dispose_inferior): Delete, and inline parts ...
|
|
|
|
|
|
(target_preopen): ... here. Only dispose of the current inferior.
|
|
|
|
|
|
(target_detach): Hold strong target reference while detaching.
|
|
|
|
|
|
Pass target down.
|
|
|
|
|
|
(target_thread_name): Add assertion.
|
|
|
|
|
|
(target_resume): Pass down target.
|
|
|
|
|
|
(target_ops::beneath, find_target_at): Adjust to refer to the
|
|
|
|
|
|
current inferior's target stack.
|
|
|
|
|
|
(get_dummy_target): New.
|
|
|
|
|
|
(target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
|
|
|
|
|
|
has a thread running.
|
|
|
|
|
|
(initialize_targets): Rename to ...
|
|
|
|
|
|
(_initialize_target): ... this.
|
|
|
|
|
|
* target.h: Include "gdbsupport/refcounted-object.h".
|
|
|
|
|
|
(struct target_ops): Inherit refcounted_object.
|
|
|
|
|
|
(target_ops::shortname, target_ops::longname): Make const.
|
|
|
|
|
|
(target_ops::async_wait_fd): New method.
|
|
|
|
|
|
(decref_target): Declare.
|
|
|
|
|
|
(struct target_ops_ref_policy): New.
|
|
|
|
|
|
(target_ops_ref): New typedef.
|
|
|
|
|
|
(get_dummy_target): Declare function.
|
|
|
|
|
|
(target_is_pushed): Return bool.
|
|
|
|
|
|
* thread-iter.c (all_matching_threads_iterator::m_inf_matches)
|
|
|
|
|
|
(all_matching_threads_iterator::all_matching_threads_iterator):
|
|
|
|
|
|
Handle filter target.
|
|
|
|
|
|
* thread-iter.h (struct all_matching_threads_iterator, struct
|
|
|
|
|
|
all_matching_threads_range, class all_non_exited_threads_range):
|
|
|
|
|
|
Filter by target too. Remove explicit.
|
|
|
|
|
|
* thread.c (threads_executing): Delete.
|
|
|
|
|
|
(inferior_thread): Pass down current inferior.
|
|
|
|
|
|
(clear_thread_inferior_resources): Pass down thread pointer
|
|
|
|
|
|
instead of ptid_t.
|
|
|
|
|
|
(add_thread_silent, add_thread_with_info, add_thread): Add
|
|
|
|
|
|
process_stratum_target parameter. Use it for thread and inferior
|
|
|
|
|
|
searches.
|
|
|
|
|
|
(is_current_thread): New.
|
|
|
|
|
|
(thread_info::deletable): Use it.
|
|
|
|
|
|
(find_thread_ptid, thread_count, in_thread_list)
|
|
|
|
|
|
(thread_change_ptid, set_resumed, set_running): New
|
|
|
|
|
|
process_stratum_target parameter. Pass it down.
|
|
|
|
|
|
(set_executing): New process_stratum_target parameter. Pass it
|
|
|
|
|
|
down. Adjust reference to 'threads_executing'.
|
|
|
|
|
|
(threads_are_executing): New process_stratum_target parameter.
|
|
|
|
|
|
Adjust reference to 'threads_executing'.
|
|
|
|
|
|
(set_stop_requested, finish_thread_state): New
|
|
|
|
|
|
process_stratum_target parameter. Pass it down.
|
|
|
|
|
|
(switch_to_thread): Also match inferior.
|
|
|
|
|
|
(switch_to_thread): New process_stratum_target parameter. Pass it
|
|
|
|
|
|
down.
|
|
|
|
|
|
(update_threads_executing): Reimplement.
|
|
|
|
|
|
* top.c (quit_force): Pop targets from all inferior.
|
|
|
|
|
|
(gdb_init): Don't call initialize_targets.
|
|
|
|
|
|
* windows-nat.c (windows_nat_target) <get_windows_debug_event>:
|
|
|
|
|
|
Declare.
|
|
|
|
|
|
(windows_add_thread, windows_delete_thread): Adjust.
|
|
|
|
|
|
(get_windows_debug_event): Rename to ...
|
|
|
|
|
|
(windows_nat_target::get_windows_debug_event): ... this. Adjust.
|
|
|
|
|
|
* tracefile-tfile.c (tfile_target_open): Pass down target.
|
|
|
|
|
|
* gdbsupport/common-gdbthread.h (struct process_stratum_target):
|
|
|
|
|
|
Forward declare.
|
|
|
|
|
|
(switch_to_thread): Add process_stratum_target parameter.
|
|
|
|
|
|
* mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
|
|
|
|
|
|
parameter. Use it.
|
|
|
|
|
|
(mi_on_resume): Pass target down.
|
|
|
|
|
|
* nat/fork-inferior.c (startup_inferior): Add
|
|
|
|
|
|
process_stratum_target parameter. Pass it down.
|
|
|
|
|
|
* nat/fork-inferior.h (startup_inferior): Add
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
* python/py-threadevent.c (py_get_event_thread): Pass target down.
|
|
|
|
|
|
|
2020-01-10 21:05:54 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::start_remote): Don't set inferior_ptid
|
|
|
|
|
|
directly. Instead find the first thread in the thread list and
|
|
|
|
|
|
use switch_to_thread.
|
|
|
|
|
|
|
Fix reconnecting to a gdbserver already debugging multiple processes, I
The multi-target patch will change the remote target's behavior when:
- the current inferior is connected to an extended-remote target.
- the current inferior is attached to any process.
- some other inferior than than the current one is live.
In current master, we get:
(gdb) tar extended-remote :9999
A program is being debugged already. Kill it? (y or n)
While after multi-target, since each inferior may have its own target
connection, we'll get:
(gdb) tar extended-remote :9999
Already connected to a remote target. Disconnect? (y or n)
That change made gdb.server/extended-remote-restart.exp expose a gdb
bug, because it made "target remote", via gdb_reconnect, just
disconnect from the previous connection, while in current master that
command would kill the inferior before disconnecting. In turn, that
would make a multi-target gdb find processes already running under
control of gdbserver as soon as it reconnects, while in current master
there is never any process around when gdb reconnects, since they'd
all been killed prior to disconnection.
The bug this exposed is that remote_target::remote_add_inferior was
always reusing current_inferior() for the new process, even if the
current inferior was already bound to a process. In the testcase's
case, when we reconnect, the remote is debugging two processes. So
we'd bind the first remote process to the empty current inferior the
first time, and then bind the second remote process to the same
inferior again, essencially losing track of the first process. That
resulted in failed assertions when we look up the inferior for the
first process by PID. The fix is to still prefer binding to the
current inferior (so that plain "target remote" keeps doing what you'd
expect), but not reuse the current inferior if it is already bound to
a process.
This patch tweaks the test to explicitly disconnect before
reconnecting, to avoid GDB killing processes, thus making current GDB
behave the same as it will behave when the multi-target work lands.
That change alone without the GDB fix exposes the bug like so:
(gdb) PASS: gdb.server/extended-remote-restart.exp: kill: 0, follow-child 0: disconnect
target extended-remote localhost:2350
Remote debugging using localhost:2350
src/gdb/thread.c:93: internal-error: thread_info* inferior_thread(): Assertion `tp' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n)
The original bug that the testcase was written for was related to
killing, (git 9d4a934ce604 ("gdb: Fix assert for extended-remote
target (PR gdb/18050)")), but since the testcase tries reconnecting
with both explicitly killing and not explicitly killing, I think we're
covering the original bug with this testcase change.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* remote.c (remote_target::remote_add_inferior): Don't bind a
process to the current inferior if the current inferior is already
bound to a process.
gdb/testsuite/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* gdb.server/extended-remote-restart.exp (test_reload): Explicitly
disconnect before reconnecting.
2020-01-10 21:05:53 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::remote_add_inferior): Don't bind a
|
|
|
|
|
|
process to the current inferior if the current inferior is already
|
|
|
|
|
|
bound to a process.
|
|
|
|
|
|
|
2020-01-10 21:05:52 +01:00
|
|
|
|
2020-01-10 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
|
|
|
|
|
|
Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
|
|
|
|
|
|
If no process is specified, return null_ptid instead of
|
|
|
|
|
|
inferior_ptid.
|
|
|
|
|
|
(remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
|
|
|
|
|
|
TARGET_WAITKIND_SIGNALLED with no pid.
|
|
|
|
|
|
|
Tweak handling of remote errors in response to resumption packet
With current master, on a Fedora 27 machine with a kernel with buggy
watchpoint support, I see:
(gdb) PASS: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: hardware breakpoints work
continue
Continuing.
warning: Remote failure reply: E01
Remote communication error. Target disconnected.: Connection reset by peer.
(gdb) FAIL: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: watchpoints work
continue
The program is not being run.
(gdb) FAIL: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: breakpoint after the first fork (the program is no longer running)
The FAILs themselves aren't what's interesting here. What is
interesting is that with the main multi-target patch applied, I was getting this:
(gdb) PASS: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: hardware breakpoints work
continue
Continuing.
warning: Remote failure reply: E01
/home/pedro/brno/pedro/gdb/binutils-gdb-2/build/../src/gdb/inferior.c:285: internal-error: inferior* find_inferior_pid(process_stratum_target*, int): Assertion `pid != 0' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) FAIL: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: watchpoints work (GDB internal error)
The problem is that in remote_target::wait_as, we're hitting this:
switch (buf[0])
{
case 'E': /* Error of some sort. */
/* We're out of sync with the target now. Did it continue or
not? Not is more likely, so report a stop. */
rs->waiting_for_stop_reply = 0;
warning (_("Remote failure reply: %s"), buf);
status->kind = TARGET_WAITKIND_STOPPED;
status->value.sig = GDB_SIGNAL_0;
break;
which leaves event_ptid as null_ptid. At the end of the function, we then reach:
else if (status->kind != TARGET_WAITKIND_EXITED
&& status->kind != TARGET_WAITKIND_SIGNALLED)
{
if (event_ptid != null_ptid)
record_currthread (rs, event_ptid);
else
event_ptid = inferior_ptid; <<<<< here
}
and the trouble is that with the multi-target patch, we'll get here
with inferior_ptid as null_ptid too. That is done exactly to find
these implicit assumptions that inferior_ptid is a good choice for
default thread, which isn't generaly true.
I first thought of fixing this in the "case 'E'" path, but, given that
this "event_ptid = inferior_ptid" path is also taken when the remote
target does not support threads at all, no thread-related packets or
extensions, it's better to fix it in latter path, to handle all
scenarios that miss reporting a thread.
That's what this patch does.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* remote.c (first_remote_resumed_thread): New.
(remote_target::wait_as): Use it as default event_ptid instead of
inferior_ptid.
2020-01-10 21:05:52 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (first_remote_resumed_thread): New.
|
|
|
|
|
|
(remote_target::wait_as): Use it as default event_ptid instead of
|
|
|
|
|
|
inferior_ptid.
|
|
|
|
|
|
|
2020-01-10 21:05:51 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
|
|
|
|
|
|
|
2020-01-10 21:05:50 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
|
|
|
|
|
|
not -1.
|
|
|
|
|
|
|
2020-01-10 21:05:49 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
|
|
|
|
|
|
ptid to get_last_target_status.
|
|
|
|
|
|
* break-catch-syscall.c (print_it_catch_syscall): Don't pass a
|
|
|
|
|
|
ptid to get_last_target_status.
|
|
|
|
|
|
* infcmd.c (continue_command): Don't pass a target_waitstatus to
|
|
|
|
|
|
get_last_target_status.
|
|
|
|
|
|
(info_program_command): Don't pass a target_waitstatus to
|
|
|
|
|
|
get_last_target_status.
|
|
|
|
|
|
* infrun.c (init_wait_for_inferior): Use
|
|
|
|
|
|
nullify_last_target_wait_ptid.
|
|
|
|
|
|
(get_last_target_status): Handle nullptr arguments.
|
|
|
|
|
|
(nullify_last_target_wait_ptid): Clear target_last_waitstatus.
|
|
|
|
|
|
(print_stop_event): Don't pass a ptid to get_last_target_status.
|
|
|
|
|
|
(normal_stop): Don't pass a ptid to get_last_target_status.
|
|
|
|
|
|
* infrun.h (get_last_target_status, set_last_target_status): Move
|
|
|
|
|
|
comments here and update.
|
|
|
|
|
|
(nullify_last_target_wait_ptid): Declare.
|
|
|
|
|
|
* linux-fork.c (fork_load_infrun_state): Remove local extern
|
|
|
|
|
|
declaration of nullify_last_target_wait_ptid.
|
|
|
|
|
|
* linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
|
|
|
|
|
|
to get_last_target_status.
|
|
|
|
|
|
|
2020-01-10 21:05:48 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbthread.h (scoped_restore_current_thread)
|
|
|
|
|
|
<dont_restore, restore, m_dont_restore>: Declare.
|
|
|
|
|
|
* thread.c (thread_alive): Add assertion. Return bool.
|
|
|
|
|
|
(switch_to_thread_if_alive): New.
|
|
|
|
|
|
(prune_threads): Switch inferior/thread.
|
|
|
|
|
|
(print_thread_info_1): Switch thread before calling target methods.
|
|
|
|
|
|
(scoped_restore_current_thread::restore): New, factored out from
|
|
|
|
|
|
...
|
|
|
|
|
|
(scoped_restore_current_thread::~scoped_restore_current_thread):
|
|
|
|
|
|
... this.
|
|
|
|
|
|
(scoped_restore_current_thread::scoped_restore_current_thread):
|
|
|
|
|
|
Add assertion.
|
|
|
|
|
|
(thread_apply_all_command, thread_select): Use
|
|
|
|
|
|
switch_to_thread_if_alive.
|
|
|
|
|
|
* infrun.c (proceed, restart_threads, handle_signal_stop)
|
|
|
|
|
|
(switch_back_to_stepped_thread): Switch current thread before
|
|
|
|
|
|
calling target methods.
|
|
|
|
|
|
|
2020-01-10 21:05:47 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* inferior.c (switch_to_inferior_no_thread): New function,
|
|
|
|
|
|
factored out from ...
|
|
|
|
|
|
(inferior_command): ... here.
|
|
|
|
|
|
* inferior.h (switch_to_inferior_no_thread): Declare.
|
|
|
|
|
|
* mi/mi-main.c (run_one_inferior): Use
|
|
|
|
|
|
switch_to_inferior_no_thread.
|
|
|
|
|
|
|
Delete unnecessary code from kill_command
I believe this comment:
/* Killing off the inferior can leave us with a core file. If
so, print the state we are left in. */
Referred to the fact that a decade ago, by design, GDB would let you
type "run" when debugging a core dump, keeping the core open. That
"run" would push a process_stratum target on the target stack for the
live process, and, the core would remain open -- we used to have a
core_stratum. When the live process was killed/detached or exited,
GDB would go back to debugging the core, since the core_stratum target
was now at the top of the stack. That design had a number of
problems, see here for example:
https://sourceware.org/ml/gdb-patches/2008-08/msg00290.html
In 2010, core_stratum was finaly eliminated and cores now have
process_stratum too, with commit c0edd9edadfe ("Make core files the
process_stratum."). Pushing a live process on the stack while you're
debugging a core discards the core completely.
I also thought that this might be in use with checkpoints, but it does
not -- "kill" when you have multiple checkpoints kills all the
checkpoints.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* infcmd.c (kill_command): Remove dead code.
2020-01-10 21:05:46 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infcmd.c (kill_command): Remove dead code.
|
|
|
|
|
|
|
Don't check target is running in remote_target::mourn_inferior
I believe the tail end of remote_target::mourn_inferior is broken, and
it's been broken for too long to even bother trying to fix. Most
probably nobody needs it. If the code is reached and we find the
target is running, we'd need to resync the thread list, at least,
since generic_mourn_inferior got rid of all the threads in the
inferior, otherwise, we'd hit an assertion on the next call to
inferior_thread(), for example. A "correct" fix would probably
involve restarting the whole remote_target::start_remote requence,
exactly as if we had completely disconnected and reconnected from
scratch.
Note that regular stub debugging usually uses plain target remote, but
this code is only reachable in target extended-mode:
- The !remote_multi_process_p check means that it's only reacheable if
the stub does not support multi-process. I.e., there can only ever
be one live process.
- remote_target::mourn_inferior has this at the top:
/* In 'target remote' mode with one inferior, we close the connection. */
if (!rs->extended && number_of_live_inferiors () <= 1)
{
unpush_target (this);
/* remote_close takes care of doing most of the clean up. */
generic_mourn_inferior ();
return;
}
Which means that if we only had one live inferior (which for our
case, must be true), we'll have closed the connection already,
unless we're in extended-remote mode.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* remote.c (remote_target::mourn_inferior): No longer check
whether the target is running.
2020-01-10 21:05:45 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::mourn_inferior): No longer check
|
|
|
|
|
|
whether the target is running.
|
|
|
|
|
|
|
Make target_ops::has_execution take an 'inferior *' instead of a ptid_t
With the multi-target work, each inferior will have its own target
stack, so to call a target method, we'll need to make sure that the
inferior in question is the current one, otherwise target->beneath()
calls will find the target beneath in the wrong inferior.
In some places, it's much more convenient to be able to check whether
an inferior has execution without having to switch to it in order to
call target_has_execution on the right inferior/target stack, to avoid
side effects with switching inferior/thread/program space.
The current target_ops::has_execution method takes a ptid_t as
parameter, which, in a multi-target world, isn't sufficient to
identify the target. This patch prepares to address that, by changing
the parameter to an inferior pointer instead. From the inferior,
we'll be able to query its target stack to tell which target is
beneath.
Also adds a new inferior::has_execution() method to make callers a bit
more natural to read.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* corelow.c (core_target::has_execution): Change parameter type to
inferior pointer.
* inferior.c (number_of_live_inferiors): Use
inferior::has_execution instead of target_has_execution_1.
* inferior.h (inferior::has_execution): New.
* linux-thread-db.c (thread_db_target::update_thread_list): Use
inferior::has_execution instead of target_has_execution_1.
* process-stratum-target.c
(process_stratum_target::has_execution): Change parameter type to
inferior pointer. Check the inferior's PID instead of
inferior_ptid.
* process-stratum-target.h
(process_stratum_target::has_execution): Change parameter type to
inferior pointer.
* record-full.c (record_full_core_target::has_execution): Change
parameter type to inferior pointer.
* target.c (target_has_execution_1): Change parameter type to
inferior pointer.
(target_has_execution_current): Adjust.
* target.h (target_ops::has_execution): Change parameter type to
inferior pointer.
(target_has_execution_1): Change parameter type to inferior
pointer. Change return type to bool.
* tracefile.h (tracefile_target::has_execution): Change parameter
type to inferior pointer.
2020-01-10 21:05:44 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* corelow.c (core_target::has_execution): Change parameter type to
|
|
|
|
|
|
inferior pointer.
|
|
|
|
|
|
* inferior.c (number_of_live_inferiors): Use
|
|
|
|
|
|
inferior::has_execution instead of target_has_execution_1.
|
|
|
|
|
|
* inferior.h (inferior::has_execution): New.
|
|
|
|
|
|
* linux-thread-db.c (thread_db_target::update_thread_list): Use
|
|
|
|
|
|
inferior::has_execution instead of target_has_execution_1.
|
|
|
|
|
|
* process-stratum-target.c
|
|
|
|
|
|
(process_stratum_target::has_execution): Change parameter type to
|
|
|
|
|
|
inferior pointer. Check the inferior's PID instead of
|
|
|
|
|
|
inferior_ptid.
|
|
|
|
|
|
* process-stratum-target.h
|
|
|
|
|
|
(process_stratum_target::has_execution): Change parameter type to
|
|
|
|
|
|
inferior pointer.
|
|
|
|
|
|
* record-full.c (record_full_core_target::has_execution): Change
|
|
|
|
|
|
parameter type to inferior pointer.
|
|
|
|
|
|
* target.c (target_has_execution_1): Change parameter type to
|
|
|
|
|
|
inferior pointer.
|
|
|
|
|
|
(target_has_execution_current): Adjust.
|
|
|
|
|
|
* target.h (target_ops::has_execution): Change parameter type to
|
|
|
|
|
|
inferior pointer.
|
|
|
|
|
|
(target_has_execution_1): Change parameter type to inferior
|
|
|
|
|
|
pointer. Change return type to bool.
|
|
|
|
|
|
* tracefile.h (tracefile_target::has_execution): Change parameter
|
|
|
|
|
|
type to inferior pointer.
|
|
|
|
|
|
|
2020-01-10 21:05:43 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* exceptions.c (print_flush): Remove current_top_target() check.
|
|
|
|
|
|
|
2020-01-10 21:05:42 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (show_remote_exec_file): Show the current inferior's
|
|
|
|
|
|
exec-file instead of the command variable's value.
|
|
|
|
|
|
|
2020-01-10 21:05:41 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* record-full.c (record_full_resume_ptid): New global.
|
|
|
|
|
|
(record_full_target::resume): Set it.
|
|
|
|
|
|
(record_full_wait_1): Use record_full_resume_ptid instead of
|
|
|
|
|
|
inferior_ptid.
|
|
|
|
|
|
|
Preserve selected thread in all-stop w/ background execution
In non-stop mode, if you resume the program in the background (with
"continue&", for example), then gdb makes sure to not switch the
current thread behind your back. That means that you can be sure that
the commands you type apply to the thread you selected, even if some
other thread that was running in the background hits some event just
while you're typing.
In all-stop mode, however, if you resume the program in the
background, gdb let's the current thread switch behind your back.
This is bogus, of course. All-stop and non-stop background
resumptions should behave the same.
This patch fixes that, and adds a testcase that exposes the bad
behavior in current master.
The fork-running-state.exp changes are necessary because that
preexisting testcase was expecting the old behavior:
Before:
continue &
Continuing.
(gdb)
[Attaching after process 8199 fork to child process 8203]
[New inferior 2 (process 8203)]
info threads
Id Target Id Frame
1.1 process 8199 "fork-running-st" (running)
* 2.1 process 8203 "fork-running-st" (running)
(gdb)
After:
continue &
Continuing.
(gdb)
[Attaching after process 24660 fork to child process 24664]
[New inferior 2 (process 24664)]
info threads
Id Target Id Frame
* 1.1 process 24660 "fork-running-st" (running)
2.1 process 24664 "fork-running-st" (running)
(gdb)
Here we see that before this patch GDB switches current inferior to
the new inferior behind the user's back, as a side effect of handling
the fork.
The delete_exited_threads call in inferior_appeared is there to fix an
issue that Baris found in a previous version of this patch. The
fetch_inferior_event change increases the refcount of the current
thread, and in case the fetched inferior event denotes a thread exit,
the thread will not be deleted right away. A non-deleted but exited
thread stays in the inferior's thread list. This, in turn, causes the
"init_thread_list" call in inferior.c to be skipped. A consequence is
that the global thread ID counter is not restarted if the current
thread exits, and then the inferior is restarted:
(gdb) start
Temporary breakpoint 1 at 0x4004d6: file main.c, line 21.
Starting program: /tmp/main
Temporary breakpoint 1, main () at main.c:21
21 foo ();
(gdb) info threads -gid
Id GId Target Id Frame
* 1 1 process 16106 "main" main () at main.c:21
(gdb) c
Continuing.
[Inferior 1 (process 16106) exited normally]
(gdb) start
Temporary breakpoint 2 at 0x4004d6: file main.c, line 21.
Starting program: /tmp/main
Temporary breakpoint 2, main () at main.c:21
21 foo ();
(gdb) info threads -gid
Id GId Target Id Frame
* 1 2 process 16138 "main" main () at main.c:21
^^^
Notice that GId == 2 above. It should have been "1" instead.
The new tids-git-reset.exp testcase exercises the problem above.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* gdbthread.h (scoped_restore_current_thread)
<dont_restore, restore, m_dont_restore>: Declare.
* thread.c (thread_alive): Add assertion. Return bool.
(switch_to_thread_if_alive): New.
(prune_threads): Switch inferior/thread.
(print_thread_info_1): Switch thread before calling target methods.
(scoped_restore_current_thread::restore): New, factored out from
...
(scoped_restore_current_thread::~scoped_restore_current_thread):
... this.
(scoped_restore_current_thread::scoped_restore_current_thread):
Add assertion.
(thread_apply_all_command, thread_select): Use
switch_to_thread_if_alive.
gdb/testsuite/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* gdb.base/fork-running-state.exp (do_test): Adjust expected
output.
* gdb.threads/async.c: New.
* gdb.threads/async.exp: New.
* gdb.multi/tids-gid-reset.c: New.
* gdb.multi/tids-gid-reset.exp: New.
2020-01-10 21:05:41 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbthread.h (scoped_restore_current_thread)
|
|
|
|
|
|
<dont_restore, restore, m_dont_restore>: Declare.
|
|
|
|
|
|
* thread.c (thread_alive): Add assertion. Return bool.
|
|
|
|
|
|
(switch_to_thread_if_alive): New.
|
|
|
|
|
|
(prune_threads): Switch inferior/thread.
|
|
|
|
|
|
(print_thread_info_1): Switch thread before calling target methods.
|
|
|
|
|
|
(scoped_restore_current_thread::restore): New, factored out from
|
|
|
|
|
|
...
|
|
|
|
|
|
(scoped_restore_current_thread::~scoped_restore_current_thread):
|
|
|
|
|
|
... this.
|
|
|
|
|
|
(scoped_restore_current_thread::scoped_restore_current_thread):
|
|
|
|
|
|
Add assertion.
|
|
|
|
|
|
(thread_apply_all_command, thread_select): Use
|
|
|
|
|
|
switch_to_thread_if_alive.
|
|
|
|
|
|
|
2020-01-10 20:30:28 +01:00
|
|
|
|
2020-01-10 George Barrett <bob@bob131.so>
|
|
|
|
|
|
|
|
|
|
|
|
* stap-probe.c (stap_modify_semaphore): Don't check for null
|
|
|
|
|
|
semaphores.
|
|
|
|
|
|
(stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
|
|
|
|
|
|
for null semaphores.
|
|
|
|
|
|
|
2020-01-07 12:39:17 +01:00
|
|
|
|
2020-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
|
|
|
|
|
|
all source windows, and maintain horizontal scroll status while
|
|
|
|
|
|
doing so.
|
|
|
|
|
|
|
2019-12-23 00:52:56 +01:00
|
|
|
|
2020-01-09 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR tui/18932:
|
|
|
|
|
|
* tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
|
|
|
|
|
|
update_source_window, not print_source_lines.
|
|
|
|
|
|
|
2020-01-07 01:41:08 +01:00
|
|
|
|
2020-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui.c (tui_enable): Register tui hooks after calling
|
|
|
|
|
|
tui_display_main.
|
|
|
|
|
|
|
2019-12-18 19:06:43 +01:00
|
|
|
|
2020-01-09 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
|
|
|
|
|
|
|
2020-01-08 22:55:03 +01:00
|
|
|
|
2020-01-08 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* thread.c (print_thread_info_1): Fix indentation.
|
|
|
|
|
|
|
2020-01-08 02:10:40 +01:00
|
|
|
|
2020-01-09 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* symtab.c (general_symbol_info::compute_and_set_names): Move the
|
|
|
|
|
|
unique_xmalloc_ptr outside the if to always free the demangled name.
|
|
|
|
|
|
|
Change section_offsets to a std::vector
This changes section_offsets to be specialization of a std::vector and
updates all the users. It also removes the ANOFFSET and
SIZEOF_N_SECTION_OFFSETS macros.
Most of this is just a generic sort of cleanup, that reduces the
number of lines of code. However, a couple spots were doing weird
things.
objfile_relocate did:
- std::vector<struct section_offsets>
- new_debug_offsets (SIZEOF_N_SECTION_OFFSETS (debug_objfile->num_sections));
... which seems to greatly over-estimate the number of elements
needed.
This appeared in set_objfile_default_section_offset:
- std::vector<struct section_offsets> offsets (objf->num_sections,
- { { offset } });
... which makes sense due to type safety, but is also actively
confusing given that section_offsets was previously also a kind of
vector type.
Tested on x86-64 Fedora 30.
gdb/ChangeLog
2020-01-08 Tom Tromey <tromey@adacore.com>
* xcoffread.c (enter_line_range, read_xcoff_symtab)
(process_xcoff_symbol, xcoff_symfile_offsets): Update.
* symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
(struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
Remove.
(section_offsets): New typedef.
* symtab.c (fixup_section, get_msymbol_address): Update.
* symmisc.c (dump_msymbols): Update.
* symfile.h (relative_addr_info_to_section_offsets)
(symfile_map_offsets_to_segments): Update.
* symfile.c (build_section_addr_info_from_objfile)
(init_objfile_sect_indices): Update.
(struct place_section_arg): Change type of "offsets".
(place_section): Update.
(relative_addr_info_to_section_offsets): Change type of
"section_offsets". Remove "num_sections" parameter.
(default_symfile_offsets, syms_from_objfile_1)
(set_objfile_default_section_offset): Update.
(reread_symbols): No need to preserve section offsets by hand.
(symfile_map_offsets_to_segments): Change type of "offsets".
* stap-probe.c (relocate_address): Update.
* stabsread.h (process_one_symbol): Update.
* solib-target.c (struct lm_info_target) <offsets>: Change type.
(solib_target_relocate_section_addresses): Update.
* solib-svr4.c (enable_break, svr4_relocate_main_executable):
Update.
* solib-frv.c (frv_relocate_main_executable): Update.
* solib-dsbt.c (dsbt_relocate_main_executable): Update.
* solib-aix.c (solib_aix_get_section_offsets): Change return
type.
(solib_aix_solib_create_inferior_hook): Update.
* remote.c (remote_target::get_offsets): Update.
* psymtab.c (find_pc_sect_psymtab): Update.
* psympriv.h (struct partial_symbol) <address, text_low,
text_high>: Update.
* objfiles.h (obj_section_offset): Update.
(struct objfile) <section_offsets>: Change type.
<num_sections>: Remove.
(objfile_relocate): Update.
* objfiles.c (entry_point_address_query): Update
(relocate_one_symbol): Change type of "section_offsets".
(objfile_relocate1, objfile_relocate1): Change type of
"new_offsets".
(objfile_rebase1): Update.
* mipsread.c (mipscoff_symfile_read): Update.
(read_alphacoff_dynamic_symtab): Remove "section_offsets"
parameter.
* mdebugread.c (parse_symbol): Change type of "section_offsets".
(parse_external, psymtab_to_symtab_1): Update.
* machoread.c (macho_symfile_offsets): Update.
* ia64-tdep.c (ia64_find_unwind_table): Update.
* hppa-tdep.c (read_unwind_info): Update.
* hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
* dwarf2read.c (create_addrmap_from_index)
(create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
(process_psymtab_comp_unit_reader, add_partial_symbol)
(add_partial_subprogram, process_full_comp_unit)
(read_file_scope, read_func_scope, read_lexical_block_scope)
(read_call_site_scope, dwarf2_rnglists_process)
(dwarf2_ranges_process, dwarf2_ranges_read)
(dwarf_decode_lines_1, var_decode_location, new_symbol)
(dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
Update.
* dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
Update.
* dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
* dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
(process_one_symbol): Change type of "section_offsets".
* ctfread.c (get_objfile_text_range): Update.
* coffread.c (coff_symtab_read, enter_linenos)
(process_coff_symbol): Update.
* coff-pe-read.c (add_pe_forwarded_sym): Update.
* amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
Change-Id: I147eb967e9b44d82f4048039de7bb44b80cd72fb
2020-01-06 22:34:52 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (enter_line_range, read_xcoff_symtab)
|
|
|
|
|
|
(process_xcoff_symbol, xcoff_symfile_offsets): Update.
|
|
|
|
|
|
* symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
|
|
|
|
|
|
(struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
|
|
|
|
|
|
Remove.
|
|
|
|
|
|
(section_offsets): New typedef.
|
|
|
|
|
|
* symtab.c (fixup_section, get_msymbol_address): Update.
|
|
|
|
|
|
* symmisc.c (dump_msymbols): Update.
|
|
|
|
|
|
* symfile.h (relative_addr_info_to_section_offsets)
|
|
|
|
|
|
(symfile_map_offsets_to_segments): Update.
|
|
|
|
|
|
* symfile.c (build_section_addr_info_from_objfile)
|
|
|
|
|
|
(init_objfile_sect_indices): Update.
|
|
|
|
|
|
(struct place_section_arg): Change type of "offsets".
|
|
|
|
|
|
(place_section): Update.
|
|
|
|
|
|
(relative_addr_info_to_section_offsets): Change type of
|
|
|
|
|
|
"section_offsets". Remove "num_sections" parameter.
|
|
|
|
|
|
(default_symfile_offsets, syms_from_objfile_1)
|
|
|
|
|
|
(set_objfile_default_section_offset): Update.
|
|
|
|
|
|
(reread_symbols): No need to preserve section offsets by hand.
|
|
|
|
|
|
(symfile_map_offsets_to_segments): Change type of "offsets".
|
|
|
|
|
|
* stap-probe.c (relocate_address): Update.
|
|
|
|
|
|
* stabsread.h (process_one_symbol): Update.
|
|
|
|
|
|
* solib-target.c (struct lm_info_target) <offsets>: Change type.
|
|
|
|
|
|
(solib_target_relocate_section_addresses): Update.
|
|
|
|
|
|
* solib-svr4.c (enable_break, svr4_relocate_main_executable):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* solib-frv.c (frv_relocate_main_executable): Update.
|
|
|
|
|
|
* solib-dsbt.c (dsbt_relocate_main_executable): Update.
|
|
|
|
|
|
* solib-aix.c (solib_aix_get_section_offsets): Change return
|
|
|
|
|
|
type.
|
|
|
|
|
|
(solib_aix_solib_create_inferior_hook): Update.
|
|
|
|
|
|
* remote.c (remote_target::get_offsets): Update.
|
|
|
|
|
|
* psymtab.c (find_pc_sect_psymtab): Update.
|
|
|
|
|
|
* psympriv.h (struct partial_symbol) <address, text_low,
|
|
|
|
|
|
text_high>: Update.
|
|
|
|
|
|
* objfiles.h (obj_section_offset): Update.
|
|
|
|
|
|
(struct objfile) <section_offsets>: Change type.
|
|
|
|
|
|
<num_sections>: Remove.
|
|
|
|
|
|
(objfile_relocate): Update.
|
|
|
|
|
|
* objfiles.c (entry_point_address_query): Update
|
|
|
|
|
|
(relocate_one_symbol): Change type of "section_offsets".
|
|
|
|
|
|
(objfile_relocate1, objfile_relocate1): Change type of
|
|
|
|
|
|
"new_offsets".
|
|
|
|
|
|
(objfile_rebase1): Update.
|
|
|
|
|
|
* mipsread.c (mipscoff_symfile_read): Update.
|
|
|
|
|
|
(read_alphacoff_dynamic_symtab): Remove "section_offsets"
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
* mdebugread.c (parse_symbol): Change type of "section_offsets".
|
|
|
|
|
|
(parse_external, psymtab_to_symtab_1): Update.
|
|
|
|
|
|
* machoread.c (macho_symfile_offsets): Update.
|
|
|
|
|
|
* ia64-tdep.c (ia64_find_unwind_table): Update.
|
|
|
|
|
|
* hppa-tdep.c (read_unwind_info): Update.
|
|
|
|
|
|
* hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
|
|
|
|
|
|
* dwarf2read.c (create_addrmap_from_index)
|
|
|
|
|
|
(create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
|
|
|
|
|
|
(process_psymtab_comp_unit_reader, add_partial_symbol)
|
|
|
|
|
|
(add_partial_subprogram, process_full_comp_unit)
|
|
|
|
|
|
(read_file_scope, read_func_scope, read_lexical_block_scope)
|
|
|
|
|
|
(read_call_site_scope, dwarf2_rnglists_process)
|
|
|
|
|
|
(dwarf2_ranges_process, dwarf2_ranges_read)
|
|
|
|
|
|
(dwarf_decode_lines_1, var_decode_location, new_symbol)
|
|
|
|
|
|
(dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
|
|
|
|
|
|
* dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
|
|
|
|
|
|
(process_one_symbol): Change type of "section_offsets".
|
|
|
|
|
|
* ctfread.c (get_objfile_text_range): Update.
|
|
|
|
|
|
* coffread.c (coff_symtab_read, enter_linenos)
|
|
|
|
|
|
(process_coff_symbol): Update.
|
|
|
|
|
|
* coff-pe-read.c (add_pe_forwarded_sym): Update.
|
|
|
|
|
|
* amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
|
|
|
|
|
|
|
2019-10-31 17:46:18 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (parse_macro_definition): Use std::string.
|
|
|
|
|
|
(parse_macro_definition): Likewise.
|
|
|
|
|
|
|
2019-10-31 17:37:35 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (abbrev_table_read_table): Use std::vector.
|
|
|
|
|
|
(ATTR_ALLOC_CHUNK): Remove.
|
|
|
|
|
|
|
2019-10-31 17:34:40 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
|
|
|
|
|
|
|
2019-10-31 17:31:28 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
|
|
|
|
|
|
(dwarf2_compute_name, open_dwo_file): Likewise.
|
|
|
|
|
|
(process_enumeration_scope): Use std::vector.
|
|
|
|
|
|
(guess_partial_die_structure_name): Use unique_xmalloc_ptr.
|
|
|
|
|
|
(partial_die_info::fixup, dwarf2_start_subfile)
|
|
|
|
|
|
(guess_full_die_structure_name, dwarf2_name): Likewise.
|
|
|
|
|
|
(determine_prefix): Update.
|
|
|
|
|
|
(guess_full_die_structure_name): Make return type const.
|
|
|
|
|
|
(partial_die_full_name): Return unique_xmalloc_ptr.
|
|
|
|
|
|
(DW_FIELD_ALLOC_CHUNK): Remove.
|
|
|
|
|
|
|
2019-12-19 19:35:22 +01:00
|
|
|
|
2020-01-07 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR build/24937:
|
|
|
|
|
|
* stap-probe.c (class stap_static_probe_ops): Add constructor.
|
|
|
|
|
|
|
2019-12-29 23:26:41 +01:00
|
|
|
|
2020-01-02 Jon Turney <jon.turney@dronecode.org.uk>
|
|
|
|
|
|
|
|
|
|
|
|
* cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
|
|
|
|
|
|
|
2019-12-26 21:56:01 +01:00
|
|
|
|
2020-01-06 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* stack.c (print_frame_info): Move disassemble_next_line code
|
|
|
|
|
|
inside source_print block.
|
|
|
|
|
|
|
2020-01-06 20:54:21 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbsupport/gdb_wait.c: Include <signal.h> instead of
|
|
|
|
|
|
gdb/signals.h, as we are now using native signal symbols.
|
|
|
|
|
|
|
2020-01-06 15:27:32 +01:00
|
|
|
|
2020-01-06 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
|
|
|
|
|
|
overflow by an early check of content vs threshold.
|
|
|
|
|
|
* tui/tui-source.c (tui_source_window::line_is_displayed):
|
|
|
|
|
|
Likewise.
|
|
|
|
|
|
|
2020-01-06 20:25:23 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
|
|
|
|
|
|
|
2020-01-02 01:25:56 +01:00
|
|
|
|
2020-01-02 Jon Turney <jon.turney@dronecode.org.uk>
|
|
|
|
|
|
|
|
|
|
|
|
* coff-pe-read.c (read_pe_exported_syms): Don't try to read the
|
|
|
|
|
|
export table if no section contains it's RVA.
|
|
|
|
|
|
|
2020-01-06 19:22:15 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
|
|
|
|
|
|
|
2019-12-22 14:58:22 +01:00
|
|
|
|
2020-01-06 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* source.c (print_source_lines_base): Set last_line_listed.
|
|
|
|
|
|
|
2020-01-06 13:54:18 +01:00
|
|
|
|
2020-01-06 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-disasm.c: Remove trailing spaces.
|
|
|
|
|
|
|
2020-01-06 12:51:54 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
|
|
|
|
|
|
* windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
|
|
|
|
|
|
(windows_gdb_signal_to_target): New function, uses the above
|
|
|
|
|
|
enumeration to convert GDB internal signal codes to equivalent
|
|
|
|
|
|
Windows codes.
|
|
|
|
|
|
(windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
|
|
|
|
|
|
* windows-nat.c: Include "gdb_wait.h".
|
|
|
|
|
|
(get_windows_debug_event): Extract the fatal exception from the
|
|
|
|
|
|
exit status and convert to the equivalent Posix signal number.
|
|
|
|
|
|
* cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
|
|
|
|
|
|
possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
|
|
|
|
|
|
* gdbsupport/gdb_wait.c: New file, implements
|
|
|
|
|
|
windows_status_to_termsig.
|
|
|
|
|
|
* gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
|
|
|
|
|
|
(WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
|
|
|
|
|
|
|
2019-12-23 00:45:31 +01:00
|
|
|
|
2020-01-05 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
|
|
|
|
|
|
show_layout.
|
|
|
|
|
|
|
2020-01-03 20:08:16 +01:00
|
|
|
|
2020-01-05 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-linux-nat.c
|
|
|
|
|
|
(aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
|
|
|
|
|
|
and bfd_mach_aarch64.
|
|
|
|
|
|
|
2019-12-15 17:58:16 +01:00
|
|
|
|
2020-01-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
|
|
|
|
|
|
|
|
|
|
|
|
* ui-file.c (stdio_file::can_emit_style_escape)
|
|
|
|
|
|
(tee_file::can_emit_style_escape): Ensure style is used also on
|
|
|
|
|
|
gdb_stderr when gdb_stderr is a tty supporting styling, similarly
|
|
|
|
|
|
to gdb_stdout.
|
|
|
|
|
|
* main.c (set_gdb_data_directory): Use file style to output the
|
|
|
|
|
|
warning that the given pathname is not a directory.
|
|
|
|
|
|
* top.c (show_history_filename, gdb_safe_append_history)
|
|
|
|
|
|
(show_gdb_datadir): Use file style.
|
|
|
|
|
|
|
2019-12-27 13:41:58 +01:00
|
|
|
|
2020-01-03 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* solib-target.c (struct lm_info_target):
|
|
|
|
|
|
Change offsets to be a unique_xmalloc_ptr.
|
|
|
|
|
|
(solib_target_relocate_section_addresses): Update.
|
|
|
|
|
|
|
2019-12-24 13:14:01 +01:00
|
|
|
|
2020-01-03 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-nat.c (windows_clear_solib): Free so_list linked list.
|
|
|
|
|
|
|
2020-01-03 09:16:38 +01:00
|
|
|
|
2020-01-03 Bernd Edlinger <bernd.edlinger@hotmail.de>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS (Write After Approval): Add myself.
|
|
|
|
|
|
|
2019-12-30 19:47:10 +01:00
|
|
|
|
2020-01-02 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* proc-service.c (get_ps_regcache): Remove reference to obsolete
|
|
|
|
|
|
Cell BE architecture.
|
|
|
|
|
|
* target.h (struct target_ops) <thread_architecture>: Likewise.
|
|
|
|
|
|
|
2019-12-30 17:01:02 +01:00
|
|
|
|
2020-01-01 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in: Use INSTALL_PROGRAM_ENV.
|
|
|
|
|
|
|
2020-01-01 13:00:28 +01:00
|
|
|
|
2020-01-01 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS (Write After Approval): Add myself.
|
|
|
|
|
|
|
2020-01-01 07:37:10 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbarch.sh: Update copyright year range of generated files.
|
|
|
|
|
|
|
2020-01-01 07:20:01 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
Update copyright year range in all GDB files.
|
|
|
|
|
|
|
2020-01-01 07:12:57 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copyright.py: Convert to Python 3.
|
|
|
|
|
|
|
2020-01-01 06:19:14 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copyright.py: Adapt after move of gnulib directory from gdb
|
|
|
|
|
|
directory to toplevel directory.
|
|
|
|
|
|
|
2020-01-01 06:08:08 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copyright.py (main): Exit if run from the wrong directory.
|
|
|
|
|
|
|
2020-01-01 05:43:08 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* top.c (print_gdb_version): Change copyright year to 2020.
|
|
|
|
|
|
|
2020-01-01 05:40:23 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
2019-12-30 17:11:32 +01:00
|
|
|
|
|
2020-01-01 05:40:23 +01:00
|
|
|
|
* config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
|
2019-12-30 17:11:32 +01:00
|
|
|
|
|
2020-01-01 05:40:23 +01:00
|
|
|
|
For older changes see ChangeLog-2019.
|
1999-04-16 03:35:26 +02:00
|
|
|
|
|
|
|
|
|
|
Local Variables:
|
|
|
|
|
|
mode: change-log
|
|
|
|
|
|
left-margin: 8
|
|
|
|
|
|
fill-column: 74
|
|
|
|
|
|
version-control: never
|
2007-08-10 00:44:38 +02:00
|
|
|
|
coding: utf-8
|
1999-04-16 03:35:26 +02:00
|
|
|
|
End:
|
