2018-02-01 16:09:44 +01:00
|
|
|
|
2018-02-01 Yao Qi <yao.qi@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* arm-tdep.c (arm_record_extension_space): Change ret to signed.
|
|
|
|
|
|
|
2018-01-31 19:23:00 +01:00
|
|
|
|
2018-01-31 Nikola Prica <nikola.prica@rt-rk.com>
|
|
|
|
|
|
|
|
|
|
|
|
* rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
|
|
|
|
|
|
assign shifted lr_reg to fdata->lr_register when lr_reg is set.
|
|
|
|
|
|
|
2018-01-31 14:50:34 +01:00
|
|
|
|
2018-01-31 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
|
|
|
|
|
|
* inflow.c (child_terminal_save_inferior): Wrap reference to
|
|
|
|
|
|
tcgetpgrp in HAVE_TERMIOS_H.
|
|
|
|
|
|
(child_interrupt, child_pass_ctrlc): Wrap references to signal in
|
|
|
|
|
|
_WIN32.
|
|
|
|
|
|
* remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
|
|
|
|
|
|
always iterate over all inferiors.
|
|
|
|
|
|
(gdbsim_cntrl_c): Adjust.
|
|
|
|
|
|
* windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
|
|
|
|
|
|
|
internal-error using '@' (repeat) operator on array of dynamic objects
Using the following Ada declarations (the same as in
gdb.ada/dyn_stride.exp)...
subtype Small_Type is Integer range L .. U;
type Record_Type (I : Small_Type := L) is record
S : String (1 .. I);
end record;
type Array_Type is array (Integer range <>) of Record_Type;
A1 : Array_Type :=
(1 => (I => U, S => (others => ASCII.NUL)),
2 => (I => 1, S => "A"),
3 => (I => 2, S => "AB"));
... where "L" and "U" are variables, trying to apply the repeat
operator to "A1(1)" yields to an internal error:
| (gdb) print a1(1)@3
| $5 = /[...]/gdbtypes.c:4883: internal-error: type* copy_type(const type*):
| Assertion `TYPE_OBJFILE_OWNED (type)' failed.
What happens first is that the ada-lang module evaluated the "A1(1)"
sub-expression returning a structure where "I" (one of the fields
in that structure) has a type which is dynamic, because it is
a range type whose bounds are not statically known.
Next, we apply the repeat ('@') operator, which is done via
allocate_repeat_value, which creates an array type with the correct
bounds to associate to our value, by calling lookup_array_range_type:
| struct type *
| lookup_array_range_type (struct type *element_type,
| LONGEST low_bound, LONGEST high_bound)
| {
| struct gdbarch *gdbarch = get_type_arch (element_type);
| struct type *index_type = builtin_type (gdbarch)->builtin_int;
| struct type *range_type
| = create_static_range_type (NULL, index_type, low_bound, high_bound);
|
| return create_array_type (NULL, element_type, range_type);
| }
As we can see, this creates an array type whose index type is
always owned by the gdbarch. This is where the problem lies.
Next, we use that type to construct a struct value. That value
then gets passed to the valprint module, which then checks
whether our object is dynamic or not. And because field "I" above
had a dynamic range type, we end up determining by association
that the artificial repeat array itself is also dynamic. So
we attempt to resolve the type, which leads to trying to copying
that type. And because the artifical array created by
lookup_array_range_type has an index which is not objfile-owned,
we trip the assertion.
This patch fixes the issue by enhancing lookup_array_range_type
to create an index type which has the same owner as the element
type.
gdb/ChangeLog:
* gdbtypes.c (lookup_array_range_type): Make sure the array's
index type is objfile-owned if the element type is as well.
gdb/testsuite/ChangeLog:
* testsuite/gdb.ada/dyn_stride.exp: Add "print a1(1)@3" test.
2018-01-31 08:18:56 +01:00
|
|
|
|
2018-01-31 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbtypes.c (lookup_array_range_type): Make sure the array's
|
|
|
|
|
|
index type is objfile-owned if the element type is as well.
|
|
|
|
|
|
|
2018-01-31 04:08:07 +01:00
|
|
|
|
2018-01-31 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
GDB 8.1 released.
|
|
|
|
|
|
|
2018-01-30 17:10:08 +01:00
|
|
|
|
2018-01-30 Philipp Rudo <prudo@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
|
|
|
|
|
|
"features/s390x-linux64.c".
|
|
|
|
|
|
(_initialize_s390_linux_tdep): Remove initialization of tdescs
|
|
|
|
|
|
s390_linux32 and s390x_linux64.
|
|
|
|
|
|
(s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
|
|
|
|
|
|
default tdesc.
|
|
|
|
|
|
* s390-tdep.c: Include "features/s390-linux32.c" and
|
|
|
|
|
|
"features/s390x-linux64.c".
|
|
|
|
|
|
(s390_tdesc_valid): Add check for tdesc_has_registers.
|
|
|
|
|
|
(s390_gdbarch_init): Make sure there is always a valid tdesc.
|
|
|
|
|
|
(_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
|
|
|
|
|
|
tdesc_s390x_linux64.
|
|
|
|
|
|
* s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
|
|
|
|
|
|
tdesc_s390x_linux64 to...
|
|
|
|
|
|
* s390-tdep.h: ...here.
|
|
|
|
|
|
|
Per-inferior target_terminal state, fix PR gdb/13211, more
In my multi-target branch I ran into problems with GDB's terminal
handling that exist in master as well, with multi-inferior debugging.
This patch adds a testcase for said problems
(gdb.multi/multi-term-settings.exp), fixes the problems, fixes PR
gdb/13211 as well (and adds a testcase for that too,
gdb.base/interrupt-daemon.exp).
The basis of the problem I ran into is the following. Consider a
scenario where you have:
- inferior 1 - started with "attach", process is running on some
other terminal.
- inferior 2 - started with "run", process is sharing gdb's terminal.
In this scenario, when you stop/resume both inferiors, you want GDB to
save/restore the terminal settings of inferior 2, the one that is
sharing GDB's terminal. I.e., you want inferior 2 to "own" the
terminal (in target_terminal::is_ours/target_terminal::is_inferior
sense).
Unfortunately, that's not what you get currently. Because GDB doesn't
know whether an attached inferior is actually sharing GDB's terminal,
it tries to save/restore its settings anyway, ignoring errors. In
this case, this is pointless, because inferior 1 is running on a
different terminal, but GDB doesn't know better.
And then, because it is only possible to have the terminal settings of
a single inferior be in effect at a time, or make one inferior/pgrp be
the terminal's foreground pgrp (aka, only one inferior can "own" the
terminal, ignoring fork children here), if GDB happens to try to
restore the terminal settings of inferior 1 first, then GDB never
restores the terminal settings of inferior 2.
This patch fixes that and a few things more along the way:
- Moves enum target_terminal::terminal_state out of the
target_terminal class (it's currently private) and makes it a
scoped enum so that it can be easily used elsewhere.
- Replaces the inflow.c:terminal_is_ours boolean with a
target_terminal_state variable. This allows distinguishing is_ours
and is_ours_for_output states. This allows finally making
child_terminal_ours_1 do something with its "output_only"
parameter.
- Makes each inferior have its own copy of the
is_ours/is_ours_for_output/is_inferior state.
- Adds a way for GDB to tell whether the inferior is sharing GDB's
terminal. Works best on Linux and Solaris; the fallback works just
as well as currently.
- With that, we can remove the inf->attach_flag tests from
child_terminal_inferior/child_terminal_ours.
- Currently target_ops.to_ours is responsible for both saving the
current inferior's terminal state, and restoring gdb's state.
Because each inferior has its own terminal state (possibly handled
by different targets in a multi-target world, even), we need to
split the inferior-saving part from the gdb-restoring part. The
patch adds a new target_ops.to_save_inferior target method for
that.
- Adds a new target_terminal::save_inferior() function, so that
sequences like:
scoped_restore_terminal_state save_state;
target_terminal::ours_for_output ();
... restore back inferiors that were
target_terminal_state::is_inferior before back to is_inferior, and
leaves inferiors that were is_ours alone.
- Along the way, this adds a default implementation of
target_pass_ctrlc to inflow.c (for inf-child.c), that handles
passing the Ctrl-C to a process running on GDB's terminal or to
some other process otherwise.
- Similarly, adds a new target default implementation of
target_interrupt, for the "interrupt" command. The current
implementation of this hook in inf-ptrace.c kills the whole process
group, but that's incorrect/undesirable because we may not be
attached to all processes in the process group. And also, it's
incorrect because inferior_process_group() doesn't really return
the inferior's real process group id if the inferior is not a
process group leader... This is the cause of PR gdb/13211 [1],
which this patch fixes. While at it, that target method's "ptid"
parameter is eliminated, because it's not really used.
- A new test is included that exercises and fixes PR gdb/13211, and
also fixes a GDB issue reported on stackoverflow that I ran into
while working on this [2]. The problem is similar to PR gdb/13211,
except that it also triggers with Ctrl-C. When debugging a daemon
(i.e., a process that disconnects from the controlling terminal and
is not a process group leader, then Ctrl-C doesn't work, you just
can't interrupt the inferior at all, resulting in a hung debug
session. The problem is that since the inferior is no longer
associated with gdb's session / controlling terminal, then trying
to put the inferior in the foreground fails. And so Ctrl-C never
reaches the inferior directly. pass_signal is only used when the
inferior is attached, but that is not the case here. This is fixed
by the new child_pass_ctrlc. Without the fix, the new
interrupt-daemon.exp testcase fails with timeout waiting for a
SIGINT that never arrives.
[1] PR gdb/13211 - Async / Process group and interrupt not working
https://sourceware.org/bugzilla/show_bug.cgi?id=13211
[2] GDB not reacting Ctrl-C when after fork() and setsid()
https://stackoverflow.com/questions/46101292/gdb-not-reacting-ctrl-c-when-after-fork-and-setsid
Note this patch does _not_ fix:
- PR gdb/14559 - The 'interrupt' command does not work if sigwait is in use
https://sourceware.org/bugzilla/show_bug.cgi?id=14559
- PR gdb/9425 - When using "sigwait" GDB doesn't trap SIGINT. Ctrl+C terminates program when should break gdb.
https://sourceware.org/bugzilla/show_bug.cgi?id=9425
The only way to fix that that I know of (without changing the kernel)
is to make GDB put inferiors in a separate session (create a
pseudo-tty master/slave pair, make the inferior run with the slave as
its terminal, and have gdb pump output/input on the master end).
gdb/ChangeLog:
2018-01-30 Pedro Alves <palves@redhat.com>
PR gdb/13211
* config.in, configure: Regenerate.
* configure.ac: Check for getpgid.
* go32-nat.c (go32_pass_ctrlc): New.
(go32_target): Install it.
* inf-child.c (inf_child_target): Install
child_terminal_save_inferior, child_pass_ctrlc and
child_interrupt.
* inf-ptrace.c (inf_ptrace_interrupt): Delete.
(inf_ptrace_target): No longer install it.
* infcmd.c (interrupt_target_1): Adjust.
* inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
(child_interrupt): Declare.
(inferior::terminal_state): New.
* inflow.c (struct terminal_info): Update comments.
(inferior_process_group): Delete.
(terminal_is_ours): Delete.
(gdb_tty_state): New.
(child_terminal_init): Adjust.
(is_gdb_terminal, sharing_input_terminal_1)
(sharing_input_terminal): New functions.
(child_terminal_inferior): Adjust. Use sharing_input_terminal.
Set the process's actual process group in the foreground if
possible. Handle is_ours_for_output/is_ours distinction. Don't
mark terminal as the inferior's if not sharing GDB's terminal.
Don't check attach_flag.
(child_terminal_ours_for_output, child_terminal_ours): Adjust to
pass down a target_terminal_state.
(child_terminal_save_inferior): New, factored out from ...
(child_terminal_ours_1): ... this. Handle
target_terminal_state::is_ours_for_output.
(child_interrupt, child_pass_ctrlc): New.
(inflow_inferior_exit): Clear the inferior's terminal_state.
(copy_terminal_info): Copy the inferior's terminal state.
(_initialize_inflow): Remove reference to terminal_is_ours.
* inflow.h (inferior_process_group): Delete.
* nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
* procfs.c (procfs_target): Don't install procfs_interrupt.
(procfs_interrupt): Delete.
* remote.c (remote_serial_quit_handler): Adjust.
(remote_interrupt): Remove ptid parameter. Adjust.
* target-delegates.c: Regenerate.
* target.c: Include "terminal.h".
(target_terminal::terminal_state): Rename to ...
(target_terminal::m_terminal_state): ... this.
(target_terminal::init): Adjust.
(target_terminal::inferior): Adjust to per-inferior
terminal_state.
(target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
(target_terminal::ours, target_terminal::ours_for_output): Use
target_terminal_is_ours_kind.
(target_interrupt): Remove ptid parameter. Adjust.
(default_target_pass_ctrlc): Adjust.
* target.h (target_ops::to_terminal_save_inferior): New field.
(target_ops::to_interrupt): Remove ptid_t parameter.
(target_interrupt): Remove ptid_t parameter. Update comment.
(target_pass_ctrlc): Update comment.
* target/target.h (target_terminal_state): New scoped enum,
factored out of ...
(target_terminal::terminal_state): ... here.
(target_terminal::inferior): Update comments.
(target_terminal::restore_inferior): New.
(target_terminal::is_inferior, target_terminal::is_ours)
(target_terminal::is_ours_for_output): Adjust.
(target_terminal::scoped_restore_terminal_state): Adjust to
rename, and call restore_inferior() instead of inferior().
(target_terminal::scoped_restore_terminal_state::m_state): Change
type.
(target_terminal::terminal_state): Rename to ...
(target_terminal::m_terminal_state): ... this and change type.
gdb/gdbserver/ChangeLog:
2018-01-30 Pedro Alves <palves@redhat.com>
PR gdb/13211
* target.c (target_terminal::terminal_state): Rename to ...
(target_terminal::m_terminal_state): ... this.
gdb/testsuite/ChangeLog:
2018-01-30 Pedro Alves <palves@redhat.com>
PR gdb/13211
* gdb.base/interrupt-daemon.c: New.
* gdb.base/interrupt-daemon.exp: New.
* gdb.multi/multi-term-settings.c: New.
* gdb.multi/multi-term-settings.exp: New.
2018-01-30 15:23:51 +01:00
|
|
|
|
2018-01-30 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/13211
|
|
|
|
|
|
* config.in, configure: Regenerate.
|
|
|
|
|
|
* configure.ac: Check for getpgid.
|
|
|
|
|
|
* go32-nat.c (go32_pass_ctrlc): New.
|
|
|
|
|
|
(go32_target): Install it.
|
|
|
|
|
|
* inf-child.c (inf_child_target): Install
|
|
|
|
|
|
child_terminal_save_inferior, child_pass_ctrlc and
|
|
|
|
|
|
child_interrupt.
|
|
|
|
|
|
* inf-ptrace.c (inf_ptrace_interrupt): Delete.
|
|
|
|
|
|
(inf_ptrace_target): No longer install it.
|
|
|
|
|
|
* infcmd.c (interrupt_target_1): Adjust.
|
|
|
|
|
|
* inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
|
|
|
|
|
|
(child_interrupt): Declare.
|
|
|
|
|
|
(inferior::terminal_state): New.
|
|
|
|
|
|
* inflow.c (struct terminal_info): Update comments.
|
|
|
|
|
|
(inferior_process_group): Delete.
|
|
|
|
|
|
(terminal_is_ours): Delete.
|
|
|
|
|
|
(gdb_tty_state): New.
|
|
|
|
|
|
(child_terminal_init): Adjust.
|
|
|
|
|
|
(is_gdb_terminal, sharing_input_terminal_1)
|
|
|
|
|
|
(sharing_input_terminal): New functions.
|
|
|
|
|
|
(child_terminal_inferior): Adjust. Use sharing_input_terminal.
|
|
|
|
|
|
Set the process's actual process group in the foreground if
|
|
|
|
|
|
possible. Handle is_ours_for_output/is_ours distinction. Don't
|
|
|
|
|
|
mark terminal as the inferior's if not sharing GDB's terminal.
|
|
|
|
|
|
Don't check attach_flag.
|
|
|
|
|
|
(child_terminal_ours_for_output, child_terminal_ours): Adjust to
|
|
|
|
|
|
pass down a target_terminal_state.
|
|
|
|
|
|
(child_terminal_save_inferior): New, factored out from ...
|
|
|
|
|
|
(child_terminal_ours_1): ... this. Handle
|
|
|
|
|
|
target_terminal_state::is_ours_for_output.
|
|
|
|
|
|
(child_interrupt, child_pass_ctrlc): New.
|
|
|
|
|
|
(inflow_inferior_exit): Clear the inferior's terminal_state.
|
|
|
|
|
|
(copy_terminal_info): Copy the inferior's terminal state.
|
|
|
|
|
|
(_initialize_inflow): Remove reference to terminal_is_ours.
|
|
|
|
|
|
* inflow.h (inferior_process_group): Delete.
|
|
|
|
|
|
* nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
|
|
|
|
|
|
* procfs.c (procfs_target): Don't install procfs_interrupt.
|
|
|
|
|
|
(procfs_interrupt): Delete.
|
|
|
|
|
|
* remote.c (remote_serial_quit_handler): Adjust.
|
|
|
|
|
|
(remote_interrupt): Remove ptid parameter. Adjust.
|
|
|
|
|
|
* target-delegates.c: Regenerate.
|
|
|
|
|
|
* target.c: Include "terminal.h".
|
|
|
|
|
|
(target_terminal::terminal_state): Rename to ...
|
|
|
|
|
|
(target_terminal::m_terminal_state): ... this.
|
|
|
|
|
|
(target_terminal::init): Adjust.
|
|
|
|
|
|
(target_terminal::inferior): Adjust to per-inferior
|
|
|
|
|
|
terminal_state.
|
|
|
|
|
|
(target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
|
|
|
|
|
|
(target_terminal::ours, target_terminal::ours_for_output): Use
|
|
|
|
|
|
target_terminal_is_ours_kind.
|
|
|
|
|
|
(target_interrupt): Remove ptid parameter. Adjust.
|
|
|
|
|
|
(default_target_pass_ctrlc): Adjust.
|
|
|
|
|
|
* target.h (target_ops::to_terminal_save_inferior): New field.
|
|
|
|
|
|
(target_ops::to_interrupt): Remove ptid_t parameter.
|
|
|
|
|
|
(target_interrupt): Remove ptid_t parameter. Update comment.
|
|
|
|
|
|
(target_pass_ctrlc): Update comment.
|
|
|
|
|
|
* target/target.h (target_terminal_state): New scoped enum,
|
|
|
|
|
|
factored out of ...
|
|
|
|
|
|
(target_terminal::terminal_state): ... here.
|
|
|
|
|
|
(target_terminal::inferior): Update comments.
|
|
|
|
|
|
(target_terminal::restore_inferior): New.
|
|
|
|
|
|
(target_terminal::is_inferior, target_terminal::is_ours)
|
|
|
|
|
|
(target_terminal::is_ours_for_output): Adjust.
|
|
|
|
|
|
(target_terminal::scoped_restore_terminal_state): Adjust to
|
|
|
|
|
|
rename, and call restore_inferior() instead of inferior().
|
|
|
|
|
|
(target_terminal::scoped_restore_terminal_state::m_state): Change
|
|
|
|
|
|
type.
|
|
|
|
|
|
(target_terminal::terminal_state): Rename to ...
|
|
|
|
|
|
(target_terminal::m_terminal_state): ... this and change type.
|
|
|
|
|
|
|
2018-01-30 15:23:51 +01:00
|
|
|
|
2018-01-30 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* linux-nat.c (wait_for_signal): New function.
|
|
|
|
|
|
(wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
|
|
|
|
|
|
directly.
|
|
|
|
|
|
(async_terminal_is_ours)
|
|
|
|
|
|
(linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
|
|
|
|
|
|
(linux_nat_add_target): Don't override
|
|
|
|
|
|
to_terminal_inferior/to_terminal_ours.
|
|
|
|
|
|
|
Don't call "detach_inferior" on "remote_follow_fork"
This patch fixes a regression that has been introduced by:
commit bc09b0c14fb713a9aec25e09b78499f3bc2441b5
Date: Fri Jan 19 11:48:11 2018 -0500
Make linux_nat_detach/thread_db_detach use the inferior parameter
It is possible to trigger this failure with gdb.base/foll-fork.exp (in
which case a bunch of ERROR's will be printed), but one can also use
the test below.
Consider the following example program:
#include <unistd.h>
int
main (int argc, char *argv[])
{
fork ();
return 0;
}
When running it under gdbserver:
# ./gdb/gdbserver/gdbserver --multi --once :2345
And debugging it under GDB, we see a segmentation fault:
# ./gdb/gdb -q -batch -ex 'set remote exec-file ./a.out' -ex 'tar extended-remote :2345' -ex r ./a.out
Starting program:
...
[Detaching after fork from child process 16102.]
Segmentation fault (core dumped)
The problem happens on inferior.c:detach_inferior:
void
detach_inferior (inferior *inf)
{
/* Save the pid, since exit_inferior_1 will reset it. */
int pid = inf->pid;
^^^^^^^^^
exit_inferior_1 (inf, 0);
if (print_inferior_events)
printf_unfiltered (_("[Inferior %d detached]\n"), pid);
}
When this code is called from remote.c:remote_follow_fork, the PID is
valid but there is no 'inferior' associated with it, which means that
'inf == NULL'.
The proper fix here is to not call "detach_inferior" when doing remote
follow-fork, because we don't have an inferior to detach on the host
side.
Before bc09b0c1, that call was already a nop (exit_inferior_1 bails
out early if you pass it a NULL inferior), except that it printed
"Inferior PID detached" when "set print inferior-events" is on. Since
native debugging doesn't call detach_inferior in this case, removing
the call from remote aligns remote debugging output with native
debugging output further.
This has been regtested using BuildBot and no regressions were found.
gdb/ChangeLog:
2018-01-29 Sergio Durigan Junior <sergiodj@redhat.com>
* remote.c (remote_follow_fork): Don't call "detach_inferior".
2018-01-29 18:29:21 +01:00
|
|
|
|
2018-01-29 Sergio Durigan Junior <sergiodj@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_follow_fork): Don't call "detach_inferior".
|
|
|
|
|
|
|
2018-01-28 18:07:30 +01:00
|
|
|
|
2018-01-28 Simon Marchi <simon.marchi@ericsson.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (free_dwo_files): Add forward-declaration.
|
|
|
|
|
|
(dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
|
|
|
|
|
|
dwarf2_per_objfile_free here.
|
|
|
|
|
|
(dwarf2_per_objfile_free): Remove.
|
|
|
|
|
|
(_initialize_dwarf2_read): Don't register
|
|
|
|
|
|
dwarf2_per_objfile_free as a registry cleanup.
|
|
|
|
|
|
|
2018-01-27 17:34:46 +01:00
|
|
|
|
2018-01-27 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
|
|
|
|
|
|
Avoid compilation errors in MinGW native builds
|
|
|
|
|
|
|
|
|
|
|
|
The error is triggered by including python-internal.h, and the
|
|
|
|
|
|
error message is:
|
|
|
|
|
|
|
|
|
|
|
|
In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
|
|
|
|
|
|
from build-gnulib/import/math.h:27,
|
|
|
|
|
|
from d:/usr/Python26/include/pyport.h:235,
|
|
|
|
|
|
from d:/usr/Python26/include/Python.h:58,
|
|
|
|
|
|
from python/python-internal.h:94,
|
|
|
|
|
|
from python/py-arch.c:24:
|
|
|
|
|
|
d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
|
|
|
|
|
|
using ::hypot;
|
|
|
|
|
|
^~~~~
|
|
|
|
|
|
|
|
|
|
|
|
This happens because Python headers define 'hypot' to expand t
|
|
|
|
|
|
'_hypot' in the Windows builds.
|
|
|
|
|
|
* python/python-internal.h (_hypot) [__MINGW32__]: Define back to
|
|
|
|
|
|
'hypoth'. This avoids a compilation error.
|
|
|
|
|
|
|
2018-01-26 15:34:52 +01:00
|
|
|
|
2018-01-26 Alan Hayward <alan.hayward@arm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS (Write After Approval): Fix ordering.
|
|
|
|
|
|
|
2018-01-26 15:34:52 +01:00
|
|
|
|
2018-01-26 Alan Hayward <alan.hayward@arm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS (Write After Approval): Add Alan Hayward.
|
|
|
|
|
|
|
2018-01-24 05:52:17 +01:00
|
|
|
|
2018-01-26 Alan Modra <amodra@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
|
|
|
|
|
|
(powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
|
|
|
|
|
|
Remove nop. Make const. Comment.
|
|
|
|
|
|
(powerpc32_plt_stub_so_2): New.
|
|
|
|
|
|
(POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
|
|
|
|
|
|
Correct count. Update uses.
|
|
|
|
|
|
(ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
|
|
|
|
|
|
Move common code reading PLT entry word. Correct
|
|
|
|
|
|
powerpc32_plt_stub PLT address calculation.
|
|
|
|
|
|
* ppc64-tdep.c (ppc64_standard_linkage1): Make const.
|
|
|
|
|
|
(ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
|
|
|
|
|
|
(ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
|
|
|
|
|
|
(ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
|
|
|
|
|
|
(ppc64_standard_linkage8): Likewise.
|
|
|
|
|
|
* rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
|
|
|
|
|
|
Correct insns description.
|
|
|
|
|
|
* ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
|
|
|
|
|
|
|
Fix GCC PR83906 - [8 Regression] Random FAIL: libstdc++-prettyprinters/80276.cc whatis p4
GCC PR83906 [1] is about a GCC/libstdc++ GDB/Python type printer
testcase failing randomly, as shown by running (in libstdc++'s
testsuite):
make check RUNTESTFLAGS=prettyprinters.exp=80276.cc
in a loop. Sometimes you get this:
FAIL: libstdc++-prettyprinters/80276.cc whatis p4
I.e., this:
type = std::unique_ptr<std::vector<std::unique_ptr<std::list<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >>[]>>[99]>
instead of this:
type = std::unique_ptr<std::vector<std::unique_ptr<std::list<std::string>[]>>[99]>
Jonathan Wakely tracked it on the printer side to this bit in
libstdc++'s type printer:
if self.type_obj == type_obj:
return strip_inline_namespaces(self.name)
This assumes the two types resolve to the same gdb.Type but some times
the comparison unexpectedly fails.
Running the testcase manually under Valgrind finds the problem in GDB:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
==6118== Conditional jump or move depends on uninitialised value(s)
==6118== at 0x4C35CB0: bcmp (vg_replace_strmem.c:1100)
==6118== by 0x6F773A: check_types_equal(type*, type*, VEC_type_equality_entry_d**) (gdbtypes.c:3515)
==6118== by 0x6F7B00: check_types_worklist(VEC_type_equality_entry_d**, bcache*) (gdbtypes.c:3618)
==6118== by 0x6F7C03: types_deeply_equal(type*, type*) (gdbtypes.c:3655)
==6118== by 0x4D5B06: typy_richcompare(_object*, _object*, int) (py-type.c:1007)
==6118== by 0x63D7E6C: PyObject_RichCompare (object.c:961)
==6118== by 0x646EAEC: PyEval_EvalFrameEx (ceval.c:4960)
==6118== by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
==6118== by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
==6118== by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
==6118== by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
==6118== by 0x646DC08: PyEval_EvalFrameEx (ceval.c:4519)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
That "bcmp" call is really a memcmp call in check_types_equal. The
problem is that gdb is memcmp'ing two objects that are equal in value:
(top-gdb) p *TYPE_RANGE_DATA (type1)
$1 = {low = {kind = PROP_CONST, data = {const_val = 0, baton = 0x0}}, high = {kind = PROP_CONST, data = {const_val = 15, baton = 0xf}}, flag_upper_bound_is_count = 0,
flag_bound_evaluated = 0}
(top-gdb) p *TYPE_RANGE_DATA (type2)
$2 = {low = {kind = PROP_CONST, data = {const_val = 0, baton = 0x0}}, high = {kind = PROP_CONST, data = {const_val = 15, baton = 0xf}}, flag_upper_bound_is_count = 0,
flag_bound_evaluated = 0}
but differ in padding. Notice the 4-byte hole:
(top-gdb) ptype /o range_bounds
/* offset | size */ type = struct range_bounds {
/* 0 | 16 */ struct dynamic_prop {
/* 0 | 4 */ dynamic_prop_kind kind;
/* XXX 4-byte hole */
/* 8 | 8 */ union dynamic_prop_data {
/* 8 */ LONGEST const_val;
/* 8 */ void *baton;
/* total size (bytes): 8 */
} data;
which is filled with garbage:
(top-gdb) x /40bx TYPE_RANGE_DATA (type1)
0x2fa7ea0: 0x01 0x00 0x00 0x00 0x43 0x01 0x00 0x00
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
0x2fa7ea8: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x2fa7eb0: 0x01 0x00 0x00 0x00 0xfe 0x7f 0x00 0x00
0x2fa7eb8: 0x0f 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x2fa7ec0: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
(top-gdb) x /40bx TYPE_RANGE_DATA (type2)
0x20379b0: 0x01 0x00 0x00 0x00 0xfe 0x7f 0x00 0x00
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
0x20379b8: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x20379c0: 0x01 0x00 0x00 0x00 0xfe 0x7f 0x00 0x00
0x20379c8: 0x0f 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x20379d0: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
(top-gdb) p memcmp (TYPE_RANGE_DATA (type1), TYPE_RANGE_DATA (type2), sizeof (*TYPE_RANGE_DATA (type1)))
$3 = -187
In some cases objects of type range_bounds are memset when allocated,
but then their dynamic_prop low/high fields are copied over from some
template dynamic_prop object that wasn't memset. E.g.,
create_static_range_type's low/high locals are left with garbage in
the padding, and then that padding is copied over to the range_bounds
object's low/high fields.
At first, I considered making sure to always memset range_bounds
objects, thinking that maybe type objects are being put in some bcache
instance somewhere. But then I hacked bcache/bcache_full to poison
non-pod types, and made dynamic_prop a non-pod, and GDB still
compiled.
So given that, it seems safest to not assume padding will always be
memset, and instead treat them as regular value types, implementing
(in)equality operators and using those instead of memcmp.
This fixes the random FAILs in GCC's testcase.
[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83906
gdb/ChangeLog:
2018-01-24 Pedro Alves <palves@redhat.com>
GCC PR libstdc++/83906
* gdbtypes.c (operator==(const dynamic_prop &,
const dynamic_prop &)): New.
(operator==(const range_bounds &, const range_bounds &)): New.
(check_types_equal): Use them instead of memcmp.
* gdbtypes.h (operator==(const dynamic_prop &,
const dynamic_prop &)): Declare.
(operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
(operator==(const range_bounds &, const range_bounds &)): Declare.
(operator!=(const range_bounds &, const range_bounds &)): Declare.
2018-01-24 18:22:05 +01:00
|
|
|
|
2018-01-24 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
GCC PR libstdc++/83906
|
|
|
|
|
|
* gdbtypes.c (operator==(const dynamic_prop &,
|
|
|
|
|
|
const dynamic_prop &)): New.
|
|
|
|
|
|
(operator==(const range_bounds &, const range_bounds &)): New.
|
|
|
|
|
|
(check_types_equal): Use them instead of memcmp.
|
|
|
|
|
|
* gdbtypes.h (operator==(const dynamic_prop &,
|
|
|
|
|
|
const dynamic_prop &)): Declare.
|
|
|
|
|
|
(operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
|
|
|
|
|
|
(operator==(const range_bounds &, const range_bounds &)): Declare.
|
|
|
|
|
|
(operator!=(const range_bounds &, const range_bounds &)): Declare.
|
|
|
|
|
|
|
s390: Move record-replay to s390-tdep.c
Record-replay is independent of the OS. So it can be moved to the common
s390 code without problem.
gdb/ChangeLog:
* s390-linux-tdep.c (s390_record_address_mask)
(s390_record_calc_disp_common, s390_record_calc_disp)
(s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
(s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
(s390_process_record): Move to s390-tdep.c.
(s390_linux_init_abi_any): Adjust.
* s390-tdep.c (s390_record_address_mask)
(s390_record_calc_disp_common, s390_record_calc_disp)
(s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
(s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
(s390_process_record): Moved from s390-linux-tdep.c
(s390_gdbarch_init): Adjust.
2018-01-23 13:37:44 +01:00
|
|
|
|
2018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* s390-linux-tdep.c (s390_record_address_mask)
|
|
|
|
|
|
(s390_record_calc_disp_common, s390_record_calc_disp)
|
|
|
|
|
|
(s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
|
|
|
|
|
|
(s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
|
|
|
|
|
|
(s390_process_record): Move to s390-tdep.c.
|
|
|
|
|
|
(s390_linux_init_abi_any): Adjust.
|
|
|
|
|
|
* s390-tdep.c (s390_record_address_mask)
|
|
|
|
|
|
(s390_record_calc_disp_common, s390_record_calc_disp)
|
|
|
|
|
|
(s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
|
|
|
|
|
|
(s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
|
|
|
|
|
|
(s390_process_record): Moved from s390-linux-tdep.c
|
|
|
|
|
|
(s390_gdbarch_init): Adjust.
|
|
|
|
|
|
|
s390: Split up s390-linux-tdep.c into two files
Currently all target dependent code for s390 is in one file,
s390-linux-tdep.c. This includes code general for the architecture as
well as code specific for uses in GNU/Linux (user space). Up until now
this was OK as GNU/Linux was the only supported OS. In preparation to
support the new Linux kernel 'OS' split up the existing s390 code into a
general s390-tdep and a GNU/Linux-specific s390-linux-tdep.
Note: The record-replay feature will be moved in a separate patch. This
is simply due to the fact that the combined patch would be too large for
the mailing list. This requires setting the process_record hook during
OSABI init to keep the code bisectable. The patch moving record-replay
cleans up this hack.
gdb/ChangeLog:
* s390-linux-nat.c (s390-tdep.h): New include.
* Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
(HFILES_NO_SRCDIR): Add s390-tdep.h.
(ALLDEPFILES): Add s390-tdep.c.
* configure.tgt (s390*-*-linux*): Add s390-tdep.o.
* s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
* s390-tdep.h: ...this. New file.
* s390-linux-tdep.c (s390-tdep.h): New include.
(_initialize_s390_tdep): Rename to...
(_initialize_s390_linux_tdep): ...this and adjust.
(s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
(enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
s390-tdep.h.
(s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
(is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
(s390_is_partial_instruction, s390_software_single_step)
(is_non_branch_ril, s390_displaced_step_copy_insn)
(s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
(s390_prologue_data, s390_addr, s390_store, s390_load)
(s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
(s390_register_call_saved, s390_guess_tracepoint_registers)
(s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
(regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
(s390_pseudo_register_name, s390_pseudo_register_type)
(s390_pseudo_register_read, s390_pseudo_register_write)
(s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
(s390_ax_pseudo_register_push_stack, s390_gen_return_address)
(s390_addr_bits_remove, s390_address_class_type_flags)
(s390_address_class_type_flags_to_name)
(s390_address_class_name_to_type_flags, s390_effective_inner_type)
(s390_function_arg_float, s390_function_arg_vector)
(is_power_of_two, s390_function_arg_integer, s390_arg_state)
(s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
(s390_frame_align, s390_register_return_value, s390_return_value)
(s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
(s390_unwind_pseudo_register, s390_adjust_frame_regnum)
(s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
(s390_trad_frame_prev_register, s390_unwind_cache)
(s390_prologue_frame_unwind_cache)
(s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
(s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
(s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
(s390_stub_frame_this_id, s390_stub_frame_prev_register)
(s390_stub_frame_sniffer, s390_stub_frame_unwind)
(s390_frame_base_address, s390_local_base_address)
(s390_frame_base, s390_gcc_target_options)
(s390_gnu_triplet_regexp, s390_stap_is_single_operand)
(s390_validate_reg_range, s390_tdesc_valid)
(s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
* s390-tdep.c: ...this. New file.
2018-01-23 13:37:43 +01:00
|
|
|
|
2018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* s390-linux-nat.c (s390-tdep.h): New include.
|
|
|
|
|
|
* Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
|
|
|
|
|
|
(HFILES_NO_SRCDIR): Add s390-tdep.h.
|
|
|
|
|
|
(ALLDEPFILES): Add s390-tdep.c.
|
|
|
|
|
|
* configure.tgt (s390*-*-linux*): Add s390-tdep.o.
|
|
|
|
|
|
* s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
|
|
|
|
|
|
* s390-tdep.h: ...this. New file.
|
|
|
|
|
|
* s390-linux-tdep.c (s390-tdep.h): New include.
|
|
|
|
|
|
(_initialize_s390_tdep): Rename to...
|
|
|
|
|
|
(_initialize_s390_linux_tdep): ...this and adjust.
|
|
|
|
|
|
(s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
|
|
|
|
|
|
(enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
|
|
|
|
|
|
s390-tdep.h.
|
|
|
|
|
|
(s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
|
|
|
|
|
|
(is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
|
|
|
|
|
|
(s390_is_partial_instruction, s390_software_single_step)
|
|
|
|
|
|
(is_non_branch_ril, s390_displaced_step_copy_insn)
|
|
|
|
|
|
(s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
|
|
|
|
|
|
(s390_prologue_data, s390_addr, s390_store, s390_load)
|
|
|
|
|
|
(s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
|
|
|
|
|
|
(s390_register_call_saved, s390_guess_tracepoint_registers)
|
|
|
|
|
|
(s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
|
|
|
|
|
|
(regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
|
|
|
|
|
|
(s390_pseudo_register_name, s390_pseudo_register_type)
|
|
|
|
|
|
(s390_pseudo_register_read, s390_pseudo_register_write)
|
|
|
|
|
|
(s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
|
|
|
|
|
|
(s390_ax_pseudo_register_push_stack, s390_gen_return_address)
|
|
|
|
|
|
(s390_addr_bits_remove, s390_address_class_type_flags)
|
|
|
|
|
|
(s390_address_class_type_flags_to_name)
|
|
|
|
|
|
(s390_address_class_name_to_type_flags, s390_effective_inner_type)
|
|
|
|
|
|
(s390_function_arg_float, s390_function_arg_vector)
|
|
|
|
|
|
(is_power_of_two, s390_function_arg_integer, s390_arg_state)
|
|
|
|
|
|
(s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
|
|
|
|
|
|
(s390_frame_align, s390_register_return_value, s390_return_value)
|
|
|
|
|
|
(s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
|
|
|
|
|
|
(s390_unwind_pseudo_register, s390_adjust_frame_regnum)
|
|
|
|
|
|
(s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
|
|
|
|
|
|
(s390_trad_frame_prev_register, s390_unwind_cache)
|
|
|
|
|
|
(s390_prologue_frame_unwind_cache)
|
|
|
|
|
|
(s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
|
|
|
|
|
|
(s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
|
|
|
|
|
|
(s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
|
|
|
|
|
|
(s390_stub_frame_this_id, s390_stub_frame_prev_register)
|
|
|
|
|
|
(s390_stub_frame_sniffer, s390_stub_frame_unwind)
|
|
|
|
|
|
(s390_frame_base_address, s390_local_base_address)
|
|
|
|
|
|
(s390_frame_base, s390_gcc_target_options)
|
|
|
|
|
|
(s390_gnu_triplet_regexp, s390_stap_is_single_operand)
|
|
|
|
|
|
(s390_validate_reg_range, s390_tdesc_valid)
|
|
|
|
|
|
(s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
|
|
|
|
|
|
* s390-tdep.c: ...this. New file.
|
|
|
|
|
|
|
2018-01-23 13:37:43 +01:00
|
|
|
|
2018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
|
|
|
|
|
|
(s390_process_record, s390_gdbarch_tdep_alloc)
|
|
|
|
|
|
(s390_linux_init_abi_any): Use/set new hook.
|
|
|
|
|
|
|
2018-01-23 13:37:43 +01:00
|
|
|
|
2018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* s390-linux-tdep.c (osabi.h): New include.
|
|
|
|
|
|
(s390_linux_init_abi_31, s390_linux_init_abi_64)
|
|
|
|
|
|
(s390_linux_init_abi_any): New functions.
|
|
|
|
|
|
(s390_gdbarch_init, _initialize_s390_tdep): Adjust.
|
|
|
|
|
|
|
2018-01-23 13:37:43 +01:00
|
|
|
|
2018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
|
|
|
|
|
|
tdesc_has_registers check
|
|
|
|
|
|
|
2018-01-23 13:37:42 +01:00
|
|
|
|
2018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* s390-linux-tdep.c (s390_tdesc_valid): New function.
|
|
|
|
|
|
(s390_validate_reg_range): New macro.
|
|
|
|
|
|
(s390_gdbarch_init): Adjust.
|
|
|
|
|
|
|
2018-01-23 13:37:42 +01:00
|
|
|
|
2018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
|
|
|
|
|
|
(s390_gdbarch_tdep_alloc): Adjust.
|
|
|
|
|
|
(s390_gdbarch_init): Adjust.
|
|
|
|
|
|
|
2018-01-23 13:37:42 +01:00
|
|
|
|
2018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
|
|
|
|
|
|
<have_tdb>: Change type to bool.
|
|
|
|
|
|
(s390_gdbarch_tdep_alloc): Adjust.
|
|
|
|
|
|
(s390_gdbarch_init): Adjust.
|
|
|
|
|
|
|
2018-01-23 13:37:41 +01:00
|
|
|
|
2018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
|
|
|
|
|
|
(gdbarch_tdep) <have_upper, have_vx>: New fields.
|
|
|
|
|
|
(s390_gdbarch_tdep_alloc): New function.
|
|
|
|
|
|
(s390_gdbarch_init): Allocate tdep at start and use its fields
|
|
|
|
|
|
instead of separate variables.
|
|
|
|
|
|
|
2018-01-23 13:37:41 +01:00
|
|
|
|
2018-01-23 Philipp Rudo <prudo@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
|
|
|
|
|
|
when looking for cached gdbarch and add comment for remaining.
|
|
|
|
|
|
|
Fix segfault with 'set print object on' + 'whatis <struct>' & co
Compiling GDB with a recent GCC exposes a problem:
../../gdb/typeprint.c: In function 'void whatis_exp(const char*, int)':
../../gdb/typeprint.c:515:12: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
real_type = value_rtti_type (val, &full, &top, &using_enc);
~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The warning is correct. There are indeed code paths that use
uninitialized 'val', leading to crashes. Inside the
value_rtti_indirect_type/value_rtti_type calls here in whatis_exp:
if (opts.objectprint)
{
if (((TYPE_CODE (type) == TYPE_CODE_PTR) || TYPE_IS_REFERENCE (type))
&& (TYPE_CODE (TYPE_TARGET_TYPE (type)) == TYPE_CODE_STRUCT))
real_type = value_rtti_indirect_type (val, &full, &top, &using_enc);
else if (TYPE_CODE (type) == TYPE_CODE_STRUCT)
real_type = value_rtti_type (val, &full, &top, &using_enc);
}
We reach those calls above with "set print object on", and then with
any of:
(gdb) whatis struct some_structure_type
(gdb) whatis struct some_structure_type *
(gdb) whatis struct some_structure_type &
because "whatis" with a type argument enters this branch:
/* The behavior of "whatis" depends on whether the user
expression names a type directly, or a language expression
(including variable names). If the former, then "whatis"
strips one level of typedefs, only. If an expression,
"whatis" prints the type of the expression without stripping
any typedef level. "ptype" always strips all levels of
typedefs. */
if (show == -1 && expr->elts[0].opcode == OP_TYPE)
{
which does not initialize VAL. Trying the above triggers crashes like
this:
(gdb) set print object on
(gdb) whatis some_structure_type
Thread 1 "gdb" received signal SIGSEGV, Segmentation fault.
0x00000000005dda90 in check_typedef (type=0x6120736573756170) at src/gdb/gdbtypes.c:2388
2388 int instance_flags = TYPE_INSTANCE_FLAGS (type);
...
This is a regression caused by a recent-ish refactoring of the code on
'whatis_exp', introduced by:
commit c973d0aa4a2c737ab527ae44a617f1c357e07364
Date: Mon Aug 21 11:34:32 2017 +0100
Fix type casts losing typedefs and reimplement "whatis" typedef stripping
Fix this by setting VAL to NULL in the "whatis TYPE" case, and
skipping fetching the dynamic type if there's no value to fetch it
from.
New tests included.
gdb/ChangeLog:
2018-01-22 Pedro Alves <palves@redhat.com>
Sergio Durigan Junior <sergiodj@redhat.com>
* typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
case.
gdb/testsuite/ChangeLog:
2018-01-22 Pedro Alves <palves@redhat.com>
Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.base/whatis.exp: Add tests for 'set print object on' +
'whatis <struct>' 'whatis <struct> *' and 'whatis <struct> &'.
2018-01-22 18:33:13 +01:00
|
|
|
|
2018-01-22 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
Sergio Durigan Junior <sergiodj@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
|
|
|
|
|
|
case.
|
|
|
|
|
|
|
2018-01-22 16:38:09 +01:00
|
|
|
|
2018-01-22 Maciej W. Rozycki <macro@mips.com>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS: Update my company e-mail address.
|
|
|
|
|
|
|
2018-01-22 12:02:49 +01:00
|
|
|
|
2018-01-22 Yao Qi <yao.qi@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* regcache.c (cooked_write_test): New function.
|
|
|
|
|
|
(_initialize_regcache): Register the test.
|
|
|
|
|
|
|
2018-01-22 12:02:49 +01:00
|
|
|
|
2018-01-22 Yao Qi <yao.qi@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* ia64-tdep.c (ia64_pseudo_register_read): Call
|
|
|
|
|
|
regcache->cooked_read instead of regcache_cooked_read_unsigned.
|
|
|
|
|
|
* m32c-tdep.c (m32c_cat_read): Likewise.
|
|
|
|
|
|
(m32c_r3r2r1r0_read): Likewise.
|
|
|
|
|
|
* m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
|
|
|
|
|
|
* xtensa-tdep.c (xtensa_register_read_masked): Likewise.
|
|
|
|
|
|
|
2018-01-22 12:02:49 +01:00
|
|
|
|
2018-01-22 Yao Qi <yao.qi@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
|
|
|
|
|
|
method raw_read instead of regcache_raw_read.
|
|
|
|
|
|
* amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
|
|
|
|
|
|
* arm-tdep.c (arm_neon_quad_read): Likewise.
|
|
|
|
|
|
* avr-tdep.c (avr_pseudo_register_read): Likewise.
|
|
|
|
|
|
* bfin-tdep.c (bfin_pseudo_register_read): Likewise.
|
|
|
|
|
|
* frv-tdep.c (frv_pseudo_register_read): Likewise.
|
|
|
|
|
|
* h8300-tdep.c (h8300_pseudo_register_read): Likewise.
|
|
|
|
|
|
* i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
|
|
|
|
|
|
(i386_pseudo_register_read_into_value): Likewise.
|
|
|
|
|
|
* mep-tdep.c (mep_pseudo_cr32_read): Likewise.
|
|
|
|
|
|
* msp430-tdep.c (msp430_pseudo_register_read): Likewise.
|
|
|
|
|
|
* nds32-tdep.c (nds32_pseudo_register_read): Likewise.
|
|
|
|
|
|
* rl78-tdep.c (rl78_pseudo_register_read): Likewise.
|
|
|
|
|
|
* s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
|
|
|
|
|
|
* sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
|
|
|
|
|
|
* sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
|
|
|
|
|
|
* spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
|
|
|
|
|
|
* xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
|
|
|
|
|
|
|
2018-01-22 12:02:49 +01:00
|
|
|
|
2018-01-22 Yao Qi <yao.qi@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
|
|
|
|
|
|
* configure.tgt: Remove target mt.
|
|
|
|
|
|
* mt-tdep.c: Remove.
|
|
|
|
|
|
* regcache.c (cooked_read_test): Remove the check for mt.
|
|
|
|
|
|
|
2018-01-22 12:02:48 +01:00
|
|
|
|
2018-01-22 Yao Qi <yao.qi@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* jit.c (jit_frame_prev_register): Call regcache::cooked_read
|
|
|
|
|
|
instead of gdbarch_pseudo_register_read_value.
|
|
|
|
|
|
|
2018-01-22 05:23:34 +01:00
|
|
|
|
2018-01-22 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (need_gnat_info): Return nonzero if the cu's
|
|
|
|
|
|
language is Ada.
|
|
|
|
|
|
|
wrong line number in breakpoint location
Consider the following situation, where we have one file containing...
$ cat -n body.inc
1 i = i + 1;
... we include that file from some code, like so:
$ cat -n cat -n small.c
[...]
17 int
18 next (int i)
19 {
20 #include "body.inc"
21 return i;
22 }
When trying to insert a breakpoint on line 18, for instance:
(gdb) b small.c:18
Breakpoint 1 at 0x40049f: file body.inc, line 18.
^^
||
Here, the issue is that GDB reports the breakpoint to be in file
body.inc, which is true, but with the line number that corresponding
to the user-requested location, which is not correct.
Although the simple reproducer may look slightly artificial,
the above is simply one way to reproduce the same issue observed
when trying to insert a breakpoint on a function provided in
a .h files and then subsequently inlined in a C file.
What happens is the following:
1. We resolve the small.c:18 linespec into a symtab_and_line which
has "small.c" and 18 as the symtab and line number.
2. Next, we call skip_prologue_sal, which calculates the PC
past the prologue, and updates the symtab_and_line: PC,
but also symtab (now body.inc) and the new line (now 1).
3. However, right after that, we do:
/* Make sure the line matches the request, not what was
found. */
intermediate_results.sals[i].line = val.line;
We should either restore both symtab and line, or leave the actual
line to match the actual symtab. This patch chose the latter.
This introduces a few changes in a few tests, which required some
updates, but looking at those change, I believe them to be expected.
gdb/ChangeLog:
* linespec.c (create_sals_line_offset): Remove code that preserved
the symtab_and_line's line number.
gdb/testsuite/ChangeLog:
* gdb.base/break-include.c, gdb.base/break-include.inc,
gdb.base/break-include.exp: New files.
* gdb.base/ending-run.exp: Minor adaptations due to the breakpoint's
line number now being the actual line number where the breakpoint
was inserted.
* gdb.mi/mi-break.exp: Likewise.
* gdb.mi/mi-reverse.exp: Likewise.
* gdb.mi/mi-simplerun.exp: Ditto.
Tested on x86_64-linux.
2018-01-22 05:14:50 +01:00
|
|
|
|
2018-01-22 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* linespec.c (create_sals_line_offset): Remove code that preserved
|
|
|
|
|
|
the symtab_and_line's line number.
|
|
|
|
|
|
|
2017-10-19 12:27:48 +02:00
|
|
|
|
2018-01-21 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* varobj.c (varobj_create): Don't set valid_block when creating a
|
|
|
|
|
|
floating varobj.
|
|
|
|
|
|
|
2017-10-19 11:59:22 +02:00
|
|
|
|
2018-01-21 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* varobj.c (varobj_create): Remove out of date comment.
|
|
|
|
|
|
|
gdb: PR mi/20395: Fix -var-update for registers in frames 1 and up
This patch fixes a problem with using the MI -var-update command
to access the values of registers in frames other than the current
frame. The patch includes a test that demonstrates the problem:
* run so there are several frames on the stack
* create a fixed varobj for $pc in each frame, #'s 1 and above
* step one instruction, to modify the value of $pc
* call -var-update for each of the previously created varobjs
to verify that they are not reported as having changed.
Without the patch, the -var-update command reported that $pc for all
frames 1 and above had changed to the value of $pc in frame 0.
A varobj is created as either fixed, the expression is evaluated within
the context of a specific frame, or floating, the expression is
evaluated within the current frame, whatever that may be.
When a varobj is created by -var-create we set two fields of the varobj
to track the context in which the varobj was created, these two fields
are varobj->root->frame and var->root->valid_block.
If a varobj is of type fixed, then, when we subsequently try to
reevaluate the expression associated with the varobj we must determine
if the original frame (and block) is still available, if it is not then
the varobj can no longer be evaluated.
The problem is that for register expressions varobj->root->valid_block
is not set correctly. This block tracking is done using the global
'innermost_block' which is set in the various parser files (for example
c-exp.y). However, this is not set for register expressions.
The fix then seems like it should be to just update the innermost block
when parsing register expressions, however, that solution causes several
test regressions.
The problem is that in some cases we rely on the expression parsing
code not updating the innermost block for registers, one example is
when we parse the expression for a 'display' command. The display
commands treats registers like floating varobjs, but symbols are
treated like fixed varobjs. So 'display $reg_name' will always show
the value of '$reg_name' even as the user moves from frame to frame,
while 'display my_variable' will only show 'my_variable' while it is
in the current frame and/or block, when the user moves to a new frame
and/or block (even one with a different 'my_variable' in) then the
display of 'my_variable' stops. For the case of 'display', without
the option to force fixed or floating expressions, the current
behaviour is probably the best choice. For the varobj system though,
we can choose between floating and fixed, and we should try to make
this work for registers.
There's only one existing test case that needs to be updated, in that
test a fixed varobj is created using a register, the MI output now
include the thread-id in which the varobj should be evaluated, which I
believe is correct behaviour. I also added a new floating test case
into the same test script, however, right now this also includes the
thread-id in the expected output, which I believe is an existing gdb
bug, which I plan to fix next.
Tested on x86_64 Linux native and native-gdbserver, no regressions.
gdb/ChangeLog:
PR mi/20395
* ada-exp.y (write_var_from_sym): Pass extra parameter when
updating innermost block.
* parse.c (innermost_block_tracker::update): Take extra type
parameter, and check types match before updating innermost block.
(write_dollar_variable): Update innermost block for registers.
* parser-defs.h (enum innermost_block_tracker_type): New enum.
(innermost_block_tracker::innermost_block_tracker): Initialise
m_types member.
(innermost_block_tracker::reset): Take type parameter.
(innermost_block_tracker::update): Take type parameter, and pass
type through as needed.
(innermost_block_tracker::m_types): New member.
* varobj.c (varobj_create): Pass type when reseting innermost
block.
gdb/testsuite/ChangeLog:
* gdb.mi/basics.c: Add new global.
* gdb.mi/mi-frame-regs.exp: New file.
* gdb.mi/mi-var-create-rtti.exp: Update expected results, add new
case.
2017-10-18 21:07:19 +02:00
|
|
|
|
2018-01-21 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR mi/20395
|
|
|
|
|
|
* ada-exp.y (write_var_from_sym): Pass extra parameter when
|
|
|
|
|
|
updating innermost block.
|
|
|
|
|
|
* parse.c (innermost_block_tracker::update): Take extra type
|
|
|
|
|
|
parameter, and check types match before updating innermost block.
|
|
|
|
|
|
(write_dollar_variable): Update innermost block for registers.
|
|
|
|
|
|
* parser-defs.h (enum innermost_block_tracker_type): New enum.
|
|
|
|
|
|
(innermost_block_tracker::innermost_block_tracker): Initialise
|
|
|
|
|
|
m_types member.
|
|
|
|
|
|
(innermost_block_tracker::reset): Take type parameter.
|
|
|
|
|
|
(innermost_block_tracker::update): Take type parameter, and pass
|
|
|
|
|
|
type through as needed.
|
|
|
|
|
|
(innermost_block_tracker::m_types): New member.
|
|
|
|
|
|
* varobj.c (varobj_create): Pass type when reseting innermost
|
|
|
|
|
|
block.
|
|
|
|
|
|
|
2017-10-18 20:53:21 +02:00
|
|
|
|
2018-01-21 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-exp.y (write_var_from_sym): Switch to innermost_block API.
|
|
|
|
|
|
* ada-lang.c (resolve_subexp): Likewise.
|
|
|
|
|
|
* breakpoint.c (set_breakpoint_condition) Likewise.
|
|
|
|
|
|
(watch_command_1) Likewise.
|
|
|
|
|
|
* c-exp.y (variable): Likewise.
|
|
|
|
|
|
* d-exp.y (PrimaryExpression): Likewise.
|
|
|
|
|
|
* f-exp.y (variable): Likewise.
|
|
|
|
|
|
* go-exp.y (variable): Likewise.
|
|
|
|
|
|
* m2-exp.y (variable): Likewise.
|
|
|
|
|
|
* objfiles.c (objfile::~objfile): Likewise.
|
|
|
|
|
|
* p-exp.y (variable): Likewise.
|
|
|
|
|
|
* parse.c (innermost_block): Change type.
|
|
|
|
|
|
* parser-defs.h (class innermost_block_tracker): New.
|
|
|
|
|
|
(innermost_block): Change to innermost_block_tracker.
|
|
|
|
|
|
* printcmd.c (display_command): Switch to innermost_block API.
|
|
|
|
|
|
(do_one_display): Likewise.
|
|
|
|
|
|
* rust-exp.y (do_one_display): Likewise.
|
|
|
|
|
|
* symfile.c (clear_symtab_users): Likewise.
|
|
|
|
|
|
* varobj.c (varobj_create): Switch to innermost_block API, replace
|
|
|
|
|
|
use of innermost_block with block stored on varobj object.
|
|
|
|
|
|
|
2017-10-18 20:04:17 +02:00
|
|
|
|
2018-01-21 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* expression.h (innermost_block): Remove declaration.
|
|
|
|
|
|
* varobj.c: Add 'parser-defs.h' include.
|
|
|
|
|
|
|
2018-01-19 23:25:19 +01:00
|
|
|
|
2018-01-19 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
|
|
|
|
|
|
symbols in the static and global blocks.
|
|
|
|
|
|
|
2018-01-19 18:22:49 +01:00
|
|
|
|
2018-01-19 James Clarke <jrtc27@jrtc27.com>
|
|
|
|
|
|
|
|
|
|
|
|
* nat/linux-ptrace.c: Remove unnecessary reinclusion of
|
|
|
|
|
|
gdb_ptrace.h, and move including gdb_wait.h ...
|
|
|
|
|
|
* nat/linux-ptrace.h: ... to here.
|
|
|
|
|
|
|
Make linux_nat_detach/thread_db_detach use the inferior parameter
This patch makes these two functions actually use the inferior parameter
added by the previous patch, instead of reading inferior_ptid. I chose
these two, because they are the one actually used when I detach on my
GNU/Linux system, so they were easy to test.
I took the opportunity to pass the inferior being detached to
inf_ptrace_detach_success, so it could use it too. From there, it made
sense to add an overload of detach_inferior that takes the inferior
directly rather than the pid, to avoid having to pass inf->pid only for
the callee to look up the inferior structure by pid.
gdb/ChangeLog:
* inf-ptrace.c (inf_ptrace_detach): Adjust call to
inf_ptrace_detach_success.
(inf_ptrace_detach_success): Add inferior parameter, use it
instead of inferior_ptid, pass it to detach_inferior.
* inf-ptrace.h (inf_ptrace_detach_success): Add inferior
parameter.
* inferior.c (detach_inferior): Add overload that takes an
inferior object.
* inferior.h (detach_inferior): Likewise.
* linux-nat.c (linux_nat_detach): Use the inf parameter, don't
use inferior_ptid, adjust call to inf_ptrace_detach_success.
* linux-thread-db.c (thread_db_detach): Use inf parameter.
2018-01-19 17:48:11 +01:00
|
|
|
|
2018-01-19 Simon Marchi <simon.marchi@ericsson.com>
|
|
|
|
|
|
|
|
|
|
|
|
* inf-ptrace.c (inf_ptrace_detach): Adjust call to
|
|
|
|
|
|
inf_ptrace_detach_success.
|
|
|
|
|
|
(inf_ptrace_detach_success): Add inferior parameter, use it
|
|
|
|
|
|
instead of inferior_ptid, pass it to detach_inferior.
|
|
|
|
|
|
* inf-ptrace.h (inf_ptrace_detach_success): Add inferior
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
* inferior.c (detach_inferior): Add overload that takes an
|
|
|
|
|
|
inferior object.
|
|
|
|
|
|
* inferior.h (detach_inferior): Likewise.
|
|
|
|
|
|
* linux-nat.c (linux_nat_detach): Use the inf parameter, don't
|
|
|
|
|
|
use inferior_ptid, adjust call to inf_ptrace_detach_success.
|
|
|
|
|
|
* linux-thread-db.c (thread_db_detach): Use inf parameter.
|
|
|
|
|
|
|
2018-01-19 17:47:57 +01:00
|
|
|
|
2018-01-19 Simon Marchi <simon.marchi@ericsson.com>
|
|
|
|
|
|
|
|
|
|
|
|
* target.h (struct target_ops) <to_detach>: Add inferior
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(target_detach): Likewise.
|
|
|
|
|
|
* target.c (dispose_inferior): Pass inferior down.
|
|
|
|
|
|
(target_detach): Pass inferior down. Assert that it is equal to
|
|
|
|
|
|
the current inferior.
|
|
|
|
|
|
* aix-thread.c (aix_thread_detach): Pass inferior down.
|
|
|
|
|
|
* corefile.c (core_file_command): Pass current_inferior() down.
|
|
|
|
|
|
* corelow.c (core_detach): Add inferior parameter.
|
|
|
|
|
|
* darwin-nat.c (darwin_detach): Likewise.
|
|
|
|
|
|
* gnu-nat.c (gnu_detach): Likewise.
|
|
|
|
|
|
* inf-ptrace.c (inf_ptrace_detach): Likewise.
|
|
|
|
|
|
* infcmd.c (detach_command): Pass current_inferior() down to
|
|
|
|
|
|
target_detach.
|
|
|
|
|
|
* infrun.c (follow_fork_inferior): Pass parent_inf to
|
|
|
|
|
|
target_detach.
|
|
|
|
|
|
(handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
|
|
|
|
|
|
target_detach.
|
|
|
|
|
|
* linux-nat.c (linux_nat_detach): Add inferior parameter.
|
|
|
|
|
|
* linux-thread-db.c (thread_db_detach): Likewise.
|
|
|
|
|
|
* nto-procfs.c (procfs_detach): Likewise.
|
|
|
|
|
|
* procfs.c (procfs_detach): Likewise.
|
|
|
|
|
|
* record.c (record_detach): Likewise.
|
|
|
|
|
|
* record.h (struct inferior): Forward-declare.
|
|
|
|
|
|
(record_detach): Add inferior parameter.
|
|
|
|
|
|
* remote-sim.c (gdbsim_detach): Likewise.
|
|
|
|
|
|
* remote.c (remote_detach_1): Likewise.
|
|
|
|
|
|
(remote_detach): Likewise.
|
|
|
|
|
|
(extended_remote_detach): Likewise.
|
|
|
|
|
|
* sol-thread.c (sol_thread_detach): Likewise.
|
|
|
|
|
|
* target-debug.h (target_debug_print_inferior_p): New macro.
|
|
|
|
|
|
* target-delegates.c: Re-generate.
|
|
|
|
|
|
* top.c (kill_or_detach): Pass inferior down to target_detach.
|
|
|
|
|
|
* windows-nat.c (windows_detach): Add inferior parameter.
|
|
|
|
|
|
|
Remove args from target detach
I was looking into adding a parameter to target_detach, and was
wondering what the args parameter was. It seems like in the distant
past, it was possible to specify a signal number when detaching. That
signal was injected in the process before it was detached. There is an
example of code handling this in linux_nat_detach. With today's GDB, I
can't get this to work. Doing "detach 15" (15 == SIGTERM) doesn't work,
because detach is a prefix command and doesn't recognize the sub-command
15. Doing "detach inferiors 15" doesn't work because it expects a list
of inferior id to detach. Therefore, I don't think there's a way of
invoking detach_command with a non-NULL args. I also didn't find any
documentation related to this feature.
I assume that this feature stopped working when detach was made a prefix
command, which is in f73adfeb8bae36885e6ea248d12223ab0d5eb9cb (sorry,
there's no commit title) from 2006. Given that this feature was broken
for such a long time and we haven't heard anything (AFAIK, I did not
find any related bug), I think it's safe to remove it, as well as the
args parameter to target_detach. If someone wants to re-introduce it, I
would suggest rethinking the user interface, and in particular would
suggest using signal name instead of numbers.
I tried to fix all the impacted code, but I might have forgotten some
spots. It shouldn't be hard to fix if that's the case. I also couldn't
build-test everything I changed, especially the nto and solaris stuff.
gdb/ChangeLog:
* target.h (struct target_ops) <to_detach>: Remove args
parameter.
(target_detach): Likewise.
* target.c (dispose_inferior): Adjust.
(target_detach): Remove args parameter, adjust.
* aix-thread.c (aix_thread_detach): Adjust.
* corefile.c (core_file_command): Adjust.
* corelow.c (core_detach): Adjust.
* darwin-nat.c (darwin_detach): Adjust.
* gnu-nat.c (gnu_detach): Adjust.
* inf-ptrace.c (inf_ptrace_detach): Adjust.
* infcmd.c (detach_command): Adjust
* infrun.c (follow_fork_inferior): Adjust.
(handle_vfork_child_exec_or_exit): Adjust.
* linux-fork.c (linux_fork_detach): Remove args parameter.
* linux-fork.h (linux_fork_detach): Likewise.
* linux-nat.c (linux_nat_detach): Likewise, and adjust.
* linux-thread-db.c (thread_db_detach): Likewise.
* nto-procfs.c (procfs_detach): Likewise.
* procfs.c (procfs_detach): Likewise.
(do_detach): Remove signo parameter.
* record.c (record_detach): Remove args parameter.
* record.h (record_detach): Likewise.
* remote-sim.c (gdbsim_detach): Likewise.
* remote.c (remote_detach_1): Likewise.
(remote_detach): Likewise.
(extended_remote_detach): Likewise.
* sol-thread.c (sol_thread_detach): Likewise.
* target-delegates.c: Re-generate.
* top.c (struct qt_args) <args>: Remove field.
(kill_or_detach): Don't pass args.
(quit_force): Don't set args.
* windows-nat.c (windows_detach): Remove args parameter.
2018-01-19 17:47:24 +01:00
|
|
|
|
2018-01-19 Simon Marchi <simon.marchi@ericsson.com>
|
|
|
|
|
|
|
|
|
|
|
|
* target.h (struct target_ops) <to_detach>: Remove args
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(target_detach): Likewise.
|
|
|
|
|
|
* target.c (dispose_inferior): Adjust.
|
|
|
|
|
|
(target_detach): Remove args parameter, adjust.
|
|
|
|
|
|
* aix-thread.c (aix_thread_detach): Adjust.
|
|
|
|
|
|
* corefile.c (core_file_command): Adjust.
|
|
|
|
|
|
* corelow.c (core_detach): Adjust.
|
|
|
|
|
|
* darwin-nat.c (darwin_detach): Adjust.
|
|
|
|
|
|
* gnu-nat.c (gnu_detach): Adjust.
|
|
|
|
|
|
* inf-ptrace.c (inf_ptrace_detach): Adjust.
|
|
|
|
|
|
* infcmd.c (detach_command): Adjust
|
|
|
|
|
|
* infrun.c (follow_fork_inferior): Adjust.
|
|
|
|
|
|
(handle_vfork_child_exec_or_exit): Adjust.
|
|
|
|
|
|
* linux-fork.c (linux_fork_detach): Remove args parameter.
|
|
|
|
|
|
* linux-fork.h (linux_fork_detach): Likewise.
|
|
|
|
|
|
* linux-nat.c (linux_nat_detach): Likewise, and adjust.
|
|
|
|
|
|
* linux-thread-db.c (thread_db_detach): Likewise.
|
|
|
|
|
|
* nto-procfs.c (procfs_detach): Likewise.
|
|
|
|
|
|
* procfs.c (procfs_detach): Likewise.
|
|
|
|
|
|
(do_detach): Remove signo parameter.
|
|
|
|
|
|
* record.c (record_detach): Remove args parameter.
|
|
|
|
|
|
* record.h (record_detach): Likewise.
|
|
|
|
|
|
* remote-sim.c (gdbsim_detach): Likewise.
|
|
|
|
|
|
* remote.c (remote_detach_1): Likewise.
|
|
|
|
|
|
(remote_detach): Likewise.
|
|
|
|
|
|
(extended_remote_detach): Likewise.
|
|
|
|
|
|
* sol-thread.c (sol_thread_detach): Likewise.
|
|
|
|
|
|
* target-delegates.c: Re-generate.
|
|
|
|
|
|
* top.c (struct qt_args) <args>: Remove field.
|
|
|
|
|
|
(kill_or_detach): Don't pass args.
|
|
|
|
|
|
(quit_force): Don't set args.
|
|
|
|
|
|
* windows-nat.c (windows_detach): Remove args parameter.
|
|
|
|
|
|
|
2018-01-19 10:16:45 +01:00
|
|
|
|
2018-01-19 Yao Qi <yao.qi@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
|
|
|
|
|
|
(arm_linux_init_abi): Install it.
|
|
|
|
|
|
|
2018-01-19 10:08:36 +01:00
|
|
|
|
2018-01-19 Yao Qi <yao.qi@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* osabi.c (gdb_osabi_names): Extend the regexp for
|
|
|
|
|
|
arm-linux-gnueabihf.
|
|
|
|
|
|
|
2018-01-18 16:29:31 +01:00
|
|
|
|
2018-01-18 Yao Qi <yao.qi@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
|
|
|
|
|
|
m_abbrevs.
|
|
|
|
|
|
(abbrev_table::add_abbrev): Update.
|
|
|
|
|
|
(abbrev_table::lookup_abbrev): Update.
|
|
|
|
|
|
|
2018-01-18 13:21:01 +01:00
|
|
|
|
2018-01-18 Yao Qi <yao.qi@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
|
|
|
|
|
|
|
2018-01-16 20:41:17 +01:00
|
|
|
|
2018-01-17 Sergio Durigan Junior <sergiodj@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* compile/compile.c (compile_to_object): Convert "triplet_rx"
|
|
|
|
|
|
to "std::string".
|
|
|
|
|
|
|
2018-01-06 01:26:21 +01:00
|
|
|
|
2018-01-17 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (symbolp): Remove typedef. Don't instantiate VEC.
|
|
|
|
|
|
|
2018-01-06 01:26:20 +01:00
|
|
|
|
2018-01-17 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbtypes.h (add_dyn_prop): Remove objfile parameter.
|
|
|
|
|
|
* gdbtypes.c (add_dyn_prop): Remove objfile parameter.
|
|
|
|
|
|
(create_array_type_with_stride): Update.
|
|
|
|
|
|
* dwarf2read.c (set_die_type): Update.
|
|
|
|
|
|
|
2018-01-06 01:26:19 +01:00
|
|
|
|
2018-01-17 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (delayed_method_info): Remove typedef.
|
|
|
|
|
|
(dwarf2_cu::method_info): Now a std::vector.
|
|
|
|
|
|
(add_to_method_list): Update.
|
|
|
|
|
|
(free_delayed_list): Remove.
|
|
|
|
|
|
(compute_delayed_physnames): Update.
|
|
|
|
|
|
(process_full_comp_unit, process_full_type_unit): Clear the method
|
|
|
|
|
|
list. Remove cleanups.
|
|
|
|
|
|
(psymtab_include_file_name): Add name_holder parameter. Use
|
|
|
|
|
|
unique_xmalloc_ptr.
|
|
|
|
|
|
(dwarf_decode_lines): Update.
|
|
|
|
|
|
|
2018-01-07 17:41:09 +01:00
|
|
|
|
2018-01-17 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
Simon Marchi <simon.marchi@ericsson.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
|
|
|
|
|
|
(dwarf2_per_objfile::free_cached_comp_units)
|
|
|
|
|
|
(init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
|
|
|
|
|
|
(init_cutu_and_read_dies_no_follow): Update.
|
|
|
|
|
|
(dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
|
|
|
|
|
|
(dwarf2_cu::~dwarf2_cu): New.
|
|
|
|
|
|
(free_heap_comp_unit, free_stack_comp_unit): Remove.
|
|
|
|
|
|
(age_cached_comp_units, free_one_cached_comp_unit): Update.
|
|
|
|
|
|
|
2018-01-06 01:26:17 +01:00
|
|
|
|
2018-01-17 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
Simon Marchi <simon.marchi@ericsson.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
|
|
|
|
|
|
(struct die_reader_specs) <abbrev_table>: New member.
|
|
|
|
|
|
(struct abbrev_table): Add constructor.
|
|
|
|
|
|
<alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
|
|
|
|
|
|
<abbrev_obstack>: Now an auto_obstack.
|
|
|
|
|
|
(abbrev_table_up): New typedef.
|
|
|
|
|
|
(init_cu_die_reader): Add abbrev_table parameter.
|
|
|
|
|
|
(read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
|
|
|
|
|
|
Add result_dwo_abbrev_table.
|
|
|
|
|
|
(init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
|
|
|
|
|
|
(init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
(peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(skip_children): Update.
|
|
|
|
|
|
(abbrev_table::alloc_abbrev): Rename from
|
|
|
|
|
|
abbrev_table_alloc_abbrev.
|
|
|
|
|
|
(abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
|
|
|
|
|
|
(abbrev_table::lookup_abbrev): Rename from
|
|
|
|
|
|
abbrev_table_lookup_abbrev.
|
|
|
|
|
|
(abbrev_table_read_table): Return abbrev_table_up.
|
|
|
|
|
|
(abbrev_table_free, abbrev_table_free_cleanup)
|
|
|
|
|
|
(dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
|
|
|
|
|
|
(load_partial_dies): Update.
|
|
|
|
|
|
|
2018-01-06 01:26:16 +01:00
|
|
|
|
2018-01-17 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (dwarf2_compute_name): Update comment.
|
|
|
|
|
|
(read_func_scope, read_variable): Update.
|
|
|
|
|
|
(new_symbol): Remove.
|
|
|
|
|
|
(new_symbol_full): Rename to new_symbol.
|
|
|
|
|
|
|
2018-01-17 18:59:51 +01:00
|
|
|
|
2018-01-17 Mike Gulick <mgulick@mathworks.com>
|
Fix gdb segv when objfile can't be opened
This fixes PR 16577.
This patch changes gdb_bfd_map_section to issue a warning rather than an error
if it is unable to read the object file, and sets the size of the section/frame
that it attempted to read to 0 on error.
The description of gdb_bfd_map_section states that it will try to read or map
the contents of the section SECT, and if successful, the section data is
returned and *SIZE is set to the size of the section data. This function was
throwing an error and leaving *SIZE as-is. Setting the section size to 0
indicates to dwarf2_build_frame_info that there is no data to read, otherwise
it will try to read from an invalid frame pointer.
Changing the error to a warning allows this to be handled gracefully.
Additionally, the error was clobbering the breakpoint output indicating the
current frame (function name, arguments, source file, and line number). E.g.
Thread 3 "foo" hit Breakpoint 1, BFD: reopening /tmp/jna-1013829440/jna2973250704389291330.tmp: No such file or directory
BFD: reopening /tmp/jna-1013829440/jna2973250704389291330.tmp: No such file or directory
(gdb)
While the "BFD: reopening ..." messages will still appear interspersed in the
breakpoint output, the current frame info is now displayed:
Thread 3 "foo" hit Breakpoint 1, BFD: reopening /tmp/jna-1013829440/jna1875755897659885075.tmp: No such file or directory
BFD: reopening /tmp/jna-1013829440/jna1875755897659885075.tmp: No such file or directory
warning: Can't read data for section '.eh_frame' in file '/tmp/jna-1013829440/jna1875755897659885075.tmp'
do_something () at file.cpp:80
80 {
(gdb)
2017-10-30 23:13:44 +01:00
|
|
|
|
|
|
|
|
|
|
PR gdb/16577
|
|
|
|
|
|
* gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
|
|
|
|
|
|
a warning instead of throwing an error, set section size to 0 and return
|
|
|
|
|
|
NULL.
|
|
|
|
|
|
* gdb_bfd.h (gdb_bfd_map_section): Update description.
|
|
|
|
|
|
|
2018-01-17 18:33:57 +01:00
|
|
|
|
2018-01-17 Simon Marchi <simon.marchi@ericsson.com>
|
|
|
|
|
|
|
|
|
|
|
|
* nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
|
|
|
|
|
|
std::string.
|
|
|
|
|
|
(linux_ptrace_attach_fail_reason_string): Likewise.
|
|
|
|
|
|
* nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
|
|
|
|
|
|
Likewise.
|
|
|
|
|
|
(linux_ptrace_attach_fail_reason_string): Likewise.
|
|
|
|
|
|
* linux-nat.c (attach_proc_task_lwp_callback): Adjust.
|
|
|
|
|
|
|
2018-01-17 18:33:45 +01:00
|
|
|
|
2018-01-17 Simon Marchi <simon.marchi@ericsson.com>
|
|
|
|
|
|
|
|
|
|
|
|
* linux-nat.c (linux_nat_attach): Remove xstrdup.
|
|
|
|
|
|
|
configure: Fix test for fs_base/gs_base in <sys/user.h>
Make <sys/types.h> be included prior to including <sys/user.h>.
glibc versions older than 2.14 use __uintNN_t types within certain
structures defined in <sys/user.h> probably assuming these types are
defined prior to including the header. This results in the following
`configure` feature test compilation error that makes it think that
`struct user_regs_struct` doesn't have `fs_base`/`gs_base` fields,
althouh it does.
configure:13617: checking for struct user_regs_struct.fs_base
configure:13617: gcc -c -g -O2 -I/linux/include conftest.c >&5
In file included from conftest.c:158:0:
/usr/include/sys/user.h:32:3: error: unknown type name '__uint16_t'
__uint16_t cwd;
^
/usr/include/sys/user.h:33:3: error: unknown type name '__uint16_t'
__uint16_t swd;
^
/usr/include/sys/user.h:34:3: error: unknown type name '__uint16_t'
__uint16_t ftw;
^
/usr/include/sys/user.h:35:3: error: unknown type name '__uint16_t'
__uint16_t fop;
^
/usr/include/sys/user.h:36:3: error: unknown type name '__uint64_t'
__uint64_t rip;
^
/usr/include/sys/user.h:37:3: error: unknown type name '__uint64_t'
__uint64_t rdp;
^
/usr/include/sys/user.h:38:3: error: unknown type name '__uint32_t'
__uint32_t mxcsr;
^
/usr/include/sys/user.h:39:3: error: unknown type name '__uint32_t'
__uint32_t mxcr_mask;
^
/usr/include/sys/user.h:40:3: error: unknown type name '__uint32_t'
__uint32_t st_space[32]; /* 8*16 bytes for each FP-reg = 128 bytes */
^
/usr/include/sys/user.h:41:3: error: unknown type name '__uint32_t'
__uint32_t xmm_space[64]; /* 16*16 bytes for each XMM-reg = 256 bytes */
^
/usr/include/sys/user.h:42:3: error: unknown type name '__uint32_t'
__uint32_t padding[24];
^
configure:13617: $? = 1
configure: failed program was:
| /* confdefs.h */
...
| /* end confdefs.h. */
| #include <sys/user.h>
|
| int
| main ()
| {
| static struct user_regs_struct ac_aggr;
| if (ac_aggr.fs_base)
| return 0;
| ;
| return 0;
| }
Recent glibc versions don't use typedef'ed int types in <sys/user.h>,
thus allowing it to be included as is
(glibc commit d79a9c949c84e7f0ba33e87447c47af833e9f11a).
However there're still some distros alive that use older glibc,
for instance, RHEL/CentOS 6 package glibc 2.12.
Also affects PR gdb/21559:
../../gdb/regcache.c:1087: internal-error: void regcache_raw_supply(regcache, int, const void): Assertion `regnum >= 0 && regnum < regcache->descr->nr_raw_registers' failed.
As noted by Andrew Paprocki, who submitted the PR
(https://sourceware.org/bugzilla/show_bug.cgi?id=21559#c3):
> It should be noted that modifying `configure` to force on
> `HAVE_STRUCT_USER_REGS_STRUCT_FS_BASE` and
> `HAVE_STRUCT_USER_REGS_STRUCT_GS_BASE` fixes this issue. For some
> reason the `configure` tests for `fs_base` and `gs_base` fail
> even though `sys/user.h` on RHEL5 has the fields defined in
> `user_regs_struct`.
Note that this patch does NOT fix the root cause of PR gdb/21559,
although now that `configure` properly detects the presence of the
fields and sets HAVE_XXX accordingly, the execution takes another
path, which doesn't lead to the assertion failure in question.
gdb/ChangeLog:
2018-01-17 Eldar Abusalimov <eldar.abusalimov@jetbrains.com>
PR gdb/21559
* configure.ac: Include <sys/types.h> prior to <sys/user.h> when
checking for fs_base/gs_base fields in struct user_regs_struct.
* configure: Regenerate.
gdb/gdbserver/ChangeLog:
2018-01-17 Eldar Abusalimov <eldar.abusalimov@jetbrains.com>
PR gdb/21559
* configure.ac: Include <sys/types.h> prior to <sys/user.h> when
checking for fs_base/gs_base fields in struct user_regs_struct.
* configure: Regenerate.
2018-01-15 14:57:42 +01:00
|
|
|
|
2018-01-17 Eldar Abusalimov <eldar.abusalimov@jetbrains.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/21559
|
|
|
|
|
|
* configure.ac: Include <sys/types.h> prior to <sys/user.h> when
|
|
|
|
|
|
checking for fs_base/gs_base fields in struct user_regs_struct.
|
|
|
|
|
|
* configure: Regenerate.
|
|
|
|
|
|
|
2018-01-17 13:48:52 +01:00
|
|
|
|
2018-01-17 Yao Qi <yao.qi@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
|
|
|
|
|
|
function.
|
|
|
|
|
|
(aarch64_linux_init_abi): Install it to gdbarch hook
|
|
|
|
|
|
gcc_target_options.
|
|
|
|
|
|
|
2018-01-15 21:03:20 +01:00
|
|
|
|
2018-01-15 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* common/signals-state-save-restore.c
|
|
|
|
|
|
(save_original_signals_state): Fix typos.
|
|
|
|
|
|
|
2018-01-11 22:12:05 +01:00
|
|
|
|
2017-01-12 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
Sergio Durigan Junior <sergiodj@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in (install-only): Install gdb-add-index.
|
|
|
|
|
|
|
2018-01-12 21:05:50 +01:00
|
|
|
|
2018-01-12 John Baldwin <jhb@FreeBSD.org>
|
|
|
|
|
|
|
|
|
|
|
|
* fbsd-tdep.c (KVE_PROTECTION): Correct value.
|
|
|
|
|
|
|
Fix GDB hang with remote after error from resume
Since this commit --
Fix PR18360 - internal error when using "interrupt -a"
(https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=c65d6b55)
-- the testsuite shows long delays on s390 with native-gdbserver when
executing certain tests, such as watchpoints.exp. These hangs have been
discussed before in the context of buildbot problems, see here:
https://sourceware.org/ml/gdb-patches/2017-12/msg00413.html
The problem can easily be triggered by stopping on a breakpoint, then
setting impossible watchpoints, and finally doing "continue". Then, after
having set the step-over state (in keep_going_pass_signal in infrun.c),
GDB tries to insert breakpoints and watchpoints into the inferior. This
fails, and the "continue" command is aborted. But the step-over state is
not cleared in this case, which causes future step-over attempts to be
skipped since GDB thinks that "we already have an in-line step-over
operation ongoing" (see start_step_over in infrun.c). Thus the next
"continue" just goes on to wait for events from the remote, which will
never occur.
The problem can also be reproduced on amd64 with native-gdbserver, using
the following change to watchpoints.exp:
-- >8 --
--- a/gdb/testsuite/gdb.base/watchpoints.exp
+++ b/gdb/testsuite/gdb.base/watchpoints.exp
@@ -61,2 +61,3 @@ with_test_prefix "before inferior start" {
gdb_test "watch ival3" ".*" ""
+ gdb_test "watch *(char \[256\] *) main"
-- >8 --
To fix the hang, this patch clears the step-over info when
insert_breakpoints has failed. Of course, with native-gdbserver the
watchpoints.exp test case still causes many FAILs on s390, because
gdbserver does not support watchpoints for that target. This is a
separate issue.
gdb/ChangeLog:
2018-01-12 Andreas Arnez <arnez@linux.vnet.ibm.com>
* infrun.c (keep_going_pass_signal): Clear step-over info when
insert_breakpoints fails.
2018-01-12 19:52:39 +01:00
|
|
|
|
2018-01-12 Andreas Arnez <arnez@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infrun.c (keep_going_pass_signal): Clear step-over info when
|
|
|
|
|
|
insert_breakpoints fails.
|
|
|
|
|
|
|
gdb.base/breakpoint-in-ro-region.exp regression on sss targets (PR gdb/22583)
As Maciej reported at
<https://sourceware.org/ml/gdb-patches/2017-12/msg00212.html>, this
commit:
commit d930703d68ae160ddfe8ebe5fdcf416fb6090e1e
Date: Thu Nov 16 18:44:43 2017 +0000
Subject: Don't ever Quit out of resume
caused regressions on software single-set targets, specifically:
FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind
FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw on: single-step breakpoint is not left behind
FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw off: step in ro region (cannot insert hw break)
FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw off: single-step breakpoint is not left behind
FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw on: single-step breakpoint is not left behind
and indeed detailed logs indicate a breakpoint is left lingering, e.g.:
(gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: step in ro region (cannot insert sw break)
maint info breakpoints 0
Num Type Disp Enb Address What
0 sw single-step keep y 0x00400774 in main at [...]/gdb/testsuite/gdb.base/breakpoint-in-ro-region.c:24 inf 1 thread 1
stop only in thread 1
(gdb) FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind
vs:
(gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: step in ro region (cannot insert sw break)
maint info breakpoints 0
No breakpoint or watchpoint matching '0'.
(gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind
as at commit d930703d68ae^.
Before commit d930703d68ae, we had a cleanup installed in 'resume'
that would delete single-step breakpoints on error:
/* Resuming. */
/* Things to clean up if we QUIT out of resume (). */
static void
resume_cleanups (void *ignore)
{
if (!ptid_equal (inferior_ptid, null_ptid))
delete_single_step_breakpoints (inferior_thread ());
normal_stop ();
}
That whole function was removed by d930703d68ae mainly to eliminate
the normal_stop call:
~~~~
Note that the exception called from within resume ends up calling
normal_stop via resume_cleanups. That's very borked though, because
normal_stop is going to re-handle whatever was the last reported
event, possibly even re-running a hook stop...
~~~~
But as the regression shows, removing resume_cleanups completely went
a bit too far, as the delete_single_step_breakpoints call is still
necessary.
So fix the regression by reinstating the
delete_single_step_breakpoints call on error. However, since we're
trying to eliminate cleanups, restore it in a different form (using
TRY/CATCH).
Tested on x86-64 GNU/Linux both top of master and on top of a series
that implements software single-step on x86.
gdb/ChangeLog:
2018-01-11 Pedro Alves <palves@redhat.com>
PR gdb/22583
* infrun.c (resume): Rename to ...
(resume_1): ... this.
(resume): Reimplement as wrapper around resume_1.
2018-01-11 18:50:31 +01:00
|
|
|
|
2018-01-11 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/22583
|
|
|
|
|
|
* infrun.c (resume): Rename to ...
|
|
|
|
|
|
(resume_1): ... this.
|
|
|
|
|
|
(resume): Reimplement as wrapper around resume_1.
|
|
|
|
|
|
|
Fix backwards compatibility with old GDBservers (PR remote/22597)
At <https://sourceware.org/ml/gdb-patches/2017-12/msg00285.html>,
Maciej reported that commit:
commit 5cd63fda035d4ba949e6478406162c4673b3c9ef
Date: Wed Oct 4 18:21:10 2017 +0100
Subject: Fix "Remote 'g' packet reply is too long" problems with multiple inferiors
made GDB stop working with older stubs. Any attempt to continue
execution after the initial connection fails with:
[...]
Process .../gdb/testsuite/outputs/gdb.base/advance/advance created; pid = 2670
Listening on port 2346
target remote [...]:2346
Remote debugging using [...]:2346
Reading symbols from .../lib64/ld.so.1...done.
[Switching to Thread <main>]
(gdb) continue
Cannot execute this command without a live selected thread.
(gdb)
The problem is:
(gdb) c
Cannot execute this command without a live selected thread.
(gdb) info threads
Id Target Id Frame
1 Thread 14917 0x00007f341cd98ed0 in _start () from /lib64/ld-linux-x86-64.so.2
The current thread <Thread ID 2> has terminated. See `help thread'.
^^^^^^^^^^^
(gdb)
Note, thread _2_. There's really only one thread in the inferior
(it's still at the entry point), but still GDB added a bogus second
thread.
The reason GDB started adding a second thread after 5cd63fda035d is
this hunk:
+ if (event->ptid == null_ptid)
+ {
+ const char *thr = strstr (p1 + 1, ";thread:");
+ if (thr != NULL)
+ event->ptid = read_ptid (thr + strlen (";thread:"),
+ NULL);
+ else
+ event->ptid = magic_null_ptid;
+ }
Note the else branch that falls back to magic_null_ptid. We reach
that when we process the initial stop reply sent back in response to
the the "?" (status) packet early in the connection setup:
Sending packet: $?#3f...Ack
Packet received: T0506:0000000000000000;07:40a510f4fd7f0000;10:d0fe1201577f0000;
And note that that response does not include a ";thread:XXX" part.
This stop reply is processed after listing threads with qfThreadInfo /
qsThreadInfo :
Sending packet: $qfThreadInfo#bb...Ack
Packet received: m3915
Sending packet: $qsThreadInfo#c8...Ack
Packet received: l
meaning, when we process that stop reply, we treat the event as coming
from a thread with ptid == magic_null_ptid, which is not yet in the
thread list, so we add it then:
(top-gdb) p ptid
$1 = {m_pid = 42000, m_lwp = -1, m_tid = 1}
(top-gdb) bt
#0 0x0000000000840a8c in add_thread_silent(ptid_t) (ptid=...) at src/gdb/thread.c:269
#1 0x00000000007ad61d in remote_add_thread(ptid_t, int, int) (ptid=..., running=0, executing=0)
at src/gdb/remote.c:1838
#2 0x00000000007ad8de in remote_notice_new_inferior(ptid_t, int) (currthread=..., executing=0)
at src/gdb/remote.c:1921
#3 0x00000000007b758b in process_stop_reply(stop_reply*, target_waitstatus*) (stop_reply=0x1158860, status=0x7fffffffcc00)
at src/gdb/remote.c:7217
#4 0x00000000007b7a38 in remote_wait_as(ptid_t, target_waitstatus*, int) (ptid=..., status=0x7fffffffcc00, options=0)
at src/gdb/remote.c:7380
#5 0x00000000007b7cd1 in remote_wait(target_ops*, ptid_t, target_waitstatus*, int) (ops=0x102fac0 <remote_ops>, ptid=..., status=0x7fffffffcc00, options=0) at src/gdb/remote.c:7446
#6 0x000000000081587b in delegate_wait(target_ops*, ptid_t, target_waitstatus*, int) (self=0x102fac0 <remote_ops>, arg1=..., arg2=0x7fffffffcc00, arg3=0) at src/gdb/target-delegates.c:138
#7 0x0000000000827d77 in target_wait(ptid_t, target_waitstatus*, int) (ptid=..., status=0x7fffffffcc00, options=0)
at src/gdb/target.c:2179
#8 0x0000000000715fda in do_target_wait(ptid_t, target_waitstatus*, int) (ptid=..., status=0x7fffffffcc00, options=0)
at src/gdb/infrun.c:3589
#9 0x0000000000716351 in wait_for_inferior() () at src/gdb/infrun.c:3707
#10 0x0000000000715435 in start_remote(int) (from_tty=1) at src/gdb/infrun.c:3212
things go downhill from this.
We don't see the problem with current master gdbserver, because that
version always sends the ";thread:" part in the initial stop reply:
Sending packet: $?#3f...Packet received: T0506:0000000000000000;07:a0d4ffffff7f0000;10:d05eddf7ff7f0000;thread:p3cea.3cea;core:3;
Years ago I had added a "--disable-packet=" command line option to
gdbserver which comes in handy for testing this, since the existing
"--disable-packet=Tthread" precisely makes gdbserver not send that
";thread:" part in stop replies. The testcase added by this commit
emulates old gdbserver making use of that.
I've compared a testrun at 5cd63fda035d^ (before regression) with
'current master+patch', against old gdbserver at f8b73d13b7ca^. I
hacked out --once, and "monitor exit" to be able to test. The results
are a bit too unstable to tell accurately, but it looked like there
were no regressions. Maciej confirmed this worked for him as well.
No regressions on master (against master gdbserver).
gdb/ChangeLog:
2018-01-11 Pedro Alves <palves@redhat.com>
PR remote/22597
* remote.c (remote_parse_stop_reply): Default to the last-set
general thread instead of to 'magic_null_ptid'.
gdb/testsuite/ChangeLog:
2018-01-11 Pedro Alves <palves@redhat.com>
PR remote/22597
* gdb.server/stop-reply-no-thread.c: New file.
* gdb.server/stop-reply-no-thread.exp: New file.
2018-01-11 01:23:04 +01:00
|
|
|
|
2018-01-11 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR remote/22597
|
|
|
|
|
|
* remote.c (remote_parse_stop_reply): Default to the last-set
|
|
|
|
|
|
general thread instead of to 'magic_null_ptid'.
|
|
|
|
|
|
|
2018-01-10 21:38:08 +01:00
|
|
|
|
2018-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* language.h (language_get_symbol_name_matcher): Rename ...
|
|
|
|
|
|
(get_symbol_name_matcher): ... this.
|
|
|
|
|
|
* language.c (language_get_symbol_name_matcher): Ditto.
|
|
|
|
|
|
* dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
|
|
|
|
|
|
callers adjusted.
|
|
|
|
|
|
|
Ada: make verbatim matcher override other language matchers (PR gdb/22670)
A previous patch fixed verbatim matching in the lookup at the minimal
symbol level, but we should also be finding that same symbol through
the partial/full symtab search.
For example, this is what happens if we use "print" instead of
"break":
(gdb) p <MixedCaseFunc>
$1 = {<text variable, no debug info>} 0x4024dc <MixedCaseFunc>
Before the C++ wildmatching series, GDB knows that MixedCaseFunc is a
function without parameters, and the expression above means calling
it. If you try it before having started the inferior, you'd get the
following (expected) error:
(gdb) print <MixedCaseFunc>
You can't do that without a process to debug.
The main idea behind making the name matcher be determined by the
symbol's language is so that C++ (etc.) wildmatching in linespecs
works even if the current language is not C++, as e.g., when you step
through C or assembly code.
Ada's verbatim matching syntax however ("<...>") isn't quite the same.
It is more a property of the current language than of a particular
symbol's language. We want to support this syntax when debugging an
Ada program, but it's reason of existence is to find non-Ada symbols.
This suggests going back to enabling it depending on current language
instead of language of the symbol being matched.
I'm not entirely happy with the "current_language" reference (though I
think that it's harmless). I think we could try storing the current
language in the lookup_name_info object, and then convert a bunch of
functions more to pass around lookup_name_info objects instead of
"const char *" names. I.e., build the lookup_name_info higher up.
I'm not sure about that, I'll have to think more about it. Maybe
something different will be better. Meanwhile, this gets us going.
I've extended the testcase to also exercise a no-debug-info function,
for extra coverage of the minsyms-only paths.
gdb/ChangeLog:
2018-01-10 Pedro Alves <palves@redhat.com>
PR gdb/22670
* dwarf2read.c
(gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
Adjust to use language_get_symbol_name_matcher instead of
language_defn::la_get_symbol_name_matcher.
* language.c (language_get_symbol_name_matcher): If in Ada mode
and the lookup name is a verbatim match, return Ada's matcher.
* language.h (language_get_symbol_name_matcher): Adjust comment.
(ada_lookup_name_info::verbatim_p):: New method.
gdb/testsuite/ChangeLog:
2018-01-10 Pedro Alves <palves@redhat.com>
PR gdb/22670
* gdb.ada/bp_c_mixed_case.exp: Add intro comment. Test printing C
functions too. Test setting breakpoints and printing C functions
with no debug info too.
* gdb.ada/bp_c_mixed_case/qux.c: New file.
2018-01-10 21:38:07 +01:00
|
|
|
|
2018-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/22670
|
|
|
|
|
|
* dwarf2read.c
|
|
|
|
|
|
(gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
|
|
|
|
|
|
Adjust to use language_get_symbol_name_matcher instead of
|
|
|
|
|
|
language_defn::la_get_symbol_name_matcher.
|
|
|
|
|
|
* language.c (language_get_symbol_name_matcher): If in Ada mode
|
|
|
|
|
|
and the lookup name is a verbatim match, return Ada's matcher.
|
|
|
|
|
|
* language.h (language_get_symbol_name_matcher): Adjust comment.
|
|
|
|
|
|
(ada_lookup_name_info::verbatim_p):: New method.
|
|
|
|
|
|
|
2018-01-10 21:38:07 +01:00
|
|
|
|
2018-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/22670
|
|
|
|
|
|
* ada-lang.c (ada_collect_symbol_completion_matches): If the
|
|
|
|
|
|
minsym's language is language_auto or language_cplus, pass down
|
|
|
|
|
|
language_ada instead.
|
|
|
|
|
|
* symtab.c (compare_symbol_name): Don't frob symbol language here.
|
|
|
|
|
|
|
2018-01-10 21:38:06 +01:00
|
|
|
|
2018-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/22670
|
|
|
|
|
|
* minsyms.c (linkage_name_str): New function.
|
|
|
|
|
|
(iterate_over_minimal_symbols): Use it.
|
|
|
|
|
|
|
2018-01-09 22:35:17 +01:00
|
|
|
|
2018-01-09 John Baldwin <jhb@FreeBSD.org>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Document that 'info proc' now works on FreeBSD.
|
|
|
|
|
|
|
2018-01-09 22:35:17 +01:00
|
|
|
|
2018-01-09 John Baldwin <jhb@FreeBSD.org>
|
|
|
|
|
|
|
|
|
|
|
|
* configure.ac: Check for kinfo_getfile in libutil.
|
|
|
|
|
|
* configure: Regenerate.
|
|
|
|
|
|
* config.in: Regenerate.
|
|
|
|
|
|
* fbsd-nat.c: Include "fbsd-tdep.h".
|
|
|
|
|
|
(fbsd_fetch_cmdline): New.
|
|
|
|
|
|
(fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
|
|
|
|
|
|
rather than calling error.
|
|
|
|
|
|
(fbsd_info_proc): New.
|
|
|
|
|
|
(fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
|
|
|
|
|
|
(fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
|
|
|
|
|
|
(fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
|
|
|
|
|
|
|
2018-01-09 22:35:17 +01:00
|
|
|
|
2018-01-09 John Baldwin <jhb@FreeBSD.org>
|
|
|
|
|
|
|
|
|
|
|
|
* fbsd-nat.c (struct free_deleter): Remove.
|
|
|
|
|
|
(fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
|
|
|
|
|
|
|
2018-01-09 22:35:17 +01:00
|
|
|
|
2018-01-09 John Baldwin <jhb@FreeBSD.org>
|
|
|
|
|
|
|
|
|
|
|
|
* fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
|
|
|
|
|
|
NULL for an empty pathname.
|
|
|
|
|
|
|
Support 'info proc' for FreeBSD process core dumps.
- Command line arguments are obtained from the pr_psargs[] array
saved in the NT_PRPSINFO note.
- The 'cwd' and 'exe' values are obtained from the per-process file
descriptor table stored in the NT_PROCSTAT_FILES core note.
- 'mappings' is implemented by walking the array of VM map entries
stored in the NT_PROCSTAT_VMMAP core note.
- 'status' output is generated by outputting fields from
the first structure stored in the NT_PROCSTAT_PROC core note.
- 'stat' is aliased to 'status'.
gdb/ChangeLog:
* fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
(KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
(KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
(KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
(KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
(KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
(KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
(KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
(kinfo_proc_layout_32, kinfo_proc_layout_i386)
(kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
(fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
(fbsd_core_fetch_timeval, fbsd_print_sigset)
(fbsd_core_info_proc_status, fbsd_core_info_proc): New.
(fbsd_init_abi): Install gdbarch "core_info_proc" method.
* fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
2018-01-09 22:35:17 +01:00
|
|
|
|
2018-01-09 John Baldwin <jhb@FreeBSD.org>
|
|
|
|
|
|
|
|
|
|
|
|
* fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
|
|
|
|
|
|
(KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
|
|
|
|
|
|
(KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
|
|
|
|
|
|
(KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
|
|
|
|
|
|
(KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
|
|
|
|
|
|
(KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
|
|
|
|
|
|
(KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
|
|
|
|
|
|
(KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
|
|
|
|
|
|
(kinfo_proc_layout_32, kinfo_proc_layout_i386)
|
|
|
|
|
|
(kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
|
|
|
|
|
|
(fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
|
|
|
|
|
|
(fbsd_core_fetch_timeval, fbsd_print_sigset)
|
|
|
|
|
|
(fbsd_core_info_proc_status, fbsd_core_info_proc): New.
|
|
|
|
|
|
(fbsd_init_abi): Install gdbarch "core_info_proc" method.
|
|
|
|
|
|
* fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
|
|
|
|
|
|
|
2018-01-08 16:30:16 +01:00
|
|
|
|
2018-01-08 Samuel Thibault <samuel.thibault@ens-lyon.org>
|
|
|
|
|
|
|
|
|
|
|
|
* gdb/gnu-nat.c: Include <elf.h> and <link.h>.
|
|
|
|
|
|
(gnu_xfer_auxv): New function.
|
|
|
|
|
|
(gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
|
|
|
|
|
|
TARGET_OBJECT_AUXV.
|
|
|
|
|
|
|
2018-01-08 11:09:32 +01:00
|
|
|
|
2018-01-08 Yao Qi <yao.qi@linaro.org>
|
|
|
|
|
|
Simon Marchi <simon.marchi@ericsson.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
|
|
|
|
|
|
common/selftest.c.
|
|
|
|
|
|
(COMMON_OBS): Remove selftest.o.
|
|
|
|
|
|
* configure.ac: Append selftest-arch.c and common/selftest.c to
|
|
|
|
|
|
CONFIG_SRCS. Append selftest-arch.o and selftest.o to COMMON_OBS.
|
|
|
|
|
|
* configure: Re-generated.
|
|
|
|
|
|
* maint.c (maintenance_selftest): Wrap selftests::run_tests with
|
|
|
|
|
|
GDB_SELF_TEST.
|
|
|
|
|
|
(maintenance_info_selftests): Likewise.
|
|
|
|
|
|
|
(Ada) Fix print of array using non-contiguous enumeration indexes
Consider the following code:
type Index is (Index1, Index2);
Size : constant Integer := 10;
for Index use (Index1 => 1, Index2 => Size);
type Array_Index_Enum is array (Index) of Integer;
my_table : Array_Index_Enum :=(others => 42);
When compiling the code above with a compiler where the GNAT encodings
are turned off (which can be temporarily emulated by using the compiler
switch -fgnat-encodings=minimal), printing this table in gdb leads to:
(gdb) p my_table
$1 = (42, 42, 4203344, 10, -8320, 32767, 4203465, 0, 0, 0)
The displayed content is wrong since the handling part believes
that the length of the array is max index value (10) minus the
first index value (1) i+ 1 = 10 which is wrong since index are not
contiguous in this case.
The right behavior is to detect that the array is using enumeration
index hence parse the enumeration values in order to get the number
of indexes in this array (2 indexes here).
This patch fixes this issue and changes the output as follow:
(gdb) p my_table
$1 = (42, 42)
gdb/ChangeLog:
* ada-valprint.c (val_print_packed_array_elements): Use
proper number of elements when printing an array indexed
by an enumeration type.
gdb/testsuite/ChangeLog (Joel Brobecker <brobecker@adacore.com>):
* gdb.ada/arr_enum_idx_w_gap.exp
* gdb.ada/arr_enum_idx_w_gap/foo_q418_043.adb
Tested on x86_64-linux.
2018-01-08 05:56:36 +01:00
|
|
|
|
2018-01-08 Xavier Roirand <roirand@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-valprint.c (val_print_packed_array_elements): Use
|
|
|
|
|
|
proper number of elements when printing an array indexed
|
|
|
|
|
|
by an enumeration type.
|
|
|
|
|
|
|
2018-01-07 17:22:46 +01:00
|
|
|
|
2018-01-07 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
|
|
|
|
|
|
(dw2_get_file_names_reader): Adjust.
|
|
|
|
|
|
(lookup_dwo_signatured_type): Adjust.
|
|
|
|
|
|
(lookup_dwp_signatured_type): Adjust.
|
|
|
|
|
|
(lookup_signatured_type): Adjust.
|
|
|
|
|
|
(create_type_unit_group): Adjust.
|
|
|
|
|
|
(get_type_unit_group): Adjust.
|
|
|
|
|
|
(process_psymtab_comp_unit_reader): Adjust.
|
|
|
|
|
|
(build_type_psymtabs_reader): Adjust.
|
|
|
|
|
|
(scan_partial_symbols): Adjust.
|
|
|
|
|
|
(add_partial_symbol): Adjust.
|
|
|
|
|
|
(add_partial_subprogram): Adjust.
|
|
|
|
|
|
(peek_die_abbrev): Adjust.
|
|
|
|
|
|
(fixup_go_packaging): Adjust.
|
|
|
|
|
|
(process_imported_unit_die): Adjust.
|
|
|
|
|
|
(dwarf2_compute_name): Adjust.
|
|
|
|
|
|
(dwarf2_physname): Adjust.
|
|
|
|
|
|
(read_import_statement): Adjust.
|
|
|
|
|
|
(handle_DW_AT_stmt_list): Adjust.
|
|
|
|
|
|
(read_file_scope): Adjust.
|
|
|
|
|
|
(read_func_scope): Adjust.
|
|
|
|
|
|
(read_lexical_block_scope): Adjust.
|
|
|
|
|
|
(read_call_site_scope): Adjust.
|
|
|
|
|
|
(read_variable): Adjust.
|
|
|
|
|
|
(dwarf2_rnglists_process): Adjust.
|
|
|
|
|
|
(dwarf2_ranges_process): Adjust.
|
|
|
|
|
|
(dwarf2_ranges_read): Adjust.
|
|
|
|
|
|
(dwarf2_get_pc_bounds): Adjust.
|
|
|
|
|
|
(dwarf2_record_block_ranges): Adjust.
|
|
|
|
|
|
(dwarf2_add_field): Adjust.
|
|
|
|
|
|
(dwarf2_add_member_fn): Adjust.
|
|
|
|
|
|
(read_structure_type): Adjust.
|
|
|
|
|
|
(process_structure_scope): Adjust.
|
|
|
|
|
|
(read_enumeration_type): Adjust.
|
|
|
|
|
|
(read_array_type): Adjust.
|
|
|
|
|
|
(mark_common_block_symbol_computed): Adjust.
|
|
|
|
|
|
(read_common_block): Adjust.
|
|
|
|
|
|
(read_namespace_type): Adjust.
|
|
|
|
|
|
(read_namespace): Adjust.
|
|
|
|
|
|
(read_module_type): Adjust.
|
|
|
|
|
|
(read_tag_pointer_type): Adjust.
|
|
|
|
|
|
(read_tag_ptr_to_member_type): Adjust.
|
|
|
|
|
|
(read_tag_string_type): Adjust.
|
|
|
|
|
|
(read_subroutine_type): Adjust.
|
|
|
|
|
|
(read_typedef): Adjust.
|
|
|
|
|
|
(read_base_type): Adjust.
|
|
|
|
|
|
(attr_to_dynamic_prop): Adjust.
|
|
|
|
|
|
(read_subrange_type): Adjust.
|
|
|
|
|
|
(read_unspecified_type): Adjust.
|
|
|
|
|
|
(dwarf2_read_abbrevs): Adjust.
|
|
|
|
|
|
(load_partial_dies): Adjust.
|
|
|
|
|
|
(read_partial_die): Adjust.
|
|
|
|
|
|
(find_partial_die): Adjust.
|
|
|
|
|
|
(guess_partial_die_structure_name): Adjust.
|
|
|
|
|
|
(fixup_partial_die): Adjust.
|
|
|
|
|
|
(read_attribute_value): Adjust.
|
|
|
|
|
|
(read_addr_index): Adjust.
|
|
|
|
|
|
(read_addr_index_from_leb128): Adjust.
|
|
|
|
|
|
(read_str_index): Adjust.
|
|
|
|
|
|
(dwarf2_string_attr): Adjust.
|
|
|
|
|
|
(get_debug_line_section): Adjust.
|
|
|
|
|
|
(dwarf_decode_line_header): Adjust.
|
|
|
|
|
|
(lnp_state_machine::check_line_address): Adjust.
|
|
|
|
|
|
(dwarf_decode_lines_1): Adjust.
|
|
|
|
|
|
(dwarf_decode_lines): Adjust.
|
|
|
|
|
|
(dwarf2_start_symtab): Adjust.
|
|
|
|
|
|
(var_decode_location): Adjust.
|
|
|
|
|
|
(new_symbol_full): Adjust.
|
|
|
|
|
|
(dwarf2_const_value_data): Adjust.
|
|
|
|
|
|
(dwarf2_const_value_attr): Adjust.
|
|
|
|
|
|
(dwarf2_const_value): Adjust.
|
|
|
|
|
|
(die_type): Adjust.
|
|
|
|
|
|
(die_containing_type): Adjust.
|
|
|
|
|
|
(build_error_marker_type): Adjust.
|
|
|
|
|
|
(lookup_die_type): Adjust.
|
|
|
|
|
|
(guess_full_die_structure_name): Adjust.
|
|
|
|
|
|
(anonymous_struct_prefix): Adjust.
|
|
|
|
|
|
(determine_prefix): Adjust.
|
|
|
|
|
|
(dwarf2_name): Adjust.
|
|
|
|
|
|
(follow_die_ref_or_sig): Adjust.
|
|
|
|
|
|
(follow_die_offset): Adjust.
|
|
|
|
|
|
(follow_die_ref): Adjust.
|
|
|
|
|
|
(follow_die_sig_1): Adjust.
|
|
|
|
|
|
(follow_die_sig): Adjust.
|
|
|
|
|
|
(get_signatured_type): Adjust.
|
|
|
|
|
|
(get_DW_AT_signature_type): Adjust.
|
|
|
|
|
|
(decode_locdesc): Adjust.
|
|
|
|
|
|
(dwarf_decode_macros): Adjust.
|
|
|
|
|
|
(cu_debug_loc_section): Adjust.
|
|
|
|
|
|
(fill_in_loclist_baton): Adjust.
|
|
|
|
|
|
(dwarf2_symbol_mark_computed): Adjust.
|
|
|
|
|
|
(init_one_comp_unit): Don't assign
|
|
|
|
|
|
dwarf2_cu::dwarf2_per_objfile.
|
|
|
|
|
|
(set_die_type): Adjust.
|
|
|
|
|
|
|
Remove dwarf2_per_objfile global
This patch removes the global variable dwarf2_per_objfile. This global
variable is set at the various entry points of dwarf2read.c (using
dw2_setup), and is referred to throughout the file. Instead of passing
data between functions in global variables like this one, it would be
better if the functions that depend on it either received it as argument
or got it from the existing arguments they receive. For example, a
function receiving a reference to a dwarf2_per_cu_data can access it
from dwarf2_per_cu_data::dwarf2_per_objfile.
This patch has been tested on the buildbot.
gdb/ChangeLog:
* dwarf2read.c (struct mapped_debug_names): Add constructor.
<dwarf2_per_objfile>: New field.
(dwarf2_per_objfile): Remove global.
(get_dwarf2_per_objfile): New function.
(set_dwarf2_per_objfile): New function.
(dwarf2_build_psymtabs_hard): Change objfile parameter to
dwarf2_per_objfile.
(abbrev_table_read_table): Add dwarf2_per_objfile parameter.
(read_abbrev_offset): Likewise.
(read_indirect_string): Likewise.
(read_indirect_line_string): Likewise.
(read_indirect_string_at_offset): Likewise.
(read_indirect_string_from_dwz): Likewise.
(dwarf2_find_containing_comp_unit): Change objfile parameter to
dwarf2_per_objfile.
(age_cached_comp_units): Add dwarf2_per_objfile parameter.
(create_all_comp_units): Change objfile parameter to
dwarf2_per_objfile.
(create_all_type_units): Likewise.
(process_queue): Add dwarf2_per_objfile parameter.
(read_and_check_comp_unit_head): Likewise.
(lookup_dwo_unit_in_dwp): Likewise.
(get_dwp_file): Likewise.
(process_cu_includes): Likewise.
(struct free_dwo_file_cleanup_data): New struct.
(dwarf2_has_info): Use get_dwarf2_per_objfile and
set_dwarf2_per_objfile.
(dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
(dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
context, adjust calls.
(dw2_instantiate_symtab): Likewise.
(dw2_get_cutu): Add dwarf2_per_objfile parameter.
(dw2_get_cu): Likewise.
(create_cu_from_index_list): Change objfile parameter to
dwarf2_per_objfile.
(create_cus_from_index_list): Get dwarf2_per_objfile from
context, adjust calls.
(create_cus_from_index): Likewise.
(create_signatured_type_table_from_index): Change objfile
parameter to dwarf2_per_objfile.
(create_signatured_type_table_from_debug_names): Change objfile
parameter to dwarf2_per_objfile.
(create_addrmap_from_index): Likewise.
(create_addrmap_from_aranges): Likewise.
(dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
(dw2_setup): Remove.
(dw2_get_file_names_reader): Get dwarf2_per_objfile from
context.
(dw2_find_last_source_symtab): Get dwarf2_per_objfile using
get_dwarf2_per_objfile.
(dw2_forget_cached_source_info): Likewise.
(dw2_map_symtabs_matching_filename): Likewise.
(struct dw2_symtab_iterator) <index>: Remove.
<dwarf2_per_objfile>: New field.
(dw2_symtab_iter_init): Replace index parameter with
dwarf2_per_objfile.
(dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
(dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
(dw2_print_stats): Likewise.
(dw2_dump): Likewise.
(dw2_expand_symtabs_for_function): Likewise.
(dw2_expand_all_symtabs): Likewise.
(dw2_expand_symtabs_with_fullname): Likewise.
(dw2_expand_marked_cus): Replace index and objfile parameters
with dwarf2_per_objfile.
(dw_expand_symtabs_matching_file_matcher): Add
dwarf2_per_objfile parameter and adjust calls.
(dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
adjust calls.
(dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
(dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
adjust calls.
(create_cus_from_debug_names_list): Replace objfile parameter
with dwarf2_per_objfile and adjust calls.
(create_cus_from_debug_names): Likewise.
(dwarf2_read_debug_names): Likewise.
(mapped_debug_names::namei_to_name): Adjust call.
(dw2_debug_names_iterator::next): Likewise.
(dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
(dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
(dw2_debug_names_dump): Likewise.
(dw2_debug_names_expand_symtabs_for_function): Likewise.
(dw2_debug_names_expand_symtabs_matching): Likewise.
(dwarf2_initialize_objfile): Likewise.
(dwarf2_build_psymtabs): Likewise.
(get_abbrev_section_for_cu): Get dwarf2_per_objfile from
this_cu.
(error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
(read_and_check_comp_unit_head): Likewise.
(read_abbrev_offset): Likewise.
(create_debug_type_hash_table): Likewise.
(create_debug_types_hash_table): Likewise.
(create_all_type_units): Replace objfile parameter with
dwarf2_per_objfile.
(add_type_unit): Add dwarf2_per_objfile parameter.
(fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
with dwarf2_per_objfile.
(lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
(lookup_dwp_signatured_type): Likewise.
(lookup_signatured_type): Likewise.
(read_cutu_die_from_dwo): Likewise.
(init_tu_and_read_dwo_dies): Likewise.
(init_cutu_and_read_dies): Likewise.
(init_cutu_and_read_dies_no_follow): Likewise.
(allocate_type_unit_groups_table): Add objfile parameter.
(create_type_unit_group): Use dwarf2_per_objfile from cu.
(get_type_unit_group): Likewise.
(process_psymtab_comp_unit): Update call.
(build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
(build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
(print_tu_stats): Likewise.
(build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
in void* parameter.
(build_type_psymtabs): Change objfile parameter to
dwarf2_per_objfile.
(process_skeletonless_type_unit): Use dwarf2_per_objfile
passed in void* parameter.
(process_skeletonless_type_units): Change objfile parameter to
dwarf2_per_objfile.
(set_partial_user): Likewise.
(dwarf2_build_psymtabs_hard): Likewise.
(read_comp_units_from_section): Likewise.
(create_all_comp_units): Likewise.
(scan_partial_symbols): Update calls.
(add_partial_symbol): Likewise.
(dwarf2_read_symtab): Use get_dwarf2_per_objfile.
(maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
(process_queue): Add dwarf2_per_objfile parameter.
(get_compunit_symtab): Use dwarf2_per_objfile from cu.
(compute_compunit_symtab_includes): Likewise.
(process_cu_includes): Add dwarf2_per_objfile parameter.
(process_full_comp_unit): Use dwarf2_per_objfile from cu.
(process_full_type_unit): Likewise.
(process_imported_unit_die): Update call.
(handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
(read_file_scope): Likewise.
(allocate_dwo_file_hash_table): Add objfile parameter.
(lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
(create_cus_hash_table): Likewise.
(create_dwp_hash_table): Likewise.
(create_dwo_unit_in_dwp_v1): Likewise.
(create_dwp_v2_section): Likewise.
(create_dwo_unit_in_dwp_v2): Likewise.
(lookup_dwo_unit_in_dwp): Likewise.
(try_open_dwop_file): Likewise.
(open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
(open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
cleanup to include a reference to dwarf2_per_objfile.
(open_dwp_file): Add dwarf2_per_objfile parameter.
(open_and_init_dwp_file): Likewise.
(get_dwp_file): Likewise.
(lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
(queue_and_load_all_dwo_tus): Update call.
(free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
data.
(dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
(dwarf2_ranges_process): Likewise.
(dwarf2_get_pc_bounds): Likewise.
(mark_common_block_symbol_computed): Likewise.
(abbrev_table_read_table): Add dwarf2_per_objfile parameter.
(dwarf2_read_abbrevs): Update call.
(read_partial_die): Use dwarf2_per_objfile from cu.
(find_partial_die): Likewise.
(fixup_partial_die): Likewise.
(read_attribute_value): Likewise.
(read_indirect_string_at_offset_from): Add objfile parameter.
(read_indirect_string_at_offset): Add dwarf2_per_objfile
parameter.
(read_indirect_string_from_dwz): Add objfile parameter.
(read_indirect_string): Add objfile parameter.
(read_addr_index_1): Add dwarf2_per_objfile parameter.
(read_addr_index): Use dwarf2_per_objfile from cu.
(dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
call dw2_setup.
(read_str_index): Use dwarf2_per_objfile from cu.
(get_debug_line_section): Likewise.
(read_formatted_entries): Add dwarf2_per_objfile parameter.
(dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
(new_symbol_full): Use dwarf2_per_objfile from cu.
(build_error_marker_type): Likewise.
(lookup_die_type): Likewise.
(determine_prefix): Likewise.
(follow_die_offset): Likewise.
(dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
(dwarf2_fetch_constant_bytes): Don't call dw2_setup.
(dwarf2_fetch_die_type_sect_off): Likewise.
(dwarf2_get_die_type): Likewise.
(follow_die_sig_1): Use dwarf2_per_objfile from cu.
(get_signatured_type): Likewise.
(get_DW_AT_signature_type): Likewise.
(dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
(dwarf_decode_macros): Use dwarf2_per_objfile from cu.
(cu_debug_loc_section): Likewise.
(fill_in_loclist_baton): Likewise.
(dwarf2_symbol_mark_computed): Likewise.
(dwarf2_find_containing_comp_unit): Change objfile parameter to
dwarf2_per_objfile.
(free_cached_comp_units): Use dwarf2_per_objfile passed in void*
parameter.
(age_cached_comp_units): Add dwarf2_per_objfile parameter.
(free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
(dwarf2_free_objfile): Use get_dwarf2_per_objfile.
(set_die_type): Use dwarf2_free_objfile from cu.
(get_die_type_at_offset): Likewise.
(dwarf2_per_objfile_free): Don't assign global variable.
(debug_names) <constructor>: Add dwarf2_per_objfile
parameter, update m_debugstrlookup construction.
(debug_names::debug_str_lookup): Add dwarf2_per_objfile
parameter.
<m_dwarf2_per_objfile>: New field.
<lookup>: Use m_dwarf2_per_objfile.
(check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
(psyms_seen_size): Likewise.
(write_gdbindex): Replace objfile parameter with
dwarf2_per_objfile.
(write_debug_names): Likewise.
(write_psymtabs_to_index): Likewise.
(save_gdb_index_command): Use get_dwarf2_per_objfile, update
calls.
2018-01-07 17:22:46 +01:00
|
|
|
|
2018-01-07 Simon Marchi <simon.marchi@ericsson.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (struct mapped_debug_names): Add constructor.
|
|
|
|
|
|
<dwarf2_per_objfile>: New field.
|
|
|
|
|
|
(dwarf2_per_objfile): Remove global.
|
|
|
|
|
|
(get_dwarf2_per_objfile): New function.
|
|
|
|
|
|
(set_dwarf2_per_objfile): New function.
|
|
|
|
|
|
(dwarf2_build_psymtabs_hard): Change objfile parameter to
|
|
|
|
|
|
dwarf2_per_objfile.
|
|
|
|
|
|
(abbrev_table_read_table): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(read_abbrev_offset): Likewise.
|
|
|
|
|
|
(read_indirect_string): Likewise.
|
|
|
|
|
|
(read_indirect_line_string): Likewise.
|
|
|
|
|
|
(read_indirect_string_at_offset): Likewise.
|
|
|
|
|
|
(read_indirect_string_from_dwz): Likewise.
|
|
|
|
|
|
(dwarf2_find_containing_comp_unit): Change objfile parameter to
|
|
|
|
|
|
dwarf2_per_objfile.
|
|
|
|
|
|
(age_cached_comp_units): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(create_all_comp_units): Change objfile parameter to
|
|
|
|
|
|
dwarf2_per_objfile.
|
|
|
|
|
|
(create_all_type_units): Likewise.
|
|
|
|
|
|
(process_queue): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(read_and_check_comp_unit_head): Likewise.
|
|
|
|
|
|
(lookup_dwo_unit_in_dwp): Likewise.
|
|
|
|
|
|
(get_dwp_file): Likewise.
|
|
|
|
|
|
(process_cu_includes): Likewise.
|
|
|
|
|
|
(struct free_dwo_file_cleanup_data): New struct.
|
|
|
|
|
|
(dwarf2_has_info): Use get_dwarf2_per_objfile and
|
|
|
|
|
|
set_dwarf2_per_objfile.
|
|
|
|
|
|
(dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
|
|
|
|
|
|
context, adjust calls.
|
|
|
|
|
|
(dw2_instantiate_symtab): Likewise.
|
|
|
|
|
|
(dw2_get_cutu): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(dw2_get_cu): Likewise.
|
|
|
|
|
|
(create_cu_from_index_list): Change objfile parameter to
|
|
|
|
|
|
dwarf2_per_objfile.
|
|
|
|
|
|
(create_cus_from_index_list): Get dwarf2_per_objfile from
|
|
|
|
|
|
context, adjust calls.
|
|
|
|
|
|
(create_cus_from_index): Likewise.
|
|
|
|
|
|
(create_signatured_type_table_from_index): Change objfile
|
|
|
|
|
|
parameter to dwarf2_per_objfile.
|
|
|
|
|
|
(create_signatured_type_table_from_debug_names): Change objfile
|
|
|
|
|
|
parameter to dwarf2_per_objfile.
|
|
|
|
|
|
(create_addrmap_from_index): Likewise.
|
|
|
|
|
|
(create_addrmap_from_aranges): Likewise.
|
|
|
|
|
|
(dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
|
|
|
|
|
|
(dw2_setup): Remove.
|
|
|
|
|
|
(dw2_get_file_names_reader): Get dwarf2_per_objfile from
|
|
|
|
|
|
context.
|
|
|
|
|
|
(dw2_find_last_source_symtab): Get dwarf2_per_objfile using
|
|
|
|
|
|
get_dwarf2_per_objfile.
|
|
|
|
|
|
(dw2_forget_cached_source_info): Likewise.
|
|
|
|
|
|
(dw2_map_symtabs_matching_filename): Likewise.
|
|
|
|
|
|
(struct dw2_symtab_iterator) <index>: Remove.
|
|
|
|
|
|
<dwarf2_per_objfile>: New field.
|
|
|
|
|
|
(dw2_symtab_iter_init): Replace index parameter with
|
|
|
|
|
|
dwarf2_per_objfile.
|
|
|
|
|
|
(dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
|
|
|
|
|
|
(dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
|
|
|
|
|
|
(dw2_print_stats): Likewise.
|
|
|
|
|
|
(dw2_dump): Likewise.
|
|
|
|
|
|
(dw2_expand_symtabs_for_function): Likewise.
|
|
|
|
|
|
(dw2_expand_all_symtabs): Likewise.
|
|
|
|
|
|
(dw2_expand_symtabs_with_fullname): Likewise.
|
|
|
|
|
|
(dw2_expand_marked_cus): Replace index and objfile parameters
|
|
|
|
|
|
with dwarf2_per_objfile.
|
|
|
|
|
|
(dw_expand_symtabs_matching_file_matcher): Add
|
|
|
|
|
|
dwarf2_per_objfile parameter and adjust calls.
|
|
|
|
|
|
(dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
|
|
|
|
|
|
adjust calls.
|
|
|
|
|
|
(dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
|
|
|
|
|
|
(dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
|
|
|
|
|
|
adjust calls.
|
|
|
|
|
|
(create_cus_from_debug_names_list): Replace objfile parameter
|
|
|
|
|
|
with dwarf2_per_objfile and adjust calls.
|
|
|
|
|
|
(create_cus_from_debug_names): Likewise.
|
|
|
|
|
|
(dwarf2_read_debug_names): Likewise.
|
|
|
|
|
|
(mapped_debug_names::namei_to_name): Adjust call.
|
|
|
|
|
|
(dw2_debug_names_iterator::next): Likewise.
|
|
|
|
|
|
(dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
|
|
|
|
|
|
(dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
|
|
|
|
|
|
(dw2_debug_names_dump): Likewise.
|
|
|
|
|
|
(dw2_debug_names_expand_symtabs_for_function): Likewise.
|
|
|
|
|
|
(dw2_debug_names_expand_symtabs_matching): Likewise.
|
|
|
|
|
|
(dwarf2_initialize_objfile): Likewise.
|
|
|
|
|
|
(dwarf2_build_psymtabs): Likewise.
|
|
|
|
|
|
(get_abbrev_section_for_cu): Get dwarf2_per_objfile from
|
|
|
|
|
|
this_cu.
|
|
|
|
|
|
(error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(read_and_check_comp_unit_head): Likewise.
|
|
|
|
|
|
(read_abbrev_offset): Likewise.
|
|
|
|
|
|
(create_debug_type_hash_table): Likewise.
|
|
|
|
|
|
(create_debug_types_hash_table): Likewise.
|
|
|
|
|
|
(create_all_type_units): Replace objfile parameter with
|
|
|
|
|
|
dwarf2_per_objfile.
|
|
|
|
|
|
(add_type_unit): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
|
|
|
|
|
|
with dwarf2_per_objfile.
|
|
|
|
|
|
(lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
|
|
|
|
|
|
(lookup_dwp_signatured_type): Likewise.
|
|
|
|
|
|
(lookup_signatured_type): Likewise.
|
|
|
|
|
|
(read_cutu_die_from_dwo): Likewise.
|
|
|
|
|
|
(init_tu_and_read_dwo_dies): Likewise.
|
|
|
|
|
|
(init_cutu_and_read_dies): Likewise.
|
|
|
|
|
|
(init_cutu_and_read_dies_no_follow): Likewise.
|
|
|
|
|
|
(allocate_type_unit_groups_table): Add objfile parameter.
|
|
|
|
|
|
(create_type_unit_group): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(get_type_unit_group): Likewise.
|
|
|
|
|
|
(process_psymtab_comp_unit): Update call.
|
|
|
|
|
|
(build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(print_tu_stats): Likewise.
|
|
|
|
|
|
(build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
|
|
|
|
|
|
in void* parameter.
|
|
|
|
|
|
(build_type_psymtabs): Change objfile parameter to
|
|
|
|
|
|
dwarf2_per_objfile.
|
|
|
|
|
|
(process_skeletonless_type_unit): Use dwarf2_per_objfile
|
|
|
|
|
|
passed in void* parameter.
|
|
|
|
|
|
(process_skeletonless_type_units): Change objfile parameter to
|
|
|
|
|
|
dwarf2_per_objfile.
|
|
|
|
|
|
(set_partial_user): Likewise.
|
|
|
|
|
|
(dwarf2_build_psymtabs_hard): Likewise.
|
|
|
|
|
|
(read_comp_units_from_section): Likewise.
|
|
|
|
|
|
(create_all_comp_units): Likewise.
|
|
|
|
|
|
(scan_partial_symbols): Update calls.
|
|
|
|
|
|
(add_partial_symbol): Likewise.
|
|
|
|
|
|
(dwarf2_read_symtab): Use get_dwarf2_per_objfile.
|
|
|
|
|
|
(maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
|
|
|
|
|
|
(process_queue): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(get_compunit_symtab): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(compute_compunit_symtab_includes): Likewise.
|
|
|
|
|
|
(process_cu_includes): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(process_full_comp_unit): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(process_full_type_unit): Likewise.
|
|
|
|
|
|
(process_imported_unit_die): Update call.
|
|
|
|
|
|
(handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(read_file_scope): Likewise.
|
|
|
|
|
|
(allocate_dwo_file_hash_table): Add objfile parameter.
|
|
|
|
|
|
(lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(create_cus_hash_table): Likewise.
|
|
|
|
|
|
(create_dwp_hash_table): Likewise.
|
|
|
|
|
|
(create_dwo_unit_in_dwp_v1): Likewise.
|
|
|
|
|
|
(create_dwp_v2_section): Likewise.
|
|
|
|
|
|
(create_dwo_unit_in_dwp_v2): Likewise.
|
|
|
|
|
|
(lookup_dwo_unit_in_dwp): Likewise.
|
|
|
|
|
|
(try_open_dwop_file): Likewise.
|
|
|
|
|
|
(open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
|
|
|
|
|
|
cleanup to include a reference to dwarf2_per_objfile.
|
|
|
|
|
|
(open_dwp_file): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(open_and_init_dwp_file): Likewise.
|
|
|
|
|
|
(get_dwp_file): Likewise.
|
|
|
|
|
|
(lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(queue_and_load_all_dwo_tus): Update call.
|
|
|
|
|
|
(free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
|
|
|
|
|
|
data.
|
|
|
|
|
|
(dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(dwarf2_ranges_process): Likewise.
|
|
|
|
|
|
(dwarf2_get_pc_bounds): Likewise.
|
|
|
|
|
|
(mark_common_block_symbol_computed): Likewise.
|
|
|
|
|
|
(abbrev_table_read_table): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(dwarf2_read_abbrevs): Update call.
|
|
|
|
|
|
(read_partial_die): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(find_partial_die): Likewise.
|
|
|
|
|
|
(fixup_partial_die): Likewise.
|
|
|
|
|
|
(read_attribute_value): Likewise.
|
|
|
|
|
|
(read_indirect_string_at_offset_from): Add objfile parameter.
|
|
|
|
|
|
(read_indirect_string_at_offset): Add dwarf2_per_objfile
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(read_indirect_string_from_dwz): Add objfile parameter.
|
|
|
|
|
|
(read_indirect_string): Add objfile parameter.
|
|
|
|
|
|
(read_addr_index_1): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(read_addr_index): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
|
|
|
|
|
|
call dw2_setup.
|
|
|
|
|
|
(read_str_index): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(get_debug_line_section): Likewise.
|
|
|
|
|
|
(read_formatted_entries): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(new_symbol_full): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(build_error_marker_type): Likewise.
|
|
|
|
|
|
(lookup_die_type): Likewise.
|
|
|
|
|
|
(determine_prefix): Likewise.
|
|
|
|
|
|
(follow_die_offset): Likewise.
|
|
|
|
|
|
(dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
|
|
|
|
|
|
(dwarf2_fetch_constant_bytes): Don't call dw2_setup.
|
|
|
|
|
|
(dwarf2_fetch_die_type_sect_off): Likewise.
|
|
|
|
|
|
(dwarf2_get_die_type): Likewise.
|
|
|
|
|
|
(follow_die_sig_1): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(get_signatured_type): Likewise.
|
|
|
|
|
|
(get_DW_AT_signature_type): Likewise.
|
|
|
|
|
|
(dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(dwarf_decode_macros): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(cu_debug_loc_section): Likewise.
|
|
|
|
|
|
(fill_in_loclist_baton): Likewise.
|
|
|
|
|
|
(dwarf2_symbol_mark_computed): Likewise.
|
|
|
|
|
|
(dwarf2_find_containing_comp_unit): Change objfile parameter to
|
|
|
|
|
|
dwarf2_per_objfile.
|
|
|
|
|
|
(free_cached_comp_units): Use dwarf2_per_objfile passed in void*
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(age_cached_comp_units): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
|
|
|
|
|
|
(dwarf2_free_objfile): Use get_dwarf2_per_objfile.
|
|
|
|
|
|
(set_die_type): Use dwarf2_free_objfile from cu.
|
|
|
|
|
|
(get_die_type_at_offset): Likewise.
|
|
|
|
|
|
(dwarf2_per_objfile_free): Don't assign global variable.
|
|
|
|
|
|
(debug_names) <constructor>: Add dwarf2_per_objfile
|
|
|
|
|
|
parameter, update m_debugstrlookup construction.
|
|
|
|
|
|
(debug_names::debug_str_lookup): Add dwarf2_per_objfile
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
<m_dwarf2_per_objfile>: New field.
|
|
|
|
|
|
<lookup>: Use m_dwarf2_per_objfile.
|
|
|
|
|
|
(check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
|
|
|
|
|
|
(psyms_seen_size): Likewise.
|
|
|
|
|
|
(write_gdbindex): Replace objfile parameter with
|
|
|
|
|
|
dwarf2_per_objfile.
|
|
|
|
|
|
(write_debug_names): Likewise.
|
|
|
|
|
|
(write_psymtabs_to_index): Likewise.
|
|
|
|
|
|
(save_gdb_index_command): Use get_dwarf2_per_objfile, update
|
|
|
|
|
|
calls.
|
|
|
|
|
|
|
2018-01-07 17:22:45 +01:00
|
|
|
|
2018-01-07 Simon Marchi <simon.marchi@ericsson.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
|
|
|
|
|
|
<dwarf2_per_objfile>: New field.
|
|
|
|
|
|
(struct dwarf2_per_cu_data) <objfile>: Remove.
|
|
|
|
|
|
<dwarf2_per_objfile>: New field.
|
|
|
|
|
|
(create_cu_from_index_list): Assign dwarf2_per_objfile instead
|
|
|
|
|
|
of objfile.
|
|
|
|
|
|
(create_signatured_type_table_from_index): Likewise.
|
|
|
|
|
|
(create_debug_type_hash_table): Likewise.
|
|
|
|
|
|
(fill_in_sig_entry_from_dwo_entry): Likewise.
|
|
|
|
|
|
(lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
|
|
|
|
|
|
(create_type_unit_group): Assign dwarf2_per_objfile instead of
|
|
|
|
|
|
objfile.
|
|
|
|
|
|
(create_partial_symtab): Access objfile through
|
|
|
|
|
|
dwarf2_per_objfile.
|
|
|
|
|
|
(process_psymtab_comp_unit_reader): Likewise.
|
|
|
|
|
|
(read_comp_units_from_section): Likewise.
|
|
|
|
|
|
(scan_partial_symbols): Likewise.
|
|
|
|
|
|
(add_partial_symbol): Likewise.
|
|
|
|
|
|
(add_partial_subprogram): Likewise.
|
|
|
|
|
|
(peek_die_abbrev): Likewise.
|
|
|
|
|
|
(fixup_go_packaging): Likewise.
|
|
|
|
|
|
(process_full_comp_unit): Likewise.
|
|
|
|
|
|
(process_full_type_unit): Likewise.
|
|
|
|
|
|
(process_imported_unit_die): Likewise.
|
|
|
|
|
|
(dwarf2_compute_name): Likewise.
|
|
|
|
|
|
(dwarf2_physname): Likewise.
|
|
|
|
|
|
(read_import_statement): Likewise.
|
|
|
|
|
|
(create_cus_hash_table): Assign dwarf2_physname instead of
|
|
|
|
|
|
objfile.
|
|
|
|
|
|
(read_func_scope): Access objfile through dwarf2_per_objfile.
|
|
|
|
|
|
(read_lexical_block_scope): Likewise.
|
|
|
|
|
|
(read_call_site_scope): Likewise.
|
|
|
|
|
|
(read_variable): Likewise.
|
|
|
|
|
|
(dwarf2_rnglists_process): Likewise.
|
|
|
|
|
|
(dwarf2_ranges_process): Likewise.
|
|
|
|
|
|
(dwarf2_ranges_read): Likewise.
|
|
|
|
|
|
(dwarf2_record_block_ranges): Likewise.
|
|
|
|
|
|
(dwarf2_add_field): Likewise.
|
|
|
|
|
|
(dwarf2_add_member_fn): Likewise.
|
|
|
|
|
|
(read_structure_type): Likewise.
|
|
|
|
|
|
(process_structure_scope): Likewise.
|
|
|
|
|
|
(read_enumeration_type): Likewise.
|
|
|
|
|
|
(read_array_type): Likewise.
|
|
|
|
|
|
(read_common_block): Likewise.
|
|
|
|
|
|
(read_namespace_type): Likewise.
|
|
|
|
|
|
(read_namespace): Likewise.
|
|
|
|
|
|
(read_module_type): Likewise.
|
|
|
|
|
|
(read_tag_pointer_type): Likewise.
|
|
|
|
|
|
(read_tag_ptr_to_member_type): Likewise.
|
|
|
|
|
|
(read_tag_string_type): Likewise.
|
|
|
|
|
|
(read_subroutine_type): Likewise.
|
|
|
|
|
|
(read_typedef): Likewise.
|
|
|
|
|
|
(read_base_type): Likewise.
|
|
|
|
|
|
(attr_to_dynamic_prop): Likewise.
|
|
|
|
|
|
(read_subrange_type): Likewise.
|
|
|
|
|
|
(read_unspecified_type): Likewise.
|
|
|
|
|
|
(load_partial_dies): Likewise.
|
|
|
|
|
|
(read_partial_die): Likewise.
|
|
|
|
|
|
(find_partial_die): Likewise.
|
|
|
|
|
|
(guess_partial_die_structure_name): Likewise.
|
|
|
|
|
|
(fixup_partial_die): Likewise.
|
|
|
|
|
|
(read_attribute_value): Likewise.
|
|
|
|
|
|
(read_addr_index_from_leb128): Likewise.
|
|
|
|
|
|
(dwarf2_read_addr_index): Likewise.
|
|
|
|
|
|
(dwarf2_string_attr): Likewise.
|
|
|
|
|
|
(lnp_state_machine::check_line_address): Likewise.
|
|
|
|
|
|
(dwarf_decode_lines_1): Likewise.
|
|
|
|
|
|
(dwarf_decode_lines): Likewise.
|
|
|
|
|
|
(dwarf2_start_symtab): Likewise.
|
|
|
|
|
|
(var_decode_location): Likewise.
|
|
|
|
|
|
(new_symbol_full): Likewise.
|
|
|
|
|
|
(dwarf2_const_value_data): Likewise.
|
|
|
|
|
|
(dwarf2_const_value_attr): Likewise.
|
|
|
|
|
|
(dwarf2_const_value): Likewise.
|
|
|
|
|
|
(die_type): Likewise.
|
|
|
|
|
|
(die_containing_type): Likewise.
|
|
|
|
|
|
(lookup_die_type): Likewise.
|
|
|
|
|
|
(guess_full_die_structure_name): Likewise.
|
|
|
|
|
|
(anonymous_struct_prefix): Likewise.
|
|
|
|
|
|
(dwarf2_name): Likewise.
|
|
|
|
|
|
(follow_die_ref_or_sig): Likewise.
|
|
|
|
|
|
(follow_die_offset): Likewise.
|
|
|
|
|
|
(follow_die_ref): Likewise.
|
|
|
|
|
|
(dwarf2_fetch_die_loc_sect_off): Likewise.
|
|
|
|
|
|
(dwarf2_fetch_constant_bytes): Likewise.
|
|
|
|
|
|
(dwarf2_fetch_die_type_sect_off): Likewise.
|
|
|
|
|
|
(dwarf2_get_die_type): Likewise.
|
|
|
|
|
|
(follow_die_sig): Likewise.
|
|
|
|
|
|
(decode_locdesc): Likewise.
|
|
|
|
|
|
(dwarf2_per_cu_objfile): Likewise.
|
|
|
|
|
|
(dwarf2_per_cu_text_offset): Likewise.
|
|
|
|
|
|
(init_one_comp_unit): Assign dwarf2_per_objfile instead of
|
|
|
|
|
|
objfile.
|
|
|
|
|
|
(set_die_type): Access objfile through
|
|
|
|
|
|
dwarf2_per_objfile.
|
|
|
|
|
|
|
2018-01-07 16:48:21 +01:00
|
|
|
|
2018-01-07 Simon Marchi <simon.marchi@ericsson.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (converted_character_d): Remove typedef.
|
|
|
|
|
|
(DEF_VEC_O (converted_character_d)): Remove.
|
|
|
|
|
|
(count_next_character): Use std::vector.
|
|
|
|
|
|
(print_converted_chars_to_obstack): Likewise.
|
|
|
|
|
|
(generic_printstr): Likewise.
|
|
|
|
|
|
|
2018-01-07 15:29:52 +01:00
|
|
|
|
2018-01-07 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* xml-support.h (struct gdb_xml_value): Add constructor.
|
|
|
|
|
|
<value>: Change type to unique_xmalloc_ptr.
|
|
|
|
|
|
(gdb_xml_value_s): Remove typedef.
|
|
|
|
|
|
(DEF_VEC_O (gdb_xml_value_s)): Remove.
|
|
|
|
|
|
(gdb_xml_element_start_handler): Change parameter type to
|
|
|
|
|
|
std::vector.
|
|
|
|
|
|
(xml_find_attribute): Likewise.
|
|
|
|
|
|
* xml-support.c (xml_find_attribute): Change parameter type to
|
|
|
|
|
|
std::vector and adjust.
|
|
|
|
|
|
(gdb_xml_values_cleanup): Remove.
|
|
|
|
|
|
(gdb_xml_parser::start_element): Adjust to std::vector.
|
|
|
|
|
|
(xinclude_start_include): Change paraeter type to std::vector
|
|
|
|
|
|
and adjust.
|
|
|
|
|
|
* btrace.c (check_xml_btrace_version): Likewise.
|
|
|
|
|
|
(parse_xml_btrace_block): Likewise.
|
|
|
|
|
|
(parse_xml_btrace_pt_config_cpu): Likewise.
|
|
|
|
|
|
(parse_xml_btrace_pt): Likewise.
|
|
|
|
|
|
(parse_xml_btrace_conf_bts): Likewise.
|
|
|
|
|
|
(parse_xml_btrace_conf_pt): Likewise.
|
|
|
|
|
|
* memory-map.c (memory_map_start_memory): Likewise.
|
|
|
|
|
|
(memory_map_start_property): Likewise.
|
|
|
|
|
|
* osdata.c (osdata_start_osdata): Likewise.
|
|
|
|
|
|
(osdata_start_item): Likewise.
|
|
|
|
|
|
(osdata_start_column): Likewise.
|
|
|
|
|
|
* remote.c (start_thread): Likewise.
|
|
|
|
|
|
* solib-aix.c (library_list_start_library): Likewise.
|
|
|
|
|
|
(library_list_start_list): Likewise.
|
|
|
|
|
|
* solib-svr4.c (library_list_start_library): Likewise.
|
|
|
|
|
|
(svr4_library_list_start_list): Likewise.
|
|
|
|
|
|
* solib-target.c (library_list_start_segment): Likewise.
|
|
|
|
|
|
(library_list_start_section): Likewise.
|
|
|
|
|
|
(library_list_start_library): Likewise.
|
|
|
|
|
|
(library_list_start_list): Likewise.
|
|
|
|
|
|
* tracepoint.c (traceframe_info_start_memory): Likewise.
|
|
|
|
|
|
(traceframe_info_start_tvar): Likewise.
|
|
|
|
|
|
* xml-syscall.c (syscall_start_syscall): Likewise.
|
|
|
|
|
|
* xml-tdesc.c (tdesc_start_target): Likewise.
|
|
|
|
|
|
(tdesc_start_feature): Likewise.
|
|
|
|
|
|
(tdesc_start_reg): Likewise.
|
|
|
|
|
|
(tdesc_start_union): Likewise.
|
|
|
|
|
|
(tdesc_start_struct): Likewise.
|
|
|
|
|
|
(tdesc_start_flags): Likewise.
|
|
|
|
|
|
(tdesc_start_enum): Likewise.
|
|
|
|
|
|
(tdesc_start_field): Likewise.
|
|
|
|
|
|
(tdesc_start_enum_value): Likewise.
|
|
|
|
|
|
(tdesc_start_vector): Likewise.
|
|
|
|
|
|
|
2018-01-07 15:25:33 +01:00
|
|
|
|
2018-01-07 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* extension.h (struct xmethod_worker) <clone>: Remove.
|
|
|
|
|
|
* python/py-xmethods.c (struct python_xmethod_worker) <clone>:
|
|
|
|
|
|
Remove.
|
|
|
|
|
|
(python_xmethod_worker::clone): Remove.
|
|
|
|
|
|
* valops.c (find_overload_match): Use std::move instead of
|
|
|
|
|
|
clone.
|
|
|
|
|
|
|
C++ify xmethod_worker, get rid of VEC(xmethod_worker_ptr)
The initial goal of this patch was to remove the usage of
VEC(xmethod_worker_ptr) and corresponding cleanups. I ended up having
to C++ify the xmethod_worker code, to be able to have xmethod_workers
free their data in destructors, and therefore be able to use vectors of
xmethod_worker unique_ptr.
The operations in extension_language_ops that act on one instance of
xmethod_worker (get result type, get args type, invoke) are transformed
to methods of xmethod_worker. xmethod_worker becomes an abstract base
class with virtual pure methods which python_xmethod_worker implements.
The only xmethod-related operation left in extension_language_ops is
get_matching_xmethod_workers, which returns a list of xmethod_workers.
The changes are relatively straightforward, but here are some notes on
things that may raise eyebrows:
- I was not really comfortable with the value_of_xmethod function. At
first it looks like a simple getter, so I considered making it a
method of xmethod_worker. But actually it creates a value and
transfers the ownership of the xmethod_worker to it. It would be a
bit weird and error-prone if calling a method on an object silently
removed the ownership of the object from the caller. To reflect the
behavior more accurately, I renamed it to value_from_xmethod and made
it accept an rvalue-reference (so the caller knows it gives away the
ownership). I noticed the backlink from xmethod_worker to its owning
value was not used, so I removed it.
- Some code, like get_matching_xmethod_workers, made each callee fill
a new vector, which was then merged in the result vector. I think
it's safe if we always pass the same vector around, and each
implementation just appends to it.
- The clone operation does not seem particularly useful, it is removed
in the following patch.
gdb/ChangeLog:
* extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
(struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
<free_xmethod_worker_data>: Remove.
<get_matching_xmethod_workers>: Chance VEC to std::vector.
<get_xmethod_arg_types>: Remove.
<get_xmethod_result_type>: Remove.
<invoke_xmethod>: Remove.
* extension.c (new_xmethod_worker): Remove.
(clone_xmethod_worker): Remove.
(get_matching_xmethod_workers): Return void, pass std::vector by
pointer.
(get_xmethod_arg_types): Rename to...
(xmethod_worker::get_arg_types): ... this, and adjust.
(get_xmethod_result_type): Rename to...
(xmethod_worker::get_result_type): ... this, and adjust.
(invoke_xmethod): Remove.
(free_xmethod_worker): Remove.
(free_xmethod_worker_vec): Remove.
* extension.h (enum ext_lang_rc): Move here from
extension-priv.h.
(struct xmethod_worker): Add constructor and destructor.
<data>: Remove.
<value>: Remove.
<invoke, clone, do_get_result_type, do_get_arg_types>: New
virtual pure methods.
<get_arg_types, get_result_type>: New methods.
(xmethod_worker_ptr): Remove typedef.
(DEF_VEC_P (xmethod_worker_ptr)): Remove.
(xmethod_worker_vec): Remove typedef.
(xmethod_worker_up): New typedef.
(invoke_xmethod): Remove.
(clone_xmethod_worker): Remove.
(free_xmethod_worker): Remove.
(free_xmethod_worker_vec): Remove.
(get_xmethod_arg_types): Remove.
(get_xmethod_result_type): Remove.
* valops.c (find_method_list): Use std::vector, don't use
intermediate vector.
(value_find_oload_method_list): Use std::vector.
(find_overload_match): Use std::vector.
(find_oload_champ): Use std::vector.
* value.c (value_free): Use operator delete.
(value_of_xmethod): Rename to...
(value_from_xmethod): ... this. Don't assign
xmethod_worker::value, take rvalue-reference.
(result_type_of_xmethod): Adjust.
(call_xmethod): Adjust.
* value.h: Include extension.h.
(struct xmethod_worker): Don't forward-declare.
(value_of_xmethod): Rename to...
(value_from_xmethod): ... this, take rvalue-reference.
* python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
(struct python_xmethod_worker): ... this, add constructor and
destructor.
<invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
(gdbpy_free_xmethod_worker_data): Rename to...
(python_xmethod_worker::~python_xmethod_worker): ... this and
adjust.
(gdbpy_clone_xmethod_worker_data): Rename to...
(python_xmethod_worker::clone): ... this and adjust.
(gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
temporary vector.
(gdbpy_get_xmethod_arg_types): Rename to...
(python_xmethod_worker::do_get_arg_types): ... this and adjust.
(gdbpy_get_xmethod_result_type): Rename to...
(python_xmethod_worker::do_get_result_type): ... this and
adjust.
(gdbpy_invoke_xmethod): Rename to...
(python_xmethod_worker::invoke): ... this and adjust.
(new_python_xmethod_worker): Rename to...
(python_xmethod_worker::python_xmethod_worker): ... this and
adjust.
* python/python-internal.h (gdbpy_clone_xmethod_worker_data):
Remove.
(gdbpy_free_xmethod_worker_data): Remove.
(gdbpy_get_matching_xmethod_workers): Use std::vector.
(gdbpy_get_xmethod_arg_types): Remove.
(gdbpy_get_xmethod_result_type): Remove.
(gdbpy_invoke_xmethod): Remove.
* python/python.c (python_extension_ops): Remove obsolete
callbacks.
2018-01-07 15:25:32 +01:00
|
|
|
|
2018-01-07 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
|
|
|
|
|
|
(struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
|
|
|
|
|
|
<free_xmethod_worker_data>: Remove.
|
|
|
|
|
|
<get_matching_xmethod_workers>: Chance VEC to std::vector.
|
|
|
|
|
|
<get_xmethod_arg_types>: Remove.
|
|
|
|
|
|
<get_xmethod_result_type>: Remove.
|
|
|
|
|
|
<invoke_xmethod>: Remove.
|
|
|
|
|
|
* extension.c (new_xmethod_worker): Remove.
|
|
|
|
|
|
(clone_xmethod_worker): Remove.
|
|
|
|
|
|
(get_matching_xmethod_workers): Return void, pass std::vector by
|
|
|
|
|
|
pointer.
|
|
|
|
|
|
(get_xmethod_arg_types): Rename to...
|
|
|
|
|
|
(xmethod_worker::get_arg_types): ... this, and adjust.
|
|
|
|
|
|
(get_xmethod_result_type): Rename to...
|
|
|
|
|
|
(xmethod_worker::get_result_type): ... this, and adjust.
|
|
|
|
|
|
(invoke_xmethod): Remove.
|
|
|
|
|
|
(free_xmethod_worker): Remove.
|
|
|
|
|
|
(free_xmethod_worker_vec): Remove.
|
|
|
|
|
|
* extension.h (enum ext_lang_rc): Move here from
|
|
|
|
|
|
extension-priv.h.
|
|
|
|
|
|
(struct xmethod_worker): Add constructor and destructor.
|
|
|
|
|
|
<data>: Remove.
|
|
|
|
|
|
<value>: Remove.
|
|
|
|
|
|
<invoke, clone, do_get_result_type, do_get_arg_types>: New
|
|
|
|
|
|
virtual pure methods.
|
|
|
|
|
|
<get_arg_types, get_result_type>: New methods.
|
|
|
|
|
|
(xmethod_worker_ptr): Remove typedef.
|
|
|
|
|
|
(DEF_VEC_P (xmethod_worker_ptr)): Remove.
|
|
|
|
|
|
(xmethod_worker_vec): Remove typedef.
|
|
|
|
|
|
(xmethod_worker_up): New typedef.
|
|
|
|
|
|
(invoke_xmethod): Remove.
|
|
|
|
|
|
(clone_xmethod_worker): Remove.
|
|
|
|
|
|
(free_xmethod_worker): Remove.
|
|
|
|
|
|
(free_xmethod_worker_vec): Remove.
|
|
|
|
|
|
(get_xmethod_arg_types): Remove.
|
|
|
|
|
|
(get_xmethod_result_type): Remove.
|
|
|
|
|
|
* valops.c (find_method_list): Use std::vector, don't use
|
|
|
|
|
|
intermediate vector.
|
|
|
|
|
|
(value_find_oload_method_list): Use std::vector.
|
|
|
|
|
|
(find_overload_match): Use std::vector.
|
|
|
|
|
|
(find_oload_champ): Use std::vector.
|
|
|
|
|
|
* value.c (value_free): Use operator delete.
|
|
|
|
|
|
(value_of_xmethod): Rename to...
|
|
|
|
|
|
(value_from_xmethod): ... this. Don't assign
|
|
|
|
|
|
xmethod_worker::value, take rvalue-reference.
|
|
|
|
|
|
(result_type_of_xmethod): Adjust.
|
|
|
|
|
|
(call_xmethod): Adjust.
|
|
|
|
|
|
* value.h: Include extension.h.
|
|
|
|
|
|
(struct xmethod_worker): Don't forward-declare.
|
|
|
|
|
|
(value_of_xmethod): Rename to...
|
|
|
|
|
|
(value_from_xmethod): ... this, take rvalue-reference.
|
|
|
|
|
|
* python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
|
|
|
|
|
|
(struct python_xmethod_worker): ... this, add constructor and
|
|
|
|
|
|
destructor.
|
|
|
|
|
|
<invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
|
|
|
|
|
|
(gdbpy_free_xmethod_worker_data): Rename to...
|
|
|
|
|
|
(python_xmethod_worker::~python_xmethod_worker): ... this and
|
|
|
|
|
|
adjust.
|
|
|
|
|
|
(gdbpy_clone_xmethod_worker_data): Rename to...
|
|
|
|
|
|
(python_xmethod_worker::clone): ... this and adjust.
|
|
|
|
|
|
(gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
|
|
|
|
|
|
temporary vector.
|
|
|
|
|
|
(gdbpy_get_xmethod_arg_types): Rename to...
|
|
|
|
|
|
(python_xmethod_worker::do_get_arg_types): ... this and adjust.
|
|
|
|
|
|
(gdbpy_get_xmethod_result_type): Rename to...
|
|
|
|
|
|
(python_xmethod_worker::do_get_result_type): ... this and
|
|
|
|
|
|
adjust.
|
|
|
|
|
|
(gdbpy_invoke_xmethod): Rename to...
|
|
|
|
|
|
(python_xmethod_worker::invoke): ... this and adjust.
|
|
|
|
|
|
(new_python_xmethod_worker): Rename to...
|
|
|
|
|
|
(python_xmethod_worker::python_xmethod_worker): ... this and
|
|
|
|
|
|
adjust.
|
|
|
|
|
|
* python/python-internal.h (gdbpy_clone_xmethod_worker_data):
|
|
|
|
|
|
Remove.
|
|
|
|
|
|
(gdbpy_free_xmethod_worker_data): Remove.
|
|
|
|
|
|
(gdbpy_get_matching_xmethod_workers): Use std::vector.
|
|
|
|
|
|
(gdbpy_get_xmethod_arg_types): Remove.
|
|
|
|
|
|
(gdbpy_get_xmethod_result_type): Remove.
|
|
|
|
|
|
(gdbpy_invoke_xmethod): Remove.
|
|
|
|
|
|
* python/python.c (python_extension_ops): Remove obsolete
|
|
|
|
|
|
callbacks.
|
|
|
|
|
|
|
Fix regression: cannot start with LD_PRELOAD=libSegFault.so (PR gdb/18653#c7)
At https://sourceware.org/bugzilla/show_bug.cgi?id=18653#c7, Andrew
reports that the fix for PR gdb/18653 made GDB useless if you preload
libSegFault.so, because GDB internal-errors on startup:
$ LD_PRELOAD=libSegFault.so gdb
src/gdb/common/signals-state-save-restore.c:64: internal-error: unexpected signal handler
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Aborted (core dumped)
$
The internal error comes from the code saving the signal dispositions
inherited from gdb's parent:
(top-gdb) bt
#0 0x000000000056b001 in internal_error(char const*, int, char const*, ...) (file=0xaf5f38 "src/gdb/common/signals-state-save-restore.c", line=64, fmt=0xaf5f18 "unexpected signal handler") at src/gdb/common/errors.c:54
#1 0x00000000005752c9 in save_original_signals_state() () at src/gdb/common/signals-state-save-restore.c:64
#2 0x00000000007425de in captured_main_1(captured_main_args*) (context=0x7fffffffd860)
at src/gdb/main.c:509
#3 0x0000000000743622 in captured_main(void*) (data=0x7fffffffd860) at src/gdb/main.c:1145
During symbol reading, cannot get low and high bounds for subprogram DIE at 24065.
#4 0x00000000007436f9 in gdb_main(captured_main_args*) (args=0x7fffffffd860) at src/gdb/main.c:1171
#5 0x0000000000413acd in main(int, char**) (argc=1, argv=0x7fffffffd968) at src/gdb/gdb.c:32
This commit downgrades the internal error to a warning. You'll get
instead:
~~~
$ LD_PRELOAD=libSegFault.so gdb
warning: Found custom handler for signal 11 (Segmentation fault) preinstalled.
Some signal dispositions inherited from the environment (SIG_DFL/SIG_IGN)
won't be propagated to spawned programs.
GNU gdb (GDB) 8.0.50.20171213-git
Copyright (C) 2017 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
(gdb)
~~~
This also moves the location where save_original_signals_state is
called a bit further below (to after option processing), so that "-q"
disables the warning:
~~~
$ LD_PRELOAD=libSegFault.so gdb -q
(gdb)
~~~
New testcase included.
gdb/ChangeLog:
2018-01-05 Pedro Alves <palves@redhat.com>
PR gdb/18653
* common/signals-state-save-restore.c
(save_original_signals_state): New parameter 'quiet'. Warn if we
find a custom handler preinstalled, instead of internal erroring.
But only warn if !quiet.
* common/signals-state-save-restore.h
(save_original_signals_state): New parameter 'quiet'.
* main.c (captured_main_1): Move save_original_signals_state call
after option handling, and pass QUIET.
gdb/gdbserver/ChangeLog:
2018-01-05 Pedro Alves <palves@redhat.com>
PR gdb/18653
* server.c (captured_main): Pass quiet=false to
save_original_signals_state.
gdb/testsuite/ChangeLog:
2018-01-05 Pedro Alves <palves@redhat.com>
PR gdb/18653
* gdb.base/libsegfault.exp: New.
2018-01-05 19:26:18 +01:00
|
|
|
|
2018-01-05 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/18653
|
|
|
|
|
|
* common/signals-state-save-restore.c
|
|
|
|
|
|
(save_original_signals_state): New parameter 'quiet'. Warn if we
|
|
|
|
|
|
find a custom handler preinstalled, instead of internal erroring.
|
|
|
|
|
|
But only warn if !quiet.
|
|
|
|
|
|
* common/signals-state-save-restore.h
|
|
|
|
|
|
(save_original_signals_state): New parameter 'quiet'.
|
|
|
|
|
|
* main.c (captured_main_1): Move save_original_signals_state call
|
|
|
|
|
|
after option handling, and pass QUIET.
|
|
|
|
|
|
|
2018-01-05 18:56:33 +01:00
|
|
|
|
2018-01-05 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* spu-tdep.c (spu_catch_start): Pass
|
|
|
|
|
|
symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
|
|
|
|
|
|
|
Fix regresssion(internal-error) printing subprogram argument (PR gdb/22670)
At <https://sourceware.org/ml/gdb-patches/2017-12/msg00298.html>, Joel
wrote:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Consider the following code which first declares a tagged type (the
equivalent of a class in Ada), and then a procedure which takes a
pointer (access) to this type's 'Class.
package Pck is
type Top_T is tagged record
N : Integer := 1;
end record;
procedure Inspect (Obj: access Top_T'Class);
end Pck;
Putting a breakpoint in that procedure and then running to it triggers
an internal error:
(gdb) break inspect
(gdb) continue
Breakpoint 1, pck.inspect (obj=0x63e010
/[...]/gdb/stack.c:621: internal-error: void print_frame_args(symbol*, frame_info*, int, ui_file*): Assertion `nsym != NULL' failed.
What's special about this subprogram is that it takes an access to
what we call a 'Class type, and for implementation reasons, the
compiler adds an extra argument named "objL". If you are curious why,
it allows the compiler for perform dynamic accessibility checks that
are mandated by the language.
If we look at the location where we get the internal error (in
stack.c), we find that we are looping over the symbol of each
parameter, and for each parameter, we do:
/* We have to look up the symbol because arguments can have
two entries (one a parameter, one a local) and the one we
want is the local, which lookup_symbol will find for us.
[...]
nsym = lookup_symbol (SYMBOL_LINKAGE_NAME (sym),
b, VAR_DOMAIN, NULL).symbol;
gdb_assert (nsym != NULL);
The lookup_symbol goes through the lookup structure, which means the
symbol's linkage name ("objL") gets transformed into a
lookup_name_info object (in block_lookup_symbol), before it gets fed
to the block symbol dictionary iterators. This, in turn, triggers the
symbol matching by comparing the "lookup" name which, for Ada, means
among other things, lowercasing the given name to "objl". It is this
transformation that causes the lookup find no matches, and therefore
trip this assertion.
Going back to the "offending" call to lookup_symbol in stack.c, what
we are trying to do, here, is do a lookup by linkage name. So, I
think what we mean to be doing is a completely literal symbol lookup,
so maybe not even strcmp_iw, but actually just plain strcmp???
In the past, in practice, you could get that effect by doing a lookup
using the C language. But that doesn't work, because we still end up
somehow using Ada's lookup_name routine which transforms "objL".
So, ideally, as I hinted before, I think what we need is a way to
perform a literal lookup so that searches by linkage names like the
above can be performed.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This commit fixes the problem by implementing something similar to
Joel's literal idea, but with some important differences.
I considered adding a symbol_name_match_type::LINKAGE and supporting
searching by linkage name for any language, but the problem with that
is that the dictionaries only work with SYMBOL_SEARCH_NAME, because
that's what is used for hashing. We'd need separate dictionaries for
hashed linkage names.
So with the current symbol tables infrastructure, it's not literal
linkage names that we want to pass down, but instead literal _search_
names (SYMBOL_SEARCH_NAME, etc.).
However, psymbols have no overload/function parameter info in C++, so
a straight strcmp doesn't work properly for C++ name matching.
So what we do is be a little less aggressive then and add a new
symbol_name_match_type::SEARCH_SYMBOL instead that takes as input a
non-user-input search symbol, and then we skip any decoding/demangling
steps and make:
- Ada treat that as a verbatim match,
- other languages treat it as symbol_name_match_type::FULL.
This also fixes the new '"maint check-psymtabs" for Ada' testcase for
me (gdb.ada/maint_with_ada.exp). I've not removed the kfail yet
because Joel still sees that testcase failing with this patch.
That'll be fixed in follow up patches.
gdb/ChangeLog:
2018-01-05 Pedro Alves <palves@redhat.com>
PR gdb/22670
* ada-lang.c (literal_symbol_name_matcher): New function.
(ada_get_symbol_name_matcher): Use it for
symbol_name_match_type::SEARCH_NAME.
* block.c (block_lookup_symbol): New parameter 'match_type'. Pass
it down instead of assuming symbol_name_match_type::FULL.
* block.h (block_lookup_symbol): New parameter 'match_type'.
* c-valprint.c (print_unpacked_pointer): Use
lookup_symbol_search_name instead of lookup_symbol.
* compile/compile-object-load.c (get_out_value_type): Pass down
symbol_name_match_type::SEARCH_NAME.
* cp-namespace.c (cp_basic_lookup_symbol): Pass down
symbol_name_match_type::FULL.
* cp-support.c (cp_get_symbol_name_matcher): Handle
symbol_name_match_type::SEARCH_NAME.
* infrun.c (insert_exception_resume_breakpoint): Use
lookup_symbol_search_name.
* p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
* psymtab.c (maintenance_check_psymtabs): Use
symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
* stack.c (print_frame_args): Use lookup_symbol_search_name and
SYMBOL_SEARCH_NAME.
* symtab.c (lookup_local_symbol): Don't demangle the lookup name
if symbol_name_match_type::SEARCH_NAME.
(lookup_symbol_in_language): Pass down
symbol_name_match_type::FULL.
(lookup_symbol_search_name): New.
(lookup_language_this): Pass down
symbol_name_match_type::SEARCH_NAME.
(lookup_symbol_aux, lookup_local_symbol): New parameter
'match_type'. Pass it down.
* symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
(lookup_symbol_search_name): New declaration.
(lookup_symbol_in_block): New 'match_type' parameter.
gdb/testsuite/ChangeLog:
2018-01-05 Joel Brobecker <brobecker@adacore.com>
PR gdb/22670
* gdb.ada/access_tagged_param.exp: New file.
* gdb.ada/access_tagged_param/foo.adb: New file.
2018-01-05 15:04:09 +01:00
|
|
|
|
2018-01-05 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/22670
|
|
|
|
|
|
* ada-lang.c (literal_symbol_name_matcher): New function.
|
|
|
|
|
|
(ada_get_symbol_name_matcher): Use it for
|
|
|
|
|
|
symbol_name_match_type::SEARCH_NAME.
|
|
|
|
|
|
* block.c (block_lookup_symbol): New parameter 'match_type'. Pass
|
|
|
|
|
|
it down instead of assuming symbol_name_match_type::FULL.
|
|
|
|
|
|
* block.h (block_lookup_symbol): New parameter 'match_type'.
|
|
|
|
|
|
* c-valprint.c (print_unpacked_pointer): Use
|
|
|
|
|
|
lookup_symbol_search_name instead of lookup_symbol.
|
|
|
|
|
|
* compile/compile-object-load.c (get_out_value_type): Pass down
|
|
|
|
|
|
symbol_name_match_type::SEARCH_NAME.
|
|
|
|
|
|
* cp-namespace.c (cp_basic_lookup_symbol): Pass down
|
|
|
|
|
|
symbol_name_match_type::FULL.
|
|
|
|
|
|
* cp-support.c (cp_get_symbol_name_matcher): Handle
|
|
|
|
|
|
symbol_name_match_type::SEARCH_NAME.
|
|
|
|
|
|
* infrun.c (insert_exception_resume_breakpoint): Use
|
|
|
|
|
|
lookup_symbol_search_name.
|
|
|
|
|
|
* p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
|
|
|
|
|
|
* psymtab.c (maintenance_check_psymtabs): Use
|
|
|
|
|
|
symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
|
|
|
|
|
|
* stack.c (print_frame_args): Use lookup_symbol_search_name and
|
|
|
|
|
|
SYMBOL_SEARCH_NAME.
|
|
|
|
|
|
* symtab.c (lookup_local_symbol): Don't demangle the lookup name
|
|
|
|
|
|
if symbol_name_match_type::SEARCH_NAME.
|
|
|
|
|
|
(lookup_symbol_in_language): Pass down
|
|
|
|
|
|
symbol_name_match_type::FULL.
|
|
|
|
|
|
(lookup_symbol_search_name): New.
|
|
|
|
|
|
(lookup_language_this): Pass down
|
|
|
|
|
|
symbol_name_match_type::SEARCH_NAME.
|
|
|
|
|
|
(lookup_symbol_aux, lookup_local_symbol): New parameter
|
|
|
|
|
|
'match_type'. Pass it down.
|
|
|
|
|
|
* symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
|
|
|
|
|
|
(lookup_symbol_search_name): New declaration.
|
|
|
|
|
|
(lookup_symbol_in_block): New 'match_type' parameter.
|
|
|
|
|
|
|
2018-01-05 17:01:57 +01:00
|
|
|
|
2018-01-05 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/22670
|
|
|
|
|
|
* ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
|
|
|
|
|
|
ada_lookup_symbol.
|
|
|
|
|
|
(ada_lookup_symbol): Reimplement in terms of
|
|
|
|
|
|
ada_lookup_symbol_list, bits factored out from
|
|
|
|
|
|
ada_lookup_encoded_symbol.
|
|
|
|
|
|
|
(Ada) problem printing renaming which references a subprogram parameter
Consider the following code, which creates a local variable B
which is a renaming whose expression references a subprogram
parameter:
procedure Flip (Bits : in out Bits_Type; I : Natural) is
begin
declare
B : Boolean renames Bits (I);
begin
B := not B; -- BREAK
end;
end Flip;
Trying to print the value of B when at the "BREAK" line currently
does not work:
(gdb) p b
Could not find i
What happens is the following: For the renaming, GNAT generates
a variable whose name is encoded as follow:
b___XR_bits___XEXSi
GDB properly detects that variable, determines that, to compute
the variable's value, we start from the symbol "Bits", which
we then have to subscript (XS) using 'i' as the index. The error
occurs while trying to find 'i'.
This is because we forgot to pass the block in the call to
ada_lookup_encoded_symbol, which this patch fixes.
gdb/ChangeLog:
* ada-exp.y (write_object_renaming): When subscripting an array
using a symbol as the index, pass the block in call to
ada_lookup_encoded_symbol when looking that symbol up.
gdb/testsuite/ChangeLog:
* gdb.ada/rename_subscript_param: New testcase.
Tested on x86_64-linux.
Note: This requires the following GCC patch:
| 2017-04-25 Pierre-Marie de Rodat <derodat@adacore.com>
|
| * exp_dbug.adb: In Debug_Renaming_Declaration,
| when dealing with indexed component, accept to produce a renaming
| symbol when the index is an IN parameter or when it is a name
| defined in an outer scope.
2018-01-05 10:29:54 +01:00
|
|
|
|
2018-01-05 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-exp.y (write_object_renaming): When subscripting an array
|
|
|
|
|
|
using a symbol as the index, pass the block in call to
|
|
|
|
|
|
ada_lookup_encoded_symbol when looking that symbol up.
|
|
|
|
|
|
|
(Ada) Fix Length attribute on array access
Consider the following variable "Indexed_By_Enum", declared as
an access to an array whose index type is an enumerated type
whose underlying values have "gaps":
type Enum_With_Gaps is (LIT0, LIT1, LIT2, LIT3, LIT4);
for Enum_With_Gaps use (LIT0 => 3,
LIT1 => 5,
LIT2 => 8,
LIT3 => 13,
LIT4 => 21);
for Enum_With_Gaps'size use 16;
type MyWord is range 0 .. 16#FFFF# ;
for MyWord'Size use 16;
type AR is array (Enum_With_Gaps range <>) of MyWord;
type AR_Access is access AR;
Indexed_By_Enum : AR_Access :=
new AR'(LIT1 => 1, LIT2 => 43, LIT3 => 42, LIT4 => 41);
Trying to print the length (number of elements) of this array using
the 'Length attribute does not work:
(gdb) print indexed_by_enum'length
'POS only defined on discrete types
The problem occurs while trying to get the array's index type.
It was using TYPE_INDEX_TYPE for that. It does not work for Ada arrays
in general; use ada_index_type instead.
gdb/ChangeLog:
* ada-lang.c (ada_array_length): Use ada_index_type instead of
TYPE_INDEX_TYPE.
gdb/testsuite/ChangeLog:
* gdb.ada/arr_acc_idx_w_gap: New testcase.
Tested on x86_64-linux.
2018-01-05 09:03:59 +01:00
|
|
|
|
2018-01-05 Jerome Guitton <guitton@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-lang.c (ada_array_length): Use ada_index_type instead of
|
|
|
|
|
|
TYPE_INDEX_TYPE.
|
|
|
|
|
|
|
memory error printing component of record from convenience variable
Consider the following situation Ada code:
type Kind_T is (One, Two, Three);
type Time_Set_T is array (Kind_T) of Integer;
type T is record
Started : Time_Set_T;
end record;
Null_T : constant T := (Started => (others => 0));
My_Item : Pck.T := Pck.Null_T;
Trying to print the value of My_Item.Started is no problem:
(gdb) p item.started
$1 = (0, 0, 0)
However, if you save My_Item into a convenience variable first,
and then try to print a component of that record, you get
an unexpected memory error, instead of getting the same result.
For instance:
(gdb) set variable $item := item
(gdb) p $item.started
Cannot access memory at address 0x0
The issue occurs when, after we extracted the component from
the convenience variable, we next try to "fix" it (which is
ada-lang speak for resolving the type into a static type).
This is done in ada_to_fixed_value, which delegates to
ada_to_fixed_value_create via:
val = ada_to_fixed_value_create (value_type (val),
value_address (val), val);
And looking at ada_to_fixed_value_create, we see that:
struct type *type = ada_to_fixed_type (type0, 0, address, NULL, 1);
if (type == type0 && val0 != NULL)
return val0;
else
return value_from_contents_and_address (type, 0, address);
The part that interests us, in this case, is the "else" branch,
where we obviously make the implicit assumption that our object
has an address, which is not true, in this case, because we are
actually dealing with a convenience variable.
This patch plugs that hole by adding special handing for situations
where val does not live in memory. In that case, we just create
a not_lval value using val's contents.
gdb/ChangeLog:
* ada-lang.c (ada_to_fixed_value_create): Add handling of
the case where VALUE_LVAL (val0) is not lval_memory.
gdb/testsuite/ChangeLog:
* gdb.ada/convvar_comp: New testcase.
Tested on x86_64-linux.
2018-01-05 08:37:38 +01:00
|
|
|
|
2018-01-05 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-lang.c (ada_to_fixed_value_create): Add handling of
|
|
|
|
|
|
the case where VALUE_LVAL (val0) is not lval_memory.
|
|
|
|
|
|
|
2018-01-05 08:39:10 +01:00
|
|
|
|
2018-01-05 Xavier Roirand <roirand@adacore.com>
|
2018-01-05 05:47:05 +01:00
|
|
|
|
|
|
|
|
|
|
* ada-valprint.c (print_optional_low_bound): Handle
|
|
|
|
|
|
character-indexed array printing like boolean-indexed array
|
|
|
|
|
|
printing.
|
|
|
|
|
|
|
2018-01-05 05:18:05 +01:00
|
|
|
|
2018-01-05 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Create a new section for the next release branch.
|
|
|
|
|
|
Rename the section of the current branch, now that it has
|
|
|
|
|
|
been cut.
|
|
|
|
|
|
|
2018-01-05 05:08:09 +01:00
|
|
|
|
2018-01-05 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
|
|
|
|
|
|
* version.in: Bump version to 8.1.50.DATE-git.
|
|
|
|
|
|
|
(Ada) New command to stop at start of exception handler.
When using gdb for debugging Ada source code, there are several catchpoint
types you can define in order to stop upon certain conditions. Let's
use this small example:
procedure Foo is
begin
begin
raise Constraint_Error;
exception
when Program_Error =>
null;
when Constraint_Error =>
null;
when others =>
null;
end;
end Foo;
One can stop when the exception is being raised by using the exception
catchpoint like below:
(gdb) catch exception
Catchpoint 1: all Ada exceptions
(gdb)
In that case, when running Foo, gdb will stop at the line where the exception
was raised:
begin
>>> raise Constraint_Error;
exception
This patch introduces new type of catchpoint, when the user wants to stop
at the location of the exception handling.
Imagine we want to stop on any exception handled by the program, we can do:
(gdb) catch handlers
Catchpoint 1: all Ada exceptions handlers
(gdb) r
Starting program: /tmp/foo
By doing so, when running Foo, gdb will stop here:
Catchpoint 1, exception at 0x000000000040255a in foo () at foo.adb:25
25 when Constraint_Error =>
(gdb)
It is also possible to stop when the Constraint_Error exception is being
handled in this program. With this patch, we can use:
(gdb) catch handlers Constraint_Error
Catchpoint 1: `Constraint_Error' Ada exception handlers
(gdb)
Like for other catchpoint, you can set a condition when adding a catchpoint
on exception handlers.
Here the handlers catchpoint checks Global_Var:
(gdb) catch handlers Constraint_Error if Global_Var /= 0
gdb/ChangeLog:
* ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
Add field.
* ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
Add field.
(default_exception_support_info) <catch_handlers_sym>: Add field.
(exception_support_info_fallback) <catch_handlers_sym>: Add field.
(ada_exception_name_addr_1): Add "catch handlers" handling.
(ada_exception_catchpoint_cond_string) <ex>: New parameter.
Update all callers.
(create_excep_cond_exprs) <ex>: Add parameter.
(re_set_exception): Update create_excep_cond_exprs call.
(print_it_exception, print_one_exception, print_mention_exception)
(print_recreate_exception): Add "catch handler" handling.
(allocate_location_catch_handlers, re_set_catch_handlers)
(check_status_catch_handlers, print_it_catch_handlers)
(print_one_catch_handlers, print_mention_catch_handlers)
(print_recreate_catch_handlers): New function.
(catch_handlers_breakpoint_ops): New variable.
(catch_ada_exception_command_split) <is_catch_handlers_cmd>:
Add parameter. Add "catch handler" handling.
(ada_exception_sym_name, ada_exception_breakpoint_ops):
Add "catch handler" handling.
(ada_exception_catchpoint_cond_string): Add "catch handler"
handling.
(create_ada_exception_catchpoint): Update create_excep_cond_exprs
call.
(catch_ada_handlers_command): New function.
(initialize_ada_catchpoint_ops): Initialize "catch handlers"
operations structure.
(_initialize_ada_language): Add "catch handlers" command entry.
* NEWS: Document "catch handlers" feature.
gdb/doc/ChangeLog:
* gdb.texinfo (Set Catchpoints): Add documentation for new
"catch handlers" action.
gdb/testsuite/ChangeLog:
* gdb.ada/excep_handle.exp: New testcase.
* gdb.ada/excep_handle/foo.adb: New file.
* gdb.ada/excep_handle/pck.ads: New file.
Tested on x86_64-linux.
2017-11-22 10:40:39 +01:00
|
|
|
|
2018-01-03 Xavier Roirand <roirand@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
|
|
|
|
|
|
Add field.
|
|
|
|
|
|
* ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
|
|
|
|
|
|
Add field.
|
|
|
|
|
|
(default_exception_support_info) <catch_handlers_sym>: Add field.
|
|
|
|
|
|
(exception_support_info_fallback) <catch_handlers_sym>: Add field.
|
|
|
|
|
|
(ada_exception_name_addr_1): Add "catch handlers" handling.
|
|
|
|
|
|
(ada_exception_catchpoint_cond_string) <ex>: New parameter.
|
|
|
|
|
|
Update all callers.
|
|
|
|
|
|
(create_excep_cond_exprs) <ex>: Add parameter.
|
|
|
|
|
|
(re_set_exception): Update create_excep_cond_exprs call.
|
|
|
|
|
|
(print_it_exception, print_one_exception, print_mention_exception)
|
|
|
|
|
|
(print_recreate_exception): Add "catch handler" handling.
|
|
|
|
|
|
(allocate_location_catch_handlers, re_set_catch_handlers)
|
|
|
|
|
|
(check_status_catch_handlers, print_it_catch_handlers)
|
|
|
|
|
|
(print_one_catch_handlers, print_mention_catch_handlers)
|
|
|
|
|
|
(print_recreate_catch_handlers): New function.
|
|
|
|
|
|
(catch_handlers_breakpoint_ops): New variable.
|
|
|
|
|
|
(catch_ada_exception_command_split) <is_catch_handlers_cmd>:
|
|
|
|
|
|
Add parameter. Add "catch handler" handling.
|
|
|
|
|
|
(ada_exception_sym_name, ada_exception_breakpoint_ops):
|
|
|
|
|
|
Add "catch handler" handling.
|
|
|
|
|
|
(ada_exception_catchpoint_cond_string): Add "catch handler"
|
|
|
|
|
|
handling.
|
|
|
|
|
|
(create_ada_exception_catchpoint): Update create_excep_cond_exprs
|
|
|
|
|
|
call.
|
|
|
|
|
|
(catch_ada_handlers_command): New function.
|
|
|
|
|
|
(initialize_ada_catchpoint_ops): Initialize "catch handlers"
|
|
|
|
|
|
operations structure.
|
|
|
|
|
|
(_initialize_ada_language): Add "catch handlers" command entry.
|
|
|
|
|
|
* NEWS: Document "catch handlers" feature.
|
|
|
|
|
|
|
[gdb/Ada] slices of arrays with dynamic strides
Consider the following Ada code:
procedure Nested (L, U : Integer) is
subtype Small_Type is Integer range L .. U;
type Record_Type (I : Small_Type := L) is record
S : String (1 .. I);
end record;
type Array_Type is array (Integer range <>) of Record_Type;
A1 : Array_Type :=
(1 => (I => 0, S => <>),
2 => (I => 1, S => "A"),
3 => (I => 2, S => "AB"));
procedure Discard (R : Record_Type) is
begin
null;
end Discard;
begin
Discard (A1 (1)); -- STOP
end;
Trying to print a slice of that array currently yields:
(gdb) p a1(1..3)
$1 = ((i => 0, s => ""), (i => 0, s => ""), (i => 0, s => ""))
We expected instead:
(gdb) p a1(1..3)
$1 = ((i => 0, s => ""), (i => 1, s => "A"), (i => 2, s => "AB"))
This is because the functions we use in ada-lang.c to create the type
of the array slice (ada_value_slice and ada_value_slice_from_ptr) was
not taking into account the stride of the array. This patch fixes this.
gdb/ChangeLog:
* ada-lang.c (ada_value_slice_from_ptr): Take array stride into
account when creating the array type of the slice.
(ada_value_slice): Likewise.
gdb/testsuite/ChangeLog:
* gdb.ada/dyn_stride.exp: Add slice test.
Note that, with the current use of ada_value_slice, the enhancement
to handle dynamic array strides seems unnecessary, because I do not
see how an array with a dynamic stride can be referenced by either
by reference or pointer. Since references are coerced to array pointers,
in both cases, the slice is performed by ada_value_slice_from_ptr.
But ada_value_slice is enhanced nonetheless, in the spirit of making
the code more robust, in case we missed something, and also as similar
as possible with its from_ptr counterpart.
tested on x86_64-linux.
2018-01-02 04:53:55 +01:00
|
|
|
|
2018-01-02 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-lang.c (ada_value_slice_from_ptr): Take array stride into
|
|
|
|
|
|
account when creating the array type of the slice.
|
|
|
|
|
|
(ada_value_slice): Likewise.
|
|
|
|
|
|
|
Add support for dynamic DW_AT_byte_stride.
This patch adds support for DW_AT_byte_stride, using Ada as one
example of where this would be useful. However, the implementation
is language-agnostic.
Consider the following Ada code:
procedure Nested (L, U : Integer) is
subtype Small_Type is Integer range L .. U;
type Record_Type (I : Small_Type := L) is record
S : String (1 .. I);
end record;
type Array_Type is array (Integer range <>) of Record_Type;
A1 : Array_Type :=
(1 => (I => 0, S => <>),
2 => (I => 1, S => "A"),
3 => (I => 2, S => "AB"));
procedure Discard (R : Record_Type) is
begin
null;
end Discard;
begin
Discard (A1 (1)); -- STOP
end;
It defines an array A1 of Record_Type, which is a variant record
type whose maximum size actually depends on the value of the
parameters passed when calling Nested. As a result, the stride
of the array A1 cannot be known statically, which leads the compiler
to generate a dynamic DW_AT_byte_stride attribute for our type.
Here is what the debugging info looks like with GNAT:
.uleb128 0x10 # (DIE (0x14e) DW_TAG_array_type)
.long .LASF17 # DW_AT_name: "foo__nested__T18b"
.long 0x141 # DW_AT_byte_stride
.long 0xdc # DW_AT_type
.uleb128 0x11 # (DIE (0x15f) DW_TAG_subrange_type)
.long 0x166 # DW_AT_type
.byte 0x3 # DW_AT_upper_bound
.byte 0 # end of children of DIE 0x14e
There DW_AT_byte_stride is a reference to a local (internal)
variable:
.uleb128 0x9 # (DIE (0x141) DW_TAG_variable)
.long .LASF6 # DW_AT_name: "foo__nested__T18b___PAD___XVZ"
This patch enhances GDB to handle this dynamic byte stride attribute
by first adding a new dynamic_prop_node_kind (DYN_PROP_BYTE_STRIDE)
to store the array dynamic stride info (when dynamic). It then enhances
the dynamic type resolver to handle this dynamic property.
Before applying this patch, trying to print the value of some of
A1's elements after having stopped at the "STOP" comment does not
work. For instance:
(gdb) p a1(2)
Cannot access memory at address 0x80000268dec0
With this patch applied, GDB now prints the value of all 3 elements
correctly:
(gdb) print A1(1)
$1 = (i => 0, s => "")
(gdb) print A1(2)
$2 = (i => 1, s => "A")
(gdb) print A1(3)
$3 = (i => 2, s => "AB")
gdb/ChangeLog:
* gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
New enum value.
(create_array_type_with_stride): Add byte_stride_prop parameter.
* gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
New parameter. Update all callers in this file.
(array_type_has_dynamic_stride): New function.
(is_dynamic_type_internal, resolve_dynamic_array): Add handling
of arrays with dynamic byte strides.
* dwarf2read.c (read_array_type): Add support for dynamic
DW_AT_byte_stride attributes.
gdb/testsuite/ChangeLog:
* gdb.ada/dyn_stride: New testcase.
Tested on x86_64-linux.
2018-01-02 04:47:18 +01:00
|
|
|
|
2018-01-02 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
|
|
|
|
|
|
New enum value.
|
|
|
|
|
|
(create_array_type_with_stride): Add byte_stride_prop parameter.
|
|
|
|
|
|
* gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
|
|
|
|
|
|
New parameter. Update all callers in this file.
|
|
|
|
|
|
(array_type_has_dynamic_stride): New function.
|
|
|
|
|
|
(is_dynamic_type_internal, resolve_dynamic_array): Add handling
|
|
|
|
|
|
of arrays with dynamic byte strides.
|
|
|
|
|
|
* dwarf2read.c (read_array_type): Add support for dynamic
|
|
|
|
|
|
DW_AT_byte_stride attributes.
|
|
|
|
|
|
|
2018-01-02 04:41:36 +01:00
|
|
|
|
2018-01-02 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (read_unspecified_type): Treat
|
|
|
|
|
|
DW_TAG_enumeration_type DIEs from Ada units as stubs.
|
|
|
|
|
|
|
2018-01-01 05:43:02 +01:00
|
|
|
|
2018-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
Update copyright year range in all GDB files.
|
|
|
|
|
|
|
2018-01-01 05:18:16 +01:00
|
|
|
|
2018-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
|
|
|
|
|
|
and gdb/testsuite/gdb.base/step-line.c.
|
|
|
|
|
|
|
2018-01-01 05:30:28 +01:00
|
|
|
|
2018-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copyright.py (main): Dump the contents of
|
|
|
|
|
|
MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
|
|
|
|
|
|
even if BY_HAND is empty.
|
|
|
|
|
|
|
2018-01-01 05:12:21 +01:00
|
|
|
|
2018-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* top.c (print_gdb_version): Update Copyright year in version
|
|
|
|
|
|
message.
|
|
|
|
|
|
|
2018-01-01 05:07:25 +01:00
|
|
|
|
2018-01-01 Joel Brobecker <brobecker@adacore.com>
|
2017-12-30 20:14:41 +01:00
|
|
|
|
|
2018-01-01 05:07:25 +01:00
|
|
|
|
* config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
|
2017-12-30 20:14:41 +01:00
|
|
|
|
|
2018-01-01 05:07:25 +01:00
|
|
|
|
For older changes see ChangeLog-2017.
|
1999-04-16 03:35:26 +02:00
|
|
|
|
|
|
|
|
|
|
Local Variables:
|
|
|
|
|
|
mode: change-log
|
|
|
|
|
|
left-margin: 8
|
|
|
|
|
|
fill-column: 74
|
|
|
|
|
|
version-control: never
|
2007-08-10 00:44:38 +02:00
|
|
|
|
coding: utf-8
|
1999-04-16 03:35:26 +02:00
|
|
|
|
End:
|
