2020-04-07 17:48:46 +02:00
|
|
|
|
2020-04-07 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
|
|
|
|
|
|
constructor. Remove `addr` parameter from other constructor and
|
|
|
|
|
|
add `per_cu` parameter.
|
|
|
|
|
|
* dwarf2/read.c (create_partial_symtab): Update.
|
|
|
|
|
|
|
2020-04-07 17:33:05 +02:00
|
|
|
|
2020-04-07 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
PR symtab/25796
|
|
|
|
|
|
* dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
|
|
|
|
|
|
(partial_die_info::fixup): Inherit has_const_value.
|
|
|
|
|
|
|
2020-04-07 10:57:20 +02:00
|
|
|
|
2020-04-07 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
* psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
|
|
|
|
|
|
symbols without address.
|
|
|
|
|
|
|
2020-03-25 20:29:44 +01:00
|
|
|
|
2020-04-06 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* nbsd-nat.h (struct thread_info): Add forward declaration.
|
|
|
|
|
|
(nbsd_nat_target::thread_alive): Add.
|
|
|
|
|
|
(nbsd_nat_target::thread_name): Likewise.
|
|
|
|
|
|
(nbsd_nat_target::update_thread_list): Likewise.
|
|
|
|
|
|
(update_thread_list::post_attach): Likewise.
|
|
|
|
|
|
(post_attach::pid_to_str): Likewise.
|
|
|
|
|
|
* nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
|
|
|
|
|
|
(nbsd_thread_lister): Add.
|
|
|
|
|
|
(nbsd_nat_target::thread_alive): Likewise.
|
|
|
|
|
|
(nbsd_nat_target::thread_name): Likewise.
|
|
|
|
|
|
(nbsd_add_threads): Likewise.
|
|
|
|
|
|
(update_thread_list::post_attach): Likewise.
|
|
|
|
|
|
(nbsd_nat_target::update_thread_list): Likewise.
|
|
|
|
|
|
(post_attach::pid_to_str): Likewise.
|
|
|
|
|
|
|
2020-04-06 20:59:57 +02:00
|
|
|
|
2020-04-06 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-valprint.c (print_variant_part): Extract the variant field.
|
|
|
|
|
|
(print_field_values): Use the field as the outer value when
|
|
|
|
|
|
recursing.
|
|
|
|
|
|
|
2020-04-06 20:42:40 +02:00
|
|
|
|
2020-04-06 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* sh-nbsd-tdep.c: Include nbsd-tdep.h.
|
|
|
|
|
|
* ppc-nbsd-tdep.c: Include nbsd-tdep.h.
|
|
|
|
|
|
* mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
|
|
|
|
|
|
* arm-nbsd-tdep.c: Include nbsd-tdep.h.
|
|
|
|
|
|
* hppa-nbsd-tdep.c: Include nbsd-tdep.h.
|
|
|
|
|
|
|
2020-04-06 20:13:24 +02:00
|
|
|
|
2020-04-06 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
|
|
|
|
|
|
TYPE_CODE_ERROR.
|
|
|
|
|
|
|
2020-03-16 19:02:22 +01:00
|
|
|
|
2020-04-06 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* nbsd-tdep.c: Include "gdbarch.h".
|
|
|
|
|
|
Define enum with NetBSD signal numbers.
|
|
|
|
|
|
(nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
|
|
|
|
|
|
* alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
|
|
|
|
|
|
* amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
|
|
|
|
|
|
* arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
|
|
|
|
|
|
* hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
|
|
|
|
|
|
* i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
|
|
|
|
|
|
* mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
|
|
|
|
|
|
* ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
|
|
|
|
|
|
* sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
|
|
|
|
|
|
* sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
|
|
|
|
|
|
* sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
|
|
|
|
|
|
* vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
|
|
|
|
|
|
|
2020-04-03 21:38:31 +02:00
|
|
|
|
2020-04-03 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/25325
|
|
|
|
|
|
* dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
|
|
|
|
|
|
|
2020-04-03 17:11:55 +02:00
|
|
|
|
2020-04-03 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
|
|
|
|
|
|
Read constant block.
|
|
|
|
|
|
|
2020-04-02 21:49:06 +02:00
|
|
|
|
2020-04-02 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* gdb_bfd.h: Include gdbsupport/byte-vector.h.
|
|
|
|
|
|
(gdb_bfd_get_full_section_contents): New declaration.
|
|
|
|
|
|
* gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
|
|
|
|
|
|
* windows-tdep.c (is_linked_with_cygwin_dll): Use
|
|
|
|
|
|
gdb_bfd_get_full_section_contents.
|
|
|
|
|
|
|
2020-04-02 21:43:41 +02:00
|
|
|
|
2020-04-02 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* exec.c (build_section_table): Replace internal_error with
|
|
|
|
|
|
gdb_assert.
|
|
|
|
|
|
(section_table_xfer_memory_partial): Likewise.
|
|
|
|
|
|
* mdebugread.c (parse_partial_symbols): Likewise.
|
|
|
|
|
|
* psymtab.c (lookup_partial_symbol): Likewise.
|
|
|
|
|
|
* utils.c (wrap_here): Likewise.
|
|
|
|
|
|
|
2020-04-02 21:13:02 +02:00
|
|
|
|
2020-04-02 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* f-lang.c (build_fortran_types): Use arch_type to initialize
|
|
|
|
|
|
builtin_complex_s32 in the TYPE_CODE_ERROR case.
|
|
|
|
|
|
|
2020-04-02 20:49:35 +02:00
|
|
|
|
2020-04-02 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (partial_die_info::read): Do not create a vector
|
|
|
|
|
|
of attributes.
|
|
|
|
|
|
|
gdb: Don't remove duplicate entries from the line table
In this commit:
commit 8c95582da858ac981f689a6f599acacb8c5c490f
Date: Mon Dec 30 21:04:51 2019 +0000
gdb: Add support for tracking the DWARF line table is-stmt field
A change was made in buildsym_compunit::record_line to remove
duplicate line table entries in some cases. This was an invalid
change, as these duplicate line table entries are used in _some_ cases
as part of prologue detection (see skip_prologue_using_sal).
It might be possible to identify those line table entries that are
required by skip_prologue_using_sal and only keep those duplicates
around, however, I have not done this here. The original duplicate
removal was done because (a) it was easy to implement, and (b) it
seemed obviously harmless.
As (b) is now known to be false, and implementation would be more
complex, and so (a) is also false. As such, it seems better to keep
all duplicates until an actual reason presents itself for why we
should remove any.
The original regression was spotted on RISC-V, which makes use of
skip_prologue_using_sal as part of riscv_skip_prologue. Originally I
created the test gdb.dwarf2/dw2-inline-small-func.exp, however, this
test will not compile on RISC-V as this target doesn't support
.uleb128 or .sleb128 assembler directives containing complex
expressions. As a result I added the gdb.opt/inline-small-func.exp
test, which exposes the bug on RISC-V, but obviously depends on the
compiler to produce specific DWARF information in order to expose the
bug. Still this test does ensure we always get the desired result,
even if the DWARF changes.
Originally the gdb.dwarf2/dw2-inline-small-func.exp test passed on
x86-64 even with the duplicate line table entries incorrectly
removed. The reason for this is that when a compilation unit doesn't
have a 'producer' string then skip_prologue_using_sal is not used,
instead the prologue is always skipped using analysis of the assembler
code.
However, for Clang on x86-64 skip_prologue_using_sal is used, so I
modified the gdb.dwarf2/dw2-inline-small-func.exp test to include a
'producer' string that names the Clang compiler. With this done the
test would fail on x86-64.
One thing to note is that the gdb.opt/inline-small-func.exp test might
fail on some targets. For example, if we compare sparc to risc-v by
looking at sparc32_skip_prologue we see that this function doesn't use
skip_prologue_using_sal, but instead uses find_pc_partial_function
directly. I don't know the full history behind why the code is like
it is, but it feels like sparc32_skip_prologue is an attempt to
duplicate some of the functionality of skip_prologue_using_sal, but
without all of the special cases. If this is true then the new test
could easily fail on this target, this would suggest that sparc should
consider switching to use skip_prologue_using_sal like risc-v does.
gdb/ChangeLog:
* buildsym.c (buildsym_compunit::record_line): Remove
deduplication code.
gdb/testsuite/ChangeLog:
* gdb.dwarf2/dw2-inline-small-func-lbls.c: New file.
* gdb.dwarf2/dw2-inline-small-func.c: New file.
* gdb.dwarf2/dw2-inline-small-func.exp: New file.
* gdb.dwarf2/dw2-inline-small-func.h: New file.
* gdb.opt/inline-small-func.c: New file.
* gdb.opt/inline-small-func.exp: New file.
* gdb.opt/inline-small-func.h: New file.
2020-03-23 13:40:24 +01:00
|
|
|
|
2020-04-02 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
Bernd Edlinger <bernd.edlinger@hotmail.de>
|
|
|
|
|
|
Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* buildsym.c (buildsym_compunit::record_line): Remove
|
|
|
|
|
|
deduplication code.
|
|
|
|
|
|
|
[gdb/ada] Fix -readnow FAILs
When running test-case gdb.ada/access_to_packed_array we have:
...
(gdb) print pack.a^M
$1 = (0 => 1, 2, 3, 4, 5, 6, 7, 8, 9, 10)^M
...
but with target board readnow.exp, we have instead:
...
(gdb) print pack.a^M
'pack.a' has unknown type; cast it to its declared type^M
...
The symbol is normally found by the map_matching_symbols call in
ada-lang.c:add_nonlocal_symbols:
...
for (objfile *objfile : current_program_space->objfiles ())
{
data.objfile = objfile;
objfile->sf->qf->map_matching_symbols (objfile, lookup_name,
domain, global, callback,
(is_wild_match
? NULL : compare_names));
...
which maps onto psym_map_matching_symbols.
Function psym_map_matching_symbols iterates over all the partial symtabs,
and:
- if not expanded, searches in the partial symtab:
- if not found, continues to the next
- if found, expands into full symtab
- searches in the full symtab
However, with -readnow the call maps onto dw2_map_matching_symbols instead,
which is unimplemented, and consequently no symbol is found.
Fix this by detecting -readnow in dw2_map_matching_symbols, and handling that
appropriately given that partial symtabs are not present, and full symtabs
are: iterate over all the symtabs and search them.
Tested on x86_64-linux, with native and target board -readnow.
This removes 217 FAILs with board -readnow.
gdb/ChangeLog:
2020-04-02 Tom de Vries <tdevries@suse.de>
PR ada/24671
* dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
2020-04-02 08:58:38 +02:00
|
|
|
|
2020-04-02 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
PR ada/24671
|
|
|
|
|
|
* dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
|
|
|
|
|
|
|
[gdb] Use partial symbol table to find language for main
When language is set to auto, part of loading an executable is to update the
language accordingly. This is implemented by set_initial_language.
The implementation of set_initial_language works as follows:
- check if any objfile in the progspace has name_of_main/language_of_main
set, and if so, use the first one found. [ This is what you get f.i. when
using dwarf with DW_AT_main_subprogram. ]
- otherwise, check for known names in the minimal symbols, and either:
- use the associated language if any (f.i. for ada), or
- lookup the symbol in the symtab for the name and use the symbol language
(f.i. for c/c++).
The symbol lookup can be slow though.
In the case of the cc1 binary from PR23710 comment 1, getting to the initial
prompt takes ~8s:
...
$ time.sh gdb cc1 -batch -ex "show language"
The current source language is "auto; currently c++".
maxmem: 1272260
real: 8.05
user: 7.73
system: 0.38
...
but if we skip guessing the initial language by setting it instead, it takes
only ~4s:
...
$ time.sh gdb -iex "set language c++" cc1 -batch -ex "show language"
The current source language is "c++".
maxmem: 498272
real: 3.99
user: 3.90
system: 0.15
...
In both cases, we load the partial symbols for the executable, but in the
first case only we also do a lookup of main, which causes the corresponding
partial symtab to be expanded into a full symtab.
Ideally, we'd like to get the language of the symbol without triggering
expansion into a full symtab, and get the speedup without having to set the
language manually.
There's a related fixme in the header comment of set_initial_language:
...
/* Set the initial language.
FIXME: A better solution would be to record the language in the
psymtab when reading partial symbols, and then use it (if known) to
set the language. This would be a win for formats that encode the
language in an easily discoverable place, such as DWARF. For
stabs, we can jump through hoops looking for specially named
symbols or try to intuit the language from the specific type of
stabs we find, but we can't do that until later when we read in
full symbols. */
void
set_initial_language (void)
...
Since we're already tracking the language of partial symbols, use this to set
the language for the main symbol.
Note that this search in partial symbol tables is not guaranteed to yield the
same result as the lookup_symbol_in_language call currently done in
set_initial_language.
Build and reg-tested on x86_64-linux.
gdb/ChangeLog:
2020-04-02 Tom de Vries <tdevries@suse.de>
* dwarf2/read.c (dwarf2_gdb_index_functions,
dwarf2_debug_names_functions): Init lookup_global_symbol_language with
NULL.
* psymtab.c (psym_lookup_global_symbol_language): New function.
(psym_functions): Init psym_lookup_global_symbol_language with
psym_lookup_global_symbol_language.
* symfile-debug.c (debug_sym_quick_functions): Init
lookup_global_symbol_language with NULL.
* symfile.c (set_initial_language): Remove fixme comment.
* symfile.h (struct quick_symbol_functions): Add
lookup_global_symbol_language.
* symtab.c (find_quick_global_symbol_language): New function.
(find_main_name): Use find_quick_global_symbol_language.
gdb/testsuite/ChangeLog:
2020-04-02 Tom de Vries <tdevries@suse.de>
* gdb.base/main-psymtab.exp: New file.
2020-04-02 08:47:49 +02:00
|
|
|
|
2020-04-02 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (dwarf2_gdb_index_functions,
|
|
|
|
|
|
dwarf2_debug_names_functions): Init lookup_global_symbol_language with
|
|
|
|
|
|
NULL.
|
|
|
|
|
|
* psymtab.c (psym_lookup_global_symbol_language): New function.
|
|
|
|
|
|
(psym_functions): Init psym_lookup_global_symbol_language with
|
|
|
|
|
|
psym_lookup_global_symbol_language.
|
|
|
|
|
|
* symfile-debug.c (debug_sym_quick_functions): Init
|
|
|
|
|
|
lookup_global_symbol_language with NULL.
|
|
|
|
|
|
* symfile.c (set_initial_language): Remove fixme comment.
|
|
|
|
|
|
* symfile.h (struct quick_symbol_functions): Add
|
|
|
|
|
|
lookup_global_symbol_language.
|
|
|
|
|
|
* symtab.c (find_quick_global_symbol_language): New function.
|
|
|
|
|
|
(find_main_name): Use find_quick_global_symbol_language.
|
|
|
|
|
|
|
2020-04-01 23:41:31 +02:00
|
|
|
|
2020-04-01 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
|
|
|
|
|
|
|
2020-03-12 11:52:34 +01:00
|
|
|
|
2020-04-01 Bernd Edlinger <bernd.edlinger@hotmail.de>
|
|
|
|
|
|
|
|
|
|
|
|
* buildsym.c (record_line): Fix undefined behavior and preserve
|
|
|
|
|
|
lines at eof.
|
|
|
|
|
|
|
2020-03-12 11:52:34 +01:00
|
|
|
|
2020-04-01 Bernd Edlinger <bernd.edlinger@hotmail.de>
|
|
|
|
|
|
|
|
|
|
|
|
* buildsym.c (record_line): Fix the resizing condition.
|
|
|
|
|
|
|
2020-04-01 22:09:52 +02:00
|
|
|
|
2020-04-01 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* value.h (value_literal_complex): Add comment.
|
|
|
|
|
|
* valops.c (value_literal_complex): Refer to value.h.
|
|
|
|
|
|
|
2020-04-01 22:09:52 +02:00
|
|
|
|
2020-04-01 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
|
|
|
|
|
|
(scalar_type): New rule, from typebase.
|
|
|
|
|
|
(typebase): Use scalar_type. Recognize complex types.
|
|
|
|
|
|
(field_name): Handle FLOAT_KEYWORD.
|
|
|
|
|
|
(ident_tokens): Add _Complex and __complex__.
|
|
|
|
|
|
|
Implement complex arithmetic
This adds support for complex arithmetic to gdb. Now something like
"print 23 + 7i" will work.
Addition, subtraction, multiplication, division, and equality testing
are supported binary operations.
Unary +, negation, and complement are supported. Following GCC, the ~
operator computes the complex conjugate.
gdb/ChangeLog
2020-04-01 Tom Tromey <tom@tromey.com>
PR exp/25299:
* valarith.c (promotion_type, complex_binop): New functions.
(scalar_binop): Handle complex numbers. Use promotion_type.
(value_pos, value_neg, value_complement): Handle complex numbers.
gdb/testsuite/ChangeLog
2020-04-01 Tom Tromey <tom@tromey.com>
* gdb.base/complex-parts.exp: Add arithmetic tests.
2020-04-01 22:09:52 +02:00
|
|
|
|
2020-04-01 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR exp/25299:
|
|
|
|
|
|
* valarith.c (promotion_type, complex_binop): New functions.
|
|
|
|
|
|
(scalar_binop): Handle complex numbers. Use promotion_type.
|
|
|
|
|
|
(value_pos, value_neg, value_complement): Handle complex numbers.
|
|
|
|
|
|
|
2020-04-01 22:09:52 +02:00
|
|
|
|
2020-04-01 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
|
|
|
|
|
|
(exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
|
|
|
|
|
|
(parse_number): Handle complex numbers.
|
|
|
|
|
|
|
2020-04-01 22:09:52 +02:00
|
|
|
|
2020-04-01 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* c-valprint.c (c_decorations): Change complex suffix to "i".
|
|
|
|
|
|
|
2020-04-01 22:09:52 +02:00
|
|
|
|
2020-04-01 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (generic_value_print_complex): Use accessors.
|
|
|
|
|
|
* value.h (value_real_part, value_imaginary_part): Declare.
|
|
|
|
|
|
* valops.c (value_real_part, value_imaginary_part): New
|
|
|
|
|
|
functions.
|
|
|
|
|
|
* value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
|
|
|
|
|
|
|
2020-04-01 22:09:52 +02:00
|
|
|
|
2020-04-01 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* stabsread.c (rs6000_builtin_type, read_sun_floating_type)
|
|
|
|
|
|
(read_range_type): Update.
|
|
|
|
|
|
* mdebugread.c (basic_type): Update.
|
|
|
|
|
|
* go-lang.c (build_go_types): Use init_complex_type.
|
|
|
|
|
|
* gdbtypes.h (struct main_type) <complex_type>: New member.
|
|
|
|
|
|
(init_complex_type): Update.
|
|
|
|
|
|
(arch_complex_type): Don't declare.
|
|
|
|
|
|
* gdbtypes.c (init_complex_type): Remove "objfile" parameter.
|
|
|
|
|
|
Make name if none given. Use alloc_type_copy. Look for cached
|
|
|
|
|
|
complex type.
|
|
|
|
|
|
(arch_complex_type): Remove.
|
|
|
|
|
|
(gdbtypes_post_init): Use init_complex_type.
|
|
|
|
|
|
* f-lang.c (build_fortran_types): Use init_complex_type.
|
|
|
|
|
|
* dwarf2/read.c (read_base_type): Update.
|
|
|
|
|
|
* d-lang.c (build_d_types): Use init_complex_type.
|
|
|
|
|
|
* ctfread.c (read_base_type): Update.
|
|
|
|
|
|
|
gdb/infrun: stop all threads if there exists a non-stop target
Stop all threads not only if the current target is non-stop, but also
if there exists a non-stop target.
The multi-target patch (5b6d1e4fa4f "Multi-target support") made the
following change to gdb/inf-child.c:
void
inf_child_target::maybe_unpush_target ()
{
- if (!inf_child_explicitly_opened && !have_inferiors ())
+ if (!inf_child_explicitly_opened)
unpush_target (this);
}
If we are in all-stop mode with multiple inferiors, and an exit event
is received from an inferior, target_mourn_inferior() gets to this
point and without the have_inferiors() check, the target is unpushed.
This leads to having exec_ops as the top target.
Here is a test scenario. Two executables, ./a.out returns
immediately; ./sleepy just sleeps.
$ gdb ./sleepy
(gdb) start
...
(gdb) add-inferior -exec ./a.out
...
(gdb) inferior 2
[Switching to inferior 2..
(gdb) start
...
(gdb) set schedule-multiple on
(gdb) set debug infrun 1
(gdb) continue
At this point, the exit event is received from ./a.out. Normally,
this would lead to stop_all_threads() to also stop ./sleepy, but this
doesn't happen, because target_is_non_stop_p() returns false. And it
returns false because the top target is no longer the process target;
it is the exec_ops.
This patch modifies 'stop_waiting' to call 'stop_all_threads' if there
exists a non-stop target, not just when the current top target is
non-stop.
Tested on X86_64 Linux.
gdb/ChangeLog:
2020-04-01 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* infrun.c (stop_all_threads): Update assertion, plus when
stopping threads, take into account that we might be trying
to stop an all-stop target.
(stop_waiting): Call 'stop_all_threads' if there exists a
non-stop target.
gdb/testsuite/ChangeLog:
2020-04-01 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* gdb.multi/stop-all-on-exit.c: New test.
* gdb.multi/stop-all-on-exit.exp: New file.
2020-04-01 21:33:06 +02:00
|
|
|
|
2020-04-01 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infrun.c (stop_all_threads): Update assertion, plus when
|
|
|
|
|
|
stopping threads, take into account that we might be trying
|
|
|
|
|
|
to stop an all-stop target.
|
|
|
|
|
|
(stop_waiting): Call 'stop_all_threads' if there exists a
|
|
|
|
|
|
non-stop target.
|
|
|
|
|
|
|
2020-04-01 21:33:05 +02:00
|
|
|
|
2020-04-01 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
* target.h (exists_non_stop_target): New function declaration.
|
|
|
|
|
|
* target.c (exists_non_stop_target): New function.
|
|
|
|
|
|
|
2020-03-31 14:49:06 +02:00
|
|
|
|
2020-04-01 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/24789
|
|
|
|
|
|
* eval.c (is_integral_or_integral_reference): New function.
|
|
|
|
|
|
(evaluate_subexp_standard): Allow integer references in
|
|
|
|
|
|
pointer arithmetic.
|
|
|
|
|
|
|
2020-04-01 16:57:39 +02:00
|
|
|
|
2020-04-01 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::remote_parse_stop_reply): Remove the
|
|
|
|
|
|
check for no ptid in the stop reply when the target is non-stop.
|
|
|
|
|
|
|
2020-04-01 15:47:13 +02:00
|
|
|
|
2020-04-01 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* symtab.h (class lookup_name_info) <lookup_name_info>: Change
|
|
|
|
|
|
"name" parameter to rvalue reference. Initialize m_name_holder.
|
|
|
|
|
|
<lookup_name_info>: New overloads.
|
|
|
|
|
|
<name>: Return gdb::string_view.
|
|
|
|
|
|
<c_str>: New method.
|
|
|
|
|
|
<make_ignore_params>: Update.
|
|
|
|
|
|
<search_name_hash>: Update.
|
|
|
|
|
|
<language_lookup_name>: Return const char *.
|
|
|
|
|
|
<m_name>: Change type.
|
|
|
|
|
|
* symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
|
|
|
|
|
|
(demangle_for_lookup_info::demangle_for_lookup_info): Update.
|
|
|
|
|
|
(lookup_name_info::match_any): Update.
|
|
|
|
|
|
* psymtab.c (match_partial_symbol, lookup_partial_symbol):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* minsyms.c (linkage_name_str): Update.
|
|
|
|
|
|
* language.c (default_symbol_name_matcher): Update.
|
|
|
|
|
|
* dwarf2/read.c (mapped_index_base::find_name_components_bounds):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* ada-lang.c (ada_fold_name): Change parameter to string_view.
|
|
|
|
|
|
(ada_lookup_name_info::ada_lookup_name_info): Update.
|
|
|
|
|
|
(literal_symbol_name_matcher): Update.
|
|
|
|
|
|
|
2020-04-01 15:47:13 +02:00
|
|
|
|
2020-04-01 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* psymtab.c (psymtab_search_name): Remove function.
|
|
|
|
|
|
(psym_lookup_symbol): Create search name and lookup name here.
|
|
|
|
|
|
(lookup_partial_symbol): Remove "name" parameter; add
|
|
|
|
|
|
lookup_name.
|
|
|
|
|
|
(psym_expand_symtabs_for_function): Update.
|
|
|
|
|
|
|
2020-03-31 22:07:04 +02:00
|
|
|
|
2020-03-31 Joel Jones <joelkevinjones@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR tui/25597:
|
|
|
|
|
|
* python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
|
|
|
|
|
|
|
2020-03-31 15:29:53 +02:00
|
|
|
|
2020-03-31 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/abbrev.c (abbrev_table::read): Conditionally call
|
|
|
|
|
|
memcpy.
|
|
|
|
|
|
|
2020-03-12 10:48:39 +01:00
|
|
|
|
2020-03-30 Nelson Chu <nelson.chu@sifive.com>
|
|
|
|
|
|
|
|
|
|
|
|
* features/riscv/32bit-csr.xml: Regenerated.
|
|
|
|
|
|
* features/riscv/64bit-csr.xml: Regenerated.
|
|
|
|
|
|
|
2020-03-30 19:50:35 +02:00
|
|
|
|
2020-03-30 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-valprint.c (print_variant_part): Update.
|
|
|
|
|
|
* ada-lang.h (ada_which_variant_applies): Update.
|
|
|
|
|
|
* ada-lang.c (ada_which_variant_applies): Remove outer_type and
|
|
|
|
|
|
outer_valaddr parameters; replace with "outer" value parameter.
|
|
|
|
|
|
(to_fixed_variant_branch_type): Update.
|
|
|
|
|
|
|
[PowerPC] Fix debug register issues in ppc-linux-nat
This patch fixes some issues with debug register handling for the powerpc
linux native target.
Currently, the target methods for installing and removing hardware
breakpoints and watchpoints in ppc-linux-nat.c affect all threads known to
linux-nat, including threads of different processes.
This patch changes ppc-linux-nat.c so that only the process of
inferior_ptid is affected by these target methods, as GDB expects.
This is done in the same way as various other architectures. The
install/remove target methods only register a hardware breakpoint or
watchpoint, and then send a stop signal to the threads. The debug
registers are only changed with ptrace right before each thread is next
resumed, using low_prepare_to_resume.
There are two interfaces to modify debug registers for linux running on
powerpc, with different sets of ptrace requests:
- PPC_PTRACE_GETHWDBGINFO, PPC_PTRACE_SETHWDEBUG, and
PPC_PTRACE_DELHWDEBUG.
Or
- PTRACE_SET_DEBUGREG and PTRACE_GET_DEBUGREG
The first set (HWDEBUG) is the more flexible one and allows setting
watchpoints with a variable watched region length and, for certain
embedded processors, multiple types of debug registers (e.g. hardware
breakpoints and hardware-assisted conditions for watchpoints).
Currently, server processors only provide one watchpoint. The second one
(DEBUGREG) only allows setting one debug register, a watchpoint, so we
only use it if the first one is not available.
The HWDEBUG interface handles debug registers with slot numbers. Once a
hardware watchpoint or breakpoint is installed (with
PPC_PTRACE_SETHWDEBUG), ptrace returns a slot number. This slot number
can then be used to remove the watchpoint or breakpoint from the inferior
(with PPC_PTRACE_DELHWDEBUG). The first interface also provides a
bitmask of available debug register features, which can be obtained with
PPC_PTRACE_GETHWDBGINFO.
When GDB first tries to use debug registers, we try the first interface
with a ptrace call, and if it isn't available, we fall back to the second
one, if available. We use EIO as an indicator that an interface is not
available in the kernel. For simplicity, with any other error we
immediately assume no interface is available. Unfortunately this means
that if a process is killed by a signal right before we try to detect the
interface, we might get an ESRCH, which would prevent debug registers to
be used in the GDB session. However, it isn't clear that we can safely
raise an exception and try again in the future in all the contexts where
we try to detect the interface.
If the HWDEBUG interface works but provides no feature bits, the target
falls back to the DEBUGREG interface. When the kernel is configured
without CONFIG_HW_BREAKPOINTS (selected by CONFIG_PERF_EVENTS), there is
a bug that causes watchpoints installed with the HWDEBUG interface not to
trigger. When this is the case, the feature bits will be zero, which is
used as the indicator to fall back to the DEBUGREG interface. This isn't
ideal, but has always been the behavior of GDB before this patch, so I
decided not to change it.
A flag indicates for each thread if its debug registers need to be
updated the next time it is resumed. The flag is set whenever the upper
layers request or remove a hardware watchpoint or breakpoint, or when a
new thread is detected. Because some kernel configurations disable
watchpoints after they are hit, we also use the last stop reason of the
LWP to determine whether we should update the debug registers. It isn't
clear that this is also true of BookE hardware breakpoints, but we also
check their stop reason to be on the safe side, since it doesn't hurt.
A map from process numbers to hardware watchpoint or breakpoint objects
keeps track of what has been requested by the upper layers of GDB, since
for GDB installing a hardware watchpoint or breakpoint means doing so for
the whole process.
When using the HWDEBUG interface we also have to keep track of which
slots were last installed in each thread with a map from threads to the
slots, so that they can be removed when needed. When resuming a thread,
we remove all the slots using this map, then we install all the hardware
watchpoints and breakpoints from the per-process map of requests, and
then update the per-thread map accordingly.
This per-thread state is also used for copying the debug register state
after a fork or a clone is detected. The kernel might do this depending
on the configuration. Recent kernels running on server processors that
were configured with CONFIG_PERF_EVENTS (and therefore
CONFIG_HW_BREAKPOINTS) don't copy debug registers across forks and
clones. Recent kernels without CONFIG_HW_BREAKPOINTS copy this state. I
believe that on embedded processors (e.g. a ppc440) the debug register
state is copied, but I haven't been able to test this. To handle both
cases, the per-thread state is always copied when forks and clones are
detected, and when we resume the thread and delete the debug register
slots before updating them, we ignore ENOENT errors.
We don't need to handle this when using the DEBUGREG interface since it
only allows one hardware watchpoint and doesn't return slot numbers, we
just set or clear this watchpoint when needed.
Since we signal running threads to stop after a request is processed, so
that we can update their debug registers when they are next resumed,
there will be a time between signalling the threads and their stop during
which the debug registers haven't been updated, even if the target
methods completed.
The tests in gdb.threads/watchpoint-fork.exp no longer fail with this
patch.
gdb/ChangeLog:
2020-03-30 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
* ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
<list>. Remove inclusion of observable.h.
(PPC_DEBUG_CURRENT_VERSION): Move up define.
(struct arch_lwp_info): New struct.
(class ppc_linux_dreg_interface): New class.
(struct ppc_linux_process_info): New struct.
(struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
<low_new_clone, low_forget_process, low_prepare_to_resume>
<copy_thread_dreg_state, mark_thread_stale>
<mark_debug_registers_changed, register_hw_breakpoint>
<clear_hw_breakpoint, register_wp, clear_wp>
<can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
<num_memory_accesses, get_trigger_type>
<create_watchpoint_request, hwdebug_point_cmp>
<init_arch_lwp_info, get_arch_lwp_info>
<low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
methods.
<struct ptid_hash>: New inner struct.
<m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
members.
(saved_dabr_value, hwdebug_info, max_slots_number)
(struct hw_break_tuple, struct thread_points, ppc_threads)
(have_ptrace_hwdebug_interface)
(hwdebug_find_thread_points_by_tid)
(hwdebug_insert_point, hwdebug_remove_point): Remove.
(ppc_linux_nat_target::can_use_hw_breakpoint): Use
m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
(ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
use m_dreg_interface.
(hwdebug_point_cmp): Change to...
(ppc_linux_nat_target::hwdebug_point_cmp): ...this method. Use
reference arguments instead of pointers.
(ppc_linux_nat_target::ranged_break_num_registers): Use
m_dreg_interface.
(ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
m_dreg_interface. Call register_hw_breakpoint.
(ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
m_dreg_interface. Call clear_hw_breakpoint.
(get_trigger_type): Change to...
(ppc_linux_nat_target::get_trigger_type): ...this method. Add
comment.
(ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
use m_dreg_interface. Call register_hw_breakpoint.
(ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
use m_dreg_interface. Call clear_hw_breakpoint.
(can_use_watchpoint_cond_accel): Change to...
(ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
method. Update comment, use m_dreg_interface and
m_process_info.
(calculate_dvc): Change to...
(ppc_linux_nat_target::calculate_dvc): ...this method. Use
m_dreg_interface.
(num_memory_accesses): Change to...
(ppc_linux_nat_target::num_memory_accesses): ...this method.
(check_condition): Change to...
(ppc_linux_nat_target::check_condition): ...this method.
(ppc_linux_nat_target::can_accel_watchpoint_condition): Update
comment, use m_dreg_interface.
(create_watchpoint_request): Change to...
(ppc_linux_nat_target::create_watchpoint_request): ...this
method. Use m_dreg_interface.
(ppc_linux_nat_target::insert_watchpoint): Add comment, use
m_dreg_interface. Call register_hw_breakpoint or register_wp.
(ppc_linux_nat_target::remove_watchpoint): Add comment, use
m_dreg_interface. Call clear_hw_breakpoint or clear_wp.
(ppc_linux_nat_target::low_forget_process)
(ppc_linux_nat_target::low_new_fork)
(ppc_linux_nat_target::low_new_clone)
(ppc_linux_nat_target::low_delete_thread)
(ppc_linux_nat_target::low_prepare_to_resume): New methods.
(ppc_linux_nat_target::low_new_thread): Remove previous logic,
only call mark_thread_stale.
(ppc_linux_thread_exit): Remove.
(ppc_linux_nat_target::stopped_data_address): Change to...
(ppc_linux_nat_target::low_stopped_data_address): This. Add
comment, use m_dreg_interface and m_thread_hw_breakpoints.
(ppc_linux_nat_target::stopped_by_watchpoint): Change to...
(ppc_linux_nat_target::stopped_by_watchpoint): This. Add
comment. Call low_stopped_data_address.
(ppc_linux_nat_target::watchpoint_addr_within_range): Use
m_dreg_interface.
(ppc_linux_nat_target::masked_watch_num_registers): Use
m_dreg_interface.
(ppc_linux_nat_target::copy_thread_dreg_state)
(ppc_linux_nat_target::mark_thread_stale)
(ppc_linux_nat_target::mark_debug_registers_changed)
(ppc_linux_nat_target::register_hw_breakpoint)
(ppc_linux_nat_target::clear_hw_breakpoint)
(ppc_linux_nat_target::register_wp)
(ppc_linux_nat_target::clear_wp)
(ppc_linux_nat_target::init_arch_lwp_info)
(ppc_linux_nat_target::get_arch_lwp_info): New methods.
(_initialize_ppc_linux_nat): Remove observer callback.
2020-03-30 17:04:25 +02:00
|
|
|
|
2020-03-30 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
|
|
|
|
|
|
<list>. Remove inclusion of observable.h.
|
|
|
|
|
|
(PPC_DEBUG_CURRENT_VERSION): Move up define.
|
|
|
|
|
|
(struct arch_lwp_info): New struct.
|
|
|
|
|
|
(class ppc_linux_dreg_interface): New class.
|
|
|
|
|
|
(struct ppc_linux_process_info): New struct.
|
|
|
|
|
|
(struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
|
|
|
|
|
|
<low_new_clone, low_forget_process, low_prepare_to_resume>
|
|
|
|
|
|
<copy_thread_dreg_state, mark_thread_stale>
|
|
|
|
|
|
<mark_debug_registers_changed, register_hw_breakpoint>
|
|
|
|
|
|
<clear_hw_breakpoint, register_wp, clear_wp>
|
|
|
|
|
|
<can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
|
|
|
|
|
|
<num_memory_accesses, get_trigger_type>
|
|
|
|
|
|
<create_watchpoint_request, hwdebug_point_cmp>
|
|
|
|
|
|
<init_arch_lwp_info, get_arch_lwp_info>
|
|
|
|
|
|
<low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
|
|
|
|
|
|
methods.
|
|
|
|
|
|
<struct ptid_hash>: New inner struct.
|
|
|
|
|
|
<m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
|
|
|
|
|
|
members.
|
|
|
|
|
|
(saved_dabr_value, hwdebug_info, max_slots_number)
|
|
|
|
|
|
(struct hw_break_tuple, struct thread_points, ppc_threads)
|
|
|
|
|
|
(have_ptrace_hwdebug_interface)
|
|
|
|
|
|
(hwdebug_find_thread_points_by_tid)
|
|
|
|
|
|
(hwdebug_insert_point, hwdebug_remove_point): Remove.
|
|
|
|
|
|
(ppc_linux_nat_target::can_use_hw_breakpoint): Use
|
|
|
|
|
|
m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
|
|
|
|
|
|
(ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
|
|
|
|
|
|
use m_dreg_interface.
|
|
|
|
|
|
(hwdebug_point_cmp): Change to...
|
|
|
|
|
|
(ppc_linux_nat_target::hwdebug_point_cmp): ...this method. Use
|
|
|
|
|
|
reference arguments instead of pointers.
|
|
|
|
|
|
(ppc_linux_nat_target::ranged_break_num_registers): Use
|
|
|
|
|
|
m_dreg_interface.
|
|
|
|
|
|
(ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
|
|
|
|
|
|
m_dreg_interface. Call register_hw_breakpoint.
|
|
|
|
|
|
(ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
|
|
|
|
|
|
m_dreg_interface. Call clear_hw_breakpoint.
|
|
|
|
|
|
(get_trigger_type): Change to...
|
|
|
|
|
|
(ppc_linux_nat_target::get_trigger_type): ...this method. Add
|
|
|
|
|
|
comment.
|
|
|
|
|
|
(ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
|
|
|
|
|
|
use m_dreg_interface. Call register_hw_breakpoint.
|
|
|
|
|
|
(ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
|
|
|
|
|
|
use m_dreg_interface. Call clear_hw_breakpoint.
|
|
|
|
|
|
(can_use_watchpoint_cond_accel): Change to...
|
|
|
|
|
|
(ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
|
|
|
|
|
|
method. Update comment, use m_dreg_interface and
|
|
|
|
|
|
m_process_info.
|
|
|
|
|
|
(calculate_dvc): Change to...
|
|
|
|
|
|
(ppc_linux_nat_target::calculate_dvc): ...this method. Use
|
|
|
|
|
|
m_dreg_interface.
|
|
|
|
|
|
(num_memory_accesses): Change to...
|
|
|
|
|
|
(ppc_linux_nat_target::num_memory_accesses): ...this method.
|
|
|
|
|
|
(check_condition): Change to...
|
|
|
|
|
|
(ppc_linux_nat_target::check_condition): ...this method.
|
|
|
|
|
|
(ppc_linux_nat_target::can_accel_watchpoint_condition): Update
|
|
|
|
|
|
comment, use m_dreg_interface.
|
|
|
|
|
|
(create_watchpoint_request): Change to...
|
|
|
|
|
|
(ppc_linux_nat_target::create_watchpoint_request): ...this
|
|
|
|
|
|
method. Use m_dreg_interface.
|
|
|
|
|
|
(ppc_linux_nat_target::insert_watchpoint): Add comment, use
|
|
|
|
|
|
m_dreg_interface. Call register_hw_breakpoint or register_wp.
|
|
|
|
|
|
(ppc_linux_nat_target::remove_watchpoint): Add comment, use
|
|
|
|
|
|
m_dreg_interface. Call clear_hw_breakpoint or clear_wp.
|
|
|
|
|
|
(ppc_linux_nat_target::low_forget_process)
|
|
|
|
|
|
(ppc_linux_nat_target::low_new_fork)
|
|
|
|
|
|
(ppc_linux_nat_target::low_new_clone)
|
|
|
|
|
|
(ppc_linux_nat_target::low_delete_thread)
|
|
|
|
|
|
(ppc_linux_nat_target::low_prepare_to_resume): New methods.
|
|
|
|
|
|
(ppc_linux_nat_target::low_new_thread): Remove previous logic,
|
|
|
|
|
|
only call mark_thread_stale.
|
|
|
|
|
|
(ppc_linux_thread_exit): Remove.
|
|
|
|
|
|
(ppc_linux_nat_target::stopped_data_address): Change to...
|
|
|
|
|
|
(ppc_linux_nat_target::low_stopped_data_address): This. Add
|
|
|
|
|
|
comment, use m_dreg_interface and m_thread_hw_breakpoints.
|
|
|
|
|
|
(ppc_linux_nat_target::stopped_by_watchpoint): Change to...
|
|
|
|
|
|
(ppc_linux_nat_target::stopped_by_watchpoint): This. Add
|
|
|
|
|
|
comment. Call low_stopped_data_address.
|
|
|
|
|
|
(ppc_linux_nat_target::watchpoint_addr_within_range): Use
|
|
|
|
|
|
m_dreg_interface.
|
|
|
|
|
|
(ppc_linux_nat_target::masked_watch_num_registers): Use
|
|
|
|
|
|
m_dreg_interface.
|
|
|
|
|
|
(ppc_linux_nat_target::copy_thread_dreg_state)
|
|
|
|
|
|
(ppc_linux_nat_target::mark_thread_stale)
|
|
|
|
|
|
(ppc_linux_nat_target::mark_debug_registers_changed)
|
|
|
|
|
|
(ppc_linux_nat_target::register_hw_breakpoint)
|
|
|
|
|
|
(ppc_linux_nat_target::clear_hw_breakpoint)
|
|
|
|
|
|
(ppc_linux_nat_target::register_wp)
|
|
|
|
|
|
(ppc_linux_nat_target::clear_wp)
|
|
|
|
|
|
(ppc_linux_nat_target::init_arch_lwp_info)
|
|
|
|
|
|
(ppc_linux_nat_target::get_arch_lwp_info): New methods.
|
|
|
|
|
|
(_initialize_ppc_linux_nat): Remove observer callback.
|
|
|
|
|
|
|
2020-03-30 17:04:25 +02:00
|
|
|
|
2020-03-30 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
|
|
|
|
|
|
(ppc_linux_nat_target::auxv_parse)
|
|
|
|
|
|
(ppc_linux_nat_target::read_description)
|
|
|
|
|
|
(supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
|
|
|
|
|
|
Move up.
|
|
|
|
|
|
|
2020-03-30 17:04:25 +02:00
|
|
|
|
2020-03-30 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* linux-nat.h (low_new_clone): New method.
|
|
|
|
|
|
* linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
|
|
|
|
|
|
|
2020-03-29 21:24:48 +02:00
|
|
|
|
2020-03-29 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
|
|
|
|
|
|
(dbx_expand_psymtab): ... this.
|
|
|
|
|
|
(start_psymtab): Update.
|
|
|
|
|
|
* mdebugread.c (psymtab_to_symtab_1): Rename to...
|
|
|
|
|
|
(mdebug_expand_psymtab): ... this.
|
|
|
|
|
|
(parse_partial_symbols): Update.
|
|
|
|
|
|
(new_psymtab): Update.
|
|
|
|
|
|
* xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
|
|
|
|
|
|
(xcoff_expand_psymtab): ... this.
|
|
|
|
|
|
(xcoff_start_psymtab): Update.
|
|
|
|
|
|
|
2020-03-29 21:23:48 +02:00
|
|
|
|
2020-03-29 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* psympriv.h (partial_symtab) <read_dependencies>: Rename to...
|
|
|
|
|
|
<expand_dependencies>: ... this.
|
|
|
|
|
|
* psymtab.c (partial_symtab::read_dependencies): Rename to...
|
|
|
|
|
|
(partial_symtab::expand_dependencies): ... this.
|
|
|
|
|
|
* dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
|
|
|
|
|
|
Update.
|
|
|
|
|
|
(dwarf2_psymtab::expand_psymtab): Update.
|
|
|
|
|
|
* dbxread.c (dbx_psymtab_to_symtab_1): Update.
|
|
|
|
|
|
* mdebugread.c (psymtab_to_symtab_1): Update.
|
|
|
|
|
|
* xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
|
|
|
|
|
|
|
2020-03-29 21:23:31 +02:00
|
|
|
|
2020-03-29 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* psympriv.h (discard_psymtab): Remove.
|
|
|
|
|
|
* dbxread.c (dbx_end_psymtab): Update.
|
|
|
|
|
|
* xcoffread.c (xcoff_end_psymtab): Update.
|
|
|
|
|
|
|
2020-03-28 16:25:41 +01:00
|
|
|
|
2020-03-28 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
|
|
|
|
|
|
comment.
|
|
|
|
|
|
|
2020-03-26 18:11:40 +01:00
|
|
|
|
2020-03-28 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (read_attribute_reprocess): Fix formatting.
|
|
|
|
|
|
|
2020-03-27 12:34:02 +01:00
|
|
|
|
2020-03-27 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-nat.c (windows_add_all_dlls): Fix system dll paths.
|
|
|
|
|
|
|
2020-03-26 17:48:28 +01:00
|
|
|
|
2020-03-26 John Baldwin <jhb@FreeBSD.org>
|
|
|
|
|
|
|
|
|
|
|
|
* fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
|
|
|
|
|
|
|
Change two functions to be methods on struct attribute
This changes dwarf2_get_ref_die_offset and
dwarf2_get_attr_constant_value to be methods on struct attribute.
gdb/ChangeLog
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
(mark_common_block_symbol_computed, read_tag_string_type)
(attr_to_dynamic_prop, read_subrange_type): Update.
(dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
to be methods on struct attribute.
(skip_one_die, process_imported_unit_die, read_namespace_alias)
(read_call_site_scope, partial_die_info::read)
(partial_die_info::read, lookup_die_type, follow_die_ref):
Update.
* dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
from dwarf2_get_ref_die_offset.
(attribute::constant_value): New method, from
dwarf2_get_attr_constant_value.
* dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
Declare method.
<constant_value>: New method.
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
|
|
|
|
|
|
(mark_common_block_symbol_computed, read_tag_string_type)
|
|
|
|
|
|
(attr_to_dynamic_prop, read_subrange_type): Update.
|
|
|
|
|
|
(dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
|
|
|
|
|
|
to be methods on struct attribute.
|
|
|
|
|
|
(skip_one_die, process_imported_unit_die, read_namespace_alias)
|
|
|
|
|
|
(read_call_site_scope, partial_die_info::read)
|
|
|
|
|
|
(partial_die_info::read, lookup_die_type, follow_die_ref):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
|
|
|
|
|
|
from dwarf2_get_ref_die_offset.
|
|
|
|
|
|
(attribute::constant_value): New method, from
|
|
|
|
|
|
dwarf2_get_attr_constant_value.
|
|
|
|
|
|
* dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
|
|
|
|
|
|
Declare method.
|
|
|
|
|
|
<constant_value>: New method.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
|
|
|
|
|
|
(dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
|
|
|
|
|
|
(dwarf_type_encoding_name): Move to stringify.c.
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
|
|
|
|
|
|
* dwarf2/stringify.c: New file.
|
|
|
|
|
|
* dwarf2/stringify.h: New file.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
|
|
|
|
|
|
Rewrite.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
|
|
|
|
|
|
methods.
|
|
|
|
|
|
* dwarf2/read.c (lookup_addr_base): Move to die.h.
|
|
|
|
|
|
(lookup_ranges_base): Likewise.
|
|
|
|
|
|
(read_cutu_die_from_dwo, read_full_die_1): Update.
|
|
|
|
|
|
|
Remove sibling_die
The sibling_die helper function does not seem to add much value,
considering that many other fields of die_info are directly accessed.
So, this removes it.
gdb/ChangeLog
2020-03-26 Tom Tromey <tom@tromey.com>
* dwarf2/read.c (read_import_statement, read_file_scope)
(read_type_unit_scope, inherit_abstract_dies, read_func_scope)
(read_lexical_block_scope, read_call_site_scope)
(dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
(handle_struct_member_die, process_structure_scope)
(update_enumeration_type_from_children)
(process_enumeration_scope, read_array_type, read_common_block)
(read_namespace, read_module, read_subroutine_type): Update.
(sibling_die): Remove.
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (read_import_statement, read_file_scope)
|
|
|
|
|
|
(read_type_unit_scope, inherit_abstract_dies, read_func_scope)
|
|
|
|
|
|
(read_lexical_block_scope, read_call_site_scope)
|
|
|
|
|
|
(dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
|
|
|
|
|
|
(handle_struct_member_die, process_structure_scope)
|
|
|
|
|
|
(update_enumeration_type_from_children)
|
|
|
|
|
|
(process_enumeration_scope, read_array_type, read_common_block)
|
|
|
|
|
|
(read_namespace, read_module, read_subroutine_type): Update.
|
|
|
|
|
|
(sibling_die): Remove.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
|
|
|
|
|
|
(build_type_psymtabs_reader, read_structure_type)
|
|
|
|
|
|
(read_enumeration_type, read_full_die_1): Update.
|
|
|
|
|
|
(dwarf2_attr_no_follow): Move to die.h.
|
|
|
|
|
|
* dwarf2/die.h (struct die_info) <attr>: New method.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
|
|
|
|
|
|
<base_address>: Now an optional.
|
|
|
|
|
|
(dwarf2_find_base_address, dwarf2_rnglists_process)
|
|
|
|
|
|
(dwarf2_ranges_process, fill_in_loclist_baton)
|
|
|
|
|
|
(dwarf2_symbol_mark_computed): Update.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (struct die_info): Move to die.h.
|
|
|
|
|
|
* dwarf2/die.h: New file.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/line-header.h (dwarf_decode_line_header): Declare.
|
|
|
|
|
|
* dwarf2/read.c
|
|
|
|
|
|
(dwarf2_statement_list_fits_in_line_number_section_complaint):
|
|
|
|
|
|
Move to line-header.c.
|
|
|
|
|
|
(read_checked_initial_length_and_offset, read_formatted_entries):
|
|
|
|
|
|
Likewise.
|
|
|
|
|
|
(dwarf_decode_line_header): Split into two.
|
|
|
|
|
|
* dwarf2/line-header.c
|
|
|
|
|
|
(dwarf2_statement_list_fits_in_line_number_section_complaint):
|
|
|
|
|
|
Move from read.c.
|
|
|
|
|
|
(read_checked_initial_length_and_offset, read_formatted_entries):
|
|
|
|
|
|
Likewise.
|
|
|
|
|
|
(dwarf_decode_line_header): New function, split from read.c.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
|
|
|
|
|
|
Declare method.
|
|
|
|
|
|
* dwarf2/read.c (read_attribute_value): Update.
|
|
|
|
|
|
(dwarf2_per_objfile::read_line_string): Rename from
|
|
|
|
|
|
read_indirect_line_string.
|
|
|
|
|
|
(read_formatted_entries): Update.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
|
|
|
|
|
|
variable.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/macro.h (dwarf_decode_macros): Make section parameter
|
|
|
|
|
|
const.
|
|
|
|
|
|
* dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
|
|
|
|
|
|
(dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
|
|
|
|
|
|
parameter const.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
|
|
|
|
|
|
* dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
|
|
|
|
|
|
* dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
|
|
|
|
|
|
(dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/line-header.h (struct line_header) <is_valid_file_index,
|
|
|
|
|
|
file_names_size, file_full_name, file_file_name>: Use const.
|
|
|
|
|
|
<file_name_at, file_names>: Add const overload.
|
|
|
|
|
|
* dwarf2/line-header.c (line_header::file_file_name)
|
|
|
|
|
|
(line_header::file_full_name): Update.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
|
|
|
|
|
|
(macro_start_file, consume_improper_spaces)
|
|
|
|
|
|
(parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
|
|
|
|
|
|
(dwarf_parse_macro_header, dwarf_decode_macro_bytes)
|
|
|
|
|
|
(dwarf_decode_macros): Move to macro.c.
|
|
|
|
|
|
* dwarf2/macro.c: New file.
|
|
|
|
|
|
* dwarf2/macro.h: New file.
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
|
|
|
|
|
|
method.
|
|
|
|
|
|
* dwarf2/section.c: New method. From
|
|
|
|
|
|
read_indirect_string_at_offset_from.
|
|
|
|
|
|
* dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
|
|
|
|
|
|
(read_indirect_string_at_offset_from): Move to section.c.
|
|
|
|
|
|
(read_indirect_string_at_offset): Rewrite.
|
|
|
|
|
|
(read_indirect_line_string_at_offset): Remove.
|
|
|
|
|
|
(read_indirect_string, read_indirect_line_string)
|
|
|
|
|
|
(dwarf_decode_macro_bytes): Update.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/section.h (struct dwarf2_section_info)
|
|
|
|
|
|
<overload_complaint>: Declare.
|
|
|
|
|
|
(dwarf2_section_buffer_overflow_complaint): Don't declare.
|
|
|
|
|
|
* dwarf2/section.c (dwarf2_section_info::overflow_complaint):
|
|
|
|
|
|
Rename from dwarf2_section_buffer_overflow_complaint.
|
|
|
|
|
|
* dwarf2/read.c (skip_one_die, partial_die_info::read)
|
|
|
|
|
|
(skip_form_bytes, dwarf_decode_macro_bytes): Update.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
|
|
|
|
|
|
Declare.
|
|
|
|
|
|
* dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
|
|
|
|
|
|
Move from read.c.
|
|
|
|
|
|
* dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
|
|
|
|
|
|
to section.c.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (macro_start_file): Change "cu" parameter to
|
|
|
|
|
|
"builder".
|
|
|
|
|
|
(dwarf_decode_macro_bytes): Likewise. Add dwarf2_per_objfile
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(dwarf_decode_macros): Update.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (read_attribute_value): Update.
|
|
|
|
|
|
(read_indirect_string_from_dwz): Move to dwz.c; change into
|
|
|
|
|
|
method.
|
|
|
|
|
|
(dwarf_decode_macro_bytes): Update.
|
|
|
|
|
|
* dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
|
|
|
|
|
|
* dwarf2/dwz.c: New file.
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add dwz.c.
|
|
|
|
|
|
|
2020-03-26 16:28:08 +01:00
|
|
|
|
2020-03-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.h (struct dwz_file): Move to dwz.h.
|
|
|
|
|
|
* dwarf2/read.c: Add include.
|
|
|
|
|
|
* dwarf2/index-write.c: Add include.
|
|
|
|
|
|
* dwarf2/index-cache.c: Add include.
|
|
|
|
|
|
* dwarf2/dwz.h: New file.
|
|
|
|
|
|
|
2020-03-25 17:26:38 +01:00
|
|
|
|
2020-03-25 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* compile/compile-object-load.c (get_out_value_type): Mention
|
|
|
|
|
|
correct symbol name in error message.
|
|
|
|
|
|
|
2020-03-24 18:03:08 +01:00
|
|
|
|
2020-03-25 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-nat.c (windows_add_all_dlls): Fix system dll paths.
|
|
|
|
|
|
|
2020-03-25 12:38:05 +01:00
|
|
|
|
2020-03-25 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
* symtab.h (is_main_symtab_of_compunit_symtab): New function.
|
|
|
|
|
|
* symmisc.c (dump_symtab_1): Print user and includes fields.
|
|
|
|
|
|
(maintenance_info_symtabs): Same.
|
|
|
|
|
|
|
2020-03-13 16:50:28 +01:00
|
|
|
|
2020-03-25 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/25534
|
|
|
|
|
|
* riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
|
|
|
|
|
|
(riscv_regcache_cooked_write): New function.
|
|
|
|
|
|
(riscv_push_dummy_call): Use new function.
|
|
|
|
|
|
(riscv_return_value): Likewise.
|
|
|
|
|
|
|
2020-03-24 18:44:58 +01:00
|
|
|
|
2020-03-24 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
|
|
|
|
|
|
* fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
|
|
|
|
|
|
* inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
|
|
|
|
|
|
* inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
|
|
|
|
|
|
* infrun.c (follow_fork): Likewise.
|
|
|
|
|
|
(follow_fork_inferior): Likewise.
|
|
|
|
|
|
* linux-nat.c (linux_nat_target::follow_fork): Likewise.
|
|
|
|
|
|
* linux-nat.h (class linux_nat_target): Likewise.
|
|
|
|
|
|
* remote.c (class remote_target) <follow_fork>: Likewise.
|
|
|
|
|
|
(remote_target::follow_fork): Likewise.
|
|
|
|
|
|
* target-delegates.c: Re-generate.
|
|
|
|
|
|
* target.c (default_follow_fork): Likewise.
|
|
|
|
|
|
(target_follow_fork): Likewise.
|
|
|
|
|
|
* target.h (struct target_ops) <follow_fork>: Likewise.
|
|
|
|
|
|
(target_follow_fork): Likewise.
|
|
|
|
|
|
|
2020-03-24 10:00:51 +01:00
|
|
|
|
2020-03-24 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
* psymtab.c (maintenance_info_psymtabs): Print user field.
|
|
|
|
|
|
|
2020-03-20 20:04:56 +01:00
|
|
|
|
2020-03-20 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
|
|
|
|
|
|
const.
|
|
|
|
|
|
* dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
|
|
|
|
|
|
const.
|
|
|
|
|
|
|
gdb: remove HAVE_DECL_PTRACE
I stumbled on this snippet in nat/gdb_ptrace.h:
/* Some systems, in particular DEC OSF/1, Digital Unix, Compaq Tru64
or whatever it's called these days, don't provide a prototype for
ptrace. Provide one to silence compiler warnings. */
#ifndef HAVE_DECL_PTRACE
extern PTRACE_TYPE_RET ptrace();
#endif
I believe this is unnecessary today and should be removed. First, the
comment only mentions OSes we don't support (and to be honest, I had
never even heard of).
But most importantly, in C++, a declaration with empty parenthesis
declares a function that accepts no arguments, unlike in C. So if this
declaration was really used, GDB wouldn't build, since all ptrace call
sites pass some arguments. Since we haven't heard anything about this
causing some build failures since we have transitioned to C++, I
conclude that it's not used.
This patch removes it as well as the corresponding configure check.
gdb/ChangeLog:
* ptrace.m4: Don't check for ptrace declaration.
* config.in: Re-generate.
* configure: Re-generate.
* nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
not defined.
gdbserver/ChangeLog:
* config.in: Re-generate.
* configure: Re-generate.
gdbsupport/ChangeLog:
* config.in: Re-generate.
* configure: Re-generate.
2020-03-20 16:57:49 +01:00
|
|
|
|
2020-03-20 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ptrace.m4: Don't check for ptrace declaration.
|
|
|
|
|
|
* config.in: Re-generate.
|
|
|
|
|
|
* configure: Re-generate.
|
|
|
|
|
|
* nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
|
|
|
|
|
|
not defined.
|
|
|
|
|
|
|
2020-03-20 15:37:18 +01:00
|
|
|
|
2020-03-20 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
|
|
|
|
|
|
`PTRACE_TYPE_RET'.
|
|
|
|
|
|
* i386-bsd-nat.c (gdb_ptrace): Likewise.
|
|
|
|
|
|
* sparc-nat.c (gdb_ptrace): Likewise.
|
|
|
|
|
|
* x86-bsd-nat.c (gdb_ptrace): Likewise.
|
|
|
|
|
|
|
2020-03-20 15:10:59 +01:00
|
|
|
|
2020-03-20 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* c-exp.y (lex_one_token): Fix assert.
|
|
|
|
|
|
|
Avoid stringop-truncation errors
I configured with -fsanitize=address and built gdb. linux-tdep.c and
ada-tasks.c failed to build due to some stringop-truncation errors,
e.g.:
In function ‘char* strncpy(char*, const char*, size_t)’,
inlined from ‘int linux_fill_prpsinfo(elf_internal_linux_prpsinfo*)’ at ../../binutils-gdb/gdb/linux-tdep.c:1742:11,
inlined from ‘char* linux_make_corefile_notes(gdbarch*, bfd*, int*)’ at ../../binutils-gdb/gdb/linux-tdep.c:1878:27:
/usr/include/bits/string_fortified.h:106:34: error: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ specified bound 81 equals destination size [-Werror=stringop-truncation]
This patch fixes the problem by using "sizeof - 1" in the call to
strndup, as recommended in the GCC manual. This doesn't make a
difference here because the next line, in all cases, sets the final
element to '\0' anyway.
gdb/ChangeLog
2020-03-20 Tom Tromey <tromey@adacore.com>
* ada-tasks.c (read_atcb): Use smaller length in strncpy call.
* linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
strncpy call.
2020-03-20 14:30:13 +01:00
|
|
|
|
2020-03-20 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-tasks.c (read_atcb): Use smaller length in strncpy call.
|
|
|
|
|
|
* linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
|
|
|
|
|
|
strncpy call.
|
|
|
|
|
|
|
2020-03-20 14:15:08 +01:00
|
|
|
|
2020-03-20 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* symmisc.c (maintenance_print_one_line_table): Use ui_out.
|
|
|
|
|
|
|
2020-03-20 15:24:16 +01:00
|
|
|
|
2020-03-20 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-valprint.c (print_variant_part): Remove parameters; switch
|
|
|
|
|
|
to value-based API.
|
|
|
|
|
|
(print_field_values): Likewise.
|
|
|
|
|
|
(ada_val_print_struct_union): Likewise.
|
|
|
|
|
|
(ada_value_print_1): Update.
|
|
|
|
|
|
|
2020-03-19 14:52:57 +01:00
|
|
|
|
2020-03-20 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
|
|
|
|
|
|
nbsd_nat_target instead of inf_ptrace_target.
|
|
|
|
|
|
* ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
|
|
|
|
|
|
nbsd_nat_target.
|
|
|
|
|
|
|
2020-03-19 15:39:56 +01:00
|
|
|
|
2020-03-20 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
|
|
|
|
|
|
it to the ptrace call.
|
|
|
|
|
|
* (store_registers): Likewise.
|
|
|
|
|
|
|
|
|
|
|
|
2020-03-20 Kamil Rytarowski <n54@gmx.com>
|
2020-03-19 15:01:27 +01:00
|
|
|
|
|
|
|
|
|
|
* ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
|
|
|
|
|
|
it to the ptrace call.
|
|
|
|
|
|
* (store_registers): Likewise.
|
|
|
|
|
|
|
[AArch64] When unavailable, fetch VG from ptrace.
I was doing some SVE tests on system QEMU and noticed quite a few failures
related to inferior function calls. Any attempt to do an inferior function
call would result in the following:
Unable to set VG register.: Success.
This happens because, after an inferior function call, GDB attempts to restore
the regcache state and updates the SVE register in order. Since the Z registers
show up before the VG register, VG is still INVALID by the time the first Z
register is being updated. So when executing the following code in
aarch64_sve_set_vq:
if (reg_buf->get_register_status (AARCH64_SVE_VG_REGNUM) != REG_VALID)
return false;
By returning false, we signal something is wrong, then we get to this:
/* First store vector length to the thread. This is done first to ensure the
ptrace buffers read from the kernel are the correct size. */
if (!aarch64_sve_set_vq (tid, regcache))
perror_with_name (_("Unable to set VG register."));
Ideally we'd always have a valid VG before attempting to set the Z registers,
but in this case the ordering of registers doesn't make that possible.
I considered reordering the registers to put VG before the Z registers, like
the DWARF numbering, but that would break backwards compatibility with
existing implementations. Also, the Z register numbering is pinned to the V
registers, and adding VG before Z would create a gap for non-SVE targets,
since we wouldn't be able to undefine VG for non-SVE targets.
As a compromise, it seems we can safely fetch the VG register value from
ptrace. The value in the kernel is likely the updated value anyway.
This patch fixed all the failures i saw in the testsuite and caused no further
regressions.
gdb/ChangeLog:
2020-03-19 Luis Machado <luis.machado@linaro.org>
* nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
valid, fetch vg value from ptrace.
2020-03-16 18:09:25 +01:00
|
|
|
|
2020-03-19 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
|
|
|
|
|
|
valid, fetch vg value from ptrace.
|
|
|
|
|
|
|
2020-03-17 17:57:14 +01:00
|
|
|
|
2020-03-19 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
* inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
|
|
|
|
|
|
* inf-ptrace.c: Likewise.
|
|
|
|
|
|
* (gdb_ptrace): Add.
|
|
|
|
|
|
* (inf_ptrace_target::resume): Update.
|
|
|
|
|
|
* (inf_ptrace_target::xfer_partial): Likewise.
|
|
|
|
|
|
* (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
|
|
|
|
|
|
* (inf_ptrace_peek_poke): Update.
|
|
|
|
|
|
|
2020-03-19 14:01:36 +01:00
|
|
|
|
2020-03-19 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* x86-bsd-nat.c (gdb_ptrace): New.
|
|
|
|
|
|
* (x86bsd_dr_set): Add new argument `ptid'.
|
|
|
|
|
|
* (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
|
|
|
|
|
|
x86bsd_dr_set_addr): Update.
|
|
|
|
|
|
|
gdb: Handle W and X remote packets without giving a warning
In this commit:
commit 24ed6739b699f329c2c45aedee5f8c7d2f54e493
Date: Thu Jan 30 14:35:40 2020 +0000
gdb/remote: Restore support for 'S' stop reply packet
A regression was introduced such that the W and X packets would give a
warning in some cases. The warning was:
warning: multi-threaded target stopped without sending a thread-id, using first non-exited thread
This problem would arise when:
1. The multi-process extensions to the remote protocol were not
being used, and
2. The inferior has multiple threads.
In this case when the W (or X) packet arrives the ptid of the
stop_reply is set to null_ptid, then when we arrive in
process_stop_reply GDB spots that we have multiple non-exited theads,
but the stop event didn't specify a thread-id.
The problem with this is that the W (and X) packets are actually
process wide events, they apply to all threads. So not specifying a
thread-id is not a problem, in fact, the best these packets allow is
for the remote to specify a process-id, not a thread-id.
If we look at how the W (and X) packets deal with a specified
process-id, then what happens is GDB sets to stop_reply ptid to a
value which indicates all threads in the process, this is done by
creating a value `ptid_t (pid)`, which sets the pid field of the
ptid_t, but leaves the tid field as 0, indicating all threads.
So, this commit does the same thing for the case where there is not
process-id specified. In process_stop_reply we not distinguish
between stop events that apply to all threads, and those that apply to
only one. If the stop event applies to only one thread then we treat
it as before. If, however, the stop event applies to all threads,
then we find the first non-exited thread, and use the pid from this
thread to create a `ptid_t (pid)` value.
If the target has multiple inferiors, and receives a process wide
event without specifying a process-id GDB now gives this warning:
warning: multi-inferior target stopped without sending a process-id, using first non-exited inferior
gdb/ChangeLog:
* remote.c (remote_target::process_stop_reply): Handle events for
all threads differently.
gdb/testsuite/ChangeLog:
* gdb.server/exit-multiple-threads.c: New file.
* gdb.server/exit-multiple-threads.exp: New file.
2020-03-11 13:30:13 +01:00
|
|
|
|
2020-03-19 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::process_stop_reply): Handle events for
|
|
|
|
|
|
all threads differently.
|
|
|
|
|
|
|
gdb: Remove C++ symbol aliases from completion list
Consider debugging the following C++ program:
struct object
{ int a; };
typedef object *object_p;
static int
get_value (object_p obj)
{
return obj->a;
}
int
main ()
{
object obj;
obj.a = 0;
return get_value (&obj);
}
Now in a GDB session:
(gdb) complete break get_value
break get_value(object*)
break get_value(object_p)
Or:
(gdb) break get_va<TAB>
(gdb) break get_value(object<RETURN>
Function "get_value(object" not defined.
Make breakpoint pending on future shared library load? (y or [n]) n
The reason this happens is that we add completions based on the
msymbol names and on the symbol names. For C++ both of these names
include the parameter list, however, the msymbol names have some
differences from the symbol names, for example:
+ typedefs are resolved,
+ whitespace rules are different around pointers,
+ the 'const' keyword is placed differently.
What this means is that the msymbol names and symbol names appear to
be completely different to GDB's completion tracker, and therefore to
readline when it offers the completions.
This commit builds on the previous commit which reworked the
completion_tracker class. It is now trivial to add a
remove_completion member function, this is then used along with
cp_canonicalize_string_no_typedefs to remove the msymbol aliases from
the completion tracker as we add the symbol names.
Now, for the above program GDB only presents a single completion for
'get_value', which is 'get_value(object_p)'.
It is still possible to reference the symbol using the msymbol name,
so a user can manually type out 'break get_value (object *)' if they
wish and will get the expected behaviour.
I did consider adding an option to make this alias exclusion optional,
in the end I didn't bother as I didn't think it would be very useful,
but I can easily add such an option if people think it would be
useful.
gdb/ChangeLog:
* completer.c (completion_tracker::remove_completion): Define new
function.
* completer.h (completion_tracker::remove_completion): Declare new
function.
* symtab.c (completion_list_add_symbol): Remove aliasing msymbols
when adding a C++ function symbol.
gdb/testsuite/ChangeLog:
* gdb.linespec/cp-completion-aliases.cc: New file.
* gdb.linespec/cp-completion-aliases.exp: New file.
Change-Id: Ie5c7c9fc8ecf973072cfb4a9650867104bf7f50c
2019-12-27 19:31:09 +01:00
|
|
|
|
2020-03-19 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* completer.c (completion_tracker::remove_completion): Define new
|
|
|
|
|
|
function.
|
|
|
|
|
|
* completer.h (completion_tracker::remove_completion): Declare new
|
|
|
|
|
|
function.
|
|
|
|
|
|
* symtab.c (completion_list_add_symbol): Remove aliasing msymbols
|
|
|
|
|
|
when adding a C++ function symbol.
|
|
|
|
|
|
|
gdb: Restructure the completion_tracker class
In this commit I rewrite how the completion tracker tracks the
completions, and builds its lowest common denominator (LCD) string.
The LCD string is now built lazily when required, and we only track
the completions in one place, the hash table, rather than maintaining
a separate vector of completions.
The motivation for these changes is that the next commit will add the
ability to remove completions from the list, removing a completion
will invalidate the LCD string, so we need to keep hold of enough
information to recompute the LCD string as needed.
Additionally, keeping the completions in a vector makes removing a
completion expensive, so better to only keep the completions in the
hash table.
This commit doesn't add any new functionality itself, and there should
be no user visible changes after this commit.
For testing, I ran the testsuite as usual, but I also ran some manual
completion tests under valgrind, and didn't get any reports about
leaked memory.
gdb/ChangeLog:
* completer.c (completion_tracker::completion_hash_entry): Define
new class.
(advance_to_filename_complete_word_point): Call
recompute_lowest_common_denominator.
(completion_tracker::completion_tracker): Call discard_completions
to setup the hash table.
(completion_tracker::discard_completions): Allow for being called
from the constructor, pass new equal function, and element deleter
when constructing the hash table. Initialise new class member
variables.
(completion_tracker::maybe_add_completion): Remove use of
m_entries_vec, and store more information into m_entries_hash.
(completion_tracker::recompute_lcd_visitor): New function, most
content taken from...
(completion_tracker::recompute_lowest_common_denominator):
...here, this now just visits each item in the hash calling the
above visitor.
(completion_tracker::build_completion_result): Remove use of
m_entries_vec, call recompute_lowest_common_denominator.
* completer.h (completion_tracker::have_completions): Remove use
of m_entries_vec.
(completion_tracker::completion_hash_entry): Declare new class.
(completion_tracker::recompute_lowest_common_denominator): Change
function signature.
(completion_tracker::recompute_lcd_visitor): Declare new function.
(completion_tracker::m_entries_vec): Delete.
(completion_tracker::m_entries_hash): Initialize to NULL.
(completion_tracker::m_lowest_common_denominator_valid): New
member variable.
(completion_tracker::m_lowest_common_denominator_max_length): New
member variable.
Change-Id: I9d1db52c489ca0041b8959ca0d53b7d3af8aea72
2020-01-27 18:37:20 +01:00
|
|
|
|
2020-03-19 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* completer.c (completion_tracker::completion_hash_entry): Define
|
|
|
|
|
|
new class.
|
|
|
|
|
|
(advance_to_filename_complete_word_point): Call
|
|
|
|
|
|
recompute_lowest_common_denominator.
|
|
|
|
|
|
(completion_tracker::completion_tracker): Call discard_completions
|
|
|
|
|
|
to setup the hash table.
|
|
|
|
|
|
(completion_tracker::discard_completions): Allow for being called
|
|
|
|
|
|
from the constructor, pass new equal function, and element deleter
|
|
|
|
|
|
when constructing the hash table. Initialise new class member
|
|
|
|
|
|
variables.
|
|
|
|
|
|
(completion_tracker::maybe_add_completion): Remove use of
|
|
|
|
|
|
m_entries_vec, and store more information into m_entries_hash.
|
|
|
|
|
|
(completion_tracker::recompute_lcd_visitor): New function, most
|
|
|
|
|
|
content taken from...
|
|
|
|
|
|
(completion_tracker::recompute_lowest_common_denominator):
|
|
|
|
|
|
...here, this now just visits each item in the hash calling the
|
|
|
|
|
|
above visitor.
|
|
|
|
|
|
(completion_tracker::build_completion_result): Remove use of
|
|
|
|
|
|
m_entries_vec, call recompute_lowest_common_denominator.
|
|
|
|
|
|
* completer.h (completion_tracker::have_completions): Remove use
|
|
|
|
|
|
of m_entries_vec.
|
|
|
|
|
|
(completion_tracker::completion_hash_entry): Declare new class.
|
|
|
|
|
|
(completion_tracker::recompute_lowest_common_denominator): Change
|
|
|
|
|
|
function signature.
|
|
|
|
|
|
(completion_tracker::recompute_lcd_visitor): Declare new function.
|
|
|
|
|
|
(completion_tracker::m_entries_vec): Delete.
|
|
|
|
|
|
(completion_tracker::m_entries_hash): Initialize to NULL.
|
|
|
|
|
|
(completion_tracker::m_lowest_common_denominator_valid): New
|
|
|
|
|
|
member variable.
|
|
|
|
|
|
(completion_tracker::m_lowest_common_denominator_max_length): New
|
|
|
|
|
|
member variable.
|
|
|
|
|
|
|
2020-03-17 14:38:23 +01:00
|
|
|
|
2020-03-17 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* regformats/regdef.h: Put reg in gdb namespace.
|
|
|
|
|
|
|
2020-03-14 17:41:11 +01:00
|
|
|
|
2020-03-17 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* i386-bsd-nat.c (gdb_ptrace): New.
|
|
|
|
|
|
* (i386bsd_fetch_inferior_registers,
|
|
|
|
|
|
i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
|
|
|
|
|
|
* (i386bsd_fetch_inferior_registers,
|
|
|
|
|
|
i386bsd_store_inferior_registers) Use gdb_ptrace.
|
|
|
|
|
|
|
2020-03-14 17:41:11 +01:00
|
|
|
|
2020-03-17 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* amd64-bsd-nat.c (gdb_ptrace): New.
|
|
|
|
|
|
* (amd64bsd_fetch_inferior_registers,
|
|
|
|
|
|
amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
|
|
|
|
|
|
* (amd64bsd_fetch_inferior_registers,
|
|
|
|
|
|
amd64bsd_store_inferior_registers) Use gdb_ptrace.
|
|
|
|
|
|
|
2020-03-17 13:41:46 +01:00
|
|
|
|
2020-03-17 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* user-regs.c (user_reg::read): Rename to...
|
|
|
|
|
|
(user_reg::xread): ...this.
|
|
|
|
|
|
* (append_user_reg): Rename argument `read' to `xread'.
|
|
|
|
|
|
* (user_reg_add_builtin): Likewise.
|
|
|
|
|
|
* (user_reg_add): Likewise.
|
|
|
|
|
|
* (value_of_user_reg): Likewise.
|
|
|
|
|
|
|
2020-03-14 17:41:11 +01:00
|
|
|
|
2020-03-17 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* sparc-nat.c (gdb_ptrace): New.
|
|
|
|
|
|
* sparc-nat.c (sparc_fetch_inferior_registers)
|
|
|
|
|
|
(sparc_store_inferior_registers) Remove obsolete comment.
|
|
|
|
|
|
* sparc-nat.c (sparc_fetch_inferior_registers)
|
|
|
|
|
|
(sparc_store_inferior_registers) Switch from pid_t to ptid_t.
|
|
|
|
|
|
* sparc-nat.c (sparc_fetch_inferior_registers)
|
|
|
|
|
|
(sparc_store_inferior_registers) Use gdb_ptrace.
|
|
|
|
|
|
|
2020-03-17 16:31:49 +01:00
|
|
|
|
2020-03-17 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
|
|
|
|
|
|
it to the ptrace call.
|
|
|
|
|
|
* sh-nbsd-nat.c (store_registers): Likewise.
|
|
|
|
|
|
|
2020-03-17 15:07:39 +01:00
|
|
|
|
2020-03-17 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
|
|
|
|
|
|
nbsd_nat_target instead of inf_ptrace_target.
|
|
|
|
|
|
* sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
|
|
|
|
|
|
nbsd_nat_target.
|
|
|
|
|
|
|
2020-03-16 18:26:29 +01:00
|
|
|
|
2020-03-17 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* amd64-bsd-nat.c: Include amd64-bsd-nat.h".
|
|
|
|
|
|
|
2020-03-15 00:12:53 +01:00
|
|
|
|
2020-03-17 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
|
|
|
|
|
|
<sys/sysctl.h>.
|
|
|
|
|
|
* nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
|
|
|
|
|
|
|
[gdb] Skip imports of c++ CUs
The DWARF standard appendix E.1 describes techniques that can be used for
compression and deduplication: DIEs can be factored out into a new compilation
unit, and referenced using DW_FORM_ref_addr.
Such a new compilation unit can either use a DW_TAG_compile_unit or
DW_TAG_partial_unit. If a DW_TAG_compile_unit is used, its contents is
evaluated by consumers as though it were an ordinary compilation unit. If a
DW_TAG_partial_unit is used, it's only considered by consumers in the context
of a DW_TAG_imported_unit.
An example of when DW_TAG_partial_unit is required is when the factored out
DIEs are not top-level, f.i. because they were children of a namespace. In
such a case the corresponding DW_TAG_imported_unit will occur as child of the
namespace.
In the case of factoring out DIEs from c++ compilation units, we can factor
out into a new DW_TAG_compile_unit, and no DW_TAG_imported_unit is required.
This begs the question how to interpret a top-level DW_TAG_imported_unit of a
c++ DW_TAG_compile_unit compilation unit. The semantics of
DW_TAG_imported_unit describe that the imported unit logically appears at the
point of the DW_TAG_imported_unit entry. But it's not clear what the effect
should be in this case, since all the imported DIEs are already globally
visible anyway, due to the use of DW_TAG_compile_unit.
So, skip top-level imports of c++ DW_TAG_compile_unit compilation units in
process_imported_unit_die.
Using the cc1 binary from PR23710 comment 1 and setting a breakpoint on do_rpo_vn:
...
$ gdb \
-batch \
-iex "maint set dwarf max-cache-age 316" \
-iex "set language c++" \
-ex "b do_rpo_vn" \
cc1
...
we get a 8.1% reduction in execution time, due to reducing the number of
partial symtabs expanded into full symtabs from 212 to 175.
Build and reg-tested on x86_64-linux.
gdb/ChangeLog:
2020-03-17 Tom de Vries <tdevries@suse.de>
PR gdb/23710
* dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
fields.
* dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
fields.
(process_imported_unit_die): Skip import of c++ CUs.
2020-03-17 08:56:36 +01:00
|
|
|
|
2020-03-17 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/23710
|
|
|
|
|
|
* dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
|
|
|
|
|
|
fields.
|
|
|
|
|
|
* dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
|
|
|
|
|
|
fields.
|
|
|
|
|
|
(process_imported_unit_die): Skip import of c++ CUs.
|
|
|
|
|
|
|
2020-03-17 01:32:44 +01:00
|
|
|
|
2020-03-16 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* p-valprint.c (pascal_object_print_value): Initialize
|
|
|
|
|
|
base_value.
|
|
|
|
|
|
|
2017-10-25 20:51:54 +02:00
|
|
|
|
2020-03-16 Anton Kolesov <anton.kolesov@synopsys.com>
|
|
|
|
|
|
Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in: Add arch/arc.o
|
|
|
|
|
|
* configure.tgt: Likewise.
|
|
|
|
|
|
* arc-tdep.c (arc_tdesc_init): Use arc_read_description.
|
|
|
|
|
|
(_initialize_arc_tdep): Don't initialize old target descriptions.
|
|
|
|
|
|
(arc_read_description): New function to cache target descriptions.
|
|
|
|
|
|
* arc-tdep.h (arc_read_description): Add proto type.
|
|
|
|
|
|
* arch/arc.c: New file.
|
|
|
|
|
|
* arch/arc.h: Likewise.
|
|
|
|
|
|
* features/Makefile: Replace old target descriptions with new.
|
|
|
|
|
|
* features/arc-arcompact.c: Remove.
|
|
|
|
|
|
* features/arc-arcompact.xml: Likewise.
|
|
|
|
|
|
* features/arc-v2.c: Likewise
|
|
|
|
|
|
* features/arc-v2.xml: Likewise
|
|
|
|
|
|
* features/arc/aux-arcompact.xml: New file.
|
|
|
|
|
|
* features/arc/aux-v2.xml: Likewise.
|
|
|
|
|
|
* features/arc/core-arcompact.xml: Likewise.
|
|
|
|
|
|
* features/arc/core-v2.xml: Likewise.
|
|
|
|
|
|
* features/arc/aux-arcompact.c: Generate.
|
|
|
|
|
|
* features/arc/aux-v2.c: Likewise.
|
|
|
|
|
|
* features/arc/core-arcompact.c: Likewise.
|
|
|
|
|
|
* features/arc/core-v2.c: Likewise.
|
|
|
|
|
|
* target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
|
|
|
|
|
|
|
2020-03-16 22:00:52 +01:00
|
|
|
|
2020-03-16 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/25663:
|
|
|
|
|
|
* dwarf2/read.c (dwarf2_name): Strip leading namespaces after
|
|
|
|
|
|
putting value into bcache.
|
|
|
|
|
|
|
2020-03-16 21:56:36 +01:00
|
|
|
|
2020-03-16 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/21500
|
|
|
|
|
|
* amd64-windows-tdep.c (amd64_windows_init_abi): Rename
|
|
|
|
|
|
to...
|
|
|
|
|
|
(amd64_windows_init_abi_common): ... this. Don't set size of
|
|
|
|
|
|
long type.
|
|
|
|
|
|
(amd64_windows_init_abi): New function.
|
|
|
|
|
|
(amd64_cygwin_init_abi): New function.
|
|
|
|
|
|
(_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
|
|
|
|
|
|
the Cygwin OS ABI.
|
|
|
|
|
|
* i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
|
|
|
|
|
|
comment.
|
|
|
|
|
|
|
2020-03-16 21:56:36 +01:00
|
|
|
|
2020-03-16 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
|
|
|
|
|
|
* windows-tdep.c (CYGWIN_DLL_NAME): New.
|
|
|
|
|
|
(pe_import_directory_entry): New struct type.
|
|
|
|
|
|
(is_linked_with_cygwin_dll): New function.
|
|
|
|
|
|
* amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
|
|
|
|
|
|
GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
|
|
|
|
|
|
* i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
|
|
|
|
|
|
|
2020-03-16 21:56:35 +01:00
|
|
|
|
2020-03-16 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
|
|
|
|
|
|
i386_cygwin_core_osabi_sniffer.
|
|
|
|
|
|
|
2020-03-16 21:56:35 +01:00
|
|
|
|
2020-03-16 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* i386-cygwin-tdep.c: Rename to...
|
|
|
|
|
|
* i386-windows-tdep.c: ... this.
|
|
|
|
|
|
* Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
|
|
|
|
|
|
i386-windows-tdep.c.
|
|
|
|
|
|
* configure.tgt: Likewise.
|
|
|
|
|
|
|
gdb: add Windows OS ABI
GDB currently uses the "Cygwin" OS ABI (GDB_OSABI_CYGWIN) for everything
related to Windows. If you build a GDB for a MinGW or Cygwin target, it
will have "Cygwin" as the default OS ABI in both cases (see
configure.tgt). If you load either a MinGW or Cygwin binary, the
"Cygwin" OS ABI will be selected in both cases.
This is misleading, because Cygwin binaries are a subset of the binaries
running on Windows. When building something with MinGW, the resulting
binary has nothing to do with Cygwin. Cygwin binaries are only special
in that they are Windows binaries that link to the cygwin1.dll library
(if my understanding is correct).
Looking at i386-cygwin-tdep.c, we can see that GDB does nothing
different when dealing with Cygwin binaries versus non-Cygwin Windows
binaries. However, there is at least one known bug which would require
us to make a distinction between the two OS ABIs, and that is the size
of the built-in "long" type on x86-64. On native Windows, this is 4,
whereas on Cygwin it's 8.
So, this patch adds a new OS ABI, "Windows", and makes GDB use it for
i386 and x86-64 PE executables, instead of the "Cygwin" OS ABI. A
subsequent patch will improve the OS ABI detection so that GDB
differentiates the non-Cygwin Windows binaries from the Cygwin Windows
binaries, and applies the "Cygwin" OS ABI for the latter.
The default OS ABI remains "Cygwin" for the GDBs built with a Cygwin
target.
I've decided to split the i386_cygwin_osabi_sniffer function in two,
I think it's cleaner to have a separate sniffer for Windows binaries and
Cygwin cores, each checking one specific thing.
gdb/ChangeLog:
* osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
* osabi.c (gdb_osabi_names): Add "Windows".
* i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
(i386_cygwin_core_osabi_sniffer): New function, extracted from
i386_cygwin_osabi_sniffer.
(_initialize_i386_cygwin_tdep): Register OS ABI
GDB_OSABI_WINDOWS for i386.
* amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
(_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
for x86-64.
* configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
when the target matches '*-*-mingw*'.
2020-03-16 21:56:34 +01:00
|
|
|
|
2020-03-16 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
|
|
|
|
|
|
* osabi.c (gdb_osabi_names): Add "Windows".
|
|
|
|
|
|
* i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
|
|
|
|
|
|
GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
|
|
|
|
|
|
(i386_cygwin_core_osabi_sniffer): New function, extracted from
|
|
|
|
|
|
i386_cygwin_osabi_sniffer.
|
|
|
|
|
|
(_initialize_i386_cygwin_tdep): Register OS ABI
|
|
|
|
|
|
GDB_OSABI_WINDOWS for i386.
|
|
|
|
|
|
* amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
|
|
|
|
|
|
GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
|
|
|
|
|
|
(_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
|
|
|
|
|
|
for x86-64.
|
|
|
|
|
|
* configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
|
|
|
|
|
|
when the target matches '*-*-mingw*'.
|
|
|
|
|
|
|
2020-03-16 21:56:34 +01:00
|
|
|
|
2020-03-16 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* defs.h (enum gdb_osabi): Move to...
|
|
|
|
|
|
* osabi.h (enum gdb_osabi): ... here.
|
|
|
|
|
|
* gdbarch.sh: Include osabi.h in gdbarch.h.
|
|
|
|
|
|
* gdbarch.h: Re-generate.
|
|
|
|
|
|
|
gdb: recognize 64 bits Windows executables as Cygwin osabi
If I generate two Windows PE executables, one 32 bits and one 64 bits:
$ x86_64-w64-mingw32-gcc test.c -g3 -O0 -o test_64
$ i686-w64-mingw32-gcc test.c -g3 -O0 -o test_32
$ file test_64
test_64: PE32+ executable (console) x86-64, for MS Windows
$ file test_32
test_32: PE32 executable (console) Intel 80386, for MS Windows
When I load the 32 bits binary in my GNU/Linux-hosted GDB, the osabi is
correctly recognized as "Cygwin":
$ ./gdb --data-directory=data-directory -nx test_32
(gdb) show osabi
The current OS ABI is "auto" (currently "Cygwin").
When I load the 64 bits binary in GDB, the osabi is incorrectly
recognized as "GNU/Linux":
$ ./gdb --data-directory=data-directory -nx test_64
(gdb) show osabi
The current OS ABI is "auto" (currently "GNU/Linux").
The 32 bits one gets recognized by the i386_cygwin_osabi_sniffer
function, by its target name:
if (strcmp (target_name, "pei-i386") == 0)
return GDB_OSABI_CYGWIN;
The target name for the 64 bits binaries is "pei-x86-64". It doesn't
get recognized by any osabi sniffer, so GDB falls back on its default
osabi, "GNU/Linux".
This patch adds an osabi sniffer function for the Windows 64 bits
executables in amd64-windows-tdep.c. With it, the osabi is recognized
as "Cygwin", just like with the 32 bits binary.
Note that it may seems strange to have a binary generated by MinGW
(which has nothing to do with Cygwin) be recognized as a Cygwin binary.
This is indeed not accurate, but at the moment GDB uses the Cygwin for
everything Windows. Subsequent patches will add a separate "Windows" OS
ABI for Windows binaries that are not Cygwin binaries.
gdb/ChangeLog:
* amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
function.
(_initialize_amd64_windows_tdep): Register osabi sniffer.
2020-03-16 21:56:33 +01:00
|
|
|
|
2020-03-16 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
|
|
|
|
|
|
function.
|
|
|
|
|
|
(_initialize_amd64_windows_tdep): Register osabi sniffer.
|
|
|
|
|
|
|
Add C parser support for "restrict" and "_Atomic"
A user noticed that "watch -location" would fail with a "restrict"
pointer. The issue here is that if the DWARF mentions "restrict", gdb
will put this into the type name -- but then the C parser will not be
able to parse this type.
This patch adds support for "restrict" and "_Atomic" to the C parser.
C++ doesn't have "restrict", but does have some GCC extensions. The
type printer is changed to handle this difference as well, so that
watch expressions will work properly.
gdb/ChangeLog
2020-03-14 Tom Tromey <tom@tromey.com>
* c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
for C++.
(c_type_print_modifier): Likewise. Add "language" parameter.
(c_type_print_varspec_prefix, c_type_print_base_struct_union)
(c_type_print_base_1): Update.
* type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
constants.
* type-stack.c (type_stack::insert): Handle tp_atomic and
tp_restrict.
(type_stack::follow_type_instance_flags): Likewise.
(type_stack::follow_types): Likewise. Merge type-following code.
* c-exp.y (RESTRICT, ATOMIC): New tokens.
(space_identifier, cv_with_space_id)
(const_or_volatile_or_space_identifier_noopt)
(const_or_volatile_or_space_identifier): Remove.
(single_qualifier, qualifier_seq_noopt, qualifier_seq): New
rules.
(ptr_operator, typebase): Update.
(enum token_flag) <FLAG_C>: New constant.
(ident_tokens): Add "restrict", "__restrict__", "__restrict", and
"_Atomic".
(lex_one_token): Handle FLAG_C.
gdb/testsuite/ChangeLog
2020-03-14 Tom Tromey <tom@tromey.com>
* gdb.base/cvexpr.exp: Add test for _Atomic and restrict.
2020-03-14 19:11:42 +01:00
|
|
|
|
2020-03-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
|
|
|
|
|
|
for C++.
|
|
|
|
|
|
(c_type_print_modifier): Likewise. Add "language" parameter.
|
|
|
|
|
|
(c_type_print_varspec_prefix, c_type_print_base_struct_union)
|
|
|
|
|
|
(c_type_print_base_1): Update.
|
|
|
|
|
|
* type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
|
|
|
|
|
|
constants.
|
|
|
|
|
|
* type-stack.c (type_stack::insert): Handle tp_atomic and
|
|
|
|
|
|
tp_restrict.
|
|
|
|
|
|
(type_stack::follow_type_instance_flags): Likewise.
|
|
|
|
|
|
(type_stack::follow_types): Likewise. Merge type-following code.
|
|
|
|
|
|
* c-exp.y (RESTRICT, ATOMIC): New tokens.
|
|
|
|
|
|
(space_identifier, cv_with_space_id)
|
|
|
|
|
|
(const_or_volatile_or_space_identifier_noopt)
|
|
|
|
|
|
(const_or_volatile_or_space_identifier): Remove.
|
|
|
|
|
|
(single_qualifier, qualifier_seq_noopt, qualifier_seq): New
|
|
|
|
|
|
rules.
|
|
|
|
|
|
(ptr_operator, typebase): Update.
|
|
|
|
|
|
(enum token_flag) <FLAG_C>: New constant.
|
|
|
|
|
|
(ident_tokens): Add "restrict", "__restrict__", "__restrict", and
|
|
|
|
|
|
"_Atomic".
|
|
|
|
|
|
(lex_one_token): Handle FLAG_C.
|
|
|
|
|
|
|
2020-03-14 17:13:38 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
|
|
|
|
|
|
it to the ptrace call.
|
|
|
|
|
|
* m68k-bsd-nat.c (store_registers): Likewise.
|
|
|
|
|
|
|
2020-03-14 17:07:18 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
|
|
|
|
|
|
gdb_byte *.
|
|
|
|
|
|
* m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
|
|
|
|
|
|
* m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
|
|
|
|
|
|
* m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
|
|
|
|
|
|
|
2020-03-14 16:54:42 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
|
|
|
|
|
|
nbsd_nat_target instead of inf_ptrace_target.
|
|
|
|
|
|
* m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
|
|
|
|
|
|
nbsd_nat_target.
|
|
|
|
|
|
|
2020-03-14 16:49:41 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
|
|
|
|
|
|
register_t.
|
|
|
|
|
|
|
2020-03-14 16:36:16 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
|
|
|
|
|
|
it to the ptrace call.
|
|
|
|
|
|
* alpha-bsd-nat.c (store_registers): Likewise.
|
|
|
|
|
|
|
2020-03-14 16:23:11 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
|
|
|
|
|
|
includes.
|
|
|
|
|
|
* alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
|
|
|
|
|
|
* alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
|
|
|
|
|
|
fill_fpregset): Likewise.
|
|
|
|
|
|
|
2020-03-14 16:05:24 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
|
|
|
|
|
|
nbsd_nat_target instead of inf_ptrace_target.
|
|
|
|
|
|
* alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
|
|
|
|
|
|
nbsd_nat_target.
|
|
|
|
|
|
|
2020-03-14 15:53:47 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
|
|
|
|
|
|
register_t.
|
|
|
|
|
|
|
2020-03-14 15:44:28 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* arm-nbsd-nat.c (fetch_register): New variable lwp and pass
|
|
|
|
|
|
it to the ptrace call.
|
|
|
|
|
|
* arm-nbsd-nat.c (fetch_fp_register): Likewise.
|
|
|
|
|
|
* arm-nbsd-nat.c (fetch_fp_regs): Likewise.
|
|
|
|
|
|
* arm-nbsd-nat.c (store_register): Likewise.
|
|
|
|
|
|
* arm-nbsd-nat.c (store_regs): Likewise.
|
|
|
|
|
|
* arm-nbsd-nat.c (store_fp_register): Likewise.
|
|
|
|
|
|
* arm-nbsd-nat.c (store_fp_regs): Likewise.
|
|
|
|
|
|
|
2020-03-14 14:50:51 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
|
|
|
|
|
|
nbsd_nat_target instead of inf_ptrace_target.
|
|
|
|
|
|
* arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
|
|
|
|
|
|
nbsd_nat_target.
|
|
|
|
|
|
|
2020-03-14 14:17:16 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
|
|
|
|
|
|
it to the ptrace call.
|
|
|
|
|
|
* x86-bsd-nat.c (x86bsd_dr_set): Likewise.
|
|
|
|
|
|
|
2020-03-14 13:33:14 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
2020-03-14 13:38:30 +01:00
|
|
|
|
* vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
|
|
|
|
|
|
it to the ptrace call.
|
|
|
|
|
|
* vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
|
|
|
|
|
|
|
|
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
|
|
|
|
|
|
gdb_byte *.
|
2020-03-14 13:33:14 +01:00
|
|
|
|
* vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
|
|
|
|
|
|
|
2020-03-14 13:21:58 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
|
|
|
|
|
|
instead of inf_ptrace_target.
|
|
|
|
|
|
* vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
|
|
|
|
|
|
nbsd_nat_target.
|
|
|
|
|
|
|
2020-03-14 12:54:47 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
|
|
|
|
|
|
register_t.
|
|
|
|
|
|
|
2020-03-14 12:51:15 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
|
|
|
|
|
|
register_t.
|
|
|
|
|
|
|
2020-03-14 12:20:01 +01:00
|
|
|
|
2020-03-14 Kamil Rytarowski <n54@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
* vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
|
|
|
|
|
|
register_t.
|
|
|
|
|
|
|
Remove val_print
We can finally remove val_print and various helper functions that are
no longer needed.
gdb/ChangeLog
2020-03-13 Tom Tromey <tom@tromey.com>
* value.h (val_print): Don't declare.
* valprint.h (val_print_array_elements)
(val_print_scalar_formatted, generic_val_print): Don't declare.
* valprint.c (generic_val_print_array): Take a struct value.
(generic_val_print_ptr, generic_val_print_memberptr)
(generic_val_print_bool, generic_val_print_int)
(generic_val_print_char, generic_val_print_complex)
(generic_val_print): Remove.
(generic_value_print): Update.
(do_val_print): Remove unused parameters. Don't call
la_val_print.
(val_print): Remove.
(common_val_print): Update. Don't call value_check_printable.
(val_print_scalar_formatted, val_print_array_elements): Remove.
* rust-lang.c (rust_val_print): Remove.
(rust_language_defn): Update.
* p-valprint.c (pascal_val_print): Remove.
(pascal_value_print_inner): Update.
(pascal_object_print_val_fields, pascal_object_print_val):
Remove.
(pascal_object_print_static_field): Update.
* p-lang.h (pascal_val_print): Don't declare.
* p-lang.c (pascal_language_defn): Update.
* opencl-lang.c (opencl_language_defn): Update.
* objc-lang.c (objc_language_defn): Update.
* m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
* m2-lang.h (m2_val_print): Don't declare.
* m2-lang.c (m2_language_defn): Update.
* language.h (struct language_defn) <la_val_print>: Remove.
* language.c (unk_lang_value_print_inner): Rename. Change
argument types.
(unknown_language_defn, auto_language_defn): Update.
* go-valprint.c (go_val_print): Remove.
* go-lang.h (go_val_print): Don't declare.
* go-lang.c (go_language_defn): Update.
* f-valprint.c (f_val_print): Remove.
* f-lang.h (f_value_print): Don't declare.
* f-lang.c (f_language_defn): Update.
* d-valprint.c (d_val_print): Remove.
* d-lang.h (d_value_print): Don't declare.
* d-lang.c (d_language_defn): Update.
* cp-valprint.c (cp_print_value_fields)
(cp_print_value_fields_rtti, cp_print_value): Remove.
(cp_print_static_field): Update.
* c-valprint.c (c_val_print_array, c_val_print_ptr)
(c_val_print_struct, c_val_print_union, c_val_print_int)
(c_val_print_memberptr, c_val_print): Remove.
* c-lang.h (c_val_print_array, cp_print_value_fields)
(cp_print_value_fields_rtti): Don't declare.
* c-lang.c (c_language_defn, cplus_language_defn)
(asm_language_defn, minimal_language_defn): Update.
* ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
(ada_val_print_enum): Take a struct value.
(ada_val_print_flt, ada_val_print_array, ada_val_print_1)
(ada_val_print): Remove.
(ada_value_print_1): Update.
(printable_val_type): Remove.
* ada-lang.h (ada_val_print): Don't declare.
* ada-lang.c (ada_language_defn): Update.
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* value.h (val_print): Don't declare.
|
|
|
|
|
|
* valprint.h (val_print_array_elements)
|
|
|
|
|
|
(val_print_scalar_formatted, generic_val_print): Don't declare.
|
|
|
|
|
|
* valprint.c (generic_val_print_array): Take a struct value.
|
|
|
|
|
|
(generic_val_print_ptr, generic_val_print_memberptr)
|
|
|
|
|
|
(generic_val_print_bool, generic_val_print_int)
|
|
|
|
|
|
(generic_val_print_char, generic_val_print_complex)
|
|
|
|
|
|
(generic_val_print): Remove.
|
|
|
|
|
|
(generic_value_print): Update.
|
|
|
|
|
|
(do_val_print): Remove unused parameters. Don't call
|
|
|
|
|
|
la_val_print.
|
|
|
|
|
|
(val_print): Remove.
|
|
|
|
|
|
(common_val_print): Update. Don't call value_check_printable.
|
|
|
|
|
|
(val_print_scalar_formatted, val_print_array_elements): Remove.
|
|
|
|
|
|
* rust-lang.c (rust_val_print): Remove.
|
|
|
|
|
|
(rust_language_defn): Update.
|
|
|
|
|
|
* p-valprint.c (pascal_val_print): Remove.
|
|
|
|
|
|
(pascal_value_print_inner): Update.
|
|
|
|
|
|
(pascal_object_print_val_fields, pascal_object_print_val):
|
|
|
|
|
|
Remove.
|
|
|
|
|
|
(pascal_object_print_static_field): Update.
|
|
|
|
|
|
* p-lang.h (pascal_val_print): Don't declare.
|
|
|
|
|
|
* p-lang.c (pascal_language_defn): Update.
|
|
|
|
|
|
* opencl-lang.c (opencl_language_defn): Update.
|
|
|
|
|
|
* objc-lang.c (objc_language_defn): Update.
|
|
|
|
|
|
* m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
|
|
|
|
|
|
* m2-lang.h (m2_val_print): Don't declare.
|
|
|
|
|
|
* m2-lang.c (m2_language_defn): Update.
|
|
|
|
|
|
* language.h (struct language_defn) <la_val_print>: Remove.
|
|
|
|
|
|
* language.c (unk_lang_value_print_inner): Rename. Change
|
|
|
|
|
|
argument types.
|
|
|
|
|
|
(unknown_language_defn, auto_language_defn): Update.
|
|
|
|
|
|
* go-valprint.c (go_val_print): Remove.
|
|
|
|
|
|
* go-lang.h (go_val_print): Don't declare.
|
|
|
|
|
|
* go-lang.c (go_language_defn): Update.
|
|
|
|
|
|
* f-valprint.c (f_val_print): Remove.
|
|
|
|
|
|
* f-lang.h (f_value_print): Don't declare.
|
|
|
|
|
|
* f-lang.c (f_language_defn): Update.
|
|
|
|
|
|
* d-valprint.c (d_val_print): Remove.
|
|
|
|
|
|
* d-lang.h (d_value_print): Don't declare.
|
|
|
|
|
|
* d-lang.c (d_language_defn): Update.
|
|
|
|
|
|
* cp-valprint.c (cp_print_value_fields)
|
|
|
|
|
|
(cp_print_value_fields_rtti, cp_print_value): Remove.
|
|
|
|
|
|
(cp_print_static_field): Update.
|
|
|
|
|
|
* c-valprint.c (c_val_print_array, c_val_print_ptr)
|
|
|
|
|
|
(c_val_print_struct, c_val_print_union, c_val_print_int)
|
|
|
|
|
|
(c_val_print_memberptr, c_val_print): Remove.
|
|
|
|
|
|
* c-lang.h (c_val_print_array, cp_print_value_fields)
|
|
|
|
|
|
(cp_print_value_fields_rtti): Don't declare.
|
|
|
|
|
|
* c-lang.c (c_language_defn, cplus_language_defn)
|
|
|
|
|
|
(asm_language_defn, minimal_language_defn): Update.
|
|
|
|
|
|
* ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
|
|
|
|
|
|
(ada_val_print_enum): Take a struct value.
|
|
|
|
|
|
(ada_val_print_flt, ada_val_print_array, ada_val_print_1)
|
|
|
|
|
|
(ada_val_print): Remove.
|
|
|
|
|
|
(ada_value_print_1): Update.
|
|
|
|
|
|
(printable_val_type): Remove.
|
|
|
|
|
|
* ada-lang.h (ada_val_print): Don't declare.
|
|
|
|
|
|
* ada-lang.c (ada_language_defn): Update.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (do_val_print): Update.
|
|
|
|
|
|
* python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
|
|
|
|
|
|
a struct value.
|
|
|
|
|
|
(value_to_value_object_no_release): Declare.
|
|
|
|
|
|
* python/py-value.c (value_to_value_object_no_release): New
|
|
|
|
|
|
function.
|
|
|
|
|
|
* python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
|
|
|
|
|
|
struct value.
|
|
|
|
|
|
* guile/scm-value.c (vlscm_scm_from_value_no_release): New
|
|
|
|
|
|
function.
|
|
|
|
|
|
* guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
|
|
|
|
|
|
a struct value.
|
|
|
|
|
|
* guile/guile-internal.h (vlscm_scm_from_value_no_release):
|
|
|
|
|
|
Declare.
|
|
|
|
|
|
(gdbscm_apply_val_pretty_printer): Take a struct value.
|
|
|
|
|
|
* extension.h (apply_ext_lang_val_pretty_printer): Take a struct
|
|
|
|
|
|
value.
|
|
|
|
|
|
* extension.c (apply_ext_lang_val_pretty_printer): Take a struct
|
|
|
|
|
|
value.
|
|
|
|
|
|
* extension-priv.h (struct extension_language_ops)
|
|
|
|
|
|
<apply_val_pretty_printer>: Take a struct value.
|
|
|
|
|
|
* cp-valprint.c (cp_print_value): Create a struct value.
|
|
|
|
|
|
(cp_print_value): Update.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-valprint.c (print_field_values): Call common_val_print.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-valprint.c (val_print_packed_array_elements): Remove
|
|
|
|
|
|
bitoffset and val parameters. Call common_val_print.
|
|
|
|
|
|
(ada_val_print_string): Remove offset, address, and original_value
|
|
|
|
|
|
parameters.
|
|
|
|
|
|
(ada_val_print_array): Update.
|
|
|
|
|
|
(ada_value_print_array): New function.
|
|
|
|
|
|
(ada_value_print_1): Call it.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-valprint.c (ada_value_print): Use common_val_print.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-valprint.c (ada_val_print_ref): Use common_val_print.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-valprint.c (ada_value_print_num): New function.
|
|
|
|
|
|
(ada_value_print_1): Use it.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-valprint.c (ada_value_print_ptr): New function.
|
|
|
|
|
|
(ada_value_print_1): Use it.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
|
|
|
|
|
|
call common_val_print.
|
|
|
|
|
|
(ada_val_print_1): Update.
|
|
|
|
|
|
(ada_value_print_1): New function.
|
|
|
|
|
|
(ada_value_print_inner): Rewrite.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* cp-valprint.c (cp_print_value_fields): Update.
|
|
|
|
|
|
(cp_print_value): New function.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* m2-valprint.c (m2_value_print_inner): Use
|
|
|
|
|
|
cp_print_value_fields.
|
|
|
|
|
|
* cp-valprint.c (cp_print_value_fields): New function.
|
|
|
|
|
|
* c-valprint.c (c_value_print_struct): New function.
|
|
|
|
|
|
(c_value_print_inner): Use c_value_print_struct.
|
|
|
|
|
|
* c-lang.h (cp_print_value_fields): Declare.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* c-valprint.c (c_value_print_array): New function.
|
|
|
|
|
|
(c_value_print_inner): Use it.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* c-valprint.c (c_value_print_memberptr): New function.
|
|
|
|
|
|
(c_value_print_inner): Use it.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* c-valprint.c (c_value_print_int): New function.
|
|
|
|
|
|
(c_value_print_inner): Use it.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* c-valprint.c (c_value_print_ptr): New function.
|
|
|
|
|
|
(c_value_print_inner): Use it.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* c-valprint.c (c_value_print_inner): Rewrite.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (generic_value_print_complex): New function.
|
|
|
|
|
|
(generic_value_print): Use it.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (generic_val_print_float): Don't call
|
|
|
|
|
|
val_print_scalar_formatted.
|
|
|
|
|
|
(generic_val_print, generic_value_print): Update.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (generic_value_print_char): New function
|
|
|
|
|
|
(generic_value_print): Use it.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (generic_value_print_int): New function.
|
|
|
|
|
|
(generic_value_print): Use it.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (generic_value_print_bool): New function.
|
|
|
|
|
|
(generic_value_print): Use it.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (generic_val_print_func): Simplify.
|
|
|
|
|
|
(generic_val_print, generic_value_print): Update.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (generic_val_print_flags): Remove.
|
|
|
|
|
|
(generic_val_print, generic_value_print): Update.
|
|
|
|
|
|
(val_print_type_code_flags): Add original_value parameter.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (generic_val_print): Update.
|
|
|
|
|
|
(generic_value_print): Update.
|
|
|
|
|
|
* valprint.c (generic_val_print_enum): Don't call
|
|
|
|
|
|
val_print_scalar_formatted.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (generic_value_print): Call generic_value_print_ptr.
|
|
|
|
|
|
* valprint.c (generic_value_print_ptr): New function.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (generic_value_print): Rewrite.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* p-valprint.c (pascal_object_print_value_fields)
|
|
|
|
|
|
(pascal_object_print_value): New functions.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* p-valprint.c (pascal_value_print_inner): Rewrite.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* f-valprint.c (f_value_print_innner): Rewrite.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* m2-valprint.c (m2_print_unbounded_array): New overload.
|
|
|
|
|
|
(m2_print_unbounded_array): Update.
|
|
|
|
|
|
(m2_print_array_contents): Take a struct value.
|
|
|
|
|
|
(m2_value_print_inner): Rewrite.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* d-valprint.c (dynamic_array_type): Call d_value_print_inner.
|
|
|
|
|
|
(d_value_print_inner): New function.
|
|
|
|
|
|
* d-lang.h (d_value_print_inner): Declare.
|
|
|
|
|
|
* d-lang.c (d_language_defn): Use d_value_print_inner.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* go-valprint.c (go_value_print_inner): New function.
|
|
|
|
|
|
* go-lang.h (go_value_print_inner): Declare.
|
|
|
|
|
|
* go-lang.c (go_language_defn): Use go_value_print_inner.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* rust-lang.c (val_print_struct, rust_print_enum): Use the value
|
|
|
|
|
|
API.
|
|
|
|
|
|
(rust_val_print): Rewrite.
|
|
|
|
|
|
(rust_value_print_inner): New function, from rust_val_print.
|
|
|
|
|
|
(rust_language_defn): Use rust_value_print_inner.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-valprint.c (ada_value_print_inner): New function.
|
|
|
|
|
|
* ada-lang.h (ada_value_print_inner): Declare.
|
|
|
|
|
|
* ada-lang.c (ada_language_defn): Use ada_value_print_inner.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* f-valprint.c (f_value_print_innner): New function.
|
|
|
|
|
|
* f-lang.h (f_value_print_innner): Declare.
|
|
|
|
|
|
* f-lang.c (f_language_defn): Use f_value_print_innner.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* p-valprint.c (pascal_value_print_inner): New function.
|
|
|
|
|
|
* p-lang.h (pascal_value_print_inner): Declare.
|
|
|
|
|
|
* p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* m2-valprint.c (m2_value_print_inner): New function.
|
|
|
|
|
|
* m2-lang.h (m2_value_print_inner): Declare.
|
|
|
|
|
|
* m2-lang.c (m2_language_defn): Use m2_value_print_inner.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
|
|
|
|
|
|
* objc-lang.c (objc_language_defn): Use c_value_print_inner.
|
|
|
|
|
|
* c-valprint.c (c_value_print_inner): New function.
|
|
|
|
|
|
* c-lang.h (c_value_print_inner): Declare.
|
|
|
|
|
|
* c-lang.c (c_language_defn, cplus_language_defn)
|
|
|
|
|
|
(asm_language_defn, minimal_language_defn): Use
|
|
|
|
|
|
c_value_print_inner.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* p-valprint.c (pascal_object_print_value_fields): Now static.
|
|
|
|
|
|
* p-lang.h (pascal_object_print_value_fields): Don't declare.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* c-valprint.c (c_val_print_array): Simplify.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (value_print_array_elements): New function.
|
|
|
|
|
|
* valprint.h (value_print_array_elements): Declare.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* printcmd.c (print_formatted): Use value_print_scalar_formatted.
|
|
|
|
|
|
* mips-tdep.c (mips_print_register): Use
|
|
|
|
|
|
value_print_scalar_formatted.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.h (value_print_scalar_formatted): Declare.
|
|
|
|
|
|
* valprint.c (value_print_scalar_formatted): New function.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.h (generic_value_print): Declare.
|
|
|
|
|
|
* valprint.c (generic_value_print): New function.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (do_val_print): Call la_value_print_inner, if
|
|
|
|
|
|
available.
|
|
|
|
|
|
* rust-lang.c (rust_language_defn): Update.
|
|
|
|
|
|
* p-lang.c (pascal_language_defn): Update.
|
|
|
|
|
|
* opencl-lang.c (opencl_language_defn): Update.
|
|
|
|
|
|
* objc-lang.c (objc_language_defn): Update.
|
|
|
|
|
|
* m2-lang.c (m2_language_defn): Update.
|
|
|
|
|
|
* language.h (struct language_defn) <la_value_print_inner>: New
|
|
|
|
|
|
member.
|
|
|
|
|
|
* language.c (unknown_language_defn, auto_language_defn): Update.
|
|
|
|
|
|
* go-lang.c (go_language_defn): Update.
|
|
|
|
|
|
* f-lang.c (f_language_defn): Update.
|
|
|
|
|
|
* d-lang.c (d_language_defn): Update.
|
|
|
|
|
|
* c-lang.c (c_language_defn, cplus_language_defn)
|
|
|
|
|
|
(asm_language_defn, minimal_language_defn): Update.
|
|
|
|
|
|
* ada-lang.c (ada_language_defn): Update.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* c-valprint.c (c_value_print): Use common_val_print.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* cp-valprint.c (cp_print_static_field): Use common_val_print.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* f-valprint.c (f77_print_array_1, f_val_print): Use
|
|
|
|
|
|
common_val_print.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* riscv-tdep.c (riscv_print_one_register_info): Use
|
|
|
|
|
|
common_val_print.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* mi/mi-main.c (output_register): Use common_val_print.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infcmd.c (default_print_one_register_info): Use
|
|
|
|
|
|
common_val_print.
|
|
|
|
|
|
|
Introduce common_val_print_checked
A (much) later patch will remove the call to value_check_printable
from common_val_print. This will needed to preserve some details of
how optimized-out structures are printed.
However, doing this will also break dw2-op-out-param.exp. Making the
change causes "bt" to print:
However, the test wants to see:
... operand2=<optimized out>
That is, a wholly-optimized out structure should not print its fields.
So, this patch introduces a new common_val_print_checked, which calls
value_check_printable first, and then arranges to use it in the one
spot that affects the test suite.
I was not completely sure if it would be preferable to change the
test. However, I reasoned that, assuming this output was intentional
in the first place, in a backtrace space is at a premium and so this
is a reasonable approach. In other spots calling common_val_print,
this behavior is probably unintended, or at least a "don't care".
gdb/ChangeLog
2020-03-13 Tom Tromey <tom@tromey.com>
* valprint.h (common_val_print_checked): Declare.
* valprint.c (common_val_print_checked): New function.
* stack.c (print_frame_arg): Use common_val_print_checked.
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.h (common_val_print_checked): Declare.
|
|
|
|
|
|
* valprint.c (common_val_print_checked): New function.
|
|
|
|
|
|
* stack.c (print_frame_arg): Use common_val_print_checked.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (do_val_print): New function, from val_print.
|
|
|
|
|
|
(val_print): Use do_val_print.
|
|
|
|
|
|
(common_val_print): Use do_val_print.
|
|
|
|
|
|
|
2020-03-14 00:39:52 +01:00
|
|
|
|
2020-03-13 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (value_print): Use scoped_value_mark.
|
|
|
|
|
|
|
[gdb/symtab] Fix partial unit psymtabs
Consider test-case gdb.dwarf2/imported-unit.exp.
It contains a CU with type int:
...
<0><129>: Abbrev Number: 2 (DW_TAG_compile_unit)
<12a> DW_AT_language : 4 (C++)
<12b> DW_AT_name : imported_unit.c
<1><13b>: Abbrev Number: 3 (DW_TAG_base_type)
<13c> DW_AT_byte_size : 4
<13d> DW_AT_encoding : 5 (signed)
<13e> DW_AT_name : int
...
which is imported in another CU:
...
<0><d2>: Abbrev Number: 2 (DW_TAG_compile_unit)
<d3> DW_AT_language : 4 (C++)
<d4> DW_AT_name : <artificial>
<1><e1>: Abbrev Number: 3 (DW_TAG_imported_unit)
<e2> DW_AT_import : <0x129> [Abbrev Number: 2]
...
However, if we print the partial symbols:
...
$ gdb -batch imported-unit -ex "maint print psymbols"
...
we see type int both in the importing CU:
...
Partial symtab for source file <artificial>@0xc7 (object 0x29f9b80)
...
Depends on 1 other partial symtabs.
0 0x2a24240 imported_unit.c
Global partial symbols:
`main', function, 0x4004b2
Static partial symbols:
`int', type, 0x0
...
and in the imported CU:
...
Partial symtab for source file imported_unit.c (object 0x2a24240)
...
Depends on 0 other partial symtabs.
Shared partial symtab with user 0x29f9b80
Static partial symbols:
`int', type, 0x0
...
This is an artefact resulting from the fact that all CUs in an objfile
share the same storage array for static partial symbols (and another array for
global partial symbols), using a range to describe their symbols.
Then when scanning the partial symbols of a CU and encountering an import, either:
- the referred CU has not been parsed yet, and will be parsed, and the range of
static partial symbols of the referred CU will be a subrange of the range of
static partial symbols of this CU, or
- the referred CU has already been parsed, and the range of static partial
symbols of the referred CU will not be a subrange of the range of static
partial symbols of this CU.
This is inconsistent handling, and confuses the notion of a symbol belonging to
a single symtab.
Furthermore, it might slow down searches, given that the symbol needs to be
skipped twice.
Finally, the same issue holds for global partial symbols, where the range of a
CU is sorted after parsing is finished. Obviously sorting the range of a CU
may invalidate subranges, effectively moving symbols in and out of imported
CUs.
Fix this for both static and global partial symbols, by gathering partial
symbols in a per-CU vector, and adding those symbols to the per-objfile
storage only once complete.
Tested on x86_64-linux, with native and board cc-with-dwz and cc-with-dwz-m.
gdb/ChangeLog:
2020-03-13 Tom de Vries <tdevries@suse.de>
PR symtab/25646
* psymtab.c (partial_symtab::partial_symtab): Don't set
globals_offset and statics_offset. Push element onto
current_global_psymbols and current_static_psymbols stacks.
(concat): New function.
(end_psymtab_common): Set globals_offset and statics_offset. Pop
element from current_global_psymbols and current_static_psymbols
stacks. Concat popped elements to global_psymbols and
static_symbols.
(add_psymbol_to_list): Use current_global_psymbols and
current_static_psymbols stacks.
* psymtab.h (class psymtab_storage): Add current_global_psymbols and
current_static_psymbols fields.
gdb/testsuite/ChangeLog:
2020-03-13 Tom de Vries <tdevries@suse.de>
PR symtab/25646
* gdb.dwarf2/imported-unit.exp: Add test.
2020-03-13 08:50:51 +01:00
|
|
|
|
2020-03-13 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
PR symtab/25646
|
|
|
|
|
|
* psymtab.c (partial_symtab::partial_symtab): Don't set
|
|
|
|
|
|
globals_offset and statics_offset. Push element onto
|
|
|
|
|
|
current_global_psymbols and current_static_psymbols stacks.
|
|
|
|
|
|
(concat): New function.
|
|
|
|
|
|
(end_psymtab_common): Set globals_offset and statics_offset. Pop
|
|
|
|
|
|
element from current_global_psymbols and current_static_psymbols
|
|
|
|
|
|
stacks. Concat popped elements to global_psymbols and
|
|
|
|
|
|
static_symbols.
|
|
|
|
|
|
(add_psymbol_to_list): Use current_global_psymbols and
|
|
|
|
|
|
current_static_psymbols stacks.
|
|
|
|
|
|
* psymtab.h (class psymtab_storage): Add current_global_psymbols and
|
|
|
|
|
|
current_static_psymbols fields.
|
|
|
|
|
|
|
2020-03-06 22:21:28 +01:00
|
|
|
|
2020-03-12 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* corelow.c (sniff_core_bfd): Remove.
|
|
|
|
|
|
(class core_target) <m_core_vec>: Remove.
|
|
|
|
|
|
(core_target::core_target): Update.
|
|
|
|
|
|
(core_file_fns): Remove.
|
|
|
|
|
|
(deprecated_add_core_fns): Remove.
|
|
|
|
|
|
(default_core_sniffer): Remove.
|
|
|
|
|
|
(sniff_core_bfd): Remove.
|
|
|
|
|
|
(default_check_format): Remove.
|
|
|
|
|
|
(gdb_check_format): Remove.
|
|
|
|
|
|
(core_target_open): Update.
|
|
|
|
|
|
(core_target::get_core_register_section): Update.
|
|
|
|
|
|
(get_core_registers_cb): Update.
|
|
|
|
|
|
(core_target::fetch_registers): Update.
|
|
|
|
|
|
* gdbcore.h (struct core_fns): Remove.
|
|
|
|
|
|
(deprecated_add_core_fns): Remove.
|
|
|
|
|
|
(default_core_sniffer): Remove.
|
|
|
|
|
|
(default_check_format): Remove.
|
|
|
|
|
|
|
2020-03-12 20:32:15 +01:00
|
|
|
|
2020-03-12 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
|
|
|
|
|
|
CORE_ADDR.
|
|
|
|
|
|
(struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
|
|
|
|
|
|
|
2020-03-12 20:32:15 +01:00
|
|
|
|
2020-03-12 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::download_tracepoint)
|
|
|
|
|
|
(remote_target::enable_tracepoint)
|
|
|
|
|
|
(remote_target::disable_tracepoint): Use phex, not sprintf_vma.
|
|
|
|
|
|
* breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
|
|
|
|
|
|
sprintf_vma.
|
|
|
|
|
|
|
2020-03-12 20:32:15 +01:00
|
|
|
|
2020-03-12 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* symfile-mem.c: Update CORE_ADDR size assert.
|
|
|
|
|
|
|
2020-03-12 19:19:38 +01:00
|
|
|
|
2020-03-12 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* selftest.m4: Move to gdbsupport/.
|
|
|
|
|
|
* acinclude.m4: Update path to selftest.m4.
|
|
|
|
|
|
|
2020-03-12 19:18:21 +01:00
|
|
|
|
2020-03-12 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
|
|
|
|
|
|
(SELFTESTS_SRCS): ... this. Add disasm-selftests.c,
|
|
|
|
|
|
gdbarch-selfselftests.c and selftest-arch.c.
|
|
|
|
|
|
(SUBDIR_UNITTESTS_OBS): Rename to...
|
|
|
|
|
|
(SELFTESTS_OBS): ... this.
|
|
|
|
|
|
(COMMON_SFILES): Remove disasm-selftests.c and
|
|
|
|
|
|
gdbarch-selftests.c.
|
|
|
|
|
|
* configure.ac: Don't add selftest-arch.{c,o} to
|
|
|
|
|
|
CONFIG_{SRCS,OBS}.
|
|
|
|
|
|
* disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
|
|
|
|
|
|
preprocessor conditions.
|
|
|
|
|
|
|
2020-03-12 19:18:00 +01:00
|
|
|
|
2020-03-12 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* configure.ac: Don't source bfd/development.sh.
|
|
|
|
|
|
* selftest.m4: Modify comment.
|
|
|
|
|
|
* configure: Re-generate.
|
|
|
|
|
|
|
2020-03-12 19:12:36 +01:00
|
|
|
|
2020-03-12 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
|
|
|
|
|
|
not "true" or "false".
|
|
|
|
|
|
* configure: Re-generate.
|
|
|
|
|
|
|
2020-03-05 22:32:54 +01:00
|
|
|
|
2020-03-12 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
|
|
|
|
|
|
* arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
|
|
|
|
|
|
renamed to arm_nbsd_supply_gregset.
|
|
|
|
|
|
(fetch_register): Update to call arm_nbsd_supply_gregset.
|
|
|
|
|
|
(fetch_regs): Remove in favor of fetch_register with a -1 regno.
|
|
|
|
|
|
(arm_netbsd_nat_target::fetch_registers): Update.
|
|
|
|
|
|
(fetch_elfcore_registers): Removed.
|
|
|
|
|
|
(_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
|
|
|
|
|
|
* arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
|
|
|
|
|
|
(arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
|
|
|
|
|
|
not require NetBSD system headers.
|
|
|
|
|
|
(arm_nbsd_regset): New struct.
|
|
|
|
|
|
(arm_nbsd_iterate_over_regset_sections): New function.
|
|
|
|
|
|
(arm_netbsd_init_abi_common): Updated to call
|
|
|
|
|
|
set_gdbarch_iterate_over_regset_sections.
|
|
|
|
|
|
* arm-nbsd-tdep.h: New file.
|
|
|
|
|
|
|
Avoid infinite recursion in find_pc_sect_line
A patch somewhat like this patch has been in Fedora GDB for well over
a decade. The Fedora patch was written by Jan Kratochvil. The Fedora
version prints a warning and attempts to continue. This version will
error out, fatally. An earlier version of this patch was more like
the Fedora version than this one. Simon Marchi recommended use of an
assertion to test for the infinite recursion; I decided to use an
explicit test (with an "if" statement) along with a call to
internal_error() if the condition is met. This way, I could include
a plea to file a bug report.
It was motivated by a customer reported bug (back in 2006!) which
showed infinite mutual recursion between find_pc_sect_line and
find_pc_line. Here is a portion of the backtrace from the bug report:
(gdb) bt
#0 0x00000000004450a4 in lookup_minimal_symbol_by_pc_section (
pc=251700325328, section=0x570f500) at gdb/minsyms.c:484
#1 0x00000000004bbfb2 in find_pc_sect_line (pc=251700325328,
section=0x570f500, notcurrent=0) at gdb/symtab.c:2057
#2 0x00000000004bc480 in find_pc_line (pc=251700325328, notcurrent=0)
at gdb/symtab.c:2232
#3 0x00000000004bc1ff in find_pc_sect_line (pc=251700325328,
section=0x570f500, notcurrent=0) at gdb/symtab.c:2081
... (lots and lots of the same two functions with the same parameters)
#1070 0x00000000004bc480 in find_pc_line (pc=251700325328, notcurrent=0)
at gdb/symtab.c:2232
#1071 0x00000000004bc1ff in find_pc_sect_line (pc=251700325328,
section=0x570f500, notcurrent=0) at gdb/symtab.c:2081
#1072 0x00000000004bc480 in find_pc_line (pc=251700325328, notcurrent=0)
at gdb/symtab.c:2232
#1073 0x00000000004bc1ff in find_pc_sect_line (pc=251700325328,
section=0x570f500, notcurrent=0) at gdb/symtab.c:2081
#1074 0x00000000004bc480 in find_pc_line (pc=251700325328, notcurrent=0)
at gdb/symtab.c:2232
#1075 0x00000000004bc1ff in find_pc_sect_line (pc=251696794399,
section=0x59b0df8, notcurrent=0) at gdb/symtab.c:2081
#1076 0x00000000004bc480 in find_pc_line (pc=251696794399, notcurrent=0)
at gdb/symtab.c:2232
#1077 0x000000000055550e in find_frame_sal (frame=0xb3f3e0, sal=0x7fff1d1a8200)
at gdb/frame.c:1392
#1078 0x00000000004d86fd in set_current_sal_from_frame (frame=0x1648, center=1)
at gdb/stack.c:379
#1079 0x00000000004cf137 in normal_stop () at gdb/infrun.c:3147
...
The test case was a large application. Attempts were made to make a
small(er) test case, but those attempts were not successful.
Therefore, I cannot provide a new test for this patch.
That said, we ought to guard against recursively calling
find_pc_sect_line (via find_pc_line) with the identical PC value that
it had been called with. Should this happen, infinite recursion (as
shown in the above backtrace) is the result. This patch prevents
that from happening.
If this should happens, there is a bug somewhere, perhaps in GDB, perhaps
in some other part of the toolchain or a library. We error out fatally
with a message briefly describing the condition along with a plea to file
a bug report.
I spent some time looking at the surrounding code and commentary which
handle the case of PC being in a stub/trampoline. It first appeared
in the public GDB repository in April, 1999. The ChangeLog entry for
this commit is from 1998-12-31. The relevant portion is:
(find_pc_sect_line): Return correct information if pc is in import
or export stub (trampoline).
What's remarkable about the overall ChangeLog entry is that it's over
2500+ lines long! I believe that this was part of the infamous "HP
merge" (in which insufficient due diligence was given in accepting
a large batch of changes from an outside source). In the years that
followed, much of this code was either significantly revised or
outright removed.
For this particular case, I'm grateful that extensive comments were
provided by "RT". (I haven't been able to figure out who RT is/was.)
I've decided against attempting to revise this stub/trampoline handling
code any further than adding Jan's test which prevents an obvious case
of infinite recursion.
I've tested on Fedora 31, x86-64. I see no regressions. I've also
searched the logfile for the new message, but as expected, no message
was found (which is good).
gdb/ChangeLog:
* symtab.c (find_pc_sect_line): Add check which prevents infinite
recursion.
Change-Id: I595470be6ab5f61ca7e4e9e70c61a252c0deaeaa
2019-11-17 19:37:39 +01:00
|
|
|
|
2020-03-11 Kevin Buettner <kevinb@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* symtab.c (find_pc_sect_line): Add check which prevents infinite
|
|
|
|
|
|
recursion.
|
|
|
|
|
|
|
2020-03-11 20:15:12 +01:00
|
|
|
|
2020-03-11 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* configure: Re-generate.
|
|
|
|
|
|
|
2020-03-11 15:29:51 +01:00
|
|
|
|
2020-03-11 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-typeprint.c (print_choices): Fix comment.
|
|
|
|
|
|
|
gdb: Fix out of bounds array access in buildsym_compunit::record_line
This commit:
commit 8c95582da858ac981f689a6f599acacb8c5c490f
Date: Mon Dec 30 21:04:51 2019 +0000
gdb: Add support for tracking the DWARF line table is-stmt field
Introduced an invalid memory access, by reading outside the bounds of
an array.
This would cause this valgrind error:
==7633== Invalid read of size 4
==7633== at 0x4D002C: buildsym_compunit::record_line(subfile*, int, unsigned long, bool) (buildsym.c:688)
==7633== by 0x5F60A5: dwarf_record_line_1(gdbarch*, subfile*, unsigned int, unsigned long, bool, dwarf2_cu*) (read.c:19956)
==7633== by 0x5F63B0: lnp_state_machine::record_line(bool) (read.c:20024)
==7633== by 0x5F5DD5: lnp_state_machine::handle_special_opcode(unsigned char) (read.c:19851)
==7633== by 0x5F6706: dwarf_decode_lines_1(line_header*, dwarf2_cu*, int, unsigned long) (read.c:20135)
==7633== by 0x5F6C57: dwarf_decode_lines(line_header*, char const*, dwarf2_cu*, dwarf2_psymtab*, unsigned long, int) (read.c:20328)
==7633== by 0x5DF5F1: handle_DW_AT_stmt_list(die_info*, dwarf2_cu*, char const*, unsigned long) (read.c:10748)
==7633== by 0x5DF823: read_file_scope(die_info*, dwarf2_cu*) (read.c:10796)
==7633== by 0x5DDA63: process_die(die_info*, dwarf2_cu*) (read.c:9815)
==7633== by 0x5DD44A: process_full_comp_unit(dwarf2_per_cu_data*, language) (read.c:9580)
==7633== by 0x5DAB58: process_queue(dwarf2_per_objfile*) (read.c:8867)
==7633== by 0x5CB30E: dw2_do_instantiate_symtab(dwarf2_per_cu_data*, bool) (read.c:2374)
==7633== Address 0xa467f48 is 8 bytes before a block of size 16,024 alloc'd
==7633== at 0x4C2CDCB: malloc (vg_replace_malloc.c:299)
==7633== by 0x451FC4: xmalloc (alloc.c:60)
==7633== by 0x4CFFDF: buildsym_compunit::record_line(subfile*, int, unsigned long, bool) (buildsym.c:678)
==7633== by 0x5F60A5: dwarf_record_line_1(gdbarch*, subfile*, unsigned int, unsigned long, bool, dwarf2_cu*) (read.c:19956)
==7633== by 0x5F63B0: lnp_state_machine::record_line(bool) (read.c:20024)
==7633== by 0x5F5DD5: lnp_state_machine::handle_special_opcode(unsigned char) (read.c:19851)
==7633== by 0x5F6706: dwarf_decode_lines_1(line_header*, dwarf2_cu*, int, unsigned long) (read.c:20135)
==7633== by 0x5F6C57: dwarf_decode_lines(line_header*, char const*, dwarf2_cu*, dwarf2_psymtab*, unsigned long, int) (read.c:20328)
==7633== by 0x5DF5F1: handle_DW_AT_stmt_list(die_info*, dwarf2_cu*, char const*, unsigned long) (read.c:10748)
==7633== by 0x5DF823: read_file_scope(die_info*, dwarf2_cu*) (read.c:10796)
==7633== by 0x5DDA63: process_die(die_info*, dwarf2_cu*) (read.c:9815)
==7633== by 0x5DD44A: process_full_comp_unit(dwarf2_per_cu_data*, language) (read.c:9580)
gdb/ChangeLog:
* buildsyms.c (buildsym_compunit::record_line): Avoid accessing
previous item in the list, when the list has no items.
2020-03-11 12:17:39 +01:00
|
|
|
|
2020-03-11 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* buildsyms.c (buildsym_compunit::record_line): Avoid accessing
|
|
|
|
|
|
previous item in the list, when the list has no items.
|
|
|
|
|
|
|
2020-03-11 00:30:54 +01:00
|
|
|
|
2020-03-11 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
|
|
|
|
|
|
PROP_LOCLIST handling code.
|
|
|
|
|
|
|
gdb: Add support for tracking the DWARF line table is-stmt field
This commit brings support for the DWARF line table is_stmt field to
GDB. The is_stmt field is used by the compiler when a single source
line is split into multiple assembler instructions, especially if the
assembler instructions are interleaved with instruction from other
source lines.
The compiler will set the is_stmt flag false from some instructions
from the source lines, these instructions are not a good place to
insert a breakpoint in order to stop at the source line.
Instructions which are marked with the is_stmt flag true are a good
place to insert a breakpoint for that source line.
Currently GDB ignores all instructions for which is_stmt is false.
This is fine in a lot of cases, however, there are some cases where
this means the debug experience is not as good as it could be.
Consider stopping at a random instruction, currently this instruction
will be attributed to the last line table entry before this point for
which is_stmt was true - as these are the only line table entries that
GDB tracks. This can easily be incorrect in code with even a low
level of optimisation.
With is_stmt tracking in place, when stopping at a random instruction
we now attribute the instruction back to the real source line, even
when is_stmt is false for that instruction in the line table.
When inserting breakpoints we still select line table entries for
which is_stmt is true, so the breakpoint placing behaviour should not
change.
When stepping though code (at the line level, not the instruction
level) we will still stop at instruction where is_stmt is true, I
think this is more likely to be the desired behaviour.
Instruction stepping is, of course, unchanged, stepping one
instruction at a time, but we should now report more accurate line
table information with each instruction step.
The original motivation for this work was a patch posted by Bernd
here:
https://sourceware.org/ml/gdb-patches/2019-11/msg00792.html
As part of that thread it was suggested that many issues would be
resolved if GDB supported line table views, this isn't something I've
attempted in this patch, though reading the spec, it seems like this
would be a useful feature to support in GDB in the future. The spec
is here:
http://dwarfstd.org/ShowIssue.php?issue=170427.1
And Bernd gives a brief description of the benefits here:
https://sourceware.org/ml/gdb-patches/2020-01/msg00147.html
With that all said, I think that there is benefit to having proper
is_stmt support regardless of whether we have views support, so I
think we should consider getting this in first, and then building view
support on top of this.
The gdb.cp/step-and-next-inline.exp test is based off a test proposed
by Bernd Edlinger in this message:
https://sourceware.org/ml/gdb-patches/2019-12/msg00842.html
gdb/ChangeLog:
* buildsym-legacy.c (record_line): Pass extra parameter to
record_line.
* buildsym.c (buildsym_compunit::record_line): Take an extra
parameter, reduce duplication in the line table, and record the
is_stmt flag in the line table.
* buildsym.h (buildsym_compunit::record_line): Add extra
parameter.
* disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
non-statement lines.
* dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
this to the symtab builder.
(dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
(lnp_state_machine::record_line): Pass a suitable is_stmt flag
through to dwarf_record_line_1.
* infrun.c (process_event_stop_test): When stepping, don't stop at
a non-statement instruction, and only refresh the step info when
we land in the middle of a line's range. Also add an extra
comment.
* jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
field.
* record-btrace.c (btrace_find_line_range): Only record lines
marked as is-statement.
* stack.c (frame_show_address): Show the frame address if we are
in a non-statement sal.
* symmisc.c (dump_symtab_1): Print the is_stmt flag.
(maintenance_print_one_line_table): Print a header for the is_stmt
column, and include is_stmt information in the output.
* symtab.c (find_pc_sect_line): Find lines marked as statements in
preference to non-statements.
(find_pcs_for_symtab_line): Prefer is-statement entries.
(find_line_common): Likewise.
* symtab.h (struct linetable_entry): Add is_stmt field.
(struct symtab_and_line): Likewise.
* xcoffread.c (arrange_linetable): Initialise is_stmt field when
arranging the line table.
gdb/testsuite/ChangeLog:
* gdb.cp/step-and-next-inline.cc: New file.
* gdb.cp/step-and-next-inline.exp: New file.
* gdb.cp/step-and-next-inline.h: New file.
* gdb.dwarf2/dw2-is-stmt.c: New file.
* gdb.dwarf2/dw2-is-stmt.exp: New file.
* gdb.dwarf2/dw2-is-stmt-2.c: New file.
* gdb.dwarf2/dw2-is-stmt-2.exp: New file.
* gdb.dwarf2/dw2-ranges-base.exp: Update line table pattern.
2019-12-30 22:04:51 +01:00
|
|
|
|
2020-03-10 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* buildsym-legacy.c (record_line): Pass extra parameter to
|
|
|
|
|
|
record_line.
|
|
|
|
|
|
* buildsym.c (buildsym_compunit::record_line): Take an extra
|
|
|
|
|
|
parameter, reduce duplication in the line table, and record the
|
|
|
|
|
|
is_stmt flag in the line table.
|
|
|
|
|
|
* buildsym.h (buildsym_compunit::record_line): Add extra
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
* disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
|
|
|
|
|
|
non-statement lines.
|
|
|
|
|
|
* dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
|
|
|
|
|
|
this to the symtab builder.
|
|
|
|
|
|
(dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
|
|
|
|
|
|
(lnp_state_machine::record_line): Pass a suitable is_stmt flag
|
|
|
|
|
|
through to dwarf_record_line_1.
|
|
|
|
|
|
* infrun.c (process_event_stop_test): When stepping, don't stop at
|
|
|
|
|
|
a non-statement instruction, and only refresh the step info when
|
|
|
|
|
|
we land in the middle of a line's range. Also add an extra
|
|
|
|
|
|
comment.
|
|
|
|
|
|
* jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
|
|
|
|
|
|
field.
|
|
|
|
|
|
* record-btrace.c (btrace_find_line_range): Only record lines
|
|
|
|
|
|
marked as is-statement.
|
|
|
|
|
|
* stack.c (frame_show_address): Show the frame address if we are
|
|
|
|
|
|
in a non-statement sal.
|
|
|
|
|
|
* symmisc.c (dump_symtab_1): Print the is_stmt flag.
|
|
|
|
|
|
(maintenance_print_one_line_table): Print a header for the is_stmt
|
|
|
|
|
|
column, and include is_stmt information in the output.
|
|
|
|
|
|
* symtab.c (find_pc_sect_line): Find lines marked as statements in
|
|
|
|
|
|
preference to non-statements.
|
|
|
|
|
|
(find_pcs_for_symtab_line): Prefer is-statement entries.
|
|
|
|
|
|
(find_line_common): Likewise.
|
|
|
|
|
|
* symtab.h (struct linetable_entry): Add is_stmt field.
|
|
|
|
|
|
(struct symtab_and_line): Likewise.
|
|
|
|
|
|
* xcoffread.c (arrange_linetable): Initialise is_stmt field when
|
|
|
|
|
|
arranging the line table.
|
|
|
|
|
|
|
2020-03-07 16:33:45 +01:00
|
|
|
|
2020-03-07 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
|
|
|
|
|
|
DIE.
|
|
|
|
|
|
|
2020-03-07 15:53:42 +01:00
|
|
|
|
2020-03-07 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valops.c (value_literal_complex): Remove obsolete comment.
|
|
|
|
|
|
* gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
|
|
|
|
|
|
comment.
|
|
|
|
|
|
|
Pass thread_info pointer to various inferior control functions
[ Migrating this from Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/321 ]
I noticed that some functions in infcmd and infrun call each other and
all call inferior_thread, while they could just get the thread_info
pointer from their caller. That means less calls to inferior_thread, so
less reliance on global state, since inferior_thread reads
inferior_ptid.
The paths I am unsure about are:
- fetch_inferior_event calls...
- step_command_fsm::should_stop calls...
- prepare_one_step
and
- process_event_stop_test calls...
- set_step_info
Before this patch, prepare_one_step gets the thread pointer using
inferior_thread. After this patch, it gets it from the
execution_control_state structure in fetch_inferior_event. Are we sure
that the thread from the execution_control_state structure is the same
as the one inferior_thread would return? This code path is used when a
thread completes a step, but the user had specified a step count (e.g.
"step 5") so we decide to do one more step. It would be strange (and
even a bug I suppose) if the thread in the ecs structure in
fetch_inferior_event was not the same thread that is prepared to stepped
by prepare_one_step. So I believe passing the ecs thread is fine.
The same logic applies to process_event_stop_test calling
set_step_info.
gdb/ChangeLog:
* infrun.h: Forward-declare thread_info.
(set_step_info): Add thread_info parameter, add doc.
* infrun.c (set_step_info): Add thread_info parameter, move doc
to header.
* infrun.c (process_event_stop_test): Pass thread to
set_step_info call.
* infcmd.c (set_step_frame): Add thread_info pointer, pass it to
set_step_info.
(prepare_one_step): Add thread_info parameter, pass it to
set_step_frame and prepare_one_step (recursive) call.
(step_1): Pass thread to prepare_one_step call.
(step_command_fsm::should_stop): Pass thread to
prepare_one_step.
(until_next_fsm): Pass thread to set_step_frame call.
(finish_command): Pass thread to set_step_info call.
2020-03-07 00:04:52 +01:00
|
|
|
|
2020-03-06 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* infrun.h: Forward-declare thread_info.
|
|
|
|
|
|
(set_step_info): Add thread_info parameter, add doc.
|
|
|
|
|
|
* infrun.c (set_step_info): Add thread_info parameter, move doc
|
|
|
|
|
|
to header.
|
|
|
|
|
|
* infrun.c (process_event_stop_test): Pass thread to
|
|
|
|
|
|
set_step_info call.
|
|
|
|
|
|
* infcmd.c (set_step_frame): Add thread_info pointer, pass it to
|
|
|
|
|
|
set_step_info.
|
|
|
|
|
|
(prepare_one_step): Add thread_info parameter, pass it to
|
|
|
|
|
|
set_step_frame and prepare_one_step (recursive) call.
|
|
|
|
|
|
(step_1): Pass thread to prepare_one_step call.
|
|
|
|
|
|
(step_command_fsm::should_stop): Pass thread to
|
|
|
|
|
|
prepare_one_step.
|
|
|
|
|
|
(until_next_fsm): Pass thread to set_step_frame call.
|
|
|
|
|
|
(finish_command): Pass thread to set_step_info call.
|
|
|
|
|
|
|
2020-03-04 21:20:31 +01:00
|
|
|
|
2020-03-06 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-tdep.c (windows_solib_create_inferior_hook):
|
|
|
|
|
|
Check if inferior is running.
|
|
|
|
|
|
|
2020-03-06 15:22:23 +01:00
|
|
|
|
2020-03-06 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Fix "the the".
|
|
|
|
|
|
* ctfread.c: Same.
|
|
|
|
|
|
|
2020-03-06 12:51:59 +01:00
|
|
|
|
2020-03-06 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
* psymtab.c (psymtab_to_symtab): Don't print "done.".
|
|
|
|
|
|
|
gdbserver/gdbsupport: Add .dir-locals.el file
Copy the .dir-locls.el file from gdb/ to gdbserver/ and gdbsupport/ so
that we get the GNU/GDB style when editing these files in Emacs.
I initially wanted to remove the (c-mode . ((mode . c++))) that
switches c-mode files into c++-mode as we store C++ code in *.cc files
in the gdbserver/ directory, unlike gdb/ where we use *.c, however, I
was forgetting about the header files - we still use *.h for our C++
header files, so for now I left the settings in place to open all C
files in c++-mode.
We now have three copies of this file, which are all identical. It
would be nice if we could remove this duplication, however, for now we
haven't found a good way to do this.
Some options considered were:
1. Use symlinks to only have one copy of the file. This was
rejected as not all targets support symlinks in the way.
2. Have two of the .dir-locals.el files contain some mechanism by
which the third copy of the file is sourced. Though this would, in
theory, be possible, it would involve some advanced Emacs scripting,
would be fragile, and a maintenance burdon.
3. Move the .dir-locals up into top level src/ directory, then use
Emacs dir-locals directory pattern matching to only apply the rules
for the three directories we care about. The problem is that each
directory has to be listed separately, so we still end up having to
duplicate all the rules.
In the end, it was decided that having three copies of the file,
though not ideal, is probably easiest for now. This was all discussed
in this mailing list thread:
https://sourceware.org/ml/gdb-patches/2020-03/msg00024.html
The copyright date in the new files is left as for gdb/.dir-locals.el,
as the new files are a copy of the old, this is inline with this rule:
https://sourceware.org/gdb/wiki/ContributionChecklist#Copyright_Header
gdb/ChangeLog:
* .dir-locals.el: Add a comment referencing the other copies of
this file.
gdbserver/ChangeLog:
* .dir-locals.el: New file.
gdbsupport/ChangeLog:
* .dir-locals.el: New file.
2020-02-28 19:08:08 +01:00
|
|
|
|
2020-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* .dir-locals.el: Add a comment referencing the other copies of
|
|
|
|
|
|
this file.
|
|
|
|
|
|
|
2020-03-06 00:02:45 +01:00
|
|
|
|
2020-03-05 John Baldwin <jhb@FreeBSD.org>
|
|
|
|
|
|
|
|
|
|
|
|
* fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
|
|
|
|
|
|
psargs.
|
|
|
|
|
|
|
gdb, gdbserver, gdbsupport: add .gitattributes files
Create .gitattributes files in gdb/, gdbserver/, and gdbsupport/.
The files specify cpp-style diffs for .h and .c files. This is
particularly helpful if a class in a header file is modified.
For instance, if the `stop_requested` field of `thread_info` in
gdb/gdbthread.h is modified, we get the following diff with
'git diff' (using git version 2.17.1):
@@ -379,7 +379,7 @@ public:
struct target_waitstatus pending_follow;
/* True if this thread has been explicitly requested to stop. */
- int stop_requested = 0;
+ bool stop_requested = 0;
/* The initiating frame of a nexting operation, used for deciding
which exceptions to intercept. If it is null_frame_id no
Note that the context of the change shows up as 'public:'; not so
useful. With the .gitattributes file, we get:
@@ -379,7 +379,7 @@ class thread_info : public refcounted_object
struct target_waitstatus pending_follow;
/* True if this thread has been explicitly requested to stop. */
- int stop_requested = 0;
+ bool stop_requested = 0;
/* The initiating frame of a nexting operation, used for deciding
which exceptions to intercept. If it is null_frame_id no
The context is successfully shown as 'class thread_info'.
This patch creates a .gitattributes file per each of gdb, gdbserver,
and gdbsupport folders. An alternative would be to define the
attributes in the root folder -- this would impact all the top-level
folders, though. I opted for the more conservative approach.
gdb/ChangeLog:
2020-03-05 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* .gitattributes: New file.
gdbserver/ChangeLog:
2020-03-05 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* .gitattributes: New file.
gdbsupport/ChangeLog:
2020-03-05 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* .gitattributes: New file.
2020-03-05 15:59:22 +01:00
|
|
|
|
2020-03-05 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
* .gitattributes: New file.
|
|
|
|
|
|
|
2020-03-05 00:34:49 +01:00
|
|
|
|
2020-03-04 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* symmisc.c (print_symbol_bcache_statistics)
|
|
|
|
|
|
(print_objfile_statistics): Update.
|
|
|
|
|
|
* symfile.c (allocate_symtab): Use intern.
|
|
|
|
|
|
* psymtab.c (partial_symtab::partial_symtab): Use intern.
|
|
|
|
|
|
* objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
|
|
|
|
|
|
macro_cache>: Remove.
|
|
|
|
|
|
<string_cache>: New member.
|
|
|
|
|
|
(struct objfile) <intern>: New methods.
|
|
|
|
|
|
* elfread.c (elf_symtab_read): Use intern.
|
|
|
|
|
|
* dwarf2/read.c (fixup_go_packaging): Intern package name.
|
|
|
|
|
|
(dwarf2_compute_name, dwarf2_physname)
|
|
|
|
|
|
(create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
|
|
|
|
|
|
names.
|
|
|
|
|
|
(guess_partial_die_structure_name): Update.
|
|
|
|
|
|
(partial_die_info::fixup): Intern name.
|
|
|
|
|
|
(dwarf2_canonicalize_name): Change parameter to objfile. Intern
|
|
|
|
|
|
name.
|
|
|
|
|
|
(dwarf2_name): Intern name. Update.
|
|
|
|
|
|
* buildsym.c (buildsym_compunit::get_macro_table): Use
|
|
|
|
|
|
string_cache.
|
|
|
|
|
|
|
2020-03-05 00:24:08 +01:00
|
|
|
|
2020-03-04 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* jit.c (bfd_open_from_target_memory): Make "target" const.
|
|
|
|
|
|
* corefile.c (gnutarget): Now const.
|
|
|
|
|
|
* gdbcore.h (gnutarget): Now const.
|
|
|
|
|
|
|
2020-01-26 22:04:04 +01:00
|
|
|
|
2020-03-04 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Mention support for WOW64 processes.
|
|
|
|
|
|
* amd64-windows-nat.c (amd64_mappings): Rename and remove static.
|
|
|
|
|
|
(amd64_windows_segment_register_p): Remove static.
|
|
|
|
|
|
(_initialize_amd64_windows_nat): Update.
|
|
|
|
|
|
* configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
|
|
|
|
|
|
* i386-windows-nat.c (context_offset): Update.
|
|
|
|
|
|
(i386_mappings): Rename and remove static.
|
|
|
|
|
|
(i386_windows_segment_register_p): Remove static.
|
|
|
|
|
|
(_initialize_i386_windows_nat): Update.
|
|
|
|
|
|
* windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
|
|
|
|
|
|
(STATUS_WX86_SINGLE_STEP): New macro.
|
|
|
|
|
|
(EnumProcessModulesEx): New macro.
|
|
|
|
|
|
(Wow64SuspendThread): New macro.
|
|
|
|
|
|
(Wow64GetThreadContext): New macro.
|
|
|
|
|
|
(Wow64SetThreadContext): New macro.
|
|
|
|
|
|
(Wow64GetThreadSelectorEntry): New macro.
|
|
|
|
|
|
(windows_set_context_register_offsets): Add static.
|
|
|
|
|
|
(windows_set_segment_register_p): Likewise.
|
|
|
|
|
|
(windows_add_thread): Adapt for WOW64 processes.
|
|
|
|
|
|
(windows_fetch_one_register): Likewise.
|
|
|
|
|
|
(windows_nat_target::fetch_registers): Likewise.
|
|
|
|
|
|
(windows_store_one_register): Likewise.
|
|
|
|
|
|
(display_selector): Likewise.
|
|
|
|
|
|
(display_selectors): Likewise.
|
|
|
|
|
|
(handle_exception): Likewise.
|
|
|
|
|
|
(windows_continue): Likewise.
|
|
|
|
|
|
(windows_nat_target::resume): Likewise.
|
|
|
|
|
|
(windows_add_all_dlls): Likewise.
|
|
|
|
|
|
(do_initial_windows_stuff): Likewise.
|
|
|
|
|
|
(windows_nat_target::attach): Likewise.
|
|
|
|
|
|
(windows_get_exec_module_filename): Likewise.
|
|
|
|
|
|
(windows_nat_target::create_inferior): Likewise.
|
|
|
|
|
|
(windows_xfer_siginfo): Likewise.
|
|
|
|
|
|
(_initialize_loadable): Initialize Wow64SuspendThread,
|
|
|
|
|
|
Wow64GetThreadContext, Wow64SetThreadContext,
|
|
|
|
|
|
Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
|
|
|
|
|
|
* windows-nat.h (windows_set_context_register_offsets):
|
|
|
|
|
|
Remove declaration.
|
|
|
|
|
|
(windows_set_segment_register_p): Likewise.
|
|
|
|
|
|
(i386_windows_segment_register_p): Add declaration.
|
|
|
|
|
|
(amd64_windows_segment_register_p): Likewise.
|
|
|
|
|
|
|
2020-03-04 17:08:13 +01:00
|
|
|
|
2020-03-04 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
|
|
|
|
|
|
in "info registers" for AArch64/ARM.
|
|
|
|
|
|
|
|
|
|
|
|
The change caused "info registers" to not print GPR's.
|
|
|
|
|
|
|
|
|
|
|
|
gdb/ChangeLog:
|
|
|
|
|
|
|
|
|
|
|
|
2020-02-01 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
|
|
|
|
|
|
when reg->group is empty and reggroup is not.
|
|
|
|
|
|
|
Find tailcall frames before inline frames
A customer reported a failure to unwind in a certain core dump. A
lengthy investigation showed that the problem came from the
interaction between the tailcall and inline frame sniffers.
Normally, the regular DWARF unwinder may discover a chain of tail
calls ending in the current frame. In this case, it sets a member on
the dwarf2_frame_cache object, so that a subsequent call into the
tailcall sniffer will create the tailcall frames.
However, in this scenario, what happened is that the DWARF unwinder
did find tailcall frames -- but then the PC of the first such frame
was recognized and claimed by the inline frame sniffer.
This then caused unwinding to go astray further up the stack.
This patch fixes the problem by arranging for the tailcall sniffer to
be called before the inline sniffer. This way, if a DWARF frame has
tailcall information, the tailcalls will always be processed first.
This is safe to do, because the tailcall sniffer can only claim a
frame if the previous frame did in fact find this information. (So,
for example, if no DWARF frame is ever found, then this sniffer will
never trigger.)
This patch also partially reverts:
commit 1ec56e88aa9b052ab10b806d82fbdbc8d153d977
Author: Pedro Alves <palves@redhat.com>
Date: Fri Nov 22 13:17:46 2013 +0000
Eliminate dwarf2_frame_cache recursion, don't unwind from the dwarf2 sniffer (move dwarf2_tailcall_sniffer_first elsewhere).
That patch moved the call to dwarf2_tailcall_sniffer_first out of
dwarf2_frame_cache, and into dwarf2_frame_prev_register. However, in
this situation, this is too late -- by the time
dwarf2_frame_prev_register is called, the frame in question is already
recognized by the inline frame sniffer.
Rather than fully revert that patch, though, this just arranges to
call dwarf2_tailcall_sniffer_first from dwarf2_frame_cache -- which is
called shortly after the DWARF frame sniffer succeeds, via
compute_frame_id.
I don't know how to write a test case for this.
gdb/ChangeLog
2020-03-03 Tom Tromey <tromey@adacore.com>
* dwarf2/frame.c (struct dwarf2_frame_cache)
<checked_tailcall_bottom, entry_cfa_sp_offset,
entry_cfa_sp_offset_p>: Remove members.
(dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
(dwarf2_frame_prev_register): Don't call
dwarf2_tailcall_sniffer_first.
(dwarf2_append_unwinders): Don't append tailcall unwinder.
* frame-unwind.c (add_unwinder): New fuction.
(frame_unwind_init): Use it. Add tailcall unwinder.
2020-03-03 23:27:04 +01:00
|
|
|
|
2020-03-03 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/frame.c (struct dwarf2_frame_cache)
|
|
|
|
|
|
<checked_tailcall_bottom, entry_cfa_sp_offset,
|
|
|
|
|
|
entry_cfa_sp_offset_p>: Remove members.
|
|
|
|
|
|
(dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
|
|
|
|
|
|
(dwarf2_frame_prev_register): Don't call
|
|
|
|
|
|
dwarf2_tailcall_sniffer_first.
|
|
|
|
|
|
(dwarf2_append_unwinders): Don't append tailcall unwinder.
|
|
|
|
|
|
* frame-unwind.c (add_unwinder): New fuction.
|
|
|
|
|
|
(frame_unwind_init): Use it. Add tailcall unwinder.
|
|
|
|
|
|
|
2020-03-02 19:08:49 +01:00
|
|
|
|
2020-03-03 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
Alok Kumar Sharma <AlokKumar.Sharma@amd.com>
|
|
|
|
|
|
|
|
|
|
|
|
* f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
|
|
|
|
|
|
value should be printed as true.
|
|
|
|
|
|
|
2020-02-12 17:53:32 +01:00
|
|
|
|
2020-03-03 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-tdep.c (windows_solib_create_inferior_hook): New function.
|
|
|
|
|
|
(windows_init_abi): Set and use windows_so_ops.
|
|
|
|
|
|
|
2020-03-02 00:15:53 +01:00
|
|
|
|
2020-03-03 Sergio Durigan Junior <sergiodj@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
|
|
|
|
|
|
when verifying if dealing with a convenience variable.
|
|
|
|
|
|
|
2020-02-25 01:04:05 +01:00
|
|
|
|
2020-03-03 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* auxv.c (default_print_auxv_entry): Add new AUXV entries.
|
|
|
|
|
|
|
2020-03-02 21:47:04 +01:00
|
|
|
|
2020-03-02 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* infrun.c (gdbarch_supports_displaced_stepping): New.
|
|
|
|
|
|
(use_displaced_stepping): Break up conditions in smaller pieces.
|
|
|
|
|
|
Use gdbarch_supports_displaced_stepping.
|
|
|
|
|
|
(displaced_step_prepare_throw): Use
|
|
|
|
|
|
gdbarch_supports_displaced_stepping.
|
|
|
|
|
|
|
gdb: Allow GDB to _not_ load a previous command history
This commit aims to give a cleaner mechanism by which the user can
prevent GDB from trying to load any previous command history.
Currently the user can change the path to the history file, either
using a command line flag, or by setting the GDBHISTFILE environment
variable, and if the path is set to a non-existent file, then
obviously GDB wont load any command history. However, this feels like
a bit of a bodge, I'd like to add an official mechanism by which we
can disable command history loading.
Why would we want to prevent command history loading? The specific
use case I have is GDB starting with a CWD that is a network mounted
directory, and there is no command history present. Still GDB will
access the network in order to check for the file. In my particular
use case I'm actually starting a large number of GDB instances in
parallel, all in the same network mounted directory, the large number
of network accesses looking for this file introduces a noticeable
delay at GDB startup.
The approach I'm proposing here is a slight adjustment to the current
rules for setting up the history filename. Currently, if a user does
this, they see an error:
(gdb) set history filename
Argument required (filename to set it to.).
However, if a user does this:
$ GDBHISTFILE= gdb --quiet
(gdb) set history save on
(gdb) q
warning: Could not rename -gdb18416~ to : No such file or directory
So, we already have a bug in this area. My plan is to allow the empty
filename to be accepted, and for this to mean, neither load, nor save
the command history.
This does mean that we now have two mechanisms to prevent saving the
command history:
(gdb) set history filename
or
(gdb) set history save off
But the only way to prevent loading the command history is to set the
filename to the empty string _before_ you get to a GDB prompt, either
using a command line option, or the environment variable.
I've updated some of the show commands, for example this session:
(gdb) set history filename
(gdb) show history filename
There is no filename currently set for recording the command history in.
(gdb) show history save
Saving of the history record on exit is off.
(gdb) set history save on
(gdb) show history save
Saving of the history is disabled due to the value of 'history filename'.
(gdb) set history filename /tmp/hist
(gdb) show history save
Saving of the history record on exit is on.
I've updated the manual, and added some tests.
gdb/ChangeLog:
* NEWS: Mention new behaviour of the history filename.
* top.c (write_history_p): Add comment.
(show_write_history_p): Add header comment, give a different
message when history writing is on, but the history filename is
empty.
(history_filename): Add comment.
(history_filename_empty): New function.
(show_history_filename): Add header comment, give a different
message when the filename is empty.
(init_history): Compare history_filename against nullptr, and only
read history if the filename is not empty.
(set_history_filename): Add header comment, and only make
non-empty filenames absolute.
(init_main): Make the filename argument to 'set history filename'
optional.
gdb/doc/ChangeLog:
* gdb.texinfo (Command History): Extend description for
GDBHISTFILE and GDBHISTSIZE, add detail about the filename for
'set history filename' being optional. Describe the effect of an
empty history filename on 'set history save on'.
gdb/testsuite/ChangeLog:
* gdb.base/default.exp: Remove test of 'set history filename'.
* gdb.base/gdbinit-history.exp: Add tests for setting the history
filename to the empty string.
* lib/gdb.exp (gdb_init): Unset environment variables GDBHISTFILE
and GDBHISTSIZE.
Change-Id: Ia586e4311182fac99113b60f11ef8a11fbd5450b
2020-01-22 19:21:58 +01:00
|
|
|
|
2020-03-02 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Mention new behaviour of the history filename.
|
|
|
|
|
|
* top.c (write_history_p): Add comment.
|
|
|
|
|
|
(show_write_history_p): Add header comment, give a different
|
|
|
|
|
|
message when history writing is on, but the history filename is
|
|
|
|
|
|
empty.
|
|
|
|
|
|
(history_filename): Add comment.
|
|
|
|
|
|
(history_filename_empty): New function.
|
|
|
|
|
|
(show_history_filename): Add header comment, give a different
|
|
|
|
|
|
message when the filename is empty.
|
|
|
|
|
|
(init_history): Compare history_filename against nullptr, and only
|
|
|
|
|
|
read history if the filename is not empty.
|
|
|
|
|
|
(set_history_filename): Add header comment, and only make
|
|
|
|
|
|
non-empty filenames absolute.
|
|
|
|
|
|
(init_main): Make the filename argument to 'set history filename'
|
|
|
|
|
|
optional.
|
|
|
|
|
|
|
2020-03-02 18:28:14 +01:00
|
|
|
|
2020-03-02 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
|
|
|
|
|
|
(arm_supply_vfpregset): ...this, and update to use VFP registers.
|
|
|
|
|
|
(fetch_fp_register): Update.
|
|
|
|
|
|
(fetch_fp_regs): Update.
|
|
|
|
|
|
(store_fp_register): Update.
|
|
|
|
|
|
(store_fp_regs): Update.
|
|
|
|
|
|
(arm_netbsd_nat_target::read_description): New function.
|
|
|
|
|
|
(fetch_elfcore_registers): Update.
|
|
|
|
|
|
|
gdb/remote: Restore support for 'S' stop reply packet
With this commit:
commit 5b6d1e4fa4fc6827c7b3f0e99ff120dfa14d65d2
Date: Fri Jan 10 20:06:08 2020 +0000
Multi-target support
There was a regression in GDB's support for older aspects of the
remote protocol. Specifically, when a target sends the 'S' stop reply
packet (which doesn't include a thread-id) then GDB has to figure out
which thread actually stopped.
Before the above commit GDB figured this out by using inferior_ptid in
process_stop_reply, which contained the ptid of the current
process/thread. This would be fine for single threaded
targets (which is the only place using an S packet makes sense), but
in the general case, relying on inferior_ptid for processing a stop is
wrong - there's no reason to believe that what was GDB's current
thread will be the same thread that just stopped in the target.
With the above commit the inferior_ptid now has the value null_ptid
inside process_stop_reply, this can be seen in do_target_wait, where
we call switch_to_inferior_no_thread before calling do_target_wait_1.
The problem this causes can be seen in the new test that runs
gdbserver using the flag --disable-packet=T, and causes GDB to throw
this assertion:
inferior.c:279: internal-error: inferior* find_inferior_pid(process_stratum_target*, int): Assertion `pid != 0' failed.
A similar problem was fixed in this commit:
commit 3cada74087687907311b52781354ff551e10a0ed
Date: Thu Jan 11 00:23:04 2018 +0000
Fix backwards compatibility with old GDBservers (PR remote/22597)
However, this commit deals with the case where the T packet doesn't
include a thread-id, not the S packet case. This commit solves the
problem providing a thread-id at the GDB side if the remote target
doesn't provide one. The thread-id provided comes from
remote_state::general_thread, however, though this does work, I don't
think it is the ideal solution.
The remote_state tracks two threads, the continue_thread and the
general_thread, these are updated when GDB asks the remote target to
switch threads. The general_thread is set before performing things
like register or memory accesses, and the continue_thread is set
before things like continue or step commands. Further, the
general_thread is updated after a target stops to reference the thread
that stopped.
The first thing to note from the above description is that we have a
cycle of dependency, when a T packet arrives without a thread-id we
fill in the thread-id from the general_thread data. The thread-id
from the stop event is then used to set the general_thread. This in
itself feels a little weird.
The second question is why use the general_thread at all? You'd think
given how they are originally set that the continue thread would be a
better choice. The problem with this is that the continue_thread, if
the user just does "continue", will be set to the minus_one_ptid, in
the remote protocol this means all threads. When the stop arrives
with no thread-id and we use continue_thread we end up with a very
similar assertion to before because we now end up trying to lookup a
thread using the minus_one_ptid. By contrast, once GDB has connected
to a remote target the general_thread will be set to a valid
thread-id, after which, if the target is single threaded, and stop
events arrive without a thread-id, everything works fine.
There is one slight weirdness with the above behaviour though. When
GDB first connects to the remote target inferior_ptid is null_ptid,
however, upon connecting we query the remote for its threads. As the
thread information arrives GDB adds the threads to its internal
database, and this process involves setting inferior_ptid to the id of
each new thread in turn. Once we know about all the threads we wait
for a stop event from the remote target to indicate that GDB is now in
control of the target.
The problem is that after adding the new threads we don't reset
inferior_ptid, and the code path we use to wait for a stop event from
the target also doesn't reset inferior_ptid, so it turns out that
during the initial connection inferior_ptid is not null_ptid. This is
lucky, because during the initial connection the general_thread
variable _is_ set to null_ptid.
So, during the initial connection, if the first stop event is missing
a thread-id then we "provide" a thead-id from general_thread. This
turns out to be null_ptid meaning no thread-id is known, and then
during process_stop_reply we fill in the missing thread-id using
inferior_ptid.
This was all discussed on the mailing list here:
https://sourceware.org/ml/gdb-patches/2020-02/msg01011.html
My proposal for a fix then is:
1. Move the call to switch_to_inferior_no_thread into
do_target_wait_1, this means that in all cases where we are waiting
for an inferior the inferior_ptid will be set to null_ptid. This is
good as no wait code should rely on inferior_ptid.
2. Remove the use of general_thread from the 'T' packet processing.
The general_thread read here was only ever correct by chance, and we
shouldn't be using it this way.
3. Remove use of inferior_ptid from process_stop_event as this is
wrong, and will always be null_ptid now anyway.
4. When a stop_event has null_ptid due to a lack of thread-id (either
from a T packet or an S packet) then pick the first non exited thread
in the target and use that. This will be fine for single threaded
targets. A multi-thread or multi-inferior aware remote target
should be using T packets with a thread-id, so we give a warning if
the target is multi-threaded, and we are still missing a thread-id.
5. Extend the existing test that covered the T packet with missing
thread-id to also cover the S packet.
gdb/ChangeLog:
* remote.c (remote_target::remote_parse_stop_reply): Don't use the
general_thread if the stop reply is missing a thread-id.
(remote_target::process_stop_reply): Use the first non-exited
thread if the target didn't pass a thread-id.
* infrun.c (do_target_wait): Move call to
switch_to_inferior_no_thread to ....
(do_target_wait_1): ... here.
gdb/testsuite/ChangeLog:
* gdb.server/stop-reply-no-thread.exp: Add test where T packet is
disabled.
2020-01-30 15:35:40 +01:00
|
|
|
|
2020-03-02 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::remote_parse_stop_reply): Don't use the
|
|
|
|
|
|
general_thread if the stop reply is missing a thread-id.
|
|
|
|
|
|
(remote_target::process_stop_reply): Use the first non-exited
|
|
|
|
|
|
thread if the target didn't pass a thread-id.
|
|
|
|
|
|
* infrun.c (do_target_wait): Move call to
|
|
|
|
|
|
switch_to_inferior_no_thread to ....
|
|
|
|
|
|
(do_target_wait_1): ... here.
|
|
|
|
|
|
|
2020-02-29 14:33:35 +01:00
|
|
|
|
2020-02-29 Jon Turney <jon.turney@dronecode.org.uk>
|
|
|
|
|
|
|
|
|
|
|
|
* debuginfod-support.c: Include defs.h first.
|
|
|
|
|
|
|
[gdb] Don't set initial language using previous language
When language is set to auto, part of loading an executable is to update the
language accordingly. This is implemented by set_initial_language.
In case of a c++ executable without DW_AT_main_subprogram,
set_initial_language finds "main" in the minimal symbols, and does a lookup of
"main" in the symbol tables to determine the language of the symbol, and uses
that as initial language.
The symbol lookup is done using lookup_symbol which is a wrapper around
lookup_symbol_in_language, using the current language.
So, consider two c++ executables a.out and b.out, which we'll load one after
another. If we track the resulting lookup_symbol_in_language calls:
...
$ gdb -batch \
-ex "b lookup_symbol_in_language" \
-ex r -ex c -ex c \
--args gdb
...
we find that indeed lookup_symbol_in_language is called once using language_c, and
once using language_c_plus:
...
(gdb) file a.out
Reading symbols from a.out...
Breakpoint 1, lookup_symbol_in_language (name=0x5555568c2050 "main", \
block=0x0, domain=VAR_DOMAIN, lang=language_c, is_a_field_of_this=0x0) \
at ../../gdb/symtab.c:1905
1905 {
(gdb) file b.out
Load new symbol table from "b.out"? (y or n) y
Reading symbols from b.out...
Breakpoint 1, lookup_symbol_in_language (name=0x5555568c2030 "main", \
block=0x0, domain=VAR_DOMAIN, lang=language_cplus, is_a_field_of_this=0x0) \
at ../../gdb/symtab.c:1905
1905 {
(gdb)
...
It seems like a bad idea to have the previous language play a role
in determining the executable language.
Fix this by using lookup_symbol_in_language in set_initial_language with the
default language c as argument.
Tested on x86_64-linux.
gdb/ChangeLog:
2020-02-28 Tom de Vries <tdevries@suse.de>
* symfile.c (set_initial_language): Use default language for lookup.
2020-02-28 16:14:53 +01:00
|
|
|
|
2020-02-28 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
* symfile.c (set_initial_language): Use default language for lookup.
|
|
|
|
|
|
|
Pass correct die_reader_specs in cutu_reader::init_tu_and_read_dwo_dies
Running anything with the fission.exp board fails since commit
c0ab21c22bb ("Replace init_cutu_and_read_dies with a class").
GDB crashes while reading the DWARF info. cu is NULL in
read_signatured_type:
Thread 1 "gdb" received signal SIGSEGV, Segmentation fault.
0x000055555780663e in read_signatured_type
sig_type=0x6210000c3600) at /home/simark/src/binutils-gdb/gdb/dwarf2/read.c:22782
22782 gdb_assert (cu->die_hash == NULL);
(top-gdb) bt
#0 0x000055555780663e in read_signatured_type (sig_type=0x6210000c3600) at /home/simark/src/binutils-gdb/gdb/dwarf2/read.c:22782
#1 0x00005555578062dd in load_full_type_unit (per_cu=0x6210000c3600) at /home/simark/src/binutils-gdb/gdb/dwarf2/read.c:22758
#2 0x00005555577c5fb7 in queue_and_load_dwo_tu (slot=0x60600007fc00, info=0x6210000c34e0) at /home/simark/src/binutils-gdb/gdb/dwarf2/read.c:12674
#3 0x0000555559934232 in htab_traverse_noresize (htab=0x60b000063670, callback=0x5555577c5e61 <queue_and_load_dwo_tu(void**, void*)>, info=0x6210000c34e0)
at /home/simark/src/binutils-gdb/libiberty/hashtab.c:775
#4 0x00005555577c6252 in queue_and_load_all_dwo_tus (per_cu=0x6210000c34e0) at /home/simark/src/binutils-gdb/gdb/dwarf2/read.c:12701
#5 0x000055555777ebd8 in dw2_do_instantiate_symtab (per_cu=0x6210000c34e0, skip_partial=false) at /home/simark/src/binutils-gdb/gdb/dwarf2/read.c:2371
#6 0x000055555777eea2 in dw2_instantiate_symtab (per_cu=0x6210000c34e0, skip_partial=false) at /home/simark/src/binutils-gdb/gdb/dwarf2/read.c:2395
#7 0x0000555557786ab6 in dw2_lookup_symbol (objfile=0x614000007240, block_index=GLOBAL_BLOCK, name=0x602000025310 "main", domain=VAR_DOMAIN)
at /home/simark/src/binutils-gdb/gdb/dwarf2/read.c:3539
After creating the reader object, the reader.cu field should not be
NULL. By checking the commit previous to the faulty one mentioned
above, I noticed that the cu field is normally set by
init_cu_die_reader, called from read_cutu_die_from_dwo, itself called
from cutu_reader::init_tu_and_read_dwo_dies, itself called from
cutu_reader's constructor.
However, cutu_reader::init_tu_and_read_dwo_dies calls
read_cutu_die_from_dwo, passing a pointer to a local `die_reader_specs`
variable. So it's the `cu` field of that object that gets set.
cutu_reader itself is a `die_reader_specs` (it inherits from it), and
the intention was most likely to pass `this` to read_cutu_die_from_dwo.
This way, the fields of the cutu_reader object, which
read_signatured_type will use, are set.
With this, I am able to use:
make check RUNTESTFLAGS='--target_board=fission'
and it looks much better. There are still some failures to be
investigated, but that's the usual state of the testsuite.
gdb/ChangeLog:
* dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
reader variable, pass `this` to read_cutu_die_from_dwo.
2020-02-28 16:07:46 +01:00
|
|
|
|
2020-02-28 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
|
|
|
|
|
|
reader variable, pass `this` to read_cutu_die_from_dwo.
|
|
|
|
|
|
|
2020-02-28 01:07:01 +01:00
|
|
|
|
2020-02-27 Aaron Merey <amerey@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* source.c (open_source_file): Check for nullptr when computing
|
|
|
|
|
|
srcpath.
|
|
|
|
|
|
|
2020-02-27 22:05:49 +01:00
|
|
|
|
2020-02-27 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
|
|
|
|
|
|
member.
|
|
|
|
|
|
(dwarf2_add_field): Don't update nfields.
|
|
|
|
|
|
(dwarf2_attach_fields_to_type, process_structure_scope): Update.
|
|
|
|
|
|
|
2020-02-27 17:42:17 +01:00
|
|
|
|
2020-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbtypes.c (create_array_type_with_stride): Use std::abs not
|
|
|
|
|
|
abs.
|
|
|
|
|
|
|
2020-02-26 23:41:07 +01:00
|
|
|
|
2020-02-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (struct dwarf2_include_psymtab): New.
|
|
|
|
|
|
(dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
|
|
|
|
|
|
(dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
|
|
|
|
|
|
(dwarf2_psymtab::get_compunit_symtab): Remove null checks for
|
|
|
|
|
|
per_cu_data.
|
|
|
|
|
|
|
2020-02-26 23:41:07 +01:00
|
|
|
|
2020-02-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/index-write.c (psym_index_map): Change type.
|
|
|
|
|
|
(add_address_entry_worker, write_one_signatured_type)
|
|
|
|
|
|
(recursively_count_psymbols, recursively_write_psymbols)
|
|
|
|
|
|
(class debug_names, psyms_seen_size, write_gdbindex)
|
|
|
|
|
|
(write_debug_names): Use partial_symtab, not dwarf2_psymtab.
|
|
|
|
|
|
|
2020-02-26 23:40:49 +01:00
|
|
|
|
2020-02-26 Aaron Merey <amerey@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in: Handle optional debuginfod support.
|
|
|
|
|
|
* NEWS: Update.
|
|
|
|
|
|
* README: Add --with-debuginfod summary.
|
|
|
|
|
|
* config.in: Regenerate.
|
|
|
|
|
|
* configure: Regenerate.
|
|
|
|
|
|
* configure.ac: Handle optional debuginfod support.
|
|
|
|
|
|
* debuginfod-support.c: debuginfod helper functions.
|
|
|
|
|
|
* debuginfod-support.h: Ditto.
|
|
|
|
|
|
* doc/gdb.texinfo: Add --with-debuginfod to configure options
|
|
|
|
|
|
summary.
|
|
|
|
|
|
* dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
|
|
|
|
|
|
when a dwz file cannot be found.
|
|
|
|
|
|
* elfread.c (elf_symfile_read): Query debuginfod servers when a
|
|
|
|
|
|
debuginfo file cannot be found.
|
|
|
|
|
|
* source.c (open_source_file): Query debuginfod servers when a
|
|
|
|
|
|
source file cannot be found.
|
|
|
|
|
|
* top.c (print_gdb_configuration): Include
|
|
|
|
|
|
--{with,without}-debuginfod in the output.
|
|
|
|
|
|
|
2020-02-18 01:08:03 +01:00
|
|
|
|
2020-02-26 Jérémie Galarneau <jeremie.galarneau@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* thread.c (thr_try_catch_cmd): Print thread name.
|
|
|
|
|
|
|
Move more declarations from dwarf2/loc.h to dwarf2/read.h
All these functions have their implementations in dwarf2/read.c, so move
their declarations to dwarf2/read.h. Move the doc to the header, at the
same time.
gdb/ChangeLog:
* dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
dwarf2_fetch_die_type_sect_off): Move to...
* dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
dwarf2_fetch_die_type_sect_off): ... here.
* dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
dwarf2_fetch_die_type_sect_off): Move doc to header file.
2020-02-26 15:35:22 +01:00
|
|
|
|
2020-02-26 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
|
|
|
|
|
|
dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
|
|
|
|
|
|
dwarf2_fetch_die_type_sect_off): Move to...
|
|
|
|
|
|
* dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
|
|
|
|
|
|
dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
|
|
|
|
|
|
dwarf2_fetch_die_type_sect_off): ... here.
|
|
|
|
|
|
* dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
|
|
|
|
|
|
dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
|
|
|
|
|
|
dwarf2_fetch_die_type_sect_off): Move doc to header file.
|
|
|
|
|
|
|
2020-02-26 14:52:00 +01:00
|
|
|
|
2020-02-26 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/25603
|
|
|
|
|
|
* symfile.c (set_initial_language): Exit-early if
|
|
|
|
|
|
language_mode == language_mode_manual.
|
|
|
|
|
|
|
2020-02-26 05:38:26 +01:00
|
|
|
|
2020-02-25 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/loc.h (dwarf2_read_addr_index): Move...
|
|
|
|
|
|
* dwarf2/read.h (dwarf2_read_addr_index): ... here.
|
|
|
|
|
|
* dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
|
|
|
|
|
|
|
gdb/fortran: Support negative array stride in one limited case
This commit adds support for negative Fortran array strides in one
limited case, that is the case of a single element array with a
negative array stride.
The changes in this commit will be required in order for more general
negative array stride support to work correctly, however, right now
other problems in GDB prevent negative array strides from working in
the general case.
The reason negative array strides don't currently work in the general
case is that when dealing with such arrays, the base address for the
objects data is actually the highest addressed element, subsequent
elements are then accessed with a negative offset from that address,
and GDB is not currently happy with this configuration.
The changes here can be summarised as, stop treating signed values as
unsigned, specifically, the array stride, and offsets calculated using
the array stride.
This issue was identified on the mailing list by Sergio:
https://sourceware.org/ml/gdb-patches/2020-01/msg00360.html
The test for this issue is a new one written by me as the copyright
status of the original test is currently unknown.
gdb/ChangeLog:
* gdbtypes.c (create_array_type_with_stride): Handle negative
array strides.
* valarith.c (value_subscripted_rvalue): Likewise.
gdb/testsuite/ChangeLog:
* gdb.fortran/derived-type-striding.exp: Add a new test.
* gdb.fortran/derived-type-striding.f90: Add pointer variable for
new test.
2020-01-18 23:38:29 +01:00
|
|
|
|
2020-02-25 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbtypes.c (create_array_type_with_stride): Handle negative
|
|
|
|
|
|
array strides.
|
|
|
|
|
|
* valarith.c (value_subscripted_rvalue): Likewise.
|
|
|
|
|
|
|
2020-02-25 15:56:58 +01:00
|
|
|
|
2020-02-25 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
|
|
|
|
|
|
|
2020-02-25 06:13:31 +01:00
|
|
|
|
2020-02-25 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* loc.h (dwarf2_get_die_type): Move to...
|
|
|
|
|
|
* read.h (dwarf2_get_die_type): ... here.
|
|
|
|
|
|
* read.c (dwarf2_get_die_type): Move doc to header.
|
|
|
|
|
|
|
2020-02-25 04:36:45 +01:00
|
|
|
|
2020-02-25 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
|
|
|
|
|
|
'gnulib/Makefile.in' to the list.
|
|
|
|
|
|
|
2020-02-24 23:50:57 +01:00
|
|
|
|
2020-02-24 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
|
|
|
|
|
|
Remove.
|
|
|
|
|
|
* dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
|
|
|
|
|
|
XOBNEWVEC.
|
|
|
|
|
|
|
2020-02-24 23:50:57 +01:00
|
|
|
|
2020-02-24 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
|
|
|
|
|
|
New method.
|
|
|
|
|
|
* dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
|
|
|
|
|
|
(dw2_do_instantiate_symtab, dw2_get_file_names)
|
|
|
|
|
|
(build_type_psymtab_dependencies, load_full_type_unit): Update.
|
|
|
|
|
|
|
2020-02-24 23:50:57 +01:00
|
|
|
|
2020-02-24 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (dwarf2_build_psymtabs_hard): Use
|
|
|
|
|
|
make_scoped_restore.
|
|
|
|
|
|
(dwarf2_psymtab::read_symtab): Don't clear
|
|
|
|
|
|
reading_partial_symbols.
|
|
|
|
|
|
|
2020-02-24 15:32:36 +01:00
|
|
|
|
2020-02-24 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/25592
|
|
|
|
|
|
* stack.c (iterate_over_block_locals): Handle LOC_CONST.
|
|
|
|
|
|
|
2020-02-24 12:30:48 +01:00
|
|
|
|
2020-02-24 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
|
|
|
|
|
|
commands layout next/prev/regs.
|
|
|
|
|
|
|
2020-02-22 21:49:56 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
|
|
|
|
|
|
* dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-win.c (_initialize_tui_win): Add usage text.
|
|
|
|
|
|
* tui/tui-stack.c (_initialize_tui_stack): Add usage text.
|
|
|
|
|
|
* tui/tui-regs.c (_initialize_tui_regs): Add usage text.
|
|
|
|
|
|
* tui/tui.c (_initialize_tui): Add usage text.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-win.c (tui_set_focus_command)
|
|
|
|
|
|
(tui_set_win_height_command): Use error_no_arg.
|
|
|
|
|
|
(_initialize_tui_win): Update help text.
|
|
|
|
|
|
(FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-layout.c (extract_display_start_addr): Rewrite.
|
|
|
|
|
|
* tui/tui-disasm.h (struct tui_disasm_window)
|
|
|
|
|
|
<display_start_addr>: Declare.
|
|
|
|
|
|
* tui/tui-source.h (struct tui_source_window)
|
|
|
|
|
|
<display_start_addr>: Declare.
|
|
|
|
|
|
* tui/tui-winsource.h (struct tui_source_window_base)
|
|
|
|
|
|
<show_source_line, display_start_addr>: New methods.
|
|
|
|
|
|
<m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
|
|
|
|
|
|
Rename and move to protected section.
|
|
|
|
|
|
* tui/tui-winsource.c (tui_source_window_base::update_source_window)
|
|
|
|
|
|
(tui_source_window_base::do_erase_source_content): Update.
|
|
|
|
|
|
(tui_source_window_base::show_source_line): Now a method.
|
|
|
|
|
|
(tui_source_window_base::show_source_content)
|
|
|
|
|
|
(tui_source_window_base::tui_source_window_base)
|
|
|
|
|
|
(tui_source_window_base::rerender)
|
|
|
|
|
|
(tui_source_window_base::refill)
|
|
|
|
|
|
(tui_source_window_base::do_scroll_horizontal)
|
|
|
|
|
|
(tui_source_window_base::set_is_exec_point_at)
|
|
|
|
|
|
(tui_source_window_base::update_breakpoint_info)
|
|
|
|
|
|
(tui_source_window_base::update_exec_info): Update.
|
|
|
|
|
|
* tui/tui-source.c (tui_source_window::set_contents)
|
|
|
|
|
|
(tui_source_window::showing_source_p)
|
|
|
|
|
|
(tui_source_window::do_scroll_vertical)
|
|
|
|
|
|
(tui_source_window::location_matches_p)
|
|
|
|
|
|
(tui_source_window::line_is_displayed): Update.
|
|
|
|
|
|
(tui_source_window::display_start_addr): New method.
|
|
|
|
|
|
* tui/tui-disasm.c (tui_disasm_window::set_contents)
|
|
|
|
|
|
(tui_disasm_window::do_scroll_vertical)
|
|
|
|
|
|
(tui_disasm_window::location_matches_p): Update.
|
|
|
|
|
|
(tui_disasm_window::display_start_addr): New method.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Add entry for gdb.register_window_type.
|
|
|
|
|
|
* tui/tui-layout.h (window_factory): New typedef.
|
|
|
|
|
|
(tui_register_window): Declare.
|
|
|
|
|
|
* tui/tui-layout.c (saved_tui_windows): New global.
|
|
|
|
|
|
(tui_apply_current_layout): Use it.
|
|
|
|
|
|
(tui_register_window): New function.
|
|
|
|
|
|
* python/python.c (do_start_initialization): Call
|
|
|
|
|
|
gdbpy_initialize_tui.
|
|
|
|
|
|
(python_GdbMethods): Add "register_window_type" function.
|
|
|
|
|
|
* python/python-internal.h (gdbpy_register_tui_window)
|
|
|
|
|
|
(gdbpy_initialize_tui): Declare.
|
|
|
|
|
|
* python/py-tui.c: New file.
|
|
|
|
|
|
* Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-io.c (do_tui_putc): Don't omit annotations.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
|
|
|
|
|
|
* tui/tui-data.h (tui_set_win_with_focus): Don't declare.
|
|
|
|
|
|
* tui/tui-data.c (tui_set_win_with_focus): Remove.
|
|
|
|
|
|
(tui_set_win_focus_to): Move from tui-win.c.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-layout.c (make_standard_window, get_locator_window): New
|
|
|
|
|
|
functions.
|
|
|
|
|
|
(known_window_types): New global.
|
|
|
|
|
|
(tui_get_window_by_name): Reimplement.
|
|
|
|
|
|
(initialize_known_windows): New function.
|
|
|
|
|
|
(validate_window_name): Rewrite.
|
|
|
|
|
|
(_initialize_tui_layout): Call initialize_known_windows.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
|
|
|
|
|
|
Remove constants.
|
|
|
|
|
|
* tui/tui-winsource.h (struct tui_source_window_base)
|
|
|
|
|
|
<tui_source_window_base>: Remove parameter.
|
|
|
|
|
|
* tui/tui-winsource.c
|
|
|
|
|
|
(tui_source_window_base::tui_source_window_base): Remove
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(tui_source_window_base::refill): Update.
|
|
|
|
|
|
* tui/tui-stack.h (struct tui_locator_window)
|
|
|
|
|
|
<tui_locator_window>: Update.
|
|
|
|
|
|
* tui/tui-source.h (struct tui_source_window) <tui_source_window>:
|
|
|
|
|
|
Default the constructor.
|
|
|
|
|
|
* tui/tui-regs.h (struct tui_data_item_window)
|
|
|
|
|
|
<tui_data_item_window>: Default the constructor.
|
|
|
|
|
|
(struct tui_data_window) <tui_data_window>: Likewise.
|
|
|
|
|
|
* tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
|
|
|
|
|
|
Default the constructor.
|
|
|
|
|
|
* tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
|
|
|
|
|
|
Default the constructor.
|
|
|
|
|
|
<type>: Remove.
|
|
|
|
|
|
(struct tui_win_info) <tui_win_info>: Default the constructor.
|
|
|
|
|
|
* tui/tui-data.c (tui_win_info::tui_win_info): Remove.
|
|
|
|
|
|
* tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
|
|
|
|
|
|
Default the constructor.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
|
|
|
|
|
|
* tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
|
|
|
|
|
|
* tui/tui-win.c (tui_resize_all): Don't call
|
|
|
|
|
|
tui_delete_invisible_windows.
|
|
|
|
|
|
* tui/tui-layout.c (tui_apply_current_layout): Delete windows when
|
|
|
|
|
|
done.
|
|
|
|
|
|
(tui_set_layout): Update.
|
|
|
|
|
|
(tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
|
|
|
|
|
|
* tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
|
|
|
|
|
|
* tui/tui-data.c (tui_delete_invisible_windows): Remove.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
|
|
|
|
|
|
correctly.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-winsource.h (struct tui_source_window_iterator)
|
|
|
|
|
|
<inner_iterator>: New etytypedef.
|
|
|
|
|
|
<tui_source_window_iterator>: Take "end" parameter.
|
|
|
|
|
|
<tui_source_window_iterator>: Take iterator.
|
|
|
|
|
|
<operator*, advance>: Update.
|
|
|
|
|
|
<m_iter>: Change type.
|
|
|
|
|
|
<m_end>: New field.
|
|
|
|
|
|
(struct tui_source_windows) <begin, end>: Update.
|
|
|
|
|
|
* tui/tui-layout.c (tui_windows): New global.
|
|
|
|
|
|
(tui_apply_current_layout): Clear tui_windows.
|
|
|
|
|
|
(tui_layout_window::apply): Update tui_windows.
|
|
|
|
|
|
* tui/tui-data.h (tui_windows): Declare.
|
|
|
|
|
|
(all_tui_windows): Now inline function.
|
|
|
|
|
|
(class tui_window_iterator, struct all_tui_windows): Remove.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR tui/17850:
|
|
|
|
|
|
* tui/tui-win.c (tui_gen_win_info::max_width): New method.
|
|
|
|
|
|
* tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
|
|
|
|
|
|
"height" argument.
|
|
|
|
|
|
(class tui_layout_window) <get_sizes>: Likewise.
|
|
|
|
|
|
(class tui_layout_split) <tui_layout_split>: Add "vertical"
|
|
|
|
|
|
argument.
|
|
|
|
|
|
<get_sizes>: Add "height" argument.
|
|
|
|
|
|
<m_vertical>: New field.
|
|
|
|
|
|
* tui/tui-layout.c (tui_layout_split::clone): Update.
|
|
|
|
|
|
(tui_layout_split::get_sizes): Add "height" argument.
|
|
|
|
|
|
(tui_layout_split::adjust_size, tui_layout_split::apply): Update.
|
|
|
|
|
|
(tui_new_layout_command): Parse "-horizontal".
|
|
|
|
|
|
(_initialize_tui_layout): Update help string.
|
|
|
|
|
|
(tui_layout_split::specification): Add "-horizontal" when needed.
|
|
|
|
|
|
* tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
|
|
|
|
|
|
argument.
|
|
|
|
|
|
* tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
|
|
|
|
|
|
New methods.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-layout.h (enum tui_adjust_result): New.
|
|
|
|
|
|
(class tui_layout_base) <adjust_size>: Return tui_adjust_result.
|
|
|
|
|
|
(class tui_layout_window) <adjust_size>: Return
|
|
|
|
|
|
tui_adjust_result. Rewrite.
|
|
|
|
|
|
(class tui_layout_split) <adjust_size>: Return tui_adjust_result.
|
|
|
|
|
|
* tui/tui-layout.c (tui_layout_split::adjust_size): Update.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-layout.h (class tui_layout_split) <add_split>: Change
|
|
|
|
|
|
parameter and return types.
|
|
|
|
|
|
(class tui_layout_base) <specification>: Add "depth".
|
|
|
|
|
|
(class tui_layout_window) <specification>: Add "depth".
|
|
|
|
|
|
(class tui_layout_split) <specification>: Add "depth".
|
|
|
|
|
|
* tui/tui-layout.c (tui_layout_split::add_split): Change parameter
|
|
|
|
|
|
and return types.
|
|
|
|
|
|
(tui_new_layout_command): Parse sub-layouts.
|
|
|
|
|
|
(_initialize_tui_layout): Update help string.
|
|
|
|
|
|
(tui_layout_window::specification): Add "depth".
|
|
|
|
|
|
(add_layout_command): Update.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Add "tui new-layout" item.
|
|
|
|
|
|
* tui/tui-layout.c (add_layout_command): Return cmd_list_element.
|
|
|
|
|
|
Add new-layout command to help text.
|
|
|
|
|
|
(validate_window_name): New function.
|
|
|
|
|
|
(tui_new_layout_command): New function.
|
|
|
|
|
|
(_initialize_tui_layout): Register "new-layout".
|
|
|
|
|
|
(tui_layout_window::specification): New method.
|
|
|
|
|
|
(tui_layout_window::specification): New method.
|
|
|
|
|
|
* tui/tui-layout.h (class tui_layout_base) <specification>: New
|
|
|
|
|
|
method.
|
|
|
|
|
|
(class tui_layout_window) <specification>: New method.
|
|
|
|
|
|
(class tui_layout_split) <specification>: New method.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui.c (tui_enable): Call tui_set_initial_layout.
|
|
|
|
|
|
* tui/tui-win.c (window_name_completer): Update comment.
|
|
|
|
|
|
* tui/tui-layout.h (class tui_layout_base) <replace_window>:
|
|
|
|
|
|
Declare method.
|
|
|
|
|
|
(class tui_layout_window) <replace_window>: Likewise.
|
|
|
|
|
|
(class tui_layout_split) <replace_window>: Likewise.
|
|
|
|
|
|
(tui_set_layout): Don't declare.
|
|
|
|
|
|
(tui_set_initial_layout): Declare function.
|
|
|
|
|
|
* tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
|
|
|
|
|
|
(asm_regs_layout): New globals.
|
|
|
|
|
|
(tui_current_layout, show_layout): Remove.
|
|
|
|
|
|
(tui_set_layout, tui_add_win_to_layout): Rewrite.
|
|
|
|
|
|
(find_layout, tui_apply_layout): New function.
|
|
|
|
|
|
(layout_completer): Remove.
|
|
|
|
|
|
(tui_next_layout): Reimplement.
|
|
|
|
|
|
(tui_next_layout_command): New function.
|
|
|
|
|
|
(tui_set_initial_layout, tui_prev_layout_command): New functions.
|
|
|
|
|
|
(tui_regs_layout): Reimplement.
|
|
|
|
|
|
(tui_regs_layout_command): New function.
|
|
|
|
|
|
(extract_display_start_addr): Rewrite.
|
|
|
|
|
|
(next_layout, prev_layout): Remove.
|
|
|
|
|
|
(tui_layout_window::replace_window): New method.
|
|
|
|
|
|
(tui_layout_split::replace_window): New method.
|
|
|
|
|
|
(destroy_layout): New function.
|
|
|
|
|
|
(layout_list): New global.
|
|
|
|
|
|
(add_layout_command): New function.
|
|
|
|
|
|
(initialize_layouts): Update.
|
|
|
|
|
|
(tui_layout_command): New function.
|
|
|
|
|
|
(_initialize_tui_layout): Install "layout" commands.
|
|
|
|
|
|
* tui/tui-data.h (enum tui_layout_type): Remove.
|
|
|
|
|
|
(tui_current_layout): Don't declare.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-regs.c (tui_reg_layout): Remove.
|
|
|
|
|
|
(tui_reg_command): Use tui_regs_layout.
|
|
|
|
|
|
* tui/tui-layout.h (tui_reg_command): Declare.
|
|
|
|
|
|
* tui/tui-layout.c (tui_reg_command): New function.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui.c (tui_rl_delete_other_windows): Call
|
|
|
|
|
|
tui_remove_some_windows.
|
|
|
|
|
|
* tui/tui-layout.h (class tui_layout_base) <remove_windows>:
|
|
|
|
|
|
Declare method.
|
|
|
|
|
|
(class tui_layout_window) <remove_windows>: New method.
|
|
|
|
|
|
(class tui_layout_split) <remove_windows>: Declare.
|
|
|
|
|
|
(tui_remove_some_windows): Declare.
|
|
|
|
|
|
* tui/tui-layout.c (tui_remove_some_windows): New function.
|
|
|
|
|
|
(tui_layout_split::remove_windows): New method.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
|
|
|
|
|
|
* tui/tui-layout.h (tui_next_layout): Declare.
|
|
|
|
|
|
* tui/tui-layout.c (tui_next_layout): New function.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-regs.c (tui_data_window::display_registers_from): Use
|
|
|
|
|
|
correct coordinates.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-layout.h (tui_add_win_to_layout): Add comment.
|
|
|
|
|
|
* tui/tui-layout.c (tui_add_win_to_layout): Add assert. Remove
|
|
|
|
|
|
DATA_WIN case.
|
|
|
|
|
|
|
2020-02-22 19:48:26 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-disasm.c (tui_get_low_disassembly_address): Use
|
|
|
|
|
|
TUI_DISASM_WIN, not tui_win_list.
|
|
|
|
|
|
|
2020-02-22 18:02:42 +01:00
|
|
|
|
2020-02-22 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (generic_val_print_enum_1)
|
|
|
|
|
|
(val_print_type_code_flags): Style member names.
|
|
|
|
|
|
* rust-lang.c (val_print_struct, rust_print_enum)
|
|
|
|
|
|
(rust_print_struct_def, rust_internal_print_type): Style member
|
|
|
|
|
|
names.
|
|
|
|
|
|
* p-valprint.c (pascal_object_print_value_fields): Style member
|
|
|
|
|
|
names. Only call fprintf_symbol_filtered for static members.
|
|
|
|
|
|
* m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
|
|
|
|
|
|
* f-valprint.c (f_val_print): Style member names.
|
|
|
|
|
|
* f-typeprint.c (f_type_print_base): Style member names.
|
|
|
|
|
|
* cp-valprint.c (cp_print_value_fields): Style member names. Only
|
|
|
|
|
|
call fprintf_symbol_filtered for static members.
|
|
|
|
|
|
(cp_print_class_member): Style member names.
|
|
|
|
|
|
* c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
|
|
|
|
|
|
member names.
|
|
|
|
|
|
* ada-valprint.c (ada_print_scalar): Style enum names.
|
|
|
|
|
|
(ada_val_print_enum): Likewise.
|
|
|
|
|
|
* ada-typeprint.c (print_enum_type): Style enum names.
|
|
|
|
|
|
|
2020-02-21 22:44:41 +01:00
|
|
|
|
2020-02-21 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* psympriv.h (struct partial_symtab): Update comment.
|
|
|
|
|
|
|
2020-02-21 16:41:11 +01:00
|
|
|
|
2020-02-21 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
|
|
|
|
|
|
type is CORE_ADDR.
|
|
|
|
|
|
|
2020-02-21 16:36:48 +01:00
|
|
|
|
2020-02-21 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/25534
|
|
|
|
|
|
* psymtab.c (partial_symtab::read_dependencies): Don't read dependency
|
|
|
|
|
|
if dependencies[i]->user != NULL.
|
|
|
|
|
|
|
2020-02-21 16:19:21 +01:00
|
|
|
|
2020-02-21 Ali Tamur <tamur@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (dwarf2_name): Add null check.
|
|
|
|
|
|
|
2020-02-21 02:22:09 +01:00
|
|
|
|
2020-02-20 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
|
|
|
|
|
|
">=", in binary search.
|
|
|
|
|
|
(dwarf2_find_containing_comp_unit): New overload.
|
|
|
|
|
|
(run_test): New self-test.
|
|
|
|
|
|
(_initialize_dwarf2_read): Register new test.
|
|
|
|
|
|
|
RISC-V: Support the ISA-dependent CSR checking.
According to the riscv privilege spec, some CSR are only valid when rv32 or
the specific extension is set. We extend the DECLARE_CSR and DECLARE_CSR_ALIAS
to record more informaton we need, and then check whether the CSR is valid
according to these information. We report warning message when the CSR is
invalid, so we have a choice between error and warning by --fatal-warnings
option. Also, a --no-warn/-W option is used to turn the warnings off, if
people don't want the warnings.
gas/
* config/tc-riscv.c (enum riscv_csr_class): New enum. Used to decide
whether or not this CSR is legal in the current ISA string.
(struct riscv_csr_extra): New structure to hold all extra information
of CSR.
(riscv_init_csr_hash): New function. According to the DECLARE_CSR and
DECLARE_CSR_ALIAS, insert CSR extra information into csr_extra_hash.
Call hash_reg_name to insert CSR address into reg_names_hash.
(md_begin): Call riscv_init_csr_hashes for each DECLARE_CSR.
(reg_csr_lookup_internal, riscv_csr_class_check): New functions.
Decide whether the CSR is valid according to the csr_extra_hash.
(init_opcode_hash): Update 'if (hash_error != NULL)' as hash_error is
not a boolean. This is same as riscv_init_csr_hash, so keep the
consistent usage.
* testsuite/gas/riscv/csr-dw-regnums.d: Add -march=rv32if option.
* testsuite/gas/riscv/priv-reg.d: Add f-ext by -march option.
* testsuite/gas/riscv/priv-reg-fail-fext.d: New testcase. The source
file is `priv-reg.s`, and the ISA is rv32i without f-ext, so the
f-ext CSR are not allowed.
* testsuite/gas/riscv/priv-reg-fail-fext.l: Likewise.
* testsuite/gas/riscv/priv-reg-fail-rv32-only.d: New testcase. The
source file is `priv-reg.s`, and the ISA is rv64if, so the
rv32-only CSR are not allowed.
* testsuite/gas/riscv/priv-reg-fail-rv32-only.l: Likewise.
include/
* opcode/riscv-opc.h: Extend DECLARE_CSR and DECLARE_CSR_ALIAS to
record riscv_csr_class.
opcodes/
* riscv-dis.c (print_insn_args): Updated since the DECLARE_CSR is changed.
gdb/
* riscv-tdep.c: Updated since the DECLARE_CSR is changed.
* riscv-tdep.h: Likewise.
* features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
rv32-only CSR.
* features/riscv/64bit-csr.xml: Regernated.
binutils/
* dwarf.c: Updated since the DECLARE_CSR is changed.
2020-02-12 11:18:49 +01:00
|
|
|
|
2020-02-20 Nelson Chu <nelson.chu@sifive.com>
|
|
|
|
|
|
|
|
|
|
|
|
* riscv-tdep.c: Updated since the DECLARE_CSR is changed.
|
|
|
|
|
|
* riscv-tdep.h: Likewise.
|
|
|
|
|
|
* features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
|
|
|
|
|
|
rv32-only CSR.
|
|
|
|
|
|
* features/riscv/64bit-csr.xml: Regenerated.
|
|
|
|
|
|
|
Make '{putchar,fputc}_unfiltered' use 'fputs_unfiltered'
There is currently a regression when using
'{putchar,fputc}_unfiltered' with 'puts_unfiltered' which was
introduced by one of the commits that reworked the unfiltered print
code.
The regression makes it impossible to use '{putchar,fputc}_unfiltered'
with 'puts_unfiltered', because the former writes directly to the
ui_file stream using 'stream->write', while the latter uses a buffered
mechanism (see 'wrap_buffer') and delays the printing.
If you do a quick & dirty hack on e.g. top.c:show_gdb_datadir:
@@ -2088,6 +2088,13 @@ static void
show_gdb_datadir (struct ui_file *file, int from_tty,
struct cmd_list_element *c, const char *value)
{
+ putchar_unfiltered ('\n');
+ puts_unfiltered ("TEST");
+ putchar_unfiltered ('>');
+ puts_unfiltered ("PUTS");
+ putchar_unfiltered ('\n');
rebuild GDB and invoke the "show data-directory" command, you will
see:
(gdb) show data-directory
>
TESTPUTSGDB's data directory is "/usr/local/share/gdb".
Note how the '>' was printed before the output, and "TEST" and "PUTS"
were printed together.
My first attempt to fix this was to always call 'flush_wrap_buffer' at
the end of 'fputs_maybe_filtered', since it seemed to me that the
function should always print what was requested. But I wasn't sure
this was the right thing to do, so I talked to Tom on IRC and he gave
me another, simpler idea: make '{putchar,fputc}_unfiltered' call into
the already existing 'fputs_unfiltered' function.
This patch implements the idea. I regtested it on the Buildbot, and
no regressions were detected.
gdb/ChangeLog:
2020-02-20 Sergio Durigan Junior <sergiodj@redhat.com>
Tom Tromey <tom@tromey.com>
* utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
of 'fputc_unfiltered'.
(putchar_unfiltered): Call 'fputc_unfiltered'.
(fputc_unfiltered): Call 'fputs_unfiltered'.
2020-02-19 22:40:48 +01:00
|
|
|
|
2020-02-20 Sergio Durigan Junior <sergiodj@redhat.com>
|
|
|
|
|
|
Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
|
|
|
|
|
|
of 'fputc_unfiltered'.
|
|
|
|
|
|
(putchar_unfiltered): Call 'fputc_unfiltered'.
|
|
|
|
|
|
(fputc_unfiltered): Call 'fputs_unfiltered'.
|
|
|
|
|
|
|
gdb: Allow more control over where to find python libraries
The motivation behind this commit is to make it easier to bundle the
Python *.py library files with GDB when statically linking GDB against
libpython. The Python files will be manually added into the GDB
installation tree, and GDB should be able to find them at run-time.
The installation tree will look like this:
.
|-- bin/
|-- include/
|-- lib/
| `-- python3.8/
`-- share/
The benefit here is that the entire installation tree can be bundled
into a single archive and copied to another machine with a different
version of Python installed, and GDB will still work, including its
Python support.
In use the new configure options would be used something like this,
first build and install a static Python library:
mkdir python
cd python
# Clone or download Python into a src/ directory.
mkdir build
export PYTHON_INSTALL_PATH=$PWD/install
cd build
../src/configure --disable-shared --prefix=$PYTHON_INSTALL_PATH
make
make install
Now build and install GDB:
mkdir binutils-gdb
cd binutils-gdb
# Clone or download GDB into a src/ directory.
mkdir build
export GDB_INSTALL_DIR=$PWD/install
cd build
../src/configure \
--prefix=$GDB_INSTALL_DIR \
--with-python=$PYTHON_INSTALL_PATH/bin/python3 \
--with-python-libdir=$GDB_INSTALL_DIR/lib
make all-gdb
make install-gdb
Finally, copy the Python libraries into the GDB install:
cp -r $PYTHON_INSTALL_DIR/lib/python3.8/ $GDB_INSTALL_DIR/lib
After this the Python src, build, and install directories are no
longer needed and can be deleted.
If the new --with-python-libdir option is not used then the existing
behaviour is left unchanged, GDB will look for the Python libraries in
the lib/ directory within the python path. The concatenation of the
python prefix and the string 'lib/' is now done at configure time,
rather than at run time in GDB as it was previous, however, this was
never something that the user had dynamic control over, so there's no
loss of functionality.
gdb/ChangeLog:
* config.in: Regenerate.
* configure: Regenerate.
* configure.ac: Add --with-python-libdir option.
* main.c: Use WITH_PYTHON_LIBDIR.
2020-01-17 01:10:22 +01:00
|
|
|
|
2020-02-20 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* config.in: Regenerate.
|
|
|
|
|
|
* configure: Regenerate.
|
|
|
|
|
|
* configure.ac: Add --with-python-libdir option.
|
|
|
|
|
|
* main.c: Use WITH_PYTHON_LIBDIR.
|
|
|
|
|
|
|
2020-02-20 01:16:51 +01:00
|
|
|
|
2020-02-19 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* symtab.c (general_symbol_info::compute_and_set_names): Use
|
|
|
|
|
|
obstack_strndup. Simplify call to symbol_set_demangled_name.
|
|
|
|
|
|
|
2020-02-19 22:04:52 +01:00
|
|
|
|
2020-02-19 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (allocate_signatured_type_table,
|
|
|
|
|
|
allocate_dwo_unit_table, allocate_type_unit_groups_table,
|
|
|
|
|
|
allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
|
|
|
|
|
|
Remove objfile parameter, update all callers.
|
|
|
|
|
|
|
2020-02-19 21:54:59 +01:00
|
|
|
|
2020-02-19 Doug Evans <dje@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR rust/25535
|
|
|
|
|
|
* rust-lang.c (rust_print_enum): Apply embedded_offset to
|
|
|
|
|
|
rust_enum_variant calculation.
|
|
|
|
|
|
|
2020-02-19 20:18:09 +01:00
|
|
|
|
2020-02-19 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
|
|
|
|
|
|
|
2020-02-19 19:06:33 +01:00
|
|
|
|
2020-02-19 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ada-lang.c (cache_symbol): Use obstack_strdup.
|
|
|
|
|
|
|
Merge changes from GCC for the config/ directory
GCC's config/ChangeLog since the last time this merge was done
(in the binutils-gdb commit 0b4d000cc4e8e77c823) is included at the
end of this commit message.
It is worth noting that the binutils-gdb commit 301a9420d947da1458
added the file config/debuginfod.m4 which is not present in GCC's
config/ directory. This file is preserved, unmodified, after this
commit.
In order to regenerate all of the configure files, I configured with
--enable-maintainer-mode, and built the 'all' target. I then did the
same thing on a source tree without this patch, and only committed
those files that changed when this patch was added.
GCC's config/ChangeLog entries:
2020-02-12 Sandra Loosemore <sandra@codesourcery.com>
PR libstdc++/79193
PR libstdc++/88999
* no-executables.m4: Use a non-empty program to test for linker
support.
2020-02-01 Andrew Burgess <andrew.burgess@embecosm.com>
* lib-link.m4 (AC_LIB_LINKFLAGS_BODY): Update shell syntax.
2020-01-27 Andrew Burgess <andrew.burgess@embecosm.com>
* lib-link.m4 (AC_LIB_LINKFLAGS_BODY): Add new
--with-libXXX-type=... option. Use this to guide the selection of
either a shared library or a static library.
2020-01-24 Maciej W. Rozycki <macro@wdc.com>
* toolexeclibdir.m4: New file.
2019-09-10 Christophe Lyon <christophe.lyon@st.com>
* futex.m4: Handle *-uclinux*.
* tls.m4 (GCC_CHECK_TLS): Likewise.
2019-09-06 Florian Weimer <fweimer@redhat.com>
* futex.m4 (GCC_LINUX_FUTEX): Include <unistd.h> for the syscall
function.
2019-07-08 Richard Sandiford <richard.sandiford@arm.com>
* bootstrap-Og.mk: New file.
2019-06-25 Kwok Cheung Yeung <kcy@codesourcery.com>
Andrew Stubbs <ams@codesourcery.com>
* gthr.m4 (GCC_AC_THREAD_HEADER): Add case for gcn.
2019-05-30 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
* ax_count_cpus.m4: New file.
2019-05-02 Richard Biener <rguenther@suse.de>
PR bootstrap/85574
* bootstrap-lto.mk (extra-compare): Set to gcc/lto1$(exeext).
2019-04-16 Martin Liska <mliska@suse.cz>
* bootstrap-lto-lean.mk: Filter out -flto in STAGEtrain_CFLAGS.
2019-04-09 Martin Liska <mliska@suse.cz>
* bootstrap-lto-lean.mk: New file.
2019-03-02 Johannes Pfau <johannespfau@gmail.com>
* mh-mingw: Also set __USE_MINGW_ACCESS flag for C++ code.
2018-10-31 Joseph Myers <joseph@codesourcery.com>
PR bootstrap/82856
* math.m4, tls.m4: Use AC_LANG_SOURCE.
Merge from binutils-gdb:
2018-06-19 Simon Marchi <simon.marchi@ericsson.com>
* override.m4 (_GCC_AUTOCONF_VERSION): Bump from 2.64 to 2.69.
config/ChangeLog:
* ax_count_cpus.m4: New file, backported from GCC.
* bootstrap-Og.mk: New file, backported from GCC.
* bootstrap-lto-lean.mk: New file, backported from GCC.
* bootstrap-lto.mk: Changes backported from GCC.
* futex.m4: Changes backported from GCC.
* gthr.m4: Changes backported from GCC.
* lib-link.m4: Changes backported from GCC.
* mh-mingw: Changes backported from GCC.
* no-executables.m4: Changes backported from GCC.
* tls.m4: Changes backported from GCC.
* toolexeclibdir.m4: New file, backported from GCC.
binutils/ChangeLog:
* configure: Regenerate.
gdb/ChangeLog:
* configure: Regenerate.
gdbserver/ChangeLog:
* configure: Regenerate.
gdbsupport/ChangeLog:
* configure: Regenerate.
intl/ChangeLog:
* configure: Regenerate.
libiberty/ChangeLog:
* configure: Regenerate.
zlib/ChangeLog.bin-gdb:
* configure: Regenerate.
2020-02-05 12:50:07 +01:00
|
|
|
|
2020-02-19 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* configure: Regenerate.
|
|
|
|
|
|
|
2020-02-19 15:50:21 +01:00
|
|
|
|
2020-02-19 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* python/python.c (do_start_initialization): Use XNEWVEC. Remove
|
|
|
|
|
|
NULL check.
|
|
|
|
|
|
|
2020-02-19 02:24:37 +01:00
|
|
|
|
2020-02-19 Maciej W. Rozycki <macro@wdc.com>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Mention RISC-V GNU/Linux GDBserver support.
|
|
|
|
|
|
|
gdb/riscv: Update API for looking up target descriptions
In preparation for adding the RISC-V gdbserver, this commit
restructures the API for looking up target descriptions.
The current API is riscv_create_target_description, which creates a
target description from a riscv_gdbarch_features, but also caches the
created target descriptions so that for a given features object we
always get back the same target description object. This is important
for GDB due to the way gdbarch objects are reused.
As the same target description is always returned to GDB, and can be
returned multiple times, it is returned as a const, however, the
current cache actually stores a non-const target description. This is
improved in this patch so that the cache holds a const target
description.
For gdbsever, this caching of the target descriptions is not needed,
the gdbserver looks up one target description to describe the target
it is actually running on and that is it. Further the gdbserver
actually needs to modify the target description that is looked up, so
for the gdbsever, returning a const target description is not
acceptable.
This commit aims to address this by creating two parallel target
description APIs, on is the old riscv_create_target_description,
however, this no longer performs any caching, and just creates a new
target description, and returns it as non-const.
The second API is riscv_lookup_target_description, this one performs
the caching, and calls riscv_create_target_description to create a
target description when needed.
In order to make sure the correct API is used in the correct place I
have guarded the code using the GDBSERVER define. For GDB the
riscv_create_target_description is static, and not generally usable
throughout GDB, only the lookup API is global. In gdbserver, the
lookup functions, and the cache are not defined or created at all,
only the riscv_create_target_description API is available.
There should be no user visible changes after this commit.
gdb/ChangeLog:
* arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
if GDBSERVER is not defined.
(riscv_tdesc_cache): Likewise, also store const target_desc.
(STATIC_IN_GDB): Define.
(riscv_create_target_description): Update declaration with
STATIC_IN_GDB.
(riscv_lookup_target_description): New function, only define if
GDBSERVER is not defined.
* arch/riscv.h (riscv_create_target_description): Declare only
when GDBSERVER is defined.
(riscv_lookup_target_description): New declaration when GDBSERVER
is not defined.
* nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
(riscv_linux_read_features): ...this, and return
riscv_gdbarch_features instead of target_desc.
* nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
(riscv_linux_read_description): Rename to...
(riscv_linux_read_features): ...this.
* riscv-linux-nat.c (riscv_linux_nat_target::read_description):
Update to use riscv_gdbarch_features and
riscv_lookup_target_description.
* riscv-tdep.c (riscv_find_default_target_description): Use
riscv_lookup_target_description instead of
riscv_create_target_description.
2020-02-19 02:24:37 +01:00
|
|
|
|
2020-02-19 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
|
|
|
|
|
|
if GDBSERVER is not defined.
|
|
|
|
|
|
(riscv_tdesc_cache): Likewise, also store const target_desc.
|
|
|
|
|
|
(STATIC_IN_GDB): Define.
|
|
|
|
|
|
(riscv_create_target_description): Update declaration with
|
|
|
|
|
|
STATIC_IN_GDB.
|
|
|
|
|
|
(riscv_lookup_target_description): New function, only define if
|
|
|
|
|
|
GDBSERVER is not defined.
|
|
|
|
|
|
* arch/riscv.h (riscv_create_target_description): Declare only
|
|
|
|
|
|
when GDBSERVER is defined.
|
|
|
|
|
|
(riscv_lookup_target_description): New declaration when GDBSERVER
|
|
|
|
|
|
is not defined.
|
|
|
|
|
|
* nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
|
|
|
|
|
|
(riscv_linux_read_features): ...this, and return
|
|
|
|
|
|
riscv_gdbarch_features instead of target_desc.
|
|
|
|
|
|
* nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
|
|
|
|
|
|
(riscv_linux_read_description): Rename to...
|
|
|
|
|
|
(riscv_linux_read_features): ...this.
|
|
|
|
|
|
* riscv-linux-nat.c (riscv_linux_nat_target::read_description):
|
|
|
|
|
|
Update to use riscv_gdbarch_features and
|
|
|
|
|
|
riscv_lookup_target_description.
|
|
|
|
|
|
* riscv-tdep.c (riscv_find_default_target_description): Use
|
|
|
|
|
|
riscv_lookup_target_description instead of
|
|
|
|
|
|
riscv_create_target_description.
|
|
|
|
|
|
|
2020-02-18 23:30:51 +01:00
|
|
|
|
2020-02-18 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (generic_val_print_enum_1): When printing a flag
|
|
|
|
|
|
enum with value 0 and there is no enumerator with value 0, print
|
|
|
|
|
|
just "0" instead of "(unknown: 0x0)".
|
|
|
|
|
|
|
2020-02-18 23:30:21 +01:00
|
|
|
|
2020-02-18 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* valprint.c (generic_val_print_enum_1): Print unknown part of
|
|
|
|
|
|
flag enum in hex.
|
|
|
|
|
|
|
gdb: allow duplicate enumerators in flag enums
I have come across some uses cases where it would be desirable to treat
an enum that has duplicate values as a "flag enum". For example, this
one here [1]:
enum membarrier_cmd {
MEMBARRIER_CMD_QUERY = 0,
MEMBARRIER_CMD_GLOBAL = (1 << 0),
MEMBARRIER_CMD_GLOBAL_EXPEDITED = (1 << 1),
MEMBARRIER_CMD_REGISTER_GLOBAL_EXPEDITED = (1 << 2),
MEMBARRIER_CMD_PRIVATE_EXPEDITED = (1 << 3),
MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED = (1 << 4),
MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE = (1 << 5),
MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_SYNC_CORE = (1 << 6),
/* Alias for header backward compatibility. */
MEMBARRIER_CMD_SHARED = MEMBARRIER_CMD_GLOBAL,
};
The last enumerator is kept for backwards compatibility. Without this
patch, this enumeration wouldn't be considered a flag enum, because two
enumerators collide. With this patch, it would be considered a flag
enum, and the value 3 would be printed as:
MEMBARRIER_CMD_GLOBAL | MEMBARRIER_CMD_GLOBAL_EXPEDITED
Although if people prefer, we could display both MEMBARRIER_CMD_GLOBAL
and MEMBARRIER_CMD_SHARED in the result. It wouldn't be wrong, and
could perhaps be useful in case a bit may have multiple meanings
(depending on some other bit value).
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/membarrier.h?id=0bf999f9c5e74c7ecf9dafb527146601e5c848b9#n125
gdb/ChangeLog:
* dwarf2/read.c (update_enumeration_type_from_children): Allow
flag enums to contain duplicate enumerators.
* valprint.c (generic_val_print_enum_1): Update comment.
gdb/testsuite/ChangeLog:
* gdb.base/printcmds.c (enum flag_enum): Add FE_TWO_LEGACY
enumerator.
2020-02-18 23:29:23 +01:00
|
|
|
|
2020-02-18 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (update_enumeration_type_from_children): Allow
|
|
|
|
|
|
flag enums to contain duplicate enumerators.
|
|
|
|
|
|
* valprint.c (generic_val_print_enum_1): Update comment.
|
|
|
|
|
|
|
2020-02-18 23:28:23 +01:00
|
|
|
|
2020-02-18 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c: Include "count-one-bits.h".
|
|
|
|
|
|
(update_enumeration_type_from_children): If an enumerator has
|
|
|
|
|
|
multiple bits set, don't treat the enumeration as a "flag enum".
|
|
|
|
|
|
* valprint.c (generic_val_print_enum_1): Assert that enumerators
|
|
|
|
|
|
of flag enums have 0 or 1 bit set.
|
|
|
|
|
|
|
2020-02-16 21:43:33 +01:00
|
|
|
|
2020-02-18 Bernd Edlinger <bernd.edlinger@hotmail.de>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
|
|
|
|
|
|
conversion.
|
|
|
|
|
|
* amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
|
2020-02-18 20:37:18 +01:00
|
|
|
|
2020-02-18 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
|
|
|
|
|
|
|
2020-02-14 22:45:40 +01:00
|
|
|
|
2020-02-14 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
|
|
|
|
|
|
displaced_step_closure_up.
|
|
|
|
|
|
* aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
(struct displaced_step_closure_up):
|
|
|
|
|
|
* amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
|
|
|
|
|
|
Likewise.
|
|
|
|
|
|
* gdbarch.sh (displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* gdbarch.c, gdbarch.h: Re-generate.
|
|
|
|
|
|
* i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
|
|
|
|
|
|
displaced_step_closure_up.
|
|
|
|
|
|
* i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* infrun.h (displaced_step_closure_up): New type alias.
|
|
|
|
|
|
(struct displaced_step_inferior_state) <step_closure>: Change
|
|
|
|
|
|
type to displaced_step_closure_up.
|
|
|
|
|
|
* rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
|
|
|
|
|
|
displaced_step_closure_up.
|
|
|
|
|
|
* s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
|
2020-02-14 22:16:23 +01:00
|
|
|
|
2020-02-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* minidebug.c (gnu_debug_key): New global.
|
|
|
|
|
|
(find_separate_debug_file_in_section): Use it.
|
|
|
|
|
|
|
2020-02-14 21:29:08 +01:00
|
|
|
|
2020-02-14 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbarch.sh (displaced_step_copy_insn): Change return type to an
|
|
|
|
|
|
std::unique_ptr.
|
|
|
|
|
|
* gdbarch.c: Re-generate.
|
|
|
|
|
|
* gdbarch.h: Re-generate.
|
|
|
|
|
|
* infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
|
|
|
|
|
|
change.
|
|
|
|
|
|
* aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
|
|
|
|
|
|
type to std::unique_ptr.
|
|
|
|
|
|
* aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
* s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
|
|
|
|
|
|
|
gdb: cleanup of displaced_step_inferior_state::reset/displaced_step_clear
displaced_step_inferior_state::reset and displaced_step_clear appear to
have the same goal, but they don't do the same thing.
displaced_step_inferior_state::reset clears more things than
displaced_step_clear, but it misses free'ing the closure, which
displaced_step_clear does.
This patch replaces displaced_step_clear's implementation with just a call to
displaced_step_inferior_state::reset. It then changes
displaced_step_inferior_state::step_closure to be a unique_ptr, to indicate the
fact that displaced_step_inferior_state owns the closure (and so that it is
automatically freed when the field is reset).
The test gdb.base/step-over-syscall.exp caught a problem when doing this, which
I consider to be a latent bug which my cleanup exposes. In
handle_inferior_event, in the TARGET_WAITKIND_FORKED case, if we displaced-step
over a fork syscall, we make sure to restore the memory that we used as a
displaced-stepping buffer in the child. We do so using the
displaced_step_inferior_state of the parent. However, we do it after calling
displaced_step_fixup for the parent, which clears the information in the
parent's displaced_step_inferior_state. It worked fine before, because
displaced_step_clear didn't completely clear the displaced_step_inferior_state
structure, so the required information (in this case the gdbarch) was
still available after clearing.
I fixed it by making GDB restore the child's memory before calling the
displaced_step_fixup on the parent. This way, the data in the
displaced_step_inferior_state structure is still valid when we use it for the
child. This is the error you would get in
gdb.base/step-over-syscall.exp without this fix:
/home/smarchi/src/binutils-gdb/gdb/gdbarch.c:3911: internal-error: ULONGEST gdbarch_max_insn_length(gdbarch*): Assertion `gdbarch != NULL' failed.
gdb/ChangeLog:
* infrun.c (get_displaced_step_closure_by_addr): Adjust to
std::unique_ptr.
(displaced_step_clear): Rename to...
(displaced_step_reset): ... this. Just call displaced->reset ().
(displaced_step_clear_cleanup): Rename to...
(displaced_step_reset_cleanup): ... this.
(displaced_step_prepare_throw): Adjust to std::unique_ptr.
(displaced_step_fixup): Likewise.
(resume_1): Likewise.
(handle_inferior_event): Restore child's memory before calling
displaced_step_fixup on the parent.
* infrun.h (displaced_step_inferior_state) <reset>: Adjust
to std::unique_ptr.
<step_closure>: Change type to std::unique_ptr.
2020-02-14 21:11:58 +01:00
|
|
|
|
2020-02-14 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infrun.c (get_displaced_step_closure_by_addr): Adjust to
|
|
|
|
|
|
std::unique_ptr.
|
|
|
|
|
|
(displaced_step_clear): Rename to...
|
|
|
|
|
|
(displaced_step_reset): ... this. Just call displaced->reset ().
|
|
|
|
|
|
(displaced_step_clear_cleanup): Rename to...
|
|
|
|
|
|
(displaced_step_reset_cleanup): ... this.
|
|
|
|
|
|
(displaced_step_prepare_throw): Adjust to std::unique_ptr.
|
|
|
|
|
|
(displaced_step_fixup): Likewise.
|
|
|
|
|
|
(resume_1): Likewise.
|
|
|
|
|
|
(handle_inferior_event): Restore child's memory before calling
|
|
|
|
|
|
displaced_step_fixup on the parent.
|
|
|
|
|
|
* infrun.h (displaced_step_inferior_state) <reset>: Adjust
|
|
|
|
|
|
to std::unique_ptr.
|
|
|
|
|
|
<step_closure>: Change type to std::unique_ptr.
|
|
|
|
|
|
|
2020-02-14 20:41:07 +01:00
|
|
|
|
2020-02-14 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* arm-tdep.c: Include count-one-bits.h.
|
|
|
|
|
|
(cleanup_block_store_pc): Use count_one_bits.
|
|
|
|
|
|
(cleanup_block_load_pc): Use count_one_bits.
|
|
|
|
|
|
(arm_copy_block_xfer): Use count_one_bits.
|
|
|
|
|
|
(thumb2_copy_block_xfer): Use count_one_bits.
|
|
|
|
|
|
(thumb_copy_pop_pc_16bit): Use count_one_bits.
|
|
|
|
|
|
* arch/arm-get-next-pcs.c: Include count-one-bits.h.
|
|
|
|
|
|
(thumb_get_next_pcs_raw): Use count_one_bits.
|
|
|
|
|
|
(arm_get_next_pcs_raw): Use count_one_bits_l.
|
|
|
|
|
|
* arch/arm.c (bitcount): Remove.
|
|
|
|
|
|
* arch/arm.h (bitcount): Remove.
|
|
|
|
|
|
|
2020-02-14 17:24:42 +01:00
|
|
|
|
2020-02-14 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
|
|
|
|
|
|
* dwarf2/loc.c (call_site_find_chain_1): Return
|
|
|
|
|
|
unique_xmalloc_ptr.
|
|
|
|
|
|
(call_site_find_chain): Likewise.
|
|
|
|
|
|
|
2020-02-14 08:32:53 +01:00
|
|
|
|
2020-02-14 Richard Biener <rguenther@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
|
|
|
|
|
|
on expression with division operators.
|
|
|
|
|
|
|
2020-02-13 11:26:11 +01:00
|
|
|
|
2020-02-13 Alok Kumar Sharma <AlokKumar.Sharma@amd.com>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS (Write After Approval): Adding myself.
|
|
|
|
|
|
|
2020-02-13 01:05:42 +01:00
|
|
|
|
2020-02-12 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* event-loop.c (event_data, gdb_event, event_handler_func):
|
|
|
|
|
|
Remove.
|
|
|
|
|
|
|
2020-02-12 23:45:08 +01:00
|
|
|
|
2020-02-12 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
|
|
|
|
|
|
(dwarf2_frame_objfile_data): Add comment.
|
|
|
|
|
|
(find_comp_unit, set_comp_unit): New functions.
|
|
|
|
|
|
(dwarf2_frame_find_fde): Use find_comp_unit.
|
|
|
|
|
|
(dwarf2_build_frame_info): Use set_comp_unit.
|
|
|
|
|
|
|
2020-02-12 23:45:08 +01:00
|
|
|
|
2020-02-12 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
|
|
|
|
|
|
(comp_unit): Don't initialize objfile.
|
|
|
|
|
|
(execute_cfa_program): Add text_offset parameter.
|
|
|
|
|
|
(execute_cfa_program_test, dwarf2_fetch_cfa_info)
|
|
|
|
|
|
(dwarf2_frame_cache): Update.
|
|
|
|
|
|
(dwarf2_build_frame_info): Don't set "objfile" member.
|
|
|
|
|
|
|
2020-02-12 23:45:08 +01:00
|
|
|
|
2020-02-12 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
|
|
|
|
|
|
(decode_frame_entry): Likewise.
|
|
|
|
|
|
(dwarf2_build_frame_info): Update.
|
|
|
|
|
|
|
2020-02-12 23:45:08 +01:00
|
|
|
|
2020-02-12 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/frame.c (struct comp_unit) <obstack>: New member.
|
|
|
|
|
|
(decode_frame_entry_1): Use the comp_unit obstack.
|
|
|
|
|
|
|
2020-02-12 23:45:08 +01:00
|
|
|
|
2020-02-12 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/frame.c (struct comp_unit): Add initializers and
|
|
|
|
|
|
constructor.
|
|
|
|
|
|
(dwarf2_frame_objfile_data): Store a comp_unit.
|
|
|
|
|
|
(dwarf2_frame_find_fde): Update.
|
|
|
|
|
|
(dwarf2_build_frame_info): Use "new".
|
|
|
|
|
|
|
2020-02-12 23:45:08 +01:00
|
|
|
|
2020-02-12 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/frame.c (struct dwarf2_fde_table): Remove.
|
|
|
|
|
|
(dwarf2_fde_table): Typedef for std::vector.
|
|
|
|
|
|
(dwarf2_frame_objfile_data): Remove the deleter. Now static.
|
|
|
|
|
|
(dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
|
|
|
|
|
|
(decode_frame_entry): Update.
|
|
|
|
|
|
(dwarf2_build_frame_info): Use "new".
|
|
|
|
|
|
|
2020-02-12 23:49:08 +01:00
|
|
|
|
2020-02-12 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* arm-tdep.c (arm_gdbarch_init): Update.
|
|
|
|
|
|
* arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
|
|
|
|
|
|
have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
|
|
|
|
|
|
have_neon, is_m>: Change to bool.
|
|
|
|
|
|
|
2020-02-12 23:28:48 +01:00
|
|
|
|
2020-02-12 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
|
|
|
|
|
|
|
2020-02-12 22:41:33 +01:00
|
|
|
|
2020-02-12 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/loc.c (struct dwarf_expr_baton): Remove.
|
|
|
|
|
|
|
2020-02-09 17:37:58 +01:00
|
|
|
|
2020-02-12 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
|
|
|
|
|
|
(windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
|
|
|
|
|
|
|
2020-02-12 02:11:32 +01:00
|
|
|
|
2020-02-11 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* psymtab.h: Update comment.
|
|
|
|
|
|
|
2020-02-12 01:31:10 +01:00
|
|
|
|
2020-02-11 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdb_obstack.h (struct auto_obstack): Use
|
|
|
|
|
|
DISABLE_COPY_AND_ASSIGN.
|
|
|
|
|
|
|
2020-02-12 01:31:10 +01:00
|
|
|
|
2020-02-11 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/frame.h (struct objfile): Don't forward declare.
|
|
|
|
|
|
|
2020-02-11 17:39:35 +01:00
|
|
|
|
2020-02-11 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* cris-tdep.c (cris_supply_gregset): Change signature to match
|
|
|
|
|
|
what struct regset expects.
|
|
|
|
|
|
(cris_regset): New struct.
|
|
|
|
|
|
(fetch_core_registers): Remove.
|
|
|
|
|
|
(cris_iterate_over_regset_sections): New function.
|
|
|
|
|
|
(_initialize_cris_tdep): Don't call deprecated_add_core_fns.
|
|
|
|
|
|
(cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
|
|
|
|
|
|
|
2020-02-11 00:34:48 +01:00
|
|
|
|
2020-02-11 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
|
|
|
|
|
|
registers.
|
|
|
|
|
|
|
2020-02-11 17:21:14 +01:00
|
|
|
|
2020-02-11 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
|
|
|
|
|
|
|
2020-02-11 16:51:49 +01:00
|
|
|
|
2020-02-11 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* configure: Re-generate.
|
|
|
|
|
|
|
2020-02-11 16:56:05 +01:00
|
|
|
|
2020-02-11 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* configure: Re-generate.
|
|
|
|
|
|
|
2020-02-11 16:51:43 +01:00
|
|
|
|
2020-02-11 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* acinclude: Update warning.m4 path.
|
|
|
|
|
|
* warning.m4: Move to gdbsupport.
|
|
|
|
|
|
|
Remove some ui_file_* functions
This removes ui_file_isatty, ui_file_read, ui_file_write,
ui_file_write_async_safe, ui_file_flush, and ui_file_puts, replacing
them with calls to the appropriate method instead.
gdb/ChangeLog
2020-02-11 Tom Tromey <tromey@adacore.com>
* remote.c (remote_console_output): Update.
* printcmd.c (printf_command): Update.
* event-loop.c (gdb_wait_for_event): Update.
* linux-nat.c (sigchld_handler): Update.
* remote-sim.c (gdb_os_write_stdout): Update.
(gdb_os_flush_stdout): Update.
(gdb_os_flush_stderr): Update.
(gdb_os_write_stderr): Update.
* exceptions.c (print_exception): Update.
* remote-fileio.c (remote_fileio_func_read): Update.
(remote_fileio_func_write): Update.
* tui/tui.c (tui_enable): Update.
* tui/tui-interp.c (tui_interp::init): Update.
* utils.c (init_page_info): Update.
(putchar_unfiltered, fputc_unfiltered): Update.
(gdb_flush): Update.
(emit_style_escape): Update.
(flush_wrap_buffer, fputs_maybe_filtered): Update.
* ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
(ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
(stderr_file::write): Update.
(stderr_file::puts): Update.
* ui-file.h (ui_file_isatty, ui_file_write)
(ui_file_write_async_safe, ui_file_read, ui_file_flush)
(ui_file_puts): Don't declare.
Change-Id: I3ca9b36e9107f6adbc41e014f5078b41d6bcec4d
2020-02-11 15:05:28 +01:00
|
|
|
|
2020-02-11 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_console_output): Update.
|
|
|
|
|
|
* printcmd.c (printf_command): Update.
|
|
|
|
|
|
* event-loop.c (gdb_wait_for_event): Update.
|
|
|
|
|
|
* linux-nat.c (sigchld_handler): Update.
|
|
|
|
|
|
* remote-sim.c (gdb_os_write_stdout): Update.
|
|
|
|
|
|
(gdb_os_flush_stdout): Update.
|
|
|
|
|
|
(gdb_os_flush_stderr): Update.
|
|
|
|
|
|
(gdb_os_write_stderr): Update.
|
|
|
|
|
|
* exceptions.c (print_exception): Update.
|
|
|
|
|
|
* remote-fileio.c (remote_fileio_func_read): Update.
|
|
|
|
|
|
(remote_fileio_func_write): Update.
|
|
|
|
|
|
* tui/tui.c (tui_enable): Update.
|
|
|
|
|
|
* tui/tui-interp.c (tui_interp::init): Update.
|
|
|
|
|
|
* utils.c (init_page_info): Update.
|
|
|
|
|
|
(putchar_unfiltered, fputc_unfiltered): Update.
|
|
|
|
|
|
(gdb_flush): Update.
|
|
|
|
|
|
(emit_style_escape): Update.
|
|
|
|
|
|
(flush_wrap_buffer, fputs_maybe_filtered): Update.
|
|
|
|
|
|
* ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
|
|
|
|
|
|
(ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
|
|
|
|
|
|
(stderr_file::write): Update.
|
|
|
|
|
|
(stderr_file::puts): Update.
|
|
|
|
|
|
* ui-file.h (ui_file_isatty, ui_file_write)
|
|
|
|
|
|
(ui_file_write_async_safe, ui_file_read, ui_file_flush)
|
|
|
|
|
|
(ui_file_puts): Don't declare.
|
|
|
|
|
|
|
2020-02-10 15:13:42 +01:00
|
|
|
|
2020-02-10 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
|
|
|
|
|
|
sentinel to char *.
|
|
|
|
|
|
|
2020-02-09 13:32:26 +01:00
|
|
|
|
2020-02-09 Tom de Vries <tdevries@suse.de>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
|
|
|
|
|
|
filename if it matches "<artificial>".
|
|
|
|
|
|
|
Use enums for human-readable exception information.
Changes to $_siginfo type to this:
(gdb) pt $_siginfo
type = struct EXCEPTION_RECORD {
enum ExceptionCode ExceptionCode;
DWORD ExceptionFlags;
struct EXCEPTION_RECORD *ExceptionRecord;
PVOID ExceptionAddress;
DWORD NumberParameters;
union {
ULONG_PTR ExceptionInformation[15];
struct {...} AccessViolationInformation;
};
}
(gdb) pt $_siginfo.ExceptionCode
type = enum ExceptionCode {FATAL_APP_EXIT = 1073741845,
DBG_CONTROL_C = 1073807365, DBG_CONTROL_BREAK = 1073807368,
DATATYPE_MISALIGNMENT = 2147483650, BREAKPOINT, SINGLE_STEP,
ACCESS_VIOLATION = 3221225477, IN_PAGE_ERROR,
ILLEGAL_INSTRUCTION = 3221225501, NONCONTINUABLE_EXCEPTION = 3221225509,
INVALID_DISPOSITION, ARRAY_BOUNDS_EXCEEDED = 3221225612,
FLOAT_DENORMAL_OPERAND, FLOAT_DIVIDE_BY_ZERO, FLOAT_INEXACT_RESULT,
FLOAT_INVALID_OPERATION, FLOAT_OVERFLOW, FLOAT_STACK_CHECK,
FLOAT_UNDERFLOW, INTEGER_DIVIDE_BY_ZERO, INTEGER_OVERFLOW,
PRIV_INSTRUCTION, STACK_OVERFLOW = 3221225725, FAST_FAIL = 3221226505}
(gdb) pt $_siginfo.AccessViolationInformation
type = struct {
enum ViolationType Type;
PVOID Address;
}
(gdb) pt $_siginfo.AccessViolationInformation.Type
type = enum ViolationType {READ_ACCESS_VIOLATION, WRITE_ACCESS_VIOLATION,
DATA_EXECUTION_PREVENTION_VIOLATION = 8}
Which makes it easier to understand the reason of the exception:
(gdb) p $_siginfo
$1 = {
ExceptionCode = ACCESS_VIOLATION,
ExceptionFlags = 0,
ExceptionRecord = 0x0,
ExceptionAddress = 0x401632 <main+18>,
NumberParameters = 2,
{
ExceptionInformation = {1, 291, 0 <repeats 13 times>},
AccessViolationInformation = {
Type = WRITE_ACCESS_VIOLATION,
Address = 0x123
}
}
}
gdb/ChangeLog:
2020-02-09 Hannes Domani <ssbssa@yahoo.de>
* windows-tdep.c (struct enum_value_name): New struct.
(create_enum): New function.
(windows_get_siginfo_type): Create and use enum types.
2020-01-17 15:50:58 +01:00
|
|
|
|
2020-02-09 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-tdep.c (struct enum_value_name): New struct.
|
|
|
|
|
|
(create_enum): New function.
|
|
|
|
|
|
(windows_get_siginfo_type): Create and use enum types.
|
|
|
|
|
|
|
2020-01-17 15:28:09 +01:00
|
|
|
|
2020-02-09 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Mention $_siginfo support for Windows.
|
|
|
|
|
|
* windows-nat.c (handle_exception): Set siginfo_er.
|
|
|
|
|
|
(windows_nat_target::mourn_inferior): Reset siginfo_er.
|
|
|
|
|
|
(windows_xfer_siginfo): New function.
|
|
|
|
|
|
(windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
|
|
|
|
|
|
* windows-tdep.c (struct windows_gdbarch_data): New struct.
|
|
|
|
|
|
(init_windows_gdbarch_data): New function.
|
|
|
|
|
|
(get_windows_gdbarch_data): New function.
|
|
|
|
|
|
(windows_get_siginfo_type): New function.
|
|
|
|
|
|
(windows_init_abi): Register windows_get_siginfo_type.
|
|
|
|
|
|
(_initialize_windows_tdep): Register init_windows_gdbarch_data.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (class cutu_reader) <cutu_reader,
|
|
|
|
|
|
init_tu_and_read_dwo_dies>: Remove "keep" parameter.
|
|
|
|
|
|
<keep>: Declare method.
|
|
|
|
|
|
<m_keep>: Remove member.
|
|
|
|
|
|
<~cutu_reader>: Remove.
|
|
|
|
|
|
(cutu_reader::init_tu_and_read_dwo_dies): Update.
|
|
|
|
|
|
(cutu_reader::cutu_reader): Update.
|
|
|
|
|
|
(cutu_reader::keep): Rename from ~cutu_reader.
|
|
|
|
|
|
(process_psymtab_comp_unit, build_type_psymtabs_1)
|
|
|
|
|
|
(process_skeletonless_type_unit, load_partial_comp_unit)
|
|
|
|
|
|
(load_full_comp_unit, dwarf2_read_addr_index)
|
|
|
|
|
|
(read_signatured_type): Update.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
|
|
|
|
|
|
"want_partial_unit" parameter.
|
|
|
|
|
|
(process_psymtab_comp_unit): Change want_partial_unit to bool.
|
|
|
|
|
|
Inline check for DW_TAG_partial_unit.
|
|
|
|
|
|
(dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (read_n_bytes, read_direct_string): Move to
|
|
|
|
|
|
read.c.
|
|
|
|
|
|
* dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
|
|
|
|
|
|
read.c.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (read_address): Move to comp-unit.c.
|
|
|
|
|
|
(dwarf2_rnglists_process, dwarf2_ranges_process)
|
|
|
|
|
|
(read_attribute_value, dwarf_decode_lines_1)
|
|
|
|
|
|
(var_decode_location, decode_locdesc): Update.
|
|
|
|
|
|
* dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
|
|
|
|
|
|
read.c. Remove "cu" parameter.
|
|
|
|
|
|
* dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
|
|
|
|
|
|
method.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (read_attribute_value, read_indirect_string)
|
|
|
|
|
|
(read_indirect_line_string): Update.
|
|
|
|
|
|
* dwarf2/comp-unit.c (read_offset): Remove.
|
|
|
|
|
|
(read_comp_unit_head): Update.
|
|
|
|
|
|
* dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
|
|
|
|
|
|
method.
|
|
|
|
|
|
(read_offset): Don't declare.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
|
|
|
|
|
|
* dwarf2/read.c (struct comp_unit_head): Move to
|
|
|
|
|
|
dwarf2/comp-unit.h.
|
|
|
|
|
|
(enum class rcuh_kind): Move to comp-unit.h.
|
|
|
|
|
|
(get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
|
|
|
|
|
|
(read_comp_unit_head, error_check_comp_unit_head)
|
|
|
|
|
|
(read_and_check_comp_unit_head): Move to comp-unit.c.
|
|
|
|
|
|
(read_offset, dwarf_unit_type_name): Likewise.
|
|
|
|
|
|
(create_debug_type_hash_table, read_cutu_die_from_dwo)
|
|
|
|
|
|
(cutu_reader::cutu_reader, read_call_site_scope)
|
|
|
|
|
|
(find_partial_die, follow_die_offset): Update.
|
|
|
|
|
|
* dwarf2/comp-unit.h: New file, from dwarf2read.c.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (read_offset_1): Move to leb.c.
|
|
|
|
|
|
(read_abbrev_offset, read_offset, dwarf_decode_line_header)
|
|
|
|
|
|
(dwarf_decode_macro_bytes): Update.
|
|
|
|
|
|
* dwarf2/leb.c (read_offset): Rename; move from read.c.
|
|
|
|
|
|
* dwarf2/leb.h (read_offset): Declare.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (dwarf2_section_size): Remove.
|
|
|
|
|
|
(error_check_comp_unit_head, dwarf2_symbol_mark_computed):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (read_initial_length): Move to leb.c.
|
|
|
|
|
|
* dwarf2/leb.h (read_initial_length): Declare.
|
|
|
|
|
|
* dwarf2/leb.c (read_initial_length): Move from read.c. Add
|
|
|
|
|
|
handle_nonstd parameter.
|
|
|
|
|
|
* dwarf2/frame.c (read_initial_length): Remove.
|
|
|
|
|
|
(decode_frame_entry_1): Update.
|
|
|
|
|
|
|
Add some methods to dwarf2_per_cu_data
This changes a few helper functions to be methods on
dwarf2_per_cu_data.
2020-02-08 Tom Tromey <tom@tromey.com>
* dwarf2/loc.c (dwarf2_find_location_expression)
(dwarf_evaluate_loc_desc::get_tls_address)
(dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
(rw_pieced_value, dwarf2_evaluate_loc_desc_full)
(dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
(dwarf2_compile_property_to_c)
(dwarf2_loc_desc_get_symbol_read_needs)
(dwarf2_compile_expr_to_ax, locexpr_describe_location)
(locexpr_tracepoint_var_ref, locexpr_generate_c_location)
(loclist_describe_location, loclist_tracepoint_var_ref)
(loclist_generate_c_location): Update.
* compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
* dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
(dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
(dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
* dwarf2/read.c (dwarf2_per_cu_data::objfile)
(dwarf2_per_cu_data::addr_size)
(dwarf2_per_cu_data::ref_addr_size)
(dwarf2_per_cu_data::text_offset)
(dwarf2_per_cu_data::addr_type): Now methods.
(per_cu_header_read_in): Make per_cu "const".
(dwarf2_version): Remove.
(dwarf2_per_cu_data::int_type): Now a method.
(dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
(set_die_type, read_array_type, read_subrange_index_type)
(read_tag_string_type, read_subrange_type): Update.
* dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
offset_size, ref_addr_size, text_offset, addr_type, version,
objfile, int_type, addr_sized_int_type>: Declare methods.
Change-Id: I07a42fa26e00795352389fa7a0cc1c12997d26f7
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/loc.c (dwarf2_find_location_expression)
|
|
|
|
|
|
(dwarf_evaluate_loc_desc::get_tls_address)
|
|
|
|
|
|
(dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
|
|
|
|
|
|
(rw_pieced_value, dwarf2_evaluate_loc_desc_full)
|
|
|
|
|
|
(dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
|
|
|
|
|
|
(dwarf2_compile_property_to_c)
|
|
|
|
|
|
(dwarf2_loc_desc_get_symbol_read_needs)
|
|
|
|
|
|
(dwarf2_compile_expr_to_ax, locexpr_describe_location)
|
|
|
|
|
|
(locexpr_tracepoint_var_ref, locexpr_generate_c_location)
|
|
|
|
|
|
(loclist_describe_location, loclist_tracepoint_var_ref)
|
|
|
|
|
|
(loclist_generate_c_location): Update.
|
|
|
|
|
|
* compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
|
|
|
|
|
|
* dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
|
|
|
|
|
|
(dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
|
|
|
|
|
|
(dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
|
|
|
|
|
|
* dwarf2/read.c (dwarf2_per_cu_data::objfile)
|
|
|
|
|
|
(dwarf2_per_cu_data::addr_size)
|
|
|
|
|
|
(dwarf2_per_cu_data::ref_addr_size)
|
|
|
|
|
|
(dwarf2_per_cu_data::text_offset)
|
|
|
|
|
|
(dwarf2_per_cu_data::addr_type): Now methods.
|
|
|
|
|
|
(per_cu_header_read_in): Make per_cu "const".
|
|
|
|
|
|
(dwarf2_version): Remove.
|
|
|
|
|
|
(dwarf2_per_cu_data::int_type): Now a method.
|
|
|
|
|
|
(dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
|
|
|
|
|
|
(set_die_type, read_array_type, read_subrange_index_type)
|
|
|
|
|
|
(read_tag_string_type, read_subrange_type): Update.
|
|
|
|
|
|
* dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
|
|
|
|
|
|
offset_size, ref_addr_size, text_offset, addr_type, version,
|
|
|
|
|
|
objfile, int_type, addr_sized_int_type>: Declare methods.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
|
|
|
|
|
|
Move earlier.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.h (dwarf_line_debug): Declare.
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
|
|
|
|
|
|
* dwarf2/read.c: Move line_header code to new files.
|
|
|
|
|
|
(dwarf_line_debug): No longer static.
|
|
|
|
|
|
* dwarf2/line-header.c: New file.
|
|
|
|
|
|
* dwarf2/line-header.h: New file.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (struct line_header) <file_full_name,
|
|
|
|
|
|
file_file_name>: Return unique_xmalloc_ptr.
|
|
|
|
|
|
(line_header::file_file_name): Update.
|
|
|
|
|
|
(line_header::file_full_name): Update.
|
|
|
|
|
|
(dw2_get_file_names_reader): Update.
|
|
|
|
|
|
(macro_start_file): Update.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (struct line_header) <file_full_name,
|
|
|
|
|
|
file_file_name>: Declare methods.
|
|
|
|
|
|
(dw2_get_file_names_reader): Update.
|
|
|
|
|
|
(file_file_name): Now a method.
|
|
|
|
|
|
(file_full_name): Likewise.
|
|
|
|
|
|
(macro_start_file): Update.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (dwarf_always_disassemble)
|
|
|
|
|
|
(show_dwarf_always_disassemble): Move to loc.c.
|
|
|
|
|
|
(_initialize_dwarf2_read): Move "always-disassemble" registration
|
|
|
|
|
|
to loc.c.
|
|
|
|
|
|
* dwarf2/read.h (dwarf_always_disassemble): Don't declare.
|
|
|
|
|
|
* dwarf2/loc.c (dwarf_always_disassemble): Move from read.c. Now
|
|
|
|
|
|
static.
|
|
|
|
|
|
(show_dwarf_always_disassemble): Move from read.c.
|
|
|
|
|
|
(_initialize_dwarf2loc): Move always-disassemble from read.c.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (~dwarf2_per_objfile): Update.
|
|
|
|
|
|
(create_quick_file_names_table): Return htab_up.
|
|
|
|
|
|
(dw2_get_file_names_reader, dw2_forget_cached_source_info):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* dwarf2/read.h (struct dwarf2_per_objfile)
|
|
|
|
|
|
<quick_file_names_table>: Now htab_up.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/abbrev.c (abbrev_table::read): Simplify.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/abbrev.c (abbrev_table): Move constructor from header.
|
|
|
|
|
|
Rewrite.
|
|
|
|
|
|
(abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
|
|
|
|
|
|
* dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
|
|
|
|
|
|
(abbrev_table::abbrev_table): No longer inline.
|
|
|
|
|
|
(ABBREV_HASH_SIZE): Remove.
|
|
|
|
|
|
(abbrev_table::m_abbrevs): Now an htab_up.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (read_cutu_die_from_dwo): Update.
|
|
|
|
|
|
(cutu_reader): Update.
|
|
|
|
|
|
(build_type_psymtabs_1): Update.
|
|
|
|
|
|
* dwarf2/abbrev.c (abbrev_table::read): Rename.
|
|
|
|
|
|
(abbrev_table::alloc_abbrev): Update.
|
|
|
|
|
|
* dwarf2/abbrev.h (abbrev_table_up): Move earlier.
|
|
|
|
|
|
(abbrev_table::read): New static method, renamed from
|
|
|
|
|
|
abbrev_table_read_table.
|
|
|
|
|
|
(abbrev_table::alloc_abbrev)
|
|
|
|
|
|
(abbrev_table::add_abbrev): Now private.
|
|
|
|
|
|
(abbrev_table::abbrev_table): Now private.
|
|
|
|
|
|
(abbrev_table::m_abbrev_obstack): Now private. Rename.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
|
|
|
|
|
|
* dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
|
|
|
|
|
|
htab_up.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
|
|
|
|
|
|
htab_up.
|
|
|
|
|
|
(lookup_dwo_unit_in_dwp): Update.
|
|
|
|
|
|
(allocate_dwp_loaded_cutus_table): Return htab_up. Don't allocate
|
|
|
|
|
|
on obstack.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
|
|
|
|
|
|
obstack.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (~dwarf2_per_objfile): Don't delete
|
|
|
|
|
|
line_header_hash.
|
|
|
|
|
|
(handle_DW_AT_stmt_list): Update. Don't allocate on obstack.
|
|
|
|
|
|
* dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
|
|
|
|
|
|
Change type to htab_up.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (allocate_type_unit_groups_table): Return
|
|
|
|
|
|
htab_up. Don't allocate on obstack.
|
|
|
|
|
|
(get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
|
|
|
|
|
|
* dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
|
|
|
|
|
|
Change type to htab_up.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
|
|
|
|
|
|
Change type to htab_up.
|
|
|
|
|
|
* dwarf2/read.c (create_signatured_type_table_from_index)
|
|
|
|
|
|
(create_signatured_type_table_from_debug_names)
|
|
|
|
|
|
(create_all_type_units, add_type_unit)
|
|
|
|
|
|
(lookup_dwo_signatured_type, lookup_signatured_type)
|
|
|
|
|
|
(process_skeletonless_type_unit): Update.
|
|
|
|
|
|
(create_debug_type_hash_table, create_debug_types_hash_table):
|
|
|
|
|
|
Change type of types_htab.
|
|
|
|
|
|
(allocate_signatured_type_table, allocate_dwo_unit_table): Return
|
|
|
|
|
|
htab_up. Don't allocate on obstack.
|
|
|
|
|
|
(create_cus_hash_table): Change type of cus_htab parameter.
|
|
|
|
|
|
(struct dwo_file) <cus, tus>: Now htab_up.
|
|
|
|
|
|
(lookup_dwo_signatured_type, lookup_dwo_cutu)
|
|
|
|
|
|
(process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
|
|
|
|
|
|
(queue_and_load_all_dwo_tus): Update.
|
|
|
|
|
|
* dwarf2/index-write.c (write_gdbindex): Update.
|
|
|
|
|
|
(write_debug_names): Update.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.h (struct dwarf2_queue_item): Move from
|
|
|
|
|
|
dwarf2/read.c. Remove "next" member. Add constructor ntad
|
|
|
|
|
|
destructor.
|
|
|
|
|
|
(struct dwarf2_per_objfile) <queue>: New member.
|
|
|
|
|
|
* dwarf2/read.c (struct dwarf2_queue_item): Move to
|
|
|
|
|
|
dwarf2/read.h.
|
|
|
|
|
|
(dwarf2_queue, dwarf2_queue_tail): Remove.
|
|
|
|
|
|
(class dwarf2_queue_guard): Add parameter to constructor. Use
|
|
|
|
|
|
DISABLE_COPY_AND_ASSIGN.
|
|
|
|
|
|
<m_per_objfile>: New member.
|
|
|
|
|
|
<~dwarf2_queue_guard>: Rewrite.
|
|
|
|
|
|
(dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
(~dwarf2_queue_item): New.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/read.c (struct die_info) <has_children>: New member.
|
|
|
|
|
|
(dw2_get_file_names_reader): Remove has_children.
|
|
|
|
|
|
(dw2_get_file_names): Update.
|
|
|
|
|
|
(read_cutu_die_from_dwo): Remove has_children.
|
|
|
|
|
|
(cutu_reader::init_tu_and_read_dwo_dies)
|
|
|
|
|
|
(cutu_reader::cutu_reader): Update.
|
|
|
|
|
|
(process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
|
|
|
|
|
|
Remove has_children.
|
|
|
|
|
|
(build_type_psymtabs_1, process_skeletonless_type_unit)
|
|
|
|
|
|
(load_partial_comp_unit, load_full_comp_unit): Update.
|
|
|
|
|
|
(create_dwo_cu_reader): Remove has_children.
|
|
|
|
|
|
(create_cus_hash_table, read_die_and_children): Update.
|
|
|
|
|
|
(read_full_die_1,read_full_die): Remove has_children.
|
|
|
|
|
|
(read_signatured_type): Update.
|
|
|
|
|
|
(class cutu_reader) <has_children>: Remove.
|
|
|
|
|
|
|
Move DWARF code to dwarf2/ subdirectory
This moves all the remaining DWARF code to the new dwarf2
subdirectory. This is just a simple renaming, with updates to
includes as needed.
gdb/ChangeLog
2020-02-08 Tom Tromey <tom@tromey.com>
* dwarf2/expr.c: Rename from dwarf2expr.c.
* dwarf2/expr.h: Rename from dwarf2expr.h.
* dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
* dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
* dwarf2/frame.c: Rename from dwarf2-frame.c.
* dwarf2/frame.h: Rename from dwarf2-frame.h.
* dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
* dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
* dwarf2/index-common.c: Rename from dwarf-index-common.c.
* dwarf2/index-common.h: Rename from dwarf-index-common.h.
* dwarf2/index-write.c: Rename from dwarf-index-write.c.
* dwarf2/index-write.h: Rename from dwarf-index-write.h.
* dwarf2/loc.c: Rename from dwarf2loc.c.
* dwarf2/loc.h: Rename from dwarf2loc.h.
* dwarf2/read.c: Rename from dwarf2read.c.
* dwarf2/read.h: Rename from dwarf2read.h.
* dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
Update.
* Makefile.in (COMMON_SFILES): Update.
(HFILES_NO_SRCDIR): Update.
Change-Id: Ied9ce1436cd27ac4a4cffef10ec92e396f181928
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2/expr.c: Rename from dwarf2expr.c.
|
|
|
|
|
|
* dwarf2/expr.h: Rename from dwarf2expr.h.
|
|
|
|
|
|
* dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
|
|
|
|
|
|
* dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
|
|
|
|
|
|
* dwarf2/frame.c: Rename from dwarf2-frame.c.
|
|
|
|
|
|
* dwarf2/frame.h: Rename from dwarf2-frame.h.
|
|
|
|
|
|
* dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
|
|
|
|
|
|
* dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
|
|
|
|
|
|
* dwarf2/index-common.c: Rename from dwarf-index-common.c.
|
|
|
|
|
|
* dwarf2/index-common.h: Rename from dwarf-index-common.h.
|
|
|
|
|
|
* dwarf2/index-write.c: Rename from dwarf-index-write.c.
|
|
|
|
|
|
* dwarf2/index-write.h: Rename from dwarf-index-write.h.
|
|
|
|
|
|
* dwarf2/loc.c: Rename from dwarf2loc.c.
|
|
|
|
|
|
* dwarf2/loc.h: Rename from dwarf2loc.h.
|
|
|
|
|
|
* dwarf2/read.c: Rename from dwarf2read.c.
|
|
|
|
|
|
* dwarf2/read.h: Rename from dwarf2read.h.
|
|
|
|
|
|
* dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
|
|
|
|
|
|
amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
|
|
|
|
|
|
compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
|
|
|
|
|
|
compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
|
|
|
|
|
|
gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
|
|
|
|
|
|
hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
|
|
|
|
|
|
i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
|
|
|
|
|
|
m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
|
|
|
|
|
|
msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
|
|
|
|
|
|
riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
|
|
|
|
|
|
s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
|
|
|
|
|
|
sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
|
|
|
|
|
|
tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Update.
|
|
|
|
|
|
(HFILES_NO_SRCDIR): Update.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
|
|
|
|
|
|
(init_cu_die_reader, read_cutu_die_from_dwo): Update.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.h (struct die_info): Don't declare.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.h (die_info_ptr): Remove typedef.
|
|
|
|
|
|
|
Change attr_form_is_block to be a method
This changes attr_form_is_block to be a method. This is done
separately because, unlike the other attribute functions,
attr_form_is_block had special handling for the case where the
argument was NULL. This required auditing each call site; in most
cases, NULL was already ruled out, but in a few spots, an additional
check was needed.
gdb/ChangeLog
2020-02-08 Tom Tromey <tom@tromey.com>
* dwarf2read.c (read_call_site_scope)
(handle_data_member_location, dwarf2_add_member_fn)
(mark_common_block_symbol_computed, read_common_block)
(attr_to_dynamic_prop, partial_die_info::read)
(var_decode_location, dwarf2_fetch_die_loc_sect_off)
(dwarf2_symbol_mark_computed, set_die_type): Update.
* dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
method.
(attr_form_is_block): Don't declare.
* dwarf2/attribute.c (attribute::form_is_block): Now a method.
Change-Id: Idfb290c61d738301ab991666f43e0b9cf577b2ae
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (read_call_site_scope)
|
|
|
|
|
|
(handle_data_member_location, dwarf2_add_member_fn)
|
|
|
|
|
|
(mark_common_block_symbol_computed, read_common_block)
|
|
|
|
|
|
(attr_to_dynamic_prop, partial_die_info::read)
|
|
|
|
|
|
(var_decode_location, dwarf2_fetch_die_loc_sect_off)
|
|
|
|
|
|
(dwarf2_symbol_mark_computed, set_die_type): Update.
|
|
|
|
|
|
* dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
|
|
|
|
|
|
method.
|
|
|
|
|
|
(attr_form_is_block): Don't declare.
|
|
|
|
|
|
* dwarf2/attribute.c (attribute::form_is_block): Now a method.
|
|
|
|
|
|
|
Change some attribute functions to be methods
This changes most of the attribute-related functions to be methods.
(attr_form_is_block changed in a subsequent patch.)
gdb/ChangeLog
2020-02-08 Tom Tromey <tom@tromey.com>
* dwarf2read.c (dwarf2_find_base_address, )
(read_call_site_scope, rust_containing_type)
(dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
(handle_data_member_location, dwarf2_add_member_fn)
(get_alignment, read_structure_type, process_structure_scope)
(mark_common_block_symbol_computed, read_common_block)
(read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
(partial_die_info::read, read_attribute_value, new_symbol)
(lookup_die_type, dwarf2_get_ref_die_offset)
(dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
(dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
(dwarf2_symbol_mark_computed): Update.
* dwarf2/attribute.h (struct attribute) <value_as_address,
form_is_section_offset, form_is_constant, form_is_ref>: Declare
methods.
(value_as_address, attr_form_is_section_offset)
(attr_form_is_constant, attr_form_is_ref): Don't declare.
* dwarf2/attribute.c (attribute::value_as_address)
(attribute::form_is_section_offset, attribute::form_is_constant)
(attribute::form_is_ref): Now methods.
Change-Id: I320dad13002c59b848dc86c39d5d7111c8a15bdc
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (dwarf2_find_base_address, )
|
|
|
|
|
|
(read_call_site_scope, rust_containing_type)
|
|
|
|
|
|
(dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
|
|
|
|
|
|
(handle_data_member_location, dwarf2_add_member_fn)
|
|
|
|
|
|
(get_alignment, read_structure_type, process_structure_scope)
|
|
|
|
|
|
(mark_common_block_symbol_computed, read_common_block)
|
|
|
|
|
|
(read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
|
|
|
|
|
|
(partial_die_info::read, read_attribute_value, new_symbol)
|
|
|
|
|
|
(lookup_die_type, dwarf2_get_ref_die_offset)
|
|
|
|
|
|
(dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
|
|
|
|
|
|
(dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
|
|
|
|
|
|
(dwarf2_symbol_mark_computed): Update.
|
|
|
|
|
|
* dwarf2/attribute.h (struct attribute) <value_as_address,
|
|
|
|
|
|
form_is_section_offset, form_is_constant, form_is_ref>: Declare
|
|
|
|
|
|
methods.
|
|
|
|
|
|
(value_as_address, attr_form_is_section_offset)
|
|
|
|
|
|
(attr_form_is_constant, attr_form_is_ref): Don't declare.
|
|
|
|
|
|
* dwarf2/attribute.c (attribute::value_as_address)
|
|
|
|
|
|
(attribute::form_is_section_offset, attribute::form_is_constant)
|
|
|
|
|
|
(attribute::form_is_ref): Now methods.
|
|
|
|
|
|
|
Create dwarf2/attribute.[ch]
This moves the attribute-related code out of dwarf2read.c and into the
new files dwarf2/attribute.[ch].
gdb/ChangeLog
2020-02-08 Tom Tromey <tom@tromey.com>
* dwarf2read.c (struct attribute, DW_STRING)
(DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
(DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
(attr_form_is_block, attr_form_is_section_offset)
(attr_form_is_constant, attr_form_is_ref): Move.
* dwarf2/attribute.h: New file.
* dwarf2/attribute.c: New file, from dwarf2read.c.
* Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
Change-Id: I1ea4c146256a1b9e38b66f1c605d782a14eeded7
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (struct attribute, DW_STRING)
|
|
|
|
|
|
(DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
|
|
|
|
|
|
(DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
|
|
|
|
|
|
(attr_form_is_block, attr_form_is_section_offset)
|
|
|
|
|
|
(attr_form_is_constant, attr_form_is_ref): Move.
|
|
|
|
|
|
* dwarf2/attribute.h: New file.
|
|
|
|
|
|
* dwarf2/attribute.c: New file, from dwarf2read.c.
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (abbrev_table_up, struct abbrev_info)
|
|
|
|
|
|
(struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
|
|
|
|
|
|
Move.
|
|
|
|
|
|
(read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
|
|
|
|
|
|
(abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
|
|
|
|
|
|
(abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
|
|
|
|
|
|
abbrev.c.
|
|
|
|
|
|
* dwarf2/abbrev.h: New file.
|
|
|
|
|
|
* dwarf2/abbrev.c: New file, from dwarf2read.c.
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
|
|
|
|
|
|
|
Change section functions to be methods of dwarf2_section_info
This changes various section-related functions to be methods on
dwarf2_section_info. I think this clarifies the role of these
functions. This also changes one such function to return bool.
gdb/ChangeLog
2020-02-08 Tom Tromey <tom@tromey.com>
* dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
(dwarf2_section_size, dwarf2_get_section_info)
(create_signatured_type_table_from_debug_names)
(create_addrmap_from_aranges, read_debug_names_from_section)
(get_gdb_index_contents_from_section, read_comp_unit_head)
(error_check_comp_unit_head, read_abbrev_offset)
(create_debug_type_hash_table, init_cu_die_reader)
(read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
(read_comp_units_from_section, create_cus_hash_table)
(create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
(create_dwp_v2_section, dwarf2_rnglists_process)
(dwarf2_ranges_process, read_die_and_siblings, read_full_die)
(abbrev_table_read_table, read_indirect_string_at_offset_from)
(read_indirect_string_from_dwz, read_addr_index_1)
(read_str_index, dwarf_decode_line_header, skip_form_bytes)
(dwarf_decode_macro_bytes, dwarf_decode_macros)
(fill_in_loclist_baton): Update.
* dwarf2/section.h (struct dwarf2_section_info) <get_name,
get_containing_section, get_bfd_owner, get_bfd_section,
get_file_name, get_id, get_flags, empty, read>: Declare methods.
(dwarf2_read_section, get_section_name, get_section_file_name)
(get_containing_section, get_section_bfd_owner)
(get_section_bfd_section, get_section_name, get_section_file_name)
(get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
declare.
* dwarf2/section.c (dwarf2_section_info::get_containing_section)
(dwarf2_section_info::get_bfd_owner)
(dwarf2_section_info::get_bfd_section)
(dwarf2_section_info::get_name)
(dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
(dwarf2_section_info::get_flags, dwarf2_section_info::empty)
(dwarf2_section_info::read): Now methods.
* dwarf-index-write.c (class debug_names): Update.
Change-Id: Ic849f182f57a18bad6b1c7c3b9368005d307758a
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
|
|
|
|
|
|
(dwarf2_section_size, dwarf2_get_section_info)
|
|
|
|
|
|
(create_signatured_type_table_from_debug_names)
|
|
|
|
|
|
(create_addrmap_from_aranges, read_debug_names_from_section)
|
|
|
|
|
|
(get_gdb_index_contents_from_section, read_comp_unit_head)
|
|
|
|
|
|
(error_check_comp_unit_head, read_abbrev_offset)
|
|
|
|
|
|
(create_debug_type_hash_table, init_cu_die_reader)
|
|
|
|
|
|
(read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
|
|
|
|
|
|
(read_comp_units_from_section, create_cus_hash_table)
|
|
|
|
|
|
(create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
|
|
|
|
|
|
(create_dwp_v2_section, dwarf2_rnglists_process)
|
|
|
|
|
|
(dwarf2_ranges_process, read_die_and_siblings, read_full_die)
|
|
|
|
|
|
(abbrev_table_read_table, read_indirect_string_at_offset_from)
|
|
|
|
|
|
(read_indirect_string_from_dwz, read_addr_index_1)
|
|
|
|
|
|
(read_str_index, dwarf_decode_line_header, skip_form_bytes)
|
|
|
|
|
|
(dwarf_decode_macro_bytes, dwarf_decode_macros)
|
|
|
|
|
|
(fill_in_loclist_baton): Update.
|
|
|
|
|
|
* dwarf2/section.h (struct dwarf2_section_info) <get_name,
|
|
|
|
|
|
get_containing_section, get_bfd_owner, get_bfd_section,
|
|
|
|
|
|
get_file_name, get_id, get_flags, empty, read>: Declare methods.
|
|
|
|
|
|
(dwarf2_read_section, get_section_name, get_section_file_name)
|
|
|
|
|
|
(get_containing_section, get_section_bfd_owner)
|
|
|
|
|
|
(get_section_bfd_section, get_section_name, get_section_file_name)
|
|
|
|
|
|
(get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
|
|
|
|
|
|
declare.
|
|
|
|
|
|
* dwarf2/section.c (dwarf2_section_info::get_containing_section)
|
|
|
|
|
|
(dwarf2_section_info::get_bfd_owner)
|
|
|
|
|
|
(dwarf2_section_info::get_bfd_section)
|
|
|
|
|
|
(dwarf2_section_info::get_name)
|
|
|
|
|
|
(dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
|
|
|
|
|
|
(dwarf2_section_info::get_flags, dwarf2_section_info::empty)
|
|
|
|
|
|
(dwarf2_section_info::read): Now methods.
|
|
|
|
|
|
* dwarf-index-write.c (class debug_names): Update.
|
|
|
|
|
|
|
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
|
|
|
|
|
|
Move to dwarf2/section.h.
|
|
|
|
|
|
* dwarf2read.c (get_containing_section, get_section_bfd_owner)
|
|
|
|
|
|
(get_section_bfd_section, get_section_name)
|
|
|
|
|
|
(get_section_file_name, get_section_id, get_section_flags)
|
|
|
|
|
|
(dwarf2_section_empty_p, dwarf2_read_section): Moe to
|
|
|
|
|
|
dwarf2/section.c.
|
|
|
|
|
|
* dwarf2/section.h: New file.
|
|
|
|
|
|
* dwarf2/section.c: New file, from dwarf2read.c.
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
|
|
|
|
|
|
|
Create dwarf2/leb.[ch]
This moves some scalar-unpacking code into a couple of new files,
dwarf2/leb.h and dwarf2/leb.c.
gdb/ChangeLog
2020-02-08 Tom Tromey <tom@tromey.com>
* dwarf2read.h (read_unsigned_leb128): Don't declare.
* dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
(read_2_signed_bytes, read_3_bytes, read_4_bytes)
(read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
(read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
* dwarf2/leb.h: New file, from dwarf2read.c.
* dwarf2/leb.c: New file, from dwarf2read.c.
* dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
Remove.
* Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
(COMMON_SFILES): Add dwarf2/leb.c.
Change-Id: Idd19647686c8f959d226a95fdfca4db47c6e96d0
2020-02-08 21:40:54 +01:00
|
|
|
|
2020-02-08 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.h (read_unsigned_leb128): Don't declare.
|
|
|
|
|
|
* dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
|
|
|
|
|
|
(read_2_signed_bytes, read_3_bytes, read_4_bytes)
|
|
|
|
|
|
(read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
|
|
|
|
|
|
(read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
|
|
|
|
|
|
* dwarf2/leb.h: New file, from dwarf2read.c.
|
|
|
|
|
|
* dwarf2/leb.c: New file, from dwarf2read.c.
|
|
|
|
|
|
* dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
|
|
|
|
|
|
Remove.
|
|
|
|
|
|
* Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
|
|
|
|
|
|
(COMMON_SFILES): Add dwarf2/leb.c.
|
|
|
|
|
|
|
2020-02-08 14:02:16 +01:00
|
|
|
|
2020-02-08 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
GDB 9.1 released.
|
|
|
|
|
|
|
2020-02-05 12:45:13 +01:00
|
|
|
|
2020-02-05 Iain Buclaw <ibuclaw@gdcproject.org>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/25190:
|
|
|
|
|
|
* gdb/remote-sim.c (gdb_os_write_stderr): Update.
|
|
|
|
|
|
* gdb/remote.c (remote_console_output): Update.
|
|
|
|
|
|
* gdb/ui-file.c (fputs_unfiltered): Rename to...
|
|
|
|
|
|
(ui_file_puts): ...this.
|
|
|
|
|
|
* gdb/ui-file.h (ui_file_puts): Add declaration.
|
|
|
|
|
|
* gdb/utils.c (emit_style_escape): Update.
|
|
|
|
|
|
(flush_wrap_buffer): Update.
|
|
|
|
|
|
(fputs_maybe_filtered): Update.
|
|
|
|
|
|
(fputs_unfiltered): Add function.
|
|
|
|
|
|
|
2020-02-05 12:25:09 +01:00
|
|
|
|
2020-02-05 Iain Buclaw <ibuclaw@gdcproject.org>
|
|
|
|
|
|
|
|
|
|
|
|
* gdb/event-loop.c (gdb_wait_for_event): Update.
|
|
|
|
|
|
* gdb/printcmd.c (printf_command): Update.
|
|
|
|
|
|
* gdb/remote-fileio.c (remote_fileio_func_write): Update.
|
|
|
|
|
|
* gdb/remote-sim.c (gdb_os_flush_stdout): Update.
|
|
|
|
|
|
(gdb_os_flush_stderr): Update.
|
|
|
|
|
|
* gdb/remote.c (remote_console_output): Update.
|
|
|
|
|
|
* gdb/ui-file.c (gdb_flush): Rename to...
|
|
|
|
|
|
(ui_file_flush): ...this.
|
|
|
|
|
|
(stderr_file::write): Update.
|
|
|
|
|
|
(stderr_file::puts): Update.
|
|
|
|
|
|
* gdb/ui-file.h (gdb_flush): Rename to...
|
|
|
|
|
|
(ui_file_flush): ...this.
|
|
|
|
|
|
* gdb/utils.c (gdb_flush): Add function.
|
|
|
|
|
|
* gdb/utils.h (gdb_flush): Add declaration.
|
|
|
|
|
|
|
2020-02-05 10:53:44 +01:00
|
|
|
|
2020-02-07 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR breakpoints/24915:
|
|
|
|
|
|
* source.c (find_and_open_source): Do not check basenames_may_differ.
|
|
|
|
|
|
|
Move gdbserver to top level
This patch moves gdbserver to the top level.
This patch is as close to a pure move as possible -- gdbserver still
builds its own variant of gnulib and gdbsupport. Changing this will
be done in a separate patch.
[v2] Note that, per Simon's review comment, this patch changes the
tree so that gdbserver is not built for or1k or score. This makes
sense, because there is apparently not actually a gdbserver port here.
[v3] This version of the patch also splits out some configury into a
new file, gdbserver/configure.host, so that the top-level configure
script can simply rely on it in order to decide whether gdbserver
should be built.
[v4] This version adds documentation and removes some unnecessary
top-level dependencies.
[v5] Update docs to mention "make all-gdbserver" and change how
top-level configure decides whether to build gdbserver, switching to a
single, shared script.
Tested by the buildbot.
ChangeLog
2020-02-07 Tom Tromey <tom@tromey.com>
Pedro Alves <palves@redhat.com>
* src-release.sh (GDB_SUPPORT_DIRS): Add gdbserver.
* gdbserver: New directory, moved from gdb/gdbserver.
* configure.ac (host_tools): Add gdbserver.
Only build gdbserver on certain systems.
* Makefile.in, configure: Rebuild.
* Makefile.def (host_modules, dependencies): Add gdbserver.
* MAINTAINERS: Add gdbserver.
gdb/ChangeLog
2020-02-07 Tom Tromey <tom@tromey.com>
* README: Update gdbserver documentation.
* gdbserver: Move to top level.
* configure.tgt (build_gdbserver): Remove.
* configure.ac: Remove --enable-gdbserver.
* configure: Rebuild.
* Makefile.in (distclean): Don't mention gdbserver.
Change-Id: I826b7565b54604711dc7a11edea0499cd51ff39e
2019-12-15 15:37:06 +01:00
|
|
|
|
2020-02-07 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* README: Update gdbserver documentation.
|
|
|
|
|
|
* gdbserver: Move to top level.
|
|
|
|
|
|
* configure.tgt (build_gdbserver): Remove.
|
|
|
|
|
|
* configure.ac: Remove --enable-gdbserver.
|
|
|
|
|
|
* configure: Rebuild.
|
|
|
|
|
|
* Makefile.in (distclean): Don't mention gdbserver.
|
|
|
|
|
|
|
gdb: Catch exceptions if the source file is not found
The source_cache::ensure method may throw an exception through
the invocation of source_cache::get_plain_source_lines. This
happens when the source file is not found. The expected behaviour
of "ensure" is only returning "true" or "false" according to the
documentation in the header file.
So far, if gdb is in source layout and a file is missing, you see
some outputs like below:
,---------------------------------------------.
| test.c file is loaded in the source window. |
| |
| int main() |
| ... |
|---------------------------------------------|
| Remote debugging using :1234 |
| __start () at /path/to/crt0.S:141 |
| /path/to/crt0.S: No such file or directory. |
| (gdb) p/x $pc |
| $1 = 0x124 |
| (gdb) n |
| /path/to/crt0.S: No such file or directory. |
| (gdb) p/x $pc |
| $2 = 0x128 |
| (gdb) [pressing arrow-down key] |
| (gdb) terminate called after throwing an |
| instance of 'gdb_exception_error' |
`---------------------------------------------'
Other issues have been encountered as well [1].
The patch from Pedro [2] which is about preventing exceptions
from crossing the "readline" mitigates the situation by not
causing gdb crash, but still there are lots of errors printed:
,---------------------------------------------.
| test.c file is loaded in the source window. |
| |
| int main() |
| ... |
|---------------------------------------------|
| Remote debugging using :1234 |
| __start () at /path/to/crt0.S:141 |
| /path/to/crt0.S: No such file or directory. |
| (gdb) [pressing arrow-down key] |
| /path/to/crt0.S: No such file or directory. |
| (gdb) [pressing arrow-down key] |
| /path/to/crt0.S: No such file or directory. |
| (gdb) [pressing arrow-up key] |
| /path/to/crt0.S: No such file or directory. |
`---------------------------------------------'
With the changes of this patch, the behavior is like:
,---------------------------------------------.
| initially, source window is empty because |
| crt0.S is not found and according to the |
| program counter that is the piece of code |
| being executed. |
| |
| later, when we break at main (see commands |
| below), this window will be filled with the |
| the contents of test.c file. |
|---------------------------------------------|
| Remote debugging using :1234 |
| __start () at /path/to/crt0.S:141 |
| (gdb) p/x $pc |
| $1 = 0x124 |
| (gdb) n |
| (gdb) p/x $pc |
| $2 = 0x128 |
| (gdb) b main |
| Breakpoint 1 at 0x334: file test.c, line 8. |
| (gdb) cont |
| Continuing. |
| Breakpoint 1, main () at hello.c:8 |
| (gdb) n |
| (gdb) |
`---------------------------------------------'
There is no crash and the error message is completely
gone. Maybe it is good practice that the error is
shown inside the source window.
I tested this change against gdb.base/list-missing-source.exp
and there was no regression.
[1]
It has also been observed in the past that the register
values are not transferred from qemu's gdb stub, see:
https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/issues/226
[2]
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=2f267673f0fdee9287e6d404ecd4f2d29da0d2f2
gdb/ChangeLog:
* source-cache.c (source_cache::ensure): Surround
get_plain_source_lines with a try/catch.
(source_cache::get_line_charpos): Get rid of try/catch
and only check for the return value of "ensure".
* tui/tui-source.c (tui_source_window::set_contents):
Simplify "nlines" calculation.
gdb/testsuite/ChangeLog:
* gdb.tui/tui-missing-src.exp: Add the "missing source
file" test for the TUI.
2020-02-06 16:20:37 +01:00
|
|
|
|
2020-02-06 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* source-cache.c (source_cache::ensure): Surround
|
|
|
|
|
|
get_plain_source_lines with a try/catch.
|
|
|
|
|
|
(source_cache::get_line_charpos): Get rid of try/catch
|
|
|
|
|
|
and only check for the return value of "ensure".
|
|
|
|
|
|
* tui/tui-source.c (tui_source_window::set_contents):
|
|
|
|
|
|
Simplify "nlines" calculation.
|
|
|
|
|
|
|
2020-02-06 16:56:40 +01:00
|
|
|
|
2020-02-06 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS (Write After Approval): Add myself.
|
|
|
|
|
|
|
2020-02-05 18:43:22 +01:00
|
|
|
|
2020-02-05 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
|
|
|
|
|
|
function call.
|
|
|
|
|
|
|
2020-02-05 18:33:42 +01:00
|
|
|
|
2020-02-05 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ppc-nbsd-tdep.h: Fix macro name in #endif comment.
|
|
|
|
|
|
|
2020-02-05 18:21:12 +01:00
|
|
|
|
2020-02-05 Maciej W. Rozycki <macro@wdc.com>
|
|
|
|
|
|
|
|
|
|
|
|
* nat/riscv-linux-tdesc.h: New file.
|
|
|
|
|
|
* nat/riscv-linux-tdesc.c: New file, taking code from...
|
|
|
|
|
|
* riscv-linux-nat.c (riscv_linux_nat_target::read_description):
|
|
|
|
|
|
... here.
|
|
|
|
|
|
* configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
|
|
|
|
|
|
NATDEPFILES.
|
|
|
|
|
|
|
2020-02-04 10:07:16 +01:00
|
|
|
|
2020-02-04 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
|
|
|
|
|
|
we don't set the fake simulator ptid to the null_ptid.
|
|
|
|
|
|
|
2020-02-04 05:02:28 +01:00
|
|
|
|
2020-02-03 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* fork-child.c (gdb_startup_inferior): Use bool instead of int.
|
|
|
|
|
|
* gdbthread.h (class thread_info) <resumed>: Likewise.
|
|
|
|
|
|
* infrun.c (resume_1): Likewise.
|
|
|
|
|
|
(proceed): Likewise.
|
|
|
|
|
|
(infrun_thread_stop_requested): Likewise.
|
|
|
|
|
|
(stop_all_threads): Likewise.
|
|
|
|
|
|
(handle_inferior_event): Likewise.
|
|
|
|
|
|
(restart_threads): Likewise.
|
|
|
|
|
|
(finish_step_over): Likewise.
|
|
|
|
|
|
(keep_going_stepped_thread): Likewise.
|
|
|
|
|
|
* linux-nat.c (attach_proc_task_lwp_callback): Likewise.
|
|
|
|
|
|
(linux_handle_extended_wait): Likewise.
|
|
|
|
|
|
* record-btrace.c (get_thread_current_frame_id): Likewise.
|
|
|
|
|
|
* record-full.c (record_full_wait_1): Likewise.
|
|
|
|
|
|
* remote.c (remote_target::process_initial_stop_replies): Likewise.
|
|
|
|
|
|
* target.c (target_resume): Likewise.
|
|
|
|
|
|
* thread.c (set_running_thread): Likewise.
|
|
|
|
|
|
|
2020-02-04 02:24:34 +01:00
|
|
|
|
2020-02-03 Alok Kumar Sharma <AlokKumar.Sharma@amd.com>
|
|
|
|
|
|
|
|
|
|
|
|
* f-valprint.c (f77_print_array_1): Changed datatype of index
|
|
|
|
|
|
variable to LONGEST from int to enable it to contain bound
|
|
|
|
|
|
values correctly.
|
|
|
|
|
|
|
2020-02-03 13:07:02 +01:00
|
|
|
|
2020-02-03 Maciej W. Rozycki <macro@wdc.com>
|
|
|
|
|
|
|
|
|
|
|
|
* riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
|
|
|
|
|
|
(supply_fpregset_regnum, fill_fpregset): Handle regset buffer
|
|
|
|
|
|
offsets according to FLEN determined.
|
|
|
|
|
|
(riscv_linux_nat_target::read_description): Determine FLEN
|
|
|
|
|
|
dynamically.
|
|
|
|
|
|
(riscv_linux_nat_target::fetch_registers): Size regset buffer
|
|
|
|
|
|
according to FLEN determined.
|
|
|
|
|
|
(riscv_linux_nat_target::store_registers): Likewise.
|
|
|
|
|
|
|
gdb: Do not print empty-group regs when printing general ones
When the command "info registers" (same as "info registers general"),
is issued, _all_ the registers from a tdesc XML are printed. This
includes the registers with empty register groups (set as "") which
are supposed to be only printed by "info registers all" (or "info
all-registers").
This bug got introduced after all the overhauls that the
tdesc_register_in_reggroup_p() went through. You can see that the
logic of tdesc_register_in_reggroup_p() did NOT remain the same after
all those changes:
git difftool c9c895b9666..HEAD -- gdb/target-descriptions.c
With the current implementation, when the reg->group is an empty
string, this function returns -1, while in the working revision
(c9c895b9666), it returned 0. This patch makes sure that the 0 is
returned again.
The old implementation of tdesc_register_in_reggroup_p() returned
-1 when "reggroup" was set to "all_reggroups" at line 4 below:
1 tdesc_register_reggroup_p (...)
2 {
3 ...
4 ret = tdesc_register_in_reggroup_p (gdbarch, regno, reggroup);
5 if (ret != -1)
6 return ret;
7
8 return default_register_reggroup_p (gdbarch, regno, reggroup);
9 }
As a result, the execution continued at line 8 and the
default_register_reggroup_p(..., reggroup=all_reggroups) would
return 1. However, with the current implementation of
tdesc_register_in_reggroup_p() that allows checking against any
arbitrary group name, it returns 0 when comparing the "reg->group"
against the string "all" which is the group name for "all_reggroups".
I have added a special check to cover this case and
"info all-registers" works as expected.
gdb/ChangeLog:
* target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
when reg->group is empty and reggroup is not.
Change-Id: I9eaf9d7fb36410ed5684ae652fe4756b1b2e61a3
2020-01-31 23:10:11 +01:00
|
|
|
|
2020-02-01 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
|
|
|
|
|
|
when reg->group is empty and reggroup is not.
|
|
|
|
|
|
|
2020-01-22 20:30:40 +01:00
|
|
|
|
2020-01-31 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
|
|
|
|
|
|
Call beneath target's mourn_inferior after unpushing.
|
|
|
|
|
|
|
gdb/tui: Disassembler scrolling of very small programs
In TUI mode, if the disassembly output for the program is less than
one screen long, then currently if the user scrolls down until on the
last assembly instruction is displayed and then tries to scroll up
using Page-Up, the display doesn't update - they are stuck viewing the
last line.
If the user tries to scroll up using the Up-Arrow, then the display
scrolls normally.
What is happening is on the Page-Up we ask GDB to scroll backward the
same number of lines as the height of the TUI ASM window. The back
scanner, which looks for a good place to start disassembling, fails to
find a starting address which will provide the requested number of new
lines before we get back to the original starting address (which is
not surprising, our whole program contains less than a screen height
of instructions), as a result the back scanner gives up and returns
the original starting address.
When we scroll with Up-Arrow we only ask the back scanner to find 1
new instruction, which it manages to do, so this scroll works.
The solution here is, when we fail to find enough instructions, to
return the lowest address we did manage to find. This will ensure we
jump to the lowest possible address in the disassembly output.
gdb/ChangeLog:
PR tui/9765
* tui/tui-disasm.c (tui_find_disassembly_address): If we don't
have enough lines to fill the screen, still return the lowest
address we found.
gdb/testsuite/ChangeLog:
PR tui/9765
* gdb.tui/tui-layout-asm-short-prog.S: New file.
* gdb.tui/tui-layout-asm-short-prog.exp: New file.
Change-Id: I6a6a7972c68a0559e9717fd8d82870b669a40af3
2020-01-24 13:46:56 +01:00
|
|
|
|
2020-01-31 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR tui/9765
|
|
|
|
|
|
* tui/tui-disasm.c (tui_find_disassembly_address): If we don't
|
|
|
|
|
|
have enough lines to fill the screen, still return the lowest
|
|
|
|
|
|
address we found.
|
|
|
|
|
|
|
2020-01-24 15:18:56 +01:00
|
|
|
|
2020-01-31 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-win.c (_initialize_tui_win): Update help text for '+',
|
|
|
|
|
|
'-', '<', and '>' commands.
|
|
|
|
|
|
|
2020-01-29 18:53:55 +01:00
|
|
|
|
2020-01-29 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
Sergio Durigan Junior <sergiodj@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infcmd.c (construct_inferior_arguments): Assert that
|
|
|
|
|
|
'argc' is greater than 0.
|
|
|
|
|
|
|
Recognize more program breakpoint patterns
New in v3:
- Code cleanups based on reviews.
New in v2:
- Fixed misc problems based on reviews.
- Switched to using gdbarch_program_breakpoint_here_p as opposed to
gdbarch_insn_is_breakpoint.
- Fixed matching of brk instructions. Previously the mask was incorrect, which
was showing up as a few failures in the testsuite. Now it is clean.
- New testcase (separate patch).
- Moved program_breakpoint_here () to arch-utils.c and made it the default
implementation of gdbarch_program_breakpoint_here_p.
--
It was reported to me that program breakpoints (permanent ones inserted into
the code itself) other than the one GDB uses for AArch64 (0xd4200000) do not
generate visible stops when continuing, and GDB will continue spinning
infinitely.
This happens because GDB, upon hitting one of those program breakpoints, thinks
the SIGTRAP came from a delayed breakpoint hit...
(gdb) x/i $pc
=> 0x4005c0 <problem_function>: brk #0x90f
(gdb) c
Continuing.
infrun: clear_proceed_status_thread (process 14198)
infrun: proceed (addr=0xffffffffffffffff, signal=GDB_SIGNAL_DEFAULT)
infrun: proceed: resuming process 14198
infrun: resume (step=0, signal=GDB_SIGNAL_0), trap_expected=0, current thread [process 14198] at 0x4005c0
infrun: infrun_async(1)
infrun: prepare_to_wait
infrun: target_wait (-1.0.0, status) =
infrun: 14198.14198.0 [process 14198],
infrun: status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: handle_inferior_event status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: stop_pc = 0x4005c0
infrun: delayed software breakpoint trap, ignoring
infrun: no stepping, continue
infrun: resume (step=0, signal=GDB_SIGNAL_0), trap_expected=0, current thread [process 14198] at 0x4005c0
infrun: prepare_to_wait
infrun: target_wait (-1.0.0, status) =
infrun: 14198.14198.0 [process 14198],
infrun: status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: handle_inferior_event status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: stop_pc = 0x4005c0
infrun: delayed software breakpoint trap, ignoring
infrun: no stepping, continue
infrun: resume (step=0, signal=GDB_SIGNAL_0), trap_expected=0, current thread [process 14198] at 0x4005c0
infrun: prepare_to_wait
infrun: target_wait (-1.0.0, status) =
infrun: 14198.14198.0 [process 14198],
infrun: status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: handle_inferior_event status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: stop_pc = 0x4005c0
infrun: delayed software breakpoint trap, ignoring
infrun: no stepping, continue
infrun: resume (step=0, signal=GDB_SIGNAL_0), trap_expected=0, current thread [process 14198] at 0x4005c0
infrun: prepare_to_wait
infrun: target_wait (-1.0.0, status) =
infrun: 14198.14198.0 [process 14198],
infrun: status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: handle_inferior_event status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: stop_pc = 0x4005c0
infrun: delayed software breakpoint trap, ignoring
infrun: no stepping, continue
infrun: resume (step=0, signal=GDB_SIGNAL_0), trap_expected=0, current thread [process 14198] at 0x4005c0
infrun: prepare_to_wait
infrun: target_wait (-1.0.0, status) =
infrun: 14198.14198.0 [process 14198],
infrun: status->kind = stopped, signal = GDB_SIGNAL_TRAP
...
... which is not the case.
If the program breakpoint is one GDB recognizes, then it will stop when it
hits it.
(gdb) x/i $pc
=> 0x4005c0 <problem_function>: brk #0x0
(gdb) c
Continuing.
infrun: clear_proceed_status_thread (process 14193)
infrun: proceed (addr=0xffffffffffffffff, signal=GDB_SIGNAL_DEFAULT)
infrun: proceed: resuming process 14193
infrun: resume (step=0, signal=GDB_SIGNAL_0), trap_expected=0, current thread [process 14193] at 0x4005c0
infrun: infrun_async(1)
infrun: prepare_to_wait
infrun: target_wait (-1.0.0, status) =
infrun: 14193.14193.0 [process 14193],
infrun: status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: handle_inferior_event status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: stop_pc = 0x4005c0
infrun: random signal (GDB_SIGNAL_TRAP)
infrun: stop_waiting
infrun: stop_all_threads
infrun: stop_all_threads, pass=0, iterations=0
infrun: process 14193 not executing
infrun: stop_all_threads, pass=1, iterations=1
infrun: process 14193 not executing
infrun: stop_all_threads done
Program received signal SIGTRAP, Trace/breakpoint trap.
problem_function () at brk_0.c:7
7 asm("brk %0\n\t" ::"n"(0x0));
infrun: infrun_async(0)
Otherwise GDB will keep trying to resume the inferior and will keep
seeing the SIGTRAP's, without stopping.
To the user it appears GDB has gone into an infinite loop, interruptible only
by Ctrl-C.
Also, windbg seems to use a different variation of AArch64 breakpoint compared
to GDB. This causes problems when debugging Windows on ARM binaries, when
program breakpoints are being used.
The proposed patch creates a new gdbarch method (gdbarch_program_breakpoint_here_p)
that tells GDB whether the underlying instruction is a breakpoint instruction
or not.
This is more general than only checking for the instruction GDB uses as
breakpoint.
The existing logic is still preserved for targets that do not implement this
new gdbarch method.
The end result is like so:
(gdb) x/i $pc
=> 0x4005c0 <problem_function>: brk #0x90f
(gdb) c
Continuing.
infrun: clear_proceed_status_thread (process 16417)
infrun: proceed (addr=0xffffffffffffffff, signal=GDB_SIGNAL_DEFAULT)
infrun: proceed: resuming process 16417
infrun: resume (step=0, signal=GDB_SIGNAL_0), trap_expected=0, current thread [process 16417] at 0x4005c0
infrun: infrun_async(1)
infrun: prepare_to_wait
infrun: target_wait (-1.0.0, status) =
infrun: 16417.16417.0 [process 16417],
infrun: status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: handle_inferior_event status->kind = stopped, signal = GDB_SIGNAL_TRAP
infrun: stop_pc = 0x4005c0
infrun: random signal (GDB_SIGNAL_TRAP)
infrun: stop_waiting
infrun: stop_all_threads
infrun: stop_all_threads, pass=0, iterations=0
infrun: process 16417 not executing
infrun: stop_all_threads, pass=1, iterations=1
infrun: process 16417 not executing
infrun: stop_all_threads done
Program received signal SIGTRAP, Trace/breakpoint trap.
problem_function () at brk.c:7
7 asm("brk %0\n\t" ::"n"(0x900 + 0xf));
infrun: infrun_async(0)
gdb/ChangeLog:
2020-01-29 Luis Machado <luis.machado@linaro.org>
* aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
(BRK_INSN_MASK): Define to 0xd4200000.
(aarch64_program_breakpoint_here_p): New function.
(aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
* arch-utils.c (default_program_breakpoint_here_p): Moved from
breakpoint.c.
* arch-utils.h (default_program_breakpoint_here_p): Moved from
breakpoint.h
* breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
call gdbarch_program_breakpoint_here_p.
(program_breakpoint_here): Moved to arch-utils.c, renamed to
default_program_breakpoint_here_p, changed return type to bool and
simplified.
* breakpoint.h (program_breakpoint_here): Moved prototype to
arch-utils.h, renamed to default_program_breakpoint_here_p and changed
return type to bool.
* gdbarch.c: Regenerate.
* gdbarch.h: Regenerate.
* gdbarch.sh (program_breakpoint_here_p): New method.
* infrun.c (handle_signal_stop): Call
gdbarch_program_breakpoint_here_p.
2019-12-23 16:04:26 +01:00
|
|
|
|
2020-01-29 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
|
|
|
|
|
|
(BRK_INSN_MASK): Define to 0xd4200000.
|
|
|
|
|
|
(aarch64_program_breakpoint_here_p): New function.
|
|
|
|
|
|
(aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
|
|
|
|
|
|
* arch-utils.c (default_program_breakpoint_here_p): Moved from
|
|
|
|
|
|
breakpoint.c.
|
|
|
|
|
|
* arch-utils.h (default_program_breakpoint_here_p): Moved from
|
|
|
|
|
|
breakpoint.h
|
|
|
|
|
|
* breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
|
|
|
|
|
|
call gdbarch_program_breakpoint_here_p.
|
|
|
|
|
|
(program_breakpoint_here): Moved to arch-utils.c, renamed to
|
|
|
|
|
|
default_program_breakpoint_here_p, changed return type to bool and
|
|
|
|
|
|
simplified.
|
|
|
|
|
|
* breakpoint.h (program_breakpoint_here): Moved prototype to
|
|
|
|
|
|
arch-utils.h, renamed to default_program_breakpoint_here_p and changed
|
|
|
|
|
|
return type to bool.
|
|
|
|
|
|
* gdbarch.c: Regenerate.
|
|
|
|
|
|
* gdbarch.h: Regenerate.
|
|
|
|
|
|
* gdbarch.sh (program_breakpoint_here_p): New method.
|
|
|
|
|
|
* infrun.c (handle_signal_stop): Call
|
|
|
|
|
|
gdbarch_program_breakpoint_here_p.
|
|
|
|
|
|
|
2020-01-27 02:43:17 +01:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* ctfread.c (struct ctf_fp_info): Reindent.
|
|
|
|
|
|
(_initialize_ctfread): Remove.
|
|
|
|
|
|
|
Virtualize "readin" and "compunit_symtab"
This patch removes the "readin" and "compunit_symtab" members from
partial_symtab, replacing them with methods. Then it introduces a new
"standard_psymtab" class, which restores these members; and changes
the symbol readers to use this intermediate class as the base class of
their partial symtab subclasses.
The reason for this is to make it possible for a symbol reader to
implement an alternate mapping between partial and full symbol tables.
This is important in order to be able to share psymtabs across
objfiles -- whether a psymtab has been "readin" is objfile-dependent,
as are the pointers to the full symbol tables.
gdb/ChangeLog
2020-01-26 Tom Tromey <tom@tromey.com>
* psymtab.c (partial_map_expand_apply)
(psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
(psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
(psym_print_stats, psym_expand_symtabs_for_function)
(psym_map_symbol_filenames, psym_map_matching_symbols)
(psym_expand_symtabs_matching)
(partial_symtab::read_dependencies, maintenance_info_psymtabs)
(maintenance_check_psymtabs): Use new methods.
* psympriv.h (struct partial_symtab) <readin_p,
get_compunit_symtab>: New methods.
<readin, compunit_symtab>: Remove members.
(struct standard_psymtab): New.
(struct legacy_psymtab): Derive from standard_psymtab.
* dwarf2read.h (struct dwarf2_psymtab): Derive from
standard_psymtab.
* ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
Change-Id: Idb923f196d7e03bf7cb9cfc8134ed06dd3f211ce
2019-10-23 17:50:58 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* psymtab.c (partial_map_expand_apply)
|
|
|
|
|
|
(psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
|
|
|
|
|
|
(psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
|
|
|
|
|
|
(psym_print_stats, psym_expand_symtabs_for_function)
|
|
|
|
|
|
(psym_map_symbol_filenames, psym_map_matching_symbols)
|
|
|
|
|
|
(psym_expand_symtabs_matching)
|
|
|
|
|
|
(partial_symtab::read_dependencies, maintenance_info_psymtabs)
|
|
|
|
|
|
(maintenance_check_psymtabs): Use new methods.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab) <readin_p,
|
|
|
|
|
|
get_compunit_symtab>: New methods.
|
|
|
|
|
|
<readin, compunit_symtab>: Remove members.
|
|
|
|
|
|
(struct standard_psymtab): New.
|
|
|
|
|
|
(struct legacy_psymtab): Derive from standard_psymtab.
|
|
|
|
|
|
* dwarf2read.h (struct dwarf2_psymtab): Derive from
|
|
|
|
|
|
standard_psymtab.
|
|
|
|
|
|
* ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
|
|
|
|
|
|
|
2019-10-23 17:46:25 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (xcoff_psymtab_to_symtab_1): Call
|
|
|
|
|
|
read_dependencies. Add assert.
|
|
|
|
|
|
* psymtab.c (partial_symtab::read_dependencies): New method.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab) <read_dependencies>: New
|
|
|
|
|
|
method.
|
|
|
|
|
|
* mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
|
|
|
|
|
|
* dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
|
|
|
|
|
|
read_dependencies.
|
|
|
|
|
|
* dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
|
|
|
|
|
|
Add assert.
|
|
|
|
|
|
|
2019-10-23 17:40:54 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
|
|
|
|
|
|
Call expand_psymtab.
|
|
|
|
|
|
(xcoff_read_symtab): Call expand_psymtab.
|
|
|
|
|
|
(xcoff_start_psymtab, xcoff_end_psymtab): Set
|
|
|
|
|
|
legacy_expand_psymtab.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab) <expand_psymtab>: New
|
|
|
|
|
|
method.
|
|
|
|
|
|
(struct legacy_psymtab) <expand_psymtab>: Implement.
|
|
|
|
|
|
<legacy_expand_psymtab>: New member.
|
|
|
|
|
|
* mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
|
|
|
|
|
|
(parse_partial_symbols): Set legacy_expand_psymtab.
|
|
|
|
|
|
(psymtab_to_symtab_1): Change argument order. Call
|
|
|
|
|
|
expand_psymtab.
|
|
|
|
|
|
(new_psymtab): Set legacy_expand_psymtab.
|
|
|
|
|
|
* dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
|
|
|
|
|
|
* dwarf2read.c (dwarf2_psymtab::read_symtab): Call
|
|
|
|
|
|
expand_psymtab.
|
|
|
|
|
|
(dwarf2_psymtab::expand_psymtab): Rename from
|
|
|
|
|
|
psymtab_to_symtab_1. Call expand_psymtab.
|
|
|
|
|
|
* dbxread.c (start_psymtab): Set legacy_expand_psymtab.
|
|
|
|
|
|
(dbx_end_psymtab): Likewise.
|
|
|
|
|
|
(dbx_psymtab_to_symtab_1): Change argument order. Call
|
|
|
|
|
|
expand_psymtab.
|
|
|
|
|
|
(dbx_read_symtab): Call expand_psymtab.
|
|
|
|
|
|
* ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
|
|
|
|
|
|
(ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
|
|
|
|
|
|
(ctf_psymtab::read_symtab): Call expand_psymtab.
|
|
|
|
|
|
|
2019-10-23 05:13:10 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (xcoff_read_symtab): Remove prints. Add assert.
|
|
|
|
|
|
* psymtab.c (psymtab_to_symtab): Print verbose "Reading"
|
|
|
|
|
|
messages.
|
|
|
|
|
|
* mdebugread.c (mdebug_read_symtab): Remove prints.
|
|
|
|
|
|
* dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints. Add
|
|
|
|
|
|
assert.
|
|
|
|
|
|
* dbxread.c (dbx_read_symtab): Remove prints. Add assert.
|
|
|
|
|
|
|
Introduce partial_symtab::read_symtab method
This introduces a new partial_symtab::read_symtab method, and updates
the symbol readers to subclass partial_symtab and implement this
method. The old read_symtab and read_symtab_private members are
removed.
In practice, only DWARF and CTF are truly updated to take advantage of
the new setup. The other symbol readers are less actively maintained,
and so this patch also introduces a "legacy_psymtab", which
essentially works the same way as the old partial_symtab.
(Note that, without more knowledge of the interaction between these
symbol readers, fixing this to remove the new (small) overhead is not
trivial, because these readers copy the read_symtab pointer between
partial symtabs.)
gdb/ChangeLog
2020-01-26 Tom Tromey <tom@tromey.com>
* xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
(xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
(xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
legacy_symtab.
* stabsread.h (dbx_end_psymtab): Use legacy_symtab.
* psymtab.c (psymtab_to_symtab): Call method.
(dump_psymtab): Update.
* psympriv.h (struct partial_symtab): Add virtual destructor.
<read_symtab>: New method.
(struct legacy_symtab): New.
* mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
(struct pst_map) <pst>: Now a legacy_psymtab.
(parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
(new_psymtab): Use legacy_psymtab.
* dwarf2read.h (struct dwarf2_psymtab): New.
(struct dwarf2_per_cu_data) <psymtab>: Use it.
* dwarf2read.c (dwarf2_create_include_psymtab)
(dwarf2_build_include_psymtabs, create_type_unit_group)
(create_partial_symtab, process_psymtab_comp_unit_reader)
(build_type_psymtabs_reader, build_type_psymtab_dependencies)
(set_partial_user): Use dwarf2_psymtab.
(dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
(psymtab_to_symtab_1, process_full_comp_unit)
(process_full_type_unit, dwarf2_ranges_read)
(dwarf2_get_pc_bounds, psymtab_include_file_name)
(dwarf_decode_lines): Use dwarf2_psymtab.
* dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
(add_address_entry_worker, write_one_signatured_type)
(recursively_count_psymbols, recursively_write_psymbols)
(write_one_signatured_type, psyms_seen_size, write_gdbindex)
(write_debug_names): Likewise.
* dbxread.c (struct header_file_location): Take a legacy_psymtab.
<pst>: Now a legacy_psymtab.
(find_corresponding_bincl_psymtab): Return a legacy_psymtab.
(read_dbx_symtab, start_psymtab, dbx_end_psymtab)
(dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
* ctfread.c (struct ctf_psymtab): New.
(ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
ctf_psymtab.
(ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
(create_partial_symtab): Return a ctf_psymtab.
(scan_partial_symbols): Update.
Change-Id: Ia57a828786867d6ad03200af8f996f48ed15285e
2019-10-23 01:28:37 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
|
|
|
|
|
|
(xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
|
|
|
|
|
|
(xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
|
|
|
|
|
|
legacy_symtab.
|
|
|
|
|
|
* stabsread.h (dbx_end_psymtab): Use legacy_symtab.
|
|
|
|
|
|
* psymtab.c (psymtab_to_symtab): Call method.
|
|
|
|
|
|
(dump_psymtab): Update.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab): Add virtual destructor.
|
|
|
|
|
|
<read_symtab>: New method.
|
|
|
|
|
|
(struct legacy_symtab): New.
|
|
|
|
|
|
* mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
|
|
|
|
|
|
(struct pst_map) <pst>: Now a legacy_psymtab.
|
|
|
|
|
|
(parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
|
|
|
|
|
|
(new_psymtab): Use legacy_psymtab.
|
|
|
|
|
|
* dwarf2read.h (struct dwarf2_psymtab): New.
|
|
|
|
|
|
(struct dwarf2_per_cu_data) <psymtab>: Use it.
|
|
|
|
|
|
* dwarf2read.c (dwarf2_create_include_psymtab)
|
|
|
|
|
|
(dwarf2_build_include_psymtabs, create_type_unit_group)
|
|
|
|
|
|
(create_partial_symtab, process_psymtab_comp_unit_reader)
|
|
|
|
|
|
(build_type_psymtabs_reader, build_type_psymtab_dependencies)
|
|
|
|
|
|
(set_partial_user): Use dwarf2_psymtab.
|
|
|
|
|
|
(dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
|
|
|
|
|
|
(psymtab_to_symtab_1, process_full_comp_unit)
|
|
|
|
|
|
(process_full_type_unit, dwarf2_ranges_read)
|
|
|
|
|
|
(dwarf2_get_pc_bounds, psymtab_include_file_name)
|
|
|
|
|
|
(dwarf_decode_lines): Use dwarf2_psymtab.
|
|
|
|
|
|
* dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
|
|
|
|
|
|
(add_address_entry_worker, write_one_signatured_type)
|
|
|
|
|
|
(recursively_count_psymbols, recursively_write_psymbols)
|
|
|
|
|
|
(write_one_signatured_type, psyms_seen_size, write_gdbindex)
|
|
|
|
|
|
(write_debug_names): Likewise.
|
|
|
|
|
|
* dbxread.c (struct header_file_location): Take a legacy_psymtab.
|
|
|
|
|
|
<pst>: Now a legacy_psymtab.
|
|
|
|
|
|
(find_corresponding_bincl_psymtab): Return a legacy_psymtab.
|
|
|
|
|
|
(read_dbx_symtab, start_psymtab, dbx_end_psymtab)
|
|
|
|
|
|
(dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
|
|
|
|
|
|
* ctfread.c (struct ctf_psymtab): New.
|
|
|
|
|
|
(ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
|
|
|
|
|
|
ctf_psymtab.
|
|
|
|
|
|
(ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
|
|
|
|
|
|
(create_partial_symtab): Return a ctf_psymtab.
|
|
|
|
|
|
(scan_partial_symbols): Update.
|
|
|
|
|
|
|
2019-10-23 01:08:16 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (xcoff_start_psymtab): Use new.
|
|
|
|
|
|
* psymtab.c (partial_symtab::partial_symtab): New constructor,
|
|
|
|
|
|
renamed from start_psymtab_common.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab): Add new constructor.
|
|
|
|
|
|
(start_psymtab_common): Don't declare.
|
|
|
|
|
|
* mdebugread.c (parse_partial_symbols): Use new.
|
|
|
|
|
|
* dwarf2read.c (create_partial_symtab): Use new.
|
|
|
|
|
|
* dbxread.c (start_psymtab): Use new.
|
|
|
|
|
|
* ctfread.c (create_partial_symtab): Use new.
|
|
|
|
|
|
|
2019-10-23 00:57:35 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (xcoff_end_psymtab): Use new.
|
|
|
|
|
|
* psymtab.c (start_psymtab_common): Use new.
|
|
|
|
|
|
(partial_symtab::partial_symtab): Rename from allocate_psymtab.
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab): Add parameters to
|
|
|
|
|
|
constructor. Don't inline.
|
|
|
|
|
|
(allocate_psymtab): Don't declare.
|
|
|
|
|
|
* mdebugread.c (new_psymtab): Use new.
|
|
|
|
|
|
* dwarf2read.c (dwarf2_create_include_psymtab): Use new.
|
|
|
|
|
|
* dbxread.c (dbx_end_psymtab): Use new.
|
|
|
|
|
|
|
2019-10-23 00:51:55 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
|
|
|
|
|
|
allocate_psymtab. Update documentation.
|
|
|
|
|
|
* psymtab.c (psymtab_storage::install_psymtab): Rename from
|
|
|
|
|
|
allocate_psymtab. Do not use new.
|
|
|
|
|
|
(allocate_psymtab): Use new. Update.
|
|
|
|
|
|
|
2019-10-23 00:47:27 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
|
|
|
|
|
|
* psymtab.c (psym_print_stats): Update.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab) <readin,
|
|
|
|
|
|
psymtabs_addrmap_supported, anonymous>: Now bool.
|
|
|
|
|
|
* mdebugread.c (psymtab_to_symtab_1): Update.
|
|
|
|
|
|
* dwarf2read.c (create_type_unit_group, create_partial_symtab)
|
|
|
|
|
|
(build_type_psymtabs_reader, psymtab_to_symtab_1)
|
|
|
|
|
|
(process_full_comp_unit, process_full_type_unit): Update.
|
|
|
|
|
|
* dbxread.c (dbx_psymtab_to_symtab_1): Update.
|
|
|
|
|
|
* ctfread.c (psymtab_to_symtab): Update.
|
|
|
|
|
|
|
2019-10-16 22:06:43 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* mdebugread.c (parse_partial_symbols): Use discard_psymtab.
|
|
|
|
|
|
* psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
|
|
|
|
|
|
* psymtab.c (psymtab_storage): Delete psymtabs.
|
|
|
|
|
|
(psymtab_storage::allocate_psymtab): Use new.
|
|
|
|
|
|
(psymtab_storage::discard_psymtab): Use delete.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab): Add constructor and
|
|
|
|
|
|
initializers.
|
|
|
|
|
|
|
2019-10-23 01:41:58 +02:00
|
|
|
|
2020-01-26 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* machoread.c: Do not include psympriv.h.
|
|
|
|
|
|
|
2019-12-21 14:47:17 +01:00
|
|
|
|
2020-01-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Mention the new option and the set/show commands.
|
|
|
|
|
|
|
Implement 'set/show exec-file-mismatch'.
This option allows to tell GDB to detect and possibly handle mismatched exec-files.
A recurrent problem with GDB is that GDB uses the wrong exec-file
when using the attach/detach commands successively.
Also, in case the user specifies a file on the command line but attaches
to the wrong PID, this error is not made visible and gives a not user
understandable behaviour.
For example:
$ gdb
...
(gdb) atta 2682 ############################################ PID running 'sleepers' executable
Attaching to process 2682
[New LWP 2683]
[New LWP 2684]
[New LWP 2685]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
0x00007f5ff829f603 in select () at ../sysdeps/unix/syscall-template.S:84
84 ../sysdeps/unix/syscall-template.S: No such file or directory.
(gdb) det
Detaching from program: /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers, process 2682
[Inferior 1 (process 2682) detached]
(gdb) atta 31069 ############################################ PID running 'gdb' executable
Attaching to program: /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers, process 31069
Reading symbols from /lib64/ld-linux-x86-64.so.2...
Reading symbols from /usr/lib/debug/.build-id/60/6df9c355103e82140d513bc7a25a635591c153.debug...
0x00007f43c23478a0 in ?? ()
(gdb) bt
#0 0x00007f43c23478a0 in ?? ()
#1 0x0000558909e3ad91 in ?? ()
#2 0x0000202962646700 in ?? ()
#3 0x00007ffc69c74e70 in ?? ()
#4 0x000055890c1d2350 in ?? ()
#5 0x0000000000000000 in ?? ()
(gdb)
The second attach has kept the executable of the first attach.
(in this case, 31069 is the PID of a GDB, that has nothing to do
with the first determined 'sleepers' executable).
Similarly, if specifying an executable, but attaching to a wrong pid,
we get:
gdb /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers
...
Reading symbols from /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers...
(gdb) atta 31069 ############################################ PID running 'gdb' executable
Attaching to program: /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers, process 31069
Reading symbols from /lib64/ld-linux-x86-64.so.2...
Reading symbols from /usr/lib/debug/.build-id/60/6df9c355103e82140d513bc7a25a635591c153.debug...
0x00007f43c23478a0 in ?? ()
(gdb) bt
#0 0x00007f43c23478a0 in ?? ()
#1 0x0000558909e3ad91 in ?? ()
#2 0x0000202962646700 in ?? ()
#3 0x00007ffc69c74e70 in ?? ()
#4 0x000055890c1d2350 in ?? ()
#5 0x0000000000000000 in ?? ()
(gdb)
And it is unclear to the user what has happened/what is going wrong.
This patch series implements a new option:
(gdb) apropos exec-file-mismatch
set exec-file-mismatch -- Set exec-file-mismatch handling (ask|warn|off).
show exec-file-mismatch -- Show exec-file-mismatch handling (ask|warn|off).
(gdb) help set exec-file-mismatch
Set exec-file-mismatch handling (ask|warn|off).
Specifies how to handle a mismatch between the current exec-file name
loaded by GDB and the exec-file name automatically determined when attaching
to a process:
ask - warn the user and ask whether to load the determined exec-file.
warn - warn the user, but do not change the exec-file.
off - do not check for mismatch.
"ask" means: in case of mismatch between the current exec-file name
and the automatically determined exec-file name of the PID we are attaching to,
give a warning to the user and ask whether to load the automatically determined
exec-file.
"warn" means: in case of mismatch, just give a warning to the user.
"off" means: do not check for mismatch.
This fixes PR gdb/17626.
There was a previous trial to fix this PR.
See https://sourceware.org/ml/gdb-patches/2015-07/msg00118.html
This trial was however only fixing the problem for the automatically
determined executable files when doing attach.
It was differentiating the 'user specified executable files' ("sticky")
from the executable files automatically found by GDB.
But such user specified sticky executables are in most cases due
to a wrong manipulation by the user, giving unexpected results
such as backtrace showing no function like in the above example.
This patch ensures that whenever a process executable can be
determined, that the user is warned if there is a mismatch.
The same tests as above then give:
(gdb) atta 2682
Attaching to process 2682
[New LWP 2683]
[New LWP 2684]
[New LWP 2685]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
0x00007f5ff829f603 in select () at ../sysdeps/unix/syscall-template.S:84
84 ../sysdeps/unix/syscall-template.S: No such file or directory.
(gdb) det
Detaching from program: /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers, process 2682
[Inferior 1 (process 2682) detached]
(gdb) atta 31069
Attaching to program: /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers, process 31069
warning: Mismatch between current exec-file /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers
and automatically determined exec-file /bd/home/philippe/gdb/git/build_fixes/gdb/gdb
exec-file-mismatch handling is currently "ask"
Load new symbol table from "/bd/home/philippe/gdb/git/build_fixes/gdb/gdb"? (y or n) y
Reading symbols from /bd/home/philippe/gdb/git/build_fixes/gdb/gdb...
Setting up the environment for debugging gdb.
...
Reading symbols from /usr/lib/debug/.build-id/60/6df9c355103e82140d513bc7a25a635591c153.debug...
0x00007f43c23478a0 in __poll_nocancel () at ../sysdeps/unix/syscall-template.S:84
84 ../sysdeps/unix/syscall-template.S: No such file or directory.
(top-gdb) bt
During symbol reading: incomplete CFI data; unspecified registers (e.g., rax) at 0x7f43c23478ad
During symbol reading: unsupported tag: 'DW_TAG_unspecified_type'
During symbol reading: cannot get low and high bounds for subprogram DIE at 0x12282a7
During symbol reading: Child DIE 0x12288ba and its abstract origin 0x1228b26 have different parents
During symbol reading: DW_AT_call_target target DIE has invalid low pc, for referencing DIE 0x1229540 [in module /bd/home/philippe/gdb/git/build_fixes/gdb/gdb]
#0 0x00007f43c23478a0 in __poll_nocancel () at ../sysdeps/unix/syscall-template.S:84
#1 0x0000558909e3ad91 in poll (__timeout=-1, __nfds=<optimized out>, __fds=<optimized out>) at /usr/include/x86_64-linux-gnu/bits/poll2.h:46
#2 gdb_wait_for_event (block=block@entry=1) at ../../fixes/gdb/event-loop.c:772
#3 0x0000558909e3aef4 in gdb_do_one_event () at ../../fixes/gdb/event-loop.c:347
#4 0x0000558909e3b085 in gdb_do_one_event () at ../../fixes/gdb/common/common-exceptions.h:219
#5 start_event_loop () at ../../fixes/gdb/event-loop.c:371
During symbol reading: Member function "~_Sp_counted_base" (offset 0x1c69bf7) is virtual but the vtable offset is not specified
During symbol reading: Multiple children of DIE 0x1c8f5a0 refer to DIE 0x1c8f0ee as their abstract origin
#6 0x0000558909ed3b78 in captured_command_loop () at ../../fixes/gdb/main.c:331
#7 0x0000558909ed4b6d in captured_main (data=<optimized out>) at ../../fixes/gdb/main.c:1174
#8 gdb_main (args=<optimized out>) at ../../fixes/gdb/main.c:1190
#9 0x0000558909c1e9a8 in main (argc=<optimized out>, argv=<optimized out>) at ../../fixes/gdb/gdb.c:32
(top-gdb)
gdb /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers
...
Reading symbols from /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers...
(gdb) atta 31069
Attaching to program: /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers, process 31069
warning: Mismatch between current exec-file /home/philippe/valgrind/git/trunk_untouched/gdbserver_tests/sleepers
and automatically determined exec-file /bd/home/philippe/gdb/git/build_fixes/gdb/gdb
exec-file-mismatch handling is currently "ask"
Load new symbol table from "/bd/home/philippe/gdb/git/build_fixes/gdb/gdb"? (y or n) y
Reading symbols from /bd/home/philippe/gdb/git/build_fixes/gdb/gdb...
Setting up the environment for debugging gdb.
....
In other words, it now works as intuitively expected by the user.
If ever the user gave the correct executable on the command line,
then attached to the wrong pid, then confirmed loading the wrong executable,
the user can simply fix this by detaching, and attaching to the correct pid,
GDB will then tell again to the user that the exec-file might better
be loaded.
The default value of "ask" is chosen instead of e.g. "warn" as in most
cases, switching of executable will be the correct action,
and in any case, the user can decide to not load the executable,
as GDB asks a confirmation to the user to load the new executable.
For settings "ask" and "warn", the new function validate_exec_file ()
tries to get the inferior pid exec file and compares it with the current
exec file. In case of mismatch, it warns the user and optionally load
the executable.
This function is called in the attach_command implementation to cover
most cases of attaching to a running process.
It must also be called in remote.c, as the attach command is not supported
for all types of remote gdbserver.
gdb/ChangeLog
2020-01-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
* exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
(show_exec_file_mismatch_command, set_exec_file_mismatch_command)
(validate_exec_file): New variables, enums, functions.
(exec_file_locate_attach, print_section_info): Style the filenames.
(_initialize_exec): Install show_exec_file_mismatch_command and
set_exec_file_mismatch_command.
* gdbcore.h (validate_exec_file): Declare.
* infcmd.c (attach_command): Call validate_exec_file.
* remote.c ( remote_target::remote_add_inferior): Likewise.
2019-12-21 10:55:11 +01:00
|
|
|
|
2020-01-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
|
|
|
|
|
|
|
|
|
|
|
|
* exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
|
|
|
|
|
|
(show_exec_file_mismatch_command, set_exec_file_mismatch_command)
|
|
|
|
|
|
(validate_exec_file): New variables, enums, functions.
|
|
|
|
|
|
(exec_file_locate_attach, print_section_info): Style the filenames.
|
|
|
|
|
|
(_initialize_exec): Install show_exec_file_mismatch_command and
|
|
|
|
|
|
set_exec_file_mismatch_command.
|
|
|
|
|
|
* gdbcore.h (validate_exec_file): Declare.
|
|
|
|
|
|
* infcmd.c (attach_command): Call validate_exec_file.
|
|
|
|
|
|
* remote.c ( remote_target::remote_add_inferior): Likewise.
|
|
|
|
|
|
|
gdb: Better frame tracking for inline frames
This commit improves GDB's handling of inline functions when there are
more than one inline function in a stack, so for example if we have a
stack like:
main -> aaa -> bbb -> ccc -> ddd
And aaa, bbb, and ccc are all inline within main GDB should (when
given sufficient debug information) be able to step from main through
aaa, bbb, and ccc. Unfortunately, this currently doesn't work, here's
an example session:
(gdb) start
Temporary breakpoint 1 at 0x4003b0: file test.c, line 38.
Starting program: /project/gdb/tests/inline/test
Temporary breakpoint 1, main () at test.c:38
38 global_var = 0;
(gdb) step
39 return aaa () + 1;
(gdb) step
aaa () at test.c:39
39 return aaa () + 1;
(gdb) step
bbb () at test.c:39
39 return aaa () + 1;
(gdb) step
ccc () at test.c:39
39 return aaa () + 1;
(gdb) step
ddd () at test.c:32
32 return global_var;
(gdb) bt
#0 ddd () at test.c:32
#1 0x00000000004003c1 in ccc () at test.c:39
#2 bbb () at test.c:26
#3 aaa () at test.c:14
#4 main () at test.c:39
Notice that once we get to line 39 in main, GDB keeps reporting line
39 in main as the location despite understanding that the inferior is
stepping through the nested inline functions with each use of step.
The problem is that as soon as the inferior stops we call
skip_inline_frames (from inline-frame.c) which calculates the
inferiors current state in relation to inline functions - it figures
out if we're in an inline function, and if we are counts how many
inline frames there are at the current location.
So, in our example above, when we step from line 38 in main to line 39
we stop at a location that is simultaneously in all of main, aaa, bbb,
and ccc. The block structure reflects the order in which the
functions would be called, with ccc being the most inner block and
main being the most outer block. When we stop GDB naturally finds the
block for ccc, however within skip_inline_frames we spot that bbb,
aaa, and main are super-blocks of the current location and that each
layer represents an inline function. The skip_inline_frames then
records the depth of inline functions (3 in this case for aaa, bbb,
and ccc) and also the symbol of the outermost inline function (in this
case 'aaa' as main isn't an inline function, it just has things inline
within it).
Now GDB understands the stack to be main -> aaa -> bbb -> ccc,
however, the state initialised in skip_inline_frames starts off
indicating that we should hide 3 frames from the user, so we report
that we're in main at line 39. The location of main, line 39 is
derived by asking the inline function state for the last symbol in the
stack (aaa in this case), and then asking for it's location - the
location of an inlined function symbol is its call site, so main, line
39 in this case.
If the user then asks GDB to step we don't actually move the inferior
at all, instead we spot that we are in an inline function stack,
lookup the inline state data, and reduce the skip depth by 1. We then
report to the user that GDB has stopped. GDB now understands that we
are in 'aaa'. In order to get the precise location we again ask GDB
for the last symbol from the inline data structure, and we are again
told 'aaa', we then get the location from 'aaa', and report that we
are in main, line 39.
Hopefully it's clear what the mistake here is, once we've reduced the
inline skip depth we should not be using 'aaa' to compute the precise
location, instead we should be using 'bbb'. That is what this patch
does.
Now, when we call skip_inline_frames instead of just recording the
last skipped symbol we now record all symbols in the inline frame
stack. When we ask GDB for the last skipped symbol we return a symbol
based on how many frames we are skipping, not just the last know
symbol.
With this fix in place, the same session as above now looks much
better:
(gdb) start
Temporary breakpoint 1 at 0x4003b0: file test.c, line 38.
Starting program: /project/gdb/tests/inline/test
Temporary breakpoint 1, main () at test.c:38
38 global_var = 0;
(gdb) s
39 return aaa () + 1;
(gdb) s
aaa () at test.c:14
14 return bbb () + 1;
(gdb) s
bbb () at test.c:26
26 return ccc () + 1;
(gdb) s
ccc () at test.c:20
20 return ddd () + 1;
(gdb) s
ddd () at test.c:32
32 return global_var;
(gdb) bt
#0 ddd () at test.c:32
#1 0x00000000004003c1 in ccc () at test.c:20
#2 bbb () at test.c:26
#3 aaa () at test.c:14
#4 main () at test.c:39
gdb/ChangeLog:
* frame.c (find_frame_sal): Move call to get_next_frame into more
inner scope.
* inline-frame.c (inilne_state) <inline_state>: Update argument
types.
(inilne_state) <skipped_symbol>: Rename to...
(inilne_state) <skipped_symbols>: ...this, and change to a vector.
(skip_inline_frames): Build vector of skipped symbols and use this
to reate the inline_state.
(inline_skipped_symbol): Add a comment and some assertions, fetch
skipped symbol from the list.
gdb/testsuite/ChangeLog:
* gdb.dwarf2/dw2-inline-many-frames.c: New file.
* gdb.dwarf2/dw2-inline-many-frames.exp: New file.
Change-Id: I99def5ffb44eb9e58cda4b449bf3d91ab0386c62
2019-11-11 23:41:13 +01:00
|
|
|
|
2020-01-24 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* frame.c (find_frame_sal): Move call to get_next_frame into more
|
|
|
|
|
|
inner scope.
|
|
|
|
|
|
* inline-frame.c (inilne_state) <inline_state>: Update argument
|
|
|
|
|
|
types.
|
|
|
|
|
|
(inilne_state) <skipped_symbol>: Rename to...
|
|
|
|
|
|
(inilne_state) <skipped_symbols>: ...this, and change to a vector.
|
|
|
|
|
|
(skip_inline_frames): Build vector of skipped symbols and use this
|
|
|
|
|
|
to reate the inline_state.
|
|
|
|
|
|
(inline_skipped_symbol): Add a comment and some assertions, fetch
|
|
|
|
|
|
skipped symbol from the list.
|
|
|
|
|
|
|
gdb: Don't reorder line table entries too much when sorting.
Don't reorder line table entries for the same address when sorting the
line table, maintain the compiler given line order. Usually this will
reflect the order in which lines are conceptually encountered at a
given address.
Consider this example:
/* 1 */ volatile int global_var;
/* 2 */ int __attribute__ ((noinline))
/* 3 */ bar ()
/* 4 */ {
/* 5 */ return global_var;
/* 6 */ }
/* 7 */ static inline int __attribute__ ((always_inline))
/* 8 */ foo ()
/* 9 */ {
/* 10 */ return bar ();
/* 11 */ }
/* 12 */ int
/* 13 */ main ()
/* 14 */ {
/* 15 */ global_var = 0;
/* 16 */ return foo ();
/* 17 */ }
GCC 10 currently generates a line table like this (as shown by
objdump):
CU: ./test.c:
File name Line number Starting address
test.c 4 0x4004b0
test.c 5 0x4004b0
test.c 6 0x4004b6
test.c 6 0x4004b7
test.c 14 0x4003b0
test.c 15 0x4003b0
test.c 16 0x4003ba
test.c 10 0x4003ba
test.c 10 0x4003c1
The interesting entries are those for lines 16 and 10 at address
0x4003ba, these represent the call to foo and the inlined body of
foo.
With the current line table sorting GDB builds the line table like
this (as shown by 'maintenance info line-table'):
INDEX LINE ADDRESS
0 14 0x00000000004003b0
1 15 0x00000000004003b0
2 10 0x00000000004003ba
3 16 0x00000000004003ba
4 END 0x00000000004003c1
5 4 0x00000000004004b0
6 5 0x00000000004004b0
7 END 0x00000000004004b7
Notice that entries 2 and 3 for lines 10 and 16 are now in a different
order to the line table as given by the compiler. With this patch
applied the order is now:
INDEX LINE ADDRESS
0 14 0x00000000004003b0
1 15 0x00000000004003b0
2 16 0x00000000004003ba
3 10 0x00000000004003ba
4 END 0x00000000004003c1
5 4 0x00000000004004b0
6 5 0x00000000004004b0
7 END 0x00000000004004b7
Notice that entries 2 and 3 are now in their original order again.
The consequence of the incorrect ordering is that when stepping
through inlined functions GDB will display the wrong line for the
inner most frame. Here's a GDB session before this patch is applied:
Starting program: /home/andrew/tmp/inline/test
Temporary breakpoint 1, main () at test.c:15
15 /* 15 */ global_var = 0;
(gdb) step
16 /* 16 */ return foo ();
(gdb) step
foo () at test.c:16
16 /* 16 */ return foo ();
(gdb) step
bar () at test.c:5
5 /* 5 */ return global_var;
The step from line 15 to 16 was fine, but the next step should have
taken us to line 10, instead we are left at line 16. The final step
to line 5 is as expected.
With this patch applied the session goes better:
Starting program: /home/andrew/tmp/inline/test
Temporary breakpoint 1, main () at test.c:15
15 /* 15 */ global_var = 0;
(gdb) step
16 /* 16 */ return foo ();
(gdb) step
foo () at test.c:10
10 /* 10 */ return bar ();
(gdb) step
bar () at test.c:5
5 /* 5 */ return global_var;
We now visit the lines as 15, 16, 10, 5 as we would like.
The reason for this issue is that the inline frame unwinder is
detecting that foo is inlined in main. When we stop at the shared
address 0x4003ba the inline frame unwinder first shows us the outer
frame, this information is extracted from the DWARF's
DW_TAG_inlined_subroutine entries and passed via GDB's block data.
When we step again the inlined frame unwinder moves us up the call
stack to the inner most frame at which point the frame is displayed as
normal, with the location for the address being looked up in the line
table.
As GDB uses the last line table entry for an address as "the" line to
report for that address it is critical that GDB maintain the order of
the line table entries. In the first case, by reordering the line
table we report the wrong location.
I had to make a small adjustment in find_pc_sect_line in order to
correctly find the previous line in the line table. In some line
tables I was seeing an actual line entry and an end of sequence marker
at the same address, before this commit these would reorder to move
the end of sequence marker before the line entry (end of sequence has
line number 0). Now the end of sequence marker remains in its correct
location, and in order to find a previous line we should step backward
over any end of sequence markers.
As an example, the binary:
gdb/testsuite/outputs/gdb.dwarf2/dw2-ranges-func/dw2-ranges-func-lo-cold
Has this line table before the patch:
INDEX LINE ADDRESS
0 48 0x0000000000400487
1 END 0x000000000040048e
2 52 0x000000000040048e
3 54 0x0000000000400492
4 56 0x0000000000400497
5 END 0x000000000040049a
6 62 0x000000000040049a
7 END 0x00000000004004a1
8 66 0x00000000004004a1
9 68 0x00000000004004a5
10 70 0x00000000004004aa
11 72 0x00000000004004b9
12 END 0x00000000004004bc
13 76 0x00000000004004bc
14 78 0x00000000004004c0
15 80 0x00000000004004c5
16 END 0x00000000004004cc
And after this patch:
INDEX LINE ADDRESS
0 48 0x0000000000400487
1 52 0x000000000040048e
2 END 0x000000000040048e
3 54 0x0000000000400492
4 56 0x0000000000400497
5 END 0x000000000040049a
6 62 0x000000000040049a
7 66 0x00000000004004a1
8 END 0x00000000004004a1
9 68 0x00000000004004a5
10 70 0x00000000004004aa
11 72 0x00000000004004b9
12 END 0x00000000004004bc
13 76 0x00000000004004bc
14 78 0x00000000004004c0
15 80 0x00000000004004c5
16 END 0x00000000004004cc
When calling find_pc_sect_line with the address 0x000000000040048e, in
both cases we find entry #3, we then try to find the previous entry,
which originally found this entry '2 52 0x000000000040048e',
after the patch it finds '2 END 0x000000000040048e', which
cases the lookup to fail.
By skipping the END marker after this patch we get back to the correct
entry, which is now #1: '1 52 0x000000000040048e', and
everything works again.
gdb/ChangeLog:
* buildsym.c (lte_is_less_than): Delete.
(buildsym_compunit::end_symtab_with_blockvector): Create local
lambda function to sort line table entries, and use
std::stable_sort instead of std::sort.
* symtab.c (find_pc_sect_line): Skip backward over end of sequence
markers when looking for a previous line.
gdb/testsuite/ChangeLog:
* gdb.dwarf2/dw2-inline-stepping.c: New file.
* gdb.dwarf2/dw2-inline-stepping.exp: New file.
Change-Id: Ia0309494be4cfd9dcc554f30209477f5f040b21b
2019-11-06 11:17:05 +01:00
|
|
|
|
2020-01-24 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* buildsym.c (lte_is_less_than): Delete.
|
|
|
|
|
|
(buildsym_compunit::end_symtab_with_blockvector): Create local
|
|
|
|
|
|
lambda function to sort line table entries, and use
|
|
|
|
|
|
std::stable_sort instead of std::sort.
|
|
|
|
|
|
* symtab.c (find_pc_sect_line): Skip backward over end of sequence
|
|
|
|
|
|
markers when looking for a previous line.
|
|
|
|
|
|
|
2019-11-05 17:00:26 +01:00
|
|
|
|
2020-01-24 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (lnp_state_machine::record_line): Include
|
|
|
|
|
|
end_sequence parameter in debug print out. Record the line if we
|
|
|
|
|
|
are at an end_sequence marker even if it's not the start of a
|
|
|
|
|
|
statement.
|
|
|
|
|
|
* symmisc.c (maintenance_print_one_line_table): Print end of
|
|
|
|
|
|
sequence markers with 'END' not '0'.
|
|
|
|
|
|
|
Fix re-runs of a second inferior (PR gdb/25410)
This fixes a latent bug exposed by the multi-target patch (5b6d1e4fa
"Multi-target support), and then fixes two other latent bugs exposed
by fixing that first latent bug.
The symptom described in the bug report is that starting a first
inferior, then trying to run a second (multi-threaded) inferior twice,
causes libthread_db to fail to load, along with other erratic
behavior:
(gdb) run
Starting program: /tmp/foo
warning: td_ta_new failed: generic error
Going a bit deeply, I found that if the two inferiors have different
symbols, we can see that just after inferior 2 exits, we are left with
inferior 2 selected, which is correct, but the symbols in scope belong
to inferior 1, which is obviously incorrect...
This problem is that there's a path in
scoped_restore_current_thread::restore() that switches to no thread
selected, and switches the current inferior, but leaves the current
program space as is, resulting in leaving the program space pointing
to the wrong program space (the one of the other inferior). This was
happening after handling TARGET_WAITKIND_NO_RESUMED, which is an event
that triggers after TARGET_WAITKIND_EXITED for the previous inferior
exit. Subsequent symbol lookups find the symbols of the wrong
inferior.
The fix is to use switch_to_inferior_no_thread in that problem spot.
This function was recently added along with the multi-target work
exactly for these situations.
As for testing, this patch adds a new testcase that tests symbol
printing just after inferior exit, which exercises the root cause of
the problem more directly. And then, to cover the use case described
in the bug too, it also exercises the lithread_db.so mis-loading, by
using TLS printing as a proxy for being sure that threaded debugging
was activated sucessfully. The testcase fails without the fix like
this, for the "print symbol just after exit" bits:
...
[Inferior 1 (process 8719) exited normally]
(gdb) PASS: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: continue until exit
print re_run_var_1
No symbol "re_run_var_1" in current context.
(gdb) FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: print re_run_var_1
...
And like this for the "libthread_db.so loading" bits:
(gdb) run
Starting program: /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.multi/multi-re-run/multi-re-run
warning: td_ta_new failed: generic error
[New LWP 27001]
Thread 1.1 "multi-re-run" hit Breakpoint 3, all_started () at /home/pedro/gdb/binutils-gdb/build/../src/gdb/testsuite/gdb.multi/multi-re-run.c:44
44 }
(gdb) PASS: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: running to all_started in runto
print tls_var
Cannot find thread-local storage for LWP 27000, executable file /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.multi/multi-re-run/multi-re-run:
Cannot find thread-local variables on this target
(gdb) FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: print tls_var
As mentioned, that fix above goes on to expose a couple other latent
bugs. This commit fixes those as well.
The first latent bug exposed is in
infrun.c:handle_vfork_child_exec_or_exit. The current code is leaving
inf->pspace == NULL while calling clone_program_space. The idea was
to make it so that the breakpoints module doesn't use this inferior's
pspace to set breakpoints. With that, any
scoped_restore_current_thread use from within clone_program_space
tries to restore a NULL program space, which hits an assertion:
Attaching after Thread 0x7ffff74b8700 (LWP 27276) vfork to child process 27277]
[New inferior 2 (process 27277)]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
/home/pedro/gdb/binutils-gdb/build/../src/gdb/progspace.c:243: internal-error: void set_current_program_space(program_space*): Assertion `pspace != NULL' faile
d.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) FAIL: gdb.threads/vfork-follow-child-exit.exp: detach-on-fork=off: continue (GDB internal error)
That NULL pspace idea was legitimate, but it's no longer necessary,
since commit b2e586e850db ("Defer breakpoint reset when cloning
progspace for fork child"). So the fix is to just set the inferior's
program space earlier.
The other latent bug exposed is in exec.c. When exec_close is called
from the program_space destructor, it is purposedly called with a
current program space that is not the current inferior's program
space. The problem is that the multi-target work added some code to
remove_target_sections that loops over all inferiors, and uses
scoped_restore_current_thread to save/restore the previous
thread/inferior/frame state. This makes it so that exec_close returns
with the current program space set to the current inferior's program
space, which is exactly what we did not want. Then the program_space
destructor continues into free_all_objfiles, but it is now running
that method on the wrong program space, resulting in:
Reading symbols from /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.threads/fork-plus-threads/fork-plus-threads...
Reading symbols from /usr/lib/debug/usr/lib64/libpthread-2.26.so.debug...
Reading symbols from /usr/lib/debug/usr/lib64/libm-2.26.so.debug...
Reading symbols from /usr/lib/debug/usr/lib64/libc-2.26.so.debug...
Reading symbols from /usr/lib/debug/usr/lib64/ld-2.26.so.debug...
[Inferior 3 (process 9583) exited normally]
/home/pedro/gdb/binutils-gdb/build/../src/gdb/progspace.c:170: internal-error: void program_space::free_all_objfiles(): Assertion `so->objfile == NULL' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: inferior 1 exited (GDB internal error)
The fix is to use scoped_restore_current_pspace_and_thread instead of
scoped_restore_current_thread.
gdb/ChangeLog:
2020-01-24 Pedro Alves <palves@redhat.com>
PR gdb/25410
* thread.c (scoped_restore_current_thread::restore): Use
switch_to_inferior_no_thread.
* exec.c: Include "progspace-and-thread.h".
(add_target_sections, remove_target_sections):
scoped_restore_current_pspace_and_thread instead of
scoped_restore_current_thread.
* infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
and aspace to the inferior before calling clone_program_space.
Remove stale comment.
gdb/testsuite/ChangeLog:
2020-01-24 Pedro Alves <palves@redhat.com>
PR gdb/25410
* gdb.multi/multi-re-run-1.c: New.
* gdb.multi/multi-re-run-2.c: New.
* gdb.multi/multi-re-run.exp: New.
2020-01-24 19:46:20 +01:00
|
|
|
|
2020-01-24 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/25410
|
|
|
|
|
|
* thread.c (scoped_restore_current_thread::restore): Use
|
|
|
|
|
|
switch_to_inferior_no_thread.
|
|
|
|
|
|
* exec.c: Include "progspace-and-thread.h".
|
|
|
|
|
|
(add_target_sections, remove_target_sections):
|
|
|
|
|
|
scoped_restore_current_pspace_and_thread instead of
|
|
|
|
|
|
scoped_restore_current_thread.
|
|
|
|
|
|
* infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
|
|
|
|
|
|
and aspace to the inferior before calling clone_program_space.
|
|
|
|
|
|
Remove stale comment.
|
|
|
|
|
|
|
2020-01-24 15:12:48 +01:00
|
|
|
|
2020-01-24 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
|
|
|
|
|
|
(arm_netbsd_nat_target::fetch_registers): ...this.
|
|
|
|
|
|
(arm_nbsd_nat_target::store_registers): Rename to...
|
|
|
|
|
|
(arm_netbsd_nat_target::store_registers): ...this.
|
|
|
|
|
|
|
2020-01-24 15:05:05 +01:00
|
|
|
|
2020-01-24 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
|
|
|
|
|
|
register_t.
|
|
|
|
|
|
|
2020-01-23 15:52:05 +01:00
|
|
|
|
2020-01-24 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
|
|
|
|
|
|
Update comment.
|
|
|
|
|
|
* aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
|
|
|
|
|
|
Likewise.
|
|
|
|
|
|
* arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
|
|
|
|
|
|
* gdbcore.h (deprecated_add_core_fns): Update comment to point to
|
|
|
|
|
|
the correct replacement (iterate_over_regset_sections).
|
|
|
|
|
|
* riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
|
|
|
|
|
|
Update comment.
|
|
|
|
|
|
|
gdb: Enable stdin on exception in execute_gdb_command
This is an update of this patch:
https://sourceware.org/ml/gdb-patches/2018-09/msg00884.html
This patch attempts to address PR gdb/23718 by re-enabling stdin
whenever an exception is caught during gdb.execute().
When Python gdb.execute() is called, an exception could occur (e.g. the
target disappearing), which is then converted into a Python exception. If
stdin was disabled before the exception is caught, it is not re-enabled,
because the exception doesn't propagate to the top level of the event loop,
whose catch block would otherwise enable it.
The result is that when execution of a Python script completes, GDB does
not prompt or accept input, and is effectively hung.
This change rectifies the issue by re-enabling stdin in the catch block of
execute_gdb_command, prior to converting the exception to a Python
exception.
Since this patch was originally posted I've added a test, and also I
converted the code to re-enable stdin from this:
SWITCH_THRU_ALL_UIS ()
{
async_enable_stdin ();
}
to simply this:
async_enable_stdin ();
My reasoning is that we only need the SWITCH_THRU_ALL_UIS if, at the time
the exception is caught, the current_ui might be different than at the time
we called async_disable_stdin. Within python's execute_gdb_command I think
it should be impossible to switch current_ui, so the SWITCH_THRU_ALL_UIS
isn't needed.
gdb/ChangeLog:
PR gdb/23718
* gdb/python/python.c (execute_gdb_command): Call
async_enable_stdin in catch block.
gdb/testsuite/ChangeLog:
PR gdb/23718
* gdb.server/server-kill-python.exp: New file.
Change-Id: I1cfc36ee9f8484cc1ed82be9be338353db6bc080
2019-11-19 12:17:20 +01:00
|
|
|
|
2020-01-24 Graham Markall <graham.markall@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR gdb/23718
|
|
|
|
|
|
* gdb/python/python.c (execute_gdb_command): Call
|
|
|
|
|
|
async_enable_stdin in catch block.
|
|
|
|
|
|
|
2019-11-19 19:09:43 +01:00
|
|
|
|
2020-01-24 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* event-loop.c (start_event_loop): Wrap async_enable_stdin with
|
|
|
|
|
|
SWITCH_THRU_ALL_UIS.
|
|
|
|
|
|
|
gdb/tui: asm window handles invalid memory and scrolls better
This started as a patch to enable the asm window to handle attempts to
disassemble invalid memory, but it ended up expanding into a
significant rewrite of how the asm window handles scrolling. These
two things ended up being tied together as it was impossible to
correctly test scrolling into invalid memory when the asm window would
randomly behave weirdly while scrolling.
Things that should work nicely now; scrolling to the bottom or top of
the listing with PageUp, PageDown, Up Arrow, Down Arrow and we should
be able to scroll past small areas of memory that don't have symbols
associated with them. It should also be possible to scroll to the
start of a section even if there's no symbol at the start of the
section.
Adding tests for this scrolling was a little bit of a problem. First
I would have liked to add tests for PageUp / PageDown, but the tuiterm
library we use doesn't support these commands right now due to only
emulating a basic ascii terminal. Changing this to emulate a more
complex terminal would require adding support for more escape sequence
control codes, so I've not tried to tackle that in this patch.
Next, I would have liked to test scrolling to the start or end of the
assembler listing and then trying to scroll even more, however, this
is a problem because in a well behaving GDB a scroll at the start/end
has no effect. What we need to do is:
- Move to start of assembler listing,
- Send scroll up command,
- Wait for all curses output,
- Ensure the assembler listing is unchanged, we're still at the
start of the listing.
The problem is that there is no curses output, so how long do we wait
at step 3? The same problem exists for scrolling to the bottom of the
assembler listing. However, when scrolling down you can at least see
the end coming, so I added a test for this case, however, this feels
like an area of code that is massively under tested.
gdb/ChangeLog:
PR tui/9765
* minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
comment, add extra parameter, and update to store previous symbol
when appropriate.
* minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
add extra parameter.
* tui/tui-disasm.c (tui_disassemble): Update header comment,
remove unneeded parameter, add try/catch around gdb_print_insn,
rewrite to add items to asm_lines vector.
(tui_find_backward_disassembly_start_address): New function.
(tui_find_disassembly_address): Updated throughout.
(tui_disasm_window::set_contents): Update for changes to
tui_disassemble.
(tui_disasm_window::do_scroll_vertical): No need to adjust the
number of lines to scroll.
gdb/testsuite/ChangeLog:
PR tui/9765
* gdb.tui/tui-layout-asm.exp: Add scrolling test for asm window.
Change-Id: I323987c8fd316962c937e73c17d952ccd3cfa66c
2020-01-11 02:38:28 +01:00
|
|
|
|
2020-01-24 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR tui/9765
|
|
|
|
|
|
* minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
|
|
|
|
|
|
comment, add extra parameter, and update to store previous symbol
|
|
|
|
|
|
when appropriate.
|
|
|
|
|
|
* minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
|
|
|
|
|
|
add extra parameter.
|
|
|
|
|
|
* tui/tui-disasm.c (tui_disassemble): Update header comment,
|
|
|
|
|
|
remove unneeded parameter, add try/catch around gdb_print_insn,
|
|
|
|
|
|
rewrite to add items to asm_lines vector.
|
|
|
|
|
|
(tui_find_backward_disassembly_start_address): New function.
|
|
|
|
|
|
(tui_find_disassembly_address): Updated throughout.
|
|
|
|
|
|
(tui_disasm_window::set_contents): Update for changes to
|
|
|
|
|
|
tui_disassemble.
|
|
|
|
|
|
(tui_disasm_window::do_scroll_vertical): No need to adjust the
|
|
|
|
|
|
number of lines to scroll.
|
|
|
|
|
|
|
2020-01-23 23:55:35 +01:00
|
|
|
|
2020-01-23 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
|
|
|
|
|
|
(SECT_OFF_DATA): Likewise.
|
|
|
|
|
|
(SECT_OFF_RODATA): Likewise.
|
|
|
|
|
|
(SECT_OFF_TEXT): Likewise.
|
|
|
|
|
|
(SECT_OFF_BSS): Likewise.
|
|
|
|
|
|
(struct objfile) <text_section_offset, data_section_offset>: New
|
|
|
|
|
|
methods.
|
|
|
|
|
|
* amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
|
|
|
|
|
|
objfile::text_section_offset.
|
|
|
|
|
|
* coff-pe-read.c (add_pe_forwarded_sym): Likewise.
|
|
|
|
|
|
* coffread.c (coff_symtab_read): Likewise.
|
|
|
|
|
|
(enter_linenos): Likewise.
|
|
|
|
|
|
(process_coff_symbol): Likewise.
|
|
|
|
|
|
* ctfread.c (get_objfile_text_range): Likewise.
|
|
|
|
|
|
* dtrace-probe.c (dtrace_probe::get_relocated_address):
|
|
|
|
|
|
Use objfile::data_section_offset.
|
|
|
|
|
|
* dwarf2-frame.c (execute_cfa_program): Use
|
|
|
|
|
|
objfile::text_section_offset.
|
|
|
|
|
|
(dwarf2_frame_find_fde): Likewise.
|
|
|
|
|
|
* dwarf2read.c (create_addrmap_from_index): Likewise.
|
|
|
|
|
|
(create_addrmap_from_aranges): Likewise.
|
|
|
|
|
|
(dw2_find_pc_sect_compunit_symtab): Likewise.
|
|
|
|
|
|
(process_psymtab_comp_unit_reader): Likewise.
|
|
|
|
|
|
(add_partial_symbol): Likewise.
|
|
|
|
|
|
(add_partial_subprogram): Likewise.
|
|
|
|
|
|
(process_full_comp_unit): Likewise.
|
|
|
|
|
|
(read_file_scope): Likewise.
|
|
|
|
|
|
(read_func_scope): Likewise.
|
|
|
|
|
|
(read_lexical_block_scope): Likewise.
|
|
|
|
|
|
(read_call_site_scope): Likewise.
|
|
|
|
|
|
(dwarf2_rnglists_process): Likewise.
|
|
|
|
|
|
(dwarf2_ranges_process): Likewise.
|
|
|
|
|
|
(dwarf2_ranges_read): Likewise.
|
|
|
|
|
|
(dwarf_decode_lines_1): Likewise.
|
|
|
|
|
|
(new_symbol): Likewise.
|
|
|
|
|
|
(dwarf2_fetch_die_loc_sect_off): Likewise.
|
|
|
|
|
|
(dwarf2_per_cu_text_offset): Likewise.
|
|
|
|
|
|
* hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
|
|
|
|
|
|
* hppa-tdep.c (read_unwind_info): Likewise.
|
|
|
|
|
|
* ia64-tdep.c (ia64_find_unwind_table): Likewise.
|
|
|
|
|
|
* psympriv.h (struct partial_symtab): Likewise.
|
|
|
|
|
|
* psymtab.c (find_pc_sect_psymtab): Likewise.
|
|
|
|
|
|
* solib-svr4.c (enable_break): Likewise.
|
|
|
|
|
|
* stap-probe.c (relocate_address): Use
|
|
|
|
|
|
objfile::data_section_offset.
|
|
|
|
|
|
* xcoffread.c (enter_line_range): Use
|
|
|
|
|
|
objfile::text_section_offset.
|
|
|
|
|
|
(read_xcoff_symtab): Likewise.
|
|
|
|
|
|
|
2020-01-23 23:44:22 +01:00
|
|
|
|
2020-01-23 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
|
|
|
|
|
|
declaration to narrower scopes.
|
|
|
|
|
|
|
gdb: fix darwin-nat.c build / adapt to multi-target
The darwin-nat.c file doesn't build since the multi-target changes
(5b6d1e4f, "Multi-target support"). This patch makes it build. I have
access to a macOS vm, so I am able to build it, but I wasn't able to
successfully codesign it and try to actually debug something, so I don't
know if it works. I don't have much more time to put on this to figure
it out, so I thought I'd sent the patch anyway, as it's at least a step
in the right direction.
The bulk of the patch is to change a bunch of functions to be methods of
the darwin_nat_target object, so that this can pass `this` to
find_inferior_ptid and other functions that now require a
process_stratum_target pointer.
The darwin_ptrace_him function (renamed to darwin_nat_target::ptrace_him
in this patch) is passed to fork_inferior as the `init_trace_fun`
parameter. Since the method can't be passed as a plain function pointer
(we need the `this` pointer), I changed the `init_trace_fun` parameter
of fork_inferior to be a gdb::function_view, so we can pass a lambda and
capture `this`.
The changes in darwin-nat.h are only to move definition higher in the
file, so that forward declarations are not needed.
gdb/ChangeLog:
* darwin-nat.h (struct darwin_exception_msg, enum
darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
Move up.
(class darwin_nat_target) <wait_1, check_new_threads,
decode_exception_message, decode_message, stop_inferior,
init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
* darwin-nat.c (darwin_check_new_threads): Rename to...
(darwin_nat_target::check_new_threads): ... this.
(darwin_suspend_inferior_it): Remove.
(darwin_decode_exception_message): Rename to...
(darwin_nat_target::decode_exception_message): ... this.
(darwin_nat_target::resume): Pass target to find_inferior_ptid.
(darwin_decode_message): Rename to...
(darwin_nat_target::decode_message): ... this.
(cancel_breakpoint): Rename to...
(darwin_nat_target::cancel_breakpoint): ... this.
(darwin_wait): Rename to...
(darwin_nat_target::wait_1): ... this. Use range-based for loop
instead of iterate_over_inferiors.
(darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
(darwin_stop_inferior): Rename to...
(darwin_nat_target::stop_inferior): ... this.
(darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
(darwin_init_thread_list): Rename to...
(darwin_nat_target::init_thread_list): ... this.
(darwin_ptrace_him): Rename to...
(darwin_nat_target::ptrace_him): ... this.
(darwin_nat_target::create_inferior): Pass lambda function to
fork_inferior.
(darwin_nat_target::detach): Call stop_inferior instead of
darwin_stop_inferior.
* fork-inferior.h (fork_inferior): Change init_trace_fun
parameter to gdb::function_view.
* fork-inferior.c (fork_inferior): Likewise.
2020-01-23 20:55:50 +01:00
|
|
|
|
2020-01-23 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* darwin-nat.h (struct darwin_exception_msg, enum
|
|
|
|
|
|
darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
|
|
|
|
|
|
Move up.
|
|
|
|
|
|
(class darwin_nat_target) <wait_1, check_new_threads,
|
|
|
|
|
|
decode_exception_message, decode_message, stop_inferior,
|
|
|
|
|
|
init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
|
|
|
|
|
|
* darwin-nat.c (darwin_check_new_threads): Rename to...
|
|
|
|
|
|
(darwin_nat_target::check_new_threads): ... this.
|
|
|
|
|
|
(darwin_suspend_inferior_it): Remove.
|
|
|
|
|
|
(darwin_decode_exception_message): Rename to...
|
|
|
|
|
|
(darwin_nat_target::decode_exception_message): ... this.
|
|
|
|
|
|
(darwin_nat_target::resume): Pass target to find_inferior_ptid.
|
|
|
|
|
|
(darwin_decode_message): Rename to...
|
|
|
|
|
|
(darwin_nat_target::decode_message): ... this.
|
|
|
|
|
|
(cancel_breakpoint): Rename to...
|
|
|
|
|
|
(darwin_nat_target::cancel_breakpoint): ... this.
|
|
|
|
|
|
(darwin_wait): Rename to...
|
|
|
|
|
|
(darwin_nat_target::wait_1): ... this. Use range-based for loop
|
|
|
|
|
|
instead of iterate_over_inferiors.
|
|
|
|
|
|
(darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
|
|
|
|
|
|
(darwin_stop_inferior): Rename to...
|
|
|
|
|
|
(darwin_nat_target::stop_inferior): ... this.
|
|
|
|
|
|
(darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
|
|
|
|
|
|
(darwin_init_thread_list): Rename to...
|
|
|
|
|
|
(darwin_nat_target::init_thread_list): ... this.
|
|
|
|
|
|
(darwin_ptrace_him): Rename to...
|
|
|
|
|
|
(darwin_nat_target::ptrace_him): ... this.
|
|
|
|
|
|
(darwin_nat_target::create_inferior): Pass lambda function to
|
|
|
|
|
|
fork_inferior.
|
|
|
|
|
|
(darwin_nat_target::detach): Call stop_inferior instead of
|
|
|
|
|
|
darwin_stop_inferior.
|
|
|
|
|
|
* fork-inferior.h (fork_inferior): Change init_trace_fun
|
|
|
|
|
|
parameter to gdb::function_view.
|
|
|
|
|
|
* fork-inferior.c (fork_inferior): Likewise.
|
|
|
|
|
|
|
2019-12-21 17:08:14 +01:00
|
|
|
|
2020-01-23 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* i386-cygwin-tdep.c (core_process_module_section): Update.
|
|
|
|
|
|
* windows-nat.c (struct lm_info_windows): Add text_offset.
|
|
|
|
|
|
(windows_xfer_shared_libraries): Update.
|
|
|
|
|
|
* windows-tdep.c (windows_xfer_shared_library):
|
|
|
|
|
|
Add text_offset_cached argument.
|
|
|
|
|
|
* windows-tdep.h (windows_xfer_shared_library): Update.
|
|
|
|
|
|
|
2020-01-22 00:30:07 +01:00
|
|
|
|
2020-01-21 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbarch.sh: Add declaration for _initialize_gdbarch.
|
|
|
|
|
|
|
2020-01-21 22:28:25 +01:00
|
|
|
|
2020-01-21 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
|
|
|
|
|
|
(get_sim_inferior_data): Remove use of iterate_over_inferiors,
|
|
|
|
|
|
replace with range-based for.
|
|
|
|
|
|
(gdbsim_interrupt_inferior): Remove.
|
|
|
|
|
|
(gdbsim_target::interrupt): Replace iterate_over_inferiors use
|
|
|
|
|
|
with a range-based for. Inline code from
|
|
|
|
|
|
gdbsim_interrupt_inferior.
|
|
|
|
|
|
|
2020-01-21 22:04:51 +01:00
|
|
|
|
2020-01-21 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infrun.c (proceed): Fix indentation.
|
|
|
|
|
|
|
Allow use of Pygments to colorize source code
While GNU Source Highlight is good, it's also difficult to build and
distribute. For one thing, it needs Boost. For another, it has an
unusual configuration and installation setup.
Pygments, a Python library, doesn't suffer from these issues, and so I
thought it would be a reasonable fallback.
This patch implements this idea. GNU Source Highlight is preferred,
but if it is unavailable (or fails), the extension languages are
tried. This patch also implements support for Pygments.
Something similar could be done for Guile, using:
https://dthompson.us/projects/guile-syntax-highlight.html
However, I don't know enough about Guile internals to make this
happen, so I have not done it here.
gdb/ChangeLog
2020-01-21 Tom Tromey <tromey@adacore.com>
* source-cache.c (source_cache::ensure): Call ext_lang_colorize.
* python/python.c (python_extension_ops): Update.
(gdbpy_colorize): New function.
* python/lib/gdb/__init__.py (colorize): New function.
* extension.h (ext_lang_colorize): Declare.
* extension.c (ext_lang_colorize): New function.
* extension-priv.h (struct extension_language_ops) <colorize>: New
member.
* cli/cli-style.c (_initialize_cli_style): Update help text.
Change-Id: I5e21623ee05f1f66baaa6deaeca78b578c031bf4
2020-01-03 21:59:27 +01:00
|
|
|
|
2020-01-21 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* source-cache.c (source_cache::ensure): Call ext_lang_colorize.
|
|
|
|
|
|
* python/python.c (python_extension_ops): Update.
|
|
|
|
|
|
(gdbpy_colorize): New function.
|
|
|
|
|
|
* python/lib/gdb/__init__.py (colorize): New function.
|
|
|
|
|
|
* extension.h (ext_lang_colorize): Declare.
|
|
|
|
|
|
* extension.c (ext_lang_colorize): New function.
|
|
|
|
|
|
* extension-priv.h (struct extension_language_ops) <colorize>: New
|
|
|
|
|
|
member.
|
|
|
|
|
|
* cli/cli-style.c (_initialize_cli_style): Update help text.
|
|
|
|
|
|
|
2020-01-09 20:24:15 +01:00
|
|
|
|
2020-01-21 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-tdep.c (struct aarch64_displaced_step_closure)
|
|
|
|
|
|
<cond>: Change type to bool.
|
|
|
|
|
|
(aarch64_displaced_step_b_cond): Update cond to use bool type.
|
|
|
|
|
|
(aarch64_displaced_step_cb): Likewise.
|
|
|
|
|
|
(aarch64_displaced_step_tb): Likewise.
|
|
|
|
|
|
|
2020-01-09 20:19:31 +01:00
|
|
|
|
2020-01-21 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
|
|
|
|
|
|
output.
|
|
|
|
|
|
|
2020-01-09 20:04:36 +01:00
|
|
|
|
2020-01-21 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-tdep.c (struct aarch64_displaced_step_closure )
|
|
|
|
|
|
<pc_adjust>: Adjust the documentation.
|
|
|
|
|
|
(aarch64_displaced_step_fixup): Check if PC really moved before
|
|
|
|
|
|
adjusting it.
|
|
|
|
|
|
|
2020-01-11 19:40:45 +01:00
|
|
|
|
2020-01-19 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* disasm.c (~gdb_disassembler): New destructor.
|
|
|
|
|
|
(gdb_buffered_insn_length): Call disassemble_free_target.
|
|
|
|
|
|
* disasm.h (class gdb_disassembler): Declare destructor. Use
|
|
|
|
|
|
DISABLE_COPY_AND_ASSIGN.
|
|
|
|
|
|
|
2020-01-11 23:56:10 +01:00
|
|
|
|
2020-01-19 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (abbrev_table_up): Move typedef earlier.
|
|
|
|
|
|
(die_reader_func_ftype): Remove.
|
|
|
|
|
|
(cutu_reader): New class.
|
|
|
|
|
|
(dw2_get_file_names_reader): Remove "data" parameter.
|
|
|
|
|
|
(dw2_get_file_names): Use cutu_reader.
|
|
|
|
|
|
(create_debug_type_hash_table): Update.
|
|
|
|
|
|
(read_cutu_die_from_dwo): Update comment.
|
|
|
|
|
|
(lookup_dwo_unit): Add dwo_name parameter.
|
|
|
|
|
|
(cutu_reader::init_tu_and_read_dwo_dies): Now a method. Remove
|
|
|
|
|
|
die_reader_func_ftype and data parameters.
|
|
|
|
|
|
(cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
|
|
|
|
|
|
Remove die_reader_func_ftype and data parameters.
|
|
|
|
|
|
(~cutu_reader): New; from init_cutu_and_read_dies.
|
|
|
|
|
|
(cutu_reader::cutu_reader): Rename from
|
|
|
|
|
|
init_cutu_and_read_dies_no_follow. Remove die_reader_func_ftype
|
|
|
|
|
|
and data parameters.
|
|
|
|
|
|
(init_cutu_and_read_dies_simple): Remove.
|
|
|
|
|
|
(struct process_psymtab_comp_unit_data): Remove.
|
|
|
|
|
|
(process_psymtab_comp_unit_reader): Remove data parameter; add
|
|
|
|
|
|
want_partial_unit and pretend_language parameters.
|
|
|
|
|
|
(process_psymtab_comp_unit): Use cutu_reader.
|
|
|
|
|
|
(build_type_psymtabs_reader): Remove data parameter.
|
|
|
|
|
|
(build_type_psymtabs_1): Use cutu_reader.
|
|
|
|
|
|
(process_skeletonless_type_unit): Likewise.
|
|
|
|
|
|
(load_partial_comp_unit_reader): Remove.
|
|
|
|
|
|
(load_partial_comp_unit): Use cutu_reader.
|
|
|
|
|
|
(load_full_comp_unit_reader): Remove.
|
|
|
|
|
|
(load_full_comp_unit): Use cutu_reader.
|
|
|
|
|
|
(struct create_dwo_cu_data): Remove.
|
|
|
|
|
|
(create_dwo_cu_reader): Remove datap parameter; add dwo_file and
|
|
|
|
|
|
dwo_unit parameters.
|
|
|
|
|
|
(create_cus_hash_table): Use cutu_reader.
|
|
|
|
|
|
(struct dwarf2_read_addr_index_data): Remove.
|
|
|
|
|
|
(dwarf2_read_addr_index_reader): Remove.
|
|
|
|
|
|
(dwarf2_read_addr_index): Use cutu_reader.
|
|
|
|
|
|
(read_signatured_type_reader): Remove.
|
|
|
|
|
|
(read_signatured_type): Use cutu_reader.
|
|
|
|
|
|
|
2019-12-27 16:47:41 +01:00
|
|
|
|
2020-01-19 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui.c (tui_show_assembly): Use tui_suppress_output.
|
|
|
|
|
|
* tui/tui-wingeneral.h (class tui_suppress_output): New.
|
|
|
|
|
|
(tui_wrefresh): Declare.
|
|
|
|
|
|
* tui/tui-wingeneral.c (suppress_output): New global.
|
|
|
|
|
|
(tui_suppress_output, ~tui_suppress_output): New constructor and
|
|
|
|
|
|
destructor.
|
|
|
|
|
|
(tui_wrefresh): New function.
|
|
|
|
|
|
(tui_gen_win_info::refresh_window): Use tui_wrefresh.
|
|
|
|
|
|
(tui_gen_win_info::make_window): Call wnoutrefresh when needed.
|
|
|
|
|
|
* tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
|
|
|
|
|
|
method.
|
|
|
|
|
|
* tui/tui-regs.c (tui_data_window::erase_data_content): Call
|
|
|
|
|
|
tui_wrefresh.
|
|
|
|
|
|
(tui_data_window::no_refresh): New method.
|
|
|
|
|
|
(tui_data_item_window::refresh_window): Call tui_wrefresh.
|
|
|
|
|
|
(tui_reg_command): Use tui_suppress_output
|
|
|
|
|
|
* tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
|
|
|
|
|
|
* tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
|
|
|
|
|
|
method.
|
|
|
|
|
|
* tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
|
|
|
|
|
|
|
2019-12-21 19:14:56 +01:00
|
|
|
|
2020-01-19 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-winsource.c (tui_update_source_windows_with_line):
|
|
|
|
|
|
Handle case where symtab is null.
|
|
|
|
|
|
|
2020-01-19 17:54:02 +01:00
|
|
|
|
2020-01-19 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* linux-fork.c (one_fork_p): Simplify.
|
|
|
|
|
|
|
2020-01-17 15:58:57 +01:00
|
|
|
|
2020-01-17 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* top.c (struct qt_args): Remove.
|
|
|
|
|
|
(kill_or_detach): Change return type to void, replace `void *`
|
|
|
|
|
|
parameter with a proper one.
|
|
|
|
|
|
(print_inferior_quit_action): Likewise.
|
|
|
|
|
|
(quit_confirm): Use range-based for loop to iterate over inferiors.
|
|
|
|
|
|
(quit_force): Likewise.
|
|
|
|
|
|
|
2020-01-17 15:57:58 +01:00
|
|
|
|
2020-01-17 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* mi/mi-main.c (run_one_inferior): Change return type to void, replace
|
|
|
|
|
|
`void *` parameter with proper parameters.
|
|
|
|
|
|
(mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
|
|
|
|
|
|
(print_one_inferior): Change return type to void, replace `void *`
|
|
|
|
|
|
parameter with proper parameters.
|
|
|
|
|
|
(mi_cmd_list_thread_groups): Use range-based loop to iterate over
|
|
|
|
|
|
inferiors.
|
|
|
|
|
|
(get_other_inferior): Remove.
|
|
|
|
|
|
(mi_cmd_remove_inferior): Use range-based loop to iterate over
|
|
|
|
|
|
inferiors.
|
|
|
|
|
|
|
2020-01-17 15:57:07 +01:00
|
|
|
|
2020-01-17 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* mi/mi-interp.c (report_initial_inferior): Remove.
|
|
|
|
|
|
(mi_interp::init): Use range-based for to iterate over inferiors.
|
|
|
|
|
|
|
2020-01-17 15:51:10 +01:00
|
|
|
|
2020-01-17 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* python/py-inferior.c (build_inferior_list): Remove.
|
|
|
|
|
|
(gdbpy_ref): Use range-based for loop to iterate over inferiors.
|
|
|
|
|
|
|
2020-01-16 23:41:53 +01:00
|
|
|
|
2020-01-16 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
|
|
|
|
|
|
(btrace_stitch_trace): Likewise.
|
|
|
|
|
|
* charset.c (intermediate_encoding): Likewise (vaild).
|
|
|
|
|
|
* nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
|
|
|
|
|
|
* python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
|
|
|
|
|
|
* record-btrace.c (record_btrace_print_conf): Likewise (unkown).
|
|
|
|
|
|
|
2019-12-23 16:38:13 +01:00
|
|
|
|
2020-01-16 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-tdep.c (windows_get_tlb_type):
|
|
|
|
|
|
Add rtl_user_process_parameters type.
|
|
|
|
|
|
|
Ensure proc-service symbols have default visibility (PR build/24805)
Compiling GDB with '-fvisibility=hidden' removes the symbols that
should be exported.
This patch explicitly marks them as visible.
gdb/ChangeLog:
2020-01-16 Pedro Alves <palves@redhat.com>
Norbert Lange <nolange79@gmail.com>
PR build/24805
* gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
(ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
(ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
(ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
(ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
(ps_plog): Redeclare exported functions with default visibility.
2020-01-16 19:35:30 +01:00
|
|
|
|
2020-01-16 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
Norbert Lange <nolange79@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR build/24805
|
|
|
|
|
|
* gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
|
|
|
|
|
|
(ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
|
|
|
|
|
|
(ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
|
|
|
|
|
|
(ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
|
|
|
|
|
|
(ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
|
|
|
|
|
|
(ps_plog): Redeclare exported functions with default visibility.
|
|
|
|
|
|
|
2020-01-16 17:51:06 +01:00
|
|
|
|
2020-01-16 Nitika Achra <Nitika.Achra@amd.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2loc.c (decode_debug_loclists_addresses): Handle
|
|
|
|
|
|
DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
|
|
|
|
|
|
|
2020-01-15 18:47:44 +01:00
|
|
|
|
2020-01-15 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infcmd.c (post_create_inferior): Use get_thread_regcache
|
|
|
|
|
|
instead of get_current_regcache.
|
|
|
|
|
|
|
2019-12-21 17:51:05 +01:00
|
|
|
|
2020-01-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR symtab/12535:
|
|
|
|
|
|
* python/python.c (gdbpy_decode_line): Treat empty string the same
|
|
|
|
|
|
as no argument.
|
|
|
|
|
|
|
2020-01-09 01:43:29 +01:00
|
|
|
|
2020-01-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
|
|
|
|
|
|
|
2019-12-20 01:49:25 +01:00
|
|
|
|
2020-01-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* nat/linux-btrace.c: Don't include <config.h>.
|
|
|
|
|
|
* nat/linux-ptrace.c: Don't include <config.h>.
|
|
|
|
|
|
* nat/x86-linux-dregs.c: Don't include <config.h>.
|
|
|
|
|
|
|
Move many configure checks to common.m4
This moves many needed configure checks from gdb and gdbserver into
common.m4. This helps gdbsupport, nat, and target be self-contained.
The result is a bit spaghetti-ish, because gdbsupport uses another m4
file from gdb/. The resulting code is somewhat non-obvious. However,
these problems already exist, so it's not really that much worse than
what is already done.
gdb/ChangeLog
2020-01-14 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
* configure.ac: Move many checks to ../gdbsupport/common.m4.
gdb/gdbserver/ChangeLog
2020-01-14 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
* configure.ac: Remove any checks that were added to common.m4.
* acinclude.m4: Include lib-ld.m4, lib-prefix.m4, and
lib-link.m4.
gdbsupport/ChangeLog
2020-01-14 Tom Tromey <tom@tromey.com>
* configure, Makefile.in, aclocal.m4, common.m4, config.in:
Rebuild.
* common.m4 (GDB_AC_COMMON): Move many checks from
gdb/configure.ac.
* acinclude.m4: Include bfd.m4, ptrace.m4.
Change-Id: I931eaa94065df268b30a2f1354390710df89c7f8
2019-12-20 00:40:15 +01:00
|
|
|
|
2020-01-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* configure: Rebuild.
|
|
|
|
|
|
* configure.ac: Move many checks to ../gdbsupport/common.m4.
|
|
|
|
|
|
|
Move gdbsupport to the top level
This patch moves the gdbsupport directory to the top level. This is
the next step in the ongoing project to move gdbserver to the top
level.
The bulk of this patch was created by "git mv gdb/gdbsupport gdbsupport".
This patch then adds a build system to gdbsupport and wires it into
the top level. Then it changes gdb to use the top-level build.
gdbserver, on the other hand, is not yet changed. It still does its
own build of gdbsupport.
ChangeLog
2020-01-14 Tom Tromey <tom@tromey.com>
* src-release.sh (GDB_SUPPORT_DIRS): Add gdbsupport.
* MAINTAINERS: Add gdbsupport.
* configure: Rebuild.
* configure.ac (configdirs): Add gdbsupport.
* gdbsupport: New directory, move from gdb/gdbsupport.
* Makefile.def (host_modules, dependencies): Add gnulib.
* Makefile.in: Rebuild.
gdb/ChangeLog
2020-01-14 Tom Tromey <tom@tromey.com>
* nat/x86-linux-dregs.c: Include configh.h.
* nat/linux-ptrace.c: Include configh.h.
* nat/linux-btrace.c: Include configh.h.
* defs.h: Include config.h, bfd.h.
* configure.ac: Don't source common.host.
(CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
* configure: Rebuild.
* acinclude.m4: Update path.
* Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
(CONFIG_SRC_SUBDIR): Remove gdbsupport.
(INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
(CLIBS): Add LIBSUPPORT.
(CDEPS): Likewise.
(COMMON_SFILES): Remove gdbsupport files.
(HFILES_NO_SRCDIR): Likewise.
(stamp-version): Update path to create-version.sh.
(ALLDEPFILES): Remove gdbsupport files.
gdb/gdbserver/ChangeLog
2020-01-14 Tom Tromey <tom@tromey.com>
* server.h: Include config.h.
* gdbreplay.c: Include config.h.
* configure: Rebuild.
* configure.ac: Don't source common.host.
* acinclude.m4: Update path.
* Makefile.in (INCSUPPORT): New variable.
(INCLUDE_CFLAGS): Add INCSUPPORT.
(SFILES): Update paths.
(version-generated.c): Update path to create-version.sh.
(gdbsupport/%-ipa.o, gdbsupport/%.o): Update paths.
gdbsupport/ChangeLog
2020-01-14 Tom Tromey <tom@tromey.com>
* common-defs.h: Add GDBSERVER case. Update includes.
* acinclude.m4, aclocal.m4, config.in, configure, configure.ac,
Makefile.am, Makefile.in, README: New files.
* Moved from ../gdb/gdbsupport/
Change-Id: I07632e7798635c1bab389bf885971e584fb4bb78
2019-07-09 16:06:39 +02:00
|
|
|
|
2020-01-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* nat/x86-linux-dregs.c: Include configh.h.
|
|
|
|
|
|
* nat/linux-ptrace.c: Include configh.h.
|
|
|
|
|
|
* nat/linux-btrace.c: Include configh.h.
|
|
|
|
|
|
* defs.h: Include config.h, bfd.h.
|
|
|
|
|
|
* configure.ac: Don't source common.host.
|
|
|
|
|
|
(CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
|
|
|
|
|
|
* configure: Rebuild.
|
|
|
|
|
|
* acinclude.m4: Update path.
|
|
|
|
|
|
* Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
|
|
|
|
|
|
(CONFIG_SRC_SUBDIR): Remove gdbsupport.
|
|
|
|
|
|
(INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
|
|
|
|
|
|
(CLIBS): Add LIBSUPPORT.
|
|
|
|
|
|
(CDEPS): Likewise.
|
|
|
|
|
|
(COMMON_SFILES): Remove gdbsupport files.
|
|
|
|
|
|
(HFILES_NO_SRCDIR): Likewise.
|
|
|
|
|
|
(stamp-version): Update path to create-version.sh.
|
|
|
|
|
|
(ALLDEPFILES): Remove gdbsupport files.
|
|
|
|
|
|
|
2019-10-23 00:22:58 +02:00
|
|
|
|
2020-01-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
|
|
|
|
|
|
USE_WIN32API when needed.
|
|
|
|
|
|
* configure.ac (USE_WIN32API): Don't define.
|
|
|
|
|
|
(WIN32LIBS): Use WIN32APILIBS.
|
|
|
|
|
|
* configure: Rebuild.
|
|
|
|
|
|
|
2020-01-15 00:16:39 +01:00
|
|
|
|
2020-01-14 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* configure: Rebuild.
|
|
|
|
|
|
* gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
|
|
|
|
|
|
|
2019-12-25 16:35:32 +01:00
|
|
|
|
2020-01-14 Bernd Edlinger <bernd.edlinger@hotmail.de>
|
|
|
|
|
|
|
|
|
|
|
|
* skip.c (skip_function_command): Make skip w/o arguments use the
|
|
|
|
|
|
name of the inlined function if pc is inside any inlined function.
|
|
|
|
|
|
|
2019-12-06 22:12:37 +01:00
|
|
|
|
2020-01-14 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* inf-ptrace.c (inf_ptrace_target::resume): Update comments.
|
|
|
|
|
|
* infrun.c (resume_1): Likewise.
|
|
|
|
|
|
(handle_inferior_event): Remove stale comment.
|
|
|
|
|
|
* linux-nat.c (linux_nat_target::resume): Update comments.
|
|
|
|
|
|
(save_stop_reason): Likewise.
|
|
|
|
|
|
(linux_nat_filter_event): Likewise.
|
|
|
|
|
|
* linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
|
|
|
|
|
|
|
gdb: Handle malformed ELF, symbols in non-allocatable sections
I ended up debugging a malformed ELF where a section containing
executable code was not correctly marked as allocatable. Before
realising the ELF was corrupted I tried to place a breakpoint on a
symbol in the non-allocatable, executable section, and GDB crashed.
Though trying to debug such an ELF clearly isn't going to go well I
would prefer, as far as possible, that any input, no matter how
corrupted, not crash GDB.
The crash occurs when trying to set a breakpoint on the name of a
function from the corrupted section. GDB converts the symbol to a
symtab_and_line, and looks up a suitable section for this.
The problem is that the section is actually an obj_section, which is
stored in the table within the objfile, and we only initialise this
table for allocatable sections (see add_to_objfile_sections_full in
objfiles.c). So, if the symbol is in a non-allocatable section then
we end up referencing an uninitialised obj_section.
Later we call get_sal_arch on the symtab_and_line, which calls
get_objfile_arch, which uses the objfile from the uninitialised
obj_section, which will be nullptr, at which point GDB crashes.
The fix I propose here is that when we setup the section references on
msymbols, we should check if the bfd_section being referenced is
allocatable or not. If it is not then we should set the section
reference back to the default 0 section (see how MSYMBOL_OBJ_SECTION
and SYMBOL_OBJ_SECTION treat the 0 section index).
With this fix in place GDB no longer crashes. Instead GDB creates the
breakpoint at the non-allocated address, and then fails, with an
error, when it tries to insert the breakpoint.
gdb/ChangeLog:
* elfread.c (record_minimal_symbol): Set section index to 0 for
non-allocatable sections.
gdb/testsuite/ChangeLog:
* gdb.dwarf2/dw2-bad-elf-other.S: New file.
* gdb.dwarf2/dw2-bad-elf.c: New file.
* gdb.dwarf2/dw2-bad-elf.exp: New file.
Change-Id: Ie05436ab4c6a71440304d20ee639dfb021223f8b
2019-12-07 00:12:29 +01:00
|
|
|
|
2020-01-13 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* elfread.c (record_minimal_symbol): Set section index to 0 for
|
|
|
|
|
|
non-allocatable sections.
|
|
|
|
|
|
|
Dwarf 5: Handle debug_str_offsets and indexed attributes that have base offsets.
* Process debug_str_offsets section. Handle DW_AT_str_offsets_base attribute and
keep the value in dwarf2_cu.
* Make addr_base field in dwarf2_cu optional to disambiguate 0 value
(absent or present and 0).
* During parsing, there is no guarantee that DW_AT_str_offsets_base and
DW_AT_rnglists_base fields will be processed before the attributes that need
those values for correct computation. So make two passes, on the first one mark
the attributes that depend on *_base attributes and process only the others.
On the second pass, only process the attributes that are marked on the first
pass.
* For string attributes, differentiate between addresses that directly point to
a string and those that point to an offset in debug_str_offsets section.
* There are now two attributes, DW_AT_addr_base and DW_AT_GNU_addr_base to read
address offset base. Likewise, there are two attributes, DW_AT_rnglists_base
and DW_AT_GNU_ranges_base to read ranges base. Since there is no guarantee which
ones the compiler will generate, create helper functions to handle all cases.
Tested with CC=/usr/bin/gcc (version 8.3.0) against master branch (also with
-gsplit-dwarf and -gdwarf-4 flags) and there was no increase in the set of
tests that fails. (gdb still cannot debug a 'hello world' program with DWARF 5,
so for the time being, this is all we care about).
This is part of an effort to support DWARF-5 in gdb.
2019-12-24 04:31:24 +01:00
|
|
|
|
|
|
|
|
|
|
2020-01-13 Ali Tamur <tamur@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
|
|
|
|
|
|
(dwarf2_cu): Add str_offsets_base field. Change the type of addr_base
|
|
|
|
|
|
to gdb::optional. Update comments.
|
|
|
|
|
|
(dwo_file): Update comments.
|
|
|
|
|
|
(read_attribute): Update API to take an additional out parameter,
|
|
|
|
|
|
need_reprocess. This is used to mark attributes that need other
|
|
|
|
|
|
attributes (e.g. str_offsets_base) for correct computation which may not
|
|
|
|
|
|
have been read yet.
|
|
|
|
|
|
(read_attribute_reprocess): New function declaration.
|
|
|
|
|
|
(read_addr_index): Likewise.
|
|
|
|
|
|
(read_dwo_str_index): Likewise.
|
|
|
|
|
|
(read_stub_str_index): Likewise.
|
|
|
|
|
|
(dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
|
|
|
|
|
|
(lookup_addr_base): New function definition.
|
|
|
|
|
|
(lookup_ranges_base): Likewise.
|
|
|
|
|
|
(read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
|
|
|
|
|
|
lookup_ranges_base.
|
|
|
|
|
|
(init_cutu_and_read_dies): Update comments.
|
|
|
|
|
|
(init_cutu_and_read_dies_no_follow): Change API to take parent compile
|
|
|
|
|
|
unit. This is used to inherit parent's str_offsets_base and addr_base.
|
|
|
|
|
|
Update comments.
|
|
|
|
|
|
(init_cutu_and_read_dies_simple): Reflect API changes.
|
|
|
|
|
|
(skip_one_die): Reflect API changes. Handle DW_FORM_rnglistx.
|
|
|
|
|
|
(create_cus_hash_table): Change API to take parent compile unit.
|
|
|
|
|
|
Reflect API changes.
|
|
|
|
|
|
(open_and_init_dwo_file): Reflect API changes.
|
|
|
|
|
|
(dwarf2_get_pc_bounds): Update comments.
|
|
|
|
|
|
(dwarf2_record_block_ranges): Likewise.
|
|
|
|
|
|
(read_full_die_1): Change implementation to reprocess attributes that
|
|
|
|
|
|
need str_offsets_base and addr_base.
|
|
|
|
|
|
(partial_die_info::read): Likewise.
|
|
|
|
|
|
(read_attribute_reprocess): New function definition.
|
|
|
|
|
|
(read_attribute_value): Change API to take an additional out parameter,
|
|
|
|
|
|
need_reprocess. Handle DW_FORM_rnglistx. No longer trigger an error
|
|
|
|
|
|
when a non-dwo compile unit has index based attributes.
|
|
|
|
|
|
(read_attribute): Reflect API changes.
|
|
|
|
|
|
(read_addr_index_1): Reflect API changes. Update comments.
|
|
|
|
|
|
(dwarf2_read_addr_index_data): Reflect API changes.
|
|
|
|
|
|
(dwarf2_read_addr_index): Likewise.
|
|
|
|
|
|
(read_str_index): Change API and implementation. This becomes a helper
|
|
|
|
|
|
to be used by the new string index related methods. Update error
|
|
|
|
|
|
message and comments.
|
|
|
|
|
|
(read_dwo_str_index): New function definition.
|
|
|
|
|
|
(read_stub_str_index): Likewise.
|
|
|
|
|
|
* dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
|
|
|
|
|
|
* symfile.h (dwarf2_debug_sections): Likewise.
|
|
|
|
|
|
* xcoffread.c (dwarf2_debug_sections): Likewise.
|
|
|
|
|
|
|
2020-01-14 00:12:08 +01:00
|
|
|
|
2020-01-13 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbcore.h (struct core_fns) <core_read_registers>: Change
|
|
|
|
|
|
core_reg_sect type to gdb_byte *.
|
|
|
|
|
|
* arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
|
|
|
|
|
|
* cris-tdep.c (fetch_core_registers): Likewise.
|
|
|
|
|
|
* corelow.c (core_target::get_core_register_section): Change
|
|
|
|
|
|
type of `contents` to gdb::byte_vector.
|
|
|
|
|
|
|
2020-01-10 01:04:25 +01:00
|
|
|
|
2020-01-13 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-wingeneral.c (box_win): Position the title in the center
|
|
|
|
|
|
of the border.
|
|
|
|
|
|
|
gdb: use std::vector instead of alloca in core_target::get_core_register_section
As I was trying to compile gdb for an m68k host, I got this error:
CXX corelow.o
In file included from /binutils-gdb/gdb/gdbsupport/common-defs.h:120,
from /binutils-gdb/gdb/defs.h:28,
from /binutils-gdb/gdb/corelow.c:20:
/binutils-gdb/gdb/corelow.c: In member function 'void core_target::get_core_register_section(regcache*, const regset*, const char*, int, int, const char*, bool)':
/binutils-gdb/gdb/../include/libiberty.h:727:36: error: 'alloca' bound is unknown [-Werror=alloca-larger-than=]
727 | # define alloca(x) __builtin_alloca(x)
| ~~~~~~~~~~~~~~~~^~~
/binutils-gdb/gdb/corelow.c:625:23: note: in expansion of macro 'alloca'
625 | contents = (char *) alloca (size);
| ^~~~~~
We are using alloca to hold the contents of a the core register
sections. These sections are typically fairly small, but there is no
realy guarantee, so I think it would be more reasonable to just use
dynamic allocation here.
gdb/ChangeLog:
* corelow.c (core_target::get_core_register_section): Use
std::vector instead of alloca.
2020-01-13 20:32:52 +01:00
|
|
|
|
2020-01-13 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* corelow.c (core_target::get_core_register_section): Use
|
|
|
|
|
|
std::vector instead of alloca.
|
|
|
|
|
|
|
2020-01-13 20:05:44 +01:00
|
|
|
|
2020-01-13 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* warning.m4: Add -Wmissing-declarations to build_warnings.
|
|
|
|
|
|
* configure: Re-generate.
|
|
|
|
|
|
|
2020-01-13 20:03:04 +01:00
|
|
|
|
2020-01-13 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* python/python.c (init__gdb_module): Add declaration.
|
|
|
|
|
|
|
2020-01-13 20:01:38 +01:00
|
|
|
|
2020-01-13 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
|
|
|
|
|
|
* aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
|
|
|
|
|
|
* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
|
|
|
|
|
|
* aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
|
|
|
|
|
|
* aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
|
|
|
|
|
|
* aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
|
|
|
|
|
|
* ada-exp.y (_initialize_ada_exp): Add declaration.
|
|
|
|
|
|
* ada-lang.c (_initialize_ada_language): Add declaration.
|
|
|
|
|
|
* ada-tasks.c (_initialize_tasks): Add declaration.
|
|
|
|
|
|
* agent.c (_initialize_agent): Add declaration.
|
|
|
|
|
|
* aix-thread.c (_initialize_aix_thread): Add declaration.
|
|
|
|
|
|
* alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
|
|
|
|
|
|
* alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
|
|
|
|
|
|
* alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
|
|
|
|
|
|
* alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
|
|
|
|
|
|
* alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
|
|
|
|
|
|
* alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
|
|
|
|
|
|
* amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
|
|
|
|
|
|
* amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
|
|
|
|
|
|
* amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
|
|
|
|
|
|
* amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
|
|
|
|
|
|
* amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
|
|
|
|
|
|
* amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
|
|
|
|
|
|
* amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
|
|
|
|
|
|
* amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
|
|
|
|
|
|
* amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
|
|
|
|
|
|
* amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
|
|
|
|
|
|
* amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
|
|
|
|
|
|
* amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
|
|
|
|
|
|
* amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
|
|
|
|
|
|
* amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
|
|
|
|
|
|
* annotate.c (_initialize_annotate): Add declaration.
|
|
|
|
|
|
* arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
|
|
|
|
|
|
* arc-tdep.c (_initialize_arc_tdep): Add declaration.
|
|
|
|
|
|
* arch-utils.c (_initialize_gdbarch_utils): Add declaration.
|
|
|
|
|
|
* arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
|
|
|
|
|
|
* arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
|
|
|
|
|
|
* arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
|
|
|
|
|
|
* arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
|
|
|
|
|
|
* arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
|
|
|
|
|
|
* arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
|
|
|
|
|
|
* arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
|
|
|
|
|
|
* arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
|
|
|
|
|
|
* arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
|
|
|
|
|
|
* arm-tdep.c (_initialize_arm_tdep): Add declaration.
|
|
|
|
|
|
* arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
|
|
|
|
|
|
* auto-load.c (_initialize_auto_load): Add declaration.
|
|
|
|
|
|
* auxv.c (_initialize_auxv): Add declaration.
|
|
|
|
|
|
* avr-tdep.c (_initialize_avr_tdep): Add declaration.
|
|
|
|
|
|
* ax-gdb.c (_initialize_ax_gdb): Add declaration.
|
|
|
|
|
|
* bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
|
|
|
|
|
|
* bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
|
|
|
|
|
|
* break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
|
|
|
|
|
|
* break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
|
|
|
|
|
|
* break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
|
|
|
|
|
|
* breakpoint.c (_initialize_breakpoint): Add declaration.
|
|
|
|
|
|
* bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
|
|
|
|
|
|
* btrace.c (_initialize_btrace): Add declaration.
|
|
|
|
|
|
* charset.c (_initialize_charset): Add declaration.
|
|
|
|
|
|
* cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
|
|
|
|
|
|
* cli/cli-dump.c (_initialize_cli_dump): Add declaration.
|
|
|
|
|
|
* cli/cli-interp.c (_initialize_cli_interp): Add declaration.
|
|
|
|
|
|
* cli/cli-logging.c (_initialize_cli_logging): Add declaration.
|
|
|
|
|
|
* cli/cli-script.c (_initialize_cli_script): Add declaration.
|
|
|
|
|
|
* cli/cli-style.c (_initialize_cli_style): Add declaration.
|
|
|
|
|
|
* coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
|
|
|
|
|
|
* coffread.c (_initialize_coffread): Add declaration.
|
|
|
|
|
|
* compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
|
|
|
|
|
|
* compile/compile.c (_initialize_compile): Add declaration.
|
|
|
|
|
|
* complaints.c (_initialize_complaints): Add declaration.
|
|
|
|
|
|
* completer.c (_initialize_completer): Add declaration.
|
|
|
|
|
|
* copying.c (_initialize_copying): Add declaration.
|
|
|
|
|
|
* corefile.c (_initialize_core): Add declaration.
|
|
|
|
|
|
* corelow.c (_initialize_corelow): Add declaration.
|
|
|
|
|
|
* cp-abi.c (_initialize_cp_abi): Add declaration.
|
|
|
|
|
|
* cp-namespace.c (_initialize_cp_namespace): Add declaration.
|
|
|
|
|
|
* cp-support.c (_initialize_cp_support): Add declaration.
|
|
|
|
|
|
* cp-valprint.c (_initialize_cp_valprint): Add declaration.
|
|
|
|
|
|
* cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
|
|
|
|
|
|
* cris-tdep.c (_initialize_cris_tdep): Add declaration.
|
|
|
|
|
|
* csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
|
|
|
|
|
|
* csky-tdep.c (_initialize_csky_tdep): Add declaration.
|
|
|
|
|
|
* ctfread.c (_initialize_ctfread): Add declaration.
|
|
|
|
|
|
* d-lang.c (_initialize_d_language): Add declaration.
|
|
|
|
|
|
* darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
|
|
|
|
|
|
* darwin-nat.c (_initialize_darwin_nat): Add declaration.
|
|
|
|
|
|
* dbxread.c (_initialize_dbxread): Add declaration.
|
|
|
|
|
|
* dcache.c (_initialize_dcache): Add declaration.
|
|
|
|
|
|
* disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
|
|
|
|
|
|
* disasm.c (_initialize_disasm): Add declaration.
|
|
|
|
|
|
* dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
|
|
|
|
|
|
* dummy-frame.c (_initialize_dummy_frame): Add declaration.
|
|
|
|
|
|
* dwarf-index-cache.c (_initialize_index_cache): Add declaration.
|
|
|
|
|
|
* dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
|
|
|
|
|
|
* dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
|
|
|
|
|
|
* dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
|
|
|
|
|
|
* dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
|
|
|
|
|
|
* dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
|
|
|
|
|
|
* dwarf2read.c (_initialize_dwarf2_read): Add declaration.
|
|
|
|
|
|
* elfread.c (_initialize_elfread): Add declaration.
|
|
|
|
|
|
* exec.c (_initialize_exec): Add declaration.
|
|
|
|
|
|
* extension.c (_initialize_extension): Add declaration.
|
|
|
|
|
|
* f-lang.c (_initialize_f_language): Add declaration.
|
|
|
|
|
|
* f-valprint.c (_initialize_f_valprint): Add declaration.
|
|
|
|
|
|
* fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
|
|
|
|
|
|
* fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
|
|
|
|
|
|
* filesystem.c (_initialize_filesystem): Add declaration.
|
|
|
|
|
|
* findcmd.c (_initialize_mem_search): Add declaration.
|
|
|
|
|
|
* findvar.c (_initialize_findvar): Add declaration.
|
|
|
|
|
|
* fork-child.c (_initialize_fork_child): Add declaration.
|
|
|
|
|
|
* frame-base.c (_initialize_frame_base): Add declaration.
|
|
|
|
|
|
* frame-unwind.c (_initialize_frame_unwind): Add declaration.
|
|
|
|
|
|
* frame.c (_initialize_frame): Add declaration.
|
|
|
|
|
|
* frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
|
|
|
|
|
|
* frv-tdep.c (_initialize_frv_tdep): Add declaration.
|
|
|
|
|
|
* ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
|
|
|
|
|
|
* gcore.c (_initialize_gcore): Add declaration.
|
|
|
|
|
|
* gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
|
|
|
|
|
|
* gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
|
|
|
|
|
|
* gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
|
|
|
|
|
|
* gdbarch.c (_initialize_gdbarch): Add declaration.
|
|
|
|
|
|
* gdbtypes.c (_initialize_gdbtypes): Add declaration.
|
|
|
|
|
|
* gnu-nat.c (_initialize_gnu_nat): Add declaration.
|
|
|
|
|
|
* gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
|
|
|
|
|
|
* gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
|
|
|
|
|
|
* go-lang.c (_initialize_go_language): Add declaration.
|
|
|
|
|
|
* go32-nat.c (_initialize_go32_nat): Add declaration.
|
|
|
|
|
|
* guile/guile.c (_initialize_guile): Add declaration.
|
|
|
|
|
|
* h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
|
|
|
|
|
|
* hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
|
|
|
|
|
|
* hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
|
|
|
|
|
|
* hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
|
|
|
|
|
|
* hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
|
|
|
|
|
|
* hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
|
|
|
|
|
|
* hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
|
|
|
|
|
|
* hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
|
|
|
|
|
|
* i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
|
|
|
|
|
|
* i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
|
|
|
|
|
|
* i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
|
|
|
|
|
|
* i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
|
|
|
|
|
|
* i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
|
|
|
|
|
|
* i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
|
|
|
|
|
|
* i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
|
|
|
|
|
|
* i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
|
|
|
|
|
|
* i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
|
|
|
|
|
|
* i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
|
|
|
|
|
|
* i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
|
|
|
|
|
|
* i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
|
|
|
|
|
|
* i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
|
|
|
|
|
|
* i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
|
|
|
|
|
|
* i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
|
|
|
|
|
|
* i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
|
|
|
|
|
|
* i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
|
|
|
|
|
|
* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
|
|
|
|
|
|
* i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
|
|
|
|
|
|
* i386-tdep.c (_initialize_i386_tdep): Add declaration.
|
|
|
|
|
|
* i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
|
|
|
|
|
|
* ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
|
|
|
|
|
|
* ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
|
|
|
|
|
|
* ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
|
|
|
|
|
|
* ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
|
|
|
|
|
|
* ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
|
|
|
|
|
|
* infcall.c (_initialize_infcall): Add declaration.
|
|
|
|
|
|
* infcmd.c (_initialize_infcmd): Add declaration.
|
|
|
|
|
|
* inflow.c (_initialize_inflow): Add declaration.
|
|
|
|
|
|
* infrun.c (_initialize_infrun): Add declaration.
|
|
|
|
|
|
* interps.c (_initialize_interpreter): Add declaration.
|
|
|
|
|
|
* iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
|
|
|
|
|
|
* jit.c (_initialize_jit): Add declaration.
|
|
|
|
|
|
* language.c (_initialize_language): Add declaration.
|
|
|
|
|
|
* linux-fork.c (_initialize_linux_fork): Add declaration.
|
|
|
|
|
|
* linux-nat.c (_initialize_linux_nat): Add declaration.
|
|
|
|
|
|
* linux-tdep.c (_initialize_linux_tdep): Add declaration.
|
|
|
|
|
|
* linux-thread-db.c (_initialize_thread_db): Add declaration.
|
|
|
|
|
|
* lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
|
|
|
|
|
|
* m2-lang.c (_initialize_m2_language): Add declaration.
|
|
|
|
|
|
* m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
|
|
|
|
|
|
* m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
|
|
|
|
|
|
* m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
|
|
|
|
|
|
* m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
|
|
|
|
|
|
* m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
|
|
|
|
|
|
* m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
|
|
|
|
|
|
* m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
|
|
|
|
|
|
* m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
|
|
|
|
|
|
* m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
|
|
|
|
|
|
* m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
|
|
|
|
|
|
* machoread.c (_initialize_machoread): Add declaration.
|
|
|
|
|
|
* macrocmd.c (_initialize_macrocmd): Add declaration.
|
|
|
|
|
|
* macroscope.c (_initialize_macroscope): Add declaration.
|
|
|
|
|
|
* maint-test-options.c (_initialize_maint_test_options): Add declaration.
|
|
|
|
|
|
* maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
|
|
|
|
|
|
* maint.c (_initialize_maint_cmds): Add declaration.
|
|
|
|
|
|
* mdebugread.c (_initialize_mdebugread): Add declaration.
|
|
|
|
|
|
* memattr.c (_initialize_mem): Add declaration.
|
|
|
|
|
|
* mep-tdep.c (_initialize_mep_tdep): Add declaration.
|
|
|
|
|
|
* mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
|
|
|
|
|
|
* mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
|
|
|
|
|
|
* mi/mi-interp.c (_initialize_mi_interp): Add declaration.
|
|
|
|
|
|
* mi/mi-main.c (_initialize_mi_main): Add declaration.
|
|
|
|
|
|
* microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
|
|
|
|
|
|
* microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
|
|
|
|
|
|
* mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
|
|
|
|
|
|
* mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
|
|
|
|
|
|
* mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
|
|
|
|
|
|
* mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
|
|
|
|
|
|
* mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
|
|
|
|
|
|
* mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
|
|
|
|
|
|
* mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
|
|
|
|
|
|
* mips-tdep.c (_initialize_mips_tdep): Add declaration.
|
|
|
|
|
|
* mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
|
|
|
|
|
|
* mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
|
|
|
|
|
|
* mipsread.c (_initialize_mipsread): Add declaration.
|
|
|
|
|
|
* mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
|
|
|
|
|
|
* mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
|
|
|
|
|
|
* moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
|
|
|
|
|
|
* msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
|
|
|
|
|
|
* nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
|
|
|
|
|
|
* nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
|
|
|
|
|
|
* nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
|
|
|
|
|
|
* nto-procfs.c (_initialize_procfs): Add declaration.
|
|
|
|
|
|
* objc-lang.c (_initialize_objc_language): Add declaration.
|
|
|
|
|
|
* observable.c (_initialize_observer): Add declaration.
|
|
|
|
|
|
* opencl-lang.c (_initialize_opencl_language): Add declaration.
|
|
|
|
|
|
* or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
|
|
|
|
|
|
* or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
|
|
|
|
|
|
* osabi.c (_initialize_gdb_osabi): Add declaration.
|
|
|
|
|
|
* osdata.c (_initialize_osdata): Add declaration.
|
|
|
|
|
|
* p-valprint.c (_initialize_pascal_valprint): Add declaration.
|
|
|
|
|
|
* parse.c (_initialize_parse): Add declaration.
|
|
|
|
|
|
* ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
|
|
|
|
|
|
* ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
|
|
|
|
|
|
* ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
|
|
|
|
|
|
* ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
|
|
|
|
|
|
* ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
|
|
|
|
|
|
* ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
|
|
|
|
|
|
* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
|
|
|
|
|
|
* ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
|
|
|
|
|
|
* printcmd.c (_initialize_printcmd): Add declaration.
|
|
|
|
|
|
* probe.c (_initialize_probe): Add declaration.
|
|
|
|
|
|
* proc-api.c (_initialize_proc_api): Add declaration.
|
|
|
|
|
|
* proc-events.c (_initialize_proc_events): Add declaration.
|
|
|
|
|
|
* proc-service.c (_initialize_proc_service): Add declaration.
|
|
|
|
|
|
* procfs.c (_initialize_procfs): Add declaration.
|
|
|
|
|
|
* producer.c (_initialize_producer): Add declaration.
|
|
|
|
|
|
* psymtab.c (_initialize_psymtab): Add declaration.
|
|
|
|
|
|
* python/python.c (_initialize_python): Add declaration.
|
|
|
|
|
|
* ravenscar-thread.c (_initialize_ravenscar): Add declaration.
|
|
|
|
|
|
* record-btrace.c (_initialize_record_btrace): Add declaration.
|
|
|
|
|
|
* record-full.c (_initialize_record_full): Add declaration.
|
|
|
|
|
|
* record.c (_initialize_record): Add declaration.
|
|
|
|
|
|
* regcache-dump.c (_initialize_regcache_dump): Add declaration.
|
|
|
|
|
|
* regcache.c (_initialize_regcache): Add declaration.
|
|
|
|
|
|
* reggroups.c (_initialize_reggroup): Add declaration.
|
|
|
|
|
|
* remote-notif.c (_initialize_notif): Add declaration.
|
|
|
|
|
|
* remote-sim.c (_initialize_remote_sim): Add declaration.
|
|
|
|
|
|
* remote.c (_initialize_remote): Add declaration.
|
|
|
|
|
|
* reverse.c (_initialize_reverse): Add declaration.
|
|
|
|
|
|
* riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
|
|
|
|
|
|
* riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
|
|
|
|
|
|
* riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
|
|
|
|
|
|
* riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
|
|
|
|
|
|
* riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
|
|
|
|
|
|
* rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
|
|
|
|
|
|
* rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
|
|
|
|
|
|
* rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
|
|
|
|
|
|
Add declaration.
|
|
|
|
|
|
* rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
|
|
|
|
|
|
* rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
|
|
|
|
|
|
* run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
|
|
|
|
|
|
* rust-exp.y (_initialize_rust_exp): Add declaration.
|
|
|
|
|
|
* rx-tdep.c (_initialize_rx_tdep): Add declaration.
|
|
|
|
|
|
* s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
|
|
|
|
|
|
* s390-linux-nat.c (_initialize_s390_nat): Add declaration.
|
|
|
|
|
|
* s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
|
|
|
|
|
|
* s390-tdep.c (_initialize_s390_tdep): Add declaration.
|
|
|
|
|
|
* score-tdep.c (_initialize_score_tdep): Add declaration.
|
|
|
|
|
|
* ser-go32.c (_initialize_ser_dos): Add declaration.
|
|
|
|
|
|
* ser-mingw.c (_initialize_ser_windows): Add declaration.
|
|
|
|
|
|
* ser-pipe.c (_initialize_ser_pipe): Add declaration.
|
|
|
|
|
|
* ser-tcp.c (_initialize_ser_tcp): Add declaration.
|
|
|
|
|
|
* ser-uds.c (_initialize_ser_socket): Add declaration.
|
|
|
|
|
|
* ser-unix.c (_initialize_ser_hardwire): Add declaration.
|
|
|
|
|
|
* serial.c (_initialize_serial): Add declaration.
|
|
|
|
|
|
* sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
|
|
|
|
|
|
* sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
|
|
|
|
|
|
* sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
|
|
|
|
|
|
* sh-tdep.c (_initialize_sh_tdep): Add declaration.
|
|
|
|
|
|
* skip.c (_initialize_step_skip): Add declaration.
|
|
|
|
|
|
* sol-thread.c (_initialize_sol_thread): Add declaration.
|
|
|
|
|
|
* solib-aix.c (_initialize_solib_aix): Add declaration.
|
|
|
|
|
|
* solib-darwin.c (_initialize_darwin_solib): Add declaration.
|
|
|
|
|
|
* solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
|
|
|
|
|
|
* solib-frv.c (_initialize_frv_solib): Add declaration.
|
|
|
|
|
|
* solib-svr4.c (_initialize_svr4_solib): Add declaration.
|
|
|
|
|
|
* solib-target.c (_initialize_solib_target): Add declaration.
|
|
|
|
|
|
* solib.c (_initialize_solib): Add declaration.
|
|
|
|
|
|
* source-cache.c (_initialize_source_cache): Add declaration.
|
|
|
|
|
|
* source.c (_initialize_source): Add declaration.
|
|
|
|
|
|
* sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
|
|
|
|
|
|
* sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
|
|
|
|
|
|
* sparc-nat.c (_initialize_sparc_nat): Add declaration.
|
|
|
|
|
|
* sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
|
|
|
|
|
|
* sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
|
|
|
|
|
|
* sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
|
|
|
|
|
|
* sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
|
|
|
|
|
|
* sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
|
|
|
|
|
|
* sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
|
|
|
|
|
|
* sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
|
|
|
|
|
|
* sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
|
|
|
|
|
|
* sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
|
|
|
|
|
|
* sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
|
|
|
|
|
|
* sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
|
|
|
|
|
|
* sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
|
|
|
|
|
|
* sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
|
|
|
|
|
|
* sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
|
|
|
|
|
|
* sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
|
|
|
|
|
|
* sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
|
|
|
|
|
|
* stabsread.c (_initialize_stabsread): Add declaration.
|
|
|
|
|
|
* stack.c (_initialize_stack): Add declaration.
|
|
|
|
|
|
* stap-probe.c (_initialize_stap_probe): Add declaration.
|
|
|
|
|
|
* std-regs.c (_initialize_frame_reg): Add declaration.
|
|
|
|
|
|
* symfile-debug.c (_initialize_symfile_debug): Add declaration.
|
|
|
|
|
|
* symfile-mem.c (_initialize_symfile_mem): Add declaration.
|
|
|
|
|
|
* symfile.c (_initialize_symfile): Add declaration.
|
|
|
|
|
|
* symmisc.c (_initialize_symmisc): Add declaration.
|
|
|
|
|
|
* symtab.c (_initialize_symtab): Add declaration.
|
|
|
|
|
|
* target.c (_initialize_target): Add declaration.
|
|
|
|
|
|
* target-connection.c (_initialize_target_connection): Add
|
|
|
|
|
|
declaration.
|
|
|
|
|
|
* target-dcache.c (_initialize_target_dcache): Add declaration.
|
|
|
|
|
|
* target-descriptions.c (_initialize_target_descriptions): Add declaration.
|
|
|
|
|
|
* thread.c (_initialize_thread): Add declaration.
|
|
|
|
|
|
* tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
|
|
|
|
|
|
* tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
|
|
|
|
|
|
* tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
|
|
|
|
|
|
* tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
|
|
|
|
|
|
* tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
|
|
|
|
|
|
* tracectf.c (_initialize_ctf): Add declaration.
|
|
|
|
|
|
* tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
|
|
|
|
|
|
* tracefile.c (_initialize_tracefile): Add declaration.
|
|
|
|
|
|
* tracepoint.c (_initialize_tracepoint): Add declaration.
|
|
|
|
|
|
* tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
|
|
|
|
|
|
* tui/tui-interp.c (_initialize_tui_interp): Add declaration.
|
|
|
|
|
|
* tui/tui-layout.c (_initialize_tui_layout): Add declaration.
|
|
|
|
|
|
* tui/tui-regs.c (_initialize_tui_regs): Add declaration.
|
|
|
|
|
|
* tui/tui-stack.c (_initialize_tui_stack): Add declaration.
|
|
|
|
|
|
* tui/tui-win.c (_initialize_tui_win): Add declaration.
|
|
|
|
|
|
* tui/tui.c (_initialize_tui): Add declaration.
|
|
|
|
|
|
* typeprint.c (_initialize_typeprint): Add declaration.
|
|
|
|
|
|
* ui-style.c (_initialize_ui_style): Add declaration.
|
|
|
|
|
|
* unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
|
|
|
|
|
|
* unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
|
|
|
|
|
|
* unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
|
|
|
|
|
|
* unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
|
|
|
|
|
|
* unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
|
|
|
|
|
|
* unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
|
|
|
|
|
|
* unittests/filtered_iterator-selftests.c
|
|
|
|
|
|
(_initialize_filtered_iterator_selftests): Add declaration.
|
|
|
|
|
|
* unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
|
|
|
|
|
|
* unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
|
|
|
|
|
|
* unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
|
|
|
|
|
|
* unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
|
|
|
|
|
|
* unittests/main-thread-selftests.c
|
|
|
|
|
|
(_initialize_main_thread_selftests): Add declaration.
|
|
|
|
|
|
* unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
|
|
|
|
|
|
* unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
|
|
|
|
|
|
* unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
|
|
|
|
|
|
* unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
|
|
|
|
|
|
* unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
|
|
|
|
|
|
* unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
|
|
|
|
|
|
* unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
|
|
|
|
|
|
* unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
|
|
|
|
|
|
* unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
|
|
|
|
|
|
* unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
|
|
|
|
|
|
* unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
|
|
|
|
|
|
* unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
|
|
|
|
|
|
* unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
|
|
|
|
|
|
* unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
|
|
|
|
|
|
* unittests/tui-selftests.c (_initialize_tui_selftest): Add
|
|
|
|
|
|
declaration.
|
|
|
|
|
|
* unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
|
|
|
|
|
|
* unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
|
|
|
|
|
|
* unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
|
|
|
|
|
|
* unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
|
|
|
|
|
|
* user-regs.c (_initialize_user_regs): Add declaration.
|
|
|
|
|
|
* utils.c (_initialize_utils): Add declaration.
|
|
|
|
|
|
* v850-tdep.c (_initialize_v850_tdep): Add declaration.
|
|
|
|
|
|
* valops.c (_initialize_valops): Add declaration.
|
|
|
|
|
|
* valprint.c (_initialize_valprint): Add declaration.
|
|
|
|
|
|
* value.c (_initialize_values): Add declaration.
|
|
|
|
|
|
* varobj.c (_initialize_varobj): Add declaration.
|
|
|
|
|
|
* vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
|
|
|
|
|
|
* vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
|
|
|
|
|
|
* vax-tdep.c (_initialize_vax_tdep): Add declaration.
|
|
|
|
|
|
* windows-nat.c (_initialize_windows_nat): Add declaration.
|
|
|
|
|
|
(_initialize_check_for_gdb_ini): Add declaration.
|
|
|
|
|
|
(_initialize_loadable): Add declaration.
|
|
|
|
|
|
* windows-tdep.c (_initialize_windows_tdep): Add declaration.
|
|
|
|
|
|
* x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
|
|
|
|
|
|
* x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
|
|
|
|
|
|
* xcoffread.c (_initialize_xcoffread): Add declaration.
|
|
|
|
|
|
* xml-support.c (_initialize_xml_support): Add declaration.
|
|
|
|
|
|
* xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
|
|
|
|
|
|
* xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
|
|
|
|
|
|
* xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
|
|
|
|
|
|
* xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
|
|
|
|
|
|
|
gdb: make regformats output a declaration for the init function
When compiling gdbserver for an architecture that uses the regdat.sh
script (such as m68k) and the -Wmissing-declarations compiler flag, I
get:
REGDAT reg-m68k-generated.c
CXX reg-m68k.o
reg-m68k-generated.c:30:1: error: no previous declaration for 'void init_registers_m68k()' [-Werror=missing-declarations]
30 | init_registers_m68k (void)
| ^~~~~~~~~~~~~~~~~~~
The same happens with other architectures, such as s390, but I'll be
using 68k as an example.
The init_registers_m68k function is defined in reg-m68k-generated.c,
which is produced by the regformats/regdat.sh script. This script reads
the regformats/reg-m68k.dat file, containing a register description, and
produces C code that creates a corresponding target description at
runtime.
The init_registers_m68k function is invoked at initialization time in
linux-m68k-low.c. The function must therefore be non-static, but does
not have a declaration at the moment.
The real clean way of fixing this would be to make regdat.sh generate a
.h file (in addition to the .c file) with declarations for whatever is
in the .c file. The generated .c file would include the .h file, and
therefore the definition would have a corresponding declaration. The
linux-m68k-low.c file would also include this .h file, instead of having
its own declaration of init_registers_m68k, like it does now.
However, this would be a quite big change for not much gain. As far as
I understand, some common architectures (i386, x86-64, ARM, AArch64)
have been moved to dynamically building target descriptions based on
features (the linux-*-tdesc.c files in gdbserver) and don't use
regdat.sh anymore. Logically (and given infinite development
resources), the other architectures would be migrated to this system too
and the regdat.sh script would be dropped. A new architecture would
probably not use regdat.sh either. So I therefore propose this simpler
patch instead, which just adds a local declaration in the generated
file.
gdb/ChangeLog:
* regformats/regdat.sh: Generate declaration for init function.
2020-01-13 19:59:18 +01:00
|
|
|
|
2020-01-13 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* regformats/regdat.sh: Generate declaration for init function.
|
|
|
|
|
|
|
gdb: adjust remote-sim.c to multi-target
The remote-sim.c file doesn't build since the main multi-target patch
(5b6d1e4f, "Multi-target support"), this patch is an attempt to fix it.
I have only build-tested it, so I'm not sure it runs fine, but it should
get us close at least.
I made these functions methods of the gdbsim_target, because they need
to pass the target down to some GDB core functions, like
find_inferior_ptid:
- get_sim_inferior_data_by_ptid (renamed to get_inferior_data_by_ptid)
- gdbsim_resume_inferior (renamed to resume_one_inferior)
- gdbsim_close_inferior (renamed to close_one_inferior)
In the last two, I changed iterate_over_inferiors to a range-based for,
since that gives simpler code (no need to pass data through the void
pointer).
The next_pid variable, INITIAL_PID macro and sim_inferior_data structure
are simply moved up in the file, above gdbsim_target.
gdb/ChangeLog:
* remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
up.
(gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
close_one_inferior>: New methods.
(get_sim_inferior_data_by_ptid): Move to gdbsim_target,
pass down target to find_inferior_pid.
(gdbsim_target::fetch_registers, gdbsim_target::store_registers):
Pass down target to find_inferior_ptid.
(gdbsim_target::create_inferior): Pass down target to
add_thread_silent.
(gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
target down to find_inferior_ptid and switch_to_thread.
(gdbsim_target::close): Update to call close_one_inferior.
(struct resume_data): Remove.
(gdbsim_resume_inferior): Move to gdbsim_target. Take arguments
directly, rather than through a void pointer.
(gdbsim_target::resume): Update to call resume_one_inferior.
2020-01-13 16:58:52 +01:00
|
|
|
|
2020-01-13 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
|
|
|
|
|
|
up.
|
|
|
|
|
|
(gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
|
|
|
|
|
|
close_one_inferior>: New methods.
|
|
|
|
|
|
(get_sim_inferior_data_by_ptid): Move to gdbsim_target,
|
|
|
|
|
|
pass down target to find_inferior_pid.
|
|
|
|
|
|
(gdbsim_target::fetch_registers, gdbsim_target::store_registers):
|
|
|
|
|
|
Pass down target to find_inferior_ptid.
|
|
|
|
|
|
(gdbsim_target::create_inferior): Pass down target to
|
|
|
|
|
|
add_thread_silent.
|
|
|
|
|
|
(gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
|
|
|
|
|
|
target down to find_inferior_ptid and switch_to_thread.
|
|
|
|
|
|
(gdbsim_target::close): Update to call close_one_inferior.
|
|
|
|
|
|
(struct resume_data): Remove.
|
|
|
|
|
|
(gdbsim_resume_inferior): Move to gdbsim_target. Take arguments
|
|
|
|
|
|
directly, rather than through a void pointer.
|
|
|
|
|
|
(gdbsim_target::resume): Update to call resume_one_inferior.
|
|
|
|
|
|
|
2020-01-12 21:11:07 +01:00
|
|
|
|
2020-01-12 Simon Marchi <simon.marchi@polymtl.ca>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbsupport/gdb_wait.c: Include gdb_wait.h.
|
|
|
|
|
|
|
2020-01-12 01:40:02 +01:00
|
|
|
|
2020-01-12 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
|
|
|
|
|
|
directly for the current inferior instead of
|
|
|
|
|
|
discard_all_inferiors.
|
|
|
|
|
|
(discard_all_inferiors): Delete.
|
|
|
|
|
|
|
2020-01-04 22:35:02 +01:00
|
|
|
|
2020-01-11 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-wingeneral.c (box_win): Check cli_styling.
|
|
|
|
|
|
* tui/tui-winsource.c (tui_source_window_base::refill): Use
|
|
|
|
|
|
deprecated_safe_get_selected_frame.
|
|
|
|
|
|
|
Switch the inferior before outputting its id in "info inferiors"
GDB uses the 'current_top_target' when displaying the description of
an inferior. This leads to same target being used for each inferior
and, in turn, yields incorrect output when the inferior has a target
that is supposed to give a specialized output. For instance, the
remote target outputs "Remote target" instead of "process XYZ" as the
description if the multi-process feature is not supported or turned
off.
E.g.: Suppose we have a native and a remote target, and the native is
the current inferior. The remote target does not support multi-process.
For "info inferiors", we would expect to see:
~~~
(gdb) i inferiors
Num Description Connection Executable
* 1 process 29060 1 (native) /a/path
2 Remote target 2 (remote ...)
~~~
but instead we get
~~~
(gdb) i inferiors
Num Description Connection Executable
* 1 process 29060 1 (native) /a/path
2 process 42000 2 (remote ...)
~~~
Similarly, if the current inferior is the remote one, we would expect
to see
~~~
(gdb) i inferiors
Num Description Connection Executable
1 process 29060 1 (native) /a/path
* 2 Remote target 2 (remote ...)
~~~
but we get
~~~
(gdb) i inferiors
Num Description Connection Executable
* 1 Remote target 1 (native) /a/path
2 Remote target 2 (remote ...)
~~~
With this patch, we switch to the inferior when outputting its
description, so that the current_top_target will be aligned to the
inferior we are displaying.
For testing, this patch expands the "info inferiors" test for the
multi-target feature. The test was checking for the output of the
info commands after setup, only when the current inferior is the last
added inferior.
This patch does the following to the testcase:
1. The "info inferiors" and "info connections" test is extracted out
from the "setup" procedure to a separate procedure.
2. The test is enriched to check the output after switching to each
inferior, not just the last one.
3. The test is performed twice; one for when the multi-process feature
is turned on, one for off.
gdb/ChangeLog:
2020-01-10 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* inferior.c (print_inferior): Switch inferior before printing it.
gdb/testsuite/ChangeLog:
2020-01-10 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* gdb.multi/multi-target.exp (setup): Factor out "info
connections" and "info inferiors" tests to ...
(test_info_inferiors): ... this new procedure.
(top level): Run new "info-inferiors" tests.
2020-01-10 21:06:17 +01:00
|
|
|
|
2020-01-10 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
* inferior.c (print_inferior): Switch inferior before printing it.
|
|
|
|
|
|
|
Switch the inferior too in switch_to_program_space_and_thread
With multi-target, each inferior now has its own target connection.
The problem in switch_to_program_space_and_thread is that in the
current state GDB switches to "no thread" and also sets the program
space but because the inferior is not switched, potentially an
incorrect target remains selected.
Here is a sample scenario that exploits this flow:
On terminal 1, start a gdbserver on a program named foo:
$ gdbserver :1234 ./foo
On terminal 2, start gdb on a program named bar. Suppose foo and bar
are compiled from foo.c and bar.c. They are completely separate. So,
bar.c:2 has no meaning for foo.
$ gdb -q ./bar
Reading symbols from ./bar...
(gdb) add-inferior
[New inferior 2]
Added inferior 2
(gdb) inferior 2
[Switching to inferior 2 [<null>] (<noexec>)]
(gdb) target remote :1234
...
(gdb) set debug remote 2
(gdb) break bar.c:2
Sending packet: $Hgp0.0#ad...Packet received: OK
Sending packet: $m5fa,12#f8...Packet received: E01
Sending packet: $m5fa,1#c6...Packet received: E01
Sending packet: $m5fb,3#c9...Packet received: E01
Sending packet: $m5fe,1#ca...Packet received: E01
Breakpoint 1 at 0x5fe: file bar.c, line 2.
(gdb)
Here we have an unnecessary sending of the packets to the gdbserver.
With this fix in progspace-and-thread.c, we'll get this:
(gdb) break bar.c:2
Breakpoint 1 at 0x5fe: file bar.c, line 2.
(gdb)
Now there is no sending of the packets to gdbserver.
The changes around clear_symtab_users calls are necessary because
otherwise we regress gdb.base/step-over-exit.exp, hitting the new
assertion in switch_to_program_space_and_thread. The problem is, a
forked child terminates, and when GDB decides to auto-purge that
inferior, GDB tries to switch to the pspace of that no-longer-existing
inferior.
The root of the problem is within the program_space destructor:
program_space::~program_space ()
{
...
set_current_program_space (this); # (1)
...
breakpoint_program_space_exit (this); # (2)
...
free_all_objfiles (); # (3)
...
}
We get here from delete_inferior -> delete_program_space.
So we're deleting an inferior, and the inferior to be
deleted is no longer in the inferior list.
At (2), we've deleted all the breakpoints and locations for the
program space being deleted.
The crash happens while doing a breakpoint re-set, called by
clear_symtab_users at the tail end of (3). That is, while recreating
breakpoints for the current program space, which is the program space
we're tearing down. During breakpoint re-set, we try to switch to the
new location's pspace (the current pspace set in (1), so the pspace
we're tearing down) with switch_to_program_space_and_thread, and that
hits the failed assertion. It's the fact that we recreate breakpoints
in the program_space destructor that is the latent bug here. Just
don't do that, and we don't end up in the crash situation.
My first approach to fix this added a symfile_add_flags parameter to
program_space::free_all_objfiles, and then passed that down to
clear_symtab_users. The program_space dtor would then pass down
SYMFILE_DEFER_BP_RESET to free_all_objfiles. I couldn't help feeling
that adding that parameter to free_all_objfiles looked a little
awkward, so I settled on something a little different -- hoist the
clear_symtab_users call to the callers. There are only two callers.
I felt that that didn't look as odd, particularly since
remove_symbol_file_command also does:
objf->unlink ();
clear_symtab_users (0);
I.e., objfile deletion is already separate from calling
clear_symtab_users in some places.
gdb/ChangeLog:
2020-01-10 Aleksandar Paunovic <aleksandar.paunovic@intel.com>
Pedro Alves <palves@redhat.com>
* progspace-and-thread.c (switch_to_program_space_and_thread):
Assert there's an inferior for PSPACE. Use
switch_to_inferior_no_thread to switch the inferior too.
* progspace.c (program_space::~program_space): Call
clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
(program_space::free_all_objfiles): Don't call clear_symtab_users
here.
* symfile.c (symbol_file_clear): Call clear_symtab_users here.
gdb/testsuite/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* gdb.server/bkpt-other-inferior.exp: New file.
2020-01-10 21:06:16 +01:00
|
|
|
|
2020-01-10 Aleksandar Paunovic <aleksandar.paunovic@intel.com>
|
|
|
|
|
|
Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* progspace-and-thread.c (switch_to_program_space_and_thread):
|
|
|
|
|
|
Assert there's an inferior for PSPACE. Use
|
|
|
|
|
|
switch_to_inferior_no_thread to switch the inferior too.
|
|
|
|
|
|
* progspace.c (program_space::~program_space): Call
|
|
|
|
|
|
clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
|
|
|
|
|
|
(program_space::free_all_objfiles): Don't call clear_symtab_users
|
|
|
|
|
|
here.
|
|
|
|
|
|
* symfile.c (symbol_file_clear): Call clear_symtab_users here.
|
|
|
|
|
|
|
2020-01-10 21:06:15 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Mention multi-target debugging, "info connections", and
|
|
|
|
|
|
"add-inferior -no-connection".
|
|
|
|
|
|
|
2020-01-10 21:06:14 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infrun.c: Include "target-connection.h".
|
|
|
|
|
|
(check_multi_target_resumption): New.
|
|
|
|
|
|
(proceed): Call it.
|
|
|
|
|
|
* target-connection.c (make_target_connection_string): Make
|
|
|
|
|
|
extern.
|
|
|
|
|
|
* target-connection.h (make_target_connection_string): Declare.
|
|
|
|
|
|
|
2020-01-10 21:06:14 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add target-connection.c.
|
|
|
|
|
|
* inferior.c (uiout_field_connection): New function.
|
|
|
|
|
|
(print_inferior): Add new "connection-id" column.
|
|
|
|
|
|
(add_inferior_command): Show connection number/string of added
|
|
|
|
|
|
inferior.
|
|
|
|
|
|
* process-stratum-target.h
|
|
|
|
|
|
(process_stratum_target::connection_string): New virtual method.
|
|
|
|
|
|
(process_stratum_target::connection_number): New field.
|
|
|
|
|
|
* remote.c (remote_target::connection_string): New override.
|
|
|
|
|
|
* target-connection.c: New file.
|
|
|
|
|
|
* target-connection.h: New file.
|
|
|
|
|
|
* target.c (decref_target): Remove process_stratum targets from
|
|
|
|
|
|
the connection list.
|
|
|
|
|
|
(target_stack::push): Add process_stratum targets to the
|
|
|
|
|
|
connection list.
|
|
|
|
|
|
|
2020-01-10 21:06:11 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
Revert:
|
|
|
|
|
|
2016-04-12 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
* serial.c (serial_open, serial_fdopen_ops, do_serial_close):
|
|
|
|
|
|
Remove references to name.
|
|
|
|
|
|
* serial.h (struct serial) <name>: Delete.
|
|
|
|
|
|
|
2020-01-10 21:06:10 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbarch-selftests.c (register_to_value_test): Remove "target
|
|
|
|
|
|
already pushed" check.
|
|
|
|
|
|
|
Multi-target support
This commit adds multi-target support to GDB. What this means is that
with this commit, GDB can now be connected to different targets at the
same time. E.g., you can debug a live native process and a core dump
at the same time, connect to multiple gdbservers, etc.
Actually, the word "target" is overloaded in gdb. We already have a
target stack, with pushes several target_ops instances on top of one
another. We also have "info target" already, which means something
completely different to what this patch does.
So from here on, I'll be using the "target connections" term, to mean
an open process_stratum target, pushed on a target stack. This patch
makes gdb have multiple target stacks, and multiple process_stratum
targets open simultaneously. The user-visible changes / commands will
also use this terminology, but of course it's all open to debate.
User-interface-wise, not that much changes. The main difference is
that each inferior may have its own target connection.
A target connection (e.g., a target extended-remote connection) may
support debugging multiple processes, just as before.
Say you're debugging against gdbserver in extended-remote mode, and
you do "add-inferior" to prepare to spawn a new process, like:
(gdb) target extended-remote :9999
...
(gdb) start
...
(gdb) add-inferior
Added inferior 2
(gdb) inferior 2
[Switching to inferior 2 [<null>] (<noexec>)]
(gdb) file a.out
...
(gdb) start
...
At this point, you have two inferiors connected to the same gdbserver.
With this commit, GDB will maintain a target stack per inferior,
instead of a global target stack.
To preserve the behavior above, by default, "add-inferior" makes the
new inferior inherit a copy of the target stack of the current
inferior. Same across a fork - the child inherits a copy of the
target stack of the parent. While the target stacks are copied, the
targets themselves are not. Instead, target_ops is made a
refcounted_object, which means that target_ops instances are
refcounted, which each inferior counting for a reference.
What if you want to create an inferior and connect it to some _other_
target? For that, this commit introduces a new "add-inferior
-no-connection" option that makes the new inferior not share the
current inferior's target. So you could do:
(gdb) target extended-remote :9999
Remote debugging using :9999
...
(gdb) add-inferior -no-connection
[New inferior 2]
Added inferior 2
(gdb) inferior 2
[Switching to inferior 2 [<null>] (<noexec>)]
(gdb) info inferiors
Num Description Executable
1 process 18401 target:/home/pedro/tmp/main
* 2 <null>
(gdb) tar extended-remote :10000
Remote debugging using :10000
...
(gdb) info inferiors
Num Description Executable
1 process 18401 target:/home/pedro/tmp/main
* 2 process 18450 target:/home/pedro/tmp/main
(gdb)
A following patch will extended "info inferiors" to include a column
indicating which connection an inferior is bound to, along with a
couple other UI tweaks.
Other than that, debugging is the same as before. Users interact with
inferiors and threads as before. The only difference is that
inferiors may be bound to processes running in different machines.
That's pretty much all there is to it in terms of noticeable UI
changes.
On to implementation.
Since we can be connected to different systems at the same time, a
ptid_t is no longer a unique identifier. Instead a thread can be
identified by a pair of ptid_t and 'process_stratum_target *', the
later being the instance of the process_stratum target that owns the
process/thread. Note that process_stratum_target inherits from
target_ops, and all process_stratum targets inherit from
process_stratum_target. In earlier patches, many places in gdb were
converted to refer to threads by thread_info pointer instead of
ptid_t, but there are still places in gdb where we start with a
pid/tid and need to find the corresponding inferior or thread_info
objects. So you'll see in the patch many places adding a
process_stratum_target parameter to functions that used to take only a
ptid_t.
Since each inferior has its own target stack now, we can always find
the process_stratum target for an inferior. That is done via a
inf->process_target() convenience method.
Since each inferior has its own target stack, we need to handle the
"beneath" calls when servicing target calls. The solution I settled
with is just to make sure to switch the current inferior to the
inferior you want before making a target call. Not relying on global
context is just not feasible in current GDB. Fortunately, there
aren't that many places that need to do that, because generally most
code that calls target methods already has the current context
pointing to the right inferior/thread. Note, to emphasize -- there's
no method to "switch to this target stack". Instead, you switch the
current inferior, and that implicitly switches the target stack.
In some spots, we need to iterate over all inferiors so that we reach
all target stacks.
Native targets are still singletons. There's always only a single
instance of such targets.
Remote targets however, we'll have one instance per remote connection.
The exec target is still a singleton. There's only one instance. I
did not see the point of instanciating more than one exec_target
object.
After vfork, we need to make sure to push the exec target on the new
inferior. See exec_on_vfork.
For type safety, functions that need a {target, ptid} pair to identify
a thread, take a process_stratum_target pointer for target parameter
instead of target_ops *. Some shared code in gdb/nat/ also need to
gain a target pointer parameter. This poses an issue, since gdbserver
doesn't have process_stratum_target, only target_ops. To fix this,
this commit renames gdbserver's target_ops to process_stratum_target.
I think this makes sense. There's no concept of target stack in
gdbserver, and gdbserver's target_ops really implements a
process_stratum-like target.
The thread and inferior iterator functions also gain
process_stratum_target parameters. These are used to be able to
iterate over threads and inferiors of a given target. Following usual
conventions, if the target pointer is null, then we iterate over
threads and inferiors of all targets.
I tried converting "add-inferior" to the gdb::option framework, as a
preparatory patch, but that stumbled on the fact that gdb::option does
not support file options yet, for "add-inferior -exec". I have a WIP
patchset that adds that, but it's not a trivial patch, mainly due to
need to integrate readline's filename completion, so I deferred that
to some other time.
In infrun.c/infcmd.c, the main change is that we need to poll events
out of all targets. See do_target_wait. Right after collecting an
event, we switch the current inferior to an inferior bound to the
target that reported the event, so that target methods can be used
while handling the event. This makes most of the code transparent to
multi-targets. See fetch_inferior_event.
infrun.c:stop_all_threads is interesting -- in this function we need
to stop all threads of all targets. What the function does is send an
asynchronous stop request to all threads, and then synchronously waits
for events, with target_wait, rinse repeat, until all it finds are
stopped threads. Now that we have multiple targets, it's not
efficient to synchronously block in target_wait waiting for events out
of one target. Instead, we implement a mini event loop, with
interruptible_select, select'ing on one file descriptor per target.
For this to work, we need to be able to ask the target for a waitable
file descriptor. Such file descriptors already exist, they are the
descriptors registered in the main event loop with add_file_handler,
inside the target_async implementations. This commit adds a new
target_async_wait_fd target method that just returns the file
descriptor in question. See wait_one / stop_all_threads in infrun.c.
The 'threads_executing' global is made a per-target variable. Since
it is only relevant to process_stratum_target targets, this is where
it is put, instead of in target_ops.
You'll notice that remote.c includes some FIXME notes. These refer to
the fact that the global arrays that hold data for the remote packets
supported are still globals. For example, if we connect to two
different servers/stubs, then each might support different remote
protocol features. They might even be different architectures, like
e.g., one ARM baremetal stub, and a x86 gdbserver, to debug a
host/controller scenario as a single program. That isn't going to
work correctly today, because of said globals. I'm leaving fixing
that for another pass, since it does not appear to be trivial, and I'd
rather land the base work first. It's already useful to be able to
debug multiple instances of the same server (e.g., a distributed
cluster, where you have full control over the servers installed), so I
think as is it's already reasonable incremental progress.
Current limitations:
- You can only resume more that one target at the same time if all
targets support asynchronous debugging, and support non-stop mode.
It should be possible to support mixed all-stop + non-stop
backends, but that is left for another time. This means that
currently in order to do multi-target with gdbserver you need to
issue "maint set target-non-stop on". I would like to make that
mode be the default, but we're not there yet. Note that I'm
talking about how the target backend works, only. User-visible
all-stop mode works just fine.
- As explained above, connecting to different remote servers at the
same time is likely to produce bad results if they don't support the
exact set of RSP features.
FreeBSD updates courtesy of John Baldwin.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
John Baldwin <jhb@FreeBSD.org>
* aarch64-linux-nat.c
(aarch64_linux_nat_target::thread_architecture): Adjust.
* ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
(task_command_1): Likewise.
* aix-thread.c (sync_threadlists, aix_thread_target::resume)
(aix_thread_target::wait, aix_thread_target::fetch_registers)
(aix_thread_target::store_registers)
(aix_thread_target::thread_alive): Adjust.
* amd64-fbsd-tdep.c: Include "inferior.h".
(amd64fbsd_get_thread_local_address): Pass down target.
* amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
thread's gdbarch instead of target_gdbarch.
* break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
get_last_target_status.
* break-catch-syscall.c (print_it_catch_syscall): Likewise.
* breakpoint.c (breakpoints_should_be_inserted_now): Consider all
inferiors.
(update_inserted_breakpoint_locations): Skip if inferiors with no
execution.
(update_global_location_list): When handling moribund locations,
find representative inferior for location's pspace, and use thread
count of its process_stratum target.
* bsd-kvm.c (bsd_kvm_target_open): Pass target down.
* bsd-uthread.c (bsd_uthread_target::wait): Use
as_process_stratum_target and adjust thread_change_ptid and
add_thread calls.
(bsd_uthread_target::update_thread_list): Use
as_process_stratum_target and adjust find_thread_ptid,
thread_change_ptid and add_thread calls.
* btrace.c (maint_btrace_packet_history_cmd): Adjust
find_thread_ptid call.
* corelow.c (add_to_thread_list): Adjust add_thread call.
(core_target_open): Adjust add_thread_silent and thread_count
calls.
(core_target::pid_to_str): Adjust find_inferior_ptid call.
* ctf.c (ctf_target_open): Adjust add_thread_silent call.
* event-top.c (async_disconnect): Pop targets from all inferiors.
* exec.c (add_target_sections): Push exec target on all inferiors
sharing the program space.
(remove_target_sections): Remove the exec target from all
inferiors sharing the program space.
(exec_on_vfork): New.
* exec.h (exec_on_vfork): Declare.
* fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
Pass it down.
(fbsd_nat_target::update_thread_list): Adjust.
(fbsd_nat_target::resume): Adjust.
(fbsd_handle_debug_trap): Add fbsd_nat_target parameter. Pass it
down.
(fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
* fbsd-tdep.c (fbsd_corefile_thread): Adjust
get_thread_arch_regcache call.
* fork-child.c (gdb_startup_inferior): Pass target down to
startup_inferior and set_executing.
* gdbthread.h (struct process_stratum_target): Forward declare.
(add_thread, add_thread_silent, add_thread_with_info)
(in_thread_list): Add process_stratum_target parameter.
(find_thread_ptid(inferior*, ptid_t)): New overload.
(find_thread_ptid, thread_change_ptid): Add process_stratum_target
parameter.
(all_threads()): Delete overload.
(all_threads, all_non_exited_threads): Add process_stratum_target
parameter.
(all_threads_safe): Use brace initialization.
(thread_count): Add process_stratum_target parameter.
(set_resumed, set_running, set_stop_requested, set_executing)
(threads_are_executing, finish_thread_state): Add
process_stratum_target parameter.
(switch_to_thread): Use is_current_thread.
* i386-fbsd-tdep.c: Include "inferior.h".
(i386fbsd_get_thread_local_address): Pass down target.
* i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
* inf-child.c (inf_child_target::maybe_unpush_target): Remove
have_inferiors check.
* inf-ptrace.c (inf_ptrace_target::create_inferior)
(inf_ptrace_target::attach): Adjust.
* infcall.c (run_inferior_call): Adjust.
* infcmd.c (run_command_1): Pass target to
scoped_finish_thread_state.
(proceed_thread_callback): Skip inferiors with no execution.
(continue_command): Rename 'all_threads' local to avoid hiding
'all_threads' function. Adjust get_last_target_status call.
(prepare_one_step): Adjust set_running call.
(signal_command): Use user_visible_resume_target. Compare thread
pointers instead of inferior_ptid.
(info_program_command): Adjust to pass down target.
(attach_command): Mark target's 'thread_executing' flag.
(stop_current_target_threads_ns): New, factored out from ...
(interrupt_target_1): ... this. Switch inferior before making
target calls.
* inferior-iter.h
(struct all_inferiors_iterator, struct all_inferiors_range)
(struct all_inferiors_safe_range)
(struct all_non_exited_inferiors_range): Filter on
process_stratum_target too. Remove explicit.
* inferior.c (inferior::inferior): Push dummy target on target
stack.
(find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
Add process_stratum_target parameter, and pass it down.
(have_live_inferiors): Adjust.
(switch_to_inferior_and_push_target): New.
(add_inferior_command, clone_inferior_command): Handle
"-no-connection" parameter. Use
switch_to_inferior_and_push_target.
(_initialize_inferior): Mention "-no-connection" option in
the help of "add-inferior" and "clone-inferior" commands.
* inferior.h: Include "process-stratum-target.h".
(interrupt_target_1): Use bool.
(struct inferior) <push_target, unpush_target, target_is_pushed,
find_target_beneath, top_target, process_target, target_at,
m_stack>: New.
(discard_all_inferiors): Delete.
(find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
(all_inferiors, all_non_exited_inferiors): Add
process_stratum_target parameter.
* infrun.c: Include "gdb_select.h" and <unordered_map>.
(target_last_proc_target): New global.
(follow_fork_inferior): Push target on new inferior. Pass target
to add_thread_silent. Call exec_on_vfork. Handle target's
reference count.
(follow_fork): Adjust get_last_target_status call. Also consider
target.
(follow_exec): Push target on new inferior.
(struct execution_control_state) <target>: New field.
(user_visible_resume_target): New.
(do_target_resume): Call target_async.
(resume_1): Set target's threads_executing flag. Consider resume
target.
(commit_resume_all_targets): New.
(proceed): Also consider resume target. Skip threads of inferiors
with no execution. Commit resumtion in all targets.
(start_remote): Pass current inferior to wait_for_inferior.
(infrun_thread_stop_requested): Consider target as well. Pass
thread_info pointer to clear_inline_frame_state instead of ptid.
(infrun_thread_thread_exit): Consider target as well.
(random_pending_event_thread): New inferior parameter. Use it.
(do_target_wait): Rename to ...
(do_target_wait_1): ... this. Add inferior parameter, and pass it
down.
(threads_are_resumed_pending_p, do_target_wait): New.
(prepare_for_detach): Adjust calls.
(wait_for_inferior): New inferior parameter. Handle it. Use
do_target_wait_1 instead of do_target_wait.
(fetch_inferior_event): Adjust. Switch to representative
inferior. Pass target down.
(set_last_target_status): Add process_stratum_target parameter.
Save target in global.
(get_last_target_status): Add process_stratum_target parameter and
handle it.
(nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
(context_switch): Check inferior_ptid == null_ptid before calling
inferior_thread().
(get_inferior_stop_soon): Pass down target.
(wait_one): Rename to ...
(poll_one_curr_target): ... this.
(struct wait_one_event): New.
(wait_one): New.
(stop_all_threads): Adjust.
(handle_no_resumed, handle_inferior_event): Adjust to consider the
event's target.
(switch_back_to_stepped_thread): Also consider target.
(print_stop_event): Update.
(normal_stop): Update. Also consider the resume target.
* infrun.h (wait_for_inferior): Remove declaration.
(user_visible_resume_target): New declaration.
(get_last_target_status, set_last_target_status): New
process_stratum_target parameter.
* inline-frame.c (clear_inline_frame_state(ptid_t)): Add
process_stratum_target parameter, and use it.
(clear_inline_frame_state (thread_info*)): New.
* inline-frame.c (clear_inline_frame_state(ptid_t)): Add
process_stratum_target parameter.
(clear_inline_frame_state (thread_info*)): Declare.
* linux-fork.c (delete_checkpoint_command): Pass target down to
find_thread_ptid.
(checkpoint_command): Adjust.
* linux-nat.c (linux_nat_target::follow_fork): Switch to thread
instead of just tweaking inferior_ptid.
(linux_nat_switch_fork): Pass target down to thread_change_ptid.
(exit_lwp): Pass target down to find_thread_ptid.
(attach_proc_task_lwp_callback): Pass target down to
add_thread/set_running/set_executing.
(linux_nat_target::attach): Pass target down to
thread_change_ptid.
(get_detach_signal): Pass target down to find_thread_ptid.
Consider last target status's target.
(linux_resume_one_lwp_throw, resume_lwp)
(linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
(stop_wait_callback, save_stop_reason, linux_nat_filter_event)
(linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
(linux_nat_target::async_wait_fd): New.
(linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
target down.
* linux-nat.h (linux_nat_target::async_wait_fd): Declare.
* linux-tdep.c (get_thread_arch_regcache): Pass target down.
* linux-thread-db.c (struct thread_db_info::process_target): New
field.
(add_thread_db_info): Save target.
(get_thread_db_info): New process_stratum_target parameter. Also
match target.
(delete_thread_db_info): New process_stratum_target parameter.
Also match target.
(thread_from_lwp): Adjust to pass down target.
(thread_db_notice_clone): Pass down target.
(check_thread_db_callback): Pass down target.
(try_thread_db_load_1): Always push the thread_db target.
(try_thread_db_load, record_thread): Pass target down.
(thread_db_target::detach): Pass target down. Always unpush the
thread_db target.
(thread_db_target::wait, thread_db_target::mourn_inferior): Pass
target down. Always unpush the thread_db target.
(find_new_threads_callback, thread_db_find_new_threads_2)
(thread_db_target::update_thread_list): Pass target down.
(thread_db_target::pid_to_str): Pass current inferior down.
(thread_db_target::get_thread_local_address): Pass target down.
(thread_db_target::resume, maintenance_check_libthread_db): Pass
target down.
* nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
* procfs.c (procfs_target::procfs_init_inferior): Declare.
(proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
(procfs_init_inferior): Rename to ...
(procfs_target::procfs_init_inferior): ... this and adjust.
(procfs_target::create_inferior, procfs_notice_thread)
(procfs_do_thread_registers): Adjust.
* ppc-fbsd-tdep.c: Include "inferior.h".
(ppcfbsd_get_thread_local_address): Pass down target.
* proc-service.c (ps_xfer_memory): Switch current inferior and
program space as well.
(get_ps_regcache): Pass target down.
* process-stratum-target.c
(process_stratum_target::thread_address_space)
(process_stratum_target::thread_architecture): Pass target down.
* process-stratum-target.h
(process_stratum_target::threads_executing): New field.
(as_process_stratum_target): New.
* ravenscar-thread.c
(ravenscar_thread_target::update_inferior_ptid): Pass target down.
(ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
down.
* record-btrace.c (record_btrace_target::info_record): Adjust.
(record_btrace_target::record_method)
(record_btrace_target::record_is_replaying)
(record_btrace_target::fetch_registers)
(get_thread_current_frame_id, record_btrace_target::resume)
(record_btrace_target::wait, record_btrace_target::stop): Pass
target down.
* record-full.c (record_full_wait_1): Switch to event thread.
Pass target down.
* regcache.c (regcache::regcache)
(get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
process_stratum_target parameter and handle it.
(current_thread_target): New global.
(get_thread_regcache): Add process_stratum_target parameter and
handle it. Switch inferior before calling target method.
(get_thread_regcache): Pass target down.
(get_thread_regcache_for_ptid): Pass target down.
(registers_changed_ptid): Add process_stratum_target parameter and
handle it.
(registers_changed_thread, registers_changed): Pass target down.
(test_get_thread_arch_aspace_regcache): New.
(current_regcache_test): Define a couple local test_target_ops
instances and use them for testing.
(readwrite_regcache): Pass process_stratum_target parameter.
(cooked_read_test, cooked_write_test): Pass mock_target down.
* regcache.h (get_thread_regcache, get_thread_arch_regcache)
(get_thread_arch_aspace_regcache): Add process_stratum_target
parameter.
(regcache::target): New method.
(regcache::regcache, regcache::get_thread_arch_aspace_regcache)
(regcache::registers_changed_ptid): Add process_stratum_target
parameter.
(regcache::m_target): New field.
(registers_changed_ptid): Add process_stratum_target parameter.
* remote.c (remote_state::supports_vCont_probed): New field.
(remote_target::async_wait_fd): New method.
(remote_unpush_and_throw): Add remote_target parameter.
(get_current_remote_target): Adjust.
(remote_target::remote_add_inferior): Push target.
(remote_target::remote_add_thread)
(remote_target::remote_notice_new_inferior)
(get_remote_thread_info): Pass target down.
(remote_target::update_thread_list): Skip threads of inferiors
bound to other targets. (remote_target::close): Don't discard
inferiors. (remote_target::add_current_inferior_and_thread)
(remote_target::process_initial_stop_replies)
(remote_target::start_remote)
(remote_target::remote_serial_quit_handler): Pass down target.
(remote_target::remote_unpush_target): New remote_target
parameter. Unpush the target from all inferiors.
(remote_target::remote_unpush_and_throw): New remote_target
parameter. Pass it down.
(remote_target::open_1): Check whether the current inferior has
execution instead of checking whether any inferior is live. Pass
target down.
(remote_target::remote_detach_1): Pass down target. Use
remote_unpush_target.
(extended_remote_target::attach): Pass down target.
(remote_target::remote_vcont_probe): Set supports_vCont_probed.
(remote_target::append_resumption): Pass down target.
(remote_target::append_pending_thread_resumptions)
(remote_target::remote_resume_with_hc, remote_target::resume)
(remote_target::commit_resume): Pass down target.
(remote_target::remote_stop_ns): Check supports_vCont_probed.
(remote_target::interrupt_query)
(remote_target::remove_new_fork_children)
(remote_target::check_pending_events_prevent_wildcard_vcont)
(remote_target::remote_parse_stop_reply)
(remote_target::process_stop_reply): Pass down target.
(first_remote_resumed_thread): New remote_target parameter. Pass
it down.
(remote_target::wait_as): Pass down target.
(unpush_and_perror): New remote_target parameter. Pass it down.
(remote_target::readchar, remote_target::remote_serial_write)
(remote_target::getpkt_or_notif_sane_1)
(remote_target::kill_new_fork_children, remote_target::kill): Pass
down target.
(remote_target::mourn_inferior): Pass down target. Use
remote_unpush_target.
(remote_target::core_of_thread)
(remote_target::remote_btrace_maybe_reopen): Pass down target.
(remote_target::pid_to_exec_file)
(remote_target::thread_handle_to_thread_info): Pass down target.
(remote_target::async_wait_fd): New.
* riscv-fbsd-tdep.c: Include "inferior.h".
(riscv_fbsd_get_thread_local_address): Pass down target.
* sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
* sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
(ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
Adjust.
* solib-spu.c (spu_skip_standalone_loader): Pass down target.
* solib-svr4.c (enable_break): Pass down target.
* spu-multiarch.c (parse_spufs_run): Pass down target.
* spu-tdep.c (spu2ppu_sniffer): Pass down target.
* target-delegates.c: Regenerate.
* target.c (g_target_stack): Delete.
(current_top_target): Return the current inferior's top target.
(target_has_execution_1): Refer to the passed-in inferior's top
target.
(target_supports_terminal_ours): Check whether the initial
inferior was already created.
(decref_target): New.
(target_stack::push): Incref/decref the target.
(push_target, push_target, unpush_target): Adjust.
(target_stack::unpush): Defref target.
(target_is_pushed): Return bool. Adjust to refer to the current
inferior's target stack.
(dispose_inferior): Delete, and inline parts ...
(target_preopen): ... here. Only dispose of the current inferior.
(target_detach): Hold strong target reference while detaching.
Pass target down.
(target_thread_name): Add assertion.
(target_resume): Pass down target.
(target_ops::beneath, find_target_at): Adjust to refer to the
current inferior's target stack.
(get_dummy_target): New.
(target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
has a thread running.
(initialize_targets): Rename to ...
(_initialize_target): ... this.
* target.h: Include "gdbsupport/refcounted-object.h".
(struct target_ops): Inherit refcounted_object.
(target_ops::shortname, target_ops::longname): Make const.
(target_ops::async_wait_fd): New method.
(decref_target): Declare.
(struct target_ops_ref_policy): New.
(target_ops_ref): New typedef.
(get_dummy_target): Declare function.
(target_is_pushed): Return bool.
* thread-iter.c (all_matching_threads_iterator::m_inf_matches)
(all_matching_threads_iterator::all_matching_threads_iterator):
Handle filter target.
* thread-iter.h (struct all_matching_threads_iterator, struct
all_matching_threads_range, class all_non_exited_threads_range):
Filter by target too. Remove explicit.
* thread.c (threads_executing): Delete.
(inferior_thread): Pass down current inferior.
(clear_thread_inferior_resources): Pass down thread pointer
instead of ptid_t.
(add_thread_silent, add_thread_with_info, add_thread): Add
process_stratum_target parameter. Use it for thread and inferior
searches.
(is_current_thread): New.
(thread_info::deletable): Use it.
(find_thread_ptid, thread_count, in_thread_list)
(thread_change_ptid, set_resumed, set_running): New
process_stratum_target parameter. Pass it down.
(set_executing): New process_stratum_target parameter. Pass it
down. Adjust reference to 'threads_executing'.
(threads_are_executing): New process_stratum_target parameter.
Adjust reference to 'threads_executing'.
(set_stop_requested, finish_thread_state): New
process_stratum_target parameter. Pass it down.
(switch_to_thread): Also match inferior.
(switch_to_thread): New process_stratum_target parameter. Pass it
down.
(update_threads_executing): Reimplement.
* top.c (quit_force): Pop targets from all inferior.
(gdb_init): Don't call initialize_targets.
* windows-nat.c (windows_nat_target) <get_windows_debug_event>:
Declare.
(windows_add_thread, windows_delete_thread): Adjust.
(get_windows_debug_event): Rename to ...
(windows_nat_target::get_windows_debug_event): ... this. Adjust.
* tracefile-tfile.c (tfile_target_open): Pass down target.
* gdbsupport/common-gdbthread.h (struct process_stratum_target):
Forward declare.
(switch_to_thread): Add process_stratum_target parameter.
* mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
parameter. Use it.
(mi_on_resume): Pass target down.
* nat/fork-inferior.c (startup_inferior): Add
process_stratum_target parameter. Pass it down.
* nat/fork-inferior.h (startup_inferior): Add
process_stratum_target parameter.
* python/py-threadevent.c (py_get_event_thread): Pass target down.
gdb/gdbserver/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* fork-child.c (post_fork_inferior): Pass target down to
startup_inferior.
* inferiors.c (switch_to_thread): Add process_stratum_target
parameter.
* lynx-low.c (lynx_target_ops): Now a process_stratum_target.
* nto-low.c (nto_target_ops): Now a process_stratum_target.
* linux-low.c (linux_target_ops): Now a process_stratum_target.
* remote-utils.c (prepare_resume_reply): Pass the target to
switch_to_thread.
* target.c (the_target): Now a process_stratum_target.
(done_accessing_memory): Pass the target to switch_to_thread.
(set_target_ops): Ajust to use process_stratum_target.
* target.h (struct target_ops): Rename to ...
(struct process_stratum_target): ... this.
(the_target, set_target_ops): Adjust.
(prepare_to_access_memory): Adjust comment.
* win32-low.c (child_xfer_memory): Adjust to use
process_stratum_target.
(win32_target_ops): Now a process_stratum_target.
2020-01-10 21:06:08 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
John Baldwin <jhb@FreeBSD.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-linux-nat.c
|
|
|
|
|
|
(aarch64_linux_nat_target::thread_architecture): Adjust.
|
|
|
|
|
|
* ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
|
|
|
|
|
|
(task_command_1): Likewise.
|
|
|
|
|
|
* aix-thread.c (sync_threadlists, aix_thread_target::resume)
|
|
|
|
|
|
(aix_thread_target::wait, aix_thread_target::fetch_registers)
|
|
|
|
|
|
(aix_thread_target::store_registers)
|
|
|
|
|
|
(aix_thread_target::thread_alive): Adjust.
|
|
|
|
|
|
* amd64-fbsd-tdep.c: Include "inferior.h".
|
|
|
|
|
|
(amd64fbsd_get_thread_local_address): Pass down target.
|
|
|
|
|
|
* amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
|
|
|
|
|
|
thread's gdbarch instead of target_gdbarch.
|
|
|
|
|
|
* break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
|
|
|
|
|
|
get_last_target_status.
|
|
|
|
|
|
* break-catch-syscall.c (print_it_catch_syscall): Likewise.
|
|
|
|
|
|
* breakpoint.c (breakpoints_should_be_inserted_now): Consider all
|
|
|
|
|
|
inferiors.
|
|
|
|
|
|
(update_inserted_breakpoint_locations): Skip if inferiors with no
|
|
|
|
|
|
execution.
|
|
|
|
|
|
(update_global_location_list): When handling moribund locations,
|
|
|
|
|
|
find representative inferior for location's pspace, and use thread
|
|
|
|
|
|
count of its process_stratum target.
|
|
|
|
|
|
* bsd-kvm.c (bsd_kvm_target_open): Pass target down.
|
|
|
|
|
|
* bsd-uthread.c (bsd_uthread_target::wait): Use
|
|
|
|
|
|
as_process_stratum_target and adjust thread_change_ptid and
|
|
|
|
|
|
add_thread calls.
|
|
|
|
|
|
(bsd_uthread_target::update_thread_list): Use
|
|
|
|
|
|
as_process_stratum_target and adjust find_thread_ptid,
|
|
|
|
|
|
thread_change_ptid and add_thread calls.
|
|
|
|
|
|
* btrace.c (maint_btrace_packet_history_cmd): Adjust
|
|
|
|
|
|
find_thread_ptid call.
|
|
|
|
|
|
* corelow.c (add_to_thread_list): Adjust add_thread call.
|
|
|
|
|
|
(core_target_open): Adjust add_thread_silent and thread_count
|
|
|
|
|
|
calls.
|
|
|
|
|
|
(core_target::pid_to_str): Adjust find_inferior_ptid call.
|
|
|
|
|
|
* ctf.c (ctf_target_open): Adjust add_thread_silent call.
|
|
|
|
|
|
* event-top.c (async_disconnect): Pop targets from all inferiors.
|
|
|
|
|
|
* exec.c (add_target_sections): Push exec target on all inferiors
|
|
|
|
|
|
sharing the program space.
|
|
|
|
|
|
(remove_target_sections): Remove the exec target from all
|
|
|
|
|
|
inferiors sharing the program space.
|
|
|
|
|
|
(exec_on_vfork): New.
|
|
|
|
|
|
* exec.h (exec_on_vfork): Declare.
|
|
|
|
|
|
* fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
|
|
|
|
|
|
Pass it down.
|
|
|
|
|
|
(fbsd_nat_target::update_thread_list): Adjust.
|
|
|
|
|
|
(fbsd_nat_target::resume): Adjust.
|
|
|
|
|
|
(fbsd_handle_debug_trap): Add fbsd_nat_target parameter. Pass it
|
|
|
|
|
|
down.
|
|
|
|
|
|
(fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
|
|
|
|
|
|
* fbsd-tdep.c (fbsd_corefile_thread): Adjust
|
|
|
|
|
|
get_thread_arch_regcache call.
|
|
|
|
|
|
* fork-child.c (gdb_startup_inferior): Pass target down to
|
|
|
|
|
|
startup_inferior and set_executing.
|
|
|
|
|
|
* gdbthread.h (struct process_stratum_target): Forward declare.
|
|
|
|
|
|
(add_thread, add_thread_silent, add_thread_with_info)
|
|
|
|
|
|
(in_thread_list): Add process_stratum_target parameter.
|
|
|
|
|
|
(find_thread_ptid(inferior*, ptid_t)): New overload.
|
|
|
|
|
|
(find_thread_ptid, thread_change_ptid): Add process_stratum_target
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(all_threads()): Delete overload.
|
|
|
|
|
|
(all_threads, all_non_exited_threads): Add process_stratum_target
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(all_threads_safe): Use brace initialization.
|
|
|
|
|
|
(thread_count): Add process_stratum_target parameter.
|
|
|
|
|
|
(set_resumed, set_running, set_stop_requested, set_executing)
|
|
|
|
|
|
(threads_are_executing, finish_thread_state): Add
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
(switch_to_thread): Use is_current_thread.
|
|
|
|
|
|
* i386-fbsd-tdep.c: Include "inferior.h".
|
|
|
|
|
|
(i386fbsd_get_thread_local_address): Pass down target.
|
|
|
|
|
|
* i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
|
|
|
|
|
|
* inf-child.c (inf_child_target::maybe_unpush_target): Remove
|
|
|
|
|
|
have_inferiors check.
|
|
|
|
|
|
* inf-ptrace.c (inf_ptrace_target::create_inferior)
|
|
|
|
|
|
(inf_ptrace_target::attach): Adjust.
|
|
|
|
|
|
* infcall.c (run_inferior_call): Adjust.
|
|
|
|
|
|
* infcmd.c (run_command_1): Pass target to
|
|
|
|
|
|
scoped_finish_thread_state.
|
|
|
|
|
|
(proceed_thread_callback): Skip inferiors with no execution.
|
|
|
|
|
|
(continue_command): Rename 'all_threads' local to avoid hiding
|
|
|
|
|
|
'all_threads' function. Adjust get_last_target_status call.
|
|
|
|
|
|
(prepare_one_step): Adjust set_running call.
|
|
|
|
|
|
(signal_command): Use user_visible_resume_target. Compare thread
|
|
|
|
|
|
pointers instead of inferior_ptid.
|
|
|
|
|
|
(info_program_command): Adjust to pass down target.
|
|
|
|
|
|
(attach_command): Mark target's 'thread_executing' flag.
|
|
|
|
|
|
(stop_current_target_threads_ns): New, factored out from ...
|
|
|
|
|
|
(interrupt_target_1): ... this. Switch inferior before making
|
|
|
|
|
|
target calls.
|
|
|
|
|
|
* inferior-iter.h
|
|
|
|
|
|
(struct all_inferiors_iterator, struct all_inferiors_range)
|
|
|
|
|
|
(struct all_inferiors_safe_range)
|
|
|
|
|
|
(struct all_non_exited_inferiors_range): Filter on
|
|
|
|
|
|
process_stratum_target too. Remove explicit.
|
|
|
|
|
|
* inferior.c (inferior::inferior): Push dummy target on target
|
|
|
|
|
|
stack.
|
|
|
|
|
|
(find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
|
|
|
|
|
|
Add process_stratum_target parameter, and pass it down.
|
|
|
|
|
|
(have_live_inferiors): Adjust.
|
|
|
|
|
|
(switch_to_inferior_and_push_target): New.
|
|
|
|
|
|
(add_inferior_command, clone_inferior_command): Handle
|
|
|
|
|
|
"-no-connection" parameter. Use
|
|
|
|
|
|
switch_to_inferior_and_push_target.
|
|
|
|
|
|
(_initialize_inferior): Mention "-no-connection" option in
|
|
|
|
|
|
the help of "add-inferior" and "clone-inferior" commands.
|
|
|
|
|
|
* inferior.h: Include "process-stratum-target.h".
|
|
|
|
|
|
(interrupt_target_1): Use bool.
|
|
|
|
|
|
(struct inferior) <push_target, unpush_target, target_is_pushed,
|
|
|
|
|
|
find_target_beneath, top_target, process_target, target_at,
|
|
|
|
|
|
m_stack>: New.
|
|
|
|
|
|
(discard_all_inferiors): Delete.
|
|
|
|
|
|
(find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
|
|
|
|
|
|
(all_inferiors, all_non_exited_inferiors): Add
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
* infrun.c: Include "gdb_select.h" and <unordered_map>.
|
|
|
|
|
|
(target_last_proc_target): New global.
|
|
|
|
|
|
(follow_fork_inferior): Push target on new inferior. Pass target
|
|
|
|
|
|
to add_thread_silent. Call exec_on_vfork. Handle target's
|
|
|
|
|
|
reference count.
|
|
|
|
|
|
(follow_fork): Adjust get_last_target_status call. Also consider
|
|
|
|
|
|
target.
|
|
|
|
|
|
(follow_exec): Push target on new inferior.
|
|
|
|
|
|
(struct execution_control_state) <target>: New field.
|
|
|
|
|
|
(user_visible_resume_target): New.
|
|
|
|
|
|
(do_target_resume): Call target_async.
|
|
|
|
|
|
(resume_1): Set target's threads_executing flag. Consider resume
|
|
|
|
|
|
target.
|
|
|
|
|
|
(commit_resume_all_targets): New.
|
|
|
|
|
|
(proceed): Also consider resume target. Skip threads of inferiors
|
|
|
|
|
|
with no execution. Commit resumtion in all targets.
|
|
|
|
|
|
(start_remote): Pass current inferior to wait_for_inferior.
|
|
|
|
|
|
(infrun_thread_stop_requested): Consider target as well. Pass
|
|
|
|
|
|
thread_info pointer to clear_inline_frame_state instead of ptid.
|
|
|
|
|
|
(infrun_thread_thread_exit): Consider target as well.
|
|
|
|
|
|
(random_pending_event_thread): New inferior parameter. Use it.
|
|
|
|
|
|
(do_target_wait): Rename to ...
|
|
|
|
|
|
(do_target_wait_1): ... this. Add inferior parameter, and pass it
|
|
|
|
|
|
down.
|
|
|
|
|
|
(threads_are_resumed_pending_p, do_target_wait): New.
|
|
|
|
|
|
(prepare_for_detach): Adjust calls.
|
|
|
|
|
|
(wait_for_inferior): New inferior parameter. Handle it. Use
|
|
|
|
|
|
do_target_wait_1 instead of do_target_wait.
|
|
|
|
|
|
(fetch_inferior_event): Adjust. Switch to representative
|
|
|
|
|
|
inferior. Pass target down.
|
|
|
|
|
|
(set_last_target_status): Add process_stratum_target parameter.
|
|
|
|
|
|
Save target in global.
|
|
|
|
|
|
(get_last_target_status): Add process_stratum_target parameter and
|
|
|
|
|
|
handle it.
|
|
|
|
|
|
(nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
|
|
|
|
|
|
(context_switch): Check inferior_ptid == null_ptid before calling
|
|
|
|
|
|
inferior_thread().
|
|
|
|
|
|
(get_inferior_stop_soon): Pass down target.
|
|
|
|
|
|
(wait_one): Rename to ...
|
|
|
|
|
|
(poll_one_curr_target): ... this.
|
|
|
|
|
|
(struct wait_one_event): New.
|
|
|
|
|
|
(wait_one): New.
|
|
|
|
|
|
(stop_all_threads): Adjust.
|
|
|
|
|
|
(handle_no_resumed, handle_inferior_event): Adjust to consider the
|
|
|
|
|
|
event's target.
|
|
|
|
|
|
(switch_back_to_stepped_thread): Also consider target.
|
|
|
|
|
|
(print_stop_event): Update.
|
|
|
|
|
|
(normal_stop): Update. Also consider the resume target.
|
|
|
|
|
|
* infrun.h (wait_for_inferior): Remove declaration.
|
|
|
|
|
|
(user_visible_resume_target): New declaration.
|
|
|
|
|
|
(get_last_target_status, set_last_target_status): New
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
* inline-frame.c (clear_inline_frame_state(ptid_t)): Add
|
|
|
|
|
|
process_stratum_target parameter, and use it.
|
|
|
|
|
|
(clear_inline_frame_state (thread_info*)): New.
|
|
|
|
|
|
* inline-frame.c (clear_inline_frame_state(ptid_t)): Add
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
(clear_inline_frame_state (thread_info*)): Declare.
|
|
|
|
|
|
* linux-fork.c (delete_checkpoint_command): Pass target down to
|
|
|
|
|
|
find_thread_ptid.
|
|
|
|
|
|
(checkpoint_command): Adjust.
|
|
|
|
|
|
* linux-nat.c (linux_nat_target::follow_fork): Switch to thread
|
|
|
|
|
|
instead of just tweaking inferior_ptid.
|
|
|
|
|
|
(linux_nat_switch_fork): Pass target down to thread_change_ptid.
|
|
|
|
|
|
(exit_lwp): Pass target down to find_thread_ptid.
|
|
|
|
|
|
(attach_proc_task_lwp_callback): Pass target down to
|
|
|
|
|
|
add_thread/set_running/set_executing.
|
|
|
|
|
|
(linux_nat_target::attach): Pass target down to
|
|
|
|
|
|
thread_change_ptid.
|
|
|
|
|
|
(get_detach_signal): Pass target down to find_thread_ptid.
|
|
|
|
|
|
Consider last target status's target.
|
|
|
|
|
|
(linux_resume_one_lwp_throw, resume_lwp)
|
|
|
|
|
|
(linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
|
|
|
|
|
|
(stop_wait_callback, save_stop_reason, linux_nat_filter_event)
|
|
|
|
|
|
(linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
|
|
|
|
|
|
(linux_nat_target::async_wait_fd): New.
|
|
|
|
|
|
(linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
|
|
|
|
|
|
target down.
|
|
|
|
|
|
* linux-nat.h (linux_nat_target::async_wait_fd): Declare.
|
|
|
|
|
|
* linux-tdep.c (get_thread_arch_regcache): Pass target down.
|
|
|
|
|
|
* linux-thread-db.c (struct thread_db_info::process_target): New
|
|
|
|
|
|
field.
|
|
|
|
|
|
(add_thread_db_info): Save target.
|
|
|
|
|
|
(get_thread_db_info): New process_stratum_target parameter. Also
|
|
|
|
|
|
match target.
|
|
|
|
|
|
(delete_thread_db_info): New process_stratum_target parameter.
|
|
|
|
|
|
Also match target.
|
|
|
|
|
|
(thread_from_lwp): Adjust to pass down target.
|
|
|
|
|
|
(thread_db_notice_clone): Pass down target.
|
|
|
|
|
|
(check_thread_db_callback): Pass down target.
|
|
|
|
|
|
(try_thread_db_load_1): Always push the thread_db target.
|
|
|
|
|
|
(try_thread_db_load, record_thread): Pass target down.
|
|
|
|
|
|
(thread_db_target::detach): Pass target down. Always unpush the
|
|
|
|
|
|
thread_db target.
|
|
|
|
|
|
(thread_db_target::wait, thread_db_target::mourn_inferior): Pass
|
|
|
|
|
|
target down. Always unpush the thread_db target.
|
|
|
|
|
|
(find_new_threads_callback, thread_db_find_new_threads_2)
|
|
|
|
|
|
(thread_db_target::update_thread_list): Pass target down.
|
|
|
|
|
|
(thread_db_target::pid_to_str): Pass current inferior down.
|
|
|
|
|
|
(thread_db_target::get_thread_local_address): Pass target down.
|
|
|
|
|
|
(thread_db_target::resume, maintenance_check_libthread_db): Pass
|
|
|
|
|
|
target down.
|
|
|
|
|
|
* nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
|
|
|
|
|
|
* procfs.c (procfs_target::procfs_init_inferior): Declare.
|
|
|
|
|
|
(proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
|
|
|
|
|
|
(procfs_init_inferior): Rename to ...
|
|
|
|
|
|
(procfs_target::procfs_init_inferior): ... this and adjust.
|
|
|
|
|
|
(procfs_target::create_inferior, procfs_notice_thread)
|
|
|
|
|
|
(procfs_do_thread_registers): Adjust.
|
|
|
|
|
|
* ppc-fbsd-tdep.c: Include "inferior.h".
|
|
|
|
|
|
(ppcfbsd_get_thread_local_address): Pass down target.
|
|
|
|
|
|
* proc-service.c (ps_xfer_memory): Switch current inferior and
|
|
|
|
|
|
program space as well.
|
|
|
|
|
|
(get_ps_regcache): Pass target down.
|
|
|
|
|
|
* process-stratum-target.c
|
|
|
|
|
|
(process_stratum_target::thread_address_space)
|
|
|
|
|
|
(process_stratum_target::thread_architecture): Pass target down.
|
|
|
|
|
|
* process-stratum-target.h
|
|
|
|
|
|
(process_stratum_target::threads_executing): New field.
|
|
|
|
|
|
(as_process_stratum_target): New.
|
|
|
|
|
|
* ravenscar-thread.c
|
|
|
|
|
|
(ravenscar_thread_target::update_inferior_ptid): Pass target down.
|
|
|
|
|
|
(ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
|
|
|
|
|
|
down.
|
|
|
|
|
|
* record-btrace.c (record_btrace_target::info_record): Adjust.
|
|
|
|
|
|
(record_btrace_target::record_method)
|
|
|
|
|
|
(record_btrace_target::record_is_replaying)
|
|
|
|
|
|
(record_btrace_target::fetch_registers)
|
|
|
|
|
|
(get_thread_current_frame_id, record_btrace_target::resume)
|
|
|
|
|
|
(record_btrace_target::wait, record_btrace_target::stop): Pass
|
|
|
|
|
|
target down.
|
|
|
|
|
|
* record-full.c (record_full_wait_1): Switch to event thread.
|
|
|
|
|
|
Pass target down.
|
|
|
|
|
|
* regcache.c (regcache::regcache)
|
|
|
|
|
|
(get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
|
|
|
|
|
|
process_stratum_target parameter and handle it.
|
|
|
|
|
|
(current_thread_target): New global.
|
|
|
|
|
|
(get_thread_regcache): Add process_stratum_target parameter and
|
|
|
|
|
|
handle it. Switch inferior before calling target method.
|
|
|
|
|
|
(get_thread_regcache): Pass target down.
|
|
|
|
|
|
(get_thread_regcache_for_ptid): Pass target down.
|
|
|
|
|
|
(registers_changed_ptid): Add process_stratum_target parameter and
|
|
|
|
|
|
handle it.
|
|
|
|
|
|
(registers_changed_thread, registers_changed): Pass target down.
|
|
|
|
|
|
(test_get_thread_arch_aspace_regcache): New.
|
|
|
|
|
|
(current_regcache_test): Define a couple local test_target_ops
|
|
|
|
|
|
instances and use them for testing.
|
|
|
|
|
|
(readwrite_regcache): Pass process_stratum_target parameter.
|
|
|
|
|
|
(cooked_read_test, cooked_write_test): Pass mock_target down.
|
|
|
|
|
|
* regcache.h (get_thread_regcache, get_thread_arch_regcache)
|
|
|
|
|
|
(get_thread_arch_aspace_regcache): Add process_stratum_target
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(regcache::target): New method.
|
|
|
|
|
|
(regcache::regcache, regcache::get_thread_arch_aspace_regcache)
|
|
|
|
|
|
(regcache::registers_changed_ptid): Add process_stratum_target
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
(regcache::m_target): New field.
|
|
|
|
|
|
(registers_changed_ptid): Add process_stratum_target parameter.
|
|
|
|
|
|
* remote.c (remote_state::supports_vCont_probed): New field.
|
|
|
|
|
|
(remote_target::async_wait_fd): New method.
|
|
|
|
|
|
(remote_unpush_and_throw): Add remote_target parameter.
|
|
|
|
|
|
(get_current_remote_target): Adjust.
|
|
|
|
|
|
(remote_target::remote_add_inferior): Push target.
|
|
|
|
|
|
(remote_target::remote_add_thread)
|
|
|
|
|
|
(remote_target::remote_notice_new_inferior)
|
|
|
|
|
|
(get_remote_thread_info): Pass target down.
|
|
|
|
|
|
(remote_target::update_thread_list): Skip threads of inferiors
|
|
|
|
|
|
bound to other targets. (remote_target::close): Don't discard
|
|
|
|
|
|
inferiors. (remote_target::add_current_inferior_and_thread)
|
|
|
|
|
|
(remote_target::process_initial_stop_replies)
|
|
|
|
|
|
(remote_target::start_remote)
|
|
|
|
|
|
(remote_target::remote_serial_quit_handler): Pass down target.
|
|
|
|
|
|
(remote_target::remote_unpush_target): New remote_target
|
|
|
|
|
|
parameter. Unpush the target from all inferiors.
|
|
|
|
|
|
(remote_target::remote_unpush_and_throw): New remote_target
|
|
|
|
|
|
parameter. Pass it down.
|
|
|
|
|
|
(remote_target::open_1): Check whether the current inferior has
|
|
|
|
|
|
execution instead of checking whether any inferior is live. Pass
|
|
|
|
|
|
target down.
|
|
|
|
|
|
(remote_target::remote_detach_1): Pass down target. Use
|
|
|
|
|
|
remote_unpush_target.
|
|
|
|
|
|
(extended_remote_target::attach): Pass down target.
|
|
|
|
|
|
(remote_target::remote_vcont_probe): Set supports_vCont_probed.
|
|
|
|
|
|
(remote_target::append_resumption): Pass down target.
|
|
|
|
|
|
(remote_target::append_pending_thread_resumptions)
|
|
|
|
|
|
(remote_target::remote_resume_with_hc, remote_target::resume)
|
|
|
|
|
|
(remote_target::commit_resume): Pass down target.
|
|
|
|
|
|
(remote_target::remote_stop_ns): Check supports_vCont_probed.
|
|
|
|
|
|
(remote_target::interrupt_query)
|
|
|
|
|
|
(remote_target::remove_new_fork_children)
|
|
|
|
|
|
(remote_target::check_pending_events_prevent_wildcard_vcont)
|
|
|
|
|
|
(remote_target::remote_parse_stop_reply)
|
|
|
|
|
|
(remote_target::process_stop_reply): Pass down target.
|
|
|
|
|
|
(first_remote_resumed_thread): New remote_target parameter. Pass
|
|
|
|
|
|
it down.
|
|
|
|
|
|
(remote_target::wait_as): Pass down target.
|
|
|
|
|
|
(unpush_and_perror): New remote_target parameter. Pass it down.
|
|
|
|
|
|
(remote_target::readchar, remote_target::remote_serial_write)
|
|
|
|
|
|
(remote_target::getpkt_or_notif_sane_1)
|
|
|
|
|
|
(remote_target::kill_new_fork_children, remote_target::kill): Pass
|
|
|
|
|
|
down target.
|
|
|
|
|
|
(remote_target::mourn_inferior): Pass down target. Use
|
|
|
|
|
|
remote_unpush_target.
|
|
|
|
|
|
(remote_target::core_of_thread)
|
|
|
|
|
|
(remote_target::remote_btrace_maybe_reopen): Pass down target.
|
|
|
|
|
|
(remote_target::pid_to_exec_file)
|
|
|
|
|
|
(remote_target::thread_handle_to_thread_info): Pass down target.
|
|
|
|
|
|
(remote_target::async_wait_fd): New.
|
|
|
|
|
|
* riscv-fbsd-tdep.c: Include "inferior.h".
|
|
|
|
|
|
(riscv_fbsd_get_thread_local_address): Pass down target.
|
|
|
|
|
|
* sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
|
|
|
|
|
|
* sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
|
|
|
|
|
|
(ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
|
|
|
|
|
|
Adjust.
|
|
|
|
|
|
* solib-spu.c (spu_skip_standalone_loader): Pass down target.
|
|
|
|
|
|
* solib-svr4.c (enable_break): Pass down target.
|
|
|
|
|
|
* spu-multiarch.c (parse_spufs_run): Pass down target.
|
|
|
|
|
|
* spu-tdep.c (spu2ppu_sniffer): Pass down target.
|
|
|
|
|
|
* target-delegates.c: Regenerate.
|
|
|
|
|
|
* target.c (g_target_stack): Delete.
|
|
|
|
|
|
(current_top_target): Return the current inferior's top target.
|
|
|
|
|
|
(target_has_execution_1): Refer to the passed-in inferior's top
|
|
|
|
|
|
target.
|
|
|
|
|
|
(target_supports_terminal_ours): Check whether the initial
|
|
|
|
|
|
inferior was already created.
|
|
|
|
|
|
(decref_target): New.
|
|
|
|
|
|
(target_stack::push): Incref/decref the target.
|
|
|
|
|
|
(push_target, push_target, unpush_target): Adjust.
|
|
|
|
|
|
(target_stack::unpush): Defref target.
|
|
|
|
|
|
(target_is_pushed): Return bool. Adjust to refer to the current
|
|
|
|
|
|
inferior's target stack.
|
|
|
|
|
|
(dispose_inferior): Delete, and inline parts ...
|
|
|
|
|
|
(target_preopen): ... here. Only dispose of the current inferior.
|
|
|
|
|
|
(target_detach): Hold strong target reference while detaching.
|
|
|
|
|
|
Pass target down.
|
|
|
|
|
|
(target_thread_name): Add assertion.
|
|
|
|
|
|
(target_resume): Pass down target.
|
|
|
|
|
|
(target_ops::beneath, find_target_at): Adjust to refer to the
|
|
|
|
|
|
current inferior's target stack.
|
|
|
|
|
|
(get_dummy_target): New.
|
|
|
|
|
|
(target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
|
|
|
|
|
|
has a thread running.
|
|
|
|
|
|
(initialize_targets): Rename to ...
|
|
|
|
|
|
(_initialize_target): ... this.
|
|
|
|
|
|
* target.h: Include "gdbsupport/refcounted-object.h".
|
|
|
|
|
|
(struct target_ops): Inherit refcounted_object.
|
|
|
|
|
|
(target_ops::shortname, target_ops::longname): Make const.
|
|
|
|
|
|
(target_ops::async_wait_fd): New method.
|
|
|
|
|
|
(decref_target): Declare.
|
|
|
|
|
|
(struct target_ops_ref_policy): New.
|
|
|
|
|
|
(target_ops_ref): New typedef.
|
|
|
|
|
|
(get_dummy_target): Declare function.
|
|
|
|
|
|
(target_is_pushed): Return bool.
|
|
|
|
|
|
* thread-iter.c (all_matching_threads_iterator::m_inf_matches)
|
|
|
|
|
|
(all_matching_threads_iterator::all_matching_threads_iterator):
|
|
|
|
|
|
Handle filter target.
|
|
|
|
|
|
* thread-iter.h (struct all_matching_threads_iterator, struct
|
|
|
|
|
|
all_matching_threads_range, class all_non_exited_threads_range):
|
|
|
|
|
|
Filter by target too. Remove explicit.
|
|
|
|
|
|
* thread.c (threads_executing): Delete.
|
|
|
|
|
|
(inferior_thread): Pass down current inferior.
|
|
|
|
|
|
(clear_thread_inferior_resources): Pass down thread pointer
|
|
|
|
|
|
instead of ptid_t.
|
|
|
|
|
|
(add_thread_silent, add_thread_with_info, add_thread): Add
|
|
|
|
|
|
process_stratum_target parameter. Use it for thread and inferior
|
|
|
|
|
|
searches.
|
|
|
|
|
|
(is_current_thread): New.
|
|
|
|
|
|
(thread_info::deletable): Use it.
|
|
|
|
|
|
(find_thread_ptid, thread_count, in_thread_list)
|
|
|
|
|
|
(thread_change_ptid, set_resumed, set_running): New
|
|
|
|
|
|
process_stratum_target parameter. Pass it down.
|
|
|
|
|
|
(set_executing): New process_stratum_target parameter. Pass it
|
|
|
|
|
|
down. Adjust reference to 'threads_executing'.
|
|
|
|
|
|
(threads_are_executing): New process_stratum_target parameter.
|
|
|
|
|
|
Adjust reference to 'threads_executing'.
|
|
|
|
|
|
(set_stop_requested, finish_thread_state): New
|
|
|
|
|
|
process_stratum_target parameter. Pass it down.
|
|
|
|
|
|
(switch_to_thread): Also match inferior.
|
|
|
|
|
|
(switch_to_thread): New process_stratum_target parameter. Pass it
|
|
|
|
|
|
down.
|
|
|
|
|
|
(update_threads_executing): Reimplement.
|
|
|
|
|
|
* top.c (quit_force): Pop targets from all inferior.
|
|
|
|
|
|
(gdb_init): Don't call initialize_targets.
|
|
|
|
|
|
* windows-nat.c (windows_nat_target) <get_windows_debug_event>:
|
|
|
|
|
|
Declare.
|
|
|
|
|
|
(windows_add_thread, windows_delete_thread): Adjust.
|
|
|
|
|
|
(get_windows_debug_event): Rename to ...
|
|
|
|
|
|
(windows_nat_target::get_windows_debug_event): ... this. Adjust.
|
|
|
|
|
|
* tracefile-tfile.c (tfile_target_open): Pass down target.
|
|
|
|
|
|
* gdbsupport/common-gdbthread.h (struct process_stratum_target):
|
|
|
|
|
|
Forward declare.
|
|
|
|
|
|
(switch_to_thread): Add process_stratum_target parameter.
|
|
|
|
|
|
* mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
|
|
|
|
|
|
parameter. Use it.
|
|
|
|
|
|
(mi_on_resume): Pass target down.
|
|
|
|
|
|
* nat/fork-inferior.c (startup_inferior): Add
|
|
|
|
|
|
process_stratum_target parameter. Pass it down.
|
|
|
|
|
|
* nat/fork-inferior.h (startup_inferior): Add
|
|
|
|
|
|
process_stratum_target parameter.
|
|
|
|
|
|
* python/py-threadevent.c (py_get_event_thread): Pass target down.
|
|
|
|
|
|
|
2020-01-10 21:05:54 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::start_remote): Don't set inferior_ptid
|
|
|
|
|
|
directly. Instead find the first thread in the thread list and
|
|
|
|
|
|
use switch_to_thread.
|
|
|
|
|
|
|
Fix reconnecting to a gdbserver already debugging multiple processes, I
The multi-target patch will change the remote target's behavior when:
- the current inferior is connected to an extended-remote target.
- the current inferior is attached to any process.
- some other inferior than than the current one is live.
In current master, we get:
(gdb) tar extended-remote :9999
A program is being debugged already. Kill it? (y or n)
While after multi-target, since each inferior may have its own target
connection, we'll get:
(gdb) tar extended-remote :9999
Already connected to a remote target. Disconnect? (y or n)
That change made gdb.server/extended-remote-restart.exp expose a gdb
bug, because it made "target remote", via gdb_reconnect, just
disconnect from the previous connection, while in current master that
command would kill the inferior before disconnecting. In turn, that
would make a multi-target gdb find processes already running under
control of gdbserver as soon as it reconnects, while in current master
there is never any process around when gdb reconnects, since they'd
all been killed prior to disconnection.
The bug this exposed is that remote_target::remote_add_inferior was
always reusing current_inferior() for the new process, even if the
current inferior was already bound to a process. In the testcase's
case, when we reconnect, the remote is debugging two processes. So
we'd bind the first remote process to the empty current inferior the
first time, and then bind the second remote process to the same
inferior again, essencially losing track of the first process. That
resulted in failed assertions when we look up the inferior for the
first process by PID. The fix is to still prefer binding to the
current inferior (so that plain "target remote" keeps doing what you'd
expect), but not reuse the current inferior if it is already bound to
a process.
This patch tweaks the test to explicitly disconnect before
reconnecting, to avoid GDB killing processes, thus making current GDB
behave the same as it will behave when the multi-target work lands.
That change alone without the GDB fix exposes the bug like so:
(gdb) PASS: gdb.server/extended-remote-restart.exp: kill: 0, follow-child 0: disconnect
target extended-remote localhost:2350
Remote debugging using localhost:2350
src/gdb/thread.c:93: internal-error: thread_info* inferior_thread(): Assertion `tp' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n)
The original bug that the testcase was written for was related to
killing, (git 9d4a934ce604 ("gdb: Fix assert for extended-remote
target (PR gdb/18050)")), but since the testcase tries reconnecting
with both explicitly killing and not explicitly killing, I think we're
covering the original bug with this testcase change.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* remote.c (remote_target::remote_add_inferior): Don't bind a
process to the current inferior if the current inferior is already
bound to a process.
gdb/testsuite/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* gdb.server/extended-remote-restart.exp (test_reload): Explicitly
disconnect before reconnecting.
2020-01-10 21:05:53 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::remote_add_inferior): Don't bind a
|
|
|
|
|
|
process to the current inferior if the current inferior is already
|
|
|
|
|
|
bound to a process.
|
|
|
|
|
|
|
2020-01-10 21:05:52 +01:00
|
|
|
|
2020-01-10 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
|
|
|
|
|
|
Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
|
|
|
|
|
|
If no process is specified, return null_ptid instead of
|
|
|
|
|
|
inferior_ptid.
|
|
|
|
|
|
(remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
|
|
|
|
|
|
TARGET_WAITKIND_SIGNALLED with no pid.
|
|
|
|
|
|
|
Tweak handling of remote errors in response to resumption packet
With current master, on a Fedora 27 machine with a kernel with buggy
watchpoint support, I see:
(gdb) PASS: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: hardware breakpoints work
continue
Continuing.
warning: Remote failure reply: E01
Remote communication error. Target disconnected.: Connection reset by peer.
(gdb) FAIL: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: watchpoints work
continue
The program is not being run.
(gdb) FAIL: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: breakpoint after the first fork (the program is no longer running)
The FAILs themselves aren't what's interesting here. What is
interesting is that with the main multi-target patch applied, I was getting this:
(gdb) PASS: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: hardware breakpoints work
continue
Continuing.
warning: Remote failure reply: E01
/home/pedro/brno/pedro/gdb/binutils-gdb-2/build/../src/gdb/inferior.c:285: internal-error: inferior* find_inferior_pid(process_stratum_target*, int): Assertion `pid != 0' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) FAIL: gdb.threads/watchpoint-fork.exp: parent: singlethreaded: watchpoints work (GDB internal error)
The problem is that in remote_target::wait_as, we're hitting this:
switch (buf[0])
{
case 'E': /* Error of some sort. */
/* We're out of sync with the target now. Did it continue or
not? Not is more likely, so report a stop. */
rs->waiting_for_stop_reply = 0;
warning (_("Remote failure reply: %s"), buf);
status->kind = TARGET_WAITKIND_STOPPED;
status->value.sig = GDB_SIGNAL_0;
break;
which leaves event_ptid as null_ptid. At the end of the function, we then reach:
else if (status->kind != TARGET_WAITKIND_EXITED
&& status->kind != TARGET_WAITKIND_SIGNALLED)
{
if (event_ptid != null_ptid)
record_currthread (rs, event_ptid);
else
event_ptid = inferior_ptid; <<<<< here
}
and the trouble is that with the multi-target patch, we'll get here
with inferior_ptid as null_ptid too. That is done exactly to find
these implicit assumptions that inferior_ptid is a good choice for
default thread, which isn't generaly true.
I first thought of fixing this in the "case 'E'" path, but, given that
this "event_ptid = inferior_ptid" path is also taken when the remote
target does not support threads at all, no thread-related packets or
extensions, it's better to fix it in latter path, to handle all
scenarios that miss reporting a thread.
That's what this patch does.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* remote.c (first_remote_resumed_thread): New.
(remote_target::wait_as): Use it as default event_ptid instead of
inferior_ptid.
2020-01-10 21:05:52 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (first_remote_resumed_thread): New.
|
|
|
|
|
|
(remote_target::wait_as): Use it as default event_ptid instead of
|
|
|
|
|
|
inferior_ptid.
|
|
|
|
|
|
|
2020-01-10 21:05:51 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
|
|
|
|
|
|
|
2020-01-10 21:05:50 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
|
|
|
|
|
|
not -1.
|
|
|
|
|
|
|
2020-01-10 21:05:49 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
|
|
|
|
|
|
ptid to get_last_target_status.
|
|
|
|
|
|
* break-catch-syscall.c (print_it_catch_syscall): Don't pass a
|
|
|
|
|
|
ptid to get_last_target_status.
|
|
|
|
|
|
* infcmd.c (continue_command): Don't pass a target_waitstatus to
|
|
|
|
|
|
get_last_target_status.
|
|
|
|
|
|
(info_program_command): Don't pass a target_waitstatus to
|
|
|
|
|
|
get_last_target_status.
|
|
|
|
|
|
* infrun.c (init_wait_for_inferior): Use
|
|
|
|
|
|
nullify_last_target_wait_ptid.
|
|
|
|
|
|
(get_last_target_status): Handle nullptr arguments.
|
|
|
|
|
|
(nullify_last_target_wait_ptid): Clear target_last_waitstatus.
|
|
|
|
|
|
(print_stop_event): Don't pass a ptid to get_last_target_status.
|
|
|
|
|
|
(normal_stop): Don't pass a ptid to get_last_target_status.
|
|
|
|
|
|
* infrun.h (get_last_target_status, set_last_target_status): Move
|
|
|
|
|
|
comments here and update.
|
|
|
|
|
|
(nullify_last_target_wait_ptid): Declare.
|
|
|
|
|
|
* linux-fork.c (fork_load_infrun_state): Remove local extern
|
|
|
|
|
|
declaration of nullify_last_target_wait_ptid.
|
|
|
|
|
|
* linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
|
|
|
|
|
|
to get_last_target_status.
|
|
|
|
|
|
|
2020-01-10 21:05:48 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbthread.h (scoped_restore_current_thread)
|
|
|
|
|
|
<dont_restore, restore, m_dont_restore>: Declare.
|
|
|
|
|
|
* thread.c (thread_alive): Add assertion. Return bool.
|
|
|
|
|
|
(switch_to_thread_if_alive): New.
|
|
|
|
|
|
(prune_threads): Switch inferior/thread.
|
|
|
|
|
|
(print_thread_info_1): Switch thread before calling target methods.
|
|
|
|
|
|
(scoped_restore_current_thread::restore): New, factored out from
|
|
|
|
|
|
...
|
|
|
|
|
|
(scoped_restore_current_thread::~scoped_restore_current_thread):
|
|
|
|
|
|
... this.
|
|
|
|
|
|
(scoped_restore_current_thread::scoped_restore_current_thread):
|
|
|
|
|
|
Add assertion.
|
|
|
|
|
|
(thread_apply_all_command, thread_select): Use
|
|
|
|
|
|
switch_to_thread_if_alive.
|
|
|
|
|
|
* infrun.c (proceed, restart_threads, handle_signal_stop)
|
|
|
|
|
|
(switch_back_to_stepped_thread): Switch current thread before
|
|
|
|
|
|
calling target methods.
|
|
|
|
|
|
|
2020-01-10 21:05:47 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* inferior.c (switch_to_inferior_no_thread): New function,
|
|
|
|
|
|
factored out from ...
|
|
|
|
|
|
(inferior_command): ... here.
|
|
|
|
|
|
* inferior.h (switch_to_inferior_no_thread): Declare.
|
|
|
|
|
|
* mi/mi-main.c (run_one_inferior): Use
|
|
|
|
|
|
switch_to_inferior_no_thread.
|
|
|
|
|
|
|
Delete unnecessary code from kill_command
I believe this comment:
/* Killing off the inferior can leave us with a core file. If
so, print the state we are left in. */
Referred to the fact that a decade ago, by design, GDB would let you
type "run" when debugging a core dump, keeping the core open. That
"run" would push a process_stratum target on the target stack for the
live process, and, the core would remain open -- we used to have a
core_stratum. When the live process was killed/detached or exited,
GDB would go back to debugging the core, since the core_stratum target
was now at the top of the stack. That design had a number of
problems, see here for example:
https://sourceware.org/ml/gdb-patches/2008-08/msg00290.html
In 2010, core_stratum was finaly eliminated and cores now have
process_stratum too, with commit c0edd9edadfe ("Make core files the
process_stratum."). Pushing a live process on the stack while you're
debugging a core discards the core completely.
I also thought that this might be in use with checkpoints, but it does
not -- "kill" when you have multiple checkpoints kills all the
checkpoints.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* infcmd.c (kill_command): Remove dead code.
2020-01-10 21:05:46 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* infcmd.c (kill_command): Remove dead code.
|
|
|
|
|
|
|
Don't check target is running in remote_target::mourn_inferior
I believe the tail end of remote_target::mourn_inferior is broken, and
it's been broken for too long to even bother trying to fix. Most
probably nobody needs it. If the code is reached and we find the
target is running, we'd need to resync the thread list, at least,
since generic_mourn_inferior got rid of all the threads in the
inferior, otherwise, we'd hit an assertion on the next call to
inferior_thread(), for example. A "correct" fix would probably
involve restarting the whole remote_target::start_remote requence,
exactly as if we had completely disconnected and reconnected from
scratch.
Note that regular stub debugging usually uses plain target remote, but
this code is only reachable in target extended-mode:
- The !remote_multi_process_p check means that it's only reacheable if
the stub does not support multi-process. I.e., there can only ever
be one live process.
- remote_target::mourn_inferior has this at the top:
/* In 'target remote' mode with one inferior, we close the connection. */
if (!rs->extended && number_of_live_inferiors () <= 1)
{
unpush_target (this);
/* remote_close takes care of doing most of the clean up. */
generic_mourn_inferior ();
return;
}
Which means that if we only had one live inferior (which for our
case, must be true), we'll have closed the connection already,
unless we're in extended-remote mode.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* remote.c (remote_target::mourn_inferior): No longer check
whether the target is running.
2020-01-10 21:05:45 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (remote_target::mourn_inferior): No longer check
|
|
|
|
|
|
whether the target is running.
|
|
|
|
|
|
|
Make target_ops::has_execution take an 'inferior *' instead of a ptid_t
With the multi-target work, each inferior will have its own target
stack, so to call a target method, we'll need to make sure that the
inferior in question is the current one, otherwise target->beneath()
calls will find the target beneath in the wrong inferior.
In some places, it's much more convenient to be able to check whether
an inferior has execution without having to switch to it in order to
call target_has_execution on the right inferior/target stack, to avoid
side effects with switching inferior/thread/program space.
The current target_ops::has_execution method takes a ptid_t as
parameter, which, in a multi-target world, isn't sufficient to
identify the target. This patch prepares to address that, by changing
the parameter to an inferior pointer instead. From the inferior,
we'll be able to query its target stack to tell which target is
beneath.
Also adds a new inferior::has_execution() method to make callers a bit
more natural to read.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* corelow.c (core_target::has_execution): Change parameter type to
inferior pointer.
* inferior.c (number_of_live_inferiors): Use
inferior::has_execution instead of target_has_execution_1.
* inferior.h (inferior::has_execution): New.
* linux-thread-db.c (thread_db_target::update_thread_list): Use
inferior::has_execution instead of target_has_execution_1.
* process-stratum-target.c
(process_stratum_target::has_execution): Change parameter type to
inferior pointer. Check the inferior's PID instead of
inferior_ptid.
* process-stratum-target.h
(process_stratum_target::has_execution): Change parameter type to
inferior pointer.
* record-full.c (record_full_core_target::has_execution): Change
parameter type to inferior pointer.
* target.c (target_has_execution_1): Change parameter type to
inferior pointer.
(target_has_execution_current): Adjust.
* target.h (target_ops::has_execution): Change parameter type to
inferior pointer.
(target_has_execution_1): Change parameter type to inferior
pointer. Change return type to bool.
* tracefile.h (tracefile_target::has_execution): Change parameter
type to inferior pointer.
2020-01-10 21:05:44 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* corelow.c (core_target::has_execution): Change parameter type to
|
|
|
|
|
|
inferior pointer.
|
|
|
|
|
|
* inferior.c (number_of_live_inferiors): Use
|
|
|
|
|
|
inferior::has_execution instead of target_has_execution_1.
|
|
|
|
|
|
* inferior.h (inferior::has_execution): New.
|
|
|
|
|
|
* linux-thread-db.c (thread_db_target::update_thread_list): Use
|
|
|
|
|
|
inferior::has_execution instead of target_has_execution_1.
|
|
|
|
|
|
* process-stratum-target.c
|
|
|
|
|
|
(process_stratum_target::has_execution): Change parameter type to
|
|
|
|
|
|
inferior pointer. Check the inferior's PID instead of
|
|
|
|
|
|
inferior_ptid.
|
|
|
|
|
|
* process-stratum-target.h
|
|
|
|
|
|
(process_stratum_target::has_execution): Change parameter type to
|
|
|
|
|
|
inferior pointer.
|
|
|
|
|
|
* record-full.c (record_full_core_target::has_execution): Change
|
|
|
|
|
|
parameter type to inferior pointer.
|
|
|
|
|
|
* target.c (target_has_execution_1): Change parameter type to
|
|
|
|
|
|
inferior pointer.
|
|
|
|
|
|
(target_has_execution_current): Adjust.
|
|
|
|
|
|
* target.h (target_ops::has_execution): Change parameter type to
|
|
|
|
|
|
inferior pointer.
|
|
|
|
|
|
(target_has_execution_1): Change parameter type to inferior
|
|
|
|
|
|
pointer. Change return type to bool.
|
|
|
|
|
|
* tracefile.h (tracefile_target::has_execution): Change parameter
|
|
|
|
|
|
type to inferior pointer.
|
|
|
|
|
|
|
2020-01-10 21:05:43 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* exceptions.c (print_flush): Remove current_top_target() check.
|
|
|
|
|
|
|
2020-01-10 21:05:42 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* remote.c (show_remote_exec_file): Show the current inferior's
|
|
|
|
|
|
exec-file instead of the command variable's value.
|
|
|
|
|
|
|
2020-01-10 21:05:41 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* record-full.c (record_full_resume_ptid): New global.
|
|
|
|
|
|
(record_full_target::resume): Set it.
|
|
|
|
|
|
(record_full_wait_1): Use record_full_resume_ptid instead of
|
|
|
|
|
|
inferior_ptid.
|
|
|
|
|
|
|
Preserve selected thread in all-stop w/ background execution
In non-stop mode, if you resume the program in the background (with
"continue&", for example), then gdb makes sure to not switch the
current thread behind your back. That means that you can be sure that
the commands you type apply to the thread you selected, even if some
other thread that was running in the background hits some event just
while you're typing.
In all-stop mode, however, if you resume the program in the
background, gdb let's the current thread switch behind your back.
This is bogus, of course. All-stop and non-stop background
resumptions should behave the same.
This patch fixes that, and adds a testcase that exposes the bad
behavior in current master.
The fork-running-state.exp changes are necessary because that
preexisting testcase was expecting the old behavior:
Before:
continue &
Continuing.
(gdb)
[Attaching after process 8199 fork to child process 8203]
[New inferior 2 (process 8203)]
info threads
Id Target Id Frame
1.1 process 8199 "fork-running-st" (running)
* 2.1 process 8203 "fork-running-st" (running)
(gdb)
After:
continue &
Continuing.
(gdb)
[Attaching after process 24660 fork to child process 24664]
[New inferior 2 (process 24664)]
info threads
Id Target Id Frame
* 1.1 process 24660 "fork-running-st" (running)
2.1 process 24664 "fork-running-st" (running)
(gdb)
Here we see that before this patch GDB switches current inferior to
the new inferior behind the user's back, as a side effect of handling
the fork.
The delete_exited_threads call in inferior_appeared is there to fix an
issue that Baris found in a previous version of this patch. The
fetch_inferior_event change increases the refcount of the current
thread, and in case the fetched inferior event denotes a thread exit,
the thread will not be deleted right away. A non-deleted but exited
thread stays in the inferior's thread list. This, in turn, causes the
"init_thread_list" call in inferior.c to be skipped. A consequence is
that the global thread ID counter is not restarted if the current
thread exits, and then the inferior is restarted:
(gdb) start
Temporary breakpoint 1 at 0x4004d6: file main.c, line 21.
Starting program: /tmp/main
Temporary breakpoint 1, main () at main.c:21
21 foo ();
(gdb) info threads -gid
Id GId Target Id Frame
* 1 1 process 16106 "main" main () at main.c:21
(gdb) c
Continuing.
[Inferior 1 (process 16106) exited normally]
(gdb) start
Temporary breakpoint 2 at 0x4004d6: file main.c, line 21.
Starting program: /tmp/main
Temporary breakpoint 2, main () at main.c:21
21 foo ();
(gdb) info threads -gid
Id GId Target Id Frame
* 1 2 process 16138 "main" main () at main.c:21
^^^
Notice that GId == 2 above. It should have been "1" instead.
The new tids-git-reset.exp testcase exercises the problem above.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* gdbthread.h (scoped_restore_current_thread)
<dont_restore, restore, m_dont_restore>: Declare.
* thread.c (thread_alive): Add assertion. Return bool.
(switch_to_thread_if_alive): New.
(prune_threads): Switch inferior/thread.
(print_thread_info_1): Switch thread before calling target methods.
(scoped_restore_current_thread::restore): New, factored out from
...
(scoped_restore_current_thread::~scoped_restore_current_thread):
... this.
(scoped_restore_current_thread::scoped_restore_current_thread):
Add assertion.
(thread_apply_all_command, thread_select): Use
switch_to_thread_if_alive.
gdb/testsuite/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* gdb.base/fork-running-state.exp (do_test): Adjust expected
output.
* gdb.threads/async.c: New.
* gdb.threads/async.exp: New.
* gdb.multi/tids-gid-reset.c: New.
* gdb.multi/tids-gid-reset.exp: New.
2020-01-10 21:05:41 +01:00
|
|
|
|
2020-01-10 Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbthread.h (scoped_restore_current_thread)
|
|
|
|
|
|
<dont_restore, restore, m_dont_restore>: Declare.
|
|
|
|
|
|
* thread.c (thread_alive): Add assertion. Return bool.
|
|
|
|
|
|
(switch_to_thread_if_alive): New.
|
|
|
|
|
|
(prune_threads): Switch inferior/thread.
|
|
|
|
|
|
(print_thread_info_1): Switch thread before calling target methods.
|
|
|
|
|
|
(scoped_restore_current_thread::restore): New, factored out from
|
|
|
|
|
|
...
|
|
|
|
|
|
(scoped_restore_current_thread::~scoped_restore_current_thread):
|
|
|
|
|
|
... this.
|
|
|
|
|
|
(scoped_restore_current_thread::scoped_restore_current_thread):
|
|
|
|
|
|
Add assertion.
|
|
|
|
|
|
(thread_apply_all_command, thread_select): Use
|
|
|
|
|
|
switch_to_thread_if_alive.
|
|
|
|
|
|
|
2020-01-10 20:30:28 +01:00
|
|
|
|
2020-01-10 George Barrett <bob@bob131.so>
|
|
|
|
|
|
|
|
|
|
|
|
* stap-probe.c (stap_modify_semaphore): Don't check for null
|
|
|
|
|
|
semaphores.
|
|
|
|
|
|
(stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
|
|
|
|
|
|
for null semaphores.
|
|
|
|
|
|
|
2020-01-07 12:39:17 +01:00
|
|
|
|
2020-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
|
|
|
|
|
|
all source windows, and maintain horizontal scroll status while
|
|
|
|
|
|
doing so.
|
|
|
|
|
|
|
2019-12-23 00:52:56 +01:00
|
|
|
|
2020-01-09 Tom Tromey <tom@tromey.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR tui/18932:
|
|
|
|
|
|
* tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
|
|
|
|
|
|
update_source_window, not print_source_lines.
|
|
|
|
|
|
|
2020-01-07 01:41:08 +01:00
|
|
|
|
2020-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui.c (tui_enable): Register tui hooks after calling
|
|
|
|
|
|
tui_display_main.
|
|
|
|
|
|
|
2019-12-18 19:06:43 +01:00
|
|
|
|
2020-01-09 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
|
|
|
|
|
|
|
2020-01-08 22:55:03 +01:00
|
|
|
|
2020-01-08 Simon Marchi <simon.marchi@efficios.com>
|
|
|
|
|
|
|
|
|
|
|
|
* thread.c (print_thread_info_1): Fix indentation.
|
|
|
|
|
|
|
2020-01-08 02:10:40 +01:00
|
|
|
|
2020-01-09 Christian Biesinger <cbiesinger@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
* symtab.c (general_symbol_info::compute_and_set_names): Move the
|
|
|
|
|
|
unique_xmalloc_ptr outside the if to always free the demangled name.
|
|
|
|
|
|
|
Change section_offsets to a std::vector
This changes section_offsets to be specialization of a std::vector and
updates all the users. It also removes the ANOFFSET and
SIZEOF_N_SECTION_OFFSETS macros.
Most of this is just a generic sort of cleanup, that reduces the
number of lines of code. However, a couple spots were doing weird
things.
objfile_relocate did:
- std::vector<struct section_offsets>
- new_debug_offsets (SIZEOF_N_SECTION_OFFSETS (debug_objfile->num_sections));
... which seems to greatly over-estimate the number of elements
needed.
This appeared in set_objfile_default_section_offset:
- std::vector<struct section_offsets> offsets (objf->num_sections,
- { { offset } });
... which makes sense due to type safety, but is also actively
confusing given that section_offsets was previously also a kind of
vector type.
Tested on x86-64 Fedora 30.
gdb/ChangeLog
2020-01-08 Tom Tromey <tromey@adacore.com>
* xcoffread.c (enter_line_range, read_xcoff_symtab)
(process_xcoff_symbol, xcoff_symfile_offsets): Update.
* symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
(struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
Remove.
(section_offsets): New typedef.
* symtab.c (fixup_section, get_msymbol_address): Update.
* symmisc.c (dump_msymbols): Update.
* symfile.h (relative_addr_info_to_section_offsets)
(symfile_map_offsets_to_segments): Update.
* symfile.c (build_section_addr_info_from_objfile)
(init_objfile_sect_indices): Update.
(struct place_section_arg): Change type of "offsets".
(place_section): Update.
(relative_addr_info_to_section_offsets): Change type of
"section_offsets". Remove "num_sections" parameter.
(default_symfile_offsets, syms_from_objfile_1)
(set_objfile_default_section_offset): Update.
(reread_symbols): No need to preserve section offsets by hand.
(symfile_map_offsets_to_segments): Change type of "offsets".
* stap-probe.c (relocate_address): Update.
* stabsread.h (process_one_symbol): Update.
* solib-target.c (struct lm_info_target) <offsets>: Change type.
(solib_target_relocate_section_addresses): Update.
* solib-svr4.c (enable_break, svr4_relocate_main_executable):
Update.
* solib-frv.c (frv_relocate_main_executable): Update.
* solib-dsbt.c (dsbt_relocate_main_executable): Update.
* solib-aix.c (solib_aix_get_section_offsets): Change return
type.
(solib_aix_solib_create_inferior_hook): Update.
* remote.c (remote_target::get_offsets): Update.
* psymtab.c (find_pc_sect_psymtab): Update.
* psympriv.h (struct partial_symbol) <address, text_low,
text_high>: Update.
* objfiles.h (obj_section_offset): Update.
(struct objfile) <section_offsets>: Change type.
<num_sections>: Remove.
(objfile_relocate): Update.
* objfiles.c (entry_point_address_query): Update
(relocate_one_symbol): Change type of "section_offsets".
(objfile_relocate1, objfile_relocate1): Change type of
"new_offsets".
(objfile_rebase1): Update.
* mipsread.c (mipscoff_symfile_read): Update.
(read_alphacoff_dynamic_symtab): Remove "section_offsets"
parameter.
* mdebugread.c (parse_symbol): Change type of "section_offsets".
(parse_external, psymtab_to_symtab_1): Update.
* machoread.c (macho_symfile_offsets): Update.
* ia64-tdep.c (ia64_find_unwind_table): Update.
* hppa-tdep.c (read_unwind_info): Update.
* hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
* dwarf2read.c (create_addrmap_from_index)
(create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
(process_psymtab_comp_unit_reader, add_partial_symbol)
(add_partial_subprogram, process_full_comp_unit)
(read_file_scope, read_func_scope, read_lexical_block_scope)
(read_call_site_scope, dwarf2_rnglists_process)
(dwarf2_ranges_process, dwarf2_ranges_read)
(dwarf_decode_lines_1, var_decode_location, new_symbol)
(dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
Update.
* dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
Update.
* dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
* dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
(process_one_symbol): Change type of "section_offsets".
* ctfread.c (get_objfile_text_range): Update.
* coffread.c (coff_symtab_read, enter_linenos)
(process_coff_symbol): Update.
* coff-pe-read.c (add_pe_forwarded_sym): Update.
* amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
Change-Id: I147eb967e9b44d82f4048039de7bb44b80cd72fb
2020-01-06 22:34:52 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (enter_line_range, read_xcoff_symtab)
|
|
|
|
|
|
(process_xcoff_symbol, xcoff_symfile_offsets): Update.
|
|
|
|
|
|
* symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
|
|
|
|
|
|
(struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
|
|
|
|
|
|
Remove.
|
|
|
|
|
|
(section_offsets): New typedef.
|
|
|
|
|
|
* symtab.c (fixup_section, get_msymbol_address): Update.
|
|
|
|
|
|
* symmisc.c (dump_msymbols): Update.
|
|
|
|
|
|
* symfile.h (relative_addr_info_to_section_offsets)
|
|
|
|
|
|
(symfile_map_offsets_to_segments): Update.
|
|
|
|
|
|
* symfile.c (build_section_addr_info_from_objfile)
|
|
|
|
|
|
(init_objfile_sect_indices): Update.
|
|
|
|
|
|
(struct place_section_arg): Change type of "offsets".
|
|
|
|
|
|
(place_section): Update.
|
|
|
|
|
|
(relative_addr_info_to_section_offsets): Change type of
|
|
|
|
|
|
"section_offsets". Remove "num_sections" parameter.
|
|
|
|
|
|
(default_symfile_offsets, syms_from_objfile_1)
|
|
|
|
|
|
(set_objfile_default_section_offset): Update.
|
|
|
|
|
|
(reread_symbols): No need to preserve section offsets by hand.
|
|
|
|
|
|
(symfile_map_offsets_to_segments): Change type of "offsets".
|
|
|
|
|
|
* stap-probe.c (relocate_address): Update.
|
|
|
|
|
|
* stabsread.h (process_one_symbol): Update.
|
|
|
|
|
|
* solib-target.c (struct lm_info_target) <offsets>: Change type.
|
|
|
|
|
|
(solib_target_relocate_section_addresses): Update.
|
|
|
|
|
|
* solib-svr4.c (enable_break, svr4_relocate_main_executable):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* solib-frv.c (frv_relocate_main_executable): Update.
|
|
|
|
|
|
* solib-dsbt.c (dsbt_relocate_main_executable): Update.
|
|
|
|
|
|
* solib-aix.c (solib_aix_get_section_offsets): Change return
|
|
|
|
|
|
type.
|
|
|
|
|
|
(solib_aix_solib_create_inferior_hook): Update.
|
|
|
|
|
|
* remote.c (remote_target::get_offsets): Update.
|
|
|
|
|
|
* psymtab.c (find_pc_sect_psymtab): Update.
|
|
|
|
|
|
* psympriv.h (struct partial_symbol) <address, text_low,
|
|
|
|
|
|
text_high>: Update.
|
|
|
|
|
|
* objfiles.h (obj_section_offset): Update.
|
|
|
|
|
|
(struct objfile) <section_offsets>: Change type.
|
|
|
|
|
|
<num_sections>: Remove.
|
|
|
|
|
|
(objfile_relocate): Update.
|
|
|
|
|
|
* objfiles.c (entry_point_address_query): Update
|
|
|
|
|
|
(relocate_one_symbol): Change type of "section_offsets".
|
|
|
|
|
|
(objfile_relocate1, objfile_relocate1): Change type of
|
|
|
|
|
|
"new_offsets".
|
|
|
|
|
|
(objfile_rebase1): Update.
|
|
|
|
|
|
* mipsread.c (mipscoff_symfile_read): Update.
|
|
|
|
|
|
(read_alphacoff_dynamic_symtab): Remove "section_offsets"
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
* mdebugread.c (parse_symbol): Change type of "section_offsets".
|
|
|
|
|
|
(parse_external, psymtab_to_symtab_1): Update.
|
|
|
|
|
|
* machoread.c (macho_symfile_offsets): Update.
|
|
|
|
|
|
* ia64-tdep.c (ia64_find_unwind_table): Update.
|
|
|
|
|
|
* hppa-tdep.c (read_unwind_info): Update.
|
|
|
|
|
|
* hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
|
|
|
|
|
|
* dwarf2read.c (create_addrmap_from_index)
|
|
|
|
|
|
(create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
|
|
|
|
|
|
(process_psymtab_comp_unit_reader, add_partial_symbol)
|
|
|
|
|
|
(add_partial_subprogram, process_full_comp_unit)
|
|
|
|
|
|
(read_file_scope, read_func_scope, read_lexical_block_scope)
|
|
|
|
|
|
(read_call_site_scope, dwarf2_rnglists_process)
|
|
|
|
|
|
(dwarf2_ranges_process, dwarf2_ranges_read)
|
|
|
|
|
|
(dwarf_decode_lines_1, var_decode_location, new_symbol)
|
|
|
|
|
|
(dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
|
|
|
|
|
|
* dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
|
|
|
|
|
|
(process_one_symbol): Change type of "section_offsets".
|
|
|
|
|
|
* ctfread.c (get_objfile_text_range): Update.
|
|
|
|
|
|
* coffread.c (coff_symtab_read, enter_linenos)
|
|
|
|
|
|
(process_coff_symbol): Update.
|
|
|
|
|
|
* coff-pe-read.c (add_pe_forwarded_sym): Update.
|
|
|
|
|
|
* amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
|
|
|
|
|
|
|
2019-10-31 17:46:18 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (parse_macro_definition): Use std::string.
|
|
|
|
|
|
(parse_macro_definition): Likewise.
|
|
|
|
|
|
|
2019-10-31 17:37:35 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (abbrev_table_read_table): Use std::vector.
|
|
|
|
|
|
(ATTR_ALLOC_CHUNK): Remove.
|
|
|
|
|
|
|
2019-10-31 17:34:40 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
|
|
|
|
|
|
|
2019-10-31 17:31:28 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
|
|
|
|
|
|
(dwarf2_compute_name, open_dwo_file): Likewise.
|
|
|
|
|
|
(process_enumeration_scope): Use std::vector.
|
|
|
|
|
|
(guess_partial_die_structure_name): Use unique_xmalloc_ptr.
|
|
|
|
|
|
(partial_die_info::fixup, dwarf2_start_subfile)
|
|
|
|
|
|
(guess_full_die_structure_name, dwarf2_name): Likewise.
|
|
|
|
|
|
(determine_prefix): Update.
|
|
|
|
|
|
(guess_full_die_structure_name): Make return type const.
|
|
|
|
|
|
(partial_die_full_name): Return unique_xmalloc_ptr.
|
|
|
|
|
|
(DW_FIELD_ALLOC_CHUNK): Remove.
|
|
|
|
|
|
|
2019-12-19 19:35:22 +01:00
|
|
|
|
2020-01-07 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR build/24937:
|
|
|
|
|
|
* stap-probe.c (class stap_static_probe_ops): Add constructor.
|
|
|
|
|
|
|
2019-12-29 23:26:41 +01:00
|
|
|
|
2020-01-02 Jon Turney <jon.turney@dronecode.org.uk>
|
|
|
|
|
|
|
|
|
|
|
|
* cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
|
|
|
|
|
|
|
2019-12-26 21:56:01 +01:00
|
|
|
|
2020-01-06 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* stack.c (print_frame_info): Move disassemble_next_line code
|
|
|
|
|
|
inside source_print block.
|
|
|
|
|
|
|
2020-01-06 20:54:21 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbsupport/gdb_wait.c: Include <signal.h> instead of
|
|
|
|
|
|
gdb/signals.h, as we are now using native signal symbols.
|
|
|
|
|
|
|
2020-01-06 15:27:32 +01:00
|
|
|
|
2020-01-06 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
|
|
|
|
|
|
overflow by an early check of content vs threshold.
|
|
|
|
|
|
* tui/tui-source.c (tui_source_window::line_is_displayed):
|
|
|
|
|
|
Likewise.
|
|
|
|
|
|
|
2020-01-06 20:25:23 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
|
|
|
|
|
|
|
2020-01-02 01:25:56 +01:00
|
|
|
|
2020-01-02 Jon Turney <jon.turney@dronecode.org.uk>
|
|
|
|
|
|
|
|
|
|
|
|
* coff-pe-read.c (read_pe_exported_syms): Don't try to read the
|
|
|
|
|
|
export table if no section contains it's RVA.
|
|
|
|
|
|
|
2020-01-06 19:22:15 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
|
|
|
|
|
|
|
2019-12-22 14:58:22 +01:00
|
|
|
|
2020-01-06 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* source.c (print_source_lines_base): Set last_line_listed.
|
|
|
|
|
|
|
2020-01-06 13:54:18 +01:00
|
|
|
|
2020-01-06 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-disasm.c: Remove trailing spaces.
|
|
|
|
|
|
|
2020-01-06 12:51:54 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
|
|
|
|
|
|
* windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
|
|
|
|
|
|
(windows_gdb_signal_to_target): New function, uses the above
|
|
|
|
|
|
enumeration to convert GDB internal signal codes to equivalent
|
|
|
|
|
|
Windows codes.
|
|
|
|
|
|
(windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
|
|
|
|
|
|
* windows-nat.c: Include "gdb_wait.h".
|
|
|
|
|
|
(get_windows_debug_event): Extract the fatal exception from the
|
|
|
|
|
|
exit status and convert to the equivalent Posix signal number.
|
|
|
|
|
|
* cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
|
|
|
|
|
|
possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
|
|
|
|
|
|
* gdbsupport/gdb_wait.c: New file, implements
|
|
|
|
|
|
windows_status_to_termsig.
|
|
|
|
|
|
* gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
|
|
|
|
|
|
(WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
|
|
|
|
|
|
|
2019-12-23 00:45:31 +01:00
|
|
|
|
2020-01-05 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
|
|
|
|
|
|
show_layout.
|
|
|
|
|
|
|
2020-01-03 20:08:16 +01:00
|
|
|
|
2020-01-05 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-linux-nat.c
|
|
|
|
|
|
(aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
|
|
|
|
|
|
and bfd_mach_aarch64.
|
|
|
|
|
|
|
2019-12-15 17:58:16 +01:00
|
|
|
|
2020-01-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
|
|
|
|
|
|
|
|
|
|
|
|
* ui-file.c (stdio_file::can_emit_style_escape)
|
|
|
|
|
|
(tee_file::can_emit_style_escape): Ensure style is used also on
|
|
|
|
|
|
gdb_stderr when gdb_stderr is a tty supporting styling, similarly
|
|
|
|
|
|
to gdb_stdout.
|
|
|
|
|
|
* main.c (set_gdb_data_directory): Use file style to output the
|
|
|
|
|
|
warning that the given pathname is not a directory.
|
|
|
|
|
|
* top.c (show_history_filename, gdb_safe_append_history)
|
|
|
|
|
|
(show_gdb_datadir): Use file style.
|
|
|
|
|
|
|
2019-12-27 13:41:58 +01:00
|
|
|
|
2020-01-03 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* solib-target.c (struct lm_info_target):
|
|
|
|
|
|
Change offsets to be a unique_xmalloc_ptr.
|
|
|
|
|
|
(solib_target_relocate_section_addresses): Update.
|
|
|
|
|
|
|
2019-12-24 13:14:01 +01:00
|
|
|
|
2020-01-03 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-nat.c (windows_clear_solib): Free so_list linked list.
|
|
|
|
|
|
|
2020-01-03 09:16:38 +01:00
|
|
|
|
2020-01-03 Bernd Edlinger <bernd.edlinger@hotmail.de>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS (Write After Approval): Add myself.
|
|
|
|
|
|
|
2019-12-30 19:47:10 +01:00
|
|
|
|
2020-01-02 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* proc-service.c (get_ps_regcache): Remove reference to obsolete
|
|
|
|
|
|
Cell BE architecture.
|
|
|
|
|
|
* target.h (struct target_ops) <thread_architecture>: Likewise.
|
|
|
|
|
|
|
2019-12-30 17:01:02 +01:00
|
|
|
|
2020-01-01 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in: Use INSTALL_PROGRAM_ENV.
|
|
|
|
|
|
|
2020-01-01 13:00:28 +01:00
|
|
|
|
2020-01-01 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS (Write After Approval): Add myself.
|
|
|
|
|
|
|
2020-01-01 07:37:10 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbarch.sh: Update copyright year range of generated files.
|
|
|
|
|
|
|
2020-01-01 07:20:01 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
Update copyright year range in all GDB files.
|
|
|
|
|
|
|
2020-01-01 07:12:57 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copyright.py: Convert to Python 3.
|
|
|
|
|
|
|
2020-01-01 06:19:14 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copyright.py: Adapt after move of gnulib directory from gdb
|
|
|
|
|
|
directory to toplevel directory.
|
|
|
|
|
|
|
2020-01-01 06:08:08 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copyright.py (main): Exit if run from the wrong directory.
|
|
|
|
|
|
|
2020-01-01 05:43:08 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* top.c (print_gdb_version): Change copyright year to 2020.
|
|
|
|
|
|
|
2020-01-01 05:40:23 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
2019-12-30 17:11:32 +01:00
|
|
|
|
|
2020-01-01 05:40:23 +01:00
|
|
|
|
* config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
|
2019-12-30 17:11:32 +01:00
|
|
|
|
|
2020-01-01 05:40:23 +01:00
|
|
|
|
For older changes see ChangeLog-2019.
|
1999-04-16 03:35:26 +02:00
|
|
|
|
|
|
|
|
|
|
Local Variables:
|
|
|
|
|
|
mode: change-log
|
|
|
|
|
|
left-margin: 8
|
|
|
|
|
|
fill-column: 74
|
|
|
|
|
|
version-control: never
|
2007-08-10 00:44:38 +02:00
|
|
|
|
coding: utf-8
|
1999-04-16 03:35:26 +02:00
|
|
|
|
End:
|
